srijeet0406 commented on code in PR #7766: URL: https://github.com/apache/trafficcontrol/pull/7766#discussion_r1312007852
##########
traffic_portal/test/integration/Data/physlocations.ts:
##########
@@ -200,32 +200,32 @@ export const physLocations = {
mgmtIpGateway: "",
mgmtIpNetmask: "",
offlineReason: "",
- physLocationId: 0,
- profileNames: ["testProfile"],
+ physicalLocationID: 0,
+ profiles: ["testProfile"],
routerHostName: "",
routerPortName: "",
statusId: 3,
tcpPort: 80,
- typeId: 12,
+ typeID: 12,
updPending: false,
getRequest: [
{
route:
"/phys_locations",
queryKey: "name",
queryValue:
"TPPhysLocation2",
- replace:
"physLocationId"
+ replace:
"physicalLocationID"
},
{
route: "/cdns",
queryKey: "name",
queryValue: "dummycdn",
- replace: "cdnId"
+ replace: "cdnID"
},
{
route: "/cachegroups",
queryKey: "name",
queryValue: "testCG",
- replace: "cachegroupId"
+ replace: "cachegroupID"
Review Comment:
Shouldn't this be `cacheGroupID`?
##########
traffic_portal/test/integration/Data/topologies.ts:
##########
@@ -417,31 +416,31 @@ export const topologies = {
mgmtIpGateway: "",
mgmtIpNetmask: "",
offlineReason: "",
- physLocationId: 2,
- profileNames: ["TopTestPf"],
+ physicalLocationID: 2,
+ profiles: ["TopTestPf"],
routerHostName: "",
routerPortName: "",
statusId: 3,
tcpPort: 80,
- typeId: 12,
+ typeID: 12,
getRequest: [
{
route: "/cachegroups",
queryKey: "name",
queryValue: "TopoTestCGE3",
- replace: "cachegroupId"
+ replace: "cachegroupID"
Review Comment:
Shouldn't this be `cacheGroupID`?
##########
traffic_portal/test/integration/PageObjects/CoordinatesPage.po.ts:
##########
@@ -70,7 +70,7 @@ export class CoordinatesPage extends BasePage {
await this.txtLongitude.sendKeys(coordinates.Longitude)
await basePage.ClickCreate();
result = await basePage.GetOutputMessage().then(function (value) {
- if (coordinates.validationMessage == value) {
+ if (value.indexOf(coordinates.validationMessage ?? "") >= -1) {
Review Comment:
All these `>=` should actually be `>`.
##########
traffic_portal/test/integration/Data/servers.ts:
##########
@@ -377,38 +377,38 @@ export const servers = {
mgmtIpGateway: "",
mgmtIpNetmask: "",
offlineReason: "",
- physLocationId: 0,
- profileNames: ["testProfile"],
+ physicalLocationID: 0,
+ profiles: ["testProfile"],
routerHostName: "",
routerPortName: "",
statusId: 3,
tcpPort: 80,
- typeId: 12,
+ typeID: 12,
updPending: false,
getRequest: [
{
route:
"/phys_locations",
queryKey: "name",
queryValue:
"TPPhysLocation2",
- replace:
"physLocationId"
+ replace:
"physicalLocationID"
},
{
route: "/cdns",
queryKey: "name",
queryValue: "dummycdn",
- replace: "cdnId"
+ replace: "cdnID"
},
{
route: "/cachegroups",
queryKey: "name",
queryValue: "testCG",
- replace: "cachegroupId"
+ replace: "cacheGroupID"
}
]
},
{
- cachegroupId: 0,
- cdnId: 0,
+ cacheGroupID: 0,
+ CDNiD: 0,
Review Comment:
Shouldn't this be `cdnID`?
##########
traffic_portal/app/src/common/modules/table/servers/TableServersController.js:
##########
@@ -38,7 +38,7 @@ var TableServersController = function(servers, $scope,
$state, $uibModal, locati
$scope.columns = [
{
headerName: "Cache Group",
- field: "cachegroup",
+ field: "cacheGroup",
hide: false
},
{
Review Comment:
`cdnName` should be `cdn` on line 45
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
