dewrich commented on a change in pull request #2803: Add Traffic Ops Golang
Steering Targets
URL: https://github.com/apache/trafficcontrol/pull/2803#discussion_r217162169
##########
File path: lib/go-tc/steeringtarget.go
##########
@@ -47,9 +47,6 @@ type SteeringTargetNullable struct {
func (st SteeringTargetNullable) Validate(tx *sql.Tx) error {
errs := []string{}
- if st.TargetID == nil {
Review comment:
Why are we putting validation rules on the struct instead of in the
controller? Seems like our Business Rules will be scattered otherwise.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
