[GitHub] mitchell852 closed pull request #2686: adds maxRevalDurationDays to seeds.sql

mitchell852 closed pull request #2686: adds maxRevalDurationDays to seeds.sql URL: https://github.com/apache/trafficcontrol/pull/2686 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] elsloo closed pull request #2694: Fix Docs invalid JSON missing commas and escapes

elsloo closed pull request #2694: Fix Docs invalid JSON missing commas and escapes URL: https://github.com/apache/trafficcontrol/pull/2694 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] mitchell852 closed pull request #2688: ensure use_tenancy set to 1 rather than deleting the parameter

mitchell852 closed pull request #2688: ensure use_tenancy set to 1 rather than deleting the parameter URL: https://github.com/apache/trafficcontrol/pull/2688 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] dneuman64 opened a new issue #2692: Traffic Stats shouldn't panic when it cannot talk to Traffic OPs

dneuman64 opened a new issue #2692: Traffic Stats shouldn't panic when it cannot talk to Traffic OPs URL: https://github.com/apache/trafficcontrol/issues/2692 If Traffic Stats cannot talk to Traffic Ops, like to get servers, it panics and dies. Traffic Stats should be able to handle this

[GitHub] dneuman64 opened a new issue #2693: When Traffic Stats panics, it leave systemd in a weird state

dneuman64 opened a new issue #2693: When Traffic Stats panics, it leave systemd in a weird state URL: https://github.com/apache/trafficcontrol/issues/2693 If traffic stats panics and dies, it leaves systemd in a weird state where the process still says its running even though it is dead.

[GitHub] rob05c opened a new pull request #2694: Fix Docs invalid JSON missing commas and escapes

rob05c opened a new pull request #2694: Fix Docs invalid JSON missing commas and escapes URL: https://github.com/apache/trafficcontrol/pull/2694 This is an automated message from the Apache Git Service. To respond to the

[GitHub] dangogh opened a new issue #2695: TO Go remove `use_tenancy` code

dangogh opened a new issue #2695: TO Go remove `use_tenancy` code URL: https://github.com/apache/trafficcontrol/issues/2695 `use_tenancy` is now on by default. We can simplify quite a bit of code including sql by no longer checking this parameter. NOTE: the Perl code should not

[GitHub] rob05c opened a new pull request #2701: Fix TO Go dss endpoint limit param

rob05c opened a new pull request #2701: Fix TO Go dss endpoint limit param URL: https://github.com/apache/trafficcontrol/pull/2701 What does this PR do? Fix TO Go dss endpoint limit param Which TC components are affected by this PR? - [ ] Documentation - [

[GitHub] asfgit commented on issue #2697: Added active filter on delivery services with matching origin names

asfgit commented on issue #2697: Added active filter on delivery services with matching origin names URL: https://github.com/apache/trafficcontrol/pull/2697#issuecomment-413625734 Refer to this link for build results (access rights to CI server needed):

[GitHub] dangogh commented on issue #2668: Traffic Ops - Admin.pl load_schema proper exit codes and eval

dangogh commented on issue #2668: Traffic Ops - Admin.pl load_schema proper exit codes and eval URL: https://github.com/apache/trafficcontrol/pull/2668#issuecomment-413590505 elsewhere, you'll see this: ``` /trafficcontrolpr2244_weasel exited with status 1 ``` `weasel`

[GitHub] asfgit commented on issue #2694: Fix Docs invalid JSON missing commas and escapes

asfgit commented on issue #2694: Fix Docs invalid JSON missing commas and escapes URL: https://github.com/apache/trafficcontrol/pull/2694#issuecomment-413595062 Refer to this link for build results (access rights to CI server needed):

[GitHub] asfgit commented on issue #2600: Handle port different than 80 for Traffic Ops Checks

asfgit commented on issue #2600: Handle port different than 80 for Traffic Ops Checks URL: https://github.com/apache/trafficcontrol/pull/2600#issuecomment-413602233 Refer to this link for build results (access rights to CI server needed):

[GitHub] mitchell852 closed pull request #2696: Fixes #2651 - Set Serves Status dropdown to be enabled when creating new

mitchell852 closed pull request #2696: Fixes #2651 - Set Serves Status dropdown to be enabled when creating new URL: https://github.com/apache/trafficcontrol/pull/2696 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] rob05c opened a new issue #2698: Document POST servers/id/deliveryservices

rob05c opened a new issue #2698: Document POST servers/id/deliveryservices URL: https://github.com/apache/trafficcontrol/issues/2698 This route needs documented. It's new, and not in Perl or the docs. I almost deleted it, because I thought it was a mistake (it's not:

Build failed in Jenkins: trafficcontrol-PR #2273

See Changes: [smalenfant] Fixing TO Checks related to tcpPorts - CDU, CHR and DSCP were not [smalenfant] Fixing indentation [github] Broken logic to calculate cache hit

[GitHub] mitchell852 closed issue #2651: Initial state for new server objects should be PRE_PROD

mitchell852 closed issue #2651: Initial state for new server objects should be PRE_PROD URL: https://github.com/apache/trafficcontrol/issues/2651 This is an automated message from the Apache Git Service. To respond to the

[GitHub] dneuman64 closed pull request #2673: adds a simple PR template

dneuman64 closed pull request #2673: adds a simple PR template URL: https://github.com/apache/trafficcontrol/pull/2673 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] dangogh commented on issue #2685: The use_tenancy global parameter from seeds.sql should be removed

dangogh commented on issue #2685: The use_tenancy global parameter from seeds.sql should be removed URL: https://github.com/apache/trafficcontrol/issues/2685#issuecomment-413586593 This needs to wait until #2687 and #2695 are addressed. The `use_tenancy` parameter must remain in the db

[GitHub] dewrich opened a new pull request #2697: Added active filter on delivery services with matching origin names

dewrich opened a new pull request #2697: Added active filter on delivery services with matching origin names URL: https://github.com/apache/trafficcontrol/pull/2697 Fixes #2644 This is an automated message from the Apache

[GitHub] rob05c opened a new issue #2699: Copy all Docs for API 1.2 into API 1.3

rob05c opened a new issue #2699: Copy all Docs for API 1.2 into API 1.3 URL: https://github.com/apache/trafficcontrol/issues/2699 So far, we've been only putting new route docs into the 1.3 API docs. We need to copy all the old routes that haven't changed from 1.2. It's not reasonable to

[GitHub] dangogh edited a comment on issue #2668: Traffic Ops - Admin.pl load_schema proper exit codes and eval

dangogh edited a comment on issue #2668: Traffic Ops - Admin.pl load_schema proper exit codes and eval URL: https://github.com/apache/trafficcontrol/pull/2668#issuecomment-413590505 elsewhere, you'll see this: ``` /trafficcontrolpr2244_weasel exited with status 1 ```

[GitHub] mitchell852 opened a new pull request #2700: pr template - moves license to bottom of file

mitchell852 opened a new pull request #2700: pr template - moves license to bottom of file URL: https://github.com/apache/trafficcontrol/pull/2700 What does this PR do? Fixes #(issue_number) Which TC components are affected by this PR? - [ ]

Jenkins build is back to normal : trafficcontrol-PR #2274

See

[GitHub] dangogh commented on issue #2687: TP remove dependency on `use_tenancy` parameter

dangogh commented on issue #2687: TP remove dependency on `use_tenancy` parameter URL: https://github.com/apache/trafficcontrol/issues/2687#issuecomment-413587046 Once this and #2695 are resolved, #2685 can be done. This is

[GitHub] dangogh commented on issue #2695: TO Go remove `use_tenancy` code

dangogh commented on issue #2695: TO Go remove `use_tenancy` code URL: https://github.com/apache/trafficcontrol/issues/2695#issuecomment-413587355 Once this and #2687 are resolved, #2685 can be done. This is an automated

[GitHub] dneuman64 commented on a change in pull request #2684: python lib updated to api v1.3

dneuman64 commented on a change in pull request #2684: python lib updated to api v1.3 URL: https://github.com/apache/trafficcontrol/pull/2684#discussion_r210657469 ## File path: traffic_control/clients/python/trafficops/trafficops/tosession.py ## @@ -590,18 +589,18 @@ def

[GitHub] asfgit commented on issue #2701: Fix TO Go dss endpoint limit param

asfgit commented on issue #2701: Fix TO Go dss endpoint limit param URL: https://github.com/apache/trafficcontrol/pull/2701#issuecomment-413633620 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/2275/ Test

[GitHub] asfgit commented on issue #2668: Traffic Ops - Admin.pl load_schema proper exit codes and eval

asfgit commented on issue #2668: Traffic Ops - Admin.pl load_schema proper exit codes and eval URL: https://github.com/apache/trafficcontrol/pull/2668#issuecomment-413663785 Refer to this link for build results (access rights to CI server needed):

[GitHub] rob05c edited a comment on issue #2701: Fix TO Go dss endpoint limit param

rob05c edited a comment on issue #2701: Fix TO Go dss endpoint limit param URL: https://github.com/apache/trafficcontrol/pull/2701#issuecomment-413657909 @mitchell852 It will take me several days, between setting up the test framework, and learning or re-learning how to do something like

[GitHub] rob05c edited a comment on issue #2701: Fix TO Go dss endpoint limit param

rob05c edited a comment on issue #2701: Fix TO Go dss endpoint limit param URL: https://github.com/apache/trafficcontrol/pull/2701#issuecomment-413657909 @mitchell852 It will take me several days, between setting up the test framework, and learning or re-learning how to do something like

[GitHub] rob05c edited a comment on issue #2701: Fix TO Go dss endpoint limit param

rob05c edited a comment on issue #2701: Fix TO Go dss endpoint limit param URL: https://github.com/apache/trafficcontrol/pull/2701#issuecomment-413657909 @mitchell852 It will take me several days, between setting up the test framework, and learning or re-learning how to do something like

[GitHub] rob05c edited a comment on issue #2701: Fix TO Go dss endpoint limit param

rob05c edited a comment on issue #2701: Fix TO Go dss endpoint limit param URL: https://github.com/apache/trafficcontrol/pull/2701#issuecomment-413657909 @mitchell852 It will take me several days, between setting up the test framework, and learning or re-learning how to do something like

[GitHub] rob05c opened a new pull request #2703: Remove TO Go unnecessary query passing

rob05c opened a new pull request #2703: Remove TO Go unnecessary query passing URL: https://github.com/apache/trafficcontrol/pull/2703 What does this PR do? Removes an unnecessary obsolete function parameter. Which TC components are affected by this PR? - [ ]

[GitHub] asfgit commented on issue #2703: Remove TO Go unnecessary query passing

asfgit commented on issue #2703: Remove TO Go unnecessary query passing URL: https://github.com/apache/trafficcontrol/pull/2703#issuecomment-413688067 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/2277/

Build failed in Jenkins: trafficcontrol-PR #2277

See -- GitHub pull request #2703 of commit 5eaba990fd4d28c063c705e221e529ab2375fa84, no merge conflicts. Setting status of 5eaba990fd4d28c063c705e221e529ab2375fa84 to PENDING with url

[GitHub] rob05c commented on issue #2701: Fix TO Go dss endpoint limit param

rob05c commented on issue #2701: Fix TO Go dss endpoint limit param URL: https://github.com/apache/trafficcontrol/pull/2701#issuecomment-413657909 @mitchell852 It will take me several days, between setting up the test framework, and learning or re-learning how to do something like that. I

[GitHub] mitchell852 commented on issue #2338: Add TO Go users

mitchell852 commented on issue #2338: Add TO Go users URL: https://github.com/apache/trafficcontrol/pull/2338#issuecomment-413654855 does this leverage the CRUDDER interface? This is an automated message from the Apache Git

[GitHub] mitchell852 edited a comment on issue #2338: Add TO Go users

mitchell852 edited a comment on issue #2338: Add TO Go users URL: https://github.com/apache/trafficcontrol/pull/2338#issuecomment-413654855 does this leverage the CRUDDER interface? I don't think so because i expected to se Create, Read, Update, Delete methods as opposed to POST, PUT,

[GitHub] mitchell852 commented on issue #2701: Fix TO Go dss endpoint limit param

mitchell852 commented on issue #2701: Fix TO Go dss endpoint limit param URL: https://github.com/apache/trafficcontrol/pull/2701#issuecomment-413656614 you should be able to create a simple test to verify that ?limit=x has the desired effect, right?

[GitHub] mitchell852 commented on issue #2481: TP: adds the ability to crud api endpoints for roles/capabilities management

mitchell852 commented on issue #2481: TP: adds the ability to crud api endpoints for roles/capabilities management URL: https://github.com/apache/trafficcontrol/pull/2481#issuecomment-413680640 retest this please This is an

[GitHub] JBevillC commented on issue #2668: Traffic Ops - Admin.pl load_schema proper exit codes and eval

JBevillC commented on issue #2668: Traffic Ops - Admin.pl load_schema proper exit codes and eval URL: https://github.com/apache/trafficcontrol/pull/2668#issuecomment-413661845 Thanks Dan ! Rebased and pushed. This is an

[GitHub] chadgilloth opened a new pull request #2702: Improve usability of comments in DS requests

chadgilloth opened a new pull request #2702: Improve usability of comments in DS requests URL: https://github.com/apache/trafficcontrol/pull/2702 Improves the usability of viewing comments in DS Requests by showing the comments in the same view CDN-2347 (No git issue)

[GitHub] asfgit commented on issue #2702: Improve usability of comments in DS requests

asfgit commented on issue #2702: Improve usability of comments in DS requests URL: https://github.com/apache/trafficcontrol/pull/2702#issuecomment-413673807 Can one of the admins verify this patch? This is an automated

Jenkins build is back to normal : trafficcontrol-PR #2280

See

[GitHub] asfgit commented on issue #2705: Fix TO Go user/ds/available to skip assigned

asfgit commented on issue #2705: Fix TO Go user/ds/available to skip assigned URL: https://github.com/apache/trafficcontrol/pull/2705#issuecomment-413702906 Refer to this link for build results (access rights to CI server needed):

[GitHub] dangogh opened a new pull request #2708: add operations role to seeds.sql so there when used for extension user

dangogh opened a new pull request #2708: add operations role to seeds.sql so there when used for extension user URL: https://github.com/apache/trafficcontrol/pull/2708 What does this PR do? adds operations role in seeds.sql Fixes #2706 Which TC components are

[GitHub] asfgit commented on issue #2704: TO DB - Mapping roles to capabilities for read-only, operations, portal, federations, steering

asfgit commented on issue #2704: TO DB - Mapping roles to capabilities for read-only, operations, portal, federations, steering URL: https://github.com/apache/trafficcontrol/pull/2704#issuecomment-413715002 Refer to this link for build results (access rights to CI server needed):

[GitHub] mitchell852 closed pull request #2708: add operations role to seeds.sql so there when used for extension user

mitchell852 closed pull request #2708: add operations role to seeds.sql so there when used for extension user URL: https://github.com/apache/trafficcontrol/pull/2708 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] asfgit commented on issue #2703: Remove TO Go unnecessary query passing

asfgit commented on issue #2703: Remove TO Go unnecessary query passing URL: https://github.com/apache/trafficcontrol/pull/2703#issuecomment-413695556 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/2278/

Jenkins build is back to normal : trafficcontrol-PR #2278

See

[GitHub] asfgit commented on issue #2704: TO DB - Mapping roles to capabilities for read-only, operations, portal, federations, steering

asfgit commented on issue #2704: TO DB - Mapping roles to capabilities for read-only, operations, portal, federations, steering URL: https://github.com/apache/trafficcontrol/pull/2704#issuecomment-413695612 Can one of the admins verify this patch?

Build failed in Jenkins: trafficcontrol-PR #2279

See Changes: [mitchell852] adds the ability to crud api endpoints [mitchell852] turn caps on/off based upon setting in tp_properties.json -- [...truncated 15.17 MB...]

[GitHub] asfgit commented on issue #2481: TP: adds the ability to crud api endpoints for roles/capabilities management

asfgit commented on issue #2481: TP: adds the ability to crud api endpoints for roles/capabilities management URL: https://github.com/apache/trafficcontrol/pull/2481#issuecomment-413699123 Refer to this link for build results (access rights to CI server needed):

[GitHub] dangogh opened a new pull request #2707: cdn-in-a-box: redo initial data loading from dir structure

dangogh opened a new pull request #2707: cdn-in-a-box: redo initial data loading from dir structure URL: https://github.com/apache/trafficcontrol/pull/2707 What does this PR do? extends cdn-in-a-box with data loaded from json files on startup Which TC components are

[GitHub] asfgit commented on issue #2707: cdn-in-a-box: redo initial data loading from dir structure

asfgit commented on issue #2707: cdn-in-a-box: redo initial data loading from dir structure URL: https://github.com/apache/trafficcontrol/pull/2707#issuecomment-413709203 Refer to this link for build results (access rights to CI server needed):

[GitHub] dangogh opened a new issue #2706: `operations` role not created in seeds.sql

dangogh opened a new issue #2706: `operations` role not created in seeds.sql URL: https://github.com/apache/trafficcontrol/issues/2706 The `extension` user is created with the `operations` role in seeds.sql, but that role isn't created first. A brand new installation will fail to get

[GitHub] dangogh commented on issue #2704: TO DB - Mapping roles to capabilities for read-only, operations, portal, federations, steering

dangogh commented on issue #2704: TO DB - Mapping roles to capabilities for read-only, operations, portal, federations, steering URL: https://github.com/apache/trafficcontrol/pull/2704#issuecomment-413710937 add to whitelist

[GitHub] mitchell852 opened a new pull request #2709: TP: server.js - removes commented out code

mitchell852 opened a new pull request #2709: TP: server.js - removes commented out code URL: https://github.com/apache/trafficcontrol/pull/2709 What does this PR do? Removes some commented out code in server.js that was a failed attempt at dbdump. Which TC

[GitHub] moltzaum opened a new pull request #2704: TO DB - Mapping roles to capabilities for read-only, operations, portal, federations, steering

moltzaum opened a new pull request #2704: TO DB - Mapping roles to capabilities for read-only, operations, portal, federations, steering URL: https://github.com/apache/trafficcontrol/pull/2704 What does this PR do? This PR is a database migration that assigns capabilities for

[GitHub] rob05c opened a new pull request #2705: Fix TO Go user/ds/available to skip assigned

rob05c opened a new pull request #2705: Fix TO Go user/ds/available to skip assigned URL: https://github.com/apache/trafficcontrol/pull/2705 What does this PR do? Fix TO Go user/ds/available to skip assigned Which TC components are affected by this PR? - [ ]

[GitHub] asfgit commented on issue #2708: add operations role to seeds.sql so there when used for extension user

asfgit commented on issue #2708: add operations role to seeds.sql so there when used for extension user URL: https://github.com/apache/trafficcontrol/pull/2708#issuecomment-413714455 Refer to this link for build results (access rights to CI server needed):

[GitHub] mitchell852 closed issue #2706: `operations` role not created in seeds.sql

mitchell852 closed issue #2706: `operations` role not created in seeds.sql URL: https://github.com/apache/trafficcontrol/issues/2706 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] asfgit commented on issue #2709: TP: server.js - removes commented out code

asfgit commented on issue #2709: TP: server.js - removes commented out code URL: https://github.com/apache/trafficcontrol/pull/2709#issuecomment-413753828 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/2284/