[GitHub] [trafficcontrol] asf-ci commented on issue #3932: Rewrote /user/login/token to Go

2019-09-20 Thread GitBox 
asf-ci commented on issue #3932: Rewrote /user/login/token to Go
URL: https://github.com/apache/trafficcontrol/pull/3932#issuecomment-533729224
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/4297/
   Test FAILed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: trafficcontrol-PR #4297

2019-09-20 Thread Apache Jenkins Server 
See 


Changes:

[ocket] Rewrote user/login/token to Go

[ocket] updated docs

[ocket] Added token login capability to TO Go client

[ocket] Added an integration test

[ocket] updated changelog

--
[...truncated 3.42 MB...]
traffic_portal_build_1   | | `-- delayed-stream@1.0.0 
traffic_portal_build_1   | +-- extend@3.0.2 
traffic_portal_build_1   | +-- forever-agent@0.6.1 
traffic_portal_build_1   | +-- form-data@2.3.3 
traffic_portal_build_1   | | `-- asynckit@0.4.0 
traffic_portal_build_1   | +-- har-validator@5.1.3 
traffic_portal_build_1   | | +-- ajv@6.10.2 
traffic_portal_build_1   | | | +-- fast-deep-equal@2.0.1 
traffic_portal_build_1   | | | +-- 
fast-json-stable-stringify@2.0.0 
traffic_portal_build_1   | | | +-- json-schema-traverse@0.4.1 
traffic_portal_build_1   | | | `-- uri-js@4.2.2 
traffic_portal_build_1   | | |   `-- punycode@2.1.1 
traffic_portal_build_1   | | `-- har-schema@2.0.0 
traffic_portal_build_1   | +-- http-signature@1.2.0 
traffic_portal_build_1   | | +-- assert-plus@1.0.0 
traffic_portal_build_1   | | +-- jsprim@1.4.1 
traffic_portal_build_1   | | | +-- extsprintf@1.3.0 
traffic_portal_build_1   | | | +-- json-schema@0.2.3 
traffic_portal_build_1   | | | `-- verror@1.10.0 
traffic_portal_build_1   | | `-- sshpk@1.16.1 
traffic_portal_build_1   | |   +-- asn1@0.2.4 
traffic_portal_build_1   | |   +-- bcrypt-pbkdf@1.0.2 
traffic_portal_build_1   | |   +-- dashdash@1.14.1 
traffic_portal_build_1   | |   +-- ecc-jsbn@0.1.2 
traffic_portal_build_1   | |   +-- getpass@0.1.7 
traffic_portal_build_1   | |   +-- jsbn@0.1.1 
traffic_portal_build_1   | |   `-- tweetnacl@0.14.5 
traffic_portal_build_1   | +-- is-typedarray@1.0.0 
traffic_portal_build_1   | +-- json-stringify-safe@5.0.1 
traffic_portal_build_1   | +-- oauth-sign@0.9.0 
traffic_portal_build_1   | +-- performance-now@2.1.0 
traffic_portal_build_1   | +-- qs@6.5.2 
traffic_portal_build_1   | +-- tough-cookie@2.4.3 
traffic_portal_build_1   | | +-- psl@1.4.0 
traffic_portal_build_1   | | `-- punycode@1.4.1 
traffic_portal_build_1   | +-- tunnel-agent@0.6.0 
traffic_portal_build_1   | `-- uuid@3.3.3 
traffic_portal_build_1   | 
traffic_portal_build_1   | npm WARN optional SKIPPING OPTIONAL 
DEPENDENCY: fsevents@^1.0.0 (node_modules/chokidar/node_modules/fsevents):
traffic_portal_build_1   | npm WARN notsup SKIPPING OPTIONAL 
DEPENDENCY: Unsupported platform for fsevents@1.2.9: wanted 
{"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
traffic_portal_build_1   | npm WARN traffic_portal@ No description
traffic_portal_build_1   | npm WARN traffic_portal@ No repository 
field.
traffic_portal_build_1   | npm WARN traffic_portal@ No license field.
traffic_portal_build_1   | 
traffic_portal_build_1   | Done.
traffic_portal_build_1   | 
traffic_portal_build_1   | 
traffic_portal_build_1   | Execution Time (2019-09-20 22:19:48 UTC)
traffic_portal_build_1   | loading tasks 952ms  ▇ 
2%
traffic_portal_build_1   | compass:prod   8.2s  
▇▇▇▇▇▇▇ 20%
traffic_portal_build_1   | browserify2:app-prod   2.1s  
▇▇ 5%
traffic_portal_build_1   | browserify2:shared-libs-prod   3.5s  
▇▇▇ 9%
traffic_portal_build_1   | install-dependencies25s  
▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇ 62%
traffic_portal_build_1   | Total 40.2s
traffic_portal_build_1   | 
traffic_portal_build_1   | + exit 0
traffic_portal_build_1   | Executing(%install): /bin/sh -e 
/var/tmp/rpm-tmp.it2tdG
traffic_portal_build_1   | + umask 022
traffic_portal_build_1   | + cd /tmp/trafficcontrol/rpmbuild/BUILD
traffic_portal_build_1   | + '[' 
/tmp/trafficcontrol/rpmbuild/BUILDROOT/traffic_portal-3.0.0-10194.65909c22.el7.x86_64
 '!=' / ']'
traffic_portal_build_1   | + rm -rf 
/tmp/trafficcontrol/rpmbuild/BUILDROOT/traffic_portal-3.0.0-10194.65909c22.el7.x86_64
traffic_portal_build_1   | ++ dirname 
/tmp/trafficcontrol/rpmbuild/BUILDROOT/traffic_portal-3.0.0-10194.65909c22.el7.x86_64
traffic_portal_build_1

[GitHub] [trafficcontrol] ocket8888 opened a new pull request #3932: Rewrote /user/login/token to Go

2019-09-20 Thread GitBox 
ocket opened a new pull request #3932: Rewrote /user/login/token to Go
URL: https://github.com/apache/trafficcontrol/pull/3932
 
 
   ## What does this PR (Pull Request) do?
   - [x] This PR fixes #3840 
   Rewrites `/user/login/token` to Go, and adds client code and a test. Also 
some minor documentation updates.
   
   ## Which Traffic Control components are affected by this PR?
   - Documentation
   - Traffic Control Client (Go)
   - Traffic Ops
   
   ## What is the best way to verify this PR?
   Run the associated API/client integration test
   
   ## The following criteria are ALL met by this PR
   - [x] This PR includes tests
   - [x] This PR includes documentation
   - [x] This PR includes an update to CHANGELOG.md
   - [x] This PR includes any and all required license headers
   - [x] This PR does not include a database migration
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY**


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] asf-ci commented on issue #3931: Gives admins the ability to mark delivery service requests as complete

2019-09-20 Thread GitBox 
asf-ci commented on issue #3931: Gives admins the ability to mark delivery 
service requests as complete
URL: https://github.com/apache/trafficcontrol/pull/3931#issuecomment-533621074
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/4295/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mhoppa commented on issue #3927: Fix using http2 between TO and TM when setting proxy

2019-09-20 Thread GitBox 
mhoppa commented on issue #3927: Fix using http2 between TO and TM when setting 
proxy
URL: https://github.com/apache/trafficcontrol/pull/3927#issuecomment-533585330
 
 
   Agreed with you @mitchell852. One question is what services besides TM/TR 
does the TO talk to? If we put getting http clients for each of them into a 
common method we can enforce it a little better as 
https://github.com/apache/trafficcontrol/pull/2305/files#diff-6e647a5b8d470f399423ff712efb0050R40
 does.
   
   As we talked we can set it globally per 
https://golang.org/src/net/http/doc.go via `GODEBUG=http2client=0  # disable 
HTTP/2 client support` but I think we have agreed that feels a little 
cumbersome.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 commented on issue #3927: Fix using http2 between TO and TM when setting proxy

2019-09-20 Thread GitBox 
ocket commented on issue #3927: Fix using http2 between TO and TM when 
setting proxy
URL: https://github.com/apache/trafficcontrol/pull/3927#issuecomment-533588286
 
 
   It talks to TV and TS and a mail server (sort of and sometimes)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mitchell852 opened a new pull request #3931: renames the override role and extends it to ds request completion and…

2019-09-20 Thread GitBox 
mitchell852 opened a new pull request #3931: renames the override role and 
extends it to ds request completion and…
URL: https://github.com/apache/trafficcontrol/pull/3931
 
 
   … rejection
   
   ## What does this PR (Pull Request) do?
   
   Allows users with the admin role to mark fulfilled delivery services 
requests as "complete".  Before this change, only the user that fulfilled the 
delivery service request could mark it as "complete". This can cause problems 
if the fulfilling user is not available to mark it as complete thus leaving the 
delivery service request in an "open" state. Because a delivery service can 
only have one open ds request at a time, this would block any further changes 
to a delivery service. Now anyone with the admin role can "complete" ds 
requests and unblock the delivery service from future updates.
   
   - [ ] This PR fixes #3871 
   
   ## Which Traffic Control components are affected by this PR?
   
   - Traffic Portal
   
   ## What is the best way to verify this PR?
   - enable ds requests in traffic_portal_properties.json
   - launch TP
   - login as user 1 (with portal role or higher) and update a delivery service 
which will create a delivery service request and set the request status to 
'submit request for review and deployment'
   - login as user 2 (with operations role or higher) and fulfill the delivery 
service request
   - login as user 3 (with admin role) and mark the delivery service request as 
"complete"
   
   (before this change, only user 2 (the fulfiller of the ds request) could 
mark the ds request as complete)
   
   There are no UI tests to cover ds requests currently as ds requests are 
disabled by default and no mechanism to turn them on for testing.
   
   ## The following criteria are ALL met by this PR
   
   - [x] This PR includes tests OR I have explained why tests are unnecessary
   - [ ] This PR includes documentation OR I have explained why documentation 
is unnecessary
   - [] This PR includes an update to CHANGELOG.md OR such an update is not 
necessary
   - [x] This PR includes any and all required license headers
   - [x] This PR ensures that database migration sequence is correct OR this PR 
does not include a database migration
   - [ ] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the 
Apache Software Foundation's security 
guidelines](https://www.apache.org/security/) for details)
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services