[GitHub] [trafficcontrol] rawlinp commented on issue #4374: Create API v2 tests

rawlinp commented on issue #4374: Create API v2 tests URL: https://github.com/apache/trafficcontrol/pull/4374#issuecomment-587762233 I still like the idea of copying the v1 tests (and Go client) to v2 and removing deprecated API usage from the v2 tests (and Go client). Then we can

[GitHub] [trafficcontrol] rob05c commented on issue #4374: Create API v2 tests

rob05c commented on issue #4374: Create API v2 tests URL: https://github.com/apache/trafficcontrol/pull/4374#issuecomment-587634511 >I think it should have the option to run v1 tests as a regression check and in my opinion by default run both. There is going to be (already is) a lot

[GitHub] [trafficcontrol] ZugNZwang opened a new issue #4411: deliveryservice_requests POST request returns Internal Server Error

ZugNZwang opened a new issue #4411: deliveryservice_requests POST request returns Internal Server Error URL: https://github.com/apache/trafficcontrol/issues/4411 ## I'm submitting a ... - [X] bug report - [ ] new feature / enhancement request - [ ]

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #4356: Update generic API Create to allow arrays in POST if set on object

mhoppa commented on a change in pull request #4356: Update generic API Create to allow arrays in POST if set on object URL: https://github.com/apache/trafficcontrol/pull/4356#discussion_r380897216 ## File path: traffic_ops/client/profile_parameter.go ## @@ -49,6 +49,25 @@

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #4356: Update generic API Create to allow arrays in POST if set on object

mhoppa commented on a change in pull request #4356: Update generic API Create to allow arrays in POST if set on object URL: https://github.com/apache/trafficcontrol/pull/4356#discussion_r380897268 ## File path: traffic_ops/client/profile_parameter.go ## @@ -49,6 +49,25 @@

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #4396: Traffic Ops client upgrades

mhoppa commented on a change in pull request #4396: Traffic Ops client upgrades URL: https://github.com/apache/trafficcontrol/pull/4396#discussion_r380900178 ## File path: CHANGELOG.md ## @@ -26,8 +26,12 @@ The format is based on [Keep a

[GitHub] [trafficcontrol] ocket8888 merged pull request #4356: Update generic API Create to allow arrays in POST if set on object

ocket merged pull request #4356: Update generic API Create to allow arrays in POST if set on object URL: https://github.com/apache/trafficcontrol/pull/4356 This is an automated message from the Apache Git Service. To

[GitHub] [trafficcontrol] ocket8888 closed issue #3103: /api/1.x/profileparameters route in Go has dropped support for array format

ocket closed issue #3103: /api/1.x/profileparameters route in Go has dropped support for array format URL: https://github.com/apache/trafficcontrol/issues/3103 This is an automated message from the Apache Git Service.

[GitHub] [trafficcontrol] mhoppa edited a comment on issue #4374: Create API v2 tests

mhoppa edited a comment on issue #4374: Create API v2 tests URL: https://github.com/apache/trafficcontrol/pull/4374#issuecomment-587469648 I think it should have the option to run v1 tests as a regression check and in my opinion by default run both. There is going to be (already is) a lot

[GitHub] [trafficcontrol] mhoppa commented on issue #4374: Create API v2 tests

mhoppa commented on issue #4374: Create API v2 tests URL: https://github.com/apache/trafficcontrol/pull/4374#issuecomment-587469648 I think it should have the option to run v1 tests as a regression check and in my opinion by default run both. There is going to be shared code between v1

[GitHub] [trafficcontrol] ZugNZwang commented on issue #4290: Undocumented Traffic Ops Golang routes

ZugNZwang commented on issue #4290: Undocumented Traffic Ops Golang routes URL: https://github.com/apache/trafficcontrol/issues/4290#issuecomment-587929554 `servers/{{ID}}/deliveryservices` is also missing the documentation for the `POST` method

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #4396: Traffic Ops client upgrades

mhoppa commented on a change in pull request #4396: Traffic Ops client upgrades URL: https://github.com/apache/trafficcontrol/pull/4396#discussion_r380961509 ## File path: CHANGELOG.md ## @@ -26,8 +26,12 @@ The format is based on [Keep a

[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #4396: Traffic Ops client upgrades

rawlinp commented on a change in pull request #4396: Traffic Ops client upgrades URL: https://github.com/apache/trafficcontrol/pull/4396#discussion_r380977004 ## File path: CHANGELOG.md ## @@ -26,8 +26,12 @@ The format is based on [Keep a

[GitHub] [trafficcontrol] zrhoffman opened a new issue #4412: deliveryservices/sslkeys/add with no authType returns Internal Server Error

zrhoffman opened a new issue #4412: deliveryservices/sslkeys/add with no authType returns Internal Server Error URL: https://github.com/apache/trafficcontrol/issues/4412 ## I'm submitting a ... - [x] bug report - [ ] new feature / enhancement request - [ ]

Build failed in Jenkins: trafficcontrol-PR #5346

See Changes: [matthew_jackson] Added IPv6 checking to Traffic Monitor [matthew_jackson] updated CHANGELOG [matthew_jackson] update per comment [matthew_jackson] update so TM UI updates when IP is removed

Build failed in Jenkins: trafficcontrol-PR #5347

See Changes: [github] TP: adds configurability (show/hide columns) to the parameters and users [github] Fixed /api/2.0/roles always returning empty array (#4397) [github] Fixed '/deliveryservices' not

[GitHub] [trafficcontrol] mattjackson220 commented on a change in pull request #4142: Allow IPv6 Only Caches, including monitoring and routing

mattjackson220 commented on a change in pull request #4142: Allow IPv6 Only Caches, including monitoring and routing URL: https://github.com/apache/trafficcontrol/pull/4142#discussion_r380747141 ## File path: traffic_monitor/health/cache.go ## @@ -171,45 +172,100 @@ func

[GitHub] [trafficcontrol] mitchell852 commented on issue #4410: Eliminating underscore

mitchell852 commented on issue #4410: Eliminating underscore URL: https://github.com/apache/trafficcontrol/pull/4410#issuecomment-587532362 this is good (it's always good to remove a dependency imo) but it's highly intrusive and dangerous as the reality is that the TP end-to-end tests

[GitHub] [trafficcontrol] mattjackson220 commented on issue #4400: TP: Fixes missing ecs enabled property on a number of ds tables

mattjackson220 commented on issue #4400: TP: Fixes missing ecs enabled property on a number of ds tables URL: https://github.com/apache/trafficcontrol/pull/4400#issuecomment-587546428 This is great! tested locally and all tables successfully add the new option!

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #4371: API 2.0 documentation

mhoppa commented on a change in pull request #4371: API 2.0 documentation URL: https://github.com/apache/trafficcontrol/pull/4371#discussion_r380694455 ## File path: docs/source/api/v2/isos.rst ## @@ -0,0 +1,124 @@ +.. +.. +.. Licensed under the Apache License, Version 2.0

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #4371: API 2.0 documentation

mhoppa commented on a change in pull request #4371: API 2.0 documentation URL: https://github.com/apache/trafficcontrol/pull/4371#discussion_r380696489 ## File path: traffic_control/clients/python/trafficops/tosession.py ## @@ -268,7 +268,7 @@ def

[GitHub] [trafficcontrol] ocket8888 opened a new pull request #4410: Eliminating underscore

ocket opened a new pull request #4410: Eliminating underscore URL: https://github.com/apache/trafficcontrol/pull/4410 ## What does this PR (Pull Request) do? - [x] This PR is not related to any Issue Removes UnderscoreJS (`_.js`) from the Traffic Portal dependencies and

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4371: API 2.0 documentation

ocket commented on a change in pull request #4371: API 2.0 documentation URL: https://github.com/apache/trafficcontrol/pull/4371#discussion_r380711443 ## File path: docs/source/api/v2/isos.rst ## @@ -0,0 +1,124 @@ +.. +.. +.. Licensed under the Apache License, Version

Build failed in Jenkins: trafficcontrol-PR #5345

See Changes: [Michael_Hoppal] API 2.0 documentation [Michael_Hoppal] Some minor cleanup to match up spacing [Michael_Hoppal] Add both v1 and v2 API documentation [Michael_Hoppal] Merge in recent v1 changes

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #4371: API 2.0 documentation

mhoppa commented on a change in pull request #4371: API 2.0 documentation URL: https://github.com/apache/trafficcontrol/pull/4371#discussion_r380694532 ## File path: docs/source/api/v2/isos.rst ## @@ -0,0 +1,124 @@ +.. +.. +.. Licensed under the Apache License, Version 2.0

Build failed in Jenkins: trafficcontrol-PR #5343

See Changes: [mitchell852] Finally removed all of that trailing whitespace from the license header [dangogh] adds more automated TP tests so the data can build from a clean db [dangogh] TP: removes hard

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4371: API 2.0 documentation

ocket commented on a change in pull request #4371: API 2.0 documentation URL: https://github.com/apache/trafficcontrol/pull/4371#discussion_r380712865 ## File path: traffic_control/clients/python/trafficops/tosession.py ## @@ -268,7 +268,7 @@ def

Build failed in Jenkins: trafficcontrol-PR #5344

See Changes: [github] TP Delivery Service Generate SSL update, new letsencrypt generate and [ocket] Removed underscore.js from Traffic Portal [ocket] browserify can't handle arrow functions...

[GitHub] [trafficcontrol] mattjackson220 commented on a change in pull request #4142: Allow IPv6 Only Caches, including monitoring and routing

mattjackson220 commented on a change in pull request #4142: Allow IPv6 Only Caches, including monitoring and routing URL: https://github.com/apache/trafficcontrol/pull/4142#discussion_r380746106 ## File path: traffic_ops/traffic_ops_golang/crconfig/servers.go ## @@ -111,7

[GitHub] [trafficcontrol] mattjackson220 commented on a change in pull request #4142: Allow IPv6 Only Caches, including monitoring and routing

mattjackson220 commented on a change in pull request #4142: Allow IPv6 Only Caches, including monitoring and routing URL: https://github.com/apache/trafficcontrol/pull/4142#discussion_r380745746 ## File path: traffic_monitor/manager/monitorconfig.go ## @@ -146,11 +148,12

[GitHub] [trafficcontrol] mattjackson220 commented on a change in pull request #4142: Allow IPv6 Only Caches, including monitoring and routing

mattjackson220 commented on a change in pull request #4142: Allow IPv6 Only Caches, including monitoring and routing URL: https://github.com/apache/trafficcontrol/pull/4142#discussion_r380745824 ## File path: traffic_monitor/manager/manager.go ## @@ -45,6 +46,8 @@ import

[GitHub] [trafficcontrol] mattjackson220 commented on a change in pull request #4142: Allow IPv6 Only Caches, including monitoring and routing

mattjackson220 commented on a change in pull request #4142: Allow IPv6 Only Caches, including monitoring and routing URL: https://github.com/apache/trafficcontrol/pull/4142#discussion_r380745964 ## File path: traffic_monitor/poller/cache.go ## @@ -162,14 +181,30 @@ func

[GitHub] [trafficcontrol] shamrickus commented on issue #4406: Only allow changing of types based on useintable

shamrickus commented on issue #4406: Only allow changing of types based on useintable URL: https://github.com/apache/trafficcontrol/pull/4406#issuecomment-587591178 It doesn't appear to need TP changes. It probably should only be in the v2 tests now that you mention it. I'll revert the v1

[GitHub] [trafficcontrol] rawlinp merged pull request #4400: TP: Fixes missing ecs enabled property on a number of ds tables

rawlinp merged pull request #4400: TP: Fixes missing ecs enabled property on a number of ds tables URL: https://github.com/apache/trafficcontrol/pull/4400 This is an automated message from the Apache Git Service. To respond

[GitHub] [trafficcontrol] rawlinp closed issue #4404: TP delivery service tables fail to render due to missing ds property (ECS Enabled)

rawlinp closed issue #4404: TP delivery service tables fail to render due to missing ds property (ECS Enabled) URL: https://github.com/apache/trafficcontrol/issues/4404 This is an automated message from the Apache Git