[GitHub] [trafficcontrol] mhoppa opened a new pull request #4516: Deprecate servers/status

2020-03-18 Thread GitBox
mhoppa opened a new pull request #4516: Deprecate servers/status URL: https://github.com/apache/trafficcontrol/pull/4516 ## What does this PR (Pull Request) do? - [x] This PR is not related to any Issue ## Which Traffic Control components are affected by this PR?

[GitHub] [trafficcontrol] mitchell852 commented on issue #4518: Add service category feature to TO and TP

2020-03-18 Thread GitBox
mitchell852 commented on issue #4518: Add service category feature to TO and TP URL: https://github.com/apache/trafficcontrol/pull/4518#issuecomment-600757547 > Do we expect Service Categories to be created by tenants? Or is it something only Operators will create? everybody is

[GitHub] [trafficcontrol] rob05c edited a comment on issue #4518: Add service category feature to TO and TP

2020-03-18 Thread GitBox
rob05c edited a comment on issue #4518: Add service category feature to TO and TP URL: https://github.com/apache/trafficcontrol/pull/4518#issuecomment-600757234 Do we expect Service Categories to be created by DS customers? Or is it something only Operators will create?

[GitHub] [trafficcontrol] rob05c commented on issue #4518: Add service category feature to TO and TP

2020-03-18 Thread GitBox
rob05c commented on issue #4518: Add service category feature to TO and TP URL: https://github.com/apache/trafficcontrol/pull/4518#issuecomment-600757234 Do we expect Service Categories to be created by tenants? Or is it something only Operators will create?

[GitHub] [trafficcontrol] mitchell852 commented on issue #4518: Add service category feature to TO and TP

2020-03-18 Thread GitBox
mitchell852 commented on issue #4518: Add service category feature to TO and TP URL: https://github.com/apache/trafficcontrol/pull/4518#issuecomment-600757067 > I think the question for anything is, "Will delivery service customers who are not CDN operators be able to create this?" If so,

[GitHub] [trafficcontrol] mitchell852 edited a comment on issue #4518: Add service category feature to TO and TP

2020-03-18 Thread GitBox
mitchell852 edited a comment on issue #4518: Add service category feature to TO and TP URL: https://github.com/apache/trafficcontrol/pull/4518#issuecomment-600763820 > IMO it's sufficiently likely someone will need the latter, to go ahead and support it from the start. Yeah, it's

[GitHub] [trafficcontrol] mhoppa opened a new pull request #4520: Rework /deliveryservice_server/:dsid/:serverid

2020-03-18 Thread GitBox
mhoppa opened a new pull request #4520: Rework /deliveryservice_server/:dsid/:serverid URL: https://github.com/apache/trafficcontrol/pull/4520 ## What does this PR (Pull Request) do? - [x] This PR is not related to any Issue Deprecates `DELETE

[GitHub] [trafficcontrol] mitchell852 commented on issue #4518: Add service category feature to TO and TP

2020-03-18 Thread GitBox
mitchell852 commented on issue #4518: Add service category feature to TO and TP URL: https://github.com/apache/trafficcontrol/pull/4518#issuecomment-600763820 > IMO it's sufficiently likely someone will need the latter, to go ahead and support it from the start. Yeah, it's harder to

[GitHub] [trafficcontrol] ocket8888 opened a new pull request #4521: Multi-interface Servers blueprint

2020-03-18 Thread GitBox
ocket opened a new pull request #4521: Multi-interface Servers blueprint URL: https://github.com/apache/trafficcontrol/pull/4521 ## What does this PR (Pull Request) do? - [ ] This PR fixes #REPLACE_ME OR is not related to any Issue ## Which Traffic Control

[GitHub] [trafficcontrol] mitchell852 merged pull request #4504: Deprecate GET profiles_id

2020-03-18 Thread GitBox
mitchell852 merged pull request #4504: Deprecate GET profiles_id URL: https://github.com/apache/trafficcontrol/pull/4504 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [trafficcontrol] mhoppa opened a new pull request #4519: Rework deliveryservices/xmlId/:XMLID/sslkeys/delete

2020-03-18 Thread GitBox
mhoppa opened a new pull request #4519: Rework deliveryservices/xmlId/:XMLID/sslkeys/delete URL: https://github.com/apache/trafficcontrol/pull/4519 ## What does this PR (Pull Request) do? - [x] This PR is not related to any Issue Deprecates `GET

[GitHub] [trafficcontrol] mitchell852 edited a comment on issue #4518: Add service category feature to TO and TP

2020-03-18 Thread GitBox
mitchell852 edited a comment on issue #4518: Add service category feature to TO and TP URL: https://github.com/apache/trafficcontrol/pull/4518#issuecomment-600757547 > Do we expect Service Categories to be created by tenants? Or is it something only Operators will create? everybody

[GitHub] [trafficcontrol] rob05c commented on issue #4518: Add service category feature to TO and TP

2020-03-18 Thread GitBox
rob05c commented on issue #4518: Add service category feature to TO and TP URL: https://github.com/apache/trafficcontrol/pull/4518#issuecomment-600759309 Right. But for example, Delivery Service Types aren't "scoped" to tenants, because they're created by operators of the system, not

[GitHub] [trafficcontrol] jehunte opened a new pull request #4518: Add service category feature to TO and TP

2020-03-18 Thread GitBox
jehunte opened a new pull request #4518: Add service category feature to TO and TP URL: https://github.com/apache/trafficcontrol/pull/4518 ## What does this PR (Pull Request) do? - [x] This PR is not related to any Issue ## Which Traffic Control components are

[GitHub] [trafficcontrol] mitchell852 commented on issue #4518: Add service category feature to TO and TP

2020-03-18 Thread GitBox
mitchell852 commented on issue #4518: Add service category feature to TO and TP URL: https://github.com/apache/trafficcontrol/pull/4518#issuecomment-600753108 Something to think about. Should "service categories" be restricted to certain tenants? For example, imagine the following tenant

[GitHub] [trafficcontrol] mhoppa opened a new pull request #4517: Collapse cdns/{{ID}}/snapshot & snapshot/{{CDN}} to snapshot route

2020-03-18 Thread GitBox
mhoppa opened a new pull request #4517: Collapse cdns/{{ID}}/snapshot & snapshot/{{CDN}} to snapshot route URL: https://github.com/apache/trafficcontrol/pull/4517 ## What does this PR (Pull Request) do? - [x] This PR is not related to any Issue Deprecates both `PUT`

[GitHub] [trafficcontrol] rob05c edited a comment on issue #4518: Add service category feature to TO and TP

2020-03-18 Thread GitBox
rob05c edited a comment on issue #4518: Add service category feature to TO and TP URL: https://github.com/apache/trafficcontrol/pull/4518#issuecomment-600756285 >If I am a user in tenant 2.1 and i create a Foo service category I think the question for anything is, "Will delivery

[GitHub] [trafficcontrol] rob05c commented on issue #4518: Add service category feature to TO and TP

2020-03-18 Thread GitBox
rob05c commented on issue #4518: Add service category feature to TO and TP URL: https://github.com/apache/trafficcontrol/pull/4518#issuecomment-600756285 >If I am a user in tenant 2.1 and i create a Foo service category I think the question for anything is, "Will delivery service

[GitHub] [trafficcontrol] rob05c commented on issue #4518: Add service category feature to TO and TP

2020-03-18 Thread GitBox
rob05c commented on issue #4518: Add service category feature to TO and TP URL: https://github.com/apache/trafficcontrol/pull/4518#issuecomment-600762344 @mitchell852 I think I agree with you. It's possible a TC Operator will want to make a hard list of categories, e.g. "Linear," "VOD,"

[GitHub] [trafficcontrol] rawlinp merged pull request #4515: Add ORT atstccfg plugin hook to modify files

2020-03-18 Thread GitBox
rawlinp merged pull request #4515: Add ORT atstccfg plugin hook to modify files URL: https://github.com/apache/trafficcontrol/pull/4515 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [trafficcontrol] dpham692 opened a new issue #4522: No message display after delete a cache group

2020-03-18 Thread GitBox
dpham692 opened a new issue #4522: No message display after delete a cache group URL: https://github.com/apache/trafficcontrol/issues/4522 ## I'm submitting a ... - [x] bug report - [ ] new feature / enhancement request - [ ] improvement request (usability,

Build failed in Jenkins: trafficcontrol-traffic_ops-test #1898

2020-03-18 Thread Apache Jenkins Server
See Changes: [github] Deprecate GET statuses/:id (#4506) -- [...truncated 93.62 KB...] unit_golang_1 | --- PASS:

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4521: Multi-interface Servers blueprint

2020-03-18 Thread GitBox
ocket commented on a change in pull request #4521: Multi-interface Servers blueprint URL: https://github.com/apache/trafficcontrol/pull/4521#discussion_r394693974 ## File path: blueprints/multi-interface-servers.md ## @@ -0,0 +1,657 @@ + +# Additional Server

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #4406: Only allow changing of types based on useintable

2020-03-18 Thread GitBox
mhoppa commented on a change in pull request #4406: Only allow changing of types based on useintable URL: https://github.com/apache/trafficcontrol/pull/4406#discussion_r394594463 ## File path: traffic_ops/traffic_ops_golang/types/types.go ## @@ -95,9 +98,46 @@ func (typ

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #4406: Only allow changing of types based on useintable

2020-03-18 Thread GitBox
mhoppa commented on a change in pull request #4406: Only allow changing of types based on useintable URL: https://github.com/apache/trafficcontrol/pull/4406#discussion_r394594577 ## File path: traffic_ops/traffic_ops_golang/types/types.go ## @@ -95,9 +98,46 @@ func (typ

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #4406: Only allow changing of types based on useintable

2020-03-18 Thread GitBox
mhoppa commented on a change in pull request #4406: Only allow changing of types based on useintable URL: https://github.com/apache/trafficcontrol/pull/4406#discussion_r394594534 ## File path: traffic_ops/traffic_ops_golang/types/types.go ## @@ -95,9 +98,46 @@ func (typ

[GitHub] [trafficcontrol] ocket8888 merged pull request #4406: Only allow changing of types based on useintable

2020-03-18 Thread GitBox
ocket merged pull request #4406: Only allow changing of types based on useintable URL: https://github.com/apache/trafficcontrol/pull/4406 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [trafficcontrol] shamrickus commented on a change in pull request #4506: Deprecate GET statuses/:id

2020-03-18 Thread GitBox
shamrickus commented on a change in pull request #4506: Deprecate GET statuses/:id URL: https://github.com/apache/trafficcontrol/pull/4506#discussion_r394648584 ## File path: docs/source/api/v1/statuses_id.rst ## @@ -21,6 +21,9 @@ ``GET`` === +.. deprecated::

[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #4521: Multi-interface Servers blueprint

2020-03-18 Thread GitBox
mitchell852 commented on a change in pull request #4521: Multi-interface Servers blueprint URL: https://github.com/apache/trafficcontrol/pull/4521#discussion_r394588892 ## File path: blueprints/multi-interface-servers.md ## @@ -0,0 +1,657 @@ + +# Additional Server

[GitHub] [trafficcontrol] shamrickus commented on a change in pull request #4506: Deprecate GET statuses/:id

2020-03-18 Thread GitBox
shamrickus commented on a change in pull request #4506: Deprecate GET statuses/:id URL: https://github.com/apache/trafficcontrol/pull/4506#discussion_r394648584 ## File path: docs/source/api/v1/statuses_id.rst ## @@ -21,6 +21,9 @@ ``GET`` === +.. deprecated::

[GitHub] [trafficcontrol] shamrickus commented on issue #4507: Deprecate GET tenants/:id

2020-03-18 Thread GitBox
shamrickus commented on issue #4507: Deprecate GET tenants/:id URL: https://github.com/apache/trafficcontrol/pull/4507#issuecomment-600882228 There is a merge conflict though This is an automated message from the Apache Git

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #4506: Deprecate GET statuses/:id

2020-03-18 Thread GitBox
mhoppa commented on a change in pull request #4506: Deprecate GET statuses/:id URL: https://github.com/apache/trafficcontrol/pull/4506#discussion_r394649712 ## File path: docs/source/api/v1/statuses_id.rst ## @@ -21,6 +21,9 @@ ``GET`` === +.. deprecated:: ATCv4 +

[GitHub] [trafficcontrol] mitchell852 commented on issue #4518: Add service category feature to TO and TP

2020-03-18 Thread GitBox
mitchell852 commented on issue #4518: Add service category feature to TO and TP URL: https://github.com/apache/trafficcontrol/pull/4518#issuecomment-600801253 also, those 2 sql scripts under additional info seem like something very specific to a certain companies use of edge header

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #4505: Deprecate GET servers id

2020-03-18 Thread GitBox
mhoppa commented on a change in pull request #4505: Deprecate GET servers id URL: https://github.com/apache/trafficcontrol/pull/4505#discussion_r394618147 ## File path: docs/source/api/v2/servers_id.rst ## @@ -19,179 +19,6 @@ ``servers/{{ID}}`` **

[GitHub] [trafficcontrol] shamrickus commented on a change in pull request #4505: Deprecate GET servers id

2020-03-18 Thread GitBox
shamrickus commented on a change in pull request #4505: Deprecate GET servers id URL: https://github.com/apache/trafficcontrol/pull/4505#discussion_r394616711 ## File path: docs/source/api/v2/servers_id.rst ## @@ -19,179 +19,6 @@ ``servers/{{ID}}`` **

[GitHub] [trafficcontrol] mitchell852 edited a comment on issue #4518: Add service category feature to TO and TP

2020-03-18 Thread GitBox
mitchell852 edited a comment on issue #4518: Add service category feature to TO and TP URL: https://github.com/apache/trafficcontrol/pull/4518#issuecomment-600801253 also, those 2 sql scripts under additional info seem like something very specific to a certain company's use of edge header

[GitHub] [trafficcontrol] ocket8888 merged pull request #4505: Deprecate GET servers id

2020-03-18 Thread GitBox
ocket merged pull request #4505: Deprecate GET servers id URL: https://github.com/apache/trafficcontrol/pull/4505 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #4521: Multi-interface Servers blueprint

2020-03-18 Thread GitBox
mitchell852 commented on a change in pull request #4521: Multi-interface Servers blueprint URL: https://github.com/apache/trafficcontrol/pull/4521#discussion_r394739192 ## File path: blueprints/multi-interface-servers.md ## @@ -0,0 +1,666 @@ + +# Additional Server

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4521: Multi-interface Servers blueprint

2020-03-18 Thread GitBox
ocket commented on a change in pull request #4521: Multi-interface Servers blueprint URL: https://github.com/apache/trafficcontrol/pull/4521#discussion_r394759337 ## File path: blueprints/multi-interface-servers.md ## @@ -0,0 +1,666 @@ + +# Additional Server

[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #4521: Multi-interface Servers blueprint

2020-03-18 Thread GitBox
mitchell852 commented on a change in pull request #4521: Multi-interface Servers blueprint URL: https://github.com/apache/trafficcontrol/pull/4521#discussion_r394743538 ## File path: blueprints/multi-interface-servers.md ## @@ -0,0 +1,666 @@ + +# Additional Server

[GitHub] [trafficcontrol] zrhoffman opened a new pull request #4523: CDN-in-a-Box: Downgrade Python Traffic Ops client

2020-03-18 Thread GitBox
zrhoffman opened a new pull request #4523: CDN-in-a-Box: Downgrade Python Traffic Ops client URL: https://github.com/apache/trafficcontrol/pull/4523 ## What does this PR (Pull Request) do? - [x] This PR fixes #4496 No documentation is included because the endpoints

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4521: Multi-interface Servers blueprint

2020-03-18 Thread GitBox
ocket commented on a change in pull request #4521: Multi-interface Servers blueprint URL: https://github.com/apache/trafficcontrol/pull/4521#discussion_r394760292 ## File path: blueprints/multi-interface-servers.md ## @@ -0,0 +1,666 @@ + +# Additional Server

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4521: Multi-interface Servers blueprint

2020-03-18 Thread GitBox
ocket commented on a change in pull request #4521: Multi-interface Servers blueprint URL: https://github.com/apache/trafficcontrol/pull/4521#discussion_r394759817 ## File path: blueprints/multi-interface-servers.md ## @@ -0,0 +1,666 @@ + +# Additional Server

Build failed in Jenkins: trafficcontrol-PR #5530

2020-03-18 Thread Apache Jenkins Server
See Changes: [github] Removed references to '/internal/' API endpoints (#4494) [github] Only allow changing of types based on useintable (#4406) [github] Deprecate GET servers id (#4505) [github] Deprecate

[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #4521: Multi-interface Servers blueprint

2020-03-18 Thread GitBox
mitchell852 commented on a change in pull request #4521: Multi-interface Servers blueprint URL: https://github.com/apache/trafficcontrol/pull/4521#discussion_r394739703 ## File path: blueprints/multi-interface-servers.md ## @@ -0,0 +1,666 @@ + +# Additional Server

[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #4521: Multi-interface Servers blueprint

2020-03-18 Thread GitBox
mitchell852 commented on a change in pull request #4521: Multi-interface Servers blueprint URL: https://github.com/apache/trafficcontrol/pull/4521#discussion_r394739703 ## File path: blueprints/multi-interface-servers.md ## @@ -0,0 +1,666 @@ + +# Additional Server

[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #4521: Multi-interface Servers blueprint

2020-03-18 Thread GitBox
mitchell852 commented on a change in pull request #4521: Multi-interface Servers blueprint URL: https://github.com/apache/trafficcontrol/pull/4521#discussion_r394739703 ## File path: blueprints/multi-interface-servers.md ## @@ -0,0 +1,666 @@ + +# Additional Server

[GitHub] [trafficcontrol] ocket8888 commented on issue #4521: Multi-interface Servers blueprint

2020-03-18 Thread GitBox
ocket commented on issue #4521: Multi-interface Servers blueprint URL: https://github.com/apache/trafficcontrol/pull/4521#issuecomment-600959404 > ... changes to TM UI... None are necessary. The TM UI has no special handling regarding _why_ a server is unavailable, it only knows

[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #4521: Multi-interface Servers blueprint

2020-03-18 Thread GitBox
mitchell852 commented on a change in pull request #4521: Multi-interface Servers blueprint URL: https://github.com/apache/trafficcontrol/pull/4521#discussion_r394588892 ## File path: blueprints/multi-interface-servers.md ## @@ -0,0 +1,657 @@ + +# Additional Server

[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #4521: Multi-interface Servers blueprint

2020-03-18 Thread GitBox
mitchell852 commented on a change in pull request #4521: Multi-interface Servers blueprint URL: https://github.com/apache/trafficcontrol/pull/4521#discussion_r394588892 ## File path: blueprints/multi-interface-servers.md ## @@ -0,0 +1,657 @@ + +# Additional Server

[GitHub] [trafficcontrol] jehunte commented on issue #4518: Add service category feature to TO and TP

2020-03-18 Thread GitBox
jehunte commented on issue #4518: Add service category feature to TO and TP URL: https://github.com/apache/trafficcontrol/pull/4518#issuecomment-600818054 @rob05c @mitchell852 These are great points. I will require a tenant to be associated with the service categories so tenants can only

[GitHub] [trafficcontrol] mitchell852 merged pull request #4494: Removed references to '/internal/' API endpoints

2020-03-18 Thread GitBox
mitchell852 merged pull request #4494: Removed references to '/internal/' API endpoints URL: https://github.com/apache/trafficcontrol/pull/4494 This is an automated message from the Apache Git Service. To respond to the

Build failed in Jenkins: trafficcontrol-traffic_ops-test #1896

2020-03-18 Thread Apache Jenkins Server
See Changes: [github] Only allow changing of types based on useintable (#4406) -- [...truncated 93.53 KB...] unit_golang_1 | --- PASS:

Build failed in Jenkins: trafficcontrol-traffic_ops-test #1897

2020-03-18 Thread Apache Jenkins Server
See Changes: [github] Deprecate GET servers id (#4505) -- [...truncated 93.62 KB...] unit_golang_1 | --- PASS:

[GitHub] [trafficcontrol] shamrickus commented on a change in pull request #4506: Deprecate GET statuses/:id

2020-03-18 Thread GitBox
shamrickus commented on a change in pull request #4506: Deprecate GET statuses/:id URL: https://github.com/apache/trafficcontrol/pull/4506#discussion_r394653475 ## File path: docs/source/api/v1/statuses_id.rst ## @@ -21,6 +21,9 @@ ``GET`` === +.. deprecated::

[GitHub] [trafficcontrol] rawlinp merged pull request #4506: Deprecate GET statuses/:id

2020-03-18 Thread GitBox
rawlinp merged pull request #4506: Deprecate GET statuses/:id URL: https://github.com/apache/trafficcontrol/pull/4506 This is an automated message from the Apache Git Service. To respond to the message, please log on to