[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7169: Update TPv2 dependencies and node version

2022-11-03 Thread GitBox
ocket commented on code in PR #7169: URL: https://github.com/apache/trafficcontrol/pull/7169#discussion_r1013031890 ## experimental/traffic-portal/package.json: ## @@ -1,119 +1,119 @@ { - "name": "traffic-portal", - "version": "0.4.1", - "description": "The web UI for

[GitHub] [trafficcontrol] ocket8888 merged pull request #7170: Use tonistiigi/binfmt to emulate arm64

2022-11-03 Thread GitBox
ocket merged PR #7170: URL: https://github.com/apache/trafficcontrol/pull/7170 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7099: Delivery Service Active Flag Rework

2022-11-03 Thread GitBox
ocket commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1013301078 ## traffic_ops/traffic_ops_golang/deliveryservice/deliveryservices.go: ## @@ -138,7 +162,7 @@ func CreateV30(w http.ResponseWriter, r *http.Request) {

[GitHub] [trafficcontrol] ocket8888 commented on pull request #7099: Delivery Service Active Flag Rework

2022-11-03 Thread GitBox
ocket commented on PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#issuecomment-1302550947 I need to change the migration file names because new migrations have been added since this PR opened. I'm in a meeting atm, I'll do it this afternoon. -- This is an automated

[GitHub] [trafficcontrol] rob05c commented on pull request #7167: Fix t3c test duplication and upgrade to v4

2022-11-03 Thread GitBox
rob05c commented on PR #7167: URL: https://github.com/apache/trafficcontrol/pull/7167#issuecomment-1302711780 It'd be really good to do this to v5 as well, so the t3c Integration Tests can easily share that too, when it comes time to upgrade them. But that can be done separately. --

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7099: Delivery Service Active Flag Rework

2022-11-03 Thread GitBox
rimashah25 commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1009828166 ## traffic_ops/traffic_ops_golang/deliveryservice/deliveryservices.go: ## @@ -138,7 +162,7 @@ func CreateV30(w http.ResponseWriter, r *http.Request) {

[GitHub] [trafficcontrol] rimashah25 commented on pull request #7099: Delivery Service Active Flag Rework

2022-11-03 Thread GitBox
rimashah25 commented on PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#issuecomment-1302958291 Tested and reviewed the following: 1. Able to create DS with 3 states (Active, Primed, Inactive) using APIv5 2. Able to create DS with 2 states (as expected) (Active=true,