[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7615: Traffic Portal v2 Topologies details page

zrhoffman commented on code in PR #7615: URL: https://github.com/apache/trafficcontrol/pull/7615#discussion_r1273677888 ## experimental/traffic-portal/src/app/api/topology.service.ts: ## @@ -0,0 +1,196 @@ +/* +* Licensed under the Apache License, Version 2.0 (the "License"); +*

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7615: Traffic Portal v2 Topologies details page

zrhoffman commented on code in PR #7615: URL: https://github.com/apache/trafficcontrol/pull/7615#discussion_r1273678356 ## experimental/traffic-portal/src/app/api/topology.service.ts: ## @@ -0,0 +1,196 @@ +/* +* Licensed under the Apache License, Version 2.0 (the "License"); +*

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7615: Traffic Portal v2 Topologies details page

zrhoffman commented on code in PR #7615: URL: https://github.com/apache/trafficcontrol/pull/7615#discussion_r1273698139 ## experimental/traffic-portal/src/app/api/topology.service.ts: ## @@ -0,0 +1,196 @@ +/* +* Licensed under the Apache License, Version 2.0 (the "License"); +*

[GitHub] [trafficcontrol] ocket8888 opened a new pull request, #7673: Tpv2 logging overhaul

ocket opened a new pull request, #7673: URL: https://github.com/apache/trafficcontrol/pull/7673 This PR overhauls the way TPv2 does logging to be more consistent. At present, it's not configurable, it just omits debug-level messages if it's in a production environment. The idea was

[GitHub] [trafficcontrol] Kashatlast2 commented on a diff in pull request #7604: Added api contract profile parameters test case

Kashatlast2 commented on code in PR #7604: URL: https://github.com/apache/trafficcontrol/pull/7604#discussion_r1273660394 ## traffic_ops/testing/api_contract/v4/conftest.py: ## @@ -1643,3 +1643,43 @@ def delivery_services_regex_data_post(to_session: TOSession,

[GitHub] [trafficcontrol] Kashatlast2 commented on a diff in pull request #7604: Added api contract profile parameters test case

Kashatlast2 commented on code in PR #7604: URL: https://github.com/apache/trafficcontrol/pull/7604#discussion_r1273911666 ## traffic_ops/testing/api_contract/v4/conftest.py: ## @@ -1643,3 +1643,43 @@ def delivery_services_regex_data_post(to_session: TOSession,

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7615: Traffic Portal v2 Topologies details page

zrhoffman commented on code in PR #7615: URL: https://github.com/apache/trafficcontrol/pull/7615#discussion_r1273679698 ## experimental/traffic-portal/src/app/api/testing/topology.service.ts: ## @@ -0,0 +1,130 @@ +/* +* Licensed under the Apache License, Version 2.0 (the

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7615: Traffic Portal v2 Topologies details page

zrhoffman commented on code in PR #7615: URL: https://github.com/apache/trafficcontrol/pull/7615#discussion_r1273678837 ## experimental/traffic-portal/src/app/core/topologies/topology-details/topology-details.component.html: ## @@ -0,0 +1,45 @@ + + + + +

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7615: Traffic Portal v2 Topologies details page

zrhoffman commented on code in PR #7615: URL: https://github.com/apache/trafficcontrol/pull/7615#discussion_r1273677580 ## experimental/traffic-portal/src/app/api/testing/topology.service.ts: ## @@ -0,0 +1,130 @@ +/* +* Licensed under the Apache License, Version 2.0 (the

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7615: Traffic Portal v2 Topologies details page

zrhoffman commented on code in PR #7615: URL: https://github.com/apache/trafficcontrol/pull/7615#discussion_r1273679183 ## experimental/traffic-portal/src/app/core/topologies/topology-details/topology-details.component.html: ## @@ -0,0 +1,45 @@ + + + + Review

[GitHub] [trafficcontrol] TerekhovaKate commented on a diff in pull request #7604: Added api contract profile parameters test case

TerekhovaKate commented on code in PR #7604: URL: https://github.com/apache/trafficcontrol/pull/7604#discussion_r1273653076 ## traffic_ops/testing/api_contract/v4/test_profile_parameters.py: ## @@ -0,0 +1,90 @@ +# +# Licensed under the Apache License, Version 2.0 (the

[GitHub] [trafficcontrol] Kashatlast2 commented on a diff in pull request #7604: Added api contract profile parameters test case

Kashatlast2 commented on code in PR #7604: URL: https://github.com/apache/trafficcontrol/pull/7604#discussion_r1273927806 ## traffic_ops/testing/api_contract/v4/conftest.py: ## @@ -1643,3 +1643,43 @@ def delivery_services_regex_data_post(to_session: TOSession,

[GitHub] [trafficcontrol] Kashatlast2 commented on a diff in pull request #7604: Added api contract profile parameters test case

Kashatlast2 commented on code in PR #7604: URL: https://github.com/apache/trafficcontrol/pull/7604#discussion_r1273973416 ## traffic_ops/testing/api_contract/v4/conftest.py: ## @@ -1643,3 +1643,39 @@ def delivery_services_regex_data_post(to_session: TOSession,

[GitHub] [trafficcontrol] TerekhovaKate commented on a diff in pull request #7604: Added api contract profile parameters test case

TerekhovaKate commented on code in PR #7604: URL: https://github.com/apache/trafficcontrol/pull/7604#discussion_r1273667438 ## traffic_ops/testing/api_contract/v4/conftest.py: ## @@ -1643,3 +1643,43 @@ def delivery_services_regex_data_post(to_session: TOSession,

[GitHub] [trafficcontrol] github-code-scanning[bot] commented on a diff in pull request #7673: Tpv2 logging overhaul

github-code-scanning[bot] commented on code in PR #7673: URL: https://github.com/apache/trafficcontrol/pull/7673#discussion_r1273967515 ## experimental/traffic-portal/src/app/utils/logging.ts: ## @@ -0,0 +1,227 @@ +/** + * @license Apache-2.0 + * + * Licensed under the Apache

[GitHub] [trafficcontrol] gokulakrishnansvm commented on a diff in pull request #7604: Added api contract profile parameters test case

gokulakrishnansvm commented on code in PR #7604: URL: https://github.com/apache/trafficcontrol/pull/7604#discussion_r1273939123 ## traffic_ops/testing/api_contract/v4/conftest.py: ## @@ -1643,3 +1643,39 @@ def delivery_services_regex_data_post(to_session: TOSession,

[GitHub] [trafficcontrol] gokulakrishnansvm commented on a diff in pull request #7604: Added api contract profile parameters test case

gokulakrishnansvm commented on code in PR #7604: URL: https://github.com/apache/trafficcontrol/pull/7604#discussion_r1273939123 ## traffic_ops/testing/api_contract/v4/conftest.py: ## @@ -1643,3 +1643,39 @@ def delivery_services_regex_data_post(to_session: TOSession,

[GitHub] [trafficcontrol] TerekhovaKate commented on a diff in pull request #7604: Added api contract profile parameters test case

TerekhovaKate commented on code in PR #7604: URL: https://github.com/apache/trafficcontrol/pull/7604#discussion_r1273651231 ## traffic_ops/testing/api_contract/v4/conftest.py: ## @@ -1643,3 +1643,43 @@ def delivery_services_regex_data_post(to_session: TOSession,

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7615: Traffic Portal v2 Topologies details page

zrhoffman commented on code in PR #7615: URL: https://github.com/apache/trafficcontrol/pull/7615#discussion_r1273676836 ## experimental/traffic-portal/src/app/api/testing/topology.service.ts: ## @@ -0,0 +1,130 @@ +/* +* Licensed under the Apache License, Version 2.0 (the

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7615: Traffic Portal v2 Topologies details page

zrhoffman commented on code in PR #7615: URL: https://github.com/apache/trafficcontrol/pull/7615#discussion_r1273676562 ## experimental/traffic-portal/src/app/api/testing/topology.service.ts: ## @@ -0,0 +1,130 @@ +/* +* Licensed under the Apache License, Version 2.0 (the

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7615: Traffic Portal v2 Topologies details page

zrhoffman commented on code in PR #7615: URL: https://github.com/apache/trafficcontrol/pull/7615#discussion_r1273677206 ## experimental/traffic-portal/src/app/api/topology.service.ts: ## @@ -0,0 +1,196 @@ +/* +* Licensed under the Apache License, Version 2.0 (the "License"); +*

[GitHub] [trafficcontrol] Kashatlast2 commented on a diff in pull request #7604: Added api contract profile parameters test case

Kashatlast2 commented on code in PR #7604: URL: https://github.com/apache/trafficcontrol/pull/7604#discussion_r1273911666 ## traffic_ops/testing/api_contract/v4/conftest.py: ## @@ -1643,3 +1643,43 @@ def delivery_services_regex_data_post(to_session: TOSession,

[GitHub] [trafficcontrol] Kashatlast2 commented on a diff in pull request #7604: Added api contract profile parameters test case

Kashatlast2 commented on code in PR #7604: URL: https://github.com/apache/trafficcontrol/pull/7604#discussion_r1273595907 ## traffic_ops/testing/api_contract/v4/conftest.py: ## @@ -1643,3 +1643,43 @@ def delivery_services_regex_data_post(to_session: TOSession,

[GitHub] [trafficcontrol] Kashatlast2 commented on a diff in pull request #7604: Added api contract profile parameters test case

Kashatlast2 commented on code in PR #7604: URL: https://github.com/apache/trafficcontrol/pull/7604#discussion_r1273941809 ## traffic_ops/testing/api_contract/v4/conftest.py: ## @@ -1643,3 +1643,39 @@ def delivery_services_regex_data_post(to_session: TOSession,

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7652: t3c to use package metadata if rpm db is unhealthy

ocket commented on code in PR #7652: URL: https://github.com/apache/trafficcontrol/pull/7652#discussion_r1274160634 ## cache-config/t3c-apply/torequest/torequest.go: ## @@ -1030,6 +1034,45 @@ func (r *TrafficOpsReq) ProcessPackages() error { return nil } +func

[GitHub] [trafficcontrol] jpappa200 opened a new issue, #7674: add update and reval flag to indicate failure

jpappa200 opened a new issue, #7674: URL: https://github.com/apache/trafficcontrol/issues/7674 ## This Feature Request affects these Traffic Control components: - Traffic Control Cache Config (`t3c`, formerly ORT) - Traffic Ops - Traffic Portal ## Description