[GitHub] rob05c commented on issue #2232: Rewrite Traffic Ops CRConfig Table Endpoints in Go

2018-05-18 Thread GitBox
rob05c commented on issue #2232: Rewrite Traffic Ops CRConfig Table Endpoints in Go URL: https://github.com/apache/incubator-trafficcontrol/issues/2232#issuecomment-387444293 Ok, we have PRs for all major table routes, but many of them are only "CRUD", and missing additional endpoints.

[GitHub] asfgit commented on issue #2300: Add TO Go cachegroups/id/deliveryservices

2018-05-18 Thread GitBox
asfgit commented on issue #2300: Add TO Go cachegroups/id/deliveryservices URL: https://github.com/apache/incubator-trafficcontrol/pull/2300#issuecomment-390361620 Refer to this link for build results (access rights to CI server needed):

[GitHub] rob05c commented on issue #2232: Rewrite Traffic Ops CRConfig Table Endpoints in Go

2018-05-18 Thread GitBox
rob05c commented on issue #2232: Rewrite Traffic Ops CRConfig Table Endpoints in Go URL: https://github.com/apache/incubator-trafficcontrol/issues/2232#issuecomment-387444293 Ok, we have PRs for all major table routes, but many of them are only "CRUD", and missing additional endpoints.

[GitHub] rob05c opened a new pull request #2300: Add TO Go cachegroups/id/deliveryservices

2018-05-18 Thread GitBox
rob05c opened a new pull request #2300: Add TO Go cachegroups/id/deliveryservices URL: https://github.com/apache/incubator-trafficcontrol/pull/2300 This is an automated message from the Apache Git Service. To respond to the

[GitHub] knutsel commented on issue #2262: Part 1 of Range Request handling

2018-05-18 Thread GitBox
knutsel commented on issue #2262: Part 1 of Range Request handling URL: https://github.com/apache/incubator-trafficcontrol/pull/2262#issuecomment-390333856 All review comments are addressed in the last commit. Thanks @rob05c !

[GitHub] asfgit commented on issue #2262: Part 1 of Range Request handling

2018-05-18 Thread GitBox
asfgit commented on issue #2262: Part 1 of Range Request handling URL: https://github.com/apache/incubator-trafficcontrol/pull/2262#issuecomment-390329494 Refer to this link for build results (access rights to CI server needed):

[GitHub] asfgit commented on issue #2256: Add TO Go profile parameters routes

2018-05-18 Thread GitBox
asfgit commented on issue #2256: Add TO Go profile parameters routes URL: https://github.com/apache/incubator-trafficcontrol/pull/2256#issuecomment-390306299 Refer to this link for build results (access rights to CI server needed):

[GitHub] rob05c commented on issue #2256: Add TO Go profile parameters routes

2018-05-18 Thread GitBox
rob05c commented on issue #2256: Add TO Go profile parameters routes URL: https://github.com/apache/incubator-trafficcontrol/pull/2256#issuecomment-390302932 Fixed This is an automated message from the Apache Git Service. To

Build failed in Jenkins: incubator-trafficcontrol-traffic_ops-test #635

2018-05-18 Thread Apache Jenkins Server
See Changes: [dangogh] allow the user to skip delivery service requests if they have the [mitchell852] Add TO Go deliveryservicesregexes --

Build failed in Jenkins: incubator-trafficcontrol-traffic_ops-test #634

2018-05-18 Thread Apache Jenkins Server
See Changes: [dangogh] dereference string pointer when calling printf -- [...truncated 2.53 MB...] unit_1 | Use of uninitialized value in

[GitHub] mitchell852 commented on issue #2256: Add TO Go profile parameters routes

2018-05-18 Thread GitBox
mitchell852 commented on issue #2256: Add TO Go profile parameters routes URL: https://github.com/apache/incubator-trafficcontrol/pull/2256#issuecomment-390287473 @rob05c - conflicts...sorry :( This is an automated message

[GitHub] mitchell852 closed pull request #2229: Add Traffic Ops Golang deliveryservicesregexes

2018-05-18 Thread GitBox
mitchell852 closed pull request #2229: Add Traffic Ops Golang deliveryservicesregexes URL: https://github.com/apache/incubator-trafficcontrol/pull/2229 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] dangogh closed pull request #2271: allow the option to immediately fulfill DSR (d…

2018-05-18 Thread GitBox
dangogh closed pull request #2271: allow the option to immediately fulfill DSR (d… URL: https://github.com/apache/incubator-trafficcontrol/pull/2271 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] dangogh closed issue #2174: TO/TP should allow for a configuration such that admins do not have to submit DSRs

2018-05-18 Thread GitBox
dangogh closed issue #2174: TO/TP should allow for a configuration such that admins do not have to submit DSRs URL: https://github.com/apache/incubator-trafficcontrol/issues/2174 This is an automated message from the Apache

Jenkins build is back to normal : incubator-trafficcontrol-PR-rat #891

2018-05-18 Thread Apache Jenkins Server
See

[GitHub] dewrich closed pull request #2298: fix config_test.go to keep it up to date with changes to LoadConfig

2018-05-18 Thread GitBox
dewrich closed pull request #2298: fix config_test.go to keep it up to date with changes to LoadConfig URL: https://github.com/apache/incubator-trafficcontrol/pull/2298 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

Build failed in Jenkins: incubator-trafficcontrol-PR-rat #890

2018-05-18 Thread Apache Jenkins Server
See -- Started by upstream project "incubator-trafficcontrol-PR" build number 1609 originally caused by: GitHub pull request #2298 of commit

[GitHub] asfgit commented on issue #2298: fix config_test.go to keep it up to date with changes to LoadConfig

2018-05-18 Thread GitBox
asfgit commented on issue #2298: fix config_test.go to keep it up to date with changes to LoadConfig URL: https://github.com/apache/incubator-trafficcontrol/pull/2298#issuecomment-390264004 Refer to this link for build results (access rights to CI server needed):

Jenkins build is back to normal : incubator-trafficcontrol-rat #729

2018-05-18 Thread Apache Jenkins Server
See

Build failed in Jenkins: incubator-trafficcontrol-traffic_ops-test #632

2018-05-18 Thread Apache Jenkins Server
See Changes: [dangogh] Add Grove vendors to .rat-excludes -- [...truncated 95.00 KB...] unit_golang_1 | --- PASS: TestInterfaces (0.00s)

[GitHub] dangogh closed pull request #2296: Add Grove vendors to .rat-excludes

2018-05-18 Thread GitBox
dangogh closed pull request #2296: Add Grove vendors to .rat-excludes URL: https://github.com/apache/incubator-trafficcontrol/pull/2296 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] DylanVolz opened a new pull request #2298: fix config_test.go to keep it up to date with changes to LoadConfig

2018-05-18 Thread GitBox
DylanVolz opened a new pull request #2298: fix config_test.go to keep it up to date with changes to LoadConfig URL: https://github.com/apache/incubator-trafficcontrol/pull/2298 This is an automated message from the Apache

Build failed in Jenkins: incubator-trafficcontrol-PR-rat #889

2018-05-18 Thread Apache Jenkins Server
See -- Started by upstream project "incubator-trafficcontrol-PR" build number 1608 originally caused by: GitHub pull request #2297 of commit

[GitHub] asfgit commented on issue #2297: Add TO Go cachegroups/trimmed

2018-05-18 Thread GitBox
asfgit commented on issue #2297: Add TO Go cachegroups/trimmed URL: https://github.com/apache/incubator-trafficcontrol/pull/2297#issuecomment-390261269 Refer to this link for build results (access rights to CI server needed):

[GitHub] rob05c commented on issue #2232: Rewrite Traffic Ops CRConfig Table Endpoints in Go

2018-05-18 Thread GitBox
rob05c commented on issue #2232: Rewrite Traffic Ops CRConfig Table Endpoints in Go URL: https://github.com/apache/incubator-trafficcontrol/issues/2232#issuecomment-387444293 Ok, we have PRs for all major table routes, but many of them are only "CRUD", and missing additional endpoints.

[GitHub] rob05c opened a new pull request #2297: Add TO Go cachegroups/trimmed

2018-05-18 Thread GitBox
rob05c opened a new pull request #2297: Add TO Go cachegroups/trimmed URL: https://github.com/apache/incubator-trafficcontrol/pull/2297 This is an automated message from the Apache Git Service. To respond to the message,

Jenkins build is back to normal : incubator-trafficcontrol-PR-rat #888

2018-05-18 Thread Apache Jenkins Server
See

[GitHub] asfgit commented on issue #2296: Add Grove vendors to .rat-excludes

2018-05-18 Thread GitBox
asfgit commented on issue #2296: Add Grove vendors to .rat-excludes URL: https://github.com/apache/incubator-trafficcontrol/pull/2296#issuecomment-390257563 Refer to this link for build results (access rights to CI server needed):

[GitHub] rob05c opened a new pull request #2296: Add Grove vendors to .rat-excludes

2018-05-18 Thread GitBox
rob05c opened a new pull request #2296: Add Grove vendors to .rat-excludes URL: https://github.com/apache/incubator-trafficcontrol/pull/2296 Tested with rat, succeeds with `0 Unknown Licenses` This is an automated message

Build failed in Jenkins: incubator-trafficcontrol-rat #728

2018-05-18 Thread Apache Jenkins Server
See -- Started by upstream project "incubator-trafficcontrol-master-build" build number 772 originally caused by: Started by an SCM change Started by an SCM change

[GitHub] dewrich closed issue #2274: Profiles endpoint unordered

2018-05-18 Thread GitBox
dewrich closed issue #2274: Profiles endpoint unordered URL: https://github.com/apache/incubator-trafficcontrol/issues/2274 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] rob05c commented on issue #2274: Profiles endpoint unordered

2018-05-18 Thread GitBox
rob05c commented on issue #2274: Profiles endpoint unordered URL: https://github.com/apache/incubator-trafficcontrol/issues/2274#issuecomment-390222865 I agree we should revisit `orderby` in API 2.0. However, currently, 1.x/profiles doesn't support orderby, per

[GitHub] mitchell852 commented on issue #2274: Profiles endpoint unordered

2018-05-18 Thread GitBox
mitchell852 commented on issue #2274: Profiles endpoint unordered URL: https://github.com/apache/incubator-trafficcontrol/issues/2274#issuecomment-390216359 @rob05c - its weird imo to have some apis support orderby and others not support it in API 1.x. How about we revisit this

[GitHub] smalenfant commented on issue #1210: CDN APIs: Routing

2018-05-18 Thread GitBox
smalenfant commented on issue #1210: CDN APIs: Routing URL: https://github.com/apache/incubator-trafficcontrol/issues/1210#issuecomment-390212306 Hopefully this fixes #902 at the same time. Just adding for reference. This is

[GitHub] jifyang opened a new pull request #2295: secondary IPs support: alter server

2018-05-18 Thread GitBox
jifyang opened a new pull request #2295: secondary IPs support: alter server URL: https://github.com/apache/incubator-trafficcontrol/pull/2295 fixes #2293 WIP (Work In Process) This PR is based on #2294 More work is needed for this PR.

Build failed in Jenkins: incubator-trafficcontrol-PR-rat #886

2018-05-18 Thread Apache Jenkins Server
See -- Started by upstream project "incubator-trafficcontrol-PR" build number 1605 originally caused by: GitHub pull request #2294 of commit

[GitHub] asfgit commented on issue #2294: secondary IPs support: add interface and ip

2018-05-18 Thread GitBox
asfgit commented on issue #2294: secondary IPs support: add interface and ip URL: https://github.com/apache/incubator-trafficcontrol/pull/2294#issuecomment-390122448 Refer to this link for build results (access rights to CI server needed):

[GitHub] jifyang opened a new pull request #2294: secondary IPs support: add interface and ip

2018-05-18 Thread GitBox
jifyang opened a new pull request #2294: secondary IPs support: add interface and ip URL: https://github.com/apache/incubator-trafficcontrol/pull/2294 This is an automated message from the Apache Git Service. To respond to