Build failed in Jenkins: incubator-trafficcontrol-traffic_ops-test #643

[Apache Jenkins Server]

See 


Changes:

[mitchell852] Add TO Go cachegroups/trimmed

--
[...truncated 97.27 KB...]
unit_golang_1  | --- PASS: TestFuncs (0.00s)
unit_golang_1  | === RUN   TestInterfaces
unit_golang_1  | --- PASS: TestInterfaces (0.00s)
unit_golang_1  | === RUN   TestValidate
unit_golang_1  | --- PASS: TestValidate (0.00s)
unit_golang_1  | PASS
unit_golang_1  | coverage: 23.0% of statements
unit_golang_1  | ok 
github.com/apache/incubator-trafficcontrol/traffic_ops/traffic_ops_golang/cdn   
0.014s  coverage: 23.0% of statements
unit_golang_1  | === RUN   TestLogLocation
unit_golang_1  | --- PASS: TestLogLocation (0.00s)
unit_golang_1  | === RUN   TestLoadConfig
unit_golang_1  | --- PASS: TestLoadConfig (0.01s)
unit_golang_1  | PASS
unit_golang_1  | coverage: 64.2% of statements
unit_golang_1  | ok 
github.com/apache/incubator-trafficcontrol/traffic_ops/traffic_ops_golang/config
0.043s  coverage: 64.2% of statements
unit_golang_1  | === RUN   TestReadCoordinates
unit_golang_1  | --- PASS: TestReadCoordinates (0.00s)
unit_golang_1  | === RUN   TestFuncs
unit_golang_1  | --- PASS: TestFuncs (0.00s)
unit_golang_1  | === RUN   TestInterfaces
unit_golang_1  | --- PASS: TestInterfaces (0.00s)
unit_golang_1  | === RUN   TestValidate
unit_golang_1  | --- PASS: TestValidate (0.00s)
unit_golang_1  | PASS
unit_golang_1  | coverage: 23.7% of statements
unit_golang_1  | ok 
github.com/apache/incubator-trafficcontrol/traffic_ops/traffic_ops_golang/coordinate
0.031s  coverage: 23.7% of statements
unit_golang_1  | === RUN   TestGetConfigParams
unit_golang_1  | --- PASS: TestGetConfigParams (0.00s)
unit_golang_1  | === RUN   TestMakeCRConfigConfig
unit_golang_1  | --- PASS: TestMakeCRConfigConfig (0.00s)
unit_golang_1  | === RUN   TestMakeDSes
unit_golang_1  | --- PASS: TestMakeDSes (0.00s)
unit_golang_1  | === RUN   TestGetServerProfileParams
unit_golang_1  | --- PASS: TestGetServerProfileParams (0.00s)
unit_golang_1  | === RUN   TestGetDSRegexesDomains
unit_golang_1  | --- PASS: TestGetDSRegexesDomains (0.00s)
unit_golang_1  | === RUN   TestGetStaticDNSEntries
unit_golang_1  | --- PASS: TestGetStaticDNSEntries (0.00s)
unit_golang_1  | === RUN   TestMakeLocations
unit_golang_1  | --- PASS: TestMakeLocations (0.00s)
unit_golang_1  | === RUN   TestGetServerParams
unit_golang_1  | --- PASS: TestGetServerParams (0.00s)
unit_golang_1  | === RUN   TestGetAllServers
unit_golang_1  | --- PASS: TestGetAllServers (0.00s)
unit_golang_1  | === RUN   TestGetServerDSNames
unit_golang_1  | --- PASS: TestGetServerDSNames (0.00s)
unit_golang_1  | === RUN   TestGetServerDSes
unit_golang_1  | --- PASS: TestGetServerDSes (0.00s)
unit_golang_1  | === RUN   TestGetCDNInfo
unit_golang_1  | --- PASS: TestGetCDNInfo (0.00s)
unit_golang_1  | === RUN   TestGetCDNNameFromID
unit_golang_1  | --- PASS: TestGetCDNNameFromID (0.00s)
unit_golang_1  | === RUN   TestGetSnapshot
unit_golang_1  | --- PASS: TestGetSnapshot (0.00s)
unit_golang_1  | === RUN   TestSnapshot
unit_golang_1  | --- PASS: TestSnapshot (0.00s)
unit_golang_1  | === RUN   TestMakeStats
unit_golang_1  | --- PASS: TestMakeStats (0.00s)
unit_golang_1  | PASS
unit_golang_1  | coverage: 50.6% of statements
unit_golang_1  | ok 
github.com/apache/incubator-trafficcontrol/traffic_ops/traffic_ops_golang/crconfig
  0.018s  coverage: 50.6% of statements
unit_golang_1  | === RUN   TestBuildQuery
unit_golang_1  | --- PASS: TestBuildQuery (0.00s)
unit_golang_1  | PASS
unit_golang_1  | coverage: 59.6% of statements
unit_golang_1  | ok 
github.com/apache/incubator-trafficcontrol/traffic_ops/traffic_ops_golang/dbhelpers
 0.062s  coverage: 59.6% of statements
unit_golang_1  | === RUN   TestInterfaces
unit_golang_1  | --- PASS: TestInterfaces (0.00s)
unit_golang_1  | === RUN   TestValidateErrors
unit_golang_1  | --- PASS: TestValidateErrors (0.00s)
unit_golang_1  | PASS
unit_golang_1  | coverage: 3.8% of statements
unit_golang_1  | ok 
github.com/apache/incubator-trafficcontrol/traffic_ops/traffic_ops_golang/deliveryservice
   0.033s  coverage: 3.8% of statements
unit_golang_1  | === RUN   TestInterfaces
unit_golang_1  | --- PASS: TestInterfaces (0.00s)
unit_golang_1  | === RUN   TestGetDeliveryServiceRequest
unit_golang_1  | --- PASS: TestGetDeliveryServiceRequest (0.00s)
unit_golang_1  | PASS
unit_golang_1  | coverage: 2.3% of statements
unit_golang_1  | ok 
github.com/apache/incubator-trafficcontrol/traffic_ops/traffic_ops_golang/deliveryservice/request
   0.012s  coverage: 2.3% of statements
unit_golang_1  | === RUN   TestFuncs
unit_golang_1  | --- PASS: TestFuncs (0.00s)
unit_golang_1  | === RUN   TestInterfaces
unit_golang_1  | --- PASS: TestInterfaces (0.00s)
unit_golang_1  | === RUN   TestValidate
unit_golang_1  | --- PASS: TestValidate (0.00s)
unit_golang_1  | PASS
unit_golang_1  | coverage: 5.7% of 

[GitHub] mitchell852 closed pull request #2297: Add TO Go cachegroups/trimmed

[GitBox]

mitchell852 closed pull request #2297: Add TO Go cachegroups/trimmed
URL: https://github.com/apache/incubator-trafficcontrol/pull/2297
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/lib/go-tc/v13/cachegroups.go b/lib/go-tc/v13/cachegroups.go
index 38ac437ad..ee203fcd5 100644
--- a/lib/go-tc/v13/cachegroups.go
+++ b/lib/go-tc/v13/cachegroups.go
@@ -56,3 +56,7 @@ type CacheGroupNullable struct {
TypeID  *int  `json:"typeId" db:"type_id"`  
   // aliased to type_id to disambiguate struct scans due join on 'type' table
LastUpdated *tc.TimeNoMod `json:"lastUpdated" 
db:"last_updated"`
 }
+
+type CachegroupTrimmedName struct {
+   Name string `json:"name"`
+}
diff --git a/traffic_ops/traffic_ops_golang/cachegroup/trimmed.go 
b/traffic_ops/traffic_ops_golang/cachegroup/trimmed.go
new file mode 100644
index 0..766c372ec
--- /dev/null
+++ b/traffic_ops/traffic_ops_golang/cachegroup/trimmed.go
@@ -0,0 +1,52 @@
+package cachegroup
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import (
+   "database/sql"
+   "errors"
+   "net/http"
+
+   tc "github.com/apache/incubator-trafficcontrol/lib/go-tc/v13"
+   
"github.com/apache/incubator-trafficcontrol/traffic_ops/traffic_ops_golang/api"
+)
+
+func TrimmedHandler(db *sql.DB) http.HandlerFunc {
+   return func(w http.ResponseWriter, r *http.Request) {
+   api.RespWriter(w, r)(getCachegroupsTrimmed(db))
+   }
+}
+
+func getCachegroupsTrimmed(db *sql.DB) ([]tc.CachegroupTrimmedName, error) {
+   names := []tc.CachegroupTrimmedName{}
+   rows, err := db.Query(`SELECT name from cachegroup`)
+   if err != nil {
+   return nil, errors.New("selecting cachegroup names: " + 
err.Error())
+   }
+   defer rows.Close()
+   for rows.Next() {
+   name := ""
+   if err := rows.Scan(); err != nil {
+   return nil, errors.New("scanning cachegroup names: " + 
err.Error())
+   }
+   names = append(names, tc.CachegroupTrimmedName{Name: name})
+   }
+   return names, nil
+}
diff --git a/traffic_ops/traffic_ops_golang/routes.go 
b/traffic_ops/traffic_ops_golang/routes.go
index 8858c327c..d1822bb06 100644
--- a/traffic_ops/traffic_ops_golang/routes.go
+++ b/traffic_ops/traffic_ops_golang/routes.go
@@ -88,6 +88,7 @@ func Routes(d ServerData) ([]Route, []RawRoute, http.Handler, 
error) {
{1.1, http.MethodDelete, `asns/{id}$`, 
api.DeleteHandler(asn.GetRefTypeV11(), d.DB), auth.PrivLevelOperations, 
Authenticated, nil},
 
//CacheGroup: CRUD
+   {1.1, http.MethodGet, `cachegroups/trimmed/?(\.json)?$`, 
cachegroup.TrimmedHandler(d.DB.DB), auth.PrivLevelReadOnly, Authenticated, nil},
{1.1, http.MethodGet, `cachegroups/?(\.json)?$`, 
api.ReadHandler(cachegroup.GetRefType(), d.DB), auth.PrivLevelReadOnly, 
Authenticated, nil},
{1.1, http.MethodGet, `cachegroups/{id}$`, 
api.ReadHandler(cachegroup.GetRefType(), d.DB), auth.PrivLevelReadOnly, 
Authenticated, nil},
{1.1, http.MethodPut, `cachegroups/{id}$`, 
api.UpdateHandler(cachegroup.GetRefType(), d.DB), auth.PrivLevelOperations, 
Authenticated, nil},


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #2318: only show ds form field tooltip when label is clicked

[GitBox]

asfgit commented on issue #2318: only show ds form field tooltip when label is 
clicked
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2318#issuecomment-391201950
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/incubator-trafficcontrol-PR/1653/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mitchell852 opened a new pull request #2318: only show ds form field tooltip when label is clicked

[GitBox]

mitchell852 opened a new pull request #2318: only show ds form field tooltip 
when label is clicked
URL: https://github.com/apache/incubator-trafficcontrol/pull/2318
 
 
   fixes #2196 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mitchell852 commented on issue #2275: Download ISO should actually download the ISO

[GitBox]

mitchell852 commented on issue #2275: Download ISO should actually download the 
ISO
URL: 
https://github.com/apache/incubator-trafficcontrol/issues/2275#issuecomment-391194784
 
 
   @dneuman64 - this was already captured in #1616 and @rivasj will be looking 
at this, so i'm going to close this.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mitchell852 closed issue #2275: Download ISO should actually download the ISO

[GitBox]

mitchell852 closed issue #2275: Download ISO should actually download the ISO
URL: https://github.com/apache/incubator-trafficcontrol/issues/2275
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: incubator-trafficcontrol-traffic_ops-test #642

[Apache Jenkins Server]

See 


Changes:

[mitchell852] update portal ds fields

[mitchell852] update traffic ops documentation

[mitchell852] changes reverted

[mitchell852] minor changes

--
[...truncated 97.72 KB...]
unit_golang_1  | --- PASS: TestFuncs (0.00s)
unit_golang_1  | === RUN   TestInterfaces
unit_golang_1  | --- PASS: TestInterfaces (0.00s)
unit_golang_1  | === RUN   TestValidate
unit_golang_1  | --- PASS: TestValidate (0.00s)
unit_golang_1  | PASS
unit_golang_1  | coverage: 23.0% of statements
unit_golang_1  | ok 
github.com/apache/incubator-trafficcontrol/traffic_ops/traffic_ops_golang/cdn   
0.024s  coverage: 23.0% of statements
unit_golang_1  | === RUN   TestLogLocation
unit_golang_1  | --- PASS: TestLogLocation (0.00s)
unit_golang_1  | === RUN   TestLoadConfig
unit_golang_1  | --- PASS: TestLoadConfig (0.00s)
unit_golang_1  | PASS
unit_golang_1  | coverage: 64.2% of statements
unit_golang_1  | ok 
github.com/apache/incubator-trafficcontrol/traffic_ops/traffic_ops_golang/config
0.014s  coverage: 64.2% of statements
unit_golang_1  | === RUN   TestReadCoordinates
unit_golang_1  | --- PASS: TestReadCoordinates (0.00s)
unit_golang_1  | === RUN   TestFuncs
unit_golang_1  | --- PASS: TestFuncs (0.00s)
unit_golang_1  | === RUN   TestInterfaces
unit_golang_1  | --- PASS: TestInterfaces (0.00s)
unit_golang_1  | === RUN   TestValidate
unit_golang_1  | --- PASS: TestValidate (0.00s)
unit_golang_1  | PASS
unit_golang_1  | coverage: 23.7% of statements
unit_golang_1  | ok 
github.com/apache/incubator-trafficcontrol/traffic_ops/traffic_ops_golang/coordinate
0.009s  coverage: 23.7% of statements
unit_golang_1  | === RUN   TestGetConfigParams
unit_golang_1  | --- PASS: TestGetConfigParams (0.00s)
unit_golang_1  | === RUN   TestMakeCRConfigConfig
unit_golang_1  | --- PASS: TestMakeCRConfigConfig (0.00s)
unit_golang_1  | === RUN   TestMakeDSes
unit_golang_1  | --- PASS: TestMakeDSes (0.00s)
unit_golang_1  | === RUN   TestGetServerProfileParams
unit_golang_1  | --- PASS: TestGetServerProfileParams (0.00s)
unit_golang_1  | === RUN   TestGetDSRegexesDomains
unit_golang_1  | --- PASS: TestGetDSRegexesDomains (0.00s)
unit_golang_1  | === RUN   TestGetStaticDNSEntries
unit_golang_1  | --- PASS: TestGetStaticDNSEntries (0.00s)
unit_golang_1  | === RUN   TestMakeLocations
unit_golang_1  | --- PASS: TestMakeLocations (0.00s)
unit_golang_1  | === RUN   TestGetServerParams
unit_golang_1  | --- PASS: TestGetServerParams (0.00s)
unit_golang_1  | === RUN   TestGetAllServers
unit_golang_1  | --- PASS: TestGetAllServers (0.00s)
unit_golang_1  | === RUN   TestGetServerDSNames
unit_golang_1  | --- PASS: TestGetServerDSNames (0.00s)
unit_golang_1  | === RUN   TestGetServerDSes
unit_golang_1  | --- PASS: TestGetServerDSes (0.00s)
unit_golang_1  | === RUN   TestGetCDNInfo
unit_golang_1  | --- PASS: TestGetCDNInfo (0.00s)
unit_golang_1  | === RUN   TestGetCDNNameFromID
unit_golang_1  | --- PASS: TestGetCDNNameFromID (0.00s)
unit_golang_1  | === RUN   TestGetSnapshot
unit_golang_1  | --- PASS: TestGetSnapshot (0.00s)
unit_golang_1  | === RUN   TestSnapshot
unit_golang_1  | --- PASS: TestSnapshot (0.00s)
unit_golang_1  | === RUN   TestMakeStats
unit_golang_1  | --- PASS: TestMakeStats (0.00s)
unit_golang_1  | PASS
unit_golang_1  | coverage: 50.6% of statements
unit_golang_1  | ok 
github.com/apache/incubator-trafficcontrol/traffic_ops/traffic_ops_golang/crconfig
  0.013s  coverage: 50.6% of statements
unit_golang_1  | === RUN   TestBuildQuery
unit_golang_1  | --- PASS: TestBuildQuery (0.00s)
unit_golang_1  | PASS
unit_golang_1  | coverage: 59.6% of statements
unit_golang_1  | ok 
github.com/apache/incubator-trafficcontrol/traffic_ops/traffic_ops_golang/dbhelpers
 0.013s  coverage: 59.6% of statements
unit_golang_1  | === RUN   TestInterfaces
unit_golang_1  | --- PASS: TestInterfaces (0.00s)
unit_golang_1  | === RUN   TestValidateErrors
unit_golang_1  | --- PASS: TestValidateErrors (0.00s)
unit_golang_1  | PASS
unit_golang_1  | coverage: 3.8% of statements
unit_golang_1  | ok 
github.com/apache/incubator-trafficcontrol/traffic_ops/traffic_ops_golang/deliveryservice
   0.015s  coverage: 3.8% of statements
unit_golang_1  | === RUN   TestInterfaces
unit_golang_1  | --- PASS: TestInterfaces (0.00s)
unit_golang_1  | === RUN   TestGetDeliveryServiceRequest
unit_golang_1  | --- PASS: TestGetDeliveryServiceRequest (0.00s)
unit_golang_1  | PASS
unit_golang_1  | coverage: 2.3% of statements
unit_golang_1  | ok 
github.com/apache/incubator-trafficcontrol/traffic_ops/traffic_ops_golang/deliveryservice/request
   0.010s  coverage: 2.3% of statements
unit_golang_1  | === RUN   TestFuncs
unit_golang_1  | --- PASS: TestFuncs (0.00s)
unit_golang_1  | === RUN   TestInterfaces
unit_golang_1  | --- PASS: TestInterfaces (0.00s)
unit_golang_1  | === RUN   TestValidate

[GitHub] asfgit commented on issue #2088: TO Go: implement tenants CRUD

[GitBox]

asfgit commented on issue #2088: TO Go: implement tenants CRUD
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2088#issuecomment-391182802
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/incubator-trafficcontrol-PR/1652/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #2088: TO Go: implement tenants CRUD

[GitBox]

asfgit commented on issue #2088: TO Go: implement tenants CRUD
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2088#issuecomment-391181463
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/incubator-trafficcontrol-PR/1651/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #2247: Add an Origin API

[GitBox]

asfgit commented on issue #2247: Add an Origin API
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2247#issuecomment-391176328
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/incubator-trafficcontrol-PR/1650/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #2317: Add TO Go cdns/name/dnsseckeys

[GitBox]

asfgit commented on issue #2317: Add TO Go cdns/name/dnsseckeys
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2317#issuecomment-391160661
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/incubator-trafficcontrol-PR/1649/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: incubator-trafficcontrol-PR-rat #927

[Apache Jenkins Server]

See 


--
Started by upstream project "incubator-trafficcontrol-PR" build number 1648
originally caused by:
 GitHub pull request #2291 of commit c77cb0dd348d83bdfe7dab8922e2bc243946d525, 
no merge conflicts.
[EnvInject] - Loading node environment variables.
Building remotely on H22 (ubuntu xenial) in workspace 

[incubator-trafficcontrol-PR-rat] $ /bin/bash -xe 
/tmp/jenkins9164967330739044138.sh
+ rm -rf 

 

 '
[operations-center-context] Requesting copy of artifacts matching '**/*.tar.gz' 
from 'Last successful build (either stable or unstable)' of 
incubator-trafficcontrol-PR
[operations-center-context] Copied 1 artifacts matching '**/*.tar.gz' from 
'Last successful build (either stable or unstable)' of 
incubator-trafficcontrol-PR:
[operations-center-context]   apache-trafficcontrol-2.3.0-incubating.tar.gz
[incubator-trafficcontrol-PR-rat] $ /bin/bash -xe 
/tmp/jenkins7040306074359592644.sh
+ set -exu
++ ls apache-trafficcontrol-2.3.0-incubating.tar.gz
+ tarball=apache-trafficcontrol-2.3.0-incubating.tar.gz
+ tar xzf apache-trafficcontrol-2.3.0-incubating.tar.gz
++ pwd
++ basename apache-trafficcontrol-2.3.0-incubating.tar.gz .tar.gz
+ 
tcdir=
+ cd 

++ date +%Y
+ egrep 'Copyright .*-?2018 The Apache Software Foundation' NOTICE
Copyright 2016-2018 The Apache Software Foundation
+ set +x
Searching for class files:
PASSED: No class files found.
Searching for jar files:
PASSED: No jar files found.
Searching for tar files:
PASSED: No tar files found.
Searching for tgz files:
PASSED: No tgz files found.
Searching for zip files:
PASSED: No zip files found.
++ curl 
https://repository.apache.org/content/repositories/snapshots/org/apache/rat/apache-rat/0.13-SNAPSHOT/
 -sN
++ grep jar
++ grep -ve md5 -e sha1
++ awk -F '"' '{print $2}'
++ sort -r
++ head -n 1
++ cut -d / -f 12
+ ratver=apache-rat-0.13-20180329.151017-101.jar
++ mktemp -d
+ ratdir=/tmp/tmp.off34hovVg
+ ratjar=/tmp/tmp.off34hovVg/apache-rat-0.13.SNAPSHOT.jar
+ curl -L -o /tmp/tmp.off34hovVg/apache-rat-0.13.SNAPSHOT.jar 
https://repository.apache.org/content/repositories/snapshots/org/apache/rat/apache-rat/0.13-SNAPSHOT/apache-rat-0.13-20180329.151017-101.jar
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0  
0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0100 
1587k  100 1587k0 0  1733k  0 --:--:-- --:--:-- --:--:-- 1732k
+ curl -L -o /tmp/tmp.off34hovVg/apache-rat-0.13.SNAPSHOT.jar.sha1 
https://repository.apache.org/content/repositories/snapshots/org/apache/rat/apache-rat/0.13-SNAPSHOT/apache-rat-0.13-20180329.151017-101.jar.sha1
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0  
0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0100 
   40  100400 0 74  0 --:--:-- --:--:-- --:--:--74
++ sha1sum /tmp/tmp.off34hovVg/apache-rat-0.13.SNAPSHOT.jar
++ awk '{print $1}'
++ cat /tmp/tmp.off34hovVg/apache-rat-0.13.SNAPSHOT.jar.sha1
+ [[ 635c5eccad31cff1d713c12144eaae7fc9f10cf4 == 
635c5eccad31cff1d713c12144eaae7fc9f10cf4 ]]
++ pwd
++ pwd
+ java -jar /tmp/tmp.off34hovVg/apache-rat-0.13.SNAPSHOT.jar -E 

 -d 

+ rm -rf /tmp/tmp.off34hovVg
++ perl -lne 'print $1 if /(\d+) Unknown Licenses/' ratreport.txt
+ unknown=56
+ [[ 56 != 0 ]]
+ echo '56 Unknown Licenses'
56 Unknown Licenses
+ perl -lne 'print if /Files with unapproved licenses:/ .. /^\*\*\*/' 
ratreport.txt
+ sed s:::
Files with unapproved licenses:

  
apache-trafficcontrol-2.3.0-incubating/grove/vendor/code.cloudfoundry.org/bytefmt/bytes.go
  
apache-trafficcontrol-2.3.0-incubating/grove/vendor/code.cloudfoundry.org/bytefmt/bytes_test.go
  

[GitHub] rob05c commented on a change in pull request #2282: Deliveryservice_Server API conversion to Go - formerly #2269

[GitBox]

rob05c commented on a change in pull request #2282: Deliveryservice_Server API 
conversion to Go - formerly #2269
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2282#discussion_r190064897
 
 

 ##
 File path: traffic_ops/traffic_ops_golang/deliveryservice/servers/servers.go
 ##
 @@ -263,7 +243,428 @@ func (dss *TODeliveryServiceServer) Delete(db *sqlx.DB, 
user auth.CurrentUser) (
rollbackTransaction = false
return nil, tc.NoError
 }
-func selectQuery() string {
+
+func selectQuery(orderBy string, limit string, offset string) (string, error) {
+
+   selectStmt := `SELECT
+   s.deliveryService,
+   s.server,
+   s.last_updated
+   FROM deliveryservice_server s`
+
+   allowedOrderByCols := map[string]string{
+   "":"",
+   "deliveryservice": "s.deliveryService",
+   "server":  "s.server",
+   "lastupdated": "s.last_updated",
+   "deliveryService": "s.deliveryService",
+   "lastUpdated": "s.last_updated",
+   "last_updated":"s.last_updated",
+   }
+   orderBy, ok := allowedOrderByCols[orderBy]
+   if !ok {
+   return "", errors.New("orderBy '" + orderBy + "' not permitted")
+   }
+
+   if orderBy != "" {
+   selectStmt += ` ORDER BY ` + orderBy
+   }
+
+   selectStmt += ` LIMIT ` + limit + ` OFFSET ` + offset + ` ROWS`
+   return selectStmt, nil
+}
+
+func deleteQuery() string {
+   query := `DELETE FROM deliveryservice_server
+   WHERE deliveryservice=:deliveryservice and server=:server`
+   return query
+}
+
+type DSServers struct {
+   DsId*int  `json:"dsId" db:"deliveryservice"`
+   Servers []int `json:"servers"`
+   Replace *bool `json:"replace"`
+}
+
+type TODSServers DSServers
+
+
+func createServersForDsIdRef() *TODSServers {
+   var dsserversRef = TODSServers(DSServers{})
+   return 
+}
+
+func GetReplaceHandler(db *sqlx.DB) http.HandlerFunc {
+   return func(w http.ResponseWriter, r *http.Request) {
+   defer r.Body.Close()
+   handleErrs := tc.GetHandleErrorsFunc(w, r)
+   ctx := r.Context()
+   user, err := auth.GetCurrentUser(ctx)
+   if err != nil {
+   log.Errorf("unable to retrieve current user from 
context: %s", err)
+   handleErrs(http.StatusInternalServerError, err)
+   return
+   }
+
+   // get list of server Ids to insert
+   payload :=  createServersForDsIdRef() 
+   servers := payload.Servers
+   dsId := payload.DsId
+
+   if err := json.NewDecoder(r.Body).Decode(payload); err != nil {
+   log.Errorf("Error trying to decode the request body: 
%s", err)
+   handleErrs(http.StatusInternalServerError, err)
+   return
+   }
+
+   // if the object has tenancy enabled, check that user is able 
to access the tenant
+   // check user tenancy access to this resource.
+   row := db.QueryRow("SELECT xml_id FROM deliveryservice WHERE id 
= $1", *dsId)
 
 Review comment:
   This is panicing. It looks like it's because You're assigning `dsId` above 
before decoding the JSON, so it's always `nil`.
   
   But, even if the JSON has been decoded, you still need to check for nil, 
because the user POST could be missing that field. In which case, we should 
return a `http.StatusBadRequest` to the user, with a message explaining that 
`dsId` is required. 
   
   The `Replace` field also needs checked that it's not `nil` before 
dereferencing.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup

[GitBox]

rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for 
backup edge cachegroup
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2029#discussion_r189971490
 
 

 ##
 File path: traffic_ops/app/lib/API/CachegroupFallback.pm
 ##
 @@ -0,0 +1,278 @@
+package API::CachegroupFallback;
+#
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+#
+#
+# a note about locations and cachegroups. This used to be "Location", before 
we had physical locations in 12M. Very confusing.
+# What used to be called a location is now called a "cache group" and location 
is now a physical address, not a group of caches working together.
+#
+
+# JvD Note: you always want to put Utils as the first use. Sh*t don't work if 
it's after the Mojo lines.
+use UI::Utils;
+use Mojo::Base 'Mojolicious::Controller';
+use Data::Dumper;
+use JSON;
+use MojoPlugins::Response;
+use Validate::Tiny ':all';
+
+sub delete {
+   my $self = shift;
+   my $cache_id = $self->param('cacheGroupId');
+   my $fallback_id = $self->param('fallbackId');
+   my $params = $self->req->json;
+   my $rs_backups = undef; 
+
+   if ( !_oper($self) ) {
+   return $self->forbidden();
+   }
+
+   if ( defined ($cache_id) && defined($fallback_id) ) {
+   $rs_backups = 
$self->db->resultset('CachegroupFallback')->search( { primary_cg => $cache_id , 
backup_cg => $fallback_id} );
+   } elsif (defined ($cache_id)) {
+   $rs_backups = 
$self->db->resultset('CachegroupFallback')->search( { primary_cg => $cache_id} 
);
+   } elsif (defined ($fallback_id)) {
+   $rs_backups = 
$self->db->resultset('CachegroupFallback')->search( { backup_cg => 
$fallback_id} );
+   }
+
+   if ( ($rs_backups->count > 0) ) {
+   my $del_records = $rs_backups->delete();
+   if ($del_records) {
+   ( $self, "Backup configuration DELETED", 
"APICHANGE");
+   return $self->success_message("Backup configuration 
DELETED");
+   } else {
+   return $self->alert( "Backup configuration DELETED." );
+   }
+   } else {
+   ( $self, "No backup Cachegroups found");
+   return $self->not_found();
+   }
+}
+
+sub show {
+   my $self = shift;
+   my $cache_id = $self->param("cacheGroupId");
+   my $fallback_id = $self->param("fallbackId");
+   my $id = $cache_id ? $cache_id : $fallback_id;
+
+   #only integers
+   if ( $id !~ /^\d+?$/ ) {
+   ( $self, "No such Cachegroup id $id");
+   return $self->success([]);
+   }
+
+   my $cachegroup = $self->db->resultset('Cachegroup')->search( { id => 
$id } )->single();
+   if ( !defined($cachegroup) ) {
+   ( $self, "No such Cachegroup $id");
+   return $self->success([]);
+   }
+
+   if ( ($cachegroup->type->name ne "EDGE_LOC") ) {
+   ( $self, "cachegroup should be type EDGE_LOC.");
+   return $self->success([]);
+   }
+
+   my $rs_backups = undef;
+
+   if ( defined ($cache_id) && defined ($fallback_id)) {
+   $rs_backups = 
$self->db->resultset('CachegroupFallback')->search({ primary_cg => $cache_id, 
backup_cg => $fallback_id}, {order_by => 'set_order'});
+   } elsif ( defined ($cache_id) ) {
+   $rs_backups = 
$self->db->resultset('CachegroupFallback')->search({ primary_cg => $cache_id}, 
{order_by => 'set_order'});
+   } elsif ( defined ($fallback_id) ) {
+   $rs_backups = 
$self->db->resultset('CachegroupFallback')->search({ backup_cg => 
$fallback_id}, {order_by => 'set_order'});
+   }
+
+   if ( defined ($rs_backups) && ($rs_backups->count > 0) ) {
+   my $response;
+   my $backup_cnt = 0;
+   while ( my $row = $rs_backups->next ) {
+   $response->[$backup_cnt]{"cacheGroupId"} = 
$row->primary_cg->id;
+   $response->[$backup_cnt]{"cacheGroupName"} = 
$row->primary_cg->name;
+   $response->[$backup_cnt]{"fallbackName"} = 
$row->backup_cg->name;
+   $response->[$backup_cnt]{"fallbackId"} = 
$row->backup_cg->id;
+   $response->[$backup_cnt]{"fallbackOrder"} = 
$row->set_order;
+   $backup_cnt++;
+   }
+   return $self->success( 

[GitHub] rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup

[GitBox]

rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for 
backup edge cachegroup
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2029#discussion_r189955184
 
 

 ##
 File path: 
traffic_ops/app/db/migrations/2018052100_cache_group_fallback.sql
 ##
 @@ -0,0 +1,38 @@
+/*
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+-- +goose Up
+-- SQL in section 'Up' is executed when this migration is applied
+
+
+-- cachegroup_fallbacks
+CREATE TABLE cachegroup_fallbacks (
+primary_cg bigint,
 
 Review comment:
   Should `primary_cg` and `backup_cg` both be `NOT NULL` as well? I'm not sure 
null values would make sense there.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup

[GitBox]

rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for 
backup edge cachegroup
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2029#discussion_r189958107
 
 

 ##
 File path: 
traffic_ops/app/db/migrations/2018052100_cache_group_fallback.sql
 ##
 @@ -0,0 +1,38 @@
+/*
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+-- +goose Up
+-- SQL in section 'Up' is executed when this migration is applied
+
+
+-- cachegroup_fallbacks
+CREATE TABLE cachegroup_fallbacks (
+primary_cg bigint,
+backup_cg bigint CHECK (primary_cg != backup_cg),
+set_order bigint NOT NULL,
+CONSTRAINT fk_primary_cg FOREIGN KEY (primary_cg) REFERENCES 
cachegroup(id) ON DELETE CASCADE,   
+CONSTRAINT fk_backup_cg FOREIGN KEY (backup_cg) REFERENCES cachegroup(id) 
ON DELETE CASCADE,
+UNIQUE (primary_cg, backup_cg),
+UNIQUE (primary_cg, set_order)
+); 
+
+ALTER TABLE cachegroup ADD COLUMN fallback_to_closest BOOLEAN DEFAULT TRUE;
 
 Review comment:
   This should also probably be NOT NULL? Might save us from a bunch of 
unnecessary null checks when reading from the DB.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup

[GitBox]

rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for 
backup edge cachegroup
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2029#discussion_r189963481
 
 

 ##
 File path: traffic_ops/app/lib/API/CachegroupFallback.pm
 ##
 @@ -0,0 +1,278 @@
+package API::CachegroupFallback;
+#
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+#
+#
+# a note about locations and cachegroups. This used to be "Location", before 
we had physical locations in 12M. Very confusing.
+# What used to be called a location is now called a "cache group" and location 
is now a physical address, not a group of caches working together.
+#
+
+# JvD Note: you always want to put Utils as the first use. Sh*t don't work if 
it's after the Mojo lines.
+use UI::Utils;
+use Mojo::Base 'Mojolicious::Controller';
+use Data::Dumper;
+use JSON;
+use MojoPlugins::Response;
+use Validate::Tiny ':all';
+
+sub delete {
+   my $self = shift;
+   my $cache_id = $self->param('cacheGroupId');
+   my $fallback_id = $self->param('fallbackId');
+   my $params = $self->req->json;
+   my $rs_backups = undef; 
+
+   if ( !_oper($self) ) {
+   return $self->forbidden();
+   }
+
+   if ( defined ($cache_id) && defined($fallback_id) ) {
+   $rs_backups = 
$self->db->resultset('CachegroupFallback')->search( { primary_cg => $cache_id , 
backup_cg => $fallback_id} );
+   } elsif (defined ($cache_id)) {
+   $rs_backups = 
$self->db->resultset('CachegroupFallback')->search( { primary_cg => $cache_id} 
);
+   } elsif (defined ($fallback_id)) {
+   $rs_backups = 
$self->db->resultset('CachegroupFallback')->search( { backup_cg => 
$fallback_id} );
+   }
+
+   if ( ($rs_backups->count > 0) ) {
+   my $del_records = $rs_backups->delete();
+   if ($del_records) {
+   ( $self, "Backup configuration DELETED", 
"APICHANGE");
+   return $self->success_message("Backup configuration 
DELETED");
+   } else {
+   return $self->alert( "Backup configuration DELETED." );
+   }
+   } else {
+   ( $self, "No backup Cachegroups found");
+   return $self->not_found();
+   }
+}
+
+sub show {
+   my $self = shift;
+   my $cache_id = $self->param("cacheGroupId");
+   my $fallback_id = $self->param("fallbackId");
+   my $id = $cache_id ? $cache_id : $fallback_id;
+
+   #only integers
+   if ( $id !~ /^\d+?$/ ) {
+   ( $self, "No such Cachegroup id $id");
+   return $self->success([]);
+   }
+
+   my $cachegroup = $self->db->resultset('Cachegroup')->search( { id => 
$id } )->single();
+   if ( !defined($cachegroup) ) {
+   ( $self, "No such Cachegroup $id");
+   return $self->success([]);
+   }
+
+   if ( ($cachegroup->type->name ne "EDGE_LOC") ) {
+   ( $self, "cachegroup should be type EDGE_LOC.");
+   return $self->success([]);
+   }
+
+   my $rs_backups = undef;
+
+   if ( defined ($cache_id) && defined ($fallback_id)) {
+   $rs_backups = 
$self->db->resultset('CachegroupFallback')->search({ primary_cg => $cache_id, 
backup_cg => $fallback_id}, {order_by => 'set_order'});
+   } elsif ( defined ($cache_id) ) {
+   $rs_backups = 
$self->db->resultset('CachegroupFallback')->search({ primary_cg => $cache_id}, 
{order_by => 'set_order'});
+   } elsif ( defined ($fallback_id) ) {
+   $rs_backups = 
$self->db->resultset('CachegroupFallback')->search({ backup_cg => 
$fallback_id}, {order_by => 'set_order'});
+   }
+
+   if ( defined ($rs_backups) && ($rs_backups->count > 0) ) {
+   my $response;
+   my $backup_cnt = 0;
+   while ( my $row = $rs_backups->next ) {
+   $response->[$backup_cnt]{"cacheGroupId"} = 
$row->primary_cg->id;
+   $response->[$backup_cnt]{"cacheGroupName"} = 
$row->primary_cg->name;
+   $response->[$backup_cnt]{"fallbackName"} = 
$row->backup_cg->name;
+   $response->[$backup_cnt]{"fallbackId"} = 
$row->backup_cg->id;
+   $response->[$backup_cnt]{"fallbackOrder"} = 
$row->set_order;
+   $backup_cnt++;
+   }
+   return $self->success( 

[GitHub] rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup

[GitBox]

rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for 
backup edge cachegroup
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2029#discussion_r189953754
 
 

 ##
 File path: traffic_ops/app/lib/API/Cachegroup.pm
 ##
 @@ -57,6 +57,7 @@ sub index {
"lastUpdated"   => 
$row->last_updated,
"parentCachegroupId"=> 
$row->parent_cachegroup_id,
"parentCachegroupName"  => ( defined 
$row->parent_cachegroup_id ) ? $idnames{ $row->parent_cachegroup_id } : undef,
+   "fallbackToClosest"   => 
\$row->fallback_to_closest,
 
 Review comment:
   I saw API reference documentation for the new `cachegroup_fallbacks` 
endpoint, but the existing cachegroup API reference documentation should also 
be updated to show this new `fallbackToClosest` field.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rawlinp commented on a change in pull request #2247: Add an Origin API

[GitBox]

rawlinp commented on a change in pull request #2247: Add an Origin API
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2247#discussion_r190048933
 
 

 ##
 File path: lib/go-tc/v13/origins.go
 ##
 @@ -0,0 +1,150 @@
+package v13
+
+import (
+   "github.com/apache/incubator-trafficcontrol/lib/go-tc"
+)
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+type OriginsResponse struct {
+   Response []OriginNullable `json:"response"`
+}
+
+// OriginDetailResponse is the JSON object returned for a single origin
+type OriginDetailResponse struct {
+   Response OriginNullable `json:"response"`
+   tc.Alerts
+}
+
+type Origin struct {
+   Cachegroupstring   `json:"cachegroup" db:"cachegroup"`
+   CachegroupID  int  `json:"cachegroupId" db:"cachegroup_id"`
+   Coordinatestring   `json:"coordinate" db:"coordinate"`
+   CoordinateID  int  `json:"coordinateId" db:"coordinate_id"`
+   DeliveryService   string   `json:"deliveryService" 
db:"deliveryservice"`
+   DeliveryServiceID int  `json:"deliveryServiceId" 
db:"deliveryservice_id"`
+   FQDN  string   `json:"fqdn" db:"fqdn"`
+   IDint  `json:"id" db:"id"`
+   IP6Addressstring   `json:"ip6Address" db:"ip6_address"`
+   IPAddress string   `json:"ipAddress" db:"ip_address"`
+   IsPrimary bool `json:"isPrimary" db:"is_primary"`
+   LastUpdated   tc.TimeNoMod `json:"lastUpdated" db:"last_updated"`
+   Name  string   `json:"name" db:"name"`
+   Port  int  `json:"port" db:"port"`
+   Profile   string   `json:"profile" db:"profile"`
+   ProfileID int  `json:"profileId" db:"profile_id"`
+   Protocol  string   `json:"protocol" db:"protocol"`
+   Tenantstring   `json:"tenant" db:"tenant"`
+   TenantID  int  `json:"tenantId" db:"tenant_id"`
+}
+
+type OriginNullable struct {
+   Cachegroup*string   `json:"cachegroup" db:"cachegroup"`
+   CachegroupID  *int  `json:"cachegroupId" db:"cachegroup_id"`
+   Coordinate*string   `json:"coordinate" db:"coordinate"`
+   CoordinateID  *int  `json:"coordinateId" db:"coordinate_id"`
+   DeliveryService   *string   `json:"deliveryService" 
db:"deliveryservice"`
+   DeliveryServiceID *int  `json:"deliveryServiceId" 
db:"deliveryservice_id"`
+   FQDN  *string   `json:"fqdn" db:"fqdn"`
+   ID*int  `json:"id" db:"id"`
+   IP6Address*string   `json:"ip6Address" db:"ip6_address"`
+   IPAddress *string   `json:"ipAddress" db:"ip_address"`
+   IsPrimary *bool `json:"isPrimary" db:"is_primary"`
+   LastUpdated   *tc.TimeNoMod `json:"lastUpdated" db:"last_updated"`
+   Name  *string   `json:"name" db:"name"`
+   Port  *int  `json:"port" db:"port"`
+   Profile   *string   `json:"profile" db:"profile"`
+   ProfileID *int  `json:"profileId" db:"profile_id"`
+   Protocol  *string   `json:"protocol" db:"protocol"`
+   Tenant*string   `json:"tenant" db:"tenant"`
+   TenantID  *int  `json:"tenantId" db:"tenant_id"`
+}
+
+type OriginBuilder struct {
 
 Review comment:
   Yeah I don't feel super strongly about this, just found it useful. Dylan 
mentioned that he sometimes uses a `func IntPointer(i int) *int {return }` to 
alleviate some of the headache with this, which might be better than 
maintaining this builder pattern here. I can take it out  


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rob05c opened a new pull request #2317: Add TO Go cdns/name/dnsseckeys

[GitBox]

rob05c opened a new pull request #2317: Add TO Go cdns/name/dnsseckeys
URL: https://github.com/apache/incubator-trafficcontrol/pull/2317
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #2315: Fix Grove grovetccfg compile errs, better err msgs

[GitBox]

asfgit commented on issue #2315: Fix Grove grovetccfg compile errs, better err 
msgs
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2315#issuecomment-391135354
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/incubator-trafficcontrol-PR/1647/
   Test FAILed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rob05c commented on a change in pull request #2247: Add an Origin API

[GitBox]

rob05c commented on a change in pull request #2247: Add an Origin API
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2247#discussion_r190046195
 
 

 ##
 File path: lib/go-tc/v13/origins.go
 ##
 @@ -0,0 +1,150 @@
+package v13
+
+import (
+   "github.com/apache/incubator-trafficcontrol/lib/go-tc"
+)
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+type OriginsResponse struct {
+   Response []OriginNullable `json:"response"`
+}
+
+// OriginDetailResponse is the JSON object returned for a single origin
+type OriginDetailResponse struct {
+   Response OriginNullable `json:"response"`
+   tc.Alerts
+}
+
+type Origin struct {
+   Cachegroupstring   `json:"cachegroup" db:"cachegroup"`
+   CachegroupID  int  `json:"cachegroupId" db:"cachegroup_id"`
+   Coordinatestring   `json:"coordinate" db:"coordinate"`
+   CoordinateID  int  `json:"coordinateId" db:"coordinate_id"`
+   DeliveryService   string   `json:"deliveryService" 
db:"deliveryservice"`
+   DeliveryServiceID int  `json:"deliveryServiceId" 
db:"deliveryservice_id"`
+   FQDN  string   `json:"fqdn" db:"fqdn"`
+   IDint  `json:"id" db:"id"`
+   IP6Addressstring   `json:"ip6Address" db:"ip6_address"`
+   IPAddress string   `json:"ipAddress" db:"ip_address"`
+   IsPrimary bool `json:"isPrimary" db:"is_primary"`
+   LastUpdated   tc.TimeNoMod `json:"lastUpdated" db:"last_updated"`
+   Name  string   `json:"name" db:"name"`
+   Port  int  `json:"port" db:"port"`
+   Profile   string   `json:"profile" db:"profile"`
+   ProfileID int  `json:"profileId" db:"profile_id"`
+   Protocol  string   `json:"protocol" db:"protocol"`
+   Tenantstring   `json:"tenant" db:"tenant"`
+   TenantID  int  `json:"tenantId" db:"tenant_id"`
+}
+
+type OriginNullable struct {
+   Cachegroup*string   `json:"cachegroup" db:"cachegroup"`
+   CachegroupID  *int  `json:"cachegroupId" db:"cachegroup_id"`
+   Coordinate*string   `json:"coordinate" db:"coordinate"`
+   CoordinateID  *int  `json:"coordinateId" db:"coordinate_id"`
+   DeliveryService   *string   `json:"deliveryService" 
db:"deliveryservice"`
+   DeliveryServiceID *int  `json:"deliveryServiceId" 
db:"deliveryservice_id"`
+   FQDN  *string   `json:"fqdn" db:"fqdn"`
+   ID*int  `json:"id" db:"id"`
+   IP6Address*string   `json:"ip6Address" db:"ip6_address"`
+   IPAddress *string   `json:"ipAddress" db:"ip_address"`
+   IsPrimary *bool `json:"isPrimary" db:"is_primary"`
+   LastUpdated   *tc.TimeNoMod `json:"lastUpdated" db:"last_updated"`
+   Name  *string   `json:"name" db:"name"`
+   Port  *int  `json:"port" db:"port"`
+   Profile   *string   `json:"profile" db:"profile"`
+   ProfileID *int  `json:"profileId" db:"profile_id"`
+   Protocol  *string   `json:"protocol" db:"protocol"`
+   Tenant*string   `json:"tenant" db:"tenant"`
+   TenantID  *int  `json:"tenantId" db:"tenant_id"`
+}
+
+type OriginBuilder struct {
 
 Review comment:
   I'm a -1 on this. I can see the convenience, but it's very non-standard. The 
benefit isn't worth the readability cost, for new devs to figure out.
   
   To avoid multiple lines, the Go idiom is to have a `NewOrigin()` func, that 
either takes values to set, or takes no parameters and initializes all the 
pointers.
   
   I'm guessing most usages will be loading from SQL and parsing JSON from 
POSTs, so it probably won't be used enough to justify the learning curve, 
either.


This is an automated message from the Apache Git Service.
To respond to the message, please log on 

[GitHub] rawlinp commented on a change in pull request #2247: Add an Origin API

[GitBox]

rawlinp commented on a change in pull request #2247: Add an Origin API
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2247#discussion_r190041779
 
 

 ##
 File path: lib/go-tc/v13/origins.go
 ##
 @@ -0,0 +1,150 @@
+package v13
+
+import (
+   "github.com/apache/incubator-trafficcontrol/lib/go-tc"
+)
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+type OriginsResponse struct {
+   Response []OriginNullable `json:"response"`
+}
+
+// OriginDetailResponse is the JSON object returned for a single origin
+type OriginDetailResponse struct {
+   Response OriginNullable `json:"response"`
+   tc.Alerts
+}
+
+type Origin struct {
+   Cachegroupstring   `json:"cachegroup" db:"cachegroup"`
+   CachegroupID  int  `json:"cachegroupId" db:"cachegroup_id"`
+   Coordinatestring   `json:"coordinate" db:"coordinate"`
+   CoordinateID  int  `json:"coordinateId" db:"coordinate_id"`
+   DeliveryService   string   `json:"deliveryService" 
db:"deliveryservice"`
+   DeliveryServiceID int  `json:"deliveryServiceId" 
db:"deliveryservice_id"`
+   FQDN  string   `json:"fqdn" db:"fqdn"`
+   IDint  `json:"id" db:"id"`
+   IP6Addressstring   `json:"ip6Address" db:"ip6_address"`
+   IPAddress string   `json:"ipAddress" db:"ip_address"`
+   IsPrimary bool `json:"isPrimary" db:"is_primary"`
+   LastUpdated   tc.TimeNoMod `json:"lastUpdated" db:"last_updated"`
+   Name  string   `json:"name" db:"name"`
+   Port  int  `json:"port" db:"port"`
+   Profile   string   `json:"profile" db:"profile"`
+   ProfileID int  `json:"profileId" db:"profile_id"`
+   Protocol  string   `json:"protocol" db:"protocol"`
+   Tenantstring   `json:"tenant" db:"tenant"`
+   TenantID  int  `json:"tenantId" db:"tenant_id"`
+}
+
+type OriginNullable struct {
 
 Review comment:
   Ok I believe just the unit tests are using `Origin`, so I should be able to 
just swap that out with `OriginNullable` then rename that to `Origin`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rawlinp commented on a change in pull request #2247: Add an Origin API

[GitBox]

rawlinp commented on a change in pull request #2247: Add an Origin API
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2247#discussion_r190044166
 
 

 ##
 File path: lib/go-tc/v13/origins.go
 ##
 @@ -0,0 +1,150 @@
+package v13
+
+import (
+   "github.com/apache/incubator-trafficcontrol/lib/go-tc"
+)
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+type OriginsResponse struct {
+   Response []OriginNullable `json:"response"`
+}
+
+// OriginDetailResponse is the JSON object returned for a single origin
+type OriginDetailResponse struct {
+   Response OriginNullable `json:"response"`
+   tc.Alerts
+}
+
+type Origin struct {
+   Cachegroupstring   `json:"cachegroup" db:"cachegroup"`
+   CachegroupID  int  `json:"cachegroupId" db:"cachegroup_id"`
+   Coordinatestring   `json:"coordinate" db:"coordinate"`
+   CoordinateID  int  `json:"coordinateId" db:"coordinate_id"`
+   DeliveryService   string   `json:"deliveryService" 
db:"deliveryservice"`
+   DeliveryServiceID int  `json:"deliveryServiceId" 
db:"deliveryservice_id"`
+   FQDN  string   `json:"fqdn" db:"fqdn"`
+   IDint  `json:"id" db:"id"`
+   IP6Addressstring   `json:"ip6Address" db:"ip6_address"`
+   IPAddress string   `json:"ipAddress" db:"ip_address"`
+   IsPrimary bool `json:"isPrimary" db:"is_primary"`
+   LastUpdated   tc.TimeNoMod `json:"lastUpdated" db:"last_updated"`
+   Name  string   `json:"name" db:"name"`
+   Port  int  `json:"port" db:"port"`
+   Profile   string   `json:"profile" db:"profile"`
+   ProfileID int  `json:"profileId" db:"profile_id"`
+   Protocol  string   `json:"protocol" db:"protocol"`
+   Tenantstring   `json:"tenant" db:"tenant"`
+   TenantID  int  `json:"tenantId" db:"tenant_id"`
+}
+
+type OriginNullable struct {
+   Cachegroup*string   `json:"cachegroup" db:"cachegroup"`
+   CachegroupID  *int  `json:"cachegroupId" db:"cachegroup_id"`
+   Coordinate*string   `json:"coordinate" db:"coordinate"`
+   CoordinateID  *int  `json:"coordinateId" db:"coordinate_id"`
+   DeliveryService   *string   `json:"deliveryService" 
db:"deliveryservice"`
+   DeliveryServiceID *int  `json:"deliveryServiceId" 
db:"deliveryservice_id"`
+   FQDN  *string   `json:"fqdn" db:"fqdn"`
+   ID*int  `json:"id" db:"id"`
+   IP6Address*string   `json:"ip6Address" db:"ip6_address"`
+   IPAddress *string   `json:"ipAddress" db:"ip_address"`
+   IsPrimary *bool `json:"isPrimary" db:"is_primary"`
+   LastUpdated   *tc.TimeNoMod `json:"lastUpdated" db:"last_updated"`
+   Name  *string   `json:"name" db:"name"`
+   Port  *int  `json:"port" db:"port"`
+   Profile   *string   `json:"profile" db:"profile"`
+   ProfileID *int  `json:"profileId" db:"profile_id"`
+   Protocol  *string   `json:"protocol" db:"protocol"`
+   Tenant*string   `json:"tenant" db:"tenant"`
+   TenantID  *int  `json:"tenantId" db:"tenant_id"`
+}
+
+type OriginBuilder struct {
 
 Review comment:
   Yeah they're not currently used anywhere in the codebase, but I found it 
useful when I was implementing a test program using the Origin client. Since 
none of the other client implementations use the `*Nullable` structs yet, 
something like this hasn't really been necessary. Without it, you basically 
have to declare a temporary variable and `&` that variable when setting the 
pointer in the `*Nullable` struct. Using this Builder pattern you basically 
just:
   ```
   foo := NewOriginBuilder().CacheGroupID(1).CoordinateID(1).Build()
   ```
   as opposed to:
   ```
   cgID := 1
   coordID := 1
   foo := OriginNullable{CachegroupID: , 

Build failed in Jenkins: incubator-trafficcontrol-traffic_ops-test #641

[Apache Jenkins Server]

See 


Changes:

[jeffrey_elsloo] Fix Grove grovetccfg compile errs, better err msgs

[rob05c] Fix makeModHdrs() when mod headers config has an empty line.

--
[...truncated 97.06 KB...]
unit_golang_1  | --- PASS: TestFuncs (0.00s)
unit_golang_1  | === RUN   TestInterfaces
unit_golang_1  | --- PASS: TestInterfaces (0.00s)
unit_golang_1  | === RUN   TestValidate
unit_golang_1  | --- PASS: TestValidate (0.00s)
unit_golang_1  | PASS
unit_golang_1  | coverage: 23.0% of statements
unit_golang_1  | ok 
github.com/apache/incubator-trafficcontrol/traffic_ops/traffic_ops_golang/cdn   
0.015s  coverage: 23.0% of statements
unit_golang_1  | === RUN   TestLogLocation
unit_golang_1  | --- PASS: TestLogLocation (0.00s)
unit_golang_1  | === RUN   TestLoadConfig
unit_golang_1  | --- PASS: TestLoadConfig (0.00s)
unit_golang_1  | PASS
unit_golang_1  | coverage: 64.2% of statements
unit_golang_1  | ok 
github.com/apache/incubator-trafficcontrol/traffic_ops/traffic_ops_golang/config
0.083s  coverage: 64.2% of statements
unit_golang_1  | === RUN   TestReadCoordinates
unit_golang_1  | --- PASS: TestReadCoordinates (0.00s)
unit_golang_1  | === RUN   TestFuncs
unit_golang_1  | --- PASS: TestFuncs (0.00s)
unit_golang_1  | === RUN   TestInterfaces
unit_golang_1  | --- PASS: TestInterfaces (0.00s)
unit_golang_1  | === RUN   TestValidate
unit_golang_1  | --- PASS: TestValidate (0.00s)
unit_golang_1  | PASS
unit_golang_1  | coverage: 23.7% of statements
unit_golang_1  | ok 
github.com/apache/incubator-trafficcontrol/traffic_ops/traffic_ops_golang/coordinate
0.017s  coverage: 23.7% of statements
unit_golang_1  | === RUN   TestGetConfigParams
unit_golang_1  | --- PASS: TestGetConfigParams (0.00s)
unit_golang_1  | === RUN   TestMakeCRConfigConfig
unit_golang_1  | --- PASS: TestMakeCRConfigConfig (0.00s)
unit_golang_1  | === RUN   TestMakeDSes
unit_golang_1  | --- PASS: TestMakeDSes (0.00s)
unit_golang_1  | === RUN   TestGetServerProfileParams
unit_golang_1  | --- PASS: TestGetServerProfileParams (0.00s)
unit_golang_1  | === RUN   TestGetDSRegexesDomains
unit_golang_1  | --- PASS: TestGetDSRegexesDomains (0.00s)
unit_golang_1  | === RUN   TestGetStaticDNSEntries
unit_golang_1  | --- PASS: TestGetStaticDNSEntries (0.00s)
unit_golang_1  | === RUN   TestMakeLocations
unit_golang_1  | --- PASS: TestMakeLocations (0.00s)
unit_golang_1  | === RUN   TestGetServerParams
unit_golang_1  | --- PASS: TestGetServerParams (0.00s)
unit_golang_1  | === RUN   TestGetAllServers
unit_golang_1  | --- PASS: TestGetAllServers (0.00s)
unit_golang_1  | === RUN   TestGetServerDSNames
unit_golang_1  | --- PASS: TestGetServerDSNames (0.00s)
unit_golang_1  | === RUN   TestGetServerDSes
unit_golang_1  | --- PASS: TestGetServerDSes (0.00s)
unit_golang_1  | === RUN   TestGetCDNInfo
unit_golang_1  | --- PASS: TestGetCDNInfo (0.00s)
unit_golang_1  | === RUN   TestGetCDNNameFromID
unit_golang_1  | --- PASS: TestGetCDNNameFromID (0.00s)
unit_golang_1  | === RUN   TestGetSnapshot
unit_golang_1  | --- PASS: TestGetSnapshot (0.00s)
unit_golang_1  | === RUN   TestSnapshot
unit_golang_1  | --- PASS: TestSnapshot (0.00s)
unit_golang_1  | === RUN   TestMakeStats
unit_golang_1  | --- PASS: TestMakeStats (0.00s)
unit_golang_1  | PASS
unit_golang_1  | coverage: 50.6% of statements
unit_golang_1  | ok 
github.com/apache/incubator-trafficcontrol/traffic_ops/traffic_ops_golang/crconfig
  0.014s  coverage: 50.6% of statements
unit_golang_1  | === RUN   TestBuildQuery
unit_golang_1  | --- PASS: TestBuildQuery (0.00s)
unit_golang_1  | PASS
unit_golang_1  | coverage: 59.6% of statements
unit_golang_1  | ok 
github.com/apache/incubator-trafficcontrol/traffic_ops/traffic_ops_golang/dbhelpers
 0.049s  coverage: 59.6% of statements
unit_golang_1  | === RUN   TestInterfaces
unit_golang_1  | --- PASS: TestInterfaces (0.00s)
unit_golang_1  | === RUN   TestValidateErrors
unit_golang_1  | --- PASS: TestValidateErrors (0.00s)
unit_golang_1  | PASS
unit_golang_1  | coverage: 3.8% of statements
unit_golang_1  | ok 
github.com/apache/incubator-trafficcontrol/traffic_ops/traffic_ops_golang/deliveryservice
   0.048s  coverage: 3.8% of statements
unit_golang_1  | === RUN   TestInterfaces
unit_golang_1  | --- PASS: TestInterfaces (0.00s)
unit_golang_1  | === RUN   TestGetDeliveryServiceRequest
unit_golang_1  | --- PASS: TestGetDeliveryServiceRequest (0.00s)
unit_golang_1  | PASS
unit_golang_1  | coverage: 2.3% of statements
unit_golang_1  | ok 
github.com/apache/incubator-trafficcontrol/traffic_ops/traffic_ops_golang/deliveryservice/request
   0.043s  coverage: 2.3% of statements
unit_golang_1  | === RUN   TestFuncs
unit_golang_1  | --- PASS: TestFuncs (0.00s)
unit_golang_1  | === RUN   TestInterfaces
unit_golang_1  | --- PASS: TestInterfaces (0.00s)
unit_golang_1  | === RUN   TestValidate
unit_golang_1  | 

[GitHub] rob05c closed pull request #2316: Fix makeModHdrs() when mod headers config has an empty line.

[GitBox]

rob05c closed pull request #2316: Fix makeModHdrs() when mod headers config has 
an empty line.
URL: https://github.com/apache/incubator-trafficcontrol/pull/2316
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/grove/grovetccfg/grovetccfg.go b/grove/grovetccfg/grovetccfg.go
index 50cd8803d..0e9db10ee 100644
--- a/grove/grovetccfg/grovetccfg.go
+++ b/grove/grovetccfg/grovetccfg.go
@@ -947,6 +947,9 @@ func makeModHdrs(edgeHRW string, remapTXT string) 
(web.ModHdrs, web.ModHdrs, err
for _, line := range strings.Split(edgeHRW, "__RETURN__") {
line = strings.TrimSuffix(line, "[L]")
parts := strings.Fields(line)
+   if len(parts) == 0 {
+   continue
+   }
if len(parts) < 2 {
return web.ModHdrs{}, web.ModHdrs{}, 
errors.New("edge header rewrite: malformed line '" + line + "'")
}


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jrushford opened a new pull request #2316: Fix makeModHdrs() when mod headers config has an empty line.

[GitBox]

jrushford opened a new pull request #2316: Fix makeModHdrs() when mod headers 
config has an empty line.
URL: https://github.com/apache/incubator-trafficcontrol/pull/2316
 
 
   Fixes an issue in makeModHdrs(), by checking for and skipping empty lines in 
mod header rules.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] elsloo closed pull request #2315: Fix Grove grovetccfg compile errs, better err msgs

[GitBox]

elsloo closed pull request #2315: Fix Grove grovetccfg compile errs, better err 
msgs
URL: https://github.com/apache/incubator-trafficcontrol/pull/2315
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/grove/grovetccfg/grovetccfg.go b/grove/grovetccfg/grovetccfg.go
index 32da4b372..50cd8803d 100644
--- a/grove/grovetccfg/grovetccfg.go
+++ b/grove/grovetccfg/grovetccfg.go
@@ -523,10 +523,18 @@ func getServerDeliveryservices(hostname string, servers 
map[string]tc.Server, ds
dsByID := makeDeliveryservicesIDMap(dses)
serverDses := []tc.DeliveryService{}
for _, dssrv := range dssrvs {
-   if dssrv.Server != serverID {
+   if dssrv.Server == nil {
+   fmt.Fprint(os.Stderr, 
time.Now().Format(time.RFC3339Nano)+" getServerDeliveryservices: 
DeliveryServiceServer Server is nil!\n")
continue
}
-   ds, ok := dsByID[dssrv.DeliveryService]
+   if dssrv.DeliveryService == nil {
+   fmt.Fprint(os.Stderr, 
time.Now().Format(time.RFC3339Nano)+" getServerDeliveryservices: 
DeliveryServiceServer DeliveryService is nil!\n")
+   continue
+   }
+   if *dssrv.Server != serverID {
+   continue
+   }
+   ds, ok := dsByID[*dssrv.DeliveryService]
if !ok {
return nil, fmt.Errorf("delivery service ID %v not 
found in Traffic Ops DeliveryServices", dssrv.DeliveryService)
}
@@ -752,7 +760,7 @@ func createRulesOld(
 
toClientHeaders, toOriginHeaders, err := 
makeModHdrs(ds.EdgeHeaderRewrite, ds.RemapText)
if err != nil {
-   return remap.RemapRules{}, err
+   return remap.RemapRules{}, errors.New("Making headers 
for delivery service '" + ds.XMLID + "':" + err.Error())
}
acl, err := makeACL(ds.RemapText)
if err != nil {
@@ -940,7 +948,7 @@ func makeModHdrs(edgeHRW string, remapTXT string) 
(web.ModHdrs, web.ModHdrs, err
line = strings.TrimSuffix(line, "[L]")
parts := strings.Fields(line)
if len(parts) < 2 {
-   return web.ModHdrs{}, web.ModHdrs{}, 
errors.New("malformed line '" + line + "'")
+   return web.ModHdrs{}, web.ModHdrs{}, 
errors.New("edge header rewrite: malformed line '" + line + "'")
}
switch {
case parts[0] == "cond":
@@ -952,7 +960,7 @@ func makeModHdrs(edgeHRW string, remapTXT string) 
(web.ModHdrs, web.ModHdrs, err
}
case parts[0] == "set-header" || parts[0] == 
"add-header": // Technically these are different
if len(parts) < 3 {
-   return web.ModHdrs{}, web.ModHdrs{}, 
errors.New("malformed line '" + line + "'")
+   return web.ModHdrs{}, web.ModHdrs{}, 
errors.New("edge header rewrite: malformed line '" + line + "'")
}
hdr := web.Hdr{Name: parts[1], Value: 
strings.Join(parts[2:], " ")}
if toOrigin {


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rob05c opened a new pull request #2315: Fix Grove grovetccfg compile errs, better err msgs

[GitBox]

rob05c opened a new pull request #2315: Fix Grove grovetccfg compile errs, 
better err msgs
URL: https://github.com/apache/incubator-trafficcontrol/pull/2315
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DylanVolz commented on a change in pull request #2247: Add an Origin API

[GitBox]

DylanVolz commented on a change in pull request #2247: Add an Origin API
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2247#discussion_r189988525
 
 

 ##
 File path: lib/go-tc/v13/origins.go
 ##
 @@ -0,0 +1,150 @@
+package v13
+
+import (
+   "github.com/apache/incubator-trafficcontrol/lib/go-tc"
+)
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+type OriginsResponse struct {
+   Response []OriginNullable `json:"response"`
+}
+
+// OriginDetailResponse is the JSON object returned for a single origin
+type OriginDetailResponse struct {
+   Response OriginNullable `json:"response"`
+   tc.Alerts
+}
+
+type Origin struct {
+   Cachegroupstring   `json:"cachegroup" db:"cachegroup"`
+   CachegroupID  int  `json:"cachegroupId" db:"cachegroup_id"`
+   Coordinatestring   `json:"coordinate" db:"coordinate"`
+   CoordinateID  int  `json:"coordinateId" db:"coordinate_id"`
+   DeliveryService   string   `json:"deliveryService" 
db:"deliveryservice"`
+   DeliveryServiceID int  `json:"deliveryServiceId" 
db:"deliveryservice_id"`
+   FQDN  string   `json:"fqdn" db:"fqdn"`
+   IDint  `json:"id" db:"id"`
+   IP6Addressstring   `json:"ip6Address" db:"ip6_address"`
+   IPAddress string   `json:"ipAddress" db:"ip_address"`
+   IsPrimary bool `json:"isPrimary" db:"is_primary"`
+   LastUpdated   tc.TimeNoMod `json:"lastUpdated" db:"last_updated"`
+   Name  string   `json:"name" db:"name"`
+   Port  int  `json:"port" db:"port"`
+   Profile   string   `json:"profile" db:"profile"`
+   ProfileID int  `json:"profileId" db:"profile_id"`
+   Protocol  string   `json:"protocol" db:"protocol"`
+   Tenantstring   `json:"tenant" db:"tenant"`
+   TenantID  int  `json:"tenantId" db:"tenant_id"`
+}
+
+type OriginNullable struct {
+   Cachegroup*string   `json:"cachegroup" db:"cachegroup"`
+   CachegroupID  *int  `json:"cachegroupId" db:"cachegroup_id"`
+   Coordinate*string   `json:"coordinate" db:"coordinate"`
+   CoordinateID  *int  `json:"coordinateId" db:"coordinate_id"`
+   DeliveryService   *string   `json:"deliveryService" 
db:"deliveryservice"`
+   DeliveryServiceID *int  `json:"deliveryServiceId" 
db:"deliveryservice_id"`
+   FQDN  *string   `json:"fqdn" db:"fqdn"`
+   ID*int  `json:"id" db:"id"`
+   IP6Address*string   `json:"ip6Address" db:"ip6_address"`
+   IPAddress *string   `json:"ipAddress" db:"ip_address"`
+   IsPrimary *bool `json:"isPrimary" db:"is_primary"`
+   LastUpdated   *tc.TimeNoMod `json:"lastUpdated" db:"last_updated"`
+   Name  *string   `json:"name" db:"name"`
+   Port  *int  `json:"port" db:"port"`
+   Profile   *string   `json:"profile" db:"profile"`
+   ProfileID *int  `json:"profileId" db:"profile_id"`
+   Protocol  *string   `json:"protocol" db:"protocol"`
+   Tenant*string   `json:"tenant" db:"tenant"`
+   TenantID  *int  `json:"tenantId" db:"tenant_id"`
+}
+
+type OriginBuilder struct {
 
 Review comment:
   Where is this used? Are these functions mainly helper functions for taking 
the pointers to store in the fields?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DylanVolz commented on a change in pull request #2247: Add an Origin API

[GitBox]

DylanVolz commented on a change in pull request #2247: Add an Origin API
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2247#discussion_r189986988
 
 

 ##
 File path: lib/go-tc/v13/origins.go
 ##
 @@ -0,0 +1,150 @@
+package v13
+
+import (
+   "github.com/apache/incubator-trafficcontrol/lib/go-tc"
+)
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+type OriginsResponse struct {
+   Response []OriginNullable `json:"response"`
+}
+
+// OriginDetailResponse is the JSON object returned for a single origin
+type OriginDetailResponse struct {
+   Response OriginNullable `json:"response"`
+   tc.Alerts
+}
+
+type Origin struct {
+   Cachegroupstring   `json:"cachegroup" db:"cachegroup"`
+   CachegroupID  int  `json:"cachegroupId" db:"cachegroup_id"`
+   Coordinatestring   `json:"coordinate" db:"coordinate"`
+   CoordinateID  int  `json:"coordinateId" db:"coordinate_id"`
+   DeliveryService   string   `json:"deliveryService" 
db:"deliveryservice"`
+   DeliveryServiceID int  `json:"deliveryServiceId" 
db:"deliveryservice_id"`
+   FQDN  string   `json:"fqdn" db:"fqdn"`
+   IDint  `json:"id" db:"id"`
+   IP6Addressstring   `json:"ip6Address" db:"ip6_address"`
+   IPAddress string   `json:"ipAddress" db:"ip_address"`
+   IsPrimary bool `json:"isPrimary" db:"is_primary"`
+   LastUpdated   tc.TimeNoMod `json:"lastUpdated" db:"last_updated"`
+   Name  string   `json:"name" db:"name"`
+   Port  int  `json:"port" db:"port"`
+   Profile   string   `json:"profile" db:"profile"`
+   ProfileID int  `json:"profileId" db:"profile_id"`
+   Protocol  string   `json:"protocol" db:"protocol"`
+   Tenantstring   `json:"tenant" db:"tenant"`
+   TenantID  int  `json:"tenantId" db:"tenant_id"`
+}
+
+type OriginNullable struct {
 
 Review comment:
   Since this is a new endpoint we do not need to preserve the non-pointer 
struct for the client. you can remove the struct above and call this one Origin 
instead of OriginNullable.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mitchell852 commented on issue #1616: Traffic Portal GenISO links break with HA

[GitBox]

mitchell852 commented on issue #1616: Traffic Portal GenISO links break with HA
URL: 
https://github.com/apache/incubator-trafficcontrol/issues/1616#issuecomment-391046762
 
 
   @rivasj will be looking at this from the API perspective. If you want to 
limit TP changes to zero, then find a way to return a link like it does now but 
ensure that link works in a HA environment?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mitchell852 commented on issue #1616: Traffic Portal GenISO links break with HA

[GitBox]

mitchell852 commented on issue #1616: Traffic Portal GenISO links break with HA
URL: 
https://github.com/apache/incubator-trafficcontrol/issues/1616#issuecomment-391046762
 
 
   @rivasj will be looking at this from the API perspective


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #2305: Add TO Go cdns/health

[GitBox]

asfgit commented on issue #2305: Add TO Go cdns/health
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2305#issuecomment-391044968
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/incubator-trafficcontrol-PR/1646/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Jenkins build is back to normal : incubator-trafficcontrol-PR-rat #925

[Apache Jenkins Server]

See 

[GitHub] asfgit commented on issue #2306: Add TO Go cdns/capacity

[GitBox]

asfgit commented on issue #2306: Add TO Go cdns/capacity
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2306#issuecomment-391043703
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/incubator-trafficcontrol-PR/1645/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: incubator-trafficcontrol-PR-rat #924

[Apache Jenkins Server]

See 


--
Started by upstream project "incubator-trafficcontrol-PR" build number 1644
originally caused by:
 GitHub pull request #2307 of commit 31943d584e854b6abfaaa2813508273a1de01a89, 
no merge conflicts.
[EnvInject] - Loading node environment variables.
Building remotely on H33 (ubuntu xenial) in workspace 

[incubator-trafficcontrol-PR-rat] $ /bin/bash -xe 
/tmp/jenkins4083160723736756636.sh
+ rm -rf 

 

 '
[operations-center-context] Requesting copy of artifacts matching '**/*.tar.gz' 
from 'Last successful build (either stable or unstable)' of 
incubator-trafficcontrol-PR
[operations-center-context] Copied 1 artifacts matching '**/*.tar.gz' from 
'Last successful build (either stable or unstable)' of 
incubator-trafficcontrol-PR:
[operations-center-context]   apache-trafficcontrol-2.3.0-incubating.tar.gz
[incubator-trafficcontrol-PR-rat] $ /bin/bash -xe 
/tmp/jenkins1938980403268849171.sh
+ set -exu
++ ls apache-trafficcontrol-2.3.0-incubating.tar.gz
+ tarball=apache-trafficcontrol-2.3.0-incubating.tar.gz
+ tar xzf apache-trafficcontrol-2.3.0-incubating.tar.gz
++ pwd
++ basename apache-trafficcontrol-2.3.0-incubating.tar.gz .tar.gz
+ 
tcdir=
+ cd 

++ date +%Y
+ egrep 'Copyright .*-?2018 The Apache Software Foundation' NOTICE
Copyright 2016-2018 The Apache Software Foundation
+ set +x
Searching for class files:
PASSED: No class files found.
Searching for jar files:
PASSED: No jar files found.
Searching for tar files:
PASSED: No tar files found.
Searching for tgz files:
PASSED: No tgz files found.
Searching for zip files:
PASSED: No zip files found.
++ curl 
https://repository.apache.org/content/repositories/snapshots/org/apache/rat/apache-rat/0.13-SNAPSHOT/
 -sN
++ grep jar
++ grep -ve md5 -e sha1
++ awk -F '"' '{print $2}'
++ head -n 1
++ cut -d / -f 12
++ sort -r
+ ratver=apache-rat-0.13-20180329.151017-101.jar
++ mktemp -d
+ ratdir=/tmp/tmp.oaBMQ8zghP
+ ratjar=/tmp/tmp.oaBMQ8zghP/apache-rat-0.13.SNAPSHOT.jar
+ curl -L -o /tmp/tmp.oaBMQ8zghP/apache-rat-0.13.SNAPSHOT.jar 
https://repository.apache.org/content/repositories/snapshots/org/apache/rat/apache-rat/0.13-SNAPSHOT/apache-rat-0.13-20180329.151017-101.jar
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0  
0 1587k0 00 0  0  0 --:--:-- --:--:-- --:--:-- 0100 
1587k  100 1587k0 0  1615k  0 --:--:-- --:--:-- --:--:-- 1614k
+ curl -L -o /tmp/tmp.oaBMQ8zghP/apache-rat-0.13.SNAPSHOT.jar.sha1 
https://repository.apache.org/content/repositories/snapshots/org/apache/rat/apache-rat/0.13-SNAPSHOT/apache-rat-0.13-20180329.151017-101.jar.sha1
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0  
0400 00 0  0  0 --:--:-- --:--:-- --:--:-- 0100 
   40  100400 0 72  0 --:--:-- --:--:-- --:--:--72
++ sha1sum /tmp/tmp.oaBMQ8zghP/apache-rat-0.13.SNAPSHOT.jar
++ awk '{print $1}'
++ cat /tmp/tmp.oaBMQ8zghP/apache-rat-0.13.SNAPSHOT.jar.sha1
+ [[ 635c5eccad31cff1d713c12144eaae7fc9f10cf4 == 
635c5eccad31cff1d713c12144eaae7fc9f10cf4 ]]
++ pwd
++ pwd
+ java -jar /tmp/tmp.oaBMQ8zghP/apache-rat-0.13.SNAPSHOT.jar -E 

 -d 

+ rm -rf /tmp/tmp.oaBMQ8zghP
++ perl -lne 'print $1 if /(\d+) Unknown Licenses/' ratreport.txt
+ unknown=2
+ [[ 2 != 0 ]]
+ echo '2 Unknown Licenses'
2 Unknown Licenses
+ perl -lne 'print if /Files with unapproved licenses:/ .. /^\*\*\*/' 
ratreport.txt
+ sed s:::
Files with unapproved licenses:

  apache-trafficcontrol-2.3.0-incubating/lib/go-tc/cdnrouters.go
  apache-trafficcontrol-2.3.0-incubating/lib/go-tc/crsstats.go

*
+ exit 1
Build step 'Execute shell' marked build as 

[GitHub] asfgit commented on issue #2301: Add TO Go cachegroups/id/queue_update

[GitBox]

asfgit commented on issue #2301: Add TO Go cachegroups/id/queue_update
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2301#issuecomment-391039599
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/incubator-trafficcontrol-PR/1642/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #2302: Add TO Go cdns/name

[GitBox]

asfgit commented on issue #2302: Add TO Go cdns/name
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2302#issuecomment-391038110
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/incubator-trafficcontrol-PR/1641/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #2303: Add TO Go delete cdns/name

[GitBox]

asfgit commented on issue #2303: Add TO Go delete cdns/name
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2303#issuecomment-391036756
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/incubator-trafficcontrol-PR/1640/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #2304: Add TO Go cdns/id/queue_updates

[GitBox]

asfgit commented on issue #2304: Add TO Go cdns/id/queue_updates
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2304#issuecomment-391034982
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/incubator-trafficcontrol-PR/1639/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #2278: Add TO Go caches/stats endpoint

[GitBox]

asfgit commented on issue #2278: Add TO Go caches/stats endpoint
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2278#issuecomment-391033553
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/incubator-trafficcontrol-PR/1638/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #2297: Add TO Go cachegroups/trimmed

[GitBox]

asfgit commented on issue #2297: Add TO Go cachegroups/trimmed
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2297#issuecomment-391032108
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/incubator-trafficcontrol-PR/1637/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #2300: Add TO Go cachegroups/id/deliveryservices

[GitBox]

asfgit commented on issue #2300: Add TO Go cachegroups/id/deliveryservices
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2300#issuecomment-391028561
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/incubator-trafficcontrol-PR/1636/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #2270: Add TO Go Servers Details endpoint

[GitBox]

asfgit commented on issue #2270: Add TO Go Servers Details endpoint
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2270#issuecomment-391026097
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/incubator-trafficcontrol-PR/1635/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services