[GitHub] asfgit commented on issue #2404: TO Go DS API: initialDispersion not required for DNS DSes

2018-06-12 Thread GitBox
asfgit commented on issue #2404: TO Go DS API: initialDispersion not required for DNS DSes URL: https://github.com/apache/incubator-trafficcontrol/pull/2404#issuecomment-396774378 Refer to this link for build results (access rights to CI server needed):

[GitHub] asfgit commented on issue #2405: Add Traffic Ops Golang user/current

2018-06-12 Thread GitBox
asfgit commented on issue #2405: Add Traffic Ops Golang user/current URL: https://github.com/apache/incubator-trafficcontrol/pull/2405#issuecomment-396772488 Refer to this link for build results (access rights to CI server needed):

[GitHub] asfgit commented on issue #2402: To go riak ping

2018-06-12 Thread GitBox
asfgit commented on issue #2402: To go riak ping URL: https://github.com/apache/incubator-trafficcontrol/pull/2402#issuecomment-396763696 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR/1797/

[GitHub] rob05c opened a new pull request #2405: Add Traffic Ops Golang user/current

2018-06-12 Thread GitBox
rob05c opened a new pull request #2405: Add Traffic Ops Golang user/current URL: https://github.com/apache/incubator-trafficcontrol/pull/2405 This is an automated message from the Apache Git Service. To respond to the

[GitHub] dangogh closed pull request #2403: Fix merge conflict for changed func signature

2018-06-12 Thread GitBox
dangogh closed pull request #2403: Fix merge conflict for changed func signature URL: https://github.com/apache/incubator-trafficcontrol/pull/2403 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] rob05c opened a new pull request #2402: To go riak ping

2018-06-12 Thread GitBox
rob05c opened a new pull request #2402: To go riak ping URL: https://github.com/apache/incubator-trafficcontrol/pull/2402 Branched from #2365 - recommend merging that first. This is an automated message from the Apache Git

[GitHub] rawlinp opened a new pull request #2401: Implement Origin UI in Traffic Portal

2018-06-12 Thread GitBox
rawlinp opened a new pull request #2401: Implement Origin UI in Traffic Portal URL: https://github.com/apache/incubator-trafficcontrol/pull/2401 Provide the ability to list, create, edit, and delete Origins using Traffic Portal.

Jenkins build is back to normal : incubator-trafficcontrol-PR-rat #1065

2018-06-12 Thread Apache Jenkins Server
See

[GitHub] asfgit commented on issue #2400: To go cdns sslkeys

2018-06-12 Thread GitBox
asfgit commented on issue #2400: To go cdns sslkeys URL: https://github.com/apache/incubator-trafficcontrol/pull/2400#issuecomment-396708178 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR/1795/

Build failed in Jenkins: incubator-trafficcontrol-PR-rat #1064

2018-06-12 Thread Apache Jenkins Server
See -- Started by upstream project "incubator-trafficcontrol-PR" build number 1794 originally caused by: GitHub pull request #2399 of commit

Jenkins build is back to normal : incubator-trafficcontrol-PR #1794

2018-06-12 Thread Apache Jenkins Server
See

[GitHub] rob05c opened a new pull request #2400: To go cdns sslkeys

2018-06-12 Thread GitBox
rob05c opened a new pull request #2400: To go cdns sslkeys URL: https://github.com/apache/incubator-trafficcontrol/pull/2400 Branched from #2365 - recommend merging that first. This is an automated message from the Apache Git

[GitHub] asfgit commented on issue #2399: Add Dockerfile, docker-compose and build scripts for ATS and astats [WIP]

2018-06-12 Thread GitBox
asfgit commented on issue #2399: Add Dockerfile, docker-compose and build scripts for ATS and astats [WIP] URL: https://github.com/apache/incubator-trafficcontrol/pull/2399#issuecomment-396705290 Refer to this link for build results (access rights to CI server needed):

[GitHub] alficles commented on a change in pull request #2365: Add TO Go api helpers

2018-06-12 Thread GitBox
alficles commented on a change in pull request #2365: Add TO Go api helpers URL: https://github.com/apache/incubator-trafficcontrol/pull/2365#discussion_r194858032 ## File path: traffic_ops/traffic_ops_golang/api/api.go ## @@ -0,0 +1,304 @@ +package api + +/* + * Licensed

[GitHub] alficles commented on a change in pull request #2365: Add TO Go api helpers

2018-06-12 Thread GitBox
alficles commented on a change in pull request #2365: Add TO Go api helpers URL: https://github.com/apache/incubator-trafficcontrol/pull/2365#discussion_r194857103 ## File path: traffic_ops/traffic_ops_golang/api/api.go ## @@ -0,0 +1,304 @@ +package api + +/* + * Licensed

[GitHub] asfgit commented on issue #2399: Add Dockerfile, docker-compose and build scripts for ATS and astats [WIP]

2018-06-12 Thread GitBox
asfgit commented on issue #2399: Add Dockerfile, docker-compose and build scripts for ATS and astats [WIP] URL: https://github.com/apache/incubator-trafficcontrol/pull/2399#issuecomment-396699870 Can one of the admins verify this patch?

[GitHub] limited opened a new pull request #2399: Add Dockerfile, docker-compose and build scripts for ATS and astats [WIP]

2018-06-12 Thread GitBox
limited opened a new pull request #2399: Add Dockerfile, docker-compose and build scripts for ATS and astats [WIP] URL: https://github.com/apache/incubator-trafficcontrol/pull/2399 This is an automated message from the

[GitHub] alficles commented on a change in pull request #2365: Add TO Go api helpers

2018-06-12 Thread GitBox
alficles commented on a change in pull request #2365: Add TO Go api helpers URL: https://github.com/apache/incubator-trafficcontrol/pull/2365#discussion_r194853155 ## File path: traffic_ops/traffic_ops_golang/api/api.go ## @@ -0,0 +1,304 @@ +package api + +/* + * Licensed

Jenkins build is back to normal : incubator-trafficcontrol-traffic_ops-test #687

2018-06-12 Thread Apache Jenkins Server
See

Build failed in Jenkins: incubator-trafficcontrol-traffic_ops-test #686

2018-06-12 Thread Apache Jenkins Server
See -- Started by an SCM change Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on H34 (ubuntu xenial) in workspace

Build failed in Jenkins: incubator-trafficcontrol-PR #1793

2018-06-12 Thread Apache Jenkins Server
See -- GitHub pull request #2398 of commit 419f958c351e246d82535c2b7462d02492c51059, no merge conflicts. [EnvInject] - Loading node environment variables. Building remotely

[GitHub] dewrich closed issue #2387: GET /api/1.3/cachegroups doesn't support filtering by type

2018-06-12 Thread GitBox
dewrich closed issue #2387: GET /api/1.3/cachegroups doesn't support filtering by type URL: https://github.com/apache/incubator-trafficcontrol/issues/2387 This is an automated message from the Apache Git Service. To respond

[GitHub] dangogh opened a new pull request #2398: [Issue 2387] allow cachegroup select by type id

2018-06-12 Thread GitBox
dangogh opened a new pull request #2398: [Issue 2387] allow cachegroup select by type id URL: https://github.com/apache/incubator-trafficcontrol/pull/2398 This fixes #2387 Now allows `.../api/1.3/cachegroups?type=4`, e.g.

[GitHub] rob05c commented on a change in pull request #2395: To go ds sslkeys generate

2018-06-12 Thread GitBox
rob05c commented on a change in pull request #2395: To go ds sslkeys generate URL: https://github.com/apache/incubator-trafficcontrol/pull/2395#discussion_r194813254 ## File path: traffic_ops/traffic_ops_golang/deliveryservice/gencert.go ## @@ -0,0 +1,121 @@ +package

[GitHub] rob05c commented on a change in pull request #2395: To go ds sslkeys generate

2018-06-12 Thread GitBox
rob05c commented on a change in pull request #2395: To go ds sslkeys generate URL: https://github.com/apache/incubator-trafficcontrol/pull/2395#discussion_r194813254 ## File path: traffic_ops/traffic_ops_golang/deliveryservice/gencert.go ## @@ -0,0 +1,121 @@ +package

[GitHub] alficles commented on a change in pull request #2395: To go ds sslkeys generate

2018-06-12 Thread GitBox
alficles commented on a change in pull request #2395: To go ds sslkeys generate URL: https://github.com/apache/incubator-trafficcontrol/pull/2395#discussion_r194776585 ## File path: traffic_ops/traffic_ops_golang/deliveryservice/gencert.go ## @@ -0,0 +1,121 @@ +package

[GitHub] ezelkow1 opened a new issue #2397: TP - empty value field for parameter not accepted

2018-06-12 Thread GitBox
ezelkow1 opened a new issue #2397: TP - empty value field for parameter not accepted URL: https://github.com/apache/incubator-trafficcontrol/issues/2397 With the old TO UI we do currently have parameters that have/use empty value fields, i.e. various ATS plugins. These were valid in the

[GitHub] rob05c commented on a change in pull request #2365: Add TO Go api helpers

2018-06-12 Thread GitBox
rob05c commented on a change in pull request #2365: Add TO Go api helpers URL: https://github.com/apache/incubator-trafficcontrol/pull/2365#discussion_r194784848 ## File path: traffic_ops/traffic_ops_golang/api/api.go ## @@ -0,0 +1,304 @@ +package api + +/* + * Licensed

[GitHub] rob05c commented on a change in pull request #2365: Add TO Go api helpers

2018-06-12 Thread GitBox
rob05c commented on a change in pull request #2365: Add TO Go api helpers URL: https://github.com/apache/incubator-trafficcontrol/pull/2365#discussion_r194784735 ## File path: traffic_ops/traffic_ops_golang/api/api.go ## @@ -0,0 +1,304 @@ +package api + +/* + * Licensed

[GitHub] rob05c commented on issue #2396: Fix TO Go "CRUDer" GetRefTypes to new, not shared

2018-06-12 Thread GitBox
rob05c commented on issue #2396: Fix TO Go "CRUDer" GetRefTypes to new, not shared URL: https://github.com/apache/incubator-trafficcontrol/pull/2396#issuecomment-396626172 Closed because the "CRUDer" framework only calls the function once and shares it anyway, so it doesn't matter.

[GitHub] rob05c closed pull request #2396: Fix TO Go "CRUDer" GetRefTypes to new, not shared

2018-06-12 Thread GitBox
rob05c closed pull request #2396: Fix TO Go "CRUDer" GetRefTypes to new, not shared URL: https://github.com/apache/incubator-trafficcontrol/pull/2396 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] rob05c commented on a change in pull request #2365: Add TO Go api helpers

2018-06-12 Thread GitBox
rob05c commented on a change in pull request #2365: Add TO Go api helpers URL: https://github.com/apache/incubator-trafficcontrol/pull/2365#discussion_r19489 ## File path: traffic_ops/traffic_ops_golang/api/api.go ## @@ -0,0 +1,304 @@ +package api + +/* + * Licensed

[GitHub] rob05c commented on a change in pull request #2365: Add TO Go api helpers

2018-06-12 Thread GitBox
rob05c commented on a change in pull request #2365: Add TO Go api helpers URL: https://github.com/apache/incubator-trafficcontrol/pull/2365#discussion_r194772362 ## File path: traffic_ops/traffic_ops_golang/api/api.go ## @@ -0,0 +1,304 @@ +package api + +/* + * Licensed

[GitHub] mitchell852 commented on issue #2387: GET /api/1.3/cachegroups doesn't support filtering by type

2018-06-12 Thread GitBox
mitchell852 commented on issue #2387: GET /api/1.3/cachegroups doesn't support filtering by type URL: https://github.com/apache/incubator-trafficcontrol/issues/2387#issuecomment-396620104 https:///#!/types//cache-groups calls this api: GET api/1.3/cachegroups?type=6

[GitHub] rob05c commented on a change in pull request #2365: Add TO Go api helpers

2018-06-12 Thread GitBox
rob05c commented on a change in pull request #2365: Add TO Go api helpers URL: https://github.com/apache/incubator-trafficcontrol/pull/2365#discussion_r194771595 ## File path: traffic_ops/traffic_ops_golang/api/api.go ## @@ -0,0 +1,304 @@ +package api + +/* + * Licensed

[GitHub] asfgit commented on issue #2396: Fix TO Go "CRUDer" GetRefTypes to new, not shared

2018-06-12 Thread GitBox
asfgit commented on issue #2396: Fix TO Go "CRUDer" GetRefTypes to new, not shared URL: https://github.com/apache/incubator-trafficcontrol/pull/2396#issuecomment-396619738 Refer to this link for build results (access rights to CI server needed):

[GitHub] rob05c commented on a change in pull request #2365: Add TO Go api helpers

2018-06-12 Thread GitBox
rob05c commented on a change in pull request #2365: Add TO Go api helpers URL: https://github.com/apache/incubator-trafficcontrol/pull/2365#discussion_r194770912 ## File path: traffic_ops/traffic_ops_golang/api/api.go ## @@ -0,0 +1,304 @@ +package api + +/* + * Licensed

[GitHub] rob05c commented on a change in pull request #2365: Add TO Go api helpers

2018-06-12 Thread GitBox
rob05c commented on a change in pull request #2365: Add TO Go api helpers URL: https://github.com/apache/incubator-trafficcontrol/pull/2365#discussion_r194768563 ## File path: traffic_ops/traffic_ops_golang/api/api.go ## @@ -0,0 +1,304 @@ +package api + +/* + * Licensed

[GitHub] rob05c opened a new pull request #2396: Fix TO Go "CRUDer" GetRefTypes to new, not shared

2018-06-12 Thread GitBox
rob05c opened a new pull request #2396: Fix TO Go "CRUDer" GetRefTypes to new, not shared URL: https://github.com/apache/incubator-trafficcontrol/pull/2396 Using shared objects between threads is dangerous, and there's no reason for it, the cost to create these structs is insignificant.

[GitHub] alficles commented on a change in pull request #2365: Add TO Go api helpers

2018-06-12 Thread GitBox
alficles commented on a change in pull request #2365: Add TO Go api helpers URL: https://github.com/apache/incubator-trafficcontrol/pull/2365#discussion_r194737004 ## File path: traffic_ops/traffic_ops_golang/api/api.go ## @@ -0,0 +1,304 @@ +package api + +/* + * Licensed

[GitHub] alficles commented on a change in pull request #2365: Add TO Go api helpers

2018-06-12 Thread GitBox
alficles commented on a change in pull request #2365: Add TO Go api helpers URL: https://github.com/apache/incubator-trafficcontrol/pull/2365#discussion_r194743253 ## File path: traffic_ops/traffic_ops_golang/api/api.go ## @@ -0,0 +1,304 @@ +package api + +/* + * Licensed

[GitHub] alficles commented on a change in pull request #2365: Add TO Go api helpers

2018-06-12 Thread GitBox
alficles commented on a change in pull request #2365: Add TO Go api helpers URL: https://github.com/apache/incubator-trafficcontrol/pull/2365#discussion_r194742439 ## File path: traffic_ops/traffic_ops_golang/api/api.go ## @@ -0,0 +1,304 @@ +package api + +/* + * Licensed

[GitHub] alficles commented on a change in pull request #2365: Add TO Go api helpers

2018-06-12 Thread GitBox
alficles commented on a change in pull request #2365: Add TO Go api helpers URL: https://github.com/apache/incubator-trafficcontrol/pull/2365#discussion_r194742335 ## File path: traffic_ops/traffic_ops_golang/api/api.go ## @@ -0,0 +1,304 @@ +package api + +/* + * Licensed

[GitHub] alficles commented on a change in pull request #2365: Add TO Go api helpers

2018-06-12 Thread GitBox
alficles commented on a change in pull request #2365: Add TO Go api helpers URL: https://github.com/apache/incubator-trafficcontrol/pull/2365#discussion_r194738662 ## File path: traffic_ops/traffic_ops_golang/api/api.go ## @@ -0,0 +1,304 @@ +package api + +/* + * Licensed

[GitHub] alficles commented on a change in pull request #2365: Add TO Go api helpers

2018-06-12 Thread GitBox
alficles commented on a change in pull request #2365: Add TO Go api helpers URL: https://github.com/apache/incubator-trafficcontrol/pull/2365#discussion_r194752252 ## File path: traffic_ops/traffic_ops_golang/api/api.go ## @@ -0,0 +1,304 @@ +package api + +/* + * Licensed

[GitHub] alficles commented on a change in pull request #2365: Add TO Go api helpers

2018-06-12 Thread GitBox
alficles commented on a change in pull request #2365: Add TO Go api helpers URL: https://github.com/apache/incubator-trafficcontrol/pull/2365#discussion_r194741648 ## File path: traffic_ops/traffic_ops_golang/api/api.go ## @@ -0,0 +1,304 @@ +package api + +/* + * Licensed

[GitHub] alficles commented on a change in pull request #2365: Add TO Go api helpers

2018-06-12 Thread GitBox
alficles commented on a change in pull request #2365: Add TO Go api helpers URL: https://github.com/apache/incubator-trafficcontrol/pull/2365#discussion_r194740898 ## File path: traffic_ops/traffic_ops_golang/api/api.go ## @@ -0,0 +1,304 @@ +package api + +/* + * Licensed

[GitHub] alficles commented on a change in pull request #2365: Add TO Go api helpers

2018-06-12 Thread GitBox
alficles commented on a change in pull request #2365: Add TO Go api helpers URL: https://github.com/apache/incubator-trafficcontrol/pull/2365#discussion_r194749846 ## File path: traffic_ops/traffic_ops_golang/api/api.go ## @@ -0,0 +1,304 @@ +package api + +/* + * Licensed