[GitHub] [trafficcontrol] asfgit commented on issue #3875: Add TO Go ATS CDN configs

[GitBox]

asfgit commented on issue #3875: Add TO Go ATS CDN configs
URL: https://github.com/apache/trafficcontrol/pull/3875#issuecomment-521841348
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/4159/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] rob05c opened a new pull request #3875: Add TO Go ATS CDN configs

[GitBox]

rob05c opened a new pull request #3875: Add TO Go ATS CDN configs
URL: https://github.com/apache/trafficcontrol/pull/3875
 
 
   Draft, still need to add tests.
   
   
   ## What does this PR (Pull Request) do?
   
   
   - [ ] This PR fixes #REPLACE_ME OR is not related to any Issue 
   
   
   ## Which Traffic Control components are affected by this PR?
   
   
   - CDN in a Box
   - Documentation
   - Grove
   - Traffic Control Client 
   - Traffic Monitor
   - Traffic Ops
   - Traffic Ops ORT
   - Traffic Portal
   - Traffic Router
   - Traffic Stats
   - Traffic Vault
   
   ## What is the best way to verify this PR?
   
   
   ## If this is a bug fix, what versions of Traffic Control are affected?
   
   
   
   ## The following criteria are ALL met by this PR
   
   
   - [ ] This PR includes tests OR I have explained why tests are unnecessary
   - [ ] This PR includes documentation OR I have explained why documentation 
is unnecessary
   - [ ] This PR includes an update to CHANGELOG.md OR such an update is not 
necessary
   - [ ] This PR includes any and all required license headers
   - [ ] This PR ensures that database migration sequence is correct OR this PR 
does not include a database migration
   - [ ] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the 
Apache Software Foundation's security 
guidelines](https://www.apache.org/security/) for details)
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: trafficcontrol-master-build #1465

[Apache Jenkins Server]

See 


Changes:

[ocket] fixed inaccurate change log message when queuing/dequeuing server

--
[...truncated 2.79 MB...]
traffic_portal_build_1   | + 
/usr/lib/rpm/redhat/brp-strip-static-archive /usr/bin/strip
traffic_portal_build_1   | + /usr/lib/rpm/brp-python-bytecompile 
/usr/bin/python 1
traffic_portal_build_1   | + /usr/lib/rpm/redhat/brp-python-hardlink
traffic_portal_build_1   | + /usr/lib/rpm/redhat/brp-java-repack-jars
traffic_portal_build_1   | Processing files: 
traffic_portal-3.0.0-10164.d4745aa6.el7.x86_64
traffic_portal_build_1   | warning: File listed twice: 
/etc/init.d/traffic_portal
traffic_portal_build_1   | warning: File listed twice: 
/opt/traffic_portal/node_modules/forever/bin/forever
traffic_portal_build_1   | warning: File listed twice: 
/opt/traffic_portal/node_modules/forever/bin/monitor
traffic_portal_build_1   | warning: File listed twice: 
/opt/traffic_portal/public/traffic_portal_properties.json
traffic_portal_build_1   | Provides: traffic_portal = 
3.0.0-10164.d4745aa6.el7 traffic_portal(x86-64) = 3.0.0-10164.d4745aa6.el7
traffic_portal_build_1   | Requires(interp): /bin/sh
traffic_portal_build_1   | Requires(rpmlib): rpmlib(FileDigests) <= 
4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(CompressedFileNames) <= 
3.0.4-1
traffic_portal_build_1   | Requires(post): /bin/sh
traffic_portal_build_1   | Checking for unpackaged file(s): 
/usr/lib/rpm/check-files 
/tmp/trafficcontrol/rpmbuild/BUILDROOT/traffic_portal-3.0.0-10164.d4745aa6.el7.x86_64
traffic_portal_build_1   | Wrote: 
/tmp/trafficcontrol/rpmbuild/SRPMS/traffic_portal-3.0.0-10164.d4745aa6.el7.src.rpm
traffic_router_build_1   | [INFO] Wrote: 
/tmp/trafficcontrol/traffic_router/build/target/rpm/traffic_router/RPMS/x86_64/traffic_router-3.0.0-10164.d4745aa6.el7.x86_64.rpm
traffic_router_build_1   | [INFO] Executing(%clean): /bin/sh -e 
/var/tmp/rpm-tmp.yLgglA
traffic_router_build_1   | [INFO] + umask 022
traffic_router_build_1   | [INFO] + cd 
/tmp/trafficcontrol/traffic_router/build/target/rpm/traffic_router/BUILD
traffic_router_build_1   | [INFO] + /usr/bin/rm -rf 
/tmp/trafficcontrol/traffic_router/build/target/rpm/traffic_router/buildroot
traffic_router_build_1   | [INFO] + exit 0
traffic_router_build_1   | [INFO] 

traffic_router_build_1   | [INFO] Reactor Summary:
traffic_router_build_1   | [INFO] 
traffic_router_build_1   | [INFO] traffic_router 
. SUCCESS [  1.566 s]
traffic_router_build_1   | [INFO] traffic_router_shared 
.. SUCCESS [ 27.687 s]
traffic_router_build_1   | [INFO] traffic_router_connector 
... SUCCESS [ 10.426 s]
traffic_router_build_1   | [INFO] traffic_router_config 
.. SUCCESS [  0.059 s]
traffic_router_build_1   | [INFO] traffic_router_geolocation 
. SUCCESS [  0.146 s]
traffic_router_build_1   | [INFO] ROOT 
... SUCCESS [ 28.273 s]
traffic_router_build_1   | [INFO] traffic_router_rpm 
. SUCCESS [ 17.914 s]
traffic_router_build_1   | [INFO] 

traffic_router_build_1   | [INFO] BUILD SUCCESS
traffic_router_build_1   | [INFO] 

traffic_router_build_1   | [INFO] Total time: 01:27 min
traffic_router_build_1   | [INFO] Finished at: 
2019-08-15T23:00:38+00:00
traffic_router_build_1   | [INFO] Final Memory: 125M/2588M
traffic_router_build_1   | [INFO] 

traffic_router_build_1   | 

traffic_router_build_1   | RPM BUILD SUCCEEDED, See 
/tmp/trafficcontrol/dist/traffic_router-3.0.0-10164.d4745aa6.x86_64.rpm for the 
newly built rpm.
traffic_router_build_1   | 

traffic_router_build_1   | 
traffic_router_build_1   | Building the rpm for Tomcat.
traffic_router_build_1   | Verifying the build configuration 
environment.
traffic_router_build_1   | 
==
traffic_router_build_1   | 

[GitHub] [trafficcontrol] ocket8888 merged pull request #3873: fixes inaccurate change log message when queuing/dequeuing server upd…

[GitBox]

ocket merged pull request #3873: fixes inaccurate change log message when 
queuing/dequeuing server upd…
URL: https://github.com/apache/trafficcontrol/pull/3873
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] asfgit commented on issue #3873: fixes inaccurate change log message when queuing/dequeuing server upd…

[GitBox]

asfgit commented on issue #3873: fixes inaccurate change log message when 
queuing/dequeuing server upd…
URL: https://github.com/apache/trafficcontrol/pull/3873#issuecomment-521816824
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/4158/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] lbathina opened a new issue #3874: Monitoring.json doesn't list the delivery services

[GitBox]

lbathina opened a new issue #3874: Monitoring.json doesn't list the delivery 
services
URL: https://github.com/apache/trafficcontrol/issues/3874
 
 
   
   
   
   
   ## I'm submitting a ...
   
   
   - [X] bug report
   - [ ] new feature / enhancement request
   - [ ] improvement request (usability, performance, tech debt, etc.)
   - [ ] other 
   
   ## Traffic Control components affected ...
   
   - [ ] CDN in a Box
   - [ ] Documentation
   - [ ] Grove
   - [ ] Traffic Control Client
   - [X] Traffic Monitor
   - [X] Traffic Ops
   - [ ] Traffic Ops ORT
   - [ ] Traffic Portal
   - [ ] Traffic Router
   - [ ] Traffic Stats
   - [ ] Traffic Vault
   - [ ] unknown
   
   ## Current behavior:
   
   DS list returned in the response of monitoring.json is empty.
   
   ## Expected / new behavior:
   
   should return a json with DS list same as the DS list in 
/api/1.2/cdns//snapshot
   
   ## Minimal reproduction of the problem with instructions:
   
   request for /api/1.2/cdns//configs/monitoring.json
   compare the DS field with DS field in the response of  endpoint 
/api/1.2/cdns//snapshot
   ## Anything else:
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mitchell852 opened a new pull request #3873: fixes inaccurate change log message when queuing/dequeuing server upd…

[GitBox]

mitchell852 opened a new pull request #3873: fixes inaccurate change log 
message when queuing/dequeuing server upd…
URL: https://github.com/apache/trafficcontrol/pull/3873
 
 
   …ates for a cdn
   
   ## What does this PR (Pull Request) do?
   Regardless of whether you were queuing or dequeuing (clearing) server 
updates for a cdn, the change log message always said:
   
   "...ACTION: Queue CDN updates"
   
   when, in fact, the message should differ depending on the action, for 
example:
   
   "ACTION: CDN server updates queued"
   "ACTION: CDN server updates dequeued"
   
   change logs messages are not documented so no doc changes
   we don't test the format of change log messages for non-shared handlers
   too small to justify a changelog.md entry
   
   - [x] This PR is not related to any Issue
   
   ## Which Traffic Control components are affected by this PR?
   
   - Traffic Ops
   
   ## What is the best way to verify this PR?
   
   ## If this is a bug fix, what versions of Traffic Control are affected?
   
   - master (241c537)
   
   ## The following criteria are ALL met by this PR
   
   - [x] This PR includes tests OR I have explained why tests are unnecessary
   - [x] This PR includes documentation OR I have explained why documentation 
is unnecessary
   - [x] This PR includes an update to CHANGELOG.md OR such an update is not 
necessary
   - [x] This PR includes any and all required license headers
   - [x] This PR ensures that database migration sequence is correct OR this PR 
does not include a database migration
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the 
Apache Software Foundation's security 
guidelines](https://www.apache.org/security/) for details)
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] asfgit commented on issue #3872: fixes broken TO unit tests when change log messages were improved

[GitBox]

asfgit commented on issue #3872: fixes broken TO unit tests when change log 
messages were improved
URL: https://github.com/apache/trafficcontrol/pull/3872#issuecomment-521792162
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/4157/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Jenkins build is back to normal : trafficcontrol-traffic_ops-test #1500

[Apache Jenkins Server]

See 

[GitHub] [trafficcontrol] rawlinp merged pull request #3872: fixes broken TO unit tests when change log messages were improved

[GitBox]

rawlinp merged pull request #3872: fixes broken TO unit tests when change log 
messages were improved
URL: https://github.com/apache/trafficcontrol/pull/3872
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mitchell852 opened a new pull request #3872: fixes broken unit tests when change log messages were improved

[GitBox]

mitchell852 opened a new pull request #3872: fixes broken unit tests when 
change log messages were improved
URL: https://github.com/apache/trafficcontrol/pull/3872
 
 
   ## What does this PR (Pull Request) do?
   fixes broken unit tests when change log messages were improved
   
   no additional tests nor documentation nor change log entry needed 
   
   - [x] This PR is not related to any Issue
   
   ## Which Traffic Control components are affected by this PR?
   - Traffic Ops
   
   ## What is the best way to verify this PR?
   cd traffic_ops_golang
   go test $(go list ./...)
   
   ## The following criteria are ALL met by this PR
   
   - [x] This PR includes tests OR I have explained why tests are unnecessary
   - [x] This PR includes documentation OR I have explained why documentation 
is unnecessary
   - [x] This PR includes an update to CHANGELOG.md OR such an update is not 
necessary
   - [x] This PR includes any and all required license headers
   - [x] This PR ensures that database migration sequence is correct OR this PR 
does not include a database migration
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the 
Apache Software Foundation's security 
guidelines](https://www.apache.org/security/) for details)
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] asfgit commented on issue #3870: Rewrite /capabilities to Go

[GitBox]

asfgit commented on issue #3870: Rewrite /capabilities to Go
URL: https://github.com/apache/trafficcontrol/pull/3870#issuecomment-521755833
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/4156/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] asfgit commented on issue #3870: Rewrite /capabilities to Go

[GitBox]

asfgit commented on issue #3870: Rewrite /capabilities to Go
URL: https://github.com/apache/trafficcontrol/pull/3870#issuecomment-521752082
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/4155/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] asfgit commented on issue #3870: Rewrite /capabilities to Go

[GitBox]

asfgit commented on issue #3870: Rewrite /capabilities to Go
URL: https://github.com/apache/trafficcontrol/pull/3870#issuecomment-521730744
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/4154/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3768: Codecov

[GitBox]

ocket commented on a change in pull request #3768: Codecov
URL: https://github.com/apache/trafficcontrol/pull/3768#discussion_r314407957
 
 

 ##
 File path: traffic_monitor/tests/gocover.bash
 ##
 @@ -0,0 +1,36 @@
+#!/usr/bin/env bash
+
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+#
+set -e
+go get "github.com/wadey/gocovmerge"
+echo "" > result.txt
+packages=( "$@" )
+coverage_out=()
+i=1
+for pkg in ${packages[@]} ; do
+for d in $(go list $pkg | grep -v vendor); do
+file="$i.out"
+go test -v -coverprofile=$file $d >> result.txt
+cat result.txt
+if [ -f $file ]; then
+coverage_out+=( $file )
+fi
+((i++))
+done
+done 
+gocovmerge ${coverage_out[*]} > coverage.out
+go tool cover -func=coverage.out
+cat result.txt | go-junit-report --package-name=golang.test.tm --set-exit-code 
> /junit/golang.test.tm.xml 
+chmod 777 -R /junit && cat /junit/golang.test.tm.xml
 
 Review comment:
   You're probably right. It might be worth checking, though, if everything 
works if you delete everything before `cat` on that line.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3768: Codecov

[GitBox]

ocket commented on a change in pull request #3768: Codecov
URL: https://github.com/apache/trafficcontrol/pull/3768#discussion_r314406675
 
 

 ##
 File path: traffic_monitor/tests/gocover.bash
 ##
 @@ -0,0 +1,36 @@
+#!/usr/bin/env bash
+
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+#
+set -e
+go get "github.com/wadey/gocovmerge"
 
 Review comment:
   You can ask the mailing list about using this library in this way.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3768: Codecov

[GitBox]

ocket commented on a change in pull request #3768: Codecov
URL: https://github.com/apache/trafficcontrol/pull/3768#discussion_r314406505
 
 

 ##
 File path: traffic_monitor/tests/gocover.bash
 ##
 @@ -0,0 +1,36 @@
+#!/usr/bin/env bash
+
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+#
+set -e
+go get "github.com/wadey/gocovmerge"
+echo "" > result.txt
 
 Review comment:
   lol no


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 commented on issue #3870: Rewrite /capabilities to Go

[GitBox]

ocket commented on issue #3870: Rewrite /capabilities to Go
URL: https://github.com/apache/trafficcontrol/pull/3870#issuecomment-521716358
 
 
   The best we could do in that direction is return an error without breaking 
the "API version promise". And actually, that might qualify; not sure.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] rawlinp commented on issue #3870: Rewrite /capabilities to Go

[GitBox]

rawlinp commented on issue #3870: Rewrite /capabilities to Go
URL: https://github.com/apache/trafficcontrol/pull/3870#issuecomment-521715386
 
 
   Well, if we make the built-in capabilities immutable the `ON UPDATE CASCADE` 
is unnecessary. Since TO plugins can access the TODB at startup, I think that 
would be the "proper" way of supporting capabilities for arbitrary extension 
routes. An extension route shouldn't require an operator to manually add its 
capabilities via the API. The extension should load them itself on startup 
time, and they should be immutable from an API perspective.
   
   Since capabilities aren't really used in the code yet, I think we have some 
freedom to design them properly before we get stuck in the rut of having to 
support unnecessary API endpoints.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] rob05c edited a comment on issue #3870: Rewrite /capabilities to Go

[GitBox]

rob05c edited a comment on issue #3870: Rewrite /capabilities to Go
URL: https://github.com/apache/trafficcontrol/pull/3870#issuecomment-521713551
 
 
   >Do extensions have access to TODB?
   
   Yes. TO Plugins can access anything the main TO app can. If a hook can't 
access something that's needed, it can be added to the `Data` struct for that 
hook, e.g. `OnRequestData`.
   
   >idk if they do at startup.
   
   Same goes for startup, needed data (like the `db` or `tx`) can be added to 
the `StartupData` struct.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 commented on issue #3870: Rewrite /capabilities to Go

[GitBox]

ocket commented on issue #3870: Rewrite /capabilities to Go
URL: https://github.com/apache/trafficcontrol/pull/3870#issuecomment-521713541
 
 
   Oh, rob05c beat me to it. But also of note while we're looking, the 
Role/Capability relationship has the same problem.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] rob05c edited a comment on issue #3870: Rewrite /capabilities to Go

[GitBox]

rob05c edited a comment on issue #3870: Rewrite /capabilities to Go
URL: https://github.com/apache/trafficcontrol/pull/3870#issuecomment-521713551
 
 
   >Do extensions have access to TODB?
   
   Yes. TO Plugins can access anything the main TO app can. If a hook can't 
access something that's needed, it can be added to the `Data` struct for that 
hook, e.g. `OnRequestData`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 commented on issue #3870: Rewrite /capabilities to Go

[GitBox]

ocket commented on issue #3870: Rewrite /capabilities to Go
URL: https://github.com/apache/trafficcontrol/pull/3870#issuecomment-521713196
 
 
   > _"If you update the name of a capability does it automatically update all 
the FK references in the api_capabilities table?"_
   
   It can, depends if the foreign key constraint was defined with `ON UPDATE 
CASCADE`. Which it should have been. But looking at 
`traffic_ops/app/db/create_tables.sql` it was not. Adding that clause is simple 
enough - and should be done, IMO -, but it's a database migration, so I'm not 
sure it's proper to include it in what's already a pretty expansive PR.
   
   Extensions certainly have access to the database at runtime, but idk if they 
do at startup.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] asfgit commented on issue #3870: Rewrite /capabilities to Go

[GitBox]

asfgit commented on issue #3870: Rewrite /capabilities to Go
URL: https://github.com/apache/trafficcontrol/pull/3870#issuecomment-521712221
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/4153/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] rob05c commented on issue #3870: Rewrite /capabilities to Go

[GitBox]

rob05c commented on issue #3870: Rewrite /capabilities to Go
URL: https://github.com/apache/trafficcontrol/pull/3870#issuecomment-521712151
 
 
   >If you update the name of a capability does it automatically update all the 
FK references in the api_capabilities table? 
   
   No, but it should. 
   
   
https://github.com/apache/trafficcontrol/blob/master/traffic_ops/app/db/create_tables.sql#L3243
   
   We should add a migration to change `fk_capability` to `ON UPDATE CASCADE`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] asfgit commented on issue #3870: Rewrite /capabilities to Go

[GitBox]

asfgit commented on issue #3870: Rewrite /capabilities to Go
URL: https://github.com/apache/trafficcontrol/pull/3870#issuecomment-521699235
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/4152/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] lbathina commented on a change in pull request #3768: Codecov

[GitBox]

lbathina commented on a change in pull request #3768: Codecov
URL: https://github.com/apache/trafficcontrol/pull/3768#discussion_r314379439
 
 

 ##
 File path: traffic_monitor/tests/gocover.bash
 ##
 @@ -0,0 +1,36 @@
+#!/usr/bin/env bash
+
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+#
+set -e
+go get "github.com/wadey/gocovmerge"
+echo "" > result.txt
+packages=( "$@" )
+coverage_out=()
+i=1
+for pkg in ${packages[@]} ; do
+for d in $(go list $pkg | grep -v vendor); do
+file="$i.out"
+go test -v -coverprofile=$file $d >> result.txt
+cat result.txt
+if [ -f $file ]; then
+coverage_out+=( $file )
+fi
+((i++))
+done
+done 
+gocovmerge ${coverage_out[*]} > coverage.out
+go tool cover -func=coverage.out
+cat result.txt | go-junit-report --package-name=golang.test.tm --set-exit-code 
> /junit/golang.test.tm.xml 
+chmod 777 -R /junit && cat /junit/golang.test.tm.xml
 
 Review comment:
   I just moved the command that was already in there. may be this question was 
missed in previous review/approval when that statement made to master


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] lbathina commented on a change in pull request #3768: Codecov

[GitBox]

lbathina commented on a change in pull request #3768: Codecov
URL: https://github.com/apache/trafficcontrol/pull/3768#discussion_r314378734
 
 

 ##
 File path: traffic_monitor/tests/gocover.bash
 ##
 @@ -0,0 +1,36 @@
+#!/usr/bin/env bash
+
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+#
+set -e
+go get "github.com/wadey/gocovmerge"
+echo "" > result.txt
 
 Review comment:
   followed how things were already in there. THought it was a special 
requirement for doing things in open source way!! 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] lbathina commented on a change in pull request #3768: Codecov

[GitBox]

lbathina commented on a change in pull request #3768: Codecov
URL: https://github.com/apache/trafficcontrol/pull/3768#discussion_r314377876
 
 

 ##
 File path: traffic_monitor/tests/gocover.bash
 ##
 @@ -0,0 +1,36 @@
+#!/usr/bin/env bash
+
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+#
+set -e
+go get "github.com/wadey/gocovmerge"
 
 Review comment:
   I might need some enlightenment here 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] asfgit commented on issue #2457: Add TO Go post deliveryservice_user

[GitBox]

asfgit commented on issue #2457: Add TO Go post deliveryservice_user
URL: https://github.com/apache/trafficcontrol/pull/2457#issuecomment-521685320
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/4151/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] asfgit commented on issue #2456: Add TO Go delete deliveryservice_user

[GitBox]

asfgit commented on issue #2456: Add TO Go delete deliveryservice_user
URL: https://github.com/apache/trafficcontrol/pull/2456#issuecomment-521683787
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/4150/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Jenkins build is back to normal : trafficcontrol-PR #4150

[Apache Jenkins Server]

See 

[GitHub] [trafficcontrol] asfgit commented on issue #2456: Add TO Go delete deliveryservice_user

[GitBox]

asfgit commented on issue #2456: Add TO Go delete deliveryservice_user
URL: https://github.com/apache/trafficcontrol/pull/2456#issuecomment-521669930
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/4149/
   Test FAILed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: trafficcontrol-PR #4149

[Apache Jenkins Server]

See 

--
GitHub pull request #2456 of commit 6bb79570dc1c01067c3b7c5cd865a3b987cc, 
no merge conflicts.
Setting status of 6bb79570dc1c01067c3b7c5cd865a3b987cc to PENDING with url 
https://builds.apache.org/job/trafficcontrol-PR/4149/ and message: 'Build 
started for merge commit.'
Using context: default
[EnvInject] - Loading node environment variables.
Building remotely on H36 (ubuntu xenial) in workspace 

[WS-CLEANUP] Deleting project workspace...
[WS-CLEANUP] Deferred wipeout is used...
using credential b205a645-1ea7-4dfd-973d-c14ac43cab07
Cloning the remote Git repository
Cloning repository git://github.com/apache/trafficcontrol.git
 > git init  # timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress git://github.com/apache/trafficcontrol.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # 
 > timeout=10
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
using GIT_SSH to set credentials 
 > git fetch --tags --progress git://github.com/apache/trafficcontrol.git 
 > +refs/pull/*:refs/remotes/origin/pr/*
 > git rev-parse 6bb79570dc1c01067c3b7c5cd865a3b987cc^{commit} # timeout=10
 > git rev-parse origin/6bb79570dc1c01067c3b7c5cd865a3b987cc^{commit} # 
 > timeout=10
 > git rev-parse 6bb79570dc1c01067c3b7c5cd865a3b987cc^{commit} # timeout=10
ERROR: Couldn't find any revision to build. Verify the repository and branch 
configuration for this job.
Retrying after 10 seconds
using credential b205a645-1ea7-4dfd-973d-c14ac43cab07
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress git://github.com/apache/trafficcontrol.git 
 > +refs/pull/*:refs/remotes/origin/pr/*
 > git rev-parse 6bb79570dc1c01067c3b7c5cd865a3b987cc^{commit} # timeout=10
 > git rev-parse origin/6bb79570dc1c01067c3b7c5cd865a3b987cc^{commit} # 
 > timeout=10
 > git rev-parse 6bb79570dc1c01067c3b7c5cd865a3b987cc^{commit} # timeout=10
ERROR: Couldn't find any revision to build. Verify the repository and branch 
configuration for this job.
Retrying after 10 seconds
using credential b205a645-1ea7-4dfd-973d-c14ac43cab07
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress git://github.com/apache/trafficcontrol.git 
 > +refs/pull/*:refs/remotes/origin/pr/*
 > git rev-parse 6bb79570dc1c01067c3b7c5cd865a3b987cc^{commit} # timeout=10
 > git rev-parse origin/6bb79570dc1c01067c3b7c5cd865a3b987cc^{commit} # 
 > timeout=10
 > git rev-parse 6bb79570dc1c01067c3b7c5cd865a3b987cc^{commit} # timeout=10
ERROR: Couldn't find any revision to build. Verify the repository and branch 
configuration for this job.
Skipped archiving because build is not successful

Build failed in Jenkins: trafficcontrol-PR #4148

[Apache Jenkins Server]

See 


Changes:

[rob] Add TO Go put deliveryservices/id/safe

[rob] Add TO Go ds/safe client func, test

--
[...truncated 3.05 MB...]
traffic_portal_build_1   | | `-- har-schema@2.0.0 
traffic_portal_build_1   | +-- http-signature@1.2.0 
traffic_portal_build_1   | | +-- assert-plus@1.0.0 
traffic_portal_build_1   | | +-- jsprim@1.4.1 
traffic_portal_build_1   | | | +-- extsprintf@1.3.0 
traffic_portal_build_1   | | | +-- json-schema@0.2.3 
traffic_portal_build_1   | | | `-- verror@1.10.0 
traffic_portal_build_1   | | `-- sshpk@1.16.1 
traffic_portal_build_1   | |   +-- asn1@0.2.4 
traffic_portal_build_1   | |   +-- bcrypt-pbkdf@1.0.2 
traffic_portal_build_1   | |   +-- dashdash@1.14.1 
traffic_portal_build_1   | |   +-- ecc-jsbn@0.1.2 
traffic_portal_build_1   | |   +-- getpass@0.1.7 
traffic_portal_build_1   | |   +-- jsbn@0.1.1 
traffic_portal_build_1   | |   `-- tweetnacl@0.14.5 
traffic_portal_build_1   | +-- is-typedarray@1.0.0 
traffic_portal_build_1   | +-- json-stringify-safe@5.0.1 
traffic_portal_build_1   | +-- oauth-sign@0.9.0 
traffic_portal_build_1   | +-- performance-now@2.1.0 
traffic_portal_build_1   | +-- qs@6.5.2 
traffic_portal_build_1   | +-- tough-cookie@2.4.3 
traffic_portal_build_1   | | +-- psl@1.3.0 
traffic_portal_build_1   | | `-- punycode@1.4.1 
traffic_portal_build_1   | +-- tunnel-agent@0.6.0 
traffic_portal_build_1   | `-- uuid@3.3.2 
traffic_portal_build_1   | 
traffic_portal_build_1   | npm WARN optional SKIPPING OPTIONAL 
DEPENDENCY: fsevents@^1.0.0 (node_modules/chokidar/node_modules/fsevents):
traffic_portal_build_1   | npm WARN notsup SKIPPING OPTIONAL 
DEPENDENCY: Unsupported platform for fsevents@1.2.9: wanted 
{"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
traffic_portal_build_1   | npm WARN traffic_portal@ No description
traffic_portal_build_1   | npm WARN traffic_portal@ No repository 
field.
traffic_portal_build_1   | npm WARN traffic_portal@ No license field.
traffic_portal_build_1   | 
traffic_portal_build_1   | Done.
traffic_portal_build_1   | 
traffic_portal_build_1   | 
traffic_portal_build_1   | Execution Time (2019-08-15 14:34:02 UTC)
traffic_portal_build_1   | loading tasks  1.2s  ▇▇ 
3%
traffic_portal_build_1   | compass:prod   9.3s  
▇▇▇▇▇▇▇▇▇ 26%
traffic_portal_build_1   | browserify2:app-prod   2.1s  ▇▇ 
6%
traffic_portal_build_1   | browserify2:shared-libs-prod   2.8s  
▇▇▇ 8%
traffic_portal_build_1   | install-dependencies  19.8s  
▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇ 56%
traffic_portal_build_1   | Total 35.6s
traffic_portal_build_1   | 
traffic_portal_build_1   | + exit 0
traffic_portal_build_1   | Executing(%install): /bin/sh -e 
/var/tmp/rpm-tmp.rEw5Oc
traffic_portal_build_1   | + umask 022
traffic_portal_build_1   | + cd /tmp/trafficcontrol/rpmbuild/BUILD
traffic_portal_build_1   | + '[' 
/tmp/trafficcontrol/rpmbuild/BUILDROOT/traffic_portal-3.0.0-10161.961a7cd5.el7.x86_64
 '!=' / ']'
traffic_portal_build_1   | + rm -rf 
/tmp/trafficcontrol/rpmbuild/BUILDROOT/traffic_portal-3.0.0-10161.961a7cd5.el7.x86_64
traffic_portal_build_1   | ++ dirname 
/tmp/trafficcontrol/rpmbuild/BUILDROOT/traffic_portal-3.0.0-10161.961a7cd5.el7.x86_64
traffic_portal_build_1   | + mkdir -p 
/tmp/trafficcontrol/rpmbuild/BUILDROOT
traffic_portal_build_1   | + mkdir 
/tmp/trafficcontrol/rpmbuild/BUILDROOT/traffic_portal-3.0.0-10161.961a7cd5.el7.x86_64
traffic_portal_build_1   | + cd traffic_portal-3.0.0
traffic_portal_build_1   | + /usr/bin/mkdir -p 
/tmp/trafficcontrol/rpmbuild/BUILDROOT/traffic_portal-3.0.0-10161.961a7cd5.el7.x86_64/etc/init.d
traffic_portal_build_1   | + /usr/bin/mkdir -p 
/tmp/trafficcontrol/rpmbuild/BUILDROOT/traffic_portal-3.0.0-10161.961a7cd5.el7.x86_64/etc/logrotate.d
traffic_portal_build_1   | + /usr/bin/mkdir -p 
/tmp/trafficcontrol/rpmbuild/BUILDROOT/traffic_portal-3.0.0-10161.961a7cd5.el7.x86_64/etc/traffic_portal
traffic_portal_build_1   | + /usr/bin/mkdir -p 
/tmp/trafficcontrol/rpmbuild/BUILDROOT/traffic_portal-3.0.0-10161.961a7cd5.el7.x86_64/opt/traffic_portal/public
traffic_portal_build_1   | + /usr/bin/mkdir -p 

[GitHub] [trafficcontrol] asfgit commented on issue #2455: Add TO Go put deliveryservices/id/safe

[GitBox]

asfgit commented on issue #2455: Add TO Go put deliveryservices/id/safe
URL: https://github.com/apache/trafficcontrol/pull/2455#issuecomment-521663630
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/4148/
   Test FAILed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] asfgit commented on issue #3870: Rewrite /capabilities to Go

[GitBox]

asfgit commented on issue #3870: Rewrite /capabilities to Go
URL: https://github.com/apache/trafficcontrol/pull/3870#issuecomment-521660504
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/4147/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services