Jenkins build is back to normal : trafficcontrol-PR #4273

2019-09-17 Thread Apache Jenkins Server 
See

Build failed in Jenkins: trafficcontrol-PR #4272

2019-09-17 Thread Apache Jenkins Server 
See 

--
[...truncated 3.08 MB...]
traffic_portal_build_1   | |   `-- stack-trace@0.0.10 
traffic_portal_build_1   | +-- morgan@1.9.1 
traffic_portal_build_1   | | `-- basic-auth@2.0.1 
traffic_portal_build_1   | +-- requirejs@2.1.22 
traffic_portal_build_1   | `-- ssl-root-cas@1.1.10 
traffic_portal_build_1   |   +-- es6-promise@2.3.0 
traffic_portal_build_1   |   `-- request@2.88.0 
traffic_portal_build_1   | +-- aws-sign2@0.7.0 
traffic_portal_build_1   | +-- aws4@1.8.0 
traffic_portal_build_1   | +-- caseless@0.12.0 
traffic_portal_build_1   | +-- combined-stream@1.0.8 
traffic_portal_build_1   | | `-- delayed-stream@1.0.0 
traffic_portal_build_1   | +-- extend@3.0.2 
traffic_portal_build_1   | +-- forever-agent@0.6.1 
traffic_portal_build_1   | +-- form-data@2.3.3 
traffic_portal_build_1   | | `-- asynckit@0.4.0 
traffic_portal_build_1   | +-- har-validator@5.1.3 
traffic_portal_build_1   | | +-- ajv@6.10.2 
traffic_portal_build_1   | | | +-- fast-deep-equal@2.0.1 
traffic_portal_build_1   | | | +-- 
fast-json-stable-stringify@2.0.0 
traffic_portal_build_1   | | | +-- json-schema-traverse@0.4.1 
traffic_portal_build_1   | | | `-- uri-js@4.2.2 
traffic_portal_build_1   | | |   `-- punycode@2.1.1 
traffic_portal_build_1   | | `-- har-schema@2.0.0 
traffic_portal_build_1   | +-- http-signature@1.2.0 
traffic_portal_build_1   | | +-- assert-plus@1.0.0 
traffic_portal_build_1   | | +-- jsprim@1.4.1 
traffic_portal_build_1   | | | +-- extsprintf@1.3.0 
traffic_portal_build_1   | | | +-- json-schema@0.2.3 
traffic_portal_build_1   | | | `-- verror@1.10.0 
traffic_portal_build_1   | | `-- sshpk@1.16.1 
traffic_portal_build_1   | |   +-- asn1@0.2.4 
traffic_portal_build_1   | |   +-- bcrypt-pbkdf@1.0.2 
traffic_portal_build_1   | |   +-- dashdash@1.14.1 
traffic_portal_build_1   | |   +-- ecc-jsbn@0.1.2 
traffic_portal_build_1   | |   +-- getpass@0.1.7 
traffic_portal_build_1   | |   +-- jsbn@0.1.1 
traffic_portal_build_1   | |   `-- tweetnacl@0.14.5 
traffic_portal_build_1   | +-- is-typedarray@1.0.0 
traffic_portal_build_1   | +-- json-stringify-safe@5.0.1 
traffic_portal_build_1   | +-- oauth-sign@0.9.0 
traffic_portal_build_1   | +-- performance-now@2.1.0 
traffic_portal_build_1   | +-- qs@6.5.2 
traffic_portal_build_1   | +-- tough-cookie@2.4.3 
traffic_portal_build_1   | | +-- psl@1.4.0 
traffic_portal_build_1   | | `-- punycode@1.4.1 
traffic_portal_build_1   | +-- tunnel-agent@0.6.0 
traffic_portal_build_1   | `-- uuid@3.3.3 
traffic_portal_build_1   | 
traffic_portal_build_1   | npm WARN optional SKIPPING OPTIONAL 
DEPENDENCY: fsevents@^1.0.0 (node_modules/chokidar/node_modules/fsevents):
traffic_portal_build_1   | npm WARN notsup SKIPPING OPTIONAL 
DEPENDENCY: Unsupported platform for fsevents@1.2.9: wanted 
{"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
traffic_portal_build_1   | npm WARN traffic_portal@ No description
traffic_portal_build_1   | npm WARN traffic_portal@ No repository 
field.
traffic_portal_build_1   | npm WARN traffic_portal@ No license field.
traffic_portal_build_1   | 
traffic_portal_build_1   | Done.
traffic_portal_build_1   | 
traffic_portal_build_1   | 
traffic_portal_build_1   | Execution Time (2019-09-17 22:53:12 UTC)
traffic_portal_build_1   | loading tasks 1.2s  ▇ 3%
traffic_portal_build_1   | compass:prod  9.6s  
▇▇▇▇▇▇▇▇ 24%
traffic_portal_build_1   | browserify2:app-prod  2.2s  ▇▇ 
5%
traffic_portal_build_1   | browserify2:shared-libs-prod  3.3s  
▇▇▇ 8%
traffic_portal_build_1   | install-dependencies   24s  
▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇ 59%
traffic_portal_build_1   | Total 40.6s
traffic_portal_build_1   | 
traffic_portal_build_1   | + exit 0
traffic_portal_build_1   | Executing(%install): /bin/sh -e 
/var/tmp/rpm-tmp.Qz3EK5
traffic_portal_build_1   | + umask 022
traffic_portal_build_1   | + cd /tmp/trafficcontrol/rpmbuild/BUILD
traffic_portal_build_1   | + '[' 
/tmp/trafficcontrol/rpmbuild/BUILDROOT/traffic_portal-3.0.0-10203.42bb29f5.el7.x86_64

[GitHub] [trafficcontrol] asf-ci commented on issue #3911: To cache side configs plus cdns

2019-09-17 Thread GitBox 
asf-ci commented on issue #3911: To cache side configs plus cdns
URL: https://github.com/apache/trafficcontrol/pull/3911#issuecomment-532432894
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/4272/
   Test FAILed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] asf-ci commented on issue #3911: To cache side configs plus cdns

2019-09-17 Thread GitBox 
asf-ci commented on issue #3911: To cache side configs plus cdns
URL: https://github.com/apache/trafficcontrol/pull/3911#issuecomment-532428900
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/4271/
   Test FAILed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: trafficcontrol-PR #4271

2019-09-17 Thread Apache Jenkins Server 
See 


Changes:

[ocket] Rewrite /cachegroups/{{id}}/parameters to Go (#3900)

[ocket] Fix ordering in overview docs section (#3906)

[rawlin_peters] Add missing license headers to blueprints (#3907)

[mitchell852] CDN-in-a-Box now caches Carton dependencies by default (#3733)

[ocket] Rewrite cachegroups/{id}/unassigned_parameters to golang (#3905)

[ocket] Use LTS version of ubuntu image for dns container (#3916)

[ocket] Blueprint: new profile comparison/management view (#3894)

[rawlin_peters] Correcting some unnecessary diffs with master (#3920)

[rawlin_peters] Issue 3910 - Fixes issue where targets with RGB enabled cannot 
be

[rawlin_peters] Some best-practices updates to the kickstart script (#3691)

[rob] Add TO Go ATS CDN configs

[rob] Change atscfg ds name trimming to use funcs

[rob] Add client-side ATS config gen

[rob] Add TO deliveryserviceserver ids query params

[rob] Add ORT atstccfg to ort build scripts

[rob] Add ORT args to override hostname, OS check

[rob] Add ORT using atstccfg instead of TO directly

[rob] Add atstccfg insecure, timeout, cache age flags

[rob] Fix merge conflict

[rob] Add TO ORT gen profile configs

[rob] Add atstccfg changelog

[rob] Add atstccfg docs

[rob] Add license for vendored pflag

[rob] Remove old/wrong comments

[rob] Remove unused symbols

[rob] Removed docs comma

[rob] Fix merge conflict

[rob] Add CDN configs to generator

--
[...truncated 3.46 MB...]
traffic_portal_build_1   | |   +-- dashdash@1.14.1 
traffic_portal_build_1   | |   +-- ecc-jsbn@0.1.2 
traffic_portal_build_1   | |   +-- getpass@0.1.7 
traffic_portal_build_1   | |   +-- jsbn@0.1.1 
traffic_portal_build_1   | |   `-- tweetnacl@0.14.5 
traffic_portal_build_1   | +-- is-typedarray@1.0.0 
traffic_portal_build_1   | +-- json-stringify-safe@5.0.1 
traffic_portal_build_1   | +-- oauth-sign@0.9.0 
traffic_portal_build_1   | +-- performance-now@2.1.0 
traffic_portal_build_1   | +-- qs@6.5.2 
traffic_portal_build_1   | +-- tough-cookie@2.4.3 
traffic_portal_build_1   | | +-- psl@1.4.0 
traffic_portal_build_1   | | `-- punycode@1.4.1 
traffic_portal_build_1   | +-- tunnel-agent@0.6.0 
traffic_portal_build_1   | `-- uuid@3.3.3 
traffic_portal_build_1   | 
traffic_portal_build_1   | npm WARN optional SKIPPING OPTIONAL 
DEPENDENCY: fsevents@^1.0.0 (node_modules/chokidar/node_modules/fsevents):
traffic_portal_build_1   | npm WARN notsup SKIPPING OPTIONAL 
DEPENDENCY: Unsupported platform for fsevents@1.2.9: wanted 
{"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
traffic_portal_build_1   | npm WARN traffic_portal@ No description
traffic_portal_build_1   | npm WARN traffic_portal@ No repository 
field.
traffic_portal_build_1   | npm WARN traffic_portal@ No license field.
traffic_portal_build_1   | 
traffic_portal_build_1   | Done.
traffic_portal_build_1   | 
traffic_portal_build_1   | 
traffic_portal_build_1   | Execution Time (2019-09-17 22:35:31 UTC)
traffic_portal_build_1   | loading tasks 948ms  ▇ 
2%
traffic_portal_build_1   | compass:prod   8.3s  
▇▇▇▇▇▇▇ 22%
traffic_portal_build_1   | browserify2:app-prod   2.1s  
▇▇ 6%
traffic_portal_build_1   | browserify2:shared-libs-prod   3.8s  
▇▇▇▇ 10%
traffic_portal_build_1   | install-dependencies  22.5s  
▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇ 59%
traffic_portal_build_1   | Total 37.9s
traffic_portal_build_1   | 
traffic_portal_build_1   | + exit 0
traffic_portal_build_1   | Executing(%install): /bin/sh -e 
/var/tmp/rpm-tmp.CqNLSG
traffic_portal_build_1   | + umask 022
traffic_portal_build_1   | + cd /tmp/trafficcontrol/rpmbuild/BUILD
traffic_portal_build_1   | + '[' 
/tmp/trafficcontrol/rpmbuild/BUILDROOT/traffic_portal-3.0.0-10203.f5bc6459.el7.x86_64
 '!=' / ']'
traffic_portal_build_1   | + rm -rf 
/tmp/trafficcontrol/rpmbuild/BUILDROOT/traffic_portal-3.0.0-10203.f5bc6459.el7.x86_64
traffic_portal_build_1   | ++ dirname 
/tmp/trafficcontrol/rpmbuild/BUILDROOT/traffic_portal-3.0.0-10203.f5bc6459.el7.x86_64
traffic_portal_build_1   | + mkdir -p 
/tmp/trafficcontrol/rpmbuild/BUILDROOT
traffic_portal_build_1   | + mkdir 
/tmp/trafficcontrol/rpmbuild/BUILDROOT/traffic_portal-3.0.0-10203.f5bc6459.el7.x86_64
traffic_portal_build_1   | + cd traffic_portal-3.0.0

[GitHub] [trafficcontrol] rawlinp commented on issue #3762: Add Cache-Side Config Generator

2019-09-17 Thread GitBox 
rawlinp commented on issue #3762: Add Cache-Side Config Generator
URL: https://github.com/apache/trafficcontrol/pull/3762#issuecomment-532407042
 
 
   > All the logic is shared, in /lib/go-atscfg. The data loading is still 
using regular DB calls, though. I didn't see a clean way to use the API within 
TO. It's technically possible, but it would be much slower, and load lots of 
unnecessary data.
   
   Yeah, I don't think it's necessary to try to use the API within TO. Thanks!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] asf-ci commented on issue #3762: Add Cache-Side Config Generator

2019-09-17 Thread GitBox 
asf-ci commented on issue #3762: Add Cache-Side Config Generator
URL: https://github.com/apache/trafficcontrol/pull/3762#issuecomment-532402907
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/4270/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Jenkins build is back to normal : trafficcontrol-PR #4270

2019-09-17 Thread Apache Jenkins Server 
See

Build failed in Jenkins: trafficcontrol-PR #4269

2019-09-17 Thread Apache Jenkins Server 
See 

--
GitHub pull request #3762 of commit a0dcbe76181f1425a15d1582e39842ffe9180e1a, 
no merge conflicts.
Setting status of a0dcbe76181f1425a15d1582e39842ffe9180e1a to PENDING with url 
https://builds.apache.org/job/trafficcontrol-PR/4269/ and message: 'Build 
started for merge commit.'
Using context: default
[EnvInject] - Loading node environment variables.
Building remotely on H37 (ubuntu xenial) in workspace 

[WS-CLEANUP] Deleting project workspace...
[WS-CLEANUP] Deferred wipeout is used...
using credential b205a645-1ea7-4dfd-973d-c14ac43cab07
Cloning the remote Git repository
Cloning repository git://github.com/apache/trafficcontrol.git
 > git init  # timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress git://github.com/apache/trafficcontrol.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # 
 > timeout=10
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
using GIT_SSH to set credentials 
 > git fetch --tags --progress git://github.com/apache/trafficcontrol.git 
 > +refs/pull/*:refs/remotes/origin/pr/*
 > git rev-parse a0dcbe76181f1425a15d1582e39842ffe9180e1a^{commit} # timeout=10
 > git rev-parse origin/a0dcbe76181f1425a15d1582e39842ffe9180e1a^{commit} # 
 > timeout=10
 > git rev-parse a0dcbe76181f1425a15d1582e39842ffe9180e1a^{commit} # timeout=10
ERROR: Couldn't find any revision to build. Verify the repository and branch 
configuration for this job.
Retrying after 10 seconds
using credential b205a645-1ea7-4dfd-973d-c14ac43cab07
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress git://github.com/apache/trafficcontrol.git 
 > +refs/pull/*:refs/remotes/origin/pr/*
 > git rev-parse a0dcbe76181f1425a15d1582e39842ffe9180e1a^{commit} # timeout=10
 > git rev-parse origin/a0dcbe76181f1425a15d1582e39842ffe9180e1a^{commit} # 
 > timeout=10
 > git rev-parse a0dcbe76181f1425a15d1582e39842ffe9180e1a^{commit} # timeout=10
ERROR: Couldn't find any revision to build. Verify the repository and branch 
configuration for this job.
Retrying after 10 seconds
using credential b205a645-1ea7-4dfd-973d-c14ac43cab07
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress git://github.com/apache/trafficcontrol.git 
 > +refs/pull/*:refs/remotes/origin/pr/*
 > git rev-parse a0dcbe76181f1425a15d1582e39842ffe9180e1a^{commit} # timeout=10
 > git rev-parse origin/a0dcbe76181f1425a15d1582e39842ffe9180e1a^{commit} # 
 > timeout=10
 > git rev-parse a0dcbe76181f1425a15d1582e39842ffe9180e1a^{commit} # timeout=10
ERROR: Couldn't find any revision to build. Verify the repository and branch 
configuration for this job.
Skipped archiving because build is not successful

[GitHub] [trafficcontrol] asf-ci commented on issue #3762: Add Cache-Side Config Generator

2019-09-17 Thread GitBox 
asf-ci commented on issue #3762: Add Cache-Side Config Generator
URL: https://github.com/apache/trafficcontrol/pull/3762#issuecomment-532401502
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/4269/
   Test FAILed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] asf-ci commented on issue #3927: Fix using http2 between TO and TM when setting proxy

2019-09-17 Thread GitBox 
asf-ci commented on issue #3927: Fix using http2 between TO and TM when setting 
proxy
URL: https://github.com/apache/trafficcontrol/pull/3927#issuecomment-532401212
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/4268/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] asf-ci commented on issue #3925: Added SMTP configuration and APIInfo Email method

2019-09-17 Thread GitBox 
asf-ci commented on issue #3925: Added SMTP configuration and APIInfo Email 
method
URL: https://github.com/apache/trafficcontrol/pull/3925#issuecomment-532399622
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/4267/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Jenkins build is back to normal : trafficcontrol-PR #4266

2019-09-17 Thread Apache Jenkins Server 
See

[GitHub] [trafficcontrol] asf-ci commented on issue #3926: On cachestats get if all TMs fail to return data TO returns failure

2019-09-17 Thread GitBox 
asf-ci commented on issue #3926: On cachestats get if all TMs fail to return 
data TO returns failure
URL: https://github.com/apache/trafficcontrol/pull/3926#issuecomment-532398188
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/4266/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] rob05c edited a comment on issue #3762: Add Cache-Side Config Generator

2019-09-17 Thread GitBox 
rob05c edited a comment on issue #3762: Add Cache-Side Config Generator
URL: https://github.com/apache/trafficcontrol/pull/3762#issuecomment-532393639
 
 
   >License header problems
   
   Fixed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] rob05c commented on issue #3762: Add Cache-Side Config Generator

2019-09-17 Thread GitBox 
rob05c commented on issue #3762: Add Cache-Side Config Generator
URL: https://github.com/apache/trafficcontrol/pull/3762#issuecomment-532394345
 
 
   >Where did we land on the idea to share code between the new atstccfg tool 
and the API and just replacing DB queries w/ API calls? Are we doing that?
   
   All the logic is shared, in `/lib/go-atscfg`. The data loading is still 
using regular DB calls, though. I didn't see a clean way to use the API within 
TO. It's technically possible, but it would be much slower, and load lots of 
unnecessary data.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] rob05c commented on a change in pull request #3762: Add Cache-Side Config Generator

2019-09-17 Thread GitBox 
rob05c commented on a change in pull request #3762: Add Cache-Side Config 
Generator
URL: https://github.com/apache/trafficcontrol/pull/3762#discussion_r325376282
 
 

 ##
 File path: LICENSE
 ##
 @@ -440,3 +440,7 @@ For the lestrrat-go/jwx (commit e35178a) component:
 For the dgrijalva/jwt-go (commit 5e25c22) component:
 @traffic_ops/traffic_ops_golang/vendor/github.com/dgrijalva/jwt-go/*
 ./traffic_ops/traffic_ops_golang/vendor/github.com/dgrijalva/jwt-go/LICENSE
+
+For the ogier/pflag component:
 
 Review comment:
   Done.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] rob05c commented on issue #3762: Add Cache-Side Config Generator

2019-09-17 Thread GitBox 
rob05c commented on issue #3762: Add Cache-Side Config Generator
URL: https://github.com/apache/trafficcontrol/pull/3762#issuecomment-532393639
 
 
   >License header problems
   Fixed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: trafficcontrol-PR #4265

2019-09-17 Thread Apache Jenkins Server 
See 


Changes:

[ocket] Rewrite /cachegroups/{{id}}/parameters to Go (#3900)

[ocket] Fix ordering in overview docs section (#3906)

[rawlin_peters] Add missing license headers to blueprints (#3907)

[mitchell852] CDN-in-a-Box now caches Carton dependencies by default (#3733)

[ocket] Rewrite cachegroups/{id}/unassigned_parameters to golang (#3905)

[ocket] Use LTS version of ubuntu image for dns container (#3916)

[ocket] Blueprint: new profile comparison/management view (#3894)

[rawlin_peters] Correcting some unnecessary diffs with master (#3920)

[rawlin_peters] Issue 3910 - Fixes issue where targets with RGB enabled cannot 
be

[rawlin_peters] Some best-practices updates to the kickstart script (#3691)

[ocket] Added SMTP configuration and APIInfo Email method

--
[...truncated 3.35 MB...]
traffic_portal_build_1   | npm WARN traffic_portal@ No license field.
traffic_portal_build_1   | 
traffic_portal_build_1   | Done.
traffic_portal_build_1   | 
traffic_portal_build_1   | 
traffic_portal_build_1   | Execution Time (2019-09-17 20:10:09 UTC)
traffic_portal_build_1   | loading tasks  1.1s  ▇ 3%
traffic_portal_build_1   | compass:prod11s  
▇▇▇▇▇▇▇▇▇ 26%
traffic_portal_build_1   | browserify2:app-prod   3.2s  
▇▇▇ 7%
traffic_portal_build_1   | browserify2:shared-libs-prod   3.8s  
▇▇▇ 9%
traffic_portal_build_1   | install-dependencies  23.3s  
▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇ 54%
traffic_portal_build_1   | Total 42.9s
traffic_portal_build_1   | 
traffic_portal_build_1   | + exit 0
traffic_portal_build_1   | Executing(%install): /bin/sh -e 
/var/tmp/rpm-tmp.XgOLNW
traffic_portal_build_1   | + umask 022
traffic_portal_build_1   | + cd /tmp/trafficcontrol/rpmbuild/BUILD
traffic_portal_build_1   | + '[' 
/tmp/trafficcontrol/rpmbuild/BUILDROOT/traffic_portal-3.0.0-10186.24e4778f.el7.x86_64
 '!=' / ']'
traffic_portal_build_1   | + rm -rf 
/tmp/trafficcontrol/rpmbuild/BUILDROOT/traffic_portal-3.0.0-10186.24e4778f.el7.x86_64
traffic_portal_build_1   | ++ dirname 
/tmp/trafficcontrol/rpmbuild/BUILDROOT/traffic_portal-3.0.0-10186.24e4778f.el7.x86_64
traffic_portal_build_1   | + mkdir -p 
/tmp/trafficcontrol/rpmbuild/BUILDROOT
traffic_portal_build_1   | + mkdir 
/tmp/trafficcontrol/rpmbuild/BUILDROOT/traffic_portal-3.0.0-10186.24e4778f.el7.x86_64
traffic_portal_build_1   | + cd traffic_portal-3.0.0
traffic_portal_build_1   | + /usr/bin/mkdir -p 
/tmp/trafficcontrol/rpmbuild/BUILDROOT/traffic_portal-3.0.0-10186.24e4778f.el7.x86_64/etc/init.d
traffic_portal_build_1   | + /usr/bin/mkdir -p 
/tmp/trafficcontrol/rpmbuild/BUILDROOT/traffic_portal-3.0.0-10186.24e4778f.el7.x86_64/etc/logrotate.d
traffic_portal_build_1   | + /usr/bin/mkdir -p 
/tmp/trafficcontrol/rpmbuild/BUILDROOT/traffic_portal-3.0.0-10186.24e4778f.el7.x86_64/etc/traffic_portal
traffic_portal_build_1   | + /usr/bin/mkdir -p 
/tmp/trafficcontrol/rpmbuild/BUILDROOT/traffic_portal-3.0.0-10186.24e4778f.el7.x86_64/opt/traffic_portal/public
traffic_portal_build_1   | + /usr/bin/mkdir -p 
/tmp/trafficcontrol/rpmbuild/BUILDROOT/traffic_portal-3.0.0-10186.24e4778f.el7.x86_64/opt/traffic_portal/server
traffic_portal_build_1   | + /usr/bin/mkdir -p 
/tmp/trafficcontrol/rpmbuild/BUILDROOT/traffic_portal-3.0.0-10186.24e4778f.el7.x86_64/var/log/traffic_portal
traffic_portal_build_1   | + /usr/bin/cp 
/tmp/trafficcontrol/rpmbuild/BUILD/traffic_portal-3.0.0/server.js 
/tmp/trafficcontrol/rpmbuild/BUILDROOT/traffic_portal-3.0.0-10186.24e4778f.el7.x86_64/opt/traffic_portal/.
traffic_portal_build_1   | + /usr/bin/cp -r 
/tmp/trafficcontrol/rpmbuild/BUILD/traffic_portal-3.0.0/conf 
/tmp/trafficcontrol/rpmbuild/BUILDROOT/traffic_portal-3.0.0-10186.24e4778f.el7.x86_64/etc/traffic_portal/.
traffic_portal_build_1   | + /usr/bin/cp 
/tmp/trafficcontrol/rpmbuild/BUILD/traffic_portal-3.0.0/build/etc/init.d/traffic_portal
 
/tmp/trafficcontrol/rpmbuild/BUILDROOT/traffic_portal-3.0.0-10186.24e4778f.el7.x86_64/etc/init.d/.
traffic_portal_build_1   | + /usr/bin/cp 
/tmp/trafficcontrol/rpmbuild/BUILD/traffic_portal-3.0.0/build/etc/logrotate.d/traffic_portal
 
/tmp/trafficcontrol/rpmbuild/BUILDROOT/traffic_portal-3.0.0-10186.24e4778f.el7.x86_64/etc/logrotate.d/.
traffic_portal_build_1   | + /usr/bin/cp 
/tmp/trafficcontrol/rpmbuild/BUILD/traffic_portal-3.0.0/build/etc/logrotate.d/traffic_portal-access
 
/tmp/trafficcontrol/rpmbuild/BUILDROOT/traffic_portal-3.0.0-10186.24e4778f.el7.x86_64/etc/logrotate.d/.
traffic_portal_build_1

[GitHub] [trafficcontrol] asf-ci commented on issue #3925: Added SMTP configuration and APIInfo Email method

2019-09-17 Thread GitBox 
asf-ci commented on issue #3925: Added SMTP configuration and APIInfo Email 
method
URL: https://github.com/apache/trafficcontrol/pull/3925#issuecomment-532382343
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/4265/
   Test FAILed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mhoppa opened a new pull request #3927: Fix using http2 between TO and TM when setting proxy

2019-09-17 Thread GitBox 
mhoppa opened a new pull request #3927: Fix using http2 between TO and TM when 
setting proxy
URL: https://github.com/apache/trafficcontrol/pull/3927
 
 
   
   ## What does this PR (Pull Request) do?
   
   
   - [x] This PR fixes #3902
   
   If TM has an https proxy set that is used by TO to connect it will fail as 
golang uses http2 be default in that case. This PR overrides that behavior 
based on the net godocs https://golang.org/src/net/http/doc.go  
   
   
   ## Which Traffic Control components are affected by this PR?
   
   
   - Traffic Ops
   
   ## What is the best way to verify this PR?
   
   
   Setup TM proxy with HTTPs ensure endpoint cdns/capacity work
   
   ## If this is a bug fix, what versions of Traffic Control are affected?
   
   
   - master (5b018e2b)
   
   
   ## The following criteria are ALL met by this PR
   
   
   - [x] This PR does not include tests OR I have explained why tests are 
unnecessary
   - [x] This PR includes documentation OR I have explained why documentation 
is unnecessary
   - [x] This PR includes an update to CHANGELOG.md OR such an update is not 
necessary
   - [x] This PR includes any and all required license headers
   - [x] This PR ensures that database migration sequence is correct OR this PR 
does not include a database migration
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the 
Apache Software Foundation's security 
guidelines](https://www.apache.org/security/) for details)
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mhoppa opened a new pull request #3926: On cachestats get if all TMs fail to return data return failure

2019-09-17 Thread GitBox 
mhoppa opened a new pull request #3926: On cachestats get if all TMs fail to 
return data return failure
URL: https://github.com/apache/trafficcontrol/pull/3926
 
 
   
   ## What does this PR (Pull Request) do?
   
   
   - [x] This PR is not related to any Issue 
   
   Currently if a user queries caches/stats from TO and TO fails to get data 
from all TMs it silently logs those errors and returns success to the end user. 
   
   This PR is changing that behavior so in that case TO will return an error to 
the user
   
   ## Which Traffic Control components are affected by this PR?
   
   
   - Traffic Ops
   
   ## What is the best way to verify this PR?
   
   Build TO with it and have no access to the TMs. When querying caches/stats 
you should now receive an error. 
   
   
   ## The following criteria are ALL met by this PR
   
   
   - [x] This PR does not include tests
   - [x] This PR does not need documentation
   - [x] This PR does not include an update to CHANGELOG.md
   - [x] This PR includes any and all required license headers
   - [x] This PR does not include a database migration
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the 
Apache Software Foundation's security 
guidelines](https://www.apache.org/security/) for details)
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] asf-ci commented on issue #3762: Add Cache-Side Config Generator

2019-09-17 Thread GitBox 
asf-ci commented on issue #3762: Add Cache-Side Config Generator
URL: https://github.com/apache/trafficcontrol/pull/3762#issuecomment-532352852
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/4264/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] asf-ci commented on issue #3925: Added SMTP configuration and APIInfo Email method

2019-09-17 Thread GitBox 
asf-ci commented on issue #3925: Added SMTP configuration and APIInfo Email 
method
URL: https://github.com/apache/trafficcontrol/pull/3925#issuecomment-532350307
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/4263/
   Test FAILed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: trafficcontrol-PR #4263

2019-09-17 Thread Apache Jenkins Server 
See 


Changes:

[ocket] Use LTS version of ubuntu image for dns container (#3916)

[ocket] Blueprint: new profile comparison/management view (#3894)

[rawlin_peters] Correcting some unnecessary diffs with master (#3920)

[rawlin_peters] Issue 3910 - Fixes issue where targets with RGB enabled cannot 
be

[rawlin_peters] Some best-practices updates to the kickstart script (#3691)

[ocket] Added SMTP configuration and APIInfo Email method

--
[...truncated 3.36 MB...]
traffic_portal_build_1   | +-- extend@3.0.2 
traffic_portal_build_1   | +-- forever-agent@0.6.1 
traffic_portal_build_1   | +-- form-data@2.3.3 
traffic_portal_build_1   | | `-- asynckit@0.4.0 
traffic_portal_build_1   | +-- har-validator@5.1.3 
traffic_portal_build_1   | | +-- ajv@6.10.2 
traffic_portal_build_1   | | | +-- fast-deep-equal@2.0.1 
traffic_portal_build_1   | | | +-- 
fast-json-stable-stringify@2.0.0 
traffic_portal_build_1   | | | +-- json-schema-traverse@0.4.1 
traffic_portal_build_1   | | | `-- uri-js@4.2.2 
traffic_portal_build_1   | | |   `-- punycode@2.1.1 
traffic_portal_build_1   | | `-- har-schema@2.0.0 
traffic_portal_build_1   | +-- http-signature@1.2.0 
traffic_portal_build_1   | | +-- assert-plus@1.0.0 
traffic_portal_build_1   | | +-- jsprim@1.4.1 
traffic_portal_build_1   | | | +-- extsprintf@1.3.0 
traffic_portal_build_1   | | | +-- json-schema@0.2.3 
traffic_portal_build_1   | | | `-- verror@1.10.0 
traffic_portal_build_1   | | `-- sshpk@1.16.1 
traffic_portal_build_1   | |   +-- asn1@0.2.4 
traffic_portal_build_1   | |   +-- bcrypt-pbkdf@1.0.2 
traffic_portal_build_1   | |   +-- dashdash@1.14.1 
traffic_portal_build_1   | |   +-- ecc-jsbn@0.1.2 
traffic_portal_build_1   | |   +-- getpass@0.1.7 
traffic_portal_build_1   | |   +-- jsbn@0.1.1 
traffic_portal_build_1   | |   `-- tweetnacl@0.14.5 
traffic_portal_build_1   | +-- is-typedarray@1.0.0 
traffic_portal_build_1   | +-- json-stringify-safe@5.0.1 
traffic_portal_build_1   | +-- oauth-sign@0.9.0 
traffic_portal_build_1   | +-- performance-now@2.1.0 
traffic_portal_build_1   | +-- qs@6.5.2 
traffic_portal_build_1   | +-- tough-cookie@2.4.3 
traffic_portal_build_1   | | +-- psl@1.4.0 
traffic_portal_build_1   | | `-- punycode@1.4.1 
traffic_portal_build_1   | +-- tunnel-agent@0.6.0 
traffic_portal_build_1   | `-- uuid@3.3.3 
traffic_portal_build_1   | 
traffic_portal_build_1   | npm WARN optional SKIPPING OPTIONAL 
DEPENDENCY: fsevents@^1.0.0 (node_modules/chokidar/node_modules/fsevents):
traffic_portal_build_1   | npm WARN notsup SKIPPING OPTIONAL 
DEPENDENCY: Unsupported platform for fsevents@1.2.9: wanted 
{"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
traffic_portal_build_1   | npm WARN traffic_portal@ No description
traffic_portal_build_1   | npm WARN traffic_portal@ No repository 
field.
traffic_portal_build_1   | npm WARN traffic_portal@ No license field.
traffic_portal_build_1   | 
traffic_portal_build_1   | Done.
traffic_portal_build_1   | 
traffic_portal_build_1   | 
traffic_portal_build_1   | Execution Time (2019-09-17 18:42:56 UTC)
traffic_portal_build_1   | loading tasks  1.3s  
▇▇ 3%
traffic_portal_build_1   | compass:prod10s  
▇▇▇▇▇▇▇▇ 24%
traffic_portal_build_1   | browserify2:app-prod   1.8s  
▇▇ 4%
traffic_portal_build_1   | browserify2:shared-libs-prod   2.4s  
▇▇ 6%
traffic_portal_build_1   | install-dependencies  25.9s  
▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇ 62%
traffic_portal_build_1   | Total 41.9s
traffic_portal_build_1   | 
traffic_portal_build_1   | + exit 0
traffic_portal_build_1   | Executing(%install): /bin/sh -e 
/var/tmp/rpm-tmp.BTr8yT
traffic_portal_build_1   | + umask 022
traffic_portal_build_1   | + cd /tmp/trafficcontrol/rpmbuild/BUILD
traffic_portal_build_1   | + '[' 
/tmp/trafficcontrol/rpmbuild/BUILDROOT/traffic_portal-3.0.0-10186.651d75b3.el7.x86_64
 '!=' / ']'
traffic_portal_build_1   | + rm -rf

[GitHub] [trafficcontrol] ocket8888 opened a new pull request #3925: Added SMTP configuration and APIInfo Email method

2019-09-17 Thread GitBox 
ocket opened a new pull request #3925: Added SMTP configuration and APIInfo 
Email method
URL: https://github.com/apache/trafficcontrol/pull/3925
 
 
   ## What does this PR (Pull Request) do?
   - [x] This PR is not related to any Issue
   
   ## Which Traffic Control components are affected by this PR?
   - Traffic Ops
   
   The configuration file is undocumented. It shouldn't be, but doing so is 
outside the scope of this PR.
   
   ## What is the best way to verify this PR?
   Create a configuration file with a valid SMTP server configuration and try 
to start Traffic Ops. Config should parse fine.
   
   ## The following criteria are ALL met by this PR
   - [x] Tests are unnecessary
   - [x] I have explained why documentation is absent
   - [x] This PR includes an update to CHANGELOG.md
   - [x] This PR includes any and all required license headers
   - [x] This PR does not include a database migration
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY**


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 commented on issue #3503: Comparison using is when operands support __eq__

2019-09-17 Thread GitBox 
ocket commented on issue #3503: Comparison using is when operands support 
__eq__
URL: https://github.com/apache/trafficcontrol/pull/3503#issuecomment-532310719
 
 
   Obsolete as of #3691 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 closed pull request #3503: Comparison using is when operands support __eq__

2019-09-17 Thread GitBox 
ocket closed pull request #3503: Comparison using is when operands support 
__eq__
URL: https://github.com/apache/trafficcontrol/pull/3503
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] rawlinp merged pull request #3691: Some best-practices updates to the kickstart script

2019-09-17 Thread GitBox 
rawlinp merged pull request #3691: Some best-practices updates to the kickstart 
script
URL: https://github.com/apache/trafficcontrol/pull/3691
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Jenkins build is back to normal : trafficcontrol-PR #4262

2019-09-17 Thread Apache Jenkins Server 
See

[GitHub] [trafficcontrol] asf-ci commented on issue #3919: TP: adds a better view for comparing/managing params of 2 profiles

2019-09-17 Thread GitBox 
asf-ci commented on issue #3919: TP: adds a better view for comparing/managing 
params of 2 profiles
URL: https://github.com/apache/trafficcontrol/pull/3919#issuecomment-532270792
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/4262/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #3919: TP: adds a better view for comparing/managing params of 2 profiles

2019-09-17 Thread GitBox 
mitchell852 commented on a change in pull request #3919: TP: adds a better view 
for comparing/managing params of 2 profiles
URL: https://github.com/apache/trafficcontrol/pull/3919#discussion_r325229014
 
 

 ##
 File path: 
traffic_portal/app/src/common/modules/table/profilesParamsCompare/TableProfilesParamsCompareController.js
 ##
 @@ -0,0 +1,213 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+var TableProfilesParamsCompareController = function(profile1, profile2, 
profilesParams, $scope, $state, $q, $uibModal, messageModel, locationUtils, 
deliveryServiceService, profileParameterService, serverService) {
+
+   this.profile1Usage;
+   this.profile2Usage;
+
+   let updateProfile1 = false,
+   updateProfile2 = false;
+
+   let getProfileUsage = function(profile, profNum) {
+   if (profile.type === 'DS_PROFILE') { // if this is a ds 
profile, then it is used by delivery service(s) so we'll fetch the ds count...
+   deliveryServiceService.getDeliveryServices({ profile: 
profile.id }).
+   then(function(result) {
+   this['profile' + profNum + 'Usage'] = 
result.length + ' delivery services';
+   });
+   } else { // otherwise the profile is used by servers so we'll 
fetch the server count...
+   serverService.getServers({ profileId: profile.id }).
+   then(function(result) {
+   this['profile' + profNum + 'Usage'] = 
result.length + ' servers';
+   });
+   }
+   };
+
+   let confirmUpdateProfiles = function() {
+   // ok, this method is fun :)
+   let params = {
+   title: 'Modify ' + profile1.name + ' parameters',
+   message: 'The ' + profile1.name + ' profile is used by 
' + this.profile1Usage + '. Are you sure you want to modify the parameters?'
+   };
+   let modalInstance = $uibModal.open({
+   templateUrl: 
'common/modules/dialog/confirm/dialog.confirm.tpl.html',
+   controller: 'DialogConfirmController',
+   size: 'md',
+   resolve: {
+   params: function () {
+   return params;
+   }
+   }
+   });
+   modalInstance.result
+   .then(
+   function() { updateProfile1 = true; },
+   function() { updateProfile1 = false; }
+   )
+   .finally(
+   function() {
+   let params = {
+   title: 'Modify ' + 
profile2.name + ' parameters',
+   message: 'The ' + profile2.name 
+ ' profile is used by ' + this.profile2Usage + '. Are you sure you want to 
modify the parameters?'
+   };
+   let modalInstance = $uibModal.open({
+   templateUrl: 
'common/modules/dialog/confirm/dialog.confirm.tpl.html',
+   controller: 
'DialogConfirmController',
+   size: 'md',
+   resolve: {
+   params: function () {
+   return params;
+   }
+   }
+   });
+   modalInstance.result
+   .then(
+   function() { 
updateProfile2 = true; },
+

[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #3919: TP: adds a better view for comparing/managing params of 2 profiles

2019-09-17 Thread GitBox 
mitchell852 commented on a change in pull request #3919: TP: adds a better view 
for comparing/managing params of 2 profiles
URL: https://github.com/apache/trafficcontrol/pull/3919#discussion_r325228037
 
 

 ##
 File path: traffic_portal/app/src/styles/main.scss
 ##
 @@ -183,6 +183,13 @@ table {
   margin-right: 5px;
 }
 
+input[type="checkbox"].dirty {
+  -moz-box-shadow:inset 0 0 10px red;
+  -webkit-box-shadow: inset 0 0 10px red;
+  box-shadow: inset 0 0 10px red;
 
 Review comment:
   changed to green


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services