[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7151: Use Generics in TO Integration Tests

2022-10-21 Thread GitBox
zrhoffman commented on code in PR #7151: URL: https://github.com/apache/trafficcontrol/pull/7151#discussion_r1002131580 ## traffic_ops/testing/api/v5/cachegroups_test.go: ## @@ -65,184 +67,173 @@ func TestCacheGroups(t *testing.T) {

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7151: Use Generics in TO Integration Tests

2022-10-21 Thread GitBox
zrhoffman commented on code in PR #7151: URL: https://github.com/apache/trafficcontrol/pull/7151#discussion_r1002127862 ## traffic_ops/testing/api/v5/deliveryservices_required_capabilities_test.go: ## @@ -79,119 +83,123 @@ func TestDeliveryServicesRequiredCapabilities(t

[GitHub] [trafficcontrol] ericholguin opened a new pull request, #7151: Use Generics in TO Integration Tests

2022-10-21 Thread GitBox
ericholguin opened a new pull request, #7151: URL: https://github.com/apache/trafficcontrol/pull/7151 Updated the tests to use the new generics test struct ## Which Traffic Control components are affected by this PR? - Traffic Ops Tests ## What is the

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7068: Renamed rascal to tm/traffic_monitor

2022-10-21 Thread GitBox
rimashah25 commented on code in PR #7068: URL: https://github.com/apache/trafficcontrol/pull/7068#discussion_r1002009697 ## traffic_ops/app/db/migrations/2022100610190300_update_rascal_to_traffic_monitor.up.sql: ## @@ -0,0 +1,35 @@ +/* + * Licensed to the Apache Software