[GitHub] [trafficcontrol] amarbs commented on pull request #7083: Tr fix nxdomain

2023-01-20 Thread GitBox
amarbs commented on PR #7083: URL: https://github.com/apache/trafficcontrol/pull/7083#issuecomment-1398210687 I have incorporated this patch on a 6.1.x traffic-router. It is working fine for me. query for record for which a A record exists, but does not: ```

[GitHub] [trafficcontrol] ocket8888 merged pull request #7294: Fix Internal Server Error when GETting sslkey_expirations endpoint

2023-01-19 Thread GitBox
ocket merged PR #7294: URL: https://github.com/apache/trafficcontrol/pull/7294 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] ocket8888 closed issue #7293: Internal Server Error: GET /api/4.1/sslkey_expirations

2023-01-19 Thread GitBox
ocket closed issue #7293: Internal Server Error: GET /api/4.1/sslkey_expirations URL: https://github.com/apache/trafficcontrol/issues/7293 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [trafficcontrol] ocket8888 merged pull request #7298: Separate Go Unit GHA into individual workflows

2023-01-19 Thread GitBox
ocket merged PR #7298: URL: https://github.com/apache/trafficcontrol/pull/7298 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] zrhoffman commented on pull request #7298: Separate Go Unit GHA into individual workflows

2023-01-19 Thread GitBox
zrhoffman commented on PR #7298: URL: https://github.com/apache/trafficcontrol/pull/7298#issuecomment-1397743743 > One thing Zach didn't mention: according to what I'm seeing here, the lib tests only run if code in the lib changes. But that library is linked to from, I think, every other

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7298: Separate Go Unit GHA into individual workflows

2023-01-19 Thread GitBox
zrhoffman commented on code in PR #7298: URL: https://github.com/apache/trafficcontrol/pull/7298#discussion_r1081956473 ## .github/workflows/cache-config.unit.tests.yml: ## @@ -0,0 +1,84 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7298: Separate Go Unit GHA into individual workflows

2023-01-19 Thread GitBox
zrhoffman commented on code in PR #7298: URL: https://github.com/apache/trafficcontrol/pull/7298#discussion_r1081967259 ## .github/workflows/cache-config.unit.tests.yml: ## @@ -0,0 +1,84 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] [trafficcontrol] shamrickus opened a new pull request, #7303: Add Physical Location Page to TPv2

2023-01-19 Thread GitBox
shamrickus opened a new pull request, #7303: URL: https://github.com/apache/trafficcontrol/pull/7303 This PR implements the Physical Locations table/detail views. It also adds a sidebar and the header service has been converted to a navigation service responsible for both the

[GitHub] [trafficcontrol] ericholguin commented on a diff in pull request #7298: Separate Go Unit GHA into individual workflows

2023-01-19 Thread GitBox
ericholguin commented on code in PR #7298: URL: https://github.com/apache/trafficcontrol/pull/7298#discussion_r1081966622 ## .github/workflows/cache-config.unit.tests.yml: ## @@ -0,0 +1,84 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7298: Separate Go Unit GHA into individual workflows

2023-01-19 Thread GitBox
zrhoffman commented on code in PR #7298: URL: https://github.com/apache/trafficcontrol/pull/7298#discussion_r1081956473 ## .github/workflows/cache-config.unit.tests.yml: ## @@ -0,0 +1,84 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] [trafficcontrol] zrhoffman commented on pull request #7298: Separate Go Unit GHA into individual workflows

2023-01-19 Thread GitBox
zrhoffman commented on PR #7298: URL: https://github.com/apache/trafficcontrol/pull/7298#issuecomment-1397722042 > > Since we're running all Go unit tests on every Go-modifying PR, splitting the Go unit tests by component means occupying 6 runners for each such PR instead of 1, which is a

[GitHub] [trafficcontrol] ocket8888 commented on pull request #7294: Fix Internal Server Error when GETting sslkey_expirations endpoint

2023-01-19 Thread GitBox
ocket commented on PR #7294: URL: https://github.com/apache/trafficcontrol/pull/7294#issuecomment-1397698240 Other than the Changelog, this looks good to go. Tested it and it's working. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [trafficcontrol] rawlinp closed issue #7297: TP integration tests fail in CiaB: `Fatal error, run database recovery`

2023-01-19 Thread GitBox
rawlinp closed issue #7297: TP integration tests fail in CiaB: `Fatal error, run database recovery` URL: https://github.com/apache/trafficcontrol/issues/7297 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [trafficcontrol] rawlinp merged pull request #7300: Rebuild RPM DB after installing NodeSource repo on RHEL 7

2023-01-19 Thread GitBox
rawlinp merged PR #7300: URL: https://github.com/apache/trafficcontrol/pull/7300 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] github-code-scanning[bot] commented on a diff in pull request #7302: added anycast traffic routing ability, and lastpoll time for v6

2023-01-19 Thread GitBox
github-code-scanning[bot] commented on code in PR #7302: URL: https://github.com/apache/trafficcontrol/pull/7302#discussion_r1081774801 ## traffic_monitor/cache/astats.go: ## @@ -116,8 +117,23 @@ astats.Ats["system.proc.loadavg"] = astats.System.ProcLoadavg

[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7302: added anycast traffic routing ability, and lastpoll time for v6

2023-01-19 Thread GitBox
codecov[bot] commented on PR #7302: URL: https://github.com/apache/trafficcontrol/pull/7302#issuecomment-1397520331 #

[GitHub] [trafficcontrol] ericholguin commented on pull request #7298: Separate Go Unit GHA into individual workflows

2023-01-19 Thread GitBox
ericholguin commented on PR #7298: URL: https://github.com/apache/trafficcontrol/pull/7298#issuecomment-1397520223 > Since we're running all Go unit tests on every Go-modifying PR, splitting the Go unit tests by component means occupying 6 runners for each such PR instead of 1, which is a

[GitHub] [trafficcontrol] serDrem opened a new pull request, #7302: added anycast traffic routing ability, and lastpoll time for v6

2023-01-19 Thread GitBox
serDrem opened a new pull request, #7302: URL: https://github.com/apache/trafficcontrol/pull/7302 These changes enable TM to poll caches that have the same ip address and are in ecmp on the same router, and direct traffic to them appropriately. ## Which Traffic Control components are

[GitHub] [trafficcontrol] mitchell852 commented on pull request #7296: Traffic Portal configuration option for Delivery Service active flags

2023-01-19 Thread GitBox
mitchell852 commented on PR #7296: URL: https://github.com/apache/trafficcontrol/pull/7296#issuecomment-1397448779 @ocket - arent there a bunch of DS tables as well that will still say "primed"? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [trafficcontrol] zrhoffman merged pull request #7296: Traffic Portal configuration option for Delivery Service active flags

2023-01-19 Thread GitBox
zrhoffman merged PR #7296: URL: https://github.com/apache/trafficcontrol/pull/7296 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] ericholguin commented on pull request #7298: Separate Go Unit GHA into individual workflows

2023-01-19 Thread GitBox
ericholguin commented on PR #7298: URL: https://github.com/apache/trafficcontrol/pull/7298#issuecomment-1397379289 > What is the goal of splitting the Go unit tests into components? Since we'd like to run all the unit tests regardless of files modified, the only goal would be to have

[GitHub] [trafficcontrol] ocket8888 commented on pull request #7296: Traffic Portal configuration option for Delivery Service active flags

2023-01-19 Thread GitBox
ocket commented on PR #7296: URL: https://github.com/apache/trafficcontrol/pull/7296#issuecomment-1397356383 The old notion of "inactive" is what is known as "primed" in APIv5. True "INACTIVE" is not available prior to that version, so when `exposeInactive` is `true`, it'll show all

[GitHub] [trafficcontrol] ocket8888 opened a new issue, #7301: CiaB RPMs can only be `make`-d once without manual intervention

2023-01-19 Thread GitBox
ocket opened a new issue, #7301: URL: https://github.com/apache/trafficcontrol/issues/7301 ## This Bug Report affects these Traffic Control components: - CDN in a Box ## Current behavior: When running `make` in the CDN-in-a-Box directory, `make` will attempt to use the

[GitHub] [trafficcontrol] rimashah25 commented on pull request #7296: Traffic Portal configuration option for Delivery Service active flags

2023-01-19 Thread GitBox
rimashah25 commented on PR #7296: URL: https://github.com/apache/trafficcontrol/pull/7296#issuecomment-1397342010 > Can you help me understand what this does @ocket ? > > exposeInactive = true will display 3 options? active, primed, AND inactive exposeInactive = false will

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7294: Fix Internal Server Error when GETting sslkeys_expirations endpoint

2023-01-19 Thread GitBox
ocket commented on code in PR #7294: URL: https://github.com/apache/trafficcontrol/pull/7294#discussion_r1081589154 ## CHANGELOG.md: ## @@ -36,6 +36,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/). -

[GitHub] [trafficcontrol] zrhoffman opened a new pull request, #7300: Rebuild RPM DB after installing NodeSource repo on RHEL 7

2023-01-19 Thread GitBox
zrhoffman opened a new pull request, #7300: URL: https://github.com/apache/trafficcontrol/pull/7300 This PR fixes #7297 by running `rpm --rebuilddb` if installing `nodejs` fails without that. ## Which Traffic Control components are affected by this PR? - CDN in a

[GitHub] [trafficcontrol] shamrickus commented on a diff in pull request #7292: TPv2 Cache Groups table/details pages

2023-01-19 Thread GitBox
shamrickus commented on code in PR #7292: URL: https://github.com/apache/trafficcontrol/pull/7292#discussion_r1081549988 ## experimental/traffic-portal/src/app/core/cache-groups/cache-group-table/cache-group-table.component.ts: ## @@ -162,13 +222,78 @@ export class

[GitHub] [trafficcontrol] ragen14 opened a new pull request, #7299: updating snapshot url and logic

2023-01-19 Thread GitBox
ragen14 opened a new pull request, #7299: URL: https://github.com/apache/trafficcontrol/pull/7299 ## Which Traffic Control components are affected by this PR? - Automation -- Ansible Roles ## What is the best way to verify this PR? Run ansible plays

[GitHub] [trafficcontrol] mitchell852 commented on pull request #7296: Traffic Portal configuration option for Delivery Service active flags

2023-01-19 Thread GitBox
mitchell852 commented on PR #7296: URL: https://github.com/apache/trafficcontrol/pull/7296#issuecomment-1397194147 Can you help me understand what this does @ocket ? exposeInactive = true will display 3 options? active, primed, AND inactive exposeInactive = false will display 2

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7298: Separate Go Unit GHA into individual workflows

2023-01-18 Thread GitBox
zrhoffman commented on code in PR #7298: URL: https://github.com/apache/trafficcontrol/pull/7298#discussion_r1080801830 ## infrastructure/cdn-in-a-box/traffic_ops_integration_test/Dockerfile: ## @@ -71,9 +71,11 @@ COPY ./infrastructure/cdn-in-a-box/traffic_ops/to-access.sh

[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7298: Separate Go Unit GHA into individual workflows

2023-01-18 Thread GitBox
codecov[bot] commented on PR #7298: URL: https://github.com/apache/trafficcontrol/pull/7298#issuecomment-1396426348 #

[GitHub] [trafficcontrol] ericholguin opened a new pull request, #7298: Separate Go Unit GHA into individual workflows

2023-01-18 Thread GitBox
ericholguin opened a new pull request, #7298: URL: https://github.com/apache/trafficcontrol/pull/7298 This PR separates all of the Go unit tests from the go.unit.tests.yml workflow into their own individual workflow files, this allows us to have more granular GHA badges in the

[GitHub] [trafficcontrol] zrhoffman opened a new issue, #7297: TP integration tests fail in CiaB: `Fatal error, run database recovery`

2023-01-18 Thread GitBox
zrhoffman opened a new issue, #7297: URL: https://github.com/apache/trafficcontrol/issues/7297 ## This Bug Report affects these Traffic Control components: - CDN in a Box - Traffic Portal, Traffic Portal integration tests ## Current behavior: Building the

[GitHub] [trafficcontrol] ocket8888 closed issue #7251: CDN-in-a-Box Makefile no longer builds RPMs on non-RHEL systems

2023-01-18 Thread GitBox
ocket closed issue #7251: CDN-in-a-Box Makefile no longer builds RPMs on non-RHEL systems URL: https://github.com/apache/trafficcontrol/issues/7251 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [trafficcontrol] ocket8888 merged pull request #7279: Wrap architecture-getting command in Makefile in Docker command

2023-01-18 Thread GitBox
ocket merged PR #7279: URL: https://github.com/apache/trafficcontrol/pull/7279 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7279: Wrap architecture-getting command in Makefile in Docker command

2023-01-18 Thread GitBox
ocket commented on code in PR #7279: URL: https://github.com/apache/trafficcontrol/pull/7279#discussion_r1073848285 ## infrastructure/cdn-in-a-box/Makefile: ## @@ -35,7 +41,8 @@ PKG_COMMAND := $(TC_DIR)/pkg PKG_FLAGS := -v -$(RHEL_VERSION) BUILD_SUFFIX := _build

[GitHub] [trafficcontrol] ocket8888 opened a new pull request, #7296: Traffic Portal configuration option for Delivery Service active flags

2023-01-18 Thread GitBox
ocket opened a new pull request, #7296: URL: https://github.com/apache/trafficcontrol/pull/7296 This PR adds a new configuration option for Traffic Portal that allows exposing the new DS Active flag states. Disabled by default. ## Which Traffic Control components are

[GitHub] [trafficcontrol] rimashah25 opened a new pull request, #7295: Added description and priority order for Layered Profile in server's form.

2023-01-18 Thread GitBox
rimashah25 opened a new pull request, #7295: URL: https://github.com/apache/trafficcontrol/pull/7295 Added helpful description to understand layered profile ## Which Traffic Control components are affected by this PR? - Traffic Portal ## What is the best

[GitHub] [trafficcontrol] srijeet0406 commented on a diff in pull request #7294: Fix Internal Server Error when GETting sslkeys_expirations endpoint

2023-01-18 Thread GitBox
srijeet0406 commented on code in PR #7294: URL: https://github.com/apache/trafficcontrol/pull/7294#discussion_r1073857066 ## traffic_ops/traffic_ops_golang/trafficvault/backends/postgres/postgres.go: ## @@ -180,7 +180,7 @@ func (p *Postgres) GetExpirationInformation(tx *sql.Tx,

[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7291: Extended LP feature to aggregate params for all profiles.

2023-01-17 Thread GitBox
codecov[bot] commented on PR #7291: URL: https://github.com/apache/trafficcontrol/pull/7291#issuecomment-1386426563 #

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7294: Fix Internal Server Error when GETting sslkeys_expirations endpoint

2023-01-17 Thread GitBox
ocket commented on code in PR #7294: URL: https://github.com/apache/trafficcontrol/pull/7294#discussion_r1073024491 ## traffic_ops/traffic_ops_golang/trafficvault/backends/postgres/postgres.go: ## @@ -180,7 +180,7 @@ func (p *Postgres) GetExpirationInformation(tx *sql.Tx,

[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7294: Fix Internal Server Error when GETting sslkeys_expirations endpoint

2023-01-17 Thread GitBox
codecov[bot] commented on PR #7294: URL: https://github.com/apache/trafficcontrol/pull/7294#issuecomment-1386190430 #

[GitHub] [trafficcontrol] srijeet0406 opened a new pull request, #7294: Fix Internal Server Error when GETting sslkeys_expirations endpoint

2023-01-17 Thread GitBox
srijeet0406 opened a new pull request, #7294: URL: https://github.com/apache/trafficcontrol/pull/7294 This PR closes #7293 ## Which Traffic Control components are affected by this PR? - Traffic Ops ## What is the best way to verify this PR?

[GitHub] [trafficcontrol] ericholguin opened a new issue, #7293: Internal Server Error: GET /api/4.1/sslkey_expirations

2023-01-17 Thread GitBox
ericholguin opened a new issue, #7293: URL: https://github.com/apache/trafficcontrol/issues/7293 ## This Bug Report affects these Traffic Control components: - Traffic Ops ## Current behavior: Making a `GET` request to

[GitHub] [trafficcontrol] ocket8888 opened a new pull request, #7292: TPv2 Cache Groups table/details pages

2023-01-17 Thread GitBox
ocket opened a new pull request, #7292: URL: https://github.com/apache/trafficcontrol/pull/7292 Adds a Cache Group details/creation page to TPv2, and rounds out much of the functionality of the Cache Groups table page. Also fixed the broken "+" FAB buttons on the regions and

[GitHub] [trafficcontrol] kdamichie commented on a diff in pull request #7282: Missing user in logs bug

2023-01-17 Thread GitBox
kdamichie commented on code in PR #7282: URL: https://github.com/apache/trafficcontrol/pull/7282#discussion_r1072597623 ## traffic_ops/traffic_ops_golang/routing/middleware/wrappers.go: ## @@ -188,19 +189,43 @@ func GetWrapAccessLog(secret string) Middleware { } }

[GitHub] [trafficcontrol] serDrem closed pull request #7290: update TM results with hostname from via header, if exists

2023-01-13 Thread GitBox
serDrem closed pull request #7290: update TM results with hostname from via header, if exists URL: https://github.com/apache/trafficcontrol/pull/7290 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [trafficcontrol] rimashah25 closed pull request #7274: Added Layered Profile to TM

2023-01-13 Thread GitBox
rimashah25 closed pull request #7274: Added Layered Profile to TM URL: https://github.com/apache/trafficcontrol/pull/7274 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [trafficcontrol] rimashah25 commented on pull request #7274: Added Layered Profile to TM

2023-01-13 Thread GitBox
rimashah25 commented on PR #7274: URL: https://github.com/apache/trafficcontrol/pull/7274#issuecomment-1382621351 Closed this PR since I developed with a difference [solution](https://github.com/apache/trafficcontrol/pull/7291) -- This is an automated message from the Apache Git

[GitHub] [trafficcontrol] rimashah25 opened a new pull request, #7291: Extended LP feature to aggregate params for all profiles.

2023-01-13 Thread GitBox
rimashah25 opened a new pull request, #7291: URL: https://github.com/apache/trafficcontrol/pull/7291 Extends layered profile feature in traffic ops to create a monitoring.json that contains all layered profiles(P1+P2+P3) and aggregates parameters for LP features. ##

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7290: update TM results with hostname from via header, if exists

2023-01-13 Thread GitBox
zrhoffman commented on code in PR #7290: URL: https://github.com/apache/trafficcontrol/pull/7290#discussion_r1070039804 ## traffic_monitor/cache/astats.go: ## @@ -116,8 +117,23 @@ func astatsParse(cacheName string, rdr io.Reader, pollCTX interface{}) (Statisti

[GitHub] [trafficcontrol] zrhoffman merged pull request #7277: t3c remapdotconfig: remove skip check at mids for nocache/live

2023-01-13 Thread GitBox
zrhoffman merged PR #7277: URL: https://github.com/apache/trafficcontrol/pull/7277 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] github-code-scanning[bot] commented on a diff in pull request #7290: update TM results with hostname from via header, if exists

2023-01-13 Thread GitBox
github-code-scanning[bot] commented on code in PR #7290: URL: https://github.com/apache/trafficcontrol/pull/7290#discussion_r1069781605 ## traffic_monitor/cache/stats_over_http.go: ## @@ -72,6 +73,14 @@ ctx := pollCTX.(*poller.HTTPPollCtx) + via :=

[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7290: update TM results with hostname from via header, if exists

2023-01-13 Thread GitBox
codecov[bot] commented on PR #7290: URL: https://github.com/apache/trafficcontrol/pull/7290#issuecomment-1382191853 #

[GitHub] [trafficcontrol] serDrem opened a new pull request, #7290: update TM results with hostname from via header, if exists

2023-01-13 Thread GitBox
serDrem opened a new pull request, #7290: URL: https://github.com/apache/trafficcontrol/pull/7290 update TM results with hostname from via header, if exists, this is needed to support multiple server with the same IP ## Which Traffic Control components are affected by

[GitHub] [trafficcontrol] ocket8888 commented on issue #7289: Add X-Forwarded-For for TP proxy and logs

2023-01-12 Thread GitBox
ocket commented on issue #7289: URL: https://github.com/apache/trafficcontrol/issues/7289#issuecomment-1381234259 The standard header for containing that kind of information is [`Forwarded`](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Forwarded) - described in [RFC7239

[GitHub] [trafficcontrol] jhg03a opened a new issue, #7289: Add X-Forwarded-For for TP proxy and logs

2023-01-12 Thread GitBox
jhg03a opened a new issue, #7289: URL: https://github.com/apache/trafficcontrol/issues/7289 ## This Improvement request (usability, performance, tech debt, etc.) affects these Traffic Control components: - Traffic Portal - Traffic Ops ## Current behavior:

[GitHub] [trafficcontrol] srijeet0406 commented on a diff in pull request #7282: Missing user in logs bug

2023-01-12 Thread GitBox
srijeet0406 commented on code in PR #7282: URL: https://github.com/apache/trafficcontrol/pull/7282#discussion_r1068733569 ## traffic_ops/traffic_ops_golang/routing/middleware/wrappers.go: ## @@ -27,6 +27,7 @@ import ( "encoding/base64" "errors" "fmt" +

[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7288: Move assert functionality

2023-01-12 Thread GitBox
codecov[bot] commented on PR #7288: URL: https://github.com/apache/trafficcontrol/pull/7288#issuecomment-1380927995 #

[GitHub] [trafficcontrol] ericholguin opened a new pull request, #7288: Move assert functionality

2023-01-12 Thread GitBox
ericholguin opened a new pull request, #7288: URL: https://github.com/apache/trafficcontrol/pull/7288 Move go testing assert functionality to lib/go-util so it can be shared by other tests Removes duplicate assert functionality that traffic stats uses ## Which

[GitHub] [trafficcontrol] zrhoffman merged pull request #7286: Ansible playbook API switch to variable

2023-01-12 Thread GitBox
zrhoffman merged PR #7286: URL: https://github.com/apache/trafficcontrol/pull/7286 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] shamrickus merged pull request #7219: TP Utility types

2023-01-12 Thread GitBox
shamrickus merged PR #7219: URL: https://github.com/apache/trafficcontrol/pull/7219 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7287: Fix t3c test duplication and upgrade to v4 (fix conflicts)

2023-01-11 Thread GitBox
codecov[bot] commented on PR #7287: URL: https://github.com/apache/trafficcontrol/pull/7287#issuecomment-1379669083 #

[GitHub] [trafficcontrol] shamrickus merged pull request #7284: Bump debug and chromedriver in /traffic_portal/test/integration

2023-01-11 Thread GitBox
shamrickus merged PR #7284: URL: https://github.com/apache/trafficcontrol/pull/7284 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] jhowar201 opened a new pull request, #7286: Ansible playbook API switch to variable

2023-01-11 Thread GitBox
jhowar201 opened a new pull request, #7286: URL: https://github.com/apache/trafficcontrol/pull/7286 Fixing API endpoints in the Ansible playbooks for snapshot against to_api as well as removing some old syntax that causes newer ansible versions to fail. ## Which Traffic Control

[GitHub] [trafficcontrol] rawlinp commented on pull request #7274: Added Layered Profile to TM

2023-01-11 Thread GitBox
rawlinp commented on PR #7274: URL: https://github.com/apache/trafficcontrol/pull/7274#issuecomment-1379459891 That might be problematic because after upgrading TO and snapshotting the CDN, all old versions of TM will fail to unmarshal the new monitoring.json due to it being a breaking

[GitHub] [trafficcontrol] ericholguin commented on pull request #7271: Clean up unused code

2023-01-11 Thread GitBox
ericholguin commented on PR #7271: URL: https://github.com/apache/trafficcontrol/pull/7271#issuecomment-1379431918 > I do use this convert_profile when I upgrade ATS. I have those rules still in use on our local repository. Can we expand on "outdated" ? > > ``` >

[GitHub] [trafficcontrol] zrhoffman merged pull request #7285: Added package procsp-ng to TM, TO, TP, TR, TS and cache docker images.

2023-01-11 Thread GitBox
zrhoffman merged PR #7285: URL: https://github.com/apache/trafficcontrol/pull/7285 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7274: Added Layered Profile to TM

2023-01-11 Thread GitBox
codecov[bot] commented on PR #7274: URL: https://github.com/apache/trafficcontrol/pull/7274#issuecomment-1379362200 #

[GitHub] [trafficcontrol] ocket8888 commented on pull request #7219: TP Utility types

2023-01-11 Thread GitBox
ocket commented on PR #7219: URL: https://github.com/apache/trafficcontrol/pull/7219#issuecomment-1379357987 note that over 10,000 lines of additions and over 8,000 lines of deletions are just from `package-lock.json`. All I did was, after resolving conflicts, `rm package-lock.json &&

[GitHub] [trafficcontrol] rimashah25 commented on pull request #7274: Added Layered Profile to TM

2023-01-11 Thread GitBox
rimashah25 commented on PR #7274: URL: https://github.com/apache/trafficcontrol/pull/7274#issuecomment-1379357372 > Is the plan for this to update `monitoring.json` so each server's profile name is an array of profile names instead? Will that only happen for this API in v5.0, while pre-5.0

[GitHub] [trafficcontrol] rimashah25 opened a new pull request, #7285: Added package procsp-ng to TM, TO, TP, TR, TS and cache docker images.

2023-01-11 Thread GitBox
rimashah25 opened a new pull request, #7285: URL: https://github.com/apache/trafficcontrol/pull/7285 Added package procsp-ng to TM, TO, TP, TR, TS and cache docker images as it contains `pkill` cmd that base image: `rockylinux` doesn't include. ## Which Traffic Control

[GitHub] [trafficcontrol] ocket8888 merged pull request #7281: Docker go tests runners: Unwrap commands from bash shell to inherit environment variables

2023-01-11 Thread GitBox
ocket merged PR #7281: URL: https://github.com/apache/trafficcontrol/pull/7281 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7284: Bump debug and chromedriver in /traffic_portal/test/integration

2023-01-11 Thread GitBox
codecov[bot] commented on PR #7284: URL: https://github.com/apache/trafficcontrol/pull/7284#issuecomment-1379271027 #

[GitHub] [trafficcontrol] dependabot[bot] opened a new pull request, #7284: Bump debug and chromedriver in /traffic_portal/test/integration

2023-01-11 Thread GitBox
dependabot[bot] opened a new pull request, #7284: URL: https://github.com/apache/trafficcontrol/pull/7284 Bumps [debug](https://github.com/debug-js/debug) to 4.3.4 and updates ancestor dependency [chromedriver](https://github.com/giggio/node-chromedriver). These dependencies need to be

[GitHub] [trafficcontrol] ocket8888 merged pull request #7276: Rollback to Node to 16 for Centos 7 support

2023-01-11 Thread GitBox
ocket merged PR #7276: URL: https://github.com/apache/trafficcontrol/pull/7276 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] zrhoffman merged pull request #7283: Update Go version to 1.19.5

2023-01-11 Thread GitBox
zrhoffman merged PR #7283: URL: https://github.com/apache/trafficcontrol/pull/7283 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] srijeet0406 merged pull request #7268: Fix edge cases for DSR creation, update, and deletion

2023-01-11 Thread GitBox
srijeet0406 merged PR #7268: URL: https://github.com/apache/trafficcontrol/pull/7268 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] smalenfant commented on pull request #7271: Clean up unused code

2023-01-11 Thread GitBox
smalenfant commented on PR #7271: URL: https://github.com/apache/trafficcontrol/pull/7271#issuecomment-1379143961 I use the following in out "upgrade_ats.yml" Ansible playbook. I don't think it needs to be part of Traffic Ops build. I would vote to move this into the "tools" folder.

[GitHub] [trafficcontrol] smalenfant commented on pull request #7271: Clean up unused code

2023-01-11 Thread GitBox
smalenfant commented on PR #7271: URL: https://github.com/apache/trafficcontrol/pull/7271#issuecomment-1379120238 > > Did you consult with Evan Zelkowitz about the removal of `convert_profile`? > > Yes, he said we have not been using it, however maybe @smalenfant may have a

[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7283: Update Go version to 1.19.5

2023-01-11 Thread GitBox
codecov[bot] commented on PR #7283: URL: https://github.com/apache/trafficcontrol/pull/7283#issuecomment-1379079637 #

[GitHub] [trafficcontrol] asf-ci opened a new pull request, #7283: Update Go version to 1.19.5

2023-01-11 Thread GitBox
asf-ci opened a new pull request, #7283: URL: https://github.com/apache/trafficcontrol/pull/7283 ## What does this PR (Pull Request) do? This PR makes the Go components of Traffic Control build using Go version 1.19.5 and updates the `golang.org/x/` dependencies. See the Go

[GitHub] [trafficcontrol] zrhoffman closed pull request #7275: Update Go version to 1.19.5

2023-01-11 Thread GitBox
zrhoffman closed pull request #7275: Update Go version to 1.19.5 URL: https://github.com/apache/trafficcontrol/pull/7275 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7277: t3c remapdotconfig: remove skip check at mids for nocache/live

2023-01-11 Thread GitBox
codecov[bot] commented on PR #7277: URL: https://github.com/apache/trafficcontrol/pull/7277#issuecomment-1379032999 #

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7281: Docker go tests runners: Unwrap commands from bash shell to inherit environment variables

2023-01-11 Thread GitBox
ocket commented on code in PR #7281: URL: https://github.com/apache/trafficcontrol/pull/7281#discussion_r1067170884 ## traffic_ops/app/bin/tests/Dockerfile-golangtest: ## @@ -20,6 +20,7 @@ ARG DIR=github.com/apache/trafficcontrol COPY --from=get-go /usr/local/go

[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7282: Missing user in logs bug

2023-01-11 Thread GitBox
codecov[bot] commented on PR #7282: URL: https://github.com/apache/trafficcontrol/pull/7282#issuecomment-1379013559 #

[GitHub] [trafficcontrol] ocket8888 merged pull request #7278: CDN-in-a-Box in GHA: Retry GitHub API request 10 times

2023-01-11 Thread GitBox
ocket merged PR #7278: URL: https://github.com/apache/trafficcontrol/pull/7278 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] kdamichie opened a new pull request, #7282: Missing user in logs bug

2023-01-10 Thread GitBox
kdamichie opened a new pull request, #7282: URL: https://github.com/apache/trafficcontrol/pull/7282 ## Which Traffic Control components are affected by this PR? - Documentation - Traffic Control Cache Config (`t3c`, formerly ORT) - Traffic Control Health

[GitHub] [trafficcontrol] zrhoffman merged pull request #7280: TM: update CDN name in shared config when overriding it

2023-01-10 Thread GitBox
zrhoffman merged PR #7280: URL: https://github.com/apache/trafficcontrol/pull/7280 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] rawlinp commented on pull request #7274: Added Layered Profile to TM

2023-01-10 Thread GitBox
rawlinp commented on PR #7274: URL: https://github.com/apache/trafficcontrol/pull/7274#issuecomment-1377987921 Is the plan for this to update `monitoring.json` so each server's profile name is an array of profile names instead? Will that only happen for this API in v5.0, while pre-5.0 API

[GitHub] [trafficcontrol] zrhoffman opened a new pull request, #7281: Docker go tests runners: Unwrap commands from bash shell to inherit environment variables

2023-01-10 Thread GitBox
zrhoffman opened a new pull request, #7281: URL: https://github.com/apache/trafficcontrol/pull/7281 This PR fixes an issue running the TO or TM unit tests, where `go` and `GOPATH/bin` are not in the `PATH`. ## Which Traffic Control components are affected by this PR?

[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7280: TM: update CDN name in shared config when overriding it

2023-01-10 Thread GitBox
codecov[bot] commented on PR #7280: URL: https://github.com/apache/trafficcontrol/pull/7280#issuecomment-1377976593 #

[GitHub] [trafficcontrol] rawlinp opened a new pull request, #7280: TM: update CDN name in shared config when overriding it

2023-01-10 Thread GitBox
rawlinp opened a new pull request, #7280: URL: https://github.com/apache/trafficcontrol/pull/7280 If there's a mismatch between the CDN name found in Traffic Ops and the one defined in traffic_ops.cfg, make sure the CDN name from Traffic Ops also overrides the shared "opsConfig" (which is

[GitHub] [trafficcontrol] zrhoffman opened a new pull request, #7279: Wrap architecture-getting command in Makefile in Docker command

2023-01-10 Thread GitBox
zrhoffman opened a new pull request, #7279: URL: https://github.com/apache/trafficcontrol/pull/7279 This pr fixes #7251 by making the `rpm` command that the CDN in a Box Makefile uses to get the host architecture run within `docker`. ## Which Traffic Control components

[GitHub] [trafficcontrol] zrhoffman opened a new pull request, #7278: CDN-in-a-Box in GHA: Retry GitHub API request 10 times

2023-01-10 Thread GitBox
zrhoffman opened a new pull request, #7278: URL: https://github.com/apache/trafficcontrol/pull/7278 At some point recently, GitHub started giving unxpected response a good amount of the time, like 20% of the time in the *CDN-in-a-Box CI* `build-rpms` action. This PR makes it retry

[GitHub] [trafficcontrol] traeak opened a new pull request, #7277: t3c remapdotconfig: remove skip check at mids for nocache/live

2023-01-10 Thread GitBox
traeak opened a new pull request, #7277: URL: https://github.com/apache/trafficcontrol/pull/7277 This bug was introduced with the t3c mustache template PR #7155. Whether or not a DS should have a remap.config line is to be determined by topology. ## Which Traffic

[GitHub] [trafficcontrol] shamrickus commented on a diff in pull request #7276: Rollback to Node to 16 for Centos 7 support

2023-01-10 Thread GitBox
shamrickus commented on code in PR #7276: URL: https://github.com/apache/trafficcontrol/pull/7276#discussion_r1066295389 ## traffic_portal/test/integration/config.json: ## @@ -29,8 +29,8 @@ "stopSpecOnExpectationFailure": true }, "params": { -"apiUrl": "

[GitHub] [trafficcontrol] shamrickus merged pull request #7227: Traffic Portal library typings

2023-01-10 Thread GitBox
shamrickus merged PR #7227: URL: https://github.com/apache/trafficcontrol/pull/7227 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7276: Rollback to Node to 16 for Centos 7 support

2023-01-10 Thread GitBox
ocket commented on code in PR #7276: URL: https://github.com/apache/trafficcontrol/pull/7276#discussion_r1066288442 ## traffic_portal/test/integration/config.json: ## @@ -29,8 +29,8 @@ "stopSpecOnExpectationFailure": true }, "params": { -"apiUrl": "

[GitHub] [trafficcontrol] shamrickus opened a new pull request, #7276: Rollback to Node to 16 for Centos 7 support

2023-01-10 Thread GitBox
shamrickus opened a new pull request, #7276: URL: https://github.com/apache/trafficcontrol/pull/7276 This PR downgrades all node version to 16 as Centos 7 does not support 18 [yet](https://github.com/nodesource/distributions/issues/1492) ## Which Traffic Control

  1   2   3   4   5   6   7   8   9   10   >