[GitHub] moltzaum opened a new issue #3214: On username conflict `PUT users/:id` hangs and curl gets empty response

2019-01-14 Thread GitBox
moltzaum opened a new issue #3214: On username conflict `PUT users/:id` hangs and curl gets empty response URL: https://github.com/apache/trafficcontrol/issues/3214 This issue documents a bug with the PUT users/:id endpoint, but is not critical enough to fix in perl IMO. It should be resol

[GitHub] moltzaum commented on issue #3214: On username conflict `PUT users/:id` hangs and curl gets empty response

2019-01-14 Thread GitBox
moltzaum commented on issue #3214: On username conflict `PUT users/:id` hangs and curl gets empty response URL: https://github.com/apache/trafficcontrol/issues/3214#issuecomment-454212410 Some reason I didn't realize it had already been converted. I'll take a look at the code itself and te

[GitHub] Shihta commented on issue #3212: Docker build error on mac

2019-01-14 Thread GitBox
Shihta commented on issue #3212: Docker build error on mac URL: https://github.com/apache/trafficcontrol/issues/3212#issuecomment-454216538 > traffic_router.rpm: no such file or directory That means you didn't build the package. Refer to [here](https://github.com/apache/trafficco

[GitHub] Shihta commented on issue #3193: CIAB: Update X509 cert generation, add certs to TV, fix TR tomcat native.

2019-01-14 Thread GitBox
Shihta commented on issue #3193: CIAB: Update X509 cert generation, add certs to TV, fix TR tomcat native. URL: https://github.com/apache/trafficcontrol/pull/3193#issuecomment-454285216 This commit doesn't contain edge server related config. e.g. ``` $ curl -k -I -L https://vid

[GitHub] Shihta opened a new issue #3215: CIAB: edge server returns "Cycle Prohibited" after add a new Delivery Service

2019-01-14 Thread GitBox
Shihta opened a new issue #3215: CIAB: edge server returns "Cycle Prohibited" after add a new Delivery Service URL: https://github.com/apache/trafficcontrol/issues/3215 I built a CIAB environment by using the latest commit (5ca7cef3ec6b6625e1bdfda962edef40c69c40fd) My steps are show

[GitHub] Shihta edited a comment on issue #3193: CIAB: Update X509 cert generation, add certs to TV, fix TR tomcat native.

2019-01-14 Thread GitBox
Shihta edited a comment on issue #3193: CIAB: Update X509 cert generation, add certs to TV, fix TR tomcat native. URL: https://github.com/apache/trafficcontrol/pull/3193#issuecomment-454285216 This commit doesn't contain edge server related config. e.g. ``` $ curl -k -I -L http

[GitHub] felicks commented on issue #3212: Docker build error on mac

2019-01-15 Thread GitBox
felicks commented on issue #3212: Docker build error on mac URL: https://github.com/apache/trafficcontrol/issues/3212#issuecomment-454374100 thanks @Shihta I tried to run `make ` but I got the following error: `The build area has been initialized. Building the rpm.

[GitHub] ocket8888 opened a new pull request #3216: Fixed server rows with errors not being appropriately highlighted in TM table

2019-01-15 Thread GitBox
ocket opened a new pull request #3216: Fixed server rows with errors not being appropriately highlighted in TM table URL: https://github.com/apache/trafficcontrol/pull/3216 ## What does this PR do? Fixes #3201 ## Which TC components are affected by this PR? - [ ] Docum

[GitHub] asfgit commented on issue #3216: Fixed server rows with errors not being appropriately highlighted in TM table

2019-01-15 Thread GitBox
asfgit commented on issue #3216: Fixed server rows with errors not being appropriately highlighted in TM table URL: https://github.com/apache/trafficcontrol/pull/3216#issuecomment-454445602 Refer to this link for build results (access rights to CI server needed): https://builds.apac

[GitHub] asfgit commented on issue #3213: Add CIAB Dynamic DNS

2019-01-15 Thread GitBox
asfgit commented on issue #3213: Add CIAB Dynamic DNS URL: https://github.com/apache/trafficcontrol/pull/3213#issuecomment-454447304 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/3052/ Test PASSed. --

[GitHub] ocket8888 commented on issue #3215: CIAB: edge server returns "Cycle Prohibited" after add a new Delivery Service

2019-01-15 Thread GitBox
ocket commented on issue #3215: CIAB: edge server returns "Cycle Prohibited" after add a new Delivery Service URL: https://github.com/apache/trafficcontrol/issues/3215#issuecomment-454452189 It is a known issue that having multiple Delivery Services with the same origin FQDN causes und

[GitHub] ocket8888 commented on issue #3212: Docker build error on mac

2019-01-15 Thread GitBox
ocket commented on issue #3212: Docker build error on mac URL: https://github.com/apache/trafficcontrol/issues/3212#issuecomment-454453380 It seems you're running `make` from outside a git repository. Did you clone the repository or download a `.zip` file of the repository's current co

[GitHub] ocket8888 commented on issue #3207: CIAB: edge server doesn't automatically update config

2019-01-15 Thread GitBox
ocket commented on issue #3207: CIAB: edge server doesn't automatically update config URL: https://github.com/apache/trafficcontrol/issues/3207#issuecomment-454453754 I think that line was meant to to aid testing and somehow found its way into a commit. We should probably remove that l

[GitHub] ocket8888 commented on issue #3193: CIAB: Update X509 cert generation, add certs to TV, fix TR tomcat native.

2019-01-15 Thread GitBox
ocket commented on issue #3193: CIAB: Update X509 cert generation, add certs to TV, fix TR tomcat native. URL: https://github.com/apache/trafficcontrol/pull/3193#issuecomment-454465714 docker-compose doesn't need a port mapping for that, because port exposures refer to host port connec

[GitHub] ocket8888 edited a comment on issue #3193: CIAB: Update X509 cert generation, add certs to TV, fix TR tomcat native.

2019-01-15 Thread GitBox
ocket edited a comment on issue #3193: CIAB: Update X509 cert generation, add certs to TV, fix TR tomcat native. URL: https://github.com/apache/trafficcontrol/pull/3193#issuecomment-454465714 docker-compose doesn't need a port mapping for that, because port exposures refer to host port

[GitHub] rawlinp opened a new issue #3217: Delivery Service Request UI issues

2019-01-15 Thread GitBox
rawlinp opened a new issue #3217: Delivery Service Request UI issues URL: https://github.com/apache/trafficcontrol/issues/3217 In Traffic Portal, when you fulfill a `delete` Delivery Service Request, the UI takes you back to the `https://tp.example.com/#!/delivery-service-requests` view th

[GitHub] JBevillC commented on issue #3213: Add CIAB Dynamic DNS

2019-01-15 Thread GitBox
JBevillC commented on issue #3213: Add CIAB Dynamic DNS URL: https://github.com/apache/trafficcontrol/pull/3213#issuecomment-454476326 I have reviewed this PR and the method used to convert from static to dynamic IPs is sound. Since nsupdate and DDNS is used to push container IP configura

[GitHub] moltzaum opened a new pull request #3218: Bugfixes for users endpoint

2019-01-15 Thread GitBox
moltzaum opened a new pull request #3218: Bugfixes for users endpoint URL: https://github.com/apache/trafficcontrol/pull/3218 What does this PR do? Fixes #3117 Fixes #3118 Fixes #3214 This PR does not include documentation updates, so doc updates will follow.

[GitHub] rawlinp opened a new issue #3219: TO-golang users API "rolename" regression

2019-01-15 Thread GitBox
rawlinp opened a new issue #3219: TO-golang users API "rolename" regression URL: https://github.com/apache/trafficcontrol/issues/3219 I fixed a bug a while back that was caused by wrong capitalization of the `"roleName"` field in the `/api/1.x/user/current` API endpoint: #2535. This bug ha

[GitHub] asfgit commented on issue #3218: Bugfixes for users endpoint

2019-01-15 Thread GitBox
asfgit commented on issue #3218: Bugfixes for users endpoint URL: https://github.com/apache/trafficcontrol/pull/3218#issuecomment-454480878 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/3053/ Test PASSed.

[GitHub] JBevillC commented on issue #3213: Add CIAB Dynamic DNS

2019-01-15 Thread GitBox
JBevillC commented on issue #3213: Add CIAB Dynamic DNS URL: https://github.com/apache/trafficcontrol/pull/3213#issuecomment-454480827 Additionally, docker-compose restarts (with persistence) has never worked with CiaB. Each container will have to be updated to support persistence for tha

[GitHub] rawlinp opened a new issue #3220: TO API 2.0 should use consistent field names for all the "user" endpoints

2019-01-15 Thread GitBox
rawlinp opened a new issue #3220: TO API 2.0 should use consistent field names for all the "user" endpoints URL: https://github.com/apache/trafficcontrol/issues/3220 In version 1.x, the various user endpoints use one of either "roleName" or "rolename". In TO API 2.0, all the user endpoints

[GitHub] asfgit commented on issue #3218: Bugfixes for users endpoint

2019-01-15 Thread GitBox
asfgit commented on issue #3218: Bugfixes for users endpoint URL: https://github.com/apache/trafficcontrol/pull/3218#issuecomment-454487743 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/3054/ Test PASSed.

[GitHub] ocket8888 commented on issue #3207: CIAB: edge server doesn't automatically update config

2019-01-15 Thread GitBox
ocket commented on issue #3207: CIAB: edge server doesn't automatically update config URL: https://github.com/apache/trafficcontrol/issues/3207#issuecomment-454497888 So I actually still have a crontab despite that line. The issue I'm hitting seems to be within ORT itself. See, it look

[GitHub] jhg03a opened a new issue #3221: Http to Https Protocol on DNS Delivery Services Broken

2019-01-15 Thread GitBox
jhg03a opened a new issue #3221: Http to Https Protocol on DNS Delivery Services Broken URL: https://github.com/apache/trafficcontrol/issues/3221 Found in 3.0.0-9870.872decc9.el7. If you create a DS with routing type DNS and protocol HTTP to HTTPS and make a HTTP query you will get an ATS

[GitHub] dangogh merged pull request #3213: Add CIAB Dynamic DNS

2019-01-15 Thread GitBox
dangogh merged pull request #3213: Add CIAB Dynamic DNS URL: https://github.com/apache/trafficcontrol/pull/3213 As this is a foreign pull request (from a fork), the diff has been sent to your commit mailing list, comm...@trafficcontrol.apache.org --

[GitHub] ocket8888 opened a new pull request #3222: ORT.py now uses the official ATC client

2019-01-15 Thread GitBox
ocket opened a new pull request #3222: ORT.py now uses the official ATC client URL: https://github.com/apache/trafficcontrol/pull/3222 ## What does this PR do? Previously, the Python-based ORT implementation had re-written a bunch of functionality already present in the Python clien

[GitHub] asfgit commented on issue #3222: ORT.py now uses the official ATC client

2019-01-15 Thread GitBox
asfgit commented on issue #3222: ORT.py now uses the official ATC client URL: https://github.com/apache/trafficcontrol/pull/3222#issuecomment-454513371 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/3055/ T

[GitHub] mitchell852 commented on issue #2418: TP - Bypass destination requires protocol

2019-01-15 Thread GitBox
mitchell852 commented on issue #2418: TP - Bypass destination requires protocol URL: https://github.com/apache/trafficcontrol/issues/2418#issuecomment-454532364 >>> The current implementation in the portal requires one to specify the protocol on a bypass destination for HTTP delivery servic

[GitHub] mitchell852 edited a comment on issue #2418: TP - Bypass destination requires protocol

2019-01-15 Thread GitBox
mitchell852 edited a comment on issue #2418: TP - Bypass destination requires protocol URL: https://github.com/apache/trafficcontrol/issues/2418#issuecomment-454532364 > The current implementation in the portal requires one to specify the protocol on a bypass destination for HTTP delivery

[GitHub] mitchell852 commented on issue #2418: TP - Bypass destination requires protocol

2019-01-15 Thread GitBox
mitchell852 commented on issue #2418: TP - Bypass destination requires protocol URL: https://github.com/apache/trafficcontrol/issues/2418#issuecomment-454533322 Can this be closed as a bug @elsloo and maybe reopen another issue with the part about > Perhaps a bypass destination shoul

[GitHub] mitchell852 edited a comment on issue #2418: TP - Bypass destination requires protocol

2019-01-15 Thread GitBox
mitchell852 edited a comment on issue #2418: TP - Bypass destination requires protocol URL: https://github.com/apache/trafficcontrol/issues/2418#issuecomment-454533322 Can this be closed as a bug @elsloo and maybe reopen another issue with the part about > Perhaps a bypass destinati

[GitHub] mitchell852 commented on issue #2426: Revalidate builds invalid regexes on ANY_MAP Delivery Services

2019-01-15 Thread GitBox
mitchell852 commented on issue #2426: Revalidate builds invalid regexes on ANY_MAP Delivery Services URL: https://github.com/apache/trafficcontrol/issues/2426#issuecomment-454534643 The API will no longer allow you to create an "invalidate content" request on a ds that has no origin defin

[GitHub] ocket8888 commented on issue #3207: CIAB: edge server doesn't automatically update config

2019-01-15 Thread GitBox
ocket commented on issue #3207: CIAB: edge server doesn't automatically update config URL: https://github.com/apache/trafficcontrol/issues/3207#issuecomment-454535808 That was part of the issue, but apparently HTTPS connections need to be specifically enabled using a line in a configur

[GitHub] mitchell852 commented on issue #3067: Add cachegroup should not default to deep routing enabled

2019-01-15 Thread GitBox
mitchell852 commented on issue #3067: Add cachegroup should not default to deep routing enabled URL: https://github.com/apache/trafficcontrol/issues/3067#issuecomment-454540286 ^^ how does that sound @dneuman64 ? This is an a

[GitHub] ocket8888 commented on issue #3218: Bugfixes for users endpoint

2019-01-15 Thread GitBox
ocket commented on issue #3218: Bugfixes for users endpoint URL: https://github.com/apache/trafficcontrol/pull/3218#issuecomment-454567071 So to be clear does this change let people update users by submitting a `PUT` request to `/api/1.x/users` or does it require an integral, unique id

[GitHub] moltzaum commented on issue #2338: Add TO Go users

2019-01-15 Thread GitBox
moltzaum commented on issue #2338: Add TO Go users URL: https://github.com/apache/trafficcontrol/pull/2338#issuecomment-454571306 Here is the other users endpoint PR that was merged: #2846 This is an automated message from the

[GitHub] mitchell852 closed pull request #2338: Add TO Go users

2019-01-15 Thread GitBox
mitchell852 closed pull request #2338: Add TO Go users URL: https://github.com/apache/trafficcontrol/pull/2338 As this is a foreign pull request (from a fork), the diff has been sent to your commit mailing list, comm...@trafficcontrol.apache.org ---

[GitHub] mitchell852 edited a comment on issue #2338: Add TO Go users

2019-01-15 Thread GitBox
mitchell852 edited a comment on issue #2338: Add TO Go users URL: https://github.com/apache/trafficcontrol/pull/2338#issuecomment-454571258 @moltzaum - what PR did you have that implemented this? This is an automated messa

[GitHub] mitchell852 commented on issue #2338: Add TO Go users

2019-01-15 Thread GitBox
mitchell852 commented on issue #2338: Add TO Go users URL: https://github.com/apache/trafficcontrol/pull/2338#issuecomment-454571258 @moltzaum - what PR did you have that addressed this? This is an automated message from t

[GitHub] moltzaum commented on issue #3218: Bugfixes for users endpoint

2019-01-15 Thread GitBox
moltzaum commented on issue #3218: Bugfixes for users endpoint URL: https://github.com/apache/trafficcontrol/pull/3218#issuecomment-454574415 Yes The way all endpoints work currently for golang endpoints is that both path and query parameters are supported for GET, PUT and DELETE (PO

[GitHub] rivasj opened a new issue #3223: Cannot add DS targets to steerings DS

2019-01-15 Thread GitBox
rivasj opened a new issue #3223: Cannot add DS targets to steerings DS URL: https://github.com/apache/trafficcontrol/issues/3223 Trying to add a target DS to a steering DS via TP results in the following error: json: cannot unmarshal string into Go struct field TOSteeringTargetV11.va

[GitHub] rivasj opened a new pull request #3224: fixes #3223. updated type of SteeringTargetNullable.Value to JSONIntStr

2019-01-15 Thread GitBox
rivasj opened a new pull request #3224: fixes #3223. updated type of SteeringTargetNullable.Value to JSONIntStr URL: https://github.com/apache/trafficcontrol/pull/3224 What does this PR do? updated type of SteeringTargetNullable.Value to JSONIntStr Fixes #3223 Whi

[GitHub] asfgit commented on issue #3224: fixes #3223. updated type of SteeringTargetNullable.Value to JSONIntStr

2019-01-15 Thread GitBox
asfgit commented on issue #3224: fixes #3223. updated type of SteeringTargetNullable.Value to JSONIntStr URL: https://github.com/apache/trafficcontrol/pull/3224#issuecomment-454586171 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org

[GitHub] asfgit commented on issue #3224: fixes #3223. updated type of SteeringTargetNullable.Value to JSONIntStr

2019-01-15 Thread GitBox
asfgit commented on issue #3224: fixes #3223. updated type of SteeringTargetNullable.Value to JSONIntStr URL: https://github.com/apache/trafficcontrol/pull/3224#issuecomment-454588477 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org

[GitHub] asfgit commented on issue #3224: fixes #3223. updated type of SteeringTargetNullable.Value to JSONIntStr

2019-01-15 Thread GitBox
asfgit commented on issue #3224: fixes #3223. updated type of SteeringTargetNullable.Value to JSONIntStr URL: https://github.com/apache/trafficcontrol/pull/3224#issuecomment-454590708 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org

[GitHub] rob05c commented on issue #3224: fixes #3223. updated type of SteeringTargetNullable.Value to JSONIntStr

2019-01-15 Thread GitBox
rob05c commented on issue #3224: fixes #3223. updated type of SteeringTargetNullable.Value to JSONIntStr URL: https://github.com/apache/trafficcontrol/pull/3224#issuecomment-454593384 For the record, the API Docs define this endpoint as taking a number, not a string (which the Portal chang

[GitHub] rob05c closed issue #3223: Cannot add DS targets to steerings DS

2019-01-15 Thread GitBox
rob05c closed issue #3223: Cannot add DS targets to steerings DS URL: https://github.com/apache/trafficcontrol/issues/3223 This is an automated message from the Apache Git Service. To respond to the message, please log on Git

[GitHub] rob05c merged pull request #3224: fixes #3223. updated type of SteeringTargetNullable.Value to JSONIntStr

2019-01-15 Thread GitBox
rob05c merged pull request #3224: fixes #3223. updated type of SteeringTargetNullable.Value to JSONIntStr URL: https://github.com/apache/trafficcontrol/pull/3224 As this is a foreign pull request (from a fork), the diff has been sent to your commit mailing list, comm...@trafficcontrol.apa

[GitHub] rob05c merged pull request #3216: Fixed server rows with errors not being appropriately highlighted in TM table

2019-01-15 Thread GitBox
rob05c merged pull request #3216: Fixed server rows with errors not being appropriately highlighted in TM table URL: https://github.com/apache/trafficcontrol/pull/3216 As this is a foreign pull request (from a fork), the diff has been sent to your commit mailing list, comm...@trafficcontr

[GitHub] rob05c closed issue #3201: Traffic Monitor UI no longer visually indicates when cache is down

2019-01-15 Thread GitBox
rob05c closed issue #3201: Traffic Monitor UI no longer visually indicates when cache is down URL: https://github.com/apache/trafficcontrol/issues/3201 This is an automated message from the Apache Git Service. To respond to

[GitHub] jhg03a opened a new issue #3225: Remove CacheURL Delivery Service Field

2019-01-15 Thread GitBox
jhg03a opened a new issue #3225: Remove CacheURL Delivery Service Field URL: https://github.com/apache/trafficcontrol/issues/3225 CacheURL was a plugin that was deprecated in ATS6 and removed in ATS7. ATS6 is now dead. We should remove all traces of cacheURL from the TO API, TODB Databas

[GitHub] mitchell852 commented on issue #3197: Calendar widget for DNSSEC/KSK date selection

2019-01-16 Thread GitBox
mitchell852 commented on issue #3197: Calendar widget for DNSSEC/KSK date selection URL: https://github.com/apache/trafficcontrol/pull/3197#issuecomment-454810145 @chadgilloth - is this "effective date" UTC or local date/time? it seems like everything else in TP is UTC so can you make sure

[GitHub] mitchell852 opened a new issue #3226: TP: roles should be sorted in order of priv level

2019-01-16 Thread GitBox
mitchell852 opened a new issue #3226: TP: roles should be sorted in order of priv level URL: https://github.com/apache/trafficcontrol/issues/3226 https://tp.domain.net/#!/roles roles used to be sorted in descending order based on priv level. this was also true for all the role drop

[GitHub] mitchell852 commented on issue #3219: TO-golang users API "rolename" regression

2019-01-16 Thread GitBox
mitchell852 commented on issue #3219: TO-golang users API "rolename" regression URL: https://github.com/apache/trafficcontrol/issues/3219#issuecomment-454813497 @moltzaum is looking at this This is an automated message from th

[GitHub] moltzaum edited a comment on issue #3218: Bugfixes for users endpoint

2019-01-16 Thread GitBox
moltzaum edited a comment on issue #3218: Bugfixes for users endpoint URL: https://github.com/apache/trafficcontrol/pull/3218#issuecomment-454574415 Yes, a path parameter is required. This is an automated message from the Apac

[GitHub] rob05c opened a new pull request #3227: Revert "Change TO DNSSEC to SHA256"

2019-01-16 Thread GitBox
rob05c opened a new pull request #3227: Revert "Change TO DNSSEC to SHA256" URL: https://github.com/apache/trafficcontrol/pull/3227 This reverts commit cc2541879ed7d38a54ef6cd160a9b4e9dacb39ca. It looks like it's going to take more work for the whole CDN to support SHA256 DNSSEC keys

[GitHub] asfgit commented on issue #3227: Revert "Change TO DNSSEC to SHA256"

2019-01-16 Thread GitBox
asfgit commented on issue #3227: Revert "Change TO DNSSEC to SHA256" URL: https://github.com/apache/trafficcontrol/pull/3227#issuecomment-454837042 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/3059/ Test

[GitHub] ocket8888 commented on issue #3218: Bugfixes for users endpoint

2019-01-16 Thread GitBox
ocket commented on issue #3218: Bugfixes for users endpoint URL: https://github.com/apache/trafficcontrol/pull/3218#issuecomment-454844797 There are a _lot_ of undocumented API endpoints, I wouldn't worry about maintaining a pattern based on that. Just do the best you can with the docu

[GitHub] moltzaum commented on issue #3218: Bugfixes for users endpoint

2019-01-16 Thread GitBox
moltzaum commented on issue #3218: Bugfixes for users endpoint URL: https://github.com/apache/trafficcontrol/pull/3218#issuecomment-454847482 I updated my comment. It does not exist; I misunderstood something based on how GET works. -

[GitHub] mitchell852 commented on a change in pull request #3203: Cachegroup ui update with fallbacks

2019-01-16 Thread GitBox
mitchell852 commented on a change in pull request #3203: Cachegroup ui update with fallbacks URL: https://github.com/apache/trafficcontrol/pull/3203#discussion_r248327926 ## File path: traffic_portal/app/src/common/modules/form/cacheGroup/FormCacheGroupController.js ## @@

[GitHub] mitchell852 commented on a change in pull request #3203: Cachegroup ui update with fallbacks

2019-01-16 Thread GitBox
mitchell852 commented on a change in pull request #3203: Cachegroup ui update with fallbacks URL: https://github.com/apache/trafficcontrol/pull/3203#discussion_r248368413 ## File path: traffic_portal/app/src/common/modules/form/cacheGroup/form.cacheGroup.tpl.html ## @@ -1

[GitHub] mitchell852 commented on a change in pull request #3203: Cachegroup ui update with fallbacks

2019-01-16 Thread GitBox
mitchell852 commented on a change in pull request #3203: Cachegroup ui update with fallbacks URL: https://github.com/apache/trafficcontrol/pull/3203#discussion_r248327609 ## File path: traffic_portal/app/src/common/modules/form/cacheGroup/FormCacheGroupController.js ## @@

[GitHub] mitchell852 commented on a change in pull request #3203: Cachegroup ui update with fallbacks

2019-01-16 Thread GitBox
mitchell852 commented on a change in pull request #3203: Cachegroup ui update with fallbacks URL: https://github.com/apache/trafficcontrol/pull/3203#discussion_r248325251 ## File path: traffic_portal/app/src/common/modules/form/_form.scss ## @@ -27,4 +27,60 @@ form .contro

[GitHub] jhg03a commented on issue #3048: TO Postinstall returns exit code 0 on failure

2019-01-16 Thread GitBox
jhg03a commented on issue #3048: TO Postinstall returns exit code 0 on failure URL: https://github.com/apache/trafficcontrol/issues/3048#issuecomment-454872283 I've also observed that postinstall can fail with carton and not get caught in the response code. You should be able to find the s

[GitHub] jhg03a commented on issue #3048: TO Postinstall returns exit code 0 on failure

2019-01-16 Thread GitBox
jhg03a commented on issue #3048: TO Postinstall returns exit code 0 on failure URL: https://github.com/apache/trafficcontrol/issues/3048#issuecomment-454873391 If you are looking at only stdout, carton will tell you that some number of things was installed and what they were. But it leaves

[GitHub] ocket8888 commented on a change in pull request #3203: Cachegroup ui update with fallbacks

2019-01-16 Thread GitBox
ocket commented on a change in pull request #3203: Cachegroup ui update with fallbacks URL: https://github.com/apache/trafficcontrol/pull/3203#discussion_r248377547 ## File path: docs/source/admin/quick_howto/cachegroup_fallback_qht.rst ## @@ -0,0 +1,65 @@ +.. +.. +..

[GitHub] ocket8888 commented on a change in pull request #3203: Cachegroup ui update with fallbacks

2019-01-16 Thread GitBox
ocket commented on a change in pull request #3203: Cachegroup ui update with fallbacks URL: https://github.com/apache/trafficcontrol/pull/3203#discussion_r248383914 ## File path: traffic_portal/app/src/common/directives/dragAndDrop/droppableDirective.js ## @@ -0,0 +1,

[GitHub] ocket8888 commented on a change in pull request #3203: Cachegroup ui update with fallbacks

2019-01-16 Thread GitBox
ocket commented on a change in pull request #3203: Cachegroup ui update with fallbacks URL: https://github.com/apache/trafficcontrol/pull/3203#discussion_r248381057 ## File path: docs/source/admin/quick_howto/cachegroup_fallback_qht.rst ## @@ -0,0 +1,65 @@ +.. +.. +..

[GitHub] ocket8888 commented on a change in pull request #3203: Cachegroup ui update with fallbacks

2019-01-16 Thread GitBox
ocket commented on a change in pull request #3203: Cachegroup ui update with fallbacks URL: https://github.com/apache/trafficcontrol/pull/3203#discussion_r248385385 ## File path: traffic_portal/app/src/common/modules/form/cacheGroup/form.cacheGroup.tpl.html ## @@ -128

[GitHub] ocket8888 commented on a change in pull request #3203: Cachegroup ui update with fallbacks

2019-01-16 Thread GitBox
ocket commented on a change in pull request #3203: Cachegroup ui update with fallbacks URL: https://github.com/apache/trafficcontrol/pull/3203#discussion_r248377294 ## File path: docs/source/admin/quick_howto/cachegroup_fallback_qht.rst ## @@ -0,0 +1,65 @@ +.. +.. +..

[GitHub] ocket8888 commented on a change in pull request #3203: Cachegroup ui update with fallbacks

2019-01-16 Thread GitBox
ocket commented on a change in pull request #3203: Cachegroup ui update with fallbacks URL: https://github.com/apache/trafficcontrol/pull/3203#discussion_r248383387 ## File path: traffic_portal/app/src/common/modules/form/_form.scss ## @@ -27,4 +27,60 @@ form .control-

[GitHub] ocket8888 commented on a change in pull request #3203: Cachegroup ui update with fallbacks

2019-01-16 Thread GitBox
ocket commented on a change in pull request #3203: Cachegroup ui update with fallbacks URL: https://github.com/apache/trafficcontrol/pull/3203#discussion_r248381854 ## File path: docs/source/admin/quick_howto/cachegroup_fallback_qht.rst ## @@ -0,0 +1,65 @@ +.. +.. +..

[GitHub] ocket8888 commented on a change in pull request #3203: Cachegroup ui update with fallbacks

2019-01-16 Thread GitBox
ocket commented on a change in pull request #3203: Cachegroup ui update with fallbacks URL: https://github.com/apache/trafficcontrol/pull/3203#discussion_r248382594 ## File path: docs/source/admin/quick_howto/index.rst ## @@ -28,3 +28,4 @@ Traffic Control is a complica

[GitHub] ocket8888 commented on a change in pull request #3203: Cachegroup ui update with fallbacks

2019-01-16 Thread GitBox
ocket commented on a change in pull request #3203: Cachegroup ui update with fallbacks URL: https://github.com/apache/trafficcontrol/pull/3203#discussion_r248383914 ## File path: traffic_portal/app/src/common/directives/dragAndDrop/droppableDirective.js ## @@ -0,0 +1,

[GitHub] rawlinp opened a new pull request #3228: Optimize regex_revalidate.config API endpoint

2019-01-16 Thread GitBox
rawlinp opened a new pull request #3228: Optimize regex_revalidate.config API endpoint URL: https://github.com/apache/trafficcontrol/pull/3228 What does this PR do? This endpoint can be unbearably slow and CPU-intensive with hundreds of current invalidation jobs. Do some simp

[GitHub] asfgit commented on issue #3228: Optimize regex_revalidate.config API endpoint

2019-01-16 Thread GitBox
asfgit commented on issue #3228: Optimize regex_revalidate.config API endpoint URL: https://github.com/apache/trafficcontrol/pull/3228#issuecomment-454878508 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/3060

[GitHub] rob05c commented on issue #3228: Optimize regex_revalidate.config API endpoint

2019-01-16 Thread GitBox
rob05c commented on issue #3228: Optimize regex_revalidate.config API endpoint URL: https://github.com/apache/trafficcontrol/pull/3228#issuecomment-454878795 This endpoint is pretty small. Is there a reason not to rewrite it in Go instead? Go should be even faster, and has the added

[GitHub] rob05c edited a comment on issue #3228: Optimize regex_revalidate.config API endpoint

2019-01-16 Thread GitBox
rob05c edited a comment on issue #3228: Optimize regex_revalidate.config API endpoint URL: https://github.com/apache/trafficcontrol/pull/3228#issuecomment-454878795 This endpoint is pretty small. Is there a reason not to rewrite it in Go instead? Go should be even faster, and has th

[GitHub] rawlinp commented on issue #3228: Optimize regex_revalidate.config API endpoint

2019-01-16 Thread GitBox
rawlinp commented on issue #3228: Optimize regex_revalidate.config API endpoint URL: https://github.com/apache/trafficcontrol/pull/3228#issuecomment-454882682 It should be rewritten in Go, but that would take much longer to implement and test than this low-hanging fruit optimization done in

[GitHub] rawlinp commented on issue #3228: Optimize regex_revalidate.config API endpoint

2019-01-16 Thread GitBox
rawlinp commented on issue #3228: Optimize regex_revalidate.config API endpoint URL: https://github.com/apache/trafficcontrol/pull/3228#issuecomment-454884716 Most of the work done in this endpoint is date parsing and calculations in pure Perl, so I imagine this would get even faster than t

[GitHub] jhg03a opened a new issue #3229: Include carton stdout & stderr output in postinstall.log

2019-01-16 Thread GitBox
jhg03a opened a new issue #3229: Include carton stdout & stderr output in postinstall.log URL: https://github.com/apache/trafficcontrol/issues/3229 The postinstall perl script doesn't appear to be capturing carton's stdout or stderr in postinstall.log. This would be immensely helpful when

[GitHub] dangogh opened a new pull request #3230: change cdn-in-a-box integration tests to use dynamic dns

2019-01-16 Thread GitBox
dangogh opened a new pull request #3230: change cdn-in-a-box integration tests to use dynamic dns URL: https://github.com/apache/trafficcontrol/pull/3230 What does this PR do? Changes integration tests in cdn-in-a-box to use the dynamic dns introduced in #3213 Whic

[GitHub] asfgit commented on issue #3230: change cdn-in-a-box integration tests to use dynamic dns

2019-01-16 Thread GitBox
asfgit commented on issue #3230: change cdn-in-a-box integration tests to use dynamic dns URL: https://github.com/apache/trafficcontrol/pull/3230#issuecomment-454891773 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcon

[GitHub] rawlinp commented on issue #3228: Optimize regex_revalidate.config API endpoint

2019-01-16 Thread GitBox
rawlinp commented on issue #3228: Optimize regex_revalidate.config API endpoint URL: https://github.com/apache/trafficcontrol/pull/3228#issuecomment-454892404 Definitely agree on putting this near the head of the endpoints to port, because it's almost completely open to self-service users w

[GitHub] dangogh commented on a change in pull request #3228: Optimize regex_revalidate.config API endpoint

2019-01-16 Thread GitBox
dangogh commented on a change in pull request #3228: Optimize regex_revalidate.config API endpoint URL: https://github.com/apache/trafficcontrol/pull/3228#discussion_r248404353 ## File path: traffic_ops/app/lib/API/Configs/ApacheTrafficServer.pm ## @@ -1803,15 +1811,11 @@

[GitHub] rawlinp commented on a change in pull request #3228: Optimize regex_revalidate.config API endpoint

2019-01-16 Thread GitBox
rawlinp commented on a change in pull request #3228: Optimize regex_revalidate.config API endpoint URL: https://github.com/apache/trafficcontrol/pull/3228#discussion_r248405152 ## File path: traffic_ops/app/lib/API/Configs/ApacheTrafficServer.pm ## @@ -1803,15 +1811,11 @@

[GitHub] mtorluemke commented on issue #3228: Optimize regex_revalidate.config API endpoint

2019-01-16 Thread GitBox
mtorluemke commented on issue #3228: Optimize regex_revalidate.config API endpoint URL: https://github.com/apache/trafficcontrol/pull/3228#issuecomment-454893380 thanks @rawlinp ! This is an automated message from the Apache

[GitHub] dangogh commented on issue #3228: Optimize regex_revalidate.config API endpoint

2019-01-16 Thread GitBox
dangogh commented on issue #3228: Optimize regex_revalidate.config API endpoint URL: https://github.com/apache/trafficcontrol/pull/3228#issuecomment-454894118 moving the $date setting outside the loop is obviously correct and a welcome change -- haven't looked at the rest of the changes in

[GitHub] asfgit commented on issue #3228: Optimize regex_revalidate.config API endpoint

2019-01-16 Thread GitBox
asfgit commented on issue #3228: Optimize regex_revalidate.config API endpoint URL: https://github.com/apache/trafficcontrol/pull/3228#issuecomment-454895257 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/3062

[GitHub] alficles commented on a change in pull request #3228: Optimize regex_revalidate.config API endpoint

2019-01-16 Thread GitBox
alficles commented on a change in pull request #3228: Optimize regex_revalidate.config API endpoint URL: https://github.com/apache/trafficcontrol/pull/3228#discussion_r248409501 ## File path: traffic_ops/app/lib/API/Configs/ApacheTrafficServer.pm ## @@ -1803,15 +1811,11 @@

[GitHub] mitchell852 commented on issue #2036: Store case-insensitive user info in DB

2019-01-16 Thread GitBox
mitchell852 commented on issue #2036: Store case-insensitive user info in DB URL: https://github.com/apache/trafficcontrol/issues/2036#issuecomment-454909863 This is applicable to any api endpoint that creates or edits a "user". I think just these ones ``` post("/api/$version/use

[GitHub] dangogh closed issue #2732: Unable to Edit or Delete a Tenant where Active is false

2019-01-16 Thread GitBox
dangogh closed issue #2732: Unable to Edit or Delete a Tenant where Active is false URL: https://github.com/apache/trafficcontrol/issues/2732 This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] dangogh merged pull request #3163: Fix Traffic Ops Tenancy and Activity Bugs, Fix TO API Test Framework to work with Tenancy

2019-01-16 Thread GitBox
dangogh merged pull request #3163: Fix Traffic Ops Tenancy and Activity Bugs, Fix TO API Test Framework to work with Tenancy URL: https://github.com/apache/trafficcontrol/pull/3163 This is an automated message from the Apach

[GitHub] rawlinp commented on a change in pull request #3222: ORT.py now uses the official ATC client

2019-01-16 Thread GitBox
rawlinp commented on a change in pull request #3222: ORT.py now uses the official ATC client URL: https://github.com/apache/trafficcontrol/pull/3222#discussion_r248440645 ## File path: traffic_control/clients/python/trafficops/tosession.py ## @@ -701,16 +691,18 @@ def get_

[GitHub] mattjackson220 commented on a change in pull request #3203: Cachegroup ui update with fallbacks

2019-01-16 Thread GitBox
mattjackson220 commented on a change in pull request #3203: Cachegroup ui update with fallbacks URL: https://github.com/apache/trafficcontrol/pull/3203#discussion_r248469664 ## File path: traffic_portal/app/src/common/modules/form/_form.scss ## @@ -27,4 +27,60 @@ form .con

[GitHub] mattjackson220 commented on a change in pull request #3203: Cachegroup ui update with fallbacks

2019-01-16 Thread GitBox
mattjackson220 commented on a change in pull request #3203: Cachegroup ui update with fallbacks URL: https://github.com/apache/trafficcontrol/pull/3203#discussion_r248469705 ## File path: traffic_portal/app/src/common/modules/form/cacheGroup/FormCacheGroupController.js ##

[GitHub] mattjackson220 commented on a change in pull request #3203: Cachegroup ui update with fallbacks

2019-01-16 Thread GitBox
mattjackson220 commented on a change in pull request #3203: Cachegroup ui update with fallbacks URL: https://github.com/apache/trafficcontrol/pull/3203#discussion_r248469688 ## File path: traffic_portal/app/src/common/modules/form/cacheGroup/FormCacheGroupController.js ##

[GitHub] mattjackson220 commented on a change in pull request #3203: Cachegroup ui update with fallbacks

2019-01-16 Thread GitBox
mattjackson220 commented on a change in pull request #3203: Cachegroup ui update with fallbacks URL: https://github.com/apache/trafficcontrol/pull/3203#discussion_r248469829 ## File path: docs/source/admin/quick_howto/cachegroup_fallback_qht.rst ## @@ -0,0 +1,65 @@ +.. +..

[GitHub] mattjackson220 commented on a change in pull request #3203: Cachegroup ui update with fallbacks

2019-01-16 Thread GitBox
mattjackson220 commented on a change in pull request #3203: Cachegroup ui update with fallbacks URL: https://github.com/apache/trafficcontrol/pull/3203#discussion_r248469726 ## File path: traffic_portal/app/src/common/modules/form/cacheGroup/form.cacheGroup.tpl.html ## @@

<    4   5   6   7   8   9   10   11   12   13   >