[GitHub] dneuman64 opened a new issue #2628: golang DNSSEC key creation creates invalid keys

2018-08-03 Thread GitBox
dneuman64 opened a new issue #2628: golang DNSSEC key creation creates invalid keys URL: https://github.com/apache/trafficcontrol/issues/2628 When DNSSEC keys are created by the golang route they are invalid and choke TR. It looks like the domain name is being generated with two periods

[GitHub] mitchell852 commented on issue #2626: comment out DS create routes with DNSSEC key generation bug

2018-08-03 Thread GitBox
mitchell852 commented on issue #2626: comment out DS create routes with DNSSEC key generation bug URL: https://github.com/apache/trafficcontrol/pull/2626#issuecomment-410333072 This PR is related to #2628 This is an

[GitHub] smalenfant opened a new pull request #2600: Handle port different than 80 for Traffic Ops Checks

2018-07-30 Thread GitBox
smalenfant opened a new pull request #2600: Handle port different than 80 for Traffic Ops Checks URL: https://github.com/apache/trafficcontrol/pull/2600 Also avoid a division by zero in Cache Hit Ratio This is an automated

[GitHub] asfgit commented on issue #2600: Handle port different than 80 for Traffic Ops Checks

2018-07-30 Thread GitBox
asfgit commented on issue #2600: Handle port different than 80 for Traffic Ops Checks URL: https://github.com/apache/trafficcontrol/pull/2600#issuecomment-408860218 Refer to this link for build results (access rights to CI server needed):

[GitHub] moltzaum commented on issue #2597: Golang cachegroup crud apis are missing data integrity rules implemented in Perl

2018-07-30 Thread GitBox
moltzaum commented on issue #2597: Golang cachegroup crud apis are missing data integrity rules implemented in Perl URL: https://github.com/apache/trafficcontrol/issues/2597#issuecomment-408989795 Working on this. This is an

[GitHub] rawlinp opened a new pull request #2601: TP: Provide way to enable or disable cachegroup localization methods

2018-07-30 Thread GitBox
rawlinp opened a new pull request #2601: TP: Provide way to enable or disable cachegroup localization methods URL: https://github.com/apache/trafficcontrol/pull/2601 With support via the TO API, add the ability to enable/disable localization methods (CZ, DEEP_CZ, GEO) in the cachegroup

[GitHub] asfgit commented on issue #2601: TP: Provide way to enable or disable cachegroup localization methods

2018-07-30 Thread GitBox
asfgit commented on issue #2601: TP: Provide way to enable or disable cachegroup localization methods URL: https://github.com/apache/trafficcontrol/pull/2601#issuecomment-409017983 Refer to this link for build results (access rights to CI server needed):

[GitHub] rawlinp commented on issue #2597: Golang cachegroup crud apis are missing data integrity rules implemented in Perl

2018-07-30 Thread GitBox
rawlinp commented on issue #2597: Golang cachegroup crud apis are missing data integrity rules implemented in Perl URL: https://github.com/apache/trafficcontrol/issues/2597#issuecomment-409018729 We should do this check in the API in order to give the user a useful error message, but also

[GitHub] moltzaum opened a new issue #2592: Dangling Federations and Federation Structure

2018-07-26 Thread GitBox
moltzaum opened a new issue #2592: Dangling Federations and Federation Structure URL: https://github.com/apache/trafficcontrol/issues/2592 `POST /cdns/foo/federations/` Does not connect a deliveryservice, but it should. The method to connect deliveryservies is via `POST

[GitHub] ezelkow1 commented on a change in pull request #2590: Add s? to cachkey capture prefix so it will capture both http and https in to http keys

2018-07-26 Thread GitBox
ezelkow1 commented on a change in pull request #2590: Add s? to cachkey capture prefix so it will capture both http and https in to http keys URL: https://github.com/apache/trafficcontrol/pull/2590#discussion_r205530384 ## File path: traffic_ops/app/lib/UI/DeliveryService.pm

[GitHub] ocket8888 commented on a change in pull request #2571: Adding parts of cdn-in-a-box

2018-07-26 Thread GitBox
ocket commented on a change in pull request #2571: Adding parts of cdn-in-a-box URL: https://github.com/apache/trafficcontrol/pull/2571#discussion_r204889103 ## File path: infrastructure/cdn-in-a-box/traffic_ops/setup.sh ## @@ -0,0 +1,55 @@ +#!/usr/bin/bash +#

[GitHub] mitchell852 commented on a change in pull request #2591: Manage static dns entries front-end changes [WIP]

2018-07-26 Thread GitBox
mitchell852 commented on a change in pull request #2591: Manage static dns entries front-end changes [WIP] URL: https://github.com/apache/trafficcontrol/pull/2591#discussion_r205644931 ## File path:

[GitHub] mitchell852 commented on issue #2589: Incorrect cachekey parameters for https origin servers

2018-07-25 Thread GitBox
mitchell852 commented on issue #2589: Incorrect cachekey parameters for https origin servers URL: https://github.com/apache/trafficcontrol/issues/2589#issuecomment-407954951 @alficles - is this bug only applicable in the TO UI or does it apply to TP/TO API as well?

[GitHub] asfgit commented on issue #2591: Manage static dns entries front-end changes [WIP]

2018-07-26 Thread GitBox
asfgit commented on issue #2591: Manage static dns entries front-end changes [WIP] URL: https://github.com/apache/trafficcontrol/pull/2591#issuecomment-408153547 Refer to this link for build results (access rights to CI server needed):

[GitHub] BaVanDuong opened a new issue #2593: traffic_ops error null value in column "tenant_id" violates not-null constraint in postinstall

2018-07-26 Thread GitBox
BaVanDuong opened a new issue #2593: traffic_ops error null value in column "tenant_id" violates not-null constraint in postinstall URL: https://github.com/apache/trafficcontrol/issues/2593 After run script postinstall traffic_ops error: ``` DBD::Pg::db do failed: ERROR: null value

[GitHub] ezelkow1 opened a new pull request #2590: Add s? to cachkey capture prefix so it will capture both http and https in to http keys

2018-07-25 Thread GitBox
ezelkow1 opened a new pull request #2590: Add s? to cachkey capture prefix so it will capture both http and https in to http keys URL: https://github.com/apache/trafficcontrol/pull/2590 For issue https://github.com/apache/trafficcontrol/issues/2589 The ignore and pass up has a

[GitHub] alficles commented on issue #2589: Incorrect cachekey parameters for https origin servers

2018-07-25 Thread GitBox
alficles commented on issue #2589: Incorrect cachekey parameters for https origin servers URL: https://github.com/apache/trafficcontrol/issues/2589#issuecomment-407958943 Both. It's a bug in the perl that generates the config lines.

[GitHub] alficles opened a new issue #2589: Incorrect cachekey parameters for https origin servers

2018-07-25 Thread GitBox
alficles opened a new issue #2589: Incorrect cachekey parameters for https origin servers URL: https://github.com/apache/trafficcontrol/issues/2589 When a delivery service uses the parameter "ignore in cache key, and pass up" for the query string and an https delivery service at the same

[GitHub] asfgit commented on issue #2590: Add s? to cachkey capture prefix so it will capture both http and https in to http keys

2018-07-25 Thread GitBox
asfgit commented on issue #2590: Add s? to cachkey capture prefix so it will capture both http and https in to http keys URL: https://github.com/apache/trafficcontrol/pull/2590#issuecomment-407944236 Can one of the admins verify this patch?

[GitHub] mitchell852 edited a comment on issue #2592: Dangling Federations and Federation Structure

2018-07-27 Thread GitBox
mitchell852 edited a comment on issue #2592: Dangling Federations and Federation Structure URL: https://github.com/apache/trafficcontrol/issues/2592#issuecomment-408431864 I don't know the best answer here. IMO, this is the result of poor API design when federations were originally

[GitHub] moltzaum commented on issue #2592: Dangling Federations and Federation Structure

2018-07-27 Thread GitBox
moltzaum commented on issue #2592: Dangling Federations and Federation Structure URL: https://github.com/apache/trafficcontrol/issues/2592#issuecomment-408437043 Suggested POST ("deliveryServices" is new) ``` { "ttl": 48, "id": 3, "description": "the description",

[GitHub] mitchell852 commented on issue #2592: Dangling Federations and Federation Structure

2018-07-27 Thread GitBox
mitchell852 commented on issue #2592: Dangling Federations and Federation Structure URL: https://github.com/apache/trafficcontrol/issues/2592#issuecomment-408431864 I don't know the best answer here. IMO, this is the result of poor API design when federations were originally implemented.

[GitHub] mitchell852 opened a new pull request #2594: fixes error with longDesc required error message

2018-07-27 Thread GitBox
mitchell852 opened a new pull request #2594: fixes error with longDesc required error message URL: https://github.com/apache/trafficcontrol/pull/2594 This is an automated message from the Apache Git Service. To respond to

[GitHub] asfgit commented on issue #2594: fixes error with longDesc required error message

2018-07-27 Thread GitBox
asfgit commented on issue #2594: fixes error with longDesc required error message URL: https://github.com/apache/trafficcontrol/pull/2594#issuecomment-408420027 Refer to this link for build results (access rights to CI server needed):

[GitHub] mitchell852 edited a comment on issue #2592: Dangling Federations and Federation Structure

2018-07-27 Thread GitBox
mitchell852 edited a comment on issue #2592: Dangling Federations and Federation Structure URL: https://github.com/apache/trafficcontrol/issues/2592#issuecomment-408431864 I don't know the best answer here. IMO, this is the result of poor API design when federations were originally

[GitHub] dangogh closed pull request #2594: fixes error with longDesc required error message

2018-07-27 Thread GitBox
dangogh closed pull request #2594: fixes error with longDesc required error message URL: https://github.com/apache/trafficcontrol/pull/2594 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] mitchell852 opened a new issue #2596: for copy url sig keys, limit the list of source ds's to ones that actually have url sig keys

2018-07-27 Thread GitBox
mitchell852 opened a new issue #2596: for copy url sig keys, limit the list of source ds's to ones that actually have url sig keys URL: https://github.com/apache/trafficcontrol/issues/2596

[GitHub] mitchell852 opened a new issue #2595: trying to delete a ds that has an open ds request is successful

2018-07-27 Thread GitBox
mitchell852 opened a new issue #2595: trying to delete a ds that has an open ds request is successful URL: https://github.com/apache/trafficcontrol/issues/2595 With ds requests turned on in traffic_portal_properties.json, all changes to a ds (create, update or delete) result in the

[GitHub] mitchell852 commented on issue #2592: Dangling Federations and Federation Structure

2018-07-27 Thread GitBox
mitchell852 commented on issue #2592: Dangling Federations and Federation Structure URL: https://github.com/apache/trafficcontrol/issues/2592#issuecomment-408463846 no, i don't particularly like them mismatching. i'd rather the GET response looks like `{ "ttl": 48,

[GitHub] mitchell852 edited a comment on issue #2592: Dangling Federations and Federation Structure

2018-07-27 Thread GitBox
mitchell852 edited a comment on issue #2592: Dangling Federations and Federation Structure URL: https://github.com/apache/trafficcontrol/issues/2592#issuecomment-408463846 no, i don't particularly like them mismatching. i'd rather the GET response looks like ``` { "ttl":

[GitHub] mitchell852 edited a comment on issue #2592: Dangling Federations and Federation Structure

2018-07-27 Thread GitBox
mitchell852 edited a comment on issue #2592: Dangling Federations and Federation Structure URL: https://github.com/apache/trafficcontrol/issues/2592#issuecomment-408463846 no, i don't particularly like them mismatching. i'd rather the GET response look something like ``` {

[GitHub] dangogh closed pull request #2598: comments out cachegroup apis that were not implemented correctly. the…

2018-07-27 Thread GitBox
dangogh closed pull request #2598: comments out cachegroup apis that were not implemented correctly. the… URL: https://github.com/apache/trafficcontrol/pull/2598 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[GitHub] asfgit commented on issue #2598: comments out cachegroup apis that were not implemented correctly. the…

2018-07-27 Thread GitBox
asfgit commented on issue #2598: comments out cachegroup apis that were not implemented correctly. the… URL: https://github.com/apache/trafficcontrol/pull/2598#issuecomment-408483756 Refer to this link for build results (access rights to CI server needed):

[GitHub] asfgit commented on issue #2598: comments out cachegroup apis that were not implemented correctly. the…

2018-07-27 Thread GitBox
asfgit commented on issue #2598: comments out cachegroup apis that were not implemented correctly. the… URL: https://github.com/apache/trafficcontrol/pull/2598#issuecomment-408484478 Refer to this link for build results (access rights to CI server needed):

[GitHub] mitchell852 opened a new issue #2597: Golang cachegroup crud apis are missing data integrity rules implemented in Perl

2018-07-27 Thread GitBox
mitchell852 opened a new issue #2597: Golang cachegroup crud apis are missing data integrity rules implemented in Perl URL: https://github.com/apache/trafficcontrol/issues/2597 All of the rules found in Perl were not migrated to Go. For example, when trying to delete a cachegroup, the

[GitHub] dangogh commented on issue #2598: comments out cachegroup apis that were not implemented correctly. the…

2018-07-27 Thread GitBox
dangogh commented on issue #2598: comments out cachegroup apis that were not implemented correctly. the… URL: https://github.com/apache/trafficcontrol/pull/2598#issuecomment-408480516 Can you put a comment in the code reflecting the reason they're disabled? I know it'll help me later..

[GitHub] alficles commented on a change in pull request #2590: Add s? to cachkey capture prefix so it will capture both http and https in to http keys

2018-07-26 Thread GitBox
alficles commented on a change in pull request #2590: Add s? to cachkey capture prefix so it will capture both http and https in to http keys URL: https://github.com/apache/trafficcontrol/pull/2590#discussion_r205438698 ## File path: traffic_ops/app/lib/UI/DeliveryService.pm

[GitHub] rawlinp commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer)

2018-07-31 Thread GitBox
rawlinp commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer) URL: https://github.com/apache/trafficcontrol/pull/2545#discussion_r206568926 ## File path: traffic_ops/traffic_ops_golang/cdnfederation/cdnfederations.go ## @@ -0,0 +1,389

[GitHub] moltzaum opened a new issue #2602: TODO: Update Tenancy Check to Use Different Method

2018-07-31 Thread GitBox
moltzaum opened a new issue #2602: TODO: Update Tenancy Check to Use Different Method URL: https://github.com/apache/trafficcontrol/issues/2602 In `cdnfederations.go` I used `GetUserTenantIDListTx` instead of `IsResourceAuthorizedToUserTx` because the secondary method still used the

[GitHub] rawlinp commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer)

2018-07-31 Thread GitBox
rawlinp commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer) URL: https://github.com/apache/trafficcontrol/pull/2545#discussion_r206561525 ## File path: traffic_ops/traffic_ops_golang/cdnfederation/cdnfederations.go ## @@ -0,0 +1,389

[GitHub] rawlinp commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer)

2018-07-31 Thread GitBox
rawlinp commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer) URL: https://github.com/apache/trafficcontrol/pull/2545#discussion_r206561525 ## File path: traffic_ops/traffic_ops_golang/cdnfederation/cdnfederations.go ## @@ -0,0 +1,389

[GitHub] moltzaum commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer)

2018-07-31 Thread GitBox
moltzaum commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer) URL: https://github.com/apache/trafficcontrol/pull/2545#discussion_r206554044 ## File path: traffic_ops/traffic_ops_golang/cdnfederation/cdnfederations.go ## @@ -0,0 +1,389

[GitHub] moltzaum commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer)

2018-07-31 Thread GitBox
moltzaum commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer) URL: https://github.com/apache/trafficcontrol/pull/2545#discussion_r206563175 ## File path: traffic_ops/traffic_ops_golang/cdnfederation/cdnfederations.go ## @@ -0,0 +1,389

[GitHub] rawlinp commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer)

2018-07-31 Thread GitBox
rawlinp commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer) URL: https://github.com/apache/trafficcontrol/pull/2545#discussion_r206562854 ## File path: traffic_ops/traffic_ops_golang/cdnfederation/cdnfederations.go ## @@ -0,0 +1,389

[GitHub] moltzaum commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer)

2018-07-31 Thread GitBox
moltzaum commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer) URL: https://github.com/apache/trafficcontrol/pull/2545#discussion_r206568231 ## File path: traffic_ops/traffic_ops_golang/cdnfederation/cdnfederations.go ## @@ -0,0 +1,389

[GitHub] moltzaum commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer)

2018-07-31 Thread GitBox
moltzaum commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer) URL: https://github.com/apache/trafficcontrol/pull/2545#discussion_r206568231 ## File path: traffic_ops/traffic_ops_golang/cdnfederation/cdnfederations.go ## @@ -0,0 +1,389

[GitHub] rawlinp commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer)

2018-07-31 Thread GitBox
rawlinp commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer) URL: https://github.com/apache/trafficcontrol/pull/2545#discussion_r206530494 ## File path: traffic_ops/traffic_ops_golang/cdnfederation/cdnfederations.go ## @@ -0,0 +1,389

[GitHub] rawlinp commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer)

2018-07-31 Thread GitBox
rawlinp commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer) URL: https://github.com/apache/trafficcontrol/pull/2545#discussion_r206542962 ## File path: traffic_ops/traffic_ops_golang/routes.go ## @@ -292,6 +293,13 @@ func Routes(d

[GitHub] rawlinp commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer)

2018-07-31 Thread GitBox
rawlinp commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer) URL: https://github.com/apache/trafficcontrol/pull/2545#discussion_r206531089 ## File path: traffic_ops/traffic_ops_golang/cdnfederation/cdnfederations.go ## @@ -0,0 +1,389

[GitHub] rawlinp commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer)

2018-07-31 Thread GitBox
rawlinp commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer) URL: https://github.com/apache/trafficcontrol/pull/2545#discussion_r206343596 ## File path: traffic_ops/traffic_ops_golang/cdnfederation/cdnfederations.go ## @@ -0,0 +1,389

[GitHub] rawlinp commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer)

2018-07-31 Thread GitBox
rawlinp commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer) URL: https://github.com/apache/trafficcontrol/pull/2545#discussion_r206354488 ## File path: traffic_ops/traffic_ops_golang/cdnfederation/cdnfederations.go ## @@ -0,0 +1,389

[GitHub] rawlinp commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer)

2018-07-31 Thread GitBox
rawlinp commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer) URL: https://github.com/apache/trafficcontrol/pull/2545#discussion_r206354814 ## File path: traffic_ops/traffic_ops_golang/cdnfederation/cdnfederations.go ## @@ -0,0 +1,389

[GitHub] rawlinp commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer)

2018-07-31 Thread GitBox
rawlinp commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer) URL: https://github.com/apache/trafficcontrol/pull/2545#discussion_r206334463 ## File path: lib/go-tc/v13/federations.go ## @@ -0,0 +1,55 @@ +package v13 + +import tc

[GitHub] rawlinp commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer)

2018-07-31 Thread GitBox
rawlinp commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer) URL: https://github.com/apache/trafficcontrol/pull/2545#discussion_r206357711 ## File path: traffic_ops/traffic_ops_golang/cdnfederation/cdnfederations.go ## @@ -0,0 +1,389

[GitHub] rawlinp commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer)

2018-07-31 Thread GitBox
rawlinp commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer) URL: https://github.com/apache/trafficcontrol/pull/2545#discussion_r206539845 ## File path: traffic_ops/traffic_ops_golang/cdnfederation/cdnfederations.go ## @@ -0,0 +1,389

[GitHub] rawlinp commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer)

2018-07-31 Thread GitBox
rawlinp commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer) URL: https://github.com/apache/trafficcontrol/pull/2545#discussion_r206344203 ## File path: traffic_ops/traffic_ops_golang/cdnfederation/cdnfederations.go ## @@ -0,0 +1,389

[GitHub] rawlinp commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer)

2018-07-31 Thread GitBox
rawlinp commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer) URL: https://github.com/apache/trafficcontrol/pull/2545#discussion_r206341203 ## File path: lib/go-tc/v13/federations.go ## @@ -0,0 +1,55 @@ +package v13 + +import tc

[GitHub] rawlinp commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer)

2018-07-31 Thread GitBox
rawlinp commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer) URL: https://github.com/apache/trafficcontrol/pull/2545#discussion_r206358762 ## File path: traffic_ops/traffic_ops_golang/cdnfederation/cdnfederations.go ## @@ -0,0 +1,389

[GitHub] rawlinp commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer)

2018-07-31 Thread GitBox
rawlinp commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer) URL: https://github.com/apache/trafficcontrol/pull/2545#discussion_r206358595 ## File path: traffic_ops/traffic_ops_golang/cdnfederation/cdnfederations.go ## @@ -0,0 +1,389

[GitHub] rawlinp commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer)

2018-07-31 Thread GitBox
rawlinp commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer) URL: https://github.com/apache/trafficcontrol/pull/2545#discussion_r206534562 ## File path: traffic_ops/testing/api/v13/cdnfederations_test.go ## @@ -0,0 +1,131 @@ +package

[GitHub] moltzaum commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer)

2018-07-31 Thread GitBox
moltzaum commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer) URL: https://github.com/apache/trafficcontrol/pull/2545#discussion_r206552673 ## File path: traffic_ops/traffic_ops_golang/cdnfederation/cdnfederations.go ## @@ -0,0 +1,389

[GitHub] moltzaum commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer)

2018-07-31 Thread GitBox
moltzaum commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer) URL: https://github.com/apache/trafficcontrol/pull/2545#discussion_r206570504 ## File path: traffic_ops/traffic_ops_golang/cdnfederation/cdnfederations.go ## @@ -0,0 +1,389

[GitHub] moltzaum commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer)

2018-07-31 Thread GitBox
moltzaum commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer) URL: https://github.com/apache/trafficcontrol/pull/2545#discussion_r206577707 ## File path: traffic_ops/traffic_ops_golang/cdnfederation/cdnfederations.go ## @@ -0,0 +1,389

[GitHub] moltzaum commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer)

2018-07-31 Thread GitBox
moltzaum commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer) URL: https://github.com/apache/trafficcontrol/pull/2545#discussion_r206582203 ## File path: traffic_ops/traffic_ops_golang/cdnfederation/cdnfederations.go ## @@ -0,0 +1,389

[GitHub] moltzaum commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer)

2018-07-31 Thread GitBox
moltzaum commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer) URL: https://github.com/apache/trafficcontrol/pull/2545#discussion_r206582203 ## File path: traffic_ops/traffic_ops_golang/cdnfederation/cdnfederations.go ## @@ -0,0 +1,389

[GitHub] moltzaum commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer)

2018-07-31 Thread GitBox
moltzaum commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer) URL: https://github.com/apache/trafficcontrol/pull/2545#discussion_r206576923 ## File path: traffic_ops/traffic_ops_golang/cdnfederation/cdnfederations.go ## @@ -0,0 +1,389

[GitHub] rawlinp commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer)

2018-07-31 Thread GitBox
rawlinp commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer) URL: https://github.com/apache/trafficcontrol/pull/2545#discussion_r206592345 ## File path: traffic_ops/traffic_ops_golang/cdnfederation/cdnfederations.go ## @@ -0,0 +1,389

[GitHub] dewrich commented on a change in pull request #2557: Cachegroups localization policy

2018-07-31 Thread GitBox
dewrich commented on a change in pull request #2557: Cachegroups localization policy URL: https://github.com/apache/trafficcontrol/pull/2557#discussion_r206581266 ## File path: traffic_ops/testing/api/v13/tc-fixtures.json ## @@ -38,6 +38,11 @@

[GitHub] rawlinp commented on issue #2557: Cachegroups localization policy

2018-07-31 Thread GitBox
rawlinp commented on issue #2557: Cachegroups localization policy URL: https://github.com/apache/trafficcontrol/pull/2557#issuecomment-409281998 I think the test fails because somebody commented out the Go cachegroup routes. It should pass when the test is actually hitting the Go version

[GitHub] rawlinp commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer)

2018-07-31 Thread GitBox
rawlinp commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer) URL: https://github.com/apache/trafficcontrol/pull/2545#discussion_r206528919 ## File path: traffic_ops/traffic_ops_golang/cdnfederation/cdnfederations.go ## @@ -0,0 +1,389

[GitHub] rawlinp commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer)

2018-07-31 Thread GitBox
rawlinp commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer) URL: https://github.com/apache/trafficcontrol/pull/2545#discussion_r206542527 ## File path: traffic_ops/traffic_ops_golang/dbhelpers/db_helpers.go ## @@ -230,3 +230,15 @@

[GitHub] rawlinp commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer)

2018-07-31 Thread GitBox
rawlinp commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer) URL: https://github.com/apache/trafficcontrol/pull/2545#discussion_r206531897 ## File path: traffic_ops/traffic_ops_golang/cdnfederation/cdnfederations.go ## @@ -0,0 +1,389

[GitHub] rawlinp commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer)

2018-07-31 Thread GitBox
rawlinp commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer) URL: https://github.com/apache/trafficcontrol/pull/2545#discussion_r206541551 ## File path: traffic_ops/traffic_ops_golang/cdnfederation/cdnfederations.go ## @@ -0,0 +1,389

[GitHub] rawlinp commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer)

2018-07-31 Thread GitBox
rawlinp commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer) URL: https://github.com/apache/trafficcontrol/pull/2545#discussion_r206532389 ## File path: traffic_ops/traffic_ops_golang/cdnfederation/cdnfederations.go ## @@ -0,0 +1,389

[GitHub] rawlinp commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer)

2018-07-31 Thread GitBox
rawlinp commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer) URL: https://github.com/apache/trafficcontrol/pull/2545#discussion_r206536013 ## File path: traffic_ops/traffic_ops_golang/cdnfederation/cdnfederations.go ## @@ -0,0 +1,389

[GitHub] rawlinp commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer)

2018-07-31 Thread GitBox
rawlinp commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer) URL: https://github.com/apache/trafficcontrol/pull/2545#discussion_r206542064 ## File path: traffic_ops/traffic_ops_golang/cdnfederation/cdnfederations.go ## @@ -0,0 +1,389

[GitHub] dewrich commented on issue #2587: allow server selection based on ds assignment

2018-07-31 Thread GitBox
dewrich commented on issue #2587: allow server selection based on ds assignment URL: https://github.com/apache/trafficcontrol/pull/2587#issuecomment-409266436 @dangogh Unit Tests Fails: ```BUILD| github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/server |

[GitHub] dewrich commented on issue #2557: Cachegroups localization policy

2018-07-31 Thread GitBox
dewrich commented on issue #2557: Cachegroups localization policy URL: https://github.com/apache/trafficcontrol/pull/2557#issuecomment-409269789 @rawlinp API Test Case fails: ```DEBUG: cachegroups_test.go:33: 2018-07-31T09:47:58.735331-06:00: TestCacheGroupsAuthentication() PASSED:

[GitHub] moltzaum commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer)

2018-07-31 Thread GitBox
moltzaum commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer) URL: https://github.com/apache/trafficcontrol/pull/2545#discussion_r206613482 ## File path: traffic_ops/traffic_ops_golang/cdnfederation/cdnfederations.go ## @@ -0,0 +1,389

[GitHub] jhg03a commented on issue #2624: Improve TP search query

2018-08-03 Thread GitBox
jhg03a commented on issue #2624: Improve TP search query URL: https://github.com/apache/trafficcontrol/issues/2624#issuecomment-410362947 Also related #2630 This is an automated message from the Apache Git Service. To respond

[GitHub] elsloo closed pull request #2629: Remove debug print from error log

2018-08-03 Thread GitBox
elsloo closed pull request #2629: Remove debug print from error log URL: https://github.com/apache/trafficcontrol/pull/2629 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] asfgit commented on issue #2629: Remove debug print from error log

2018-08-03 Thread GitBox
asfgit commented on issue #2629: Remove debug print from error log URL: https://github.com/apache/trafficcontrol/pull/2629#issuecomment-410353501 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/2185/ Test

[GitHub] jhg03a opened a new pull request #2629: Remove debug print from error log

2018-08-03 Thread GitBox
jhg03a opened a new pull request #2629: Remove debug print from error log URL: https://github.com/apache/trafficcontrol/pull/2629 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] asfgit commented on issue #2606: Updates 'grovetccfg' to to write a grove.cfg from the grove servers profile

2018-08-02 Thread GitBox
asfgit commented on issue #2606: Updates 'grovetccfg' to to write a grove.cfg from the grove servers profile URL: https://github.com/apache/trafficcontrol/pull/2606#issuecomment-409943092 Refer to this link for build results (access rights to CI server needed):

[GitHub] dangogh opened a new pull request #2612: cdn-in-a-box TO more general preload of data

2018-08-02 Thread GitBox
dangogh opened a new pull request #2612: cdn-in-a-box TO more general preload of data URL: https://github.com/apache/trafficcontrol/pull/2612 This is an automated message from the Apache Git Service. To respond to the

[GitHub] rawlinp commented on issue #2239: ORT Routes need to point to the 1.3 TO APIs

2018-08-01 Thread GitBox
rawlinp commented on issue #2239: ORT Routes need to point to the 1.3 TO APIs URL: https://github.com/apache/trafficcontrol/issues/2239#issuecomment-409689984 I noticed ORT still uses the `/login` endpoint to login (rather than a proper API route): ``` my $url = $to_host .

[GitHub] jrushford opened a new pull request #2606: Updates 'grovetccfg' to to write a grove.cfg from the grove servers profile

2018-08-01 Thread GitBox
jrushford opened a new pull request #2606: Updates 'grovetccfg' to to write a grove.cfg from the grove servers profile URL: https://github.com/apache/trafficcontrol/pull/2606 Modified grovetccfg to read a grove server profile from the traffic_ops and write a grove.cfg from that profile id

[GitHub] asfgit commented on issue #2606: Updates 'grovetccfg' to to write a grove.cfg from the grove servers profile

2018-08-01 Thread GitBox
asfgit commented on issue #2606: Updates 'grovetccfg' to to write a grove.cfg from the grove servers profile URL: https://github.com/apache/trafficcontrol/pull/2606#issuecomment-409691292 Refer to this link for build results (access rights to CI server needed):

[GitHub] moltzaum opened a new pull request #2605: TO Golang: Implemented Cachegroup Data Integrity Rules

2018-08-01 Thread GitBox
moltzaum opened a new pull request #2605: TO Golang: Implemented Cachegroup Data Integrity Rules URL: https://github.com/apache/trafficcontrol/pull/2605 Will no longer delete cachegroup that is in use by either a server or asn. A database migration was also added that edits a delete

[GitHub] asfgit commented on issue #2605: TO Golang: Implemented Cachegroup Data Integrity Rules

2018-08-01 Thread GitBox
asfgit commented on issue #2605: TO Golang: Implemented Cachegroup Data Integrity Rules URL: https://github.com/apache/trafficcontrol/pull/2605#issuecomment-409662984 Can one of the admins verify this patch? This is an

[GitHub] rawlinp commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer)

2018-08-01 Thread GitBox
rawlinp commented on a change in pull request #2545: Update TO Go cdns/:name/federations (CRUDer) URL: https://github.com/apache/trafficcontrol/pull/2545#discussion_r206932464 ## File path: docs/source/api/v13/federation.rst ## @@ -0,0 +1,449 @@ +.. Review comment:

[GitHub] rivasj opened a new pull request #2609: Manage Static DNS Entries - front end CRUD implementation

2018-08-01 Thread GitBox
rivasj opened a new pull request #2609: Manage Static DNS Entries - front end CRUD implementation URL: https://github.com/apache/trafficcontrol/pull/2609 This is an automated message from the Apache Git Service. To respond

[GitHub] DylanVolz opened a new pull request #2611: fix tests broken by auth refactor

2018-08-01 Thread GitBox
DylanVolz opened a new pull request #2611: fix tests broken by auth refactor URL: https://github.com/apache/trafficcontrol/pull/2611 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] elsloo closed pull request #2611: fix tests broken by auth refactor

2018-08-01 Thread GitBox
elsloo closed pull request #2611: fix tests broken by auth refactor URL: https://github.com/apache/trafficcontrol/pull/2611 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] asfgit commented on issue #2606: Updates 'grovetccfg' to to write a grove.cfg from the grove servers profile

2018-08-01 Thread GitBox
asfgit commented on issue #2606: Updates 'grovetccfg' to to write a grove.cfg from the grove servers profile URL: https://github.com/apache/trafficcontrol/pull/2606#issuecomment-409697623 Refer to this link for build results (access rights to CI server needed):

[GitHub] DylanVolz opened a new pull request #2608: remove the prepared transaction from the auth wrapper that was a bott…

2018-08-01 Thread GitBox
DylanVolz opened a new pull request #2608: remove the prepared transaction from the auth wrapper that was a bott… URL: https://github.com/apache/trafficcontrol/pull/2608 …leneck This is an automated message from the Apache

[GitHub] asfgit commented on issue #2609: Manage Static DNS Entries - front end CRUD implementation

2018-08-01 Thread GitBox
asfgit commented on issue #2609: Manage Static DNS Entries - front end CRUD implementation URL: https://github.com/apache/trafficcontrol/pull/2609#issuecomment-409727054 Refer to this link for build results (access rights to CI server needed):

[GitHub] elsloo closed pull request #2608: remove the prepared transaction from the auth wrapper that was a bottleneck

2018-08-01 Thread GitBox
elsloo closed pull request #2608: remove the prepared transaction from the auth wrapper that was a bottleneck URL: https://github.com/apache/trafficcontrol/pull/2608 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] elsloo commented on issue #2604: Add TR failover for TM CRConfig

2018-08-01 Thread GitBox
elsloo commented on issue #2604: Add TR failover for TM CRConfig URL: https://github.com/apache/trafficcontrol/issues/2604#issuecomment-409707957 In Traffic Router, we do not latch onto a failed server, and will continue trying to use the other servers that are available. We could

[GitHub] jrushford opened a new issue #2607: grovetccfg does not update the grove.cfg file

2018-08-01 Thread GitBox
jrushford opened a new issue #2607: grovetccfg does not update the grove.cfg file URL: https://github.com/apache/trafficcontrol/issues/2607 grovetccfg is the grove equivalent of the ort script. currently it only reads ip_allow parameters from a grove servers profile and only build remap

<    5   6   7   8   9   10   11   12   13   14   >