[GitHub] [trafficcontrol] ocket8888 opened a new pull request, #7210: APIv5 Delivery Service updates for Traffic Portal

2022-11-19 Thread GitBox
ocket opened a new pull request, #7210: URL: https://github.com/apache/trafficcontrol/pull/7210 Primarily the motivation of this PR was to support the change of the "Active" property of Delivery Services from a boolean to an enumerated constant. More generally, though, that means using

[GitHub] [trafficcontrol] ocket8888 merged pull request #7209: Dev-CiaB: Run db/admin as root

2022-11-18 Thread GitBox
ocket merged PR #7209: URL: https://github.com/apache/trafficcontrol/pull/7209 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] zrhoffman opened a new pull request, #7209: Dev-CiaB: Run db/admin as root

2022-11-18 Thread GitBox
zrhoffman opened a new pull request, #7209: URL: https://github.com/apache/trafficcontrol/pull/7209 This PR addresses #7202 for CDN in a Box for Developers specifically by making `db/admin` run as root before de-escalating to the unprivileged user that runs `traffic_ops_golang`.

[GitHub] [trafficcontrol] zrhoffman merged pull request #7208: TP fix syntax issue with ciab tp integration tests

2022-11-18 Thread GitBox
zrhoffman merged PR #7208: URL: https://github.com/apache/trafficcontrol/pull/7208 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] shamrickus opened a new pull request, #7208: TP fix syntax issue with ciab tp integration tests

2022-11-18 Thread GitBox
shamrickus opened a new pull request, #7208: URL: https://github.com/apache/trafficcontrol/pull/7208 This PR fixes a syntax issue with the ciab integration tp tests ## Which Traffic Control components are affected by this PR? - CDN in a Box ## What is the

[GitHub] [trafficcontrol] zrhoffman commented on pull request #7206: Relax TP integration ciab test timeouts

2022-11-18 Thread GitBox
zrhoffman commented on PR #7206: URL: https://github.com/apache/trafficcontrol/pull/7206#issuecomment-1320522886 This causes an error actually ```jq $ jq ' \ .capabilities.chromeOptions.args += [ \ "--disable-extensions", \

[GitHub] [trafficcontrol] zrhoffman merged pull request #7207: TP update dependencies to latest minor version.

2022-11-18 Thread GitBox
zrhoffman merged PR #7207: URL: https://github.com/apache/trafficcontrol/pull/7207 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] zrhoffman merged pull request #7206: Relax TP integration ciab test timeouts

2022-11-18 Thread GitBox
zrhoffman merged PR #7206: URL: https://github.com/apache/trafficcontrol/pull/7206 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] zrhoffman commented on pull request #7207: TP update dependencies to latest minor version.

2022-11-18 Thread GitBox
zrhoffman commented on PR #7207: URL: https://github.com/apache/trafficcontrol/pull/7207#issuecomment-1320464885 This has conflicts, since #7187 added dependencies -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7205: TR: use hostname from CRConfig if only a single TR in CRConfig

2022-11-18 Thread GitBox
ocket commented on code in PR #7205: URL: https://github.com/apache/trafficcontrol/pull/7205#discussion_r1026787434 ## traffic_router/core/src/main/java/org/apache/traffic_control/traffic_router/core/dns/ZoneManager.java: ## @@ -453,6 +454,17 @@ private static List

[GitHub] [trafficcontrol] zrhoffman merged pull request #7205: TR: use hostname from CRConfig if only a single TR in CRConfig

2022-11-18 Thread GitBox
zrhoffman merged PR #7205: URL: https://github.com/apache/trafficcontrol/pull/7205 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] zrhoffman commented on pull request #7205: TR: use hostname from CRConfig if only a single TR in CRConfig

2022-11-18 Thread GitBox
zrhoffman commented on PR #7205: URL: https://github.com/apache/trafficcontrol/pull/7205#issuecomment-1320360802 *TR Ultimate Test Harness* workflow fails until #7202 is addressed for CDN in a Box for developers -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7205: TR: use hostname from CRConfig if only a single TR in CRConfig

2022-11-18 Thread GitBox
zrhoffman commented on code in PR #7205: URL: https://github.com/apache/trafficcontrol/pull/7205#discussion_r1026738995 ## traffic_router/core/src/main/java/org/apache/traffic_control/traffic_router/core/dns/ZoneManager.java: ## @@ -453,6 +454,17 @@ private static List

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7187: Minimize Snapshot diff for Server Server Capabilities

2022-11-18 Thread GitBox
ocket commented on code in PR #7187: URL: https://github.com/apache/trafficcontrol/pull/7187#discussion_r1026721927 ## traffic_portal/app/src/common/service/utils/CollectionUtils.js: ## @@ -19,6 +19,39 @@ var CollectionUtils = function() { + // minimizeArrayDiff

[GitHub] [trafficcontrol] ocket8888 closed issue #7113: Assigning a new Server Server capability changes SSC order in the Snapshot for that Server

2022-11-18 Thread GitBox
ocket closed issue #7113: Assigning a new Server Server capability changes SSC order in the Snapshot for that Server URL: https://github.com/apache/trafficcontrol/issues/7113 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [trafficcontrol] ocket8888 merged pull request #7187: Minimize Snapshot diff for Server Server Capabilities

2022-11-18 Thread GitBox
ocket merged PR #7187: URL: https://github.com/apache/trafficcontrol/pull/7187 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] shamrickus opened a new pull request, #7207: TP update dependencies to latest minor version.

2022-11-18 Thread GitBox
shamrickus opened a new pull request, #7207: URL: https://github.com/apache/trafficcontrol/pull/7207 This PR updates TP dependencies to the latest minor version (no breaking changes). It also fixes an audit vulnerability in the TP integration tests. ## Which Traffic

[GitHub] [trafficcontrol] zrhoffman closed issue #3746: Fix DS "ACTIVE" flag to work as expected

2022-11-18 Thread GitBox
zrhoffman closed issue #3746: Fix DS "ACTIVE" flag to work as expected URL: https://github.com/apache/trafficcontrol/issues/3746 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [trafficcontrol] zrhoffman merged pull request #7099: Delivery Service Active Flag Rework

2022-11-18 Thread GitBox
zrhoffman merged PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] rimashah25 commented on pull request #7187: Minimize Snapshot diff for Server Server Capabilities

2022-11-18 Thread GitBox
rimashah25 commented on PR #7187: URL: https://github.com/apache/trafficcontrol/pull/7187#issuecomment-1320280005 Can be merged once TP tests pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [trafficcontrol] shamrickus opened a new pull request, #7206: Relax TP integration ciab test timeouts

2022-11-18 Thread GitBox
shamrickus opened a new pull request, #7206: URL: https://github.com/apache/trafficcontrol/pull/7206 This PR relaxes some timeouts in the ciab TP integration test container to help make tests less flakey when running the full ATC suite of ciab tests/builds. ## Which

[GitHub] [trafficcontrol] rawlinp opened a new pull request, #7205: TR: use hostname from CRConfig if only a single TR in CRConfig

2022-11-17 Thread GitBox
rawlinp opened a new pull request, #7205: URL: https://github.com/apache/trafficcontrol/pull/7205 In situations where there is only a single TR in the CRConfig but actually multiple TRs in the system, using the server hostname in zone generation leads to the creation of invalid mname

[GitHub] [trafficcontrol] ocket8888 commented on issue #7202: Traffic Ops `db/admin` tool depends on passwordless DB connection as `root` user

2022-11-17 Thread GitBox
ocket commented on issue #7202: URL: https://github.com/apache/trafficcontrol/issues/7202#issuecomment-1319326046 The number of issues isn't important to me, just want to be sure both are fixed. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [trafficcontrol] ocket8888 merged pull request #7150: Retract versions v1.1.0 through v1.1.5 from Go modules

2022-11-17 Thread GitBox
ocket merged PR #7150: URL: https://github.com/apache/trafficcontrol/pull/7150 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] zrhoffman commented on issue #7202: Traffic Ops `db/admin` tool depends on passwordless DB connection as `root` user

2022-11-17 Thread GitBox
zrhoffman commented on issue #7202: URL: https://github.com/apache/trafficcontrol/issues/7202#issuecomment-1319162713 Got it. I'm not sure how to describe one of those 2 points without describing the other, since both cases are related to Postgres default installations, but if you think

[GitHub] [trafficcontrol] traeak opened a new pull request, #7204: t3c: strategies.yaml has_key only for consistent_hash

2022-11-17 Thread GitBox
traeak opened a new pull request, #7204: URL: https://github.com/apache/trafficcontrol/pull/7204 The t3c strategies.yaml file when generating a strategy always populates the hash_key yaml field although it only applies to consistent_hash policy. Currently with this

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7099: Delivery Service Active Flag Rework

2022-11-17 Thread GitBox
rimashah25 commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1025644688 ## traffic_ops/testing/api/utils/utils.go: ## @@ -119,7 +130,7 @@ type V3TestData struct { // V3TestDataT represents the data needed for testing the v3

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7099: Delivery Service Active Flag Rework

2022-11-17 Thread GitBox
ocket commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1025641073 ## traffic_ops/testing/api/utils/utils.go: ## @@ -129,7 +140,7 @@ type V3TestDataT[B any] struct { // V4TestData represents the data needed for testing the

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7099: Delivery Service Active Flag Rework

2022-11-17 Thread GitBox
ocket commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1025640302 ## traffic_ops/testing/api/utils/utils.go: ## @@ -119,7 +130,7 @@ type V3TestData struct { // V3TestDataT represents the data needed for testing the v3 api

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7099: Delivery Service Active Flag Rework

2022-11-17 Thread GitBox
zrhoffman commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1025629258 ## traffic_ops/testing/api/utils/utils.go: ## @@ -119,7 +130,7 @@ type V3TestData struct { // V3TestDataT represents the data needed for testing the v3 api

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7099: Delivery Service Active Flag Rework

2022-11-17 Thread GitBox
ocket commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1025615404 ## traffic_ops/testing/api/utils/utils.go: ## @@ -119,7 +130,7 @@ type V3TestData struct { // V3TestDataT represents the data needed for testing the v3 api

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7099: Delivery Service Active Flag Rework

2022-11-17 Thread GitBox
zrhoffman commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1025615043 ## traffic_ops/testing/api/utils/utils.go: ## @@ -119,7 +130,7 @@ type V3TestData struct { // V3TestDataT represents the data needed for testing the v3 api

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7099: Delivery Service Active Flag Rework

2022-11-17 Thread GitBox
ocket commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1025603512 ## traffic_ops/traffic_ops_golang/crconfig/deliveryservice.go: ## @@ -145,7 +145,7 @@ FROM deliveryservice AS d INNER JOIN type AS t ON t.id = d.type LEFT

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7099: Delivery Service Active Flag Rework

2022-11-17 Thread GitBox
zrhoffman commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1025600442 ## traffic_ops/testing/api/utils/utils.go: ## @@ -119,7 +130,7 @@ type V3TestData struct { // V3TestDataT represents the data needed for testing the v3 api

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7099: Delivery Service Active Flag Rework

2022-11-17 Thread GitBox
zrhoffman commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1025600442 ## traffic_ops/testing/api/utils/utils.go: ## @@ -119,7 +130,7 @@ type V3TestData struct { // V3TestDataT represents the data needed for testing the v3 api

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7099: Delivery Service Active Flag Rework

2022-11-17 Thread GitBox
zrhoffman commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1025592447 ## traffic_ops/traffic_ops_golang/crconfig/deliveryservice.go: ## @@ -145,7 +145,7 @@ FROM deliveryservice AS d INNER JOIN type AS t ON t.id = d.type LEFT

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7099: Delivery Service Active Flag Rework

2022-11-17 Thread GitBox
zrhoffman commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1025573120 ## traffic_ops/testing/api/utils/utils.go: ## @@ -119,7 +130,7 @@ type V3TestData struct { // V3TestDataT represents the data needed for testing the v3 api

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7099: Delivery Service Active Flag Rework

2022-11-17 Thread GitBox
rimashah25 commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1025568063 ## traffic_ops/testing/api/utils/utils.go: ## @@ -119,7 +130,7 @@ type V3TestData struct { // V3TestDataT represents the data needed for testing the v3

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7099: Delivery Service Active Flag Rework

2022-11-17 Thread GitBox
ocket commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1025558560 ## traffic_ops/traffic_ops_golang/crconfig/deliveryservice.go: ## @@ -145,7 +145,7 @@ FROM deliveryservice AS d INNER JOIN type AS t ON t.id = d.type LEFT

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7099: Delivery Service Active Flag Rework

2022-11-17 Thread GitBox
zrhoffman commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1025419058 ## lib/go-tc/copy.go: ## @@ -0,0 +1,112 @@ +package tc Review Comment: `copy.go` belongs in the `go-util` package -- This is an automated message from

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7099: Delivery Service Active Flag Rework

2022-11-17 Thread GitBox
zrhoffman commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1025557008 ## lib/go-tc/copy.go: ## @@ -0,0 +1,112 @@ +package tc Review Comment: That's true. What you did is definitely an improvement already, so maybe someone

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7099: Delivery Service Active Flag Rework

2022-11-17 Thread GitBox
zrhoffman commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1025548842 ## traffic_ops/testing/api/utils/utils.go: ## @@ -119,7 +130,7 @@ type V3TestData struct { // V3TestDataT represents the data needed for testing the v3 api

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7099: Delivery Service Active Flag Rework

2022-11-17 Thread GitBox
ocket commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1025546374 ## lib/go-tc/copy.go: ## @@ -0,0 +1,112 @@ +package tc Review Comment: In order for that to be true, it would need to change to exported utilities and

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7099: Delivery Service Active Flag Rework

2022-11-17 Thread GitBox
zrhoffman commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1025539566 ## traffic_ops/testing/api/utils/utils.go: ## @@ -119,7 +130,7 @@ type V3TestData struct { // V3TestDataT represents the data needed for testing the v3 api

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7099: Delivery Service Active Flag Rework

2022-11-17 Thread GitBox
zrhoffman commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1025539566 ## traffic_ops/testing/api/utils/utils.go: ## @@ -119,7 +130,7 @@ type V3TestData struct { // V3TestDataT represents the data needed for testing the v3 api

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7099: Delivery Service Active Flag Rework

2022-11-17 Thread GitBox
rimashah25 commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1025538561 ## traffic_ops/testing/api/utils/utils.go: ## @@ -119,7 +130,7 @@ type V3TestData struct { // V3TestDataT represents the data needed for testing the v3

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7099: Delivery Service Active Flag Rework

2022-11-17 Thread GitBox
zrhoffman commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1025536834 ## traffic_ops/testing/api/utils/utils.go: ## @@ -119,7 +130,7 @@ type V3TestData struct { // V3TestDataT represents the data needed for testing the v3 api

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7099: Delivery Service Active Flag Rework

2022-11-17 Thread GitBox
rimashah25 commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1025532355 ## traffic_ops/testing/api/utils/utils.go: ## @@ -86,29 +94,32 @@ func Compare(t *testing.T, expected []string, alertsStrs []string) { } //

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7099: Delivery Service Active Flag Rework

2022-11-17 Thread GitBox
rimashah25 commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1025534716 ## traffic_ops/testing/api/utils/utils.go: ## @@ -157,7 +168,7 @@ type requestOpts interface { // TestData represents the data needed for testing the api

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7099: Delivery Service Active Flag Rework

2022-11-17 Thread GitBox
rimashah25 commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1025532466 ## traffic_ops/testing/api/utils/utils.go: ## @@ -119,7 +130,7 @@ type V3TestData struct { // V3TestDataT represents the data needed for testing the v3

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7099: Delivery Service Active Flag Rework

2022-11-17 Thread GitBox
rimashah25 commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1025533866 ## traffic_ops/testing/api/utils/utils.go: ## @@ -129,7 +140,7 @@ type V3TestDataT[B any] struct { // V4TestData represents the data needed for testing

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7099: Delivery Service Active Flag Rework

2022-11-17 Thread GitBox
rimashah25 commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1025532355 ## traffic_ops/testing/api/utils/utils.go: ## @@ -86,29 +94,32 @@ func Compare(t *testing.T, expected []string, alertsStrs []string) { } //

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7099: Delivery Service Active Flag Rework

2022-11-17 Thread GitBox
zrhoffman commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1025419058 ## lib/go-tc/copy.go: ## @@ -0,0 +1,112 @@ +package tc Review Comment: `copy.go` belongs in the `go-utils` package ##

[GitHub] [trafficcontrol] ocket8888 commented on pull request #7099: Delivery Service Active Flag Rework

2022-11-17 Thread GitBox
ocket commented on PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#issuecomment-1318960434 Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [trafficcontrol] shamrickus opened a new pull request, #7203: TPv2: Add Divisions Pages

2022-11-17 Thread GitBox
shamrickus opened a new pull request, #7203: URL: https://github.com/apache/trafficcontrol/pull/7203 This PR adds the Divisions table & edit pages to TPv2. It also updates nightwatch and loosens versioning restriction in `package.json` to allow for up-to minor version updates.

[GitHub] [trafficcontrol] ocket8888 commented on issue #7202: Traffic Ops `db/admin` tool depends on passwordless DB connection as `root` user

2022-11-17 Thread GitBox
ocket commented on issue #7202: URL: https://github.com/apache/trafficcontrol/issues/7202#issuecomment-1318933443 idk the way I see it there are two issues * `admin` should not depend on passwordless authentication for its database connections * `admin` should not require

[GitHub] [trafficcontrol] zrhoffman commented on issue #7202: Traffic Ops `db/admin` tool depends on passwordless DB connection as `root` user

2022-11-17 Thread GitBox
zrhoffman commented on issue #7202: URL: https://github.com/apache/trafficcontrol/issues/7202#issuecomment-1318928052 > If the title is strictly true, then the tool doesn't depend on passwordless DB connections when not run as the root user The tool didn't depend on password DB

[GitHub] [trafficcontrol] ocket8888 commented on issue #7202: Traffic Ops `db/admin` tool depends on passwordless DB connection as `root` user

2022-11-17 Thread GitBox
ocket commented on issue #7202: URL: https://github.com/apache/trafficcontrol/issues/7202#issuecomment-1318919316 I do not. If it's true that db/admin requires you to run it as the root user, that's also an issue IMO. -- This is an automated message from the Apache Git Service. To

[GitHub] [trafficcontrol] zrhoffman commented on issue #7202: Traffic Ops `db/admin` tool depends on passwordless DB connection as `root` user

2022-11-17 Thread GitBox
zrhoffman commented on issue #7202: URL: https://github.com/apache/trafficcontrol/issues/7202#issuecomment-1318909426 It sounds like you know what I mean, feel free to change the title to whatever you feel is accurate -- This is an automated message from the Apache Git Service. To

[GitHub] [trafficcontrol] ocket8888 commented on issue #7202: Traffic Ops `db/admin` tool depends on passwordless DB connection as `root` user

2022-11-17 Thread GitBox
ocket commented on issue #7202: URL: https://github.com/apache/trafficcontrol/issues/7202#issuecomment-1318904033 If the title is strictly true, then the tool doesn't depend on passwordless DB connections when not run as the root user -- This is an automated message from the Apache

[GitHub] [trafficcontrol] zrhoffman commented on issue #7202: Traffic Ops `db/admin` tool depends on passwordless DB connection as `root` user

2022-11-17 Thread GitBox
zrhoffman commented on issue #7202: URL: https://github.com/apache/trafficcontrol/issues/7202#issuecomment-1318879427 Not sure what the difference between *strictly true* and *`db/admin` depends on the calling user to be the root user* is, but they both seem true to me. Notice how

[GitHub] [trafficcontrol] rimashah25 commented on pull request #7195: Added backward compatibility for renaming rascal to traffic monitor

2022-11-17 Thread GitBox
rimashah25 commented on PR #7195: URL: https://github.com/apache/trafficcontrol/pull/7195#issuecomment-1318872116 Closed since the changes were reverted in #7190 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [trafficcontrol] rimashah25 closed pull request #7195: Added backward compatibility for renaming rascal to traffic monitor

2022-11-17 Thread GitBox
rimashah25 closed pull request #7195: Added backward compatibility for renaming rascal to traffic monitor URL: https://github.com/apache/trafficcontrol/pull/7195 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [trafficcontrol] zrhoffman commented on pull request #7099: Delivery Service Active Flag Rework

2022-11-17 Thread GitBox
zrhoffman commented on PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#issuecomment-1318859077 There's a merge conflict in the changelog -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [trafficcontrol] rimashah25 commented on pull request #7099: Delivery Service Active Flag Rework

2022-11-17 Thread GitBox
rimashah25 commented on PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#issuecomment-1318857208 LGTM, ready for a merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [trafficcontrol] ocket8888 commented on issue #7202: Traffic Ops `db/admin` tool depends on passwordless DB connection as `root` user

2022-11-17 Thread GitBox
ocket commented on issue #7202: URL: https://github.com/apache/trafficcontrol/issues/7202#issuecomment-1318852997 Is > Traffic Ops `db/admin` tool depends on passwordless DB connection as root user strictly true, or is it the case that `db/admin` depends on the calling

[GitHub] [trafficcontrol] zrhoffman merged pull request #7192: update health-client to v4 API

2022-11-17 Thread GitBox
zrhoffman merged PR #7192: URL: https://github.com/apache/trafficcontrol/pull/7192 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] zrhoffman closed issue #7191: tc-health-client update to v4 API

2022-11-17 Thread GitBox
zrhoffman closed issue #7191: tc-health-client update to v4 API URL: https://github.com/apache/trafficcontrol/issues/7191 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [trafficcontrol] zrhoffman opened a new issue, #7202: Traffic Ops `db/admin` tool depends on passwordless DB connection as `root` user

2022-11-17 Thread GitBox
zrhoffman opened a new issue, #7202: URL: https://github.com/apache/trafficcontrol/issues/7202 ## This Improvement request (usability, performance, tech debt, etc.) affects these Traffic Control components: - Traffic Ops ## Current behavior: The Traffic Ops

[GitHub] [trafficcontrol] jpappa200 commented on a diff in pull request #7192: update health-client to v4 API

2022-11-17 Thread GitBox
jpappa200 commented on code in PR #7192: URL: https://github.com/apache/trafficcontrol/pull/7192#discussion_r1025268669 ## lib/go-tc/enum.go: ## @@ -143,6 +143,15 @@ const MonitorTypeName = "TRAFFIC_MONITOR" // properly, and new code should not check this. const

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7192: update health-client to v4 API

2022-11-16 Thread GitBox
zrhoffman commented on code in PR #7192: URL: https://github.com/apache/trafficcontrol/pull/7192#discussion_r1024587976 ## tc-health-client/tmagent/tmagent.go: ## @@ -656,7 +656,7 @@ func (pi *ParentInfo) GetTOData(cfg *config.Cfg) error { if *sv.CDNName !=

[GitHub] [trafficcontrol] ocket8888 merged pull request #7190: Revert Traffic Monitor renaming to rascal

2022-11-16 Thread GitBox
ocket merged PR #7190: URL: https://github.com/apache/trafficcontrol/pull/7190 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] ocket8888 merged pull request #7182: t3c: sort peers in strategies.yaml

2022-11-16 Thread GitBox
ocket merged PR #7182: URL: https://github.com/apache/trafficcontrol/pull/7182 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] ocket8888 commented on pull request #7194: Added catch for missing POST body when posted to profileparameters

2022-11-16 Thread GitBox
ocket commented on PR #7194: URL: https://github.com/apache/trafficcontrol/pull/7194#issuecomment-1317676090 > I don't think there's anything you can put in for `RequestBody` that will do what you want. Actually, I take that back. [It's actually fairly easy to create a type that

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7194: Added catch for missing POST body when posted to profileparameters

2022-11-16 Thread GitBox
ocket commented on code in PR #7194: URL: https://github.com/apache/trafficcontrol/pull/7194#discussion_r1024507202 ## traffic_ops/testing/api/v4/profile_parameters_test.go: ## @@ -76,6 +76,11 @@ func TestProfileParameters(t *testing.T) {

[GitHub] [trafficcontrol] shamrickus merged pull request #7199: Bump minimatch from 3.0.4 to 3.1.2 in /traffic_portal/test/integration

2022-11-16 Thread GitBox
shamrickus merged PR #7199: URL: https://github.com/apache/trafficcontrol/pull/7199 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] shamrickus merged pull request #7200: Bump minimatch from 3.0.4 to 3.1.2 in /traffic_portal/app/src

2022-11-16 Thread GitBox
shamrickus merged PR #7200: URL: https://github.com/apache/trafficcontrol/pull/7200 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] shamrickus merged pull request #7197: Bump loader-utils from 2.0.3 to 2.0.4 in /experimental/traffic-portal

2022-11-16 Thread GitBox
shamrickus merged PR #7197: URL: https://github.com/apache/trafficcontrol/pull/7197 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] zrhoffman commented on pull request #7150: Retract versions v1.1.0 through v1.1.5 from Go modules

2022-11-16 Thread GitBox
zrhoffman commented on PR #7150: URL: https://github.com/apache/trafficcontrol/pull/7150#issuecomment-1317557150 Rebased to get the t3c test nonbreakage from #7198 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [trafficcontrol] dependabot[bot] opened a new pull request, #7201: Bump minimatch and nightwatch in /experimental/traffic-portal

2022-11-16 Thread GitBox
dependabot[bot] opened a new pull request, #7201: URL: https://github.com/apache/trafficcontrol/pull/7201 Bumps [minimatch](https://github.com/isaacs/minimatch) to 3.1.2 and updates ancestor dependency [nightwatch](https://github.com/nightwatchjs/nightwatch). These dependencies need to be

[GitHub] [trafficcontrol] dependabot[bot] opened a new pull request, #7200: Bump minimatch from 3.0.4 to 3.1.2 in /traffic_portal/app/src

2022-11-16 Thread GitBox
dependabot[bot] opened a new pull request, #7200: URL: https://github.com/apache/trafficcontrol/pull/7200 Bumps [minimatch](https://github.com/isaacs/minimatch) from 3.0.4 to 3.1.2. Commits

[GitHub] [trafficcontrol] dependabot[bot] opened a new pull request, #7199: Bump minimatch from 3.0.4 to 3.1.2 in /traffic_portal/test/integration

2022-11-16 Thread GitBox
dependabot[bot] opened a new pull request, #7199: URL: https://github.com/apache/trafficcontrol/pull/7199 Bumps [minimatch](https://github.com/isaacs/minimatch) from 3.0.4 to 3.1.2. Commits

[GitHub] [trafficcontrol] srijeet0406 merged pull request #7198: Revert setting `PGPASSWORD` for entire db/admin binary

2022-11-16 Thread GitBox
srijeet0406 merged PR #7198: URL: https://github.com/apache/trafficcontrol/pull/7198 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] zrhoffman opened a new pull request, #7198: Revert setting `PGPASSWORD` for entire db/admin binary

2022-11-16 Thread GitBox
zrhoffman opened a new pull request, #7198: URL: https://github.com/apache/trafficcontrol/pull/7198 This PR reverts [`25483428a5`](https://github.com/apache/trafficcontrol/pull/7142/commits/25483428a53b3a2f0fdc1ca5e28f7992b91cb716), a commit in #7142 that set the `PGPASSWORD`

[GitHub] [trafficcontrol] ocket8888 closed issue #7046: POST /deliveryservices/sslkeys/add accepts unrelated certificates

2022-11-16 Thread GitBox
ocket closed issue #7046: POST /deliveryservices/sslkeys/add accepts unrelated certificates URL: https://github.com/apache/trafficcontrol/issues/7046 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [trafficcontrol] ocket8888 merged pull request #7136: TO `deliveryservice/sslkeys/add` verify certificate chain

2022-11-16 Thread GitBox
ocket merged PR #7136: URL: https://github.com/apache/trafficcontrol/pull/7136 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7187: Minimize Snapshot diff for Server Server Capabilities

2022-11-16 Thread GitBox
zrhoffman commented on code in PR #7187: URL: https://github.com/apache/trafficcontrol/pull/7187#discussion_r1024232010 ## .github/workflows/tp.integration.tests.yml: ## @@ -92,14 +128,14 @@ jobs: - name: Checkout uses: actions/checkout@master - name:

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7187: Minimize Snapshot diff for Server Server Capabilities

2022-11-16 Thread GitBox
rimashah25 commented on code in PR #7187: URL: https://github.com/apache/trafficcontrol/pull/7187#discussion_r1024228952 ## .github/workflows/tp.integration.tests.yml: ## @@ -92,14 +128,14 @@ jobs: - name: Checkout uses: actions/checkout@master - name:

[GitHub] [trafficcontrol] dependabot[bot] opened a new pull request, #7197: Bump loader-utils from 2.0.3 to 2.0.4 in /experimental/traffic-portal

2022-11-15 Thread GitBox
dependabot[bot] opened a new pull request, #7197: URL: https://github.com/apache/trafficcontrol/pull/7197 Bumps [loader-utils](https://github.com/webpack/loader-utils) from 2.0.3 to 2.0.4. Release notes Sourced from https://github.com/webpack/loader-utils/releases;>loader-utils's

[GitHub] [trafficcontrol] zrhoffman commented on pull request #7150: Retract versions v1.1.0 through v1.1.5 from Go modules

2022-11-15 Thread GitBox
zrhoffman commented on PR #7150: URL: https://github.com/apache/trafficcontrol/pull/7150#issuecomment-1315977312 Rebased onto latest master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [trafficcontrol] mitchell852 commented on issue #979: [TC-553] Queue updates API queues updates on all servers, not just caches

2022-11-15 Thread GitBox
mitchell852 commented on issue #979: URL: https://github.com/apache/trafficcontrol/issues/979#issuecomment-1315892547 there is a challenge with this however. how does one know what is a "cache" and what is not a cache? that needs to be figured out before this can be fixed imo. -- This

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7194: Added catch for missing POST body when posted to profileparameters

2022-11-15 Thread GitBox
ocket commented on code in PR #7194: URL: https://github.com/apache/trafficcontrol/pull/7194#discussion_r1023267170 ## traffic_ops/testing/api/conf/traffic-ops-test.conf: ## @@ -1,40 +0,0 @@ -{ -"default": { -"logLocations": { -"debug": "stdout", -

[GitHub] [trafficcontrol] smalenfant opened a new issue, #7196: traffic_stats: seelog is deprecated but still include configuration and files

2022-11-15 Thread GitBox
smalenfant opened a new issue, #7196: URL: https://github.com/apache/trafficcontrol/issues/7196 ## This Bug Report affects these Traffic Control components: - Traffic Stats ## Current behavior: Traffic Stats (6.1+) includes deprecated configuration (seelog) ##

[GitHub] [trafficcontrol] zrhoffman commented on issue #3430: Traffic Portal: Doesn't allow wildcard DNS static entries

2022-11-15 Thread GitBox
zrhoffman commented on issue #3430: URL: https://github.com/apache/trafficcontrol/issues/3430#issuecomment-1315627421 Relabeled #3430 as a Traffic Ops issue, since the validation message is coming from TO, not TP. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [trafficcontrol] zrhoffman commented on issue #3703: TP: User is able to assign physical location that is not related to Cache group lat and long for a server.

2022-11-15 Thread GitBox
zrhoffman commented on issue #3703: URL: https://github.com/apache/trafficcontrol/issues/3703#issuecomment-1315618916 @lbathina @mitchell852 It sounds like we don't need Phys Location/Cache Group coordinate parity valiation. Can #3703 be closed? -- This is an automated message from the

[GitHub] [trafficcontrol] zrhoffman commented on issue #2731: Disable ability to change your own Role and Tenant in the User Profile

2022-11-15 Thread GitBox
zrhoffman commented on issue #2731: URL: https://github.com/apache/trafficcontrol/issues/2731#issuecomment-1315613475 @chadgilloth Are you still able to reproduce #2731 now that Roles and Permissions were reworked in ATC 6.0.0? -- This is an automated message from the Apache Git

[GitHub] [trafficcontrol] zrhoffman commented on issue #3541: View servers that employ a certain parameter

2022-11-15 Thread GitBox
zrhoffman commented on issue #3541: URL: https://github.com/apache/trafficcontrol/issues/3541#issuecomment-1315598390 I believe Traffic Portal has this feature now. Would you please confirm? -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [trafficcontrol] ocket8888 closed issue #3433: Types: Missing auto-populating Use-in-Table field

2022-11-15 Thread GitBox
ocket closed issue #3433: Types: Missing auto-populating Use-in-Table field URL: https://github.com/apache/trafficcontrol/issues/3433 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [trafficcontrol] ocket8888 commented on issue #3433: Types: Missing auto-populating Use-in-Table field

2022-11-15 Thread GitBox
ocket commented on issue #3433: URL: https://github.com/apache/trafficcontrol/issues/3433#issuecomment-1315597691 I don't believe this is relevant any longer, since only server types can be created through the API -- This is an automated message from the Apache Git Service. To

[GitHub] [trafficcontrol] rimashah25 opened a new pull request, #7195: Added backward compatibility for renaming rascal to traffic monitor

2022-11-14 Thread GitBox
rimashah25 opened a new pull request, #7195: URL: https://github.com/apache/trafficcontrol/pull/7195 ## Which Traffic Control components are affected by this PR? - Traffic Ops ## What is the best way to verify this PR? Verify APIv3, APIv4 work well

<    1   2   3   4   5   6   7   8   9   10   >