[GitHub] [trafficcontrol] github-code-scanning[bot] commented on a diff in pull request #7161: DTP open sourcing

2022-10-31 Thread GitBox
github-code-scanning[bot] commented on code in PR #7161: URL: https://github.com/apache/trafficcontrol/pull/7161#discussion_r1009840274 ## test/fakeOrigin/dtp/dtp.go: ## @@ -0,0 +1,130 @@ +package dtp + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7099: Delivery Service Active Flag Rework

2022-10-31 Thread GitBox
rimashah25 commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1009828166 ## traffic_ops/traffic_ops_golang/deliveryservice/deliveryservices.go: ## @@ -138,7 +162,7 @@ func CreateV30(w http.ResponseWriter, r *http.Request) {

[GitHub] [trafficcontrol] ezelkow1 commented on a diff in pull request #7161: DTP open sourcing

2022-10-31 Thread GitBox
ezelkow1 commented on code in PR #7161: URL: https://github.com/apache/trafficcontrol/pull/7161#discussion_r1009826559 ## test/fakeOrigin/dtp/dtp.go: ## @@ -0,0 +1,144 @@ +package dtp + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor

[GitHub] [trafficcontrol] ezelkow1 commented on a diff in pull request #7161: DTP open sourcing

2022-10-31 Thread GitBox
ezelkow1 commented on code in PR #7161: URL: https://github.com/apache/trafficcontrol/pull/7161#discussion_r1009827162 ## test/fakeOrigin/dtp/dtp.go: ## @@ -0,0 +1,144 @@ +package dtp + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor

[GitHub] [trafficcontrol] ezelkow1 commented on a diff in pull request #7161: DTP open sourcing

2022-10-31 Thread GitBox
ezelkow1 commented on code in PR #7161: URL: https://github.com/apache/trafficcontrol/pull/7161#discussion_r1009826299 ## test/fakeOrigin/dtp/dtp.go: ## @@ -0,0 +1,144 @@ +package dtp + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor

[GitHub] [trafficcontrol] github-code-scanning[bot] commented on a diff in pull request #7161: DTP open sourcing

2022-10-31 Thread GitBox
github-code-scanning[bot] commented on code in PR #7161: URL: https://github.com/apache/trafficcontrol/pull/7161#discussion_r1009807225 ## test/fakeOrigin/dtp/dtp.go: ## @@ -0,0 +1,144 @@ +package dtp + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] [trafficcontrol] srijeet0406 closed issue #6033: Add ability to assign and remove a server capability for multiple servers at a time

2022-10-31 Thread GitBox
srijeet0406 closed issue #6033: Add ability to assign and remove a server capability for multiple servers at a time URL: https://github.com/apache/trafficcontrol/issues/6033 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [trafficcontrol] srijeet0406 merged pull request #7079: Assign multiple servers to a capability

2022-10-31 Thread GitBox
srijeet0406 merged PR #7079: URL: https://github.com/apache/trafficcontrol/pull/7079 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] zrhoffman commented on issue #6533: TR should not rename/recreate log files on rollover

2022-10-29 Thread GitBox
zrhoffman commented on issue #6533: URL: https://github.com/apache/trafficcontrol/issues/6533#issuecomment-1295962551 Assigned! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [trafficcontrol] villajo commented on issue #6533: TR should not rename/recreate log files on rollover

2022-10-29 Thread GitBox
villajo commented on issue #6533: URL: https://github.com/apache/trafficcontrol/issues/6533#issuecomment-1295961247 Can this be assigned to me? I'd like to take a crack at it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [trafficcontrol] srijeet0406 commented on a diff in pull request #7079: Assign multiple servers to a capability

2022-10-28 Thread GitBox
srijeet0406 commented on code in PR #7079: URL: https://github.com/apache/trafficcontrol/pull/7079#discussion_r1008285232 ## traffic_ops/traffic_ops_golang/server/servers_server_capability.go: ## @@ -453,77 +443,185 @@ func AssignMultipleServerCapabilities(w

[GitHub] [trafficcontrol] rob05c opened a new pull request, #7163: Fix t3c multiple profile generation

2022-10-28 Thread GitBox
rob05c opened a new pull request, #7163: URL: https://github.com/apache/trafficcontrol/pull/7163 Draft - temporarily not a draft to make tests run. ## Which Traffic Control components are affected by this PR? - Documentation - Traffic Control Cache Config

[GitHub] [trafficcontrol] srijeet0406 commented on a diff in pull request #7079: Assign multiple servers to a capability

2022-10-27 Thread GitBox
srijeet0406 commented on code in PR #7079: URL: https://github.com/apache/trafficcontrol/pull/7079#discussion_r1007454984 ## traffic_ops/traffic_ops_golang/server/servers_server_capability.go: ## @@ -453,77 +443,185 @@ func AssignMultipleServerCapabilities(w

[GitHub] [trafficcontrol] srijeet0406 commented on a diff in pull request #7079: Assign multiple servers to a capability

2022-10-27 Thread GitBox
srijeet0406 commented on code in PR #7079: URL: https://github.com/apache/trafficcontrol/pull/7079#discussion_r1007454708 ## traffic_ops/traffic_ops_golang/server/servers_server_capability.go: ## @@ -453,77 +443,185 @@ func AssignMultipleServerCapabilities(w

[GitHub] [trafficcontrol] ocket8888 merged pull request #7160: Consider DS Regional field for MaxOriginConnections of Edge Caches

2022-10-27 Thread GitBox
ocket merged PR #7160: URL: https://github.com/apache/trafficcontrol/pull/7160 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] zrhoffman commented on pull request #7162: updated tomcat version to 1.2.35

2022-10-27 Thread GitBox
zrhoffman commented on PR #7162: URL: https://github.com/apache/trafficcontrol/pull/7162#issuecomment-1293800151 Although this works, the next time the tomcat-native version is updated, it should be something like `tomcat-native-1.*`, since any tomcat-native version 1 will work (version 2

[GitHub] [trafficcontrol] zrhoffman merged pull request #7162: updated tomcat version to 1.2.35

2022-10-27 Thread GitBox
zrhoffman merged PR #7162: URL: https://github.com/apache/trafficcontrol/pull/7162 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] ragen14 opened a new pull request, #7162: updated tomcat version to 1.2.35

2022-10-27 Thread GitBox
ragen14 opened a new pull request, #7162: URL: https://github.com/apache/trafficcontrol/pull/7162 ## Which Traffic Control components are affected by this PR? - Traffic Router - Automation ## What is the best way to verify this PR? install

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7160: Consider DS Regional field for MaxOriginConnections of Edge Caches

2022-10-27 Thread GitBox
zrhoffman commented on code in PR #7160: URL: https://github.com/apache/trafficcontrol/pull/7160#discussion_r1007114313 ## lib/go-atscfg/headerrewritedotconfig_test.go: ## @@ -496,42 +407,91 @@ func TestGetAssignedMids(t *testing.T) { ID:

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7160: Consider DS Regional field for MaxOriginConnections of Edge Caches

2022-10-27 Thread GitBox
ocket commented on code in PR #7160: URL: https://github.com/apache/trafficcontrol/pull/7160#discussion_r1007048872 ## lib/go-atscfg/headerrewritedotconfig_test.go: ## @@ -496,42 +407,91 @@ func TestGetAssignedMids(t *testing.T) { ID:

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7099: Delivery Service Active Flag Rework

2022-10-27 Thread GitBox
rimashah25 commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1006437034 ## traffic_ops/testing/api/v4/tc-fixtures.json: ## @@ -907,7 +907,7 @@ "regexRemap": null, "regionalGeoBlocking": false,

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7099: Delivery Service Active Flag Rework

2022-10-27 Thread GitBox
rimashah25 commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1006436587 ## traffic_ops/v5-client/deliveryservice_requests.go: ## @@ -58,31 +58,31 @@ func (to *Session) CreateDeliveryServiceRequest(dsr

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7079: Assign multiple servers to a capability

2022-10-26 Thread GitBox
rimashah25 commented on code in PR #7079: URL: https://github.com/apache/trafficcontrol/pull/7079#discussion_r1006427072 ## traffic_ops/traffic_ops_golang/server/servers_server_capability.go: ## @@ -453,77 +443,185 @@ func AssignMultipleServerCapabilities(w

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7079: Assign multiple servers to a capability

2022-10-26 Thread GitBox
rimashah25 commented on code in PR #7079: URL: https://github.com/apache/trafficcontrol/pull/7079#discussion_r1006420423 ## traffic_ops/traffic_ops_golang/server/servers_server_capability.go: ## @@ -453,77 +443,185 @@ func AssignMultipleServerCapabilities(w

[GitHub] [trafficcontrol] ezelkow1 opened a new pull request, #7161: DTP open sourcing

2022-10-26 Thread GitBox
ezelkow1 opened a new pull request, #7161: URL: https://github.com/apache/trafficcontrol/pull/7161 This PR open sources our internal testing tool, DTP. Originally DTP was a stand alone origin that can provide origin responses based on query parameters to simulate a variety of

[GitHub] [trafficcontrol] zrhoffman opened a new pull request, #7160: Consider DS Regional field for MaxOriginConnections of Edge Caches

2022-10-26 Thread GitBox
zrhoffman opened a new pull request, #7160: URL: https://github.com/apache/trafficcontrol/pull/7160 This PR fixes a bug where MaxOriginConnections for a *Regional* Delivery Service was not divided over a Server's own Cache Group in the case of Edge Caches directly parented by the

[GitHub] [trafficcontrol] traeak commented on pull request #7155: t3c: initial mustache for remap.config templating

2022-10-26 Thread GitBox
traeak commented on PR #7155: URL: https://github.com/apache/trafficcontrol/pull/7155#issuecomment-1292403015 > Why did you decide on this library? The one linked to on [the mustache website](https://mustache.github.io) is [cbroclie/mustache](https://github.com/cbroglie/mustache).

[GitHub] [trafficcontrol] ocket8888 commented on pull request #7149: Use "twelve" as the password where "twelve12" was used

2022-10-26 Thread GitBox
ocket commented on PR #7149: URL: https://github.com/apache/trafficcontrol/pull/7149#issuecomment-1292288893 I don't agree that we should knowingly use invalid data in any environment, except in a test to ensure such data is rejected by the API. -- This is an automated message from

[GitHub] [trafficcontrol] ocket8888 commented on pull request #7142: Run CDN in a Box for Developers services as unprivileged users

2022-10-26 Thread GitBox
ocket commented on PR #7142: URL: https://github.com/apache/trafficcontrol/pull/7142#issuecomment-1292273358 This is something I've wanted for the dev environment since its inception, but I can't test it because of a bug in the TP/TPv2 containers that prevents them from fetching a

[GitHub] [trafficcontrol] zrhoffman merged pull request #7156: Fix APIv4.0 returning APIv4.1 DS structures

2022-10-26 Thread GitBox
zrhoffman merged PR #7156: URL: https://github.com/apache/trafficcontrol/pull/7156 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] ocket8888 commented on pull request #7099: Delivery Service Active Flag Rework

2022-10-25 Thread GitBox
ocket commented on PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#issuecomment-1291257249 This PR depends on #7156 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7099: Delivery Service Active Flag Rework

2022-10-25 Thread GitBox
ocket commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1005068529 ## traffic_ops/app/db/migrations/2022092107561215_ds_explicit_mso.down.sql: ## @@ -0,0 +1,20 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7099: Delivery Service Active Flag Rework

2022-10-25 Thread GitBox
ocket commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1005066584 ## traffic_ops/traffic_ops_golang/deliveryservice/servers/servers.go: ## @@ -1023,6 +1027,7 @@ func scanDSInfoRow(row *sql.Row) (DSInfo, bool, error) {

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7099: Delivery Service Active Flag Rework

2022-10-25 Thread GitBox
ocket commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1005065463 ## traffic_ops/testing/api/v4/tc-fixtures.json: ## @@ -907,7 +907,7 @@ "regexRemap": null, "regionalGeoBlocking": false,

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7099: Delivery Service Active Flag Rework

2022-10-25 Thread GitBox
ocket commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1005063876 ## traffic_ops/testing/api/v5/deliveryservice_request_comments_test.go: ## @@ -178,7 +178,9 @@ func CreateTestDeliveryServiceRequestComments(t *testing.T) {

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7099: Delivery Service Active Flag Rework

2022-10-25 Thread GitBox
ocket commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1005062709 ## traffic_ops/v5-client/deliveryservice_requests.go: ## @@ -58,31 +58,31 @@ func (to *Session) CreateDeliveryServiceRequest(dsr tc.DeliveryServiceRequestV4,

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7099: Delivery Service Active Flag Rework

2022-10-25 Thread GitBox
ocket commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1005059975 ## traffic_ops/testing/api/v5/deliveryservices_keys_test.go: ## @@ -67,30 +67,29 @@ func createBlankCDN(cdnName string, t *testing.T) tc.CDN { return

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7099: Delivery Service Active Flag Rework

2022-10-25 Thread GitBox
ocket commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1005057765 ## traffic_ops/traffic_ops_golang/deliveryservice/safe.go: ## @@ -144,19 +141,28 @@ func UpdateSafe(w http.ResponseWriter, r *http.Request) {

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7099: Delivery Service Active Flag Rework

2022-10-25 Thread GitBox
ocket commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1005057324 ## traffic_ops/traffic_ops_golang/deliveryservice/deliveryservices.go: ## @@ -138,7 +162,7 @@ func CreateV30(w http.ResponseWriter, r *http.Request) {

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7156: Fix APIv4.0 returning APIv4.1 DS structures

2022-10-25 Thread GitBox
ocket commented on code in PR #7156: URL: https://github.com/apache/trafficcontrol/pull/7156#discussion_r1005050496 ## traffic_ops/traffic_ops_golang/deliveryservice/deliveryservices.go: ## @@ -614,7 +614,7 @@ func (ds *TODeliveryService) Read(h http.Header, useIMS bool)

[GitHub] [trafficcontrol] ocket8888 closed issue #7158: Traffic Vault: Reencrypt utility wipes different SSL Keys during update

2022-10-25 Thread GitBox
ocket closed issue #7158: Traffic Vault: Reencrypt utility wipes different SSL Keys during update URL: https://github.com/apache/trafficcontrol/issues/7158 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [trafficcontrol] ocket8888 merged pull request #7159: Traffic Vault: Fix `reencrypt` utility to uniquely reencrypt ssl keys

2022-10-25 Thread GitBox
ocket merged PR #7159: URL: https://github.com/apache/trafficcontrol/pull/7159 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] zrhoffman merged pull request #7152: Use Generics in TO API v3 Integration Tests

2022-10-25 Thread GitBox
zrhoffman merged PR #7152: URL: https://github.com/apache/trafficcontrol/pull/7152 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7156: Fix APIv4.0 returning APIv4.1 DS structures

2022-10-25 Thread GitBox
zrhoffman commented on code in PR #7156: URL: https://github.com/apache/trafficcontrol/pull/7156#discussion_r1004982343 ## traffic_ops/traffic_ops_golang/deliveryservice/deliveryservices.go: ## @@ -614,7 +614,7 @@ func (ds *TODeliveryService) Read(h http.Header, useIMS bool)

[GitHub] [trafficcontrol] TaylorCFrey opened a new pull request, #7159: Traffic Vault: Fix `reencrypt` utility to uniquely reencrypt ssl keys

2022-10-25 Thread GitBox
TaylorCFrey opened a new pull request, #7159: URL: https://github.com/apache/trafficcontrol/pull/7159 Closes: #7158 A Traffic Vault utility called `reencrypt` allows for the ability to take previously encrypted values in the Traffic Vault DB and apply a new AES key for

[GitHub] [trafficcontrol] TaylorCFrey opened a new issue, #7158: Traffic Vault: Reencrypt utility wipes different SSL Keys during update

2022-10-25 Thread GitBox
TaylorCFrey opened a new issue, #7158: URL: https://github.com/apache/trafficcontrol/issues/7158 ## This Bug Report affects these Traffic Control components: - Traffic Vault ## Current behavior: When running the `reencrypt` utility located at

[GitHub] [trafficcontrol] ocket8888 commented on pull request #7155: t3c: initial mustache for remap.config templating

2022-10-25 Thread GitBox
ocket commented on PR #7155: URL: https://github.com/apache/trafficcontrol/pull/7155#issuecomment-1291092430 Why did you decide on this library? The one linked to on [the mustache website](https://mustache.github.io) is [cbroclie/mustache](https://github.com/cbroglie/mustache). --

[GitHub] [trafficcontrol] zrhoffman merged pull request #7157: Fix TP DSR edit page not rendering

2022-10-25 Thread GitBox
zrhoffman merged PR #7157: URL: https://github.com/apache/trafficcontrol/pull/7157 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7156: Fix APIv4.0 returning APIv4.1 DS structures

2022-10-25 Thread GitBox
zrhoffman commented on code in PR #7156: URL: https://github.com/apache/trafficcontrol/pull/7156#discussion_r1004876267 ## traffic_ops/traffic_ops_golang/deliveryservice/deliveryservices.go: ## @@ -572,8 +614,10 @@ func (ds *TODeliveryService) Read(h http.Header, useIMS bool)

[GitHub] [trafficcontrol] ocket8888 opened a new pull request, #7157: Fix TP DSR edit page not rendering

2022-10-25 Thread GitBox
ocket opened a new pull request, #7157: URL: https://github.com/apache/trafficcontrol/pull/7157 Fixes a bug introduced in #7075 that prevented Delivery Service Request edit pages from rendering. ## Which Traffic Control components are affected by this PR? - Traffic

[GitHub] [trafficcontrol] ocket8888 opened a new pull request, #7156: Fix APIv4.0 returning APIv4.1 DS structures

2022-10-25 Thread GitBox
ocket opened a new pull request, #7156: URL: https://github.com/apache/trafficcontrol/pull/7156 This PR fixes a bug introduced by #7111 where APIv4.0 responses containing representations of Delivery Services used the representation from APIv4.1. ## Which Traffic Control

[GitHub] [trafficcontrol] smalenfant commented on issue #7081: Traffic Router logs `SocketTimeoutException` for port 53 TCP health checks

2022-10-25 Thread GitBox
smalenfant commented on issue #7081: URL: https://github.com/apache/trafficcontrol/issues/7081#issuecomment-1290868215 I used to turn those messages off in the past when that was a problem. I'm glad there is some resolution to this. ```

[GitHub] [trafficcontrol] traeak opened a new pull request, #7155: t3c: initial mustache for remap.config templating

2022-10-25 Thread GitBox
traeak opened a new pull request, #7155: URL: https://github.com/apache/trafficcontrol/pull/7155 This allows remap.config to be modified by specifying a DS parameter with a different template. Template uses a golang mustache library. const

[GitHub] [trafficcontrol] srijeet0406 commented on a diff in pull request #7079: Assign multiple servers to a capability

2022-10-24 Thread GitBox
srijeet0406 commented on code in PR #7079: URL: https://github.com/apache/trafficcontrol/pull/7079#discussion_r1003829984 ## traffic_ops/traffic_ops_golang/server/servers_server_capability.go: ## @@ -453,77 +443,185 @@ func AssignMultipleServerCapabilities(w

[GitHub] [trafficcontrol] zrhoffman merged pull request #7096: Add health client parent health

2022-10-24 Thread GitBox
zrhoffman merged PR #7096: URL: https://github.com/apache/trafficcontrol/pull/7096 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] rob05c commented on a diff in pull request #7096: Add health client parent health

2022-10-24 Thread GitBox
rob05c commented on code in PR #7096: URL: https://github.com/apache/trafficcontrol/pull/7096#discussion_r1003764988 ## tc-health-client/config/config_test.go: ## @@ -37,7 +37,7 @@ func TestLoadConfig(t *testing.T) { } cfg := Cfg{ -

[GitHub] [trafficcontrol] rob05c commented on a diff in pull request #7096: Add health client parent health

2022-10-24 Thread GitBox
rob05c commented on code in PR #7096: URL: https://github.com/apache/trafficcontrol/pull/7096#discussion_r1003764401 ## tc-health-client/tmagent/markdownservice.go: ## @@ -0,0 +1,484 @@ +package tmagent + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] [trafficcontrol] rob05c commented on a diff in pull request #7096: Add health client parent health

2022-10-24 Thread GitBox
rob05c commented on code in PR #7096: URL: https://github.com/apache/trafficcontrol/pull/7096#discussion_r1003762350 ## tc-health-client/sar/ephemeralportholder.go: ## @@ -0,0 +1,77 @@ +package sar + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [trafficcontrol] rob05c opened a new pull request, #7154: Add Traffic Ops Batch Endpoint

2022-10-24 Thread GitBox
rob05c opened a new pull request, #7154: URL: https://github.com/apache/trafficcontrol/pull/7154 This is a Proof-of-Concept. I just needed to prove to myself that it's reasonable, it still needs the details worked out, docs, tests, etc. I'm making a Draft PR in case anyone else is

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7096: Add health client parent health

2022-10-24 Thread GitBox
zrhoffman commented on code in PR #7096: URL: https://github.com/apache/trafficcontrol/pull/7096#discussion_r1003601203 ## tc-health-client/config/config_test.go: ## @@ -37,7 +37,7 @@ func TestLoadConfig(t *testing.T) { } cfg := Cfg{ -

[GitHub] [trafficcontrol] traeak opened a new pull request, #7153: T3c bad cert

2022-10-24 Thread GitBox
traeak opened a new pull request, #7153: URL: https://github.com/apache/trafficcontrol/pull/7153 t3c will panic and fail when a pem.Decode fails for a base64 decoded cert. This adds extra logic to identify and skip a cert that fails this way. ## Which Traffic Control

[GitHub] [trafficcontrol] ericholguin opened a new pull request, #7152: Use Generics in TO Integration Tests

2022-10-24 Thread GitBox
ericholguin opened a new pull request, #7152: URL: https://github.com/apache/trafficcontrol/pull/7152 Updated the tests to use the new generics test struct ## Which Traffic Control components are affected by this PR? - Traffic Ops ## What is

[GitHub] [trafficcontrol] ericholguin closed pull request #7151: Use Generics in TO Integration Tests

2022-10-24 Thread GitBox
ericholguin closed pull request #7151: Use Generics in TO Integration Tests URL: https://github.com/apache/trafficcontrol/pull/7151 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [trafficcontrol] traeak commented on a diff in pull request #7137: T3C parent.config simulate topology for non topo delivery services

2022-10-24 Thread GitBox
traeak commented on code in PR #7137: URL: https://github.com/apache/trafficcontrol/pull/7137#discussion_r1003289241 ## lib/go-atscfg/parentdotconfig.go: ## @@ -383,258 +390,112 @@ func makeParentDotConfigData( continue } -

[GitHub] [trafficcontrol] traeak commented on a diff in pull request #7137: T3C parent.config simulate topology for non topo delivery services

2022-10-24 Thread GitBox
traeak commented on code in PR #7137: URL: https://github.com/apache/trafficcontrol/pull/7137#discussion_r1003288538 ## lib/go-atscfg/parentdotconfig.go: ## @@ -383,258 +390,112 @@ func makeParentDotConfigData( continue } -

[GitHub] [trafficcontrol] traeak commented on a diff in pull request #7137: T3C parent.config simulate topology for non topo delivery services

2022-10-24 Thread GitBox
traeak commented on code in PR #7137: URL: https://github.com/apache/trafficcontrol/pull/7137#discussion_r1003288096 ## lib/go-atscfg/parentdotconfig.go: ## @@ -165,6 +165,11 @@ func MakeParentDotConfig( }, nil } +// Check if this ds type is edge only Review

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7151: Use Generics in TO Integration Tests

2022-10-21 Thread GitBox
zrhoffman commented on code in PR #7151: URL: https://github.com/apache/trafficcontrol/pull/7151#discussion_r1002131580 ## traffic_ops/testing/api/v5/cachegroups_test.go: ## @@ -65,184 +67,173 @@ func TestCacheGroups(t *testing.T) {

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7151: Use Generics in TO Integration Tests

2022-10-21 Thread GitBox
zrhoffman commented on code in PR #7151: URL: https://github.com/apache/trafficcontrol/pull/7151#discussion_r1002127862 ## traffic_ops/testing/api/v5/deliveryservices_required_capabilities_test.go: ## @@ -79,119 +83,123 @@ func TestDeliveryServicesRequiredCapabilities(t

[GitHub] [trafficcontrol] ericholguin opened a new pull request, #7151: Use Generics in TO Integration Tests

2022-10-21 Thread GitBox
ericholguin opened a new pull request, #7151: URL: https://github.com/apache/trafficcontrol/pull/7151 Updated the tests to use the new generics test struct ## Which Traffic Control components are affected by this PR? - Traffic Ops Tests ## What is the

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7068: Renamed rascal to tm/traffic_monitor

2022-10-21 Thread GitBox
rimashah25 commented on code in PR #7068: URL: https://github.com/apache/trafficcontrol/pull/7068#discussion_r1002009697 ## traffic_ops/app/db/migrations/2022100610190300_update_rascal_to_traffic_monitor.up.sql: ## @@ -0,0 +1,35 @@ +/* + * Licensed to the Apache Software

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7068: Renamed rascal to tm/traffic_monitor

2022-10-20 Thread GitBox
ocket commented on code in PR #7068: URL: https://github.com/apache/trafficcontrol/pull/7068#discussion_r1001067763 ## traffic_ops/traffic_ops_golang/server/servers.go: ## @@ -856,6 +856,12 @@ func getServers(h http.Header, params map[string]string, tx *sqlx.Tx, user *auth

[GitHub] [trafficcontrol] zrhoffman merged pull request #7144: Use Generics in TO Integration Tests

2022-10-20 Thread GitBox
zrhoffman merged PR #7144: URL: https://github.com/apache/trafficcontrol/pull/7144 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] zrhoffman commented on pull request #7150: Retract versions v1.1.0 through v1.1.5 from Go modules

2022-10-20 Thread GitBox
zrhoffman commented on PR #7150: URL: https://github.com/apache/trafficcontrol/pull/7150#issuecomment-1285947757 We could also tag it something like `v1.1.5-retraction`, it doesn't need to be named only `v1.1.5` -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [trafficcontrol] zrhoffman opened a new pull request, #7150: Retract versions v1.1.0 through v1.1.5 from Go modules

2022-10-20 Thread GitBox
zrhoffman opened a new pull request, #7150: URL: https://github.com/apache/trafficcontrol/pull/7150 This PR retracts `v1.1.0`, `v1.1.1`, `v1.1.2`, `v1.1.3`, `v1.1.4`, and `v1.1.5` from Go modules. If this PR is merged, it should be tagged version `v1.1.5`. Without this PR

[GitHub] [trafficcontrol] ocket8888 merged pull request #7118: Remove ASN from servers

2022-10-20 Thread GitBox
ocket merged PR #7118: URL: https://github.com/apache/trafficcontrol/pull/7118 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] ericholguin commented on a diff in pull request #7144: Use Generics in TO Integration Tests

2022-10-20 Thread GitBox
ericholguin commented on code in PR #7144: URL: https://github.com/apache/trafficcontrol/pull/7144#discussion_r1000939988 ## traffic_ops/testing/api/v5/servers_hostname_update_status_test.go: ## @@ -1,18 +1,17 @@ package v5 /* + Licensed under the Apache License,

[GitHub] [trafficcontrol] ericholguin commented on a diff in pull request #7144: Use Generics in TO Integration Tests

2022-10-20 Thread GitBox
ericholguin commented on code in PR #7144: URL: https://github.com/apache/trafficcontrol/pull/7144#discussion_r1000939559 ## traffic_ops/testing/api/v4/server_server_capabilities_test.go: ## @@ -216,25 +189,26 @@ func TestServerServerCapabilities(t *testing.T) {

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7144: Use Generics in TO Integration Tests

2022-10-20 Thread GitBox
zrhoffman commented on code in PR #7144: URL: https://github.com/apache/trafficcontrol/pull/7144#discussion_r1000915015 ## traffic_ops/testing/api/v4/server_server_capabilities_test.go: ## @@ -216,25 +189,26 @@ func TestServerServerCapabilities(t *testing.T) {

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7079: Assign multiple servers to a capability

2022-10-19 Thread GitBox
ocket commented on code in PR #7079: URL: https://github.com/apache/trafficcontrol/pull/7079#discussion_r157834 ## docs/source/api/v5/multiple_servers_capabilities.rst: ## @@ -0,0 +1,123 @@ +.. +.. +.. Licensed under the Apache License, Version 2.0 (the "License"); +..

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #6532: CDN-in-a-Box for Developers

2022-10-19 Thread GitBox
zrhoffman commented on code in PR #6532: URL: https://github.com/apache/trafficcontrol/pull/6532#discussion_r999826379 ## dev/traffic_router/conf/traffic_ops.properties: ## @@ -0,0 +1,13 @@ +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use

[GitHub] [trafficcontrol] zrhoffman opened a new pull request, #7149: Use "twelve" as the password where "twelve12" was used

2022-10-19 Thread GitBox
zrhoffman opened a new pull request, #7149: URL: https://github.com/apache/trafficcontrol/pull/7149 #4764 changed the default password in some places, but not all, from `twelve` to `twelve12`. This is confusing for all of the people who are used to `twelve` being the default

[GitHub] [trafficcontrol] shamrickus merged pull request #7148: Check the exit code of API v5 tests also

2022-10-19 Thread GitBox
shamrickus merged PR #7148: URL: https://github.com/apache/trafficcontrol/pull/7148 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] zrhoffman opened a new pull request, #7148: Check the exit code of API v5 tests also

2022-10-19 Thread GitBox
zrhoffman opened a new pull request, #7148: URL: https://github.com/apache/trafficcontrol/pull/7148 This PR updates the TO API tests service in CDN in a Box to check the exit code for the API v5 tests. ## Which Traffic Control components are affected by this PR? -

[GitHub] [trafficcontrol] smalenfant commented on issue #7128: API acme_autorenew: Renewal are not being kicked off

2022-10-19 Thread GitBox
smalenfant commented on issue #7128: URL: https://github.com/apache/trafficcontrol/issues/7128#issuecomment-1284356148 I also noticed that the expiration is not set when doing the riak->postgreql migration. Not sure if this could affect the functionality of the renewal. -- This is an

[GitHub] [trafficcontrol] mitchell852 commented on issue #7128: API acme_autorenew: Renewal are not being kicked off

2022-10-19 Thread GitBox
mitchell852 commented on issue #7128: URL: https://github.com/apache/trafficcontrol/issues/7128#issuecomment-1284340857 > @mitchell852 It's in there already. Maybe not clear. `After upgrading to 6.1.0 from 5.1.2` cool. guess i didn't see that. :) -- This is an automated message

[GitHub] [trafficcontrol] smalenfant commented on issue #7128: API acme_autorenew: Renewal are not being kicked off

2022-10-19 Thread GitBox
smalenfant commented on issue #7128: URL: https://github.com/apache/trafficcontrol/issues/7128#issuecomment-1284334826 @mitchell852 It's in there already. Maybe not clear. `After upgrading to 6.1.0 from 5.1.2` -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [trafficcontrol] smalenfant commented on issue #7129: Let's Encrypt certificates sometimes fails to write to Traffic Vault - postgresql

2022-10-19 Thread GitBox
smalenfant commented on issue #7129: URL: https://github.com/apache/trafficcontrol/issues/7129#issuecomment-1284334179 @mitchell852 I added. I'm pretty this should also affect master/7.1.x as I don't see changes regarding the backend. -- This is an automated message from the Apache Git

[GitHub] [trafficcontrol] shamrickus merged pull request #7147: Include TO API v5 in CiaB TO API Tests

2022-10-19 Thread GitBox
shamrickus merged PR #7147: URL: https://github.com/apache/trafficcontrol/pull/7147 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] zrhoffman opened a new pull request, #7147: Include TO API v5 in CiaB TO API Tests

2022-10-19 Thread GitBox
zrhoffman opened a new pull request, #7147: URL: https://github.com/apache/trafficcontrol/pull/7147 This PR updates the TO API tests service in CDN in a Box to include API v5 (and not try to print API v2 results). ## Which Traffic Control components are affected by this

[GitHub] [trafficcontrol] zrhoffman closed issue #7081: Traffic Router logs `SocketTimeoutException` for port 53 TCP health checks

2022-10-19 Thread GitBox
zrhoffman closed issue #7081: Traffic Router logs `SocketTimeoutException` for port 53 TCP health checks URL: https://github.com/apache/trafficcontrol/issues/7081 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [trafficcontrol] zrhoffman merged pull request #7146: Better messages for Traffic Router exceptions

2022-10-19 Thread GitBox
zrhoffman merged PR #7146: URL: https://github.com/apache/trafficcontrol/pull/7146 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7146: Better messages for Traffic Router exceptions

2022-10-19 Thread GitBox
zrhoffman commented on code in PR #7146: URL: https://github.com/apache/trafficcontrol/pull/7146#discussion_r999684460 ## traffic_router/core/src/main/java/org/apache/traffic_control/traffic_router/core/dns/protocol/TCP.java: ## @@ -112,6 +115,20 @@ public void run() {

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7068: Renamed rascal to tm/traffic_monitor

2022-10-19 Thread GitBox
rimashah25 commented on code in PR #7068: URL: https://github.com/apache/trafficcontrol/pull/7068#discussion_r999632370 ## traffic_ops/app/db/migrations/2022100610190300_update_rascal_to_traffic_monitor.up.sql: ## @@ -0,0 +1,35 @@ +/* + * Licensed to the Apache Software

[GitHub] [trafficcontrol] shamrickus merged pull request #7145: Bump @xmldom/xmldom from 0.7.5 to 0.7.6 in /traffic_portal/test/integration

2022-10-19 Thread GitBox
shamrickus merged PR #7145: URL: https://github.com/apache/trafficcontrol/pull/7145 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] shamrickus closed issue #7134: Remove cookie user errors from TO error.log

2022-10-19 Thread GitBox
shamrickus closed issue #7134: Remove cookie user errors from TO error.log URL: https://github.com/apache/trafficcontrol/issues/7134 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [trafficcontrol] shamrickus merged pull request #7138: Remove expired cookie and bad signature cookie errors from error.log

2022-10-19 Thread GitBox
shamrickus merged PR #7138: URL: https://github.com/apache/trafficcontrol/pull/7138 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7146: Better messages for Traffic Router exceptions

2022-10-18 Thread GitBox
zrhoffman commented on code in PR #7146: URL: https://github.com/apache/trafficcontrol/pull/7146#discussion_r998716177 ## traffic_router/core/src/main/java/org/apache/traffic_control/traffic_router/core/dns/protocol/TCP.java: ## @@ -112,6 +114,20 @@ public void run() {

[GitHub] [trafficcontrol] srijeet0406 closed issue #2388: Global DNS TTL adjustment

2022-10-18 Thread GitBox
srijeet0406 closed issue #2388: Global DNS TTL adjustment URL: https://github.com/apache/trafficcontrol/issues/2388 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [trafficcontrol] srijeet0406 merged pull request #7143: Override all Delivery Service TTLs in a CDN's Snapshot with a given value

2022-10-18 Thread GitBox
srijeet0406 merged PR #7143: URL: https://github.com/apache/trafficcontrol/pull/7143 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] srijeet0406 commented on a diff in pull request #7118: Remove ASN from servers

2022-10-18 Thread GitBox
srijeet0406 commented on code in PR #7118: URL: https://github.com/apache/trafficcontrol/pull/7118#discussion_r998504903 ## traffic_ops/traffic_ops_golang/deliveryservice/keys_test.go: ## @@ -2260,6 +2261,7 @@ func TestVerifyAndEncodeCertificateSelfSignedX509v1(t *testing.T) {

<    3   4   5   6   7   8   9   10   11   12   >