[GitHub] dneuman64 closed pull request #2318: only show ds form field tooltip when label is clicked

2018-05-23 Thread GitBox
dneuman64 closed pull request #2318: only show ds form field tooltip when label is clicked URL: https://github.com/apache/incubator-trafficcontrol/pull/2318 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] rawlinp commented on a change in pull request #2247: Add an Origin API

2018-05-22 Thread GitBox
rawlinp commented on a change in pull request #2247: Add an Origin API URL: https://github.com/apache/incubator-trafficcontrol/pull/2247#discussion_r190044166 ## File path: lib/go-tc/v13/origins.go ## @@ -0,0 +1,150 @@ +package v13 + +import ( +

[GitHub] rob05c commented on a change in pull request #2282: Deliveryservice_Server API conversion to Go - formerly #2269

2018-05-22 Thread GitBox
rob05c commented on a change in pull request #2282: Deliveryservice_Server API conversion to Go - formerly #2269 URL: https://github.com/apache/incubator-trafficcontrol/pull/2282#discussion_r190064897 ## File path: traffic_ops/traffic_ops_golang/deliveryservice/servers/servers.go

[GitHub] rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup

2018-05-22 Thread GitBox
rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#discussion_r189958107 ## File path: traffic_ops/app/db/migrations/2018052100_cache_group_fallback.sql

[GitHub] rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup

2018-05-22 Thread GitBox
rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#discussion_r189955184 ## File path: traffic_ops/app/db/migrations/2018052100_cache_group_fallback.sql

[GitHub] rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup

2018-05-22 Thread GitBox
rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#discussion_r189953754 ## File path: traffic_ops/app/lib/API/Cachegroup.pm ## @@ -57,6 +57,7 @@ sub index

[GitHub] rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup

2018-05-22 Thread GitBox
rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#discussion_r189963481 ## File path: traffic_ops/app/lib/API/CachegroupFallback.pm ## @@ -0,0 +1,278 @@

[GitHub] rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup

2018-05-22 Thread GitBox
rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#discussion_r189971490 ## File path: traffic_ops/app/lib/API/CachegroupFallback.pm ## @@ -0,0 +1,278 @@

[GitHub] rawlinp commented on a change in pull request #2247: Add an Origin API

2018-05-22 Thread GitBox
rawlinp commented on a change in pull request #2247: Add an Origin API URL: https://github.com/apache/incubator-trafficcontrol/pull/2247#discussion_r190041779 ## File path: lib/go-tc/v13/origins.go ## @@ -0,0 +1,150 @@ +package v13 + +import ( +

[GitHub] rob05c commented on a change in pull request #2247: Add an Origin API

2018-05-22 Thread GitBox
rob05c commented on a change in pull request #2247: Add an Origin API URL: https://github.com/apache/incubator-trafficcontrol/pull/2247#discussion_r190046195 ## File path: lib/go-tc/v13/origins.go ## @@ -0,0 +1,150 @@ +package v13 + +import ( +

[GitHub] asfgit commented on issue #2317: Add TO Go cdns/name/dnsseckeys

2018-05-22 Thread GitBox
asfgit commented on issue #2317: Add TO Go cdns/name/dnsseckeys URL: https://github.com/apache/incubator-trafficcontrol/pull/2317#issuecomment-391160661 Refer to this link for build results (access rights to CI server needed):

[GitHub] jrushford opened a new pull request #2316: Fix makeModHdrs() when mod headers config has an empty line.

2018-05-22 Thread GitBox
jrushford opened a new pull request #2316: Fix makeModHdrs() when mod headers config has an empty line. URL: https://github.com/apache/incubator-trafficcontrol/pull/2316 Fixes an issue in makeModHdrs(), by checking for and skipping empty lines in mod header rules.

[GitHub] rob05c opened a new pull request #2317: Add TO Go cdns/name/dnsseckeys

2018-05-22 Thread GitBox
rob05c opened a new pull request #2317: Add TO Go cdns/name/dnsseckeys URL: https://github.com/apache/incubator-trafficcontrol/pull/2317 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] asfgit commented on issue #2247: Add an Origin API

2018-05-22 Thread GitBox
asfgit commented on issue #2247: Add an Origin API URL: https://github.com/apache/incubator-trafficcontrol/pull/2247#issuecomment-391176328 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR/1650/

[GitHub] rob05c closed pull request #2316: Fix makeModHdrs() when mod headers config has an empty line.

2018-05-22 Thread GitBox
rob05c closed pull request #2316: Fix makeModHdrs() when mod headers config has an empty line. URL: https://github.com/apache/incubator-trafficcontrol/pull/2316 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] asfgit commented on issue #2315: Fix Grove grovetccfg compile errs, better err msgs

2018-05-22 Thread GitBox
asfgit commented on issue #2315: Fix Grove grovetccfg compile errs, better err msgs URL: https://github.com/apache/incubator-trafficcontrol/pull/2315#issuecomment-391135354 Refer to this link for build results (access rights to CI server needed):

[GitHub] rawlinp commented on a change in pull request #2247: Add an Origin API

2018-05-22 Thread GitBox
rawlinp commented on a change in pull request #2247: Add an Origin API URL: https://github.com/apache/incubator-trafficcontrol/pull/2247#discussion_r190048933 ## File path: lib/go-tc/v13/origins.go ## @@ -0,0 +1,150 @@ +package v13 + +import ( +

[GitHub] Vijay-1 commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup

2018-05-25 Thread GitBox
Vijay-1 commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#discussion_r190844337 ## File path: traffic_ops/app/lib/API/CachegroupFallback.pm ## @@ -0,0 +1,278 @@

[GitHub] limited commented on issue #2331: Traffic Router upgrade Tomcat to 8.5

2018-05-25 Thread GitBox
limited commented on issue #2331: Traffic Router upgrade Tomcat to 8.5 URL: https://github.com/apache/incubator-trafficcontrol/pull/2331#issuecomment-392045570 test this please This is an automated message from the Apache

[GitHub] limited commented on issue #925: [TC-69] Upgrade Tomcat Version for Traffic Router

2018-05-25 Thread GitBox
limited commented on issue #925: [TC-69] Upgrade Tomcat Version for Traffic Router URL: https://github.com/apache/incubator-trafficcontrol/issues/925#issuecomment-392045445 Very exciting Andy! * Any idea on the HTTPS performance improvements from this upgrade? * Requirements

[GitHub] asfgit commented on issue #2331: Traffic Router upgrade Tomcat to 8.5

2018-05-25 Thread GitBox
asfgit commented on issue #2331: Traffic Router upgrade Tomcat to 8.5 URL: https://github.com/apache/incubator-trafficcontrol/pull/2331#issuecomment-392046773 Refer to this link for build results (access rights to CI server needed):

[GitHub] Vijay-1 commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup

2018-05-25 Thread GitBox
Vijay-1 commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#discussion_r190841696 ## File path: traffic_ops/app/db/migrations/2018052100_cache_group_fallback.sql

[GitHub] Vijay-1 commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup

2018-05-25 Thread GitBox
Vijay-1 commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#discussion_r190840779 ## File path: traffic_ops/app/db/migrations/2018052100_cache_group_fallback.sql

[GitHub] Vijay-1 commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup

2018-05-25 Thread GitBox
Vijay-1 commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#discussion_r190866276 ## File path: traffic_ops/app/lib/API/Cachegroup.pm ## @@ -57,6 +57,7 @@ sub index

[GitHub] dangogh commented on issue #2331: Traffic Router upgrade Tomcat to 8.5

2018-05-25 Thread GitBox
dangogh commented on issue #2331: Traffic Router upgrade Tomcat to 8.5 URL: https://github.com/apache/incubator-trafficcontrol/pull/2331#issuecomment-392066416 also see in the rat report -- this file doesn't have the Apache license header: ```

[GitHub] asfgit commented on issue #2270: Add TO Go Servers Details endpoint

2018-05-25 Thread GitBox
asfgit commented on issue #2270: Add TO Go Servers Details endpoint URL: https://github.com/apache/incubator-trafficcontrol/pull/2270#issuecomment-392110364 Refer to this link for build results (access rights to CI server needed):

[GitHub] asfgit commented on issue #2320: Start of integration tests for Grove

2018-05-25 Thread GitBox
asfgit commented on issue #2320: Start of integration tests for Grove URL: https://github.com/apache/incubator-trafficcontrol/pull/2320#issuecomment-392104967 Refer to this link for build results (access rights to CI server needed):

[GitHub] asfgit commented on issue #2124: Add TO Go deliveryservices routes

2018-05-25 Thread GitBox
asfgit commented on issue #2124: Add TO Go deliveryservices routes URL: https://github.com/apache/incubator-trafficcontrol/pull/2124#issuecomment-39229 Refer to this link for build results (access rights to CI server needed):

[GitHub] dangogh commented on a change in pull request #2331: Traffic Router upgrade Tomcat to 8.5

2018-05-25 Thread GitBox
dangogh commented on a change in pull request #2331: Traffic Router upgrade Tomcat to 8.5 URL: https://github.com/apache/incubator-trafficcontrol/pull/2331#discussion_r190947658 ## File path: VERSION ## @@ -1 +1 @@ -2.3.0 Review comment: The VERSION change really

[GitHub] dg4prez commented on issue #889: [TC-545] CRConfig should not list teak nodes as edges

2018-05-25 Thread GitBox
dg4prez commented on issue #889: [TC-545] CRConfig should not list teak nodes as edges URL: https://github.com/apache/incubator-trafficcontrol/issues/889#issuecomment-392086475 This was fixed in a previous release. This is

[GitHub] rob05c closed pull request #2333: adds 'view delivery services' link to all server types

2018-05-25 Thread GitBox
rob05c closed pull request #2333: adds 'view delivery services' link to all server types URL: https://github.com/apache/incubator-trafficcontrol/pull/2333 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] dg4prez closed issue #889: [TC-545] CRConfig should not list teak nodes as edges

2018-05-25 Thread GitBox
dg4prez closed issue #889: [TC-545] CRConfig should not list teak nodes as edges URL: https://github.com/apache/incubator-trafficcontrol/issues/889 This is an automated message from the Apache Git Service. To respond to the

[GitHub] rob05c closed issue #2323: Feature Request: Show delivery services associated with MSO "Server"

2018-05-25 Thread GitBox
rob05c closed issue #2323: Feature Request: Show delivery services associated with MSO "Server" URL: https://github.com/apache/incubator-trafficcontrol/issues/2323 This is an automated message from the Apache Git Service.

[GitHub] asfgit commented on issue #2320: Start of integration tests for Grove

2018-05-25 Thread GitBox
asfgit commented on issue #2320: Start of integration tests for Grove URL: https://github.com/apache/incubator-trafficcontrol/pull/2320#issuecomment-392114548 Refer to this link for build results (access rights to CI server needed):

[GitHub] asfgit commented on issue #2302: Add TO Go cdns/name

2018-05-25 Thread GitBox
asfgit commented on issue #2302: Add TO Go cdns/name URL: https://github.com/apache/incubator-trafficcontrol/pull/2302#issuecomment-392109606 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR/1683/

[GitHub] mitchell852 opened a new pull request #2333: adds 'view delivery services' link to all server types

2018-05-25 Thread GitBox
mitchell852 opened a new pull request #2333: adds 'view delivery services' link to all server types URL: https://github.com/apache/incubator-trafficcontrol/pull/2333 fixes #2323 This is an automated message from the Apache

[GitHub] asfgit commented on issue #2304: Add TO Go cdns/id/queue_updates

2018-05-25 Thread GitBox
asfgit commented on issue #2304: Add TO Go cdns/id/queue_updates URL: https://github.com/apache/incubator-trafficcontrol/pull/2304#issuecomment-392108783 Refer to this link for build results (access rights to CI server needed):

[GitHub] mitchell852 commented on issue #2335: Fix for Traffic Router file leak when TM or TO is down

2018-05-25 Thread GitBox
mitchell852 commented on issue #2335: Fix for Traffic Router file leak when TM or TO is down URL: https://github.com/apache/incubator-trafficcontrol/pull/2335#issuecomment-392158797 @dewrich - were all the format changes necessary? maybe they were, just asking.

[GitHub] rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup

2018-05-25 Thread GitBox
rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#discussion_r191002483 ## File path: traffic_ops/traffic_ops_golang/crconfig/edgelocations.go ## @@ -57,6

[GitHub] rawlinp opened a new pull request #2337: Geolocation-based client steering

2018-05-25 Thread GitBox
rawlinp opened a new pull request #2337: Geolocation-based client steering URL: https://github.com/apache/incubator-trafficcontrol/pull/2337 By being able to assign coordinates to a delivery service through the Origin API, we can now use that data to optimally sort the list of targets of

[GitHub] asfgit commented on issue #2333: adds 'view delivery services' link to all server types

2018-05-25 Thread GitBox
asfgit commented on issue #2333: adds 'view delivery services' link to all server types URL: https://github.com/apache/incubator-trafficcontrol/pull/2333#issuecomment-392085828 Refer to this link for build results (access rights to CI server needed):

[GitHub] dangogh commented on issue #2320: Start of integration tests for Grove

2018-05-25 Thread GitBox
dangogh commented on issue #2320: Start of integration tests for Grove URL: https://github.com/apache/incubator-trafficcontrol/pull/2320#issuecomment-392128053 don't forget to add the appropriate Apache license header on any new files...

[GitHub] asfgit commented on issue #2335: Fix for Traffic Router file leak when TM or TO is down

2018-05-25 Thread GitBox
asfgit commented on issue #2335: Fix for Traffic Router file leak when TM or TO is down URL: https://github.com/apache/incubator-trafficcontrol/pull/2335#issuecomment-392151706 Refer to this link for build results (access rights to CI server needed):

[GitHub] asfgit commented on issue #2320: Start of integration tests for Grove

2018-05-25 Thread GitBox
asfgit commented on issue #2320: Start of integration tests for Grove URL: https://github.com/apache/incubator-trafficcontrol/pull/2320#issuecomment-392125552 Refer to this link for build results (access rights to CI server needed):

[GitHub] asfgit commented on issue #2334: TO postinstall -- modify GenerateCert.pm to not overwrite cdn.conf

2018-05-25 Thread GitBox
asfgit commented on issue #2334: TO postinstall -- modify GenerateCert.pm to not overwrite cdn.conf URL: https://github.com/apache/incubator-trafficcontrol/pull/2334#issuecomment-392127881 Refer to this link for build results (access rights to CI server needed):

[GitHub] dewrich opened a new pull request #2335: Fix for Traffic Router file leak when TM or TO is down

2018-05-25 Thread GitBox
dewrich opened a new pull request #2335: Fix for Traffic Router file leak when TM or TO is down URL: https://github.com/apache/incubator-trafficcontrol/pull/2335 Fix for Traffic Router issue #2223 This is an automated

[GitHub] dewrich closed pull request #2334: TO postinstall -- modify GenerateCert.pm to not overwrite cdn.conf

2018-05-25 Thread GitBox
dewrich closed pull request #2334: TO postinstall -- modify GenerateCert.pm to not overwrite cdn.conf URL: https://github.com/apache/incubator-trafficcontrol/pull/2334 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup

2018-05-25 Thread GitBox
rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#discussion_r190948333 ## File path: lib/go-tc/cachegroupfallback.go ## @@ -0,0 +1,55 @@ +package tc + +

[GitHub] rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup

2018-05-25 Thread GitBox
rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#discussion_r190963209 ## File path: traffic_ops/app/lib/API/CachegroupFallback.pm ## @@ -0,0 +1,287 @@

[GitHub] rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup

2018-05-25 Thread GitBox
rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#discussion_r190950254 ## File path: traffic_ops/app/db/migrations/2018052100_cache_group_fallback.sql

[GitHub] rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup

2018-05-25 Thread GitBox
rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#discussion_r190962381 ## File path: traffic_ops/app/lib/API/CachegroupFallback.pm ## @@ -0,0 +1,287 @@

[GitHub] rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup

2018-05-25 Thread GitBox
rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#discussion_r190955096 ## File path: traffic_ops/app/lib/API/CachegroupFallback.pm ## @@ -0,0 +1,287 @@

[GitHub] rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup

2018-05-25 Thread GitBox
rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#discussion_r190959281 ## File path: traffic_ops/app/lib/API/CachegroupFallback.pm ## @@ -0,0 +1,287 @@

[GitHub] rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup

2018-05-25 Thread GitBox
rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#discussion_r190962154 ## File path: traffic_ops/app/lib/API/CachegroupFallback.pm ## @@ -0,0 +1,287 @@

[GitHub] rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup

2018-05-25 Thread GitBox
rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#discussion_r190964049 ## File path: traffic_ops/app/lib/API/CachegroupFallback.pm ## @@ -0,0 +1,287 @@

[GitHub] rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup

2018-05-25 Thread GitBox
rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#discussion_r190955160 ## File path: traffic_ops/app/lib/API/CachegroupFallback.pm ## @@ -0,0 +1,287 @@

[GitHub] rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup

2018-05-25 Thread GitBox
rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#discussion_r190958237 ## File path: traffic_ops/app/lib/API/CachegroupFallback.pm ## @@ -0,0 +1,287 @@

[GitHub] rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup

2018-05-25 Thread GitBox
rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#discussion_r190963988 ## File path: traffic_ops/app/lib/API/CachegroupFallback.pm ## @@ -0,0 +1,287 @@

[GitHub] rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup

2018-05-25 Thread GitBox
rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#discussion_r190972947 ## File path: traffic_ops/traffic_ops_golang/crconfig/edgelocations.go ## @@ -57,6

[GitHub] rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup

2018-05-25 Thread GitBox
rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#discussion_r190980948 ## File path: traffic_ops/app/db/migrations/2018052100_cache_group_fallback.sql

[GitHub] asfgit commented on issue #2336: Update TR routes to point to 1.3 TO routes

2018-05-25 Thread GitBox
asfgit commented on issue #2336: Update TR routes to point to 1.3 TO routes URL: https://github.com/apache/incubator-trafficcontrol/pull/2336#issuecomment-392152497 Can one of the admins verify this patch? This is an

[GitHub] dangogh opened a new pull request #2334: TO postinstall -- modify GenerateCert.pm to not overwrite cdn.conf

2018-05-25 Thread GitBox
dangogh opened a new pull request #2334: TO postinstall -- modify GenerateCert.pm to not overwrite cdn.conf URL: https://github.com/apache/incubator-trafficcontrol/pull/2334 same change as #2329 to GenerateCert.pm which is what's actually used by `_postinstall`

[GitHub] rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup

2018-05-25 Thread GitBox
rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#discussion_r190952902 ## File path: traffic_ops/app/db/migrations/2018052100_cache_group_fallback.sql

[GitHub] rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup

2018-05-25 Thread GitBox
rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#discussion_r190962982 ## File path: traffic_ops/app/lib/API/CachegroupFallback.pm ## @@ -0,0 +1,287 @@

[GitHub] rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup

2018-05-25 Thread GitBox
rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#discussion_r190961962 ## File path: traffic_ops/app/lib/API/CachegroupFallback.pm ## @@ -0,0 +1,287 @@

[GitHub] rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup

2018-05-25 Thread GitBox
rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#discussion_r190962521 ## File path: traffic_ops/app/lib/API/CachegroupFallback.pm ## @@ -0,0 +1,287 @@

[GitHub] rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup

2018-05-25 Thread GitBox
rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#discussion_r190958981 ## File path: traffic_ops/app/lib/API/CachegroupFallback.pm ## @@ -0,0 +1,287 @@

[GitHub] rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup

2018-05-25 Thread GitBox
rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#discussion_r190962922 ## File path: traffic_ops/app/lib/API/CachegroupFallback.pm ## @@ -0,0 +1,287 @@

[GitHub] rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup

2018-05-25 Thread GitBox
rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#discussion_r190962185 ## File path: traffic_ops/app/lib/API/CachegroupFallback.pm ## @@ -0,0 +1,287 @@

[GitHub] rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup

2018-05-25 Thread GitBox
rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#discussion_r190971957 ## File path: traffic_ops/traffic_ops_golang/crconfig/edgelocations.go ## @@ -57,6

[GitHub] asfgit commented on issue #2336: Update TR routes to point to 1.3 TO routes

2018-05-25 Thread GitBox
asfgit commented on issue #2336: Update TR routes to point to 1.3 TO routes URL: https://github.com/apache/incubator-trafficcontrol/pull/2336#issuecomment-392152246 Can one of the admins verify this patch? This is an

[GitHub] rivasj opened a new pull request #2336: Update TR routes to point to 1.3 TO routes

2018-05-25 Thread GitBox
rivasj opened a new pull request #2336: Update TR routes to point to 1.3 TO routes URL: https://github.com/apache/incubator-trafficcontrol/pull/2336 -Updated default TO API paths from 1.1/1.2 to 1.3 -Updated test .json files to return 1.3 TO routes

[GitHub] asfgit commented on issue #2320: Start of integration tests for Grove

2018-05-25 Thread GitBox
asfgit commented on issue #2320: Start of integration tests for Grove URL: https://github.com/apache/incubator-trafficcontrol/pull/2320#issuecomment-392204201 Refer to this link for build results (access rights to CI server needed):

[GitHub] ajschmidt commented on a change in pull request #2331: Traffic Router upgrade Tomcat to 8.5

2018-05-25 Thread GitBox
ajschmidt commented on a change in pull request #2331: Traffic Router upgrade Tomcat to 8.5 URL: https://github.com/apache/incubator-trafficcontrol/pull/2331#discussion_r191029034 ## File path: VERSION ## @@ -1 +1 @@ -2.3.0 Review comment: I could, but it will

[GitHub] ajschmidt commented on a change in pull request #2331: Traffic Router upgrade Tomcat to 8.5

2018-05-25 Thread GitBox
ajschmidt commented on a change in pull request #2331: Traffic Router upgrade Tomcat to 8.5 URL: https://github.com/apache/incubator-trafficcontrol/pull/2331#discussion_r191029242 ## File path: VERSION ## @@ -1 +1 @@ -2.3.0 Review comment: Oh, and the previous

[GitHub] asfgit commented on issue #2337: Geolocation-based client steering

2018-05-25 Thread GitBox
asfgit commented on issue #2337: Geolocation-based client steering URL: https://github.com/apache/incubator-trafficcontrol/pull/2337#issuecomment-392194464 Refer to this link for build results (access rights to CI server needed):

[GitHub] asfgit commented on issue #2320: Start of integration tests for Grove

2018-05-25 Thread GitBox
asfgit commented on issue #2320: Start of integration tests for Grove URL: https://github.com/apache/incubator-trafficcontrol/pull/2320#issuecomment-392205986 Refer to this link for build results (access rights to CI server needed):

[GitHub] dangogh closed issue #2053: TO goose migration fails with "permission denied"

2018-05-24 Thread GitBox
dangogh closed issue #2053: TO goose migration fails with "permission denied" URL: https://github.com/apache/incubator-trafficcontrol/issues/2053 This is an automated message from the Apache Git Service. To respond to the

[GitHub] rob05c commented on a change in pull request #2282: Deliveryservice_Server API conversion to Go - formerly #2269

2018-05-24 Thread GitBox
rob05c commented on a change in pull request #2282: Deliveryservice_Server API conversion to Go - formerly #2269 URL: https://github.com/apache/incubator-trafficcontrol/pull/2282#discussion_r190616966 ## File path: traffic_ops/traffic_ops_golang/routes.go ## @@ -156,7

[GitHub] rob05c commented on a change in pull request #2282: Deliveryservice_Server API conversion to Go - formerly #2269

2018-05-24 Thread GitBox
rob05c commented on a change in pull request #2282: Deliveryservice_Server API conversion to Go - formerly #2269 URL: https://github.com/apache/incubator-trafficcontrol/pull/2282#discussion_r190610400 ## File path: traffic_ops/traffic_ops_golang/routes.go ## @@ -156,7

[GitHub] guzzijason opened a new issue #2326: TP: [RFE] addition of "NOT" (!) operator in search fields

2018-05-24 Thread GitBox
guzzijason opened a new issue #2326: TP: [RFE] addition of "NOT" (!) operator in search fields URL: https://github.com/apache/incubator-trafficcontrol/issues/2326 Today, we have the ability to search using `^` and `$` characters. As a user of Traffic Portal, it would also be useful to be

[GitHub] rob05c commented on a change in pull request #2282: Deliveryservice_Server API conversion to Go - formerly #2269

2018-05-24 Thread GitBox
rob05c commented on a change in pull request #2282: Deliveryservice_Server API conversion to Go - formerly #2269 URL: https://github.com/apache/incubator-trafficcontrol/pull/2282#discussion_r190612184 ## File path: traffic_ops/traffic_ops_golang/deliveryservice/servers/servers.go

[GitHub] dewrich commented on issue #2327: updated the Traffic Router docker compose file

2018-05-24 Thread GitBox
dewrich commented on issue #2327: updated the Traffic Router docker compose file URL: https://github.com/apache/incubator-trafficcontrol/pull/2327#issuecomment-391773960 @dangogh I forgot to put that back because I ran into an error that was something else, so I wasn't sure what the `:z`

[GitHub] asfgit commented on issue #2327: updated the Traffic Router docker compose file

2018-05-24 Thread GitBox
asfgit commented on issue #2327: updated the Traffic Router docker compose file URL: https://github.com/apache/incubator-trafficcontrol/pull/2327#issuecomment-391783890 Refer to this link for build results (access rights to CI server needed):

[GitHub] asfgit commented on issue #2124: Add TO Go deliveryservices routes

2018-05-24 Thread GitBox
asfgit commented on issue #2124: Add TO Go deliveryservices routes URL: https://github.com/apache/incubator-trafficcontrol/pull/2124#issuecomment-391788793 Refer to this link for build results (access rights to CI server needed):

[GitHub] dewrich opened a new pull request #2327: updated the Traffic Router docker compose file

2018-05-24 Thread GitBox
dewrich opened a new pull request #2327: updated the Traffic Router docker compose file URL: https://github.com/apache/incubator-trafficcontrol/pull/2327 Now creates a host volume for the .m2 directory to improve build performance

[GitHub] rob05c commented on issue #2282: Deliveryservice_Server API conversion to Go - formerly #2269

2018-05-24 Thread GitBox
rob05c commented on issue #2282: Deliveryservice_Server API conversion to Go - formerly #2269 URL: https://github.com/apache/incubator-trafficcontrol/pull/2282#issuecomment-391756171 Ok, I tested all the endpoints, they all work correctly, except the previous comments

[GitHub] rob05c commented on issue #2282: Deliveryservice_Server API conversion to Go - formerly #2269

2018-05-24 Thread GitBox
rob05c commented on issue #2282: Deliveryservice_Server API conversion to Go - formerly #2269 URL: https://github.com/apache/incubator-trafficcontrol/pull/2282#issuecomment-391756171 Ok, I tested all the endpoints, they all work correctly, except the above comments

[GitHub] dewrich closed pull request #2247: Add an Origin API

2018-05-24 Thread GitBox
dewrich closed pull request #2247: Add an Origin API URL: https://github.com/apache/incubator-trafficcontrol/pull/2247 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] nerdynick commented on issue #2289: Foundation for Java Api Client

2018-05-24 Thread GitBox
nerdynick commented on issue #2289: Foundation for Java Api Client URL: https://github.com/apache/incubator-trafficcontrol/pull/2289#issuecomment-391758344 @dewrich Apache License added to all files This is an automated

[GitHub] asfgit commented on issue #2314: Remove deliveryservice.org_server_fqdn column/compute it from Origin table

2018-05-24 Thread GitBox
asfgit commented on issue #2314: Remove deliveryservice.org_server_fqdn column/compute it from Origin table URL: https://github.com/apache/incubator-trafficcontrol/pull/2314#issuecomment-391768499 Refer to this link for build results (access rights to CI server needed):

[GitHub] dangogh commented on issue #2124: Add TO Go deliveryservices routes

2018-05-24 Thread GitBox
dangogh commented on issue #2124: Add TO Go deliveryservices routes URL: https://github.com/apache/incubator-trafficcontrol/pull/2124#issuecomment-391800962 don't forget to add the new vendor'd dirs to `.rat-excludes` This

[GitHub] dangogh closed issue #1573: Traffic Ops postinstall must add new keys to cdn.conf

2018-05-24 Thread GitBox
dangogh closed issue #1573: Traffic Ops postinstall must add new keys to cdn.conf URL: https://github.com/apache/incubator-trafficcontrol/issues/1573 This is an automated message from the Apache Git Service. To respond to

[GitHub] dangogh commented on issue #1573: Traffic Ops postinstall must add new keys to cdn.conf

2018-05-24 Thread GitBox
dangogh commented on issue #1573: Traffic Ops postinstall must add new keys to cdn.conf URL: https://github.com/apache/incubator-trafficcontrol/issues/1573#issuecomment-391811029 this was fixed in #1350 This is an

[GitHub] asfgit commented on issue #2329: TO postinstall - generateCert no longer overwrites cdn.conf

2018-05-24 Thread GitBox
asfgit commented on issue #2329: TO postinstall - generateCert no longer overwrites cdn.conf URL: https://github.com/apache/incubator-trafficcontrol/pull/2329#issuecomment-391835664 Refer to this link for build results (access rights to CI server needed):

[GitHub] mitchell852 closed issue #2145: Remove redundant profileparam API routes

2018-05-24 Thread GitBox
mitchell852 closed issue #2145: Remove redundant profileparam API routes URL: https://github.com/apache/incubator-trafficcontrol/issues/2145 This is an automated message from the Apache Git Service. To respond to the

[GitHub] dangogh opened a new issue #2328: TO: generateCert not reading cdn.conf before writing over it

2018-05-24 Thread GitBox
dangogh opened a new issue #2328: TO: generateCert not reading cdn.conf before writing over it URL: https://github.com/apache/incubator-trafficcontrol/issues/2328 generateCert reads the cdn.conf, but assumes it's Perl -- needs to read and write as JSON

[GitHub] mitchell852 closed issue #898: [TC-494] Clone DS assignments button on Server times out

2018-05-24 Thread GitBox
mitchell852 closed issue #898: [TC-494] Clone DS assignments button on Server times out URL: https://github.com/apache/incubator-trafficcontrol/issues/898 This is an automated message from the Apache Git Service. To respond

[GitHub] jhg03a commented on issue #2312: Provide the ability to fetch all children tenants for a specified tenant

2018-05-24 Thread GitBox
jhg03a commented on issue #2312: Provide the ability to fetch all children tenants for a specified tenant URL: https://github.com/apache/incubator-trafficcontrol/issues/2312#issuecomment-391841225 Agreed. Preferably any parameter that could take a number should also take a name. It's

[GitHub] mitchell852 commented on issue #2312: Provide the ability to fetch all children tenants for a specified tenant

2018-05-24 Thread GitBox
mitchell852 commented on issue #2312: Provide the ability to fetch all children tenants for a specified tenant URL: https://github.com/apache/incubator-trafficcontrol/issues/2312#issuecomment-390756744 It sounds like you want 2 things really: 1. GET /api/tenants/:id?children=true

<    1   2   3   4   5   6   7   8   9   10   >