[GitHub] dangogh opened a new pull request #2641: fix cdn-in-a-box issues; add comments

2018-08-07 Thread GitBox
dangogh opened a new pull request #2641: fix cdn-in-a-box issues; add comments URL: https://github.com/apache/trafficcontrol/pull/2641 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] ocket8888 commented on issue #2638: Adding edge

2018-08-07 Thread GitBox
ocket commented on issue #2638: Adding edge URL: https://github.com/apache/trafficcontrol/pull/2638#issuecomment-411154174 I don't understand that merge conflict. It's only insertions, why isn't that just part of the changes?

[GitHub] dangogh closed pull request #2638: Adding edge

2018-08-07 Thread GitBox
dangogh closed pull request #2638: Adding edge URL: https://github.com/apache/trafficcontrol/pull/2638 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a

[GitHub] ocket8888 opened a new pull request #2640: Fixing monitor

2018-08-07 Thread GitBox
ocket opened a new pull request #2640: Fixing monitor URL: https://github.com/apache/trafficcontrol/pull/2640 Imports server configuration into Traffic Ops and sets it up to monitor the edge cache group. This is an

[GitHub] ocket8888 commented on issue #2638: Adding edge

2018-08-07 Thread GitBox
ocket commented on issue #2638: Adding edge URL: https://github.com/apache/trafficcontrol/pull/2638#issuecomment-411164760 Oh, that's weird. I just did another rebase and found more conflicts than last time. This is an

[GitHub] ocket8888 commented on issue #2638: Adding edge

2018-08-07 Thread GitBox
ocket commented on issue #2638: Adding edge URL: https://github.com/apache/trafficcontrol/pull/2638#issuecomment-411162940 I rebased on master and force-pushed twice, but it's still giving me this merge conflict. This is

[GitHub] asfgit commented on issue #2640: Fixing monitor

2018-08-07 Thread GitBox
asfgit commented on issue #2640: Fixing monitor URL: https://github.com/apache/trafficcontrol/pull/2640#issuecomment-411186034 Can one of the admins verify this patch? This is an automated message from the Apache Git Service.

[GitHub] dangogh commented on issue #2638: Adding edge

2018-08-07 Thread GitBox
dangogh commented on issue #2638: Adding edge URL: https://github.com/apache/trafficcontrol/pull/2638#issuecomment-411161579 because I also added things to the docker-compose.yml at the same place. So it doesn't know that they're both additions that need to be kept. If it did, it's not

[GitHub] rob05c commented on issue #2556: TO Go: profileparameters endpoint has different JSON form Perl vs Go

2018-08-07 Thread GitBox
rob05c commented on issue #2556: TO Go: profileparameters endpoint has different JSON form Perl vs Go URL: https://github.com/apache/trafficcontrol/issues/2556#issuecomment-411170422 @mitchell852 I did not

[GitHub] MattMills opened a new issue #2644: Mid DS data is not limited to active delivery services

2018-08-08 Thread GitBox
MattMills opened a new issue #2644: Mid DS data is not limited to active delivery services URL: https://github.com/apache/trafficcontrol/issues/2644 On this line: https://github.com/apache/trafficcontrol/blob/master/traffic_ops/app/lib/API/Configs/ApacheTrafficServer.pm#L1127 There

[GitHub] dangogh closed pull request #2643: adds missing license header

2018-08-08 Thread GitBox
dangogh closed pull request #2643: adds missing license header URL: https://github.com/apache/trafficcontrol/pull/2643 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] asfgit commented on issue #2632: adds ds bps, tps and http status charts

2018-08-08 Thread GitBox
asfgit commented on issue #2632: adds ds bps, tps and http status charts URL: https://github.com/apache/trafficcontrol/pull/2632#issuecomment-411446083 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/2206/

[GitHub] dangogh closed pull request #2632: adds ds bps, tps and http status charts

2018-08-08 Thread GitBox
dangogh closed pull request #2632: adds ds bps, tps and http status charts URL: https://github.com/apache/trafficcontrol/pull/2632 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] asfgit commented on issue #2453: show / hide TP views based on a users capabilities

2018-08-08 Thread GitBox
asfgit commented on issue #2453: show / hide TP views based on a users capabilities URL: https://github.com/apache/trafficcontrol/pull/2453#issuecomment-411448014 Refer to this link for build results (access rights to CI server needed):

[GitHub] dangogh commented on issue #2640: Fixing monitor

2018-08-08 Thread GitBox
dangogh commented on issue #2640: Fixing monitor URL: https://github.com/apache/trafficcontrol/pull/2640#issuecomment-411450134 add to whitelist This is an automated message from the Apache Git Service. To respond to the

[GitHub] asfgit commented on issue #2640: Fixing monitor

2018-08-08 Thread GitBox
asfgit commented on issue #2640: Fixing monitor URL: https://github.com/apache/trafficcontrol/pull/2640#issuecomment-411451401 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/2208/ Test FAILed.

[GitHub] mitchell852 commented on issue #2635: Fixes #2397 - Removed NOT NULL constraints on 'value' from parameters…

2018-08-08 Thread GitBox
mitchell852 commented on issue #2635: Fixes #2397 - Removed NOT NULL constraints on 'value' from parameters… URL: https://github.com/apache/trafficcontrol/pull/2635#issuecomment-411424032 @rob05c - the use case fyi is #2397

[GitHub] mitchell852 commented on issue #2453: show / hide TP views based on a users capabilities

2018-08-08 Thread GitBox
mitchell852 commented on issue #2453: show / hide TP views based on a users capabilities URL: https://github.com/apache/trafficcontrol/pull/2453#issuecomment-411446517 retest this please This is an automated message from

[GitHub] ocket8888 commented on issue #2640: Fixing monitor

2018-08-08 Thread GitBox
ocket commented on issue #2640: Fixing monitor URL: https://github.com/apache/trafficcontrol/pull/2640#issuecomment-411466963 What test? This is an automated message from the Apache Git Service. To respond to the

[GitHub] mitchell852 closed pull request #2609: Manage Static DNS Entries - front end CRUD implementation

2018-08-13 Thread GitBox
mitchell852 closed pull request #2609: Manage Static DNS Entries - front end CRUD implementation URL: https://github.com/apache/trafficcontrol/pull/2609 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] dewrich commented on a change in pull request #2656: properly handle db timeouts in when checking user during authorization

2018-08-13 Thread GitBox
dewrich commented on a change in pull request #2656: properly handle db timeouts in when checking user during authorization URL: https://github.com/apache/trafficcontrol/pull/2656#discussion_r209742387 ## File path: traffic_ops/traffic_ops_golang/auth/authorize.go ## @@

[GitHub] mitchell852 commented on a change in pull request #2665: Add TO old UI deprecation bar

2018-08-13 Thread GitBox
mitchell852 commented on a change in pull request #2665: Add TO old UI deprecation bar URL: https://github.com/apache/trafficcontrol/pull/2665#discussion_r209746977 ## File path: traffic_ops/app/conf/cdn.conf ## @@ -43,6 +43,7 @@ }, "portal" : {

[GitHub] mitchell852 commented on a change in pull request #2665: Add TO old UI deprecation bar

2018-08-13 Thread GitBox
mitchell852 commented on a change in pull request #2665: Add TO old UI deprecation bar URL: https://github.com/apache/trafficcontrol/pull/2665#discussion_r209752698 ## File path: traffic_ops/app/conf/cdn.conf ## @@ -43,6 +43,7 @@ }, "portal" : {

[GitHub] rob05c commented on a change in pull request #2653: Fix TO Go routes to all use transactions and timeouts

2018-08-13 Thread GitBox
rob05c commented on a change in pull request #2653: Fix TO Go routes to all use transactions and timeouts URL: https://github.com/apache/trafficcontrol/pull/2653#discussion_r209756497 ## File path: traffic_ops/traffic_ops_golang/monitoring/monitoring.go ## @@ -110,56

[GitHub] rob05c commented on a change in pull request #2653: Fix TO Go routes to all use transactions and timeouts

2018-08-13 Thread GitBox
rob05c commented on a change in pull request #2653: Fix TO Go routes to all use transactions and timeouts URL: https://github.com/apache/trafficcontrol/pull/2653#discussion_r209756497 ## File path: traffic_ops/traffic_ops_golang/monitoring/monitoring.go ## @@ -110,56

[GitHub] rob05c commented on a change in pull request #2653: Fix TO Go routes to all use transactions and timeouts

2018-08-13 Thread GitBox
rob05c commented on a change in pull request #2653: Fix TO Go routes to all use transactions and timeouts URL: https://github.com/apache/trafficcontrol/pull/2653#discussion_r209757007 ## File path: traffic_ops/traffic_ops_golang/crconfig/handler.go ## @@ -20,223 +20,146

[GitHub] rob05c commented on a change in pull request #2653: Fix TO Go routes to all use transactions and timeouts

2018-08-13 Thread GitBox
rob05c commented on a change in pull request #2653: Fix TO Go routes to all use transactions and timeouts URL: https://github.com/apache/trafficcontrol/pull/2653#discussion_r209757007 ## File path: traffic_ops/traffic_ops_golang/crconfig/handler.go ## @@ -20,223 +20,146

[GitHub] rob05c opened a new pull request #2665: Add TO old UI deprecation bar

2018-08-13 Thread GitBox
rob05c opened a new pull request #2665: Add TO old UI deprecation bar URL: https://github.com/apache/trafficcontrol/pull/2665 Fixes #2662 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] asfgit commented on issue #2668: Traffic Ops - Admin.pl load_schema proper exit codes and eval

2018-08-13 Thread GitBox
asfgit commented on issue #2668: Traffic Ops - Admin.pl load_schema proper exit codes and eval URL: https://github.com/apache/trafficcontrol/pull/2668#issuecomment-412615559 Can one of the admins verify this patch? This is

[GitHub] dangogh commented on issue #2668: Traffic Ops - Admin.pl load_schema proper exit codes and eval

2018-08-13 Thread GitBox
dangogh commented on issue #2668: Traffic Ops - Admin.pl load_schema proper exit codes and eval URL: https://github.com/apache/trafficcontrol/pull/2668#issuecomment-412627849 add to whitelist This is an automated message

[GitHub] rob05c commented on a change in pull request #2665: Add TO old UI deprecation bar

2018-08-13 Thread GitBox
rob05c commented on a change in pull request #2665: Add TO old UI deprecation bar URL: https://github.com/apache/trafficcontrol/pull/2665#discussion_r209755686 ## File path: traffic_ops/app/templates/navbar.html.ep ## @@ -14,6 +14,7 @@ --> +WARNING: This old

[GitHub] DylanVolz opened a new issue #2669: use enums instead of raw strings

2018-08-13 Thread GitBox
DylanVolz opened a new issue #2669: use enums instead of raw strings URL: https://github.com/apache/trafficcontrol/issues/2669 everywhere we use raw strings that can be enums we should convert them. For example in cachegroup/queueupdate.go on line 47 "queue" and "dequeue" can be

[GitHub] JBevillC opened a new pull request #2668: Traffic Ops - Admin.pl load_schema proper exit codes and eval

2018-08-13 Thread GitBox
JBevillC opened a new pull request #2668: Traffic Ops - Admin.pl load_schema proper exit codes and eval URL: https://github.com/apache/trafficcontrol/pull/2668 This PR will fix the following related to issue #2667 in the traffic_ops component: - Update admin.pl load_schema function

[GitHub] asfgit commented on issue #2665: Add TO old UI deprecation bar

2018-08-13 Thread GitBox
asfgit commented on issue #2665: Add TO old UI deprecation bar URL: https://github.com/apache/trafficcontrol/pull/2665#issuecomment-412632969 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/2245/ Test

[GitHub] mitchell852 commented on a change in pull request #2665: Add TO old UI deprecation bar

2018-08-13 Thread GitBox
mitchell852 commented on a change in pull request #2665: Add TO old UI deprecation bar URL: https://github.com/apache/trafficcontrol/pull/2665#discussion_r209747676 ## File path: traffic_ops/app/templates/navbar.html.ep ## @@ -14,6 +14,7 @@ --> +WARNING: This old

[GitHub] rob05c commented on issue #2666: TO Golang: api.NewInfo Close() deferral postpones DB transaction commit until after API response is written

2018-08-13 Thread GitBox
rob05c commented on issue #2666: TO Golang: api.NewInfo Close() deferral postpones DB transaction commit until after API response is written URL: https://github.com/apache/trafficcontrol/issues/2666#issuecomment-412601783 Yeah, I've been considering changing `*inf.CommitTx = true` to a

[GitHub] JBevillC opened a new issue #2667: Traffic Ops - admin.pl load_schema function does not return proper exit codes

2018-08-13 Thread GitBox
JBevillC opened a new issue #2667: Traffic Ops - admin.pl load_schema function does not return proper exit codes URL: https://github.com/apache/trafficcontrol/issues/2667 **Traffic Ops** The admin.pl load_schema function does not correctly evaluate for sql error conditions for each

[GitHub] mitchell852 commented on a change in pull request #2665: Add TO old UI deprecation bar

2018-08-13 Thread GitBox
mitchell852 commented on a change in pull request #2665: Add TO old UI deprecation bar URL: https://github.com/apache/trafficcontrol/pull/2665#discussion_r209723176 ## File path: traffic_ops/app/conf/cdn.conf ## @@ -47,6 +47,7 @@ "pass_reset_path" : "user",

[GitHub] dewrich edited a comment on issue #2655: [Issue 2654] fix deepcachingtype retrieval in users/xx/deliveryservices

2018-08-13 Thread GitBox
dewrich edited a comment on issue #2655: [Issue 2654] fix deepcachingtype retrieval in users/xx/deliveryservices URL: https://github.com/apache/trafficcontrol/pull/2655#issuecomment-412640942 @dangogh Should there be an API test that shows the breakage is fixed?

[GitHub] mitchell852 commented on a change in pull request #2665: Add TO old UI deprecation bar

2018-08-13 Thread GitBox
mitchell852 commented on a change in pull request #2665: Add TO old UI deprecation bar URL: https://github.com/apache/trafficcontrol/pull/2665#discussion_r209747676 ## File path: traffic_ops/app/templates/navbar.html.ep ## @@ -14,6 +14,7 @@ --> +WARNING: This old

[GitHub] rawlinp commented on a change in pull request #2665: Add TO old UI deprecation bar

2018-08-13 Thread GitBox
rawlinp commented on a change in pull request #2665: Add TO old UI deprecation bar URL: https://github.com/apache/trafficcontrol/pull/2665#discussion_r209749372 ## File path: traffic_ops/app/conf/cdn.conf ## @@ -43,6 +43,7 @@ }, "portal" : { "base_url"

[GitHub] dewrich opened a new issue #2670: /api/1.3/servers error - "getting servers: sql: Rows are closed"

2018-08-13 Thread GitBox
dewrich opened a new issue #2670: /api/1.3/servers error - "getting servers: sql: Rows are closed" URL: https://github.com/apache/trafficcontrol/issues/2670 `/api/1.3/servers` returning alert error ```{ alerts: [ { text: "getting servers: sql: Rows are closed", level:

[GitHub] rob05c commented on a change in pull request #2653: Fix TO Go routes to all use transactions and timeouts

2018-08-13 Thread GitBox
rob05c commented on a change in pull request #2653: Fix TO Go routes to all use transactions and timeouts URL: https://github.com/apache/trafficcontrol/pull/2653#discussion_r209756203 ## File path: traffic_ops/traffic_ops_golang/profileparameter/unassignedparams.go ## @@

[GitHub] DylanVolz commented on a change in pull request #2656: properly handle db timeouts in when checking user during authorization

2018-08-13 Thread GitBox
DylanVolz commented on a change in pull request #2656: properly handle db timeouts in when checking user during authorization URL: https://github.com/apache/trafficcontrol/pull/2656#discussion_r209756347 ## File path: traffic_ops/traffic_ops_golang/auth/authorize.go ## @@

[GitHub] asfgit commented on issue #2660: Update version of Traffic Control to 3.0.0.

2018-08-13 Thread GitBox
asfgit commented on issue #2660: Update version of Traffic Control to 3.0.0. URL: https://github.com/apache/trafficcontrol/pull/2660#issuecomment-412670177 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/2246/

[GitHub] DylanVolz commented on a change in pull request #2653: Fix TO Go routes to all use transactions and timeouts

2018-08-13 Thread GitBox
DylanVolz commented on a change in pull request #2653: Fix TO Go routes to all use transactions and timeouts URL: https://github.com/apache/trafficcontrol/pull/2653#discussion_r209730554 ## File path: traffic_ops/traffic_ops_golang/monitoring/monitoring.go ## @@ -110,56

[GitHub] DylanVolz commented on a change in pull request #2653: Fix TO Go routes to all use transactions and timeouts

2018-08-13 Thread GitBox
DylanVolz commented on a change in pull request #2653: Fix TO Go routes to all use transactions and timeouts URL: https://github.com/apache/trafficcontrol/pull/2653#discussion_r209664633 ## File path: traffic_ops/traffic_ops_golang/crconfig/handler.go ## @@ -20,223

[GitHub] rob05c commented on a change in pull request #2665: Add TO old UI deprecation bar

2018-08-13 Thread GitBox
rob05c commented on a change in pull request #2665: Add TO old UI deprecation bar URL: https://github.com/apache/trafficcontrol/pull/2665#discussion_r209755248 ## File path: traffic_ops/app/conf/cdn.conf ## @@ -43,6 +43,7 @@ }, "portal" : { "base_url" :

[GitHub] DylanVolz commented on a change in pull request #2653: Fix TO Go routes to all use transactions and timeouts

2018-08-13 Thread GitBox
DylanVolz commented on a change in pull request #2653: Fix TO Go routes to all use transactions and timeouts URL: https://github.com/apache/trafficcontrol/pull/2653#discussion_r209753130 ## File path: traffic_ops/traffic_ops_golang/profileparameter/unassignedparams.go ##

[GitHub] dewrich commented on issue #2655: [Issue 2654] fix deepcachingtype retrieval in users/xx/deliveryservices

2018-08-13 Thread GitBox
dewrich commented on issue #2655: [Issue 2654] fix deepcachingtype retrieval in users/xx/deliveryservices URL: https://github.com/apache/trafficcontrol/pull/2655#issuecomment-412640942 @dangogh Should there be an API test that shows the breakage too?

[GitHub] mitchell852 commented on issue #2660: Update version of Traffic Control to 3.0.0.

2018-08-13 Thread GitBox
mitchell852 commented on issue #2660: Update version of Traffic Control to 3.0.0. URL: https://github.com/apache/trafficcontrol/pull/2660#issuecomment-412663073 retest this please This is an automated message from the Apache

[GitHub] mitchell852 commented on a change in pull request #2609: Manage Static DNS Entries - front end CRUD implementation

2018-08-13 Thread GitBox
mitchell852 commented on a change in pull request #2609: Manage Static DNS Entries - front end CRUD implementation URL: https://github.com/apache/trafficcontrol/pull/2609#discussion_r209687022 ## File path: traffic_portal/app/src/common/api/StaticDnsEntryService.js ## @@

[GitHub] rawlinp opened a new issue #2666: TO Golang: api.NewInfo Close() deferral postpones DB transaction commit until after API response is written

2018-08-13 Thread GitBox
rawlinp opened a new issue #2666: TO Golang: api.NewInfo Close() deferral postpones DB transaction commit until after API response is written URL: https://github.com/apache/trafficcontrol/issues/2666 General usage of `api.NewInfo()` [1] is that the `APIInfo.Close()` method is immediately

[GitHub] asfgit commented on issue #2665: Add TO old UI deprecation bar

2018-08-13 Thread GitBox
asfgit commented on issue #2665: Add TO old UI deprecation bar URL: https://github.com/apache/trafficcontrol/pull/2665#issuecomment-412600556 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/2243/ Test

[GitHub] asfgit commented on issue #2668: Traffic Ops - Admin.pl load_schema proper exit codes and eval

2018-08-13 Thread GitBox
asfgit commented on issue #2668: Traffic Ops - Admin.pl load_schema proper exit codes and eval URL: https://github.com/apache/trafficcontrol/pull/2668#issuecomment-412630078 Refer to this link for build results (access rights to CI server needed):

[GitHub] mitchell852 commented on issue #1301: Manage delivery service static dns entries

2018-08-13 Thread GitBox
mitchell852 commented on issue #1301: Manage delivery service static dns entries URL: https://github.com/apache/trafficcontrol/issues/1301#issuecomment-412672217 this is all done and merged This is an automated message from

[GitHub] ocket8888 commented on a change in pull request #2658: Cache script improvements

2018-08-15 Thread GitBox
ocket commented on a change in pull request #2658: Cache script improvements URL: https://github.com/apache/trafficcontrol/pull/2658#discussion_r210259720 ## File path: infrastructure/cdn-in-a-box/README.md ## @@ -1,44 +1,141 @@ + Licensed to the Apache

[GitHub] ocket8888 commented on a change in pull request #2658: Cache script improvements

2018-08-15 Thread GitBox
ocket commented on a change in pull request #2658: Cache script improvements URL: https://github.com/apache/trafficcontrol/pull/2658#discussion_r210260291 ## File path: infrastructure/cdn-in-a-box/README.md ## @@ -1,44 +1,141 @@ + Licensed to the Apache

[GitHub] dg4prez opened a new pull request #2686: adds maxRevalDurationDays to seeds.sql

2018-08-15 Thread GitBox
dg4prez opened a new pull request #2686: adds maxRevalDurationDays to seeds.sql URL: https://github.com/apache/trafficcontrol/pull/2686 adds the maxRevalDurationDays entry to global to seed new installs - TO does not function properly without this value.

[GitHub] ocket8888 commented on a change in pull request #2658: Cache script improvements

2018-08-15 Thread GitBox
ocket commented on a change in pull request #2658: Cache script improvements URL: https://github.com/apache/trafficcontrol/pull/2658#discussion_r210272338 ## File path: infrastructure/cdn-in-a-box/README.md ## @@ -1,44 +1,141 @@ + Licensed to the Apache

[GitHub] asfgit commented on issue #2686: adds maxRevalDurationDays to seeds.sql

2018-08-15 Thread GitBox
asfgit commented on issue #2686: adds maxRevalDurationDays to seeds.sql URL: https://github.com/apache/trafficcontrol/pull/2686#issuecomment-413234880 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/2267/

[GitHub] dangogh commented on a change in pull request #2658: Cache script improvements

2018-08-15 Thread GitBox
dangogh commented on a change in pull request #2658: Cache script improvements URL: https://github.com/apache/trafficcontrol/pull/2658#discussion_r210386102 ## File path: infrastructure/cdn-in-a-box/README.md ## @@ -1,44 +1,141 @@ + Licensed to the Apache Software

[GitHub] dangogh commented on a change in pull request #2658: Cache script improvements

2018-08-15 Thread GitBox
dangogh commented on a change in pull request #2658: Cache script improvements URL: https://github.com/apache/trafficcontrol/pull/2658#discussion_r210406095 ## File path: infrastructure/cdn-in-a-box/traffic_ops/to-access.sh ## @@ -30,66 +30,80 @@

[GitHub] dangogh closed pull request #2658: Cache script improvements

2018-08-15 Thread GitBox
dangogh closed pull request #2658: Cache script improvements URL: https://github.com/apache/trafficcontrol/pull/2658 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] dangogh commented on issue #2688: ensure use_tenancy set to 1 rather than deleting the parameter

2018-08-15 Thread GitBox
dangogh commented on issue #2688: ensure use_tenancy set to 1 rather than deleting the parameter URL: https://github.com/apache/trafficcontrol/pull/2688#issuecomment-413322802 modified the description to reflect that this is a temporary solution, not necessarily a fix

[GitHub] ocket8888 commented on a change in pull request #2658: Cache script improvements

2018-08-15 Thread GitBox
ocket commented on a change in pull request #2658: Cache script improvements URL: https://github.com/apache/trafficcontrol/pull/2658#discussion_r210397489 ## File path: infrastructure/cdn-in-a-box/traffic_ops/to-access.sh ## @@ -30,66 +30,80 @@

[GitHub] rivasj opened a new pull request #2689: Update Traffic Monitor to use TO Client v13

2018-08-15 Thread GitBox
rivasj opened a new pull request #2689: Update Traffic Monitor to use TO Client v13 URL: https://github.com/apache/trafficcontrol/pull/2689 - Changed TO client package in TM from /client to /client/v13 - Replaced deprecated TO client function calls in TM with updated counterparts -

[GitHub] asfgit commented on issue #2689: Update Traffic Monitor to use TO Client v13

2018-08-15 Thread GitBox
asfgit commented on issue #2689: Update Traffic Monitor to use TO Client v13 URL: https://github.com/apache/trafficcontrol/pull/2689#issuecomment-413337285 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/2270/

[GitHub] ocket8888 commented on a change in pull request #2658: Cache script improvements

2018-08-15 Thread GitBox
ocket commented on a change in pull request #2658: Cache script improvements URL: https://github.com/apache/trafficcontrol/pull/2658#discussion_r210400893 ## File path: infrastructure/cdn-in-a-box/traffic_ops/to-access.sh ## @@ -30,66 +30,80 @@

[GitHub] asfgit commented on issue #2658: Cache script improvements

2018-08-15 Thread GitBox
asfgit commented on issue #2658: Cache script improvements URL: https://github.com/apache/trafficcontrol/pull/2658#issuecomment-413336066 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/2269/ Test PASSed.

[GitHub] elsloo closed pull request #2690: OnThrowable memory leak fix for Traffic Router Issue #2223

2018-08-15 Thread GitBox
elsloo closed pull request #2690: OnThrowable memory leak fix for Traffic Router Issue #2223 URL: https://github.com/apache/trafficcontrol/pull/2690 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] tyagian commented on issue #2684: python lib updated to api v1.3

2018-08-15 Thread GitBox
tyagian commented on issue #2684: python lib updated to api v1.3 URL: https://github.com/apache/trafficcontrol/pull/2684#issuecomment-413350613 can anyone approve this? This is an automated message from the Apache Git

[GitHub] dneuman64 commented on a change in pull request #2684: python lib updated to api v1.3

2018-08-15 Thread GitBox
dneuman64 commented on a change in pull request #2684: python lib updated to api v1.3 URL: https://github.com/apache/trafficcontrol/pull/2684#discussion_r210430314 ## File path: traffic_control/clients/python/trafficops/trafficops/tosession.py ## @@ -146,10 +146,10 @@ def

[GitHub] dneuman64 commented on a change in pull request #2684: python lib updated to api v1.3

2018-08-15 Thread GitBox
dneuman64 commented on a change in pull request #2684: python lib updated to api v1.3 URL: https://github.com/apache/trafficcontrol/pull/2684#discussion_r210430448 ## File path: traffic_control/clients/python/trafficops/trafficops/tosession.py ## @@ -280,17 +280,17 @@ def

[GitHub] dneuman64 commented on a change in pull request #2684: python lib updated to api v1.3

2018-08-15 Thread GitBox
dneuman64 commented on a change in pull request #2684: python lib updated to api v1.3 URL: https://github.com/apache/trafficcontrol/pull/2684#discussion_r210430282 ## File path: traffic_control/clients/python/trafficops/trafficops/tosession.py ## @@ -66,7 +66,7 @@ class

[GitHub] dneuman64 commented on a change in pull request #2684: python lib updated to api v1.3

2018-08-15 Thread GitBox
dneuman64 commented on a change in pull request #2684: python lib updated to api v1.3 URL: https://github.com/apache/trafficcontrol/pull/2684#discussion_r210430773 ## File path: traffic_control/clients/python/trafficops/trafficops/tosession.py ## @@ -590,18 +590,18 @@ def

[GitHub] dneuman64 commented on a change in pull request #2684: python lib updated to api v1.3

2018-08-15 Thread GitBox
dneuman64 commented on a change in pull request #2684: python lib updated to api v1.3 URL: https://github.com/apache/trafficcontrol/pull/2684#discussion_r210430517 ## File path: traffic_control/clients/python/trafficops/trafficops/tosession.py ## @@ -331,17 +331,17 @@ def

[GitHub] mitchell852 commented on issue #2688: ensure use_tenancy set to 1 rather than deleting the parameter

2018-08-15 Thread GitBox
mitchell852 commented on issue #2688: ensure use_tenancy set to 1 rather than deleting the parameter URL: https://github.com/apache/trafficcontrol/pull/2688#issuecomment-413317546 This PR doesn't really "fix" #2687. The true fix is to remove any reference from anything (TP for example)

[GitHub] ocket8888 commented on a change in pull request #2658: Cache script improvements

2018-08-15 Thread GitBox
ocket commented on a change in pull request #2658: Cache script improvements URL: https://github.com/apache/trafficcontrol/pull/2658#discussion_r210398800 ## File path: infrastructure/cdn-in-a-box/traffic_ops/to-access.sh ## @@ -30,66 +30,80 @@

[GitHub] dewrich opened a new pull request #2690: removed code under OnThrowable that was causing yet another memory leak

2018-08-15 Thread GitBox
dewrich opened a new pull request #2690: removed code under OnThrowable that was causing yet another memory leak URL: https://github.com/apache/trafficcontrol/pull/2690 Additional Fix for #2223 This is an automated message

[GitHub] rob05c opened a new pull request #2691: Fix TO Go db nested query breaking dss post

2018-08-15 Thread GitBox
rob05c opened a new pull request #2691: Fix TO Go db nested query breaking dss post URL: https://github.com/apache/trafficcontrol/pull/2691 Incidentally, it also fixes the endpoint to correctly return a 4xx message when the association exists; it had been returning an Internal Server

[GitHub] dangogh commented on a change in pull request #2658: Cache script improvements

2018-08-15 Thread GitBox
dangogh commented on a change in pull request #2658: Cache script improvements URL: https://github.com/apache/trafficcontrol/pull/2658#discussion_r210386607 ## File path: infrastructure/cdn-in-a-box/README.md ## @@ -1,44 +1,141 @@ + Licensed to the Apache Software

[GitHub] dangogh opened a new pull request #2688: ensure use_tenancy set to 1 rather than deleting the parameter

2018-08-15 Thread GitBox
dangogh opened a new pull request #2688: ensure use_tenancy set to 1 rather than deleting the parameter URL: https://github.com/apache/trafficcontrol/pull/2688 this ensures that code dependent on this parameter continues to work. That code should be eliminated prior to deleting this

[GitHub] dangogh opened a new issue #2687: TP /users/:id/delivery-services shows `{{user.username}}`

2018-08-15 Thread GitBox
dangogh opened a new issue #2687: TP /users/:id/delivery-services shows `{{user.username}}` URL: https://github.com/apache/trafficcontrol/issues/2687 username isn't being replaced in the template. Probable cause is the recent removal of the `use_tenancy` property.

[GitHub] mitchell852 commented on issue #2687: TP /users/:id/delivery-services shows `{{user.username}}`

2018-08-15 Thread GitBox
mitchell852 commented on issue #2687: TP /users/:id/delivery-services shows `{{user.username}}` URL: https://github.com/apache/trafficcontrol/issues/2687#issuecomment-413258085 TP is trying to fetch the useTenancy parameter to figure out if tenancy is enabled or not but since tenancy is

[GitHub] asfgit commented on issue #2688: ensure use_tenancy set to 1 rather than deleting the parameter

2018-08-15 Thread GitBox
asfgit commented on issue #2688: ensure use_tenancy set to 1 rather than deleting the parameter URL: https://github.com/apache/trafficcontrol/pull/2688#issuecomment-413268069 Refer to this link for build results (access rights to CI server needed):

[GitHub] dangogh commented on a change in pull request #2658: Cache script improvements

2018-08-15 Thread GitBox
dangogh commented on a change in pull request #2658: Cache script improvements URL: https://github.com/apache/trafficcontrol/pull/2658#discussion_r210383671 ## File path: infrastructure/cdn-in-a-box/traffic_ops/to-access.sh ## @@ -30,66 +30,80 @@

[GitHub] dangogh commented on a change in pull request #2658: Cache script improvements

2018-08-15 Thread GitBox
dangogh commented on a change in pull request #2658: Cache script improvements URL: https://github.com/apache/trafficcontrol/pull/2658#discussion_r210383324 ## File path: infrastructure/cdn-in-a-box/traffic_ops/to-access.sh ## @@ -30,66 +30,80 @@

[GitHub] asfgit commented on issue #2691: Fix TO Go db nested query breaking dss post

2018-08-15 Thread GitBox
asfgit commented on issue #2691: Fix TO Go db nested query breaking dss post URL: https://github.com/apache/trafficcontrol/pull/2691#issuecomment-413368028 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/2271/

[GitHub] JBevillC commented on issue #2668: Traffic Ops - Admin.pl load_schema proper exit codes and eval

2018-08-15 Thread GitBox
JBevillC commented on issue #2668: Traffic Ops - Admin.pl load_schema proper exit codes and eval URL: https://github.com/apache/trafficcontrol/pull/2668#issuecomment-413390049 I reviewed the build log file and the failure doesn't seem to be related to my PR. On line 17145 of the build

[GitHub] rawlinp closed pull request #2671: TO Go API: fix origin api tests -- add a tenantId

2018-08-13 Thread GitBox
rawlinp closed pull request #2671: TO Go API: fix origin api tests -- add a tenantId URL: https://github.com/apache/trafficcontrol/pull/2671 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] asfgit commented on issue #2656: properly handle db timeouts in when checking user during authorization

2018-08-13 Thread GitBox
asfgit commented on issue #2656: properly handle db timeouts in when checking user during authorization URL: https://github.com/apache/trafficcontrol/pull/2656#issuecomment-412683290 Refer to this link for build results (access rights to CI server needed):

[GitHub] dangogh opened a new pull request #2672: TO Go: add not null constraint to deep_caching_type

2018-08-13 Thread GitBox
dangogh opened a new pull request #2672: TO Go: add not null constraint to deep_caching_type URL: https://github.com/apache/trafficcontrol/pull/2672 related to #2654 This is an automated message from the Apache Git

[GitHub] asfgit commented on issue #2672: TO Go: add not null constraint to deep_caching_type

2018-08-13 Thread GitBox
asfgit commented on issue #2672: TO Go: add not null constraint to deep_caching_type URL: https://github.com/apache/trafficcontrol/pull/2672#issuecomment-412701165 Refer to this link for build results (access rights to CI server needed):

[GitHub] rob05c commented on issue #2656: properly handle db timeouts in when checking user during authorization

2018-08-13 Thread GitBox
rob05c commented on issue #2656: properly handle db timeouts in when checking user during authorization URL: https://github.com/apache/trafficcontrol/pull/2656#issuecomment-412685361 Tested, works. This is an automated

[GitHub] mitchell852 commented on a change in pull request #2665: Add TO old UI deprecation bar

2018-08-13 Thread GitBox
mitchell852 commented on a change in pull request #2665: Add TO old UI deprecation bar URL: https://github.com/apache/trafficcontrol/pull/2665#discussion_r209806785 ## File path: traffic_ops/app/conf/cdn.conf ## @@ -43,6 +43,7 @@ }, "portal" : {

[GitHub] asfgit commented on issue #2673: adds a simple PR template

2018-08-13 Thread GitBox
asfgit commented on issue #2673: adds a simple PR template URL: https://github.com/apache/trafficcontrol/pull/2673#issuecomment-412727546 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/2251/ Test FAILed.

[GitHub] asfgit commented on issue #2673: adds a simple PR template

2018-08-13 Thread GitBox
asfgit commented on issue #2673: adds a simple PR template URL: https://github.com/apache/trafficcontrol/pull/2673#issuecomment-412731254 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/2253/ Test FAILed.

[GitHub] asfgit commented on issue #2673: adds a simple PR template

2018-08-13 Thread GitBox
asfgit commented on issue #2673: adds a simple PR template URL: https://github.com/apache/trafficcontrol/pull/2673#issuecomment-412731155 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/2252/ Test FAILed.

[GitHub] asfgit commented on issue #2673: adds a simple PR template

2018-08-13 Thread GitBox
asfgit commented on issue #2673: adds a simple PR template URL: https://github.com/apache/trafficcontrol/pull/2673#issuecomment-412735203 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/2254/ Test PASSed.

<    7   8   9   10   11   12   13   14   15   16   >