[GitHub] dangogh commented on a change in pull request #2673: adds a simple PR template

2018-08-13 Thread GitBox
dangogh commented on a change in pull request #2673: adds a simple PR template URL: https://github.com/apache/trafficcontrol/pull/2673#discussion_r209819601 ## File path: PULL_REQUEST_TEMPLATE.md ## @@ -0,0 +1,27 @@ + What does this PR do? + +Fixes #(issue_number) +

[GitHub] asfgit commented on issue #2671: TO Go API: fix origin api tests -- add a tenantId

2018-08-13 Thread GitBox
asfgit commented on issue #2671: TO Go API: fix origin api tests -- add a tenantId URL: https://github.com/apache/trafficcontrol/pull/2671#issuecomment-412696687 Refer to this link for build results (access rights to CI server needed):

[GitHub] mitchell852 opened a new pull request #2673: adds a simple PR template

2018-08-13 Thread GitBox
mitchell852 opened a new pull request #2673: adds a simple PR template URL: https://github.com/apache/trafficcontrol/pull/2673 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] rob05c commented on issue #2659: Add Monitor poll plugins

2018-08-13 Thread GitBox
rob05c commented on issue #2659: Add Monitor poll plugins URL: https://github.com/apache/trafficcontrol/pull/2659#issuecomment-412674113 retest this please This is an automated message from the Apache Git Service. To respond

[GitHub] mitchell852 closed issue #1301: Manage delivery service static dns entries

2018-08-13 Thread GitBox
mitchell852 closed issue #1301: Manage delivery service static dns entries URL: https://github.com/apache/trafficcontrol/issues/1301 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] mitchell852 closed pull request #2660: Update version of Traffic Control to 3.0.0.

2018-08-13 Thread GitBox
mitchell852 closed pull request #2660: Update version of Traffic Control to 3.0.0. URL: https://github.com/apache/trafficcontrol/pull/2660 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] asfgit commented on issue #2660: Update version of Traffic Control to 3.0.0.

2018-08-13 Thread GitBox
asfgit commented on issue #2660: Update version of Traffic Control to 3.0.0. URL: https://github.com/apache/trafficcontrol/pull/2660#issuecomment-412677518 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/2247/

[GitHub] dangogh opened a new pull request #2671: TO Go API: fix origin api tests -- add a tenantId

2018-08-13 Thread GitBox
dangogh opened a new pull request #2671: TO Go API: fix origin api tests -- add a tenantId URL: https://github.com/apache/trafficcontrol/pull/2671 api test for origins is missing tenant id which causes it to fail on the new not-null db constraint.

[GitHub] rawlinp closed pull request #2672: TO Go: add not null constraint to deep_caching_type

2018-08-13 Thread GitBox
rawlinp closed pull request #2672: TO Go: add not null constraint to deep_caching_type URL: https://github.com/apache/trafficcontrol/pull/2672 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] rob05c opened a new pull request #2675: Fix TM tests

2018-08-14 Thread GitBox
rob05c opened a new pull request #2675: Fix TM tests URL: https://github.com/apache/trafficcontrol/pull/2675 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use

[GitHub] elsloo opened a new pull request #2678: Changes download of Tomcat to use curl over wget

2018-08-14 Thread GitBox
elsloo opened a new pull request #2678: Changes download of Tomcat to use curl over wget URL: https://github.com/apache/trafficcontrol/pull/2678 Changes download of Tomcat to use curl over wget and made slight tweaks to the dnssec curl to match. This resolves #2676.

[GitHub] dangogh closed pull request #2678: Changes download of Tomcat to use curl over wget

2018-08-14 Thread GitBox
dangogh closed pull request #2678: Changes download of Tomcat to use curl over wget URL: https://github.com/apache/trafficcontrol/pull/2678 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] dangogh closed issue #2676: traffic_router build failure in master

2018-08-14 Thread GitBox
dangogh closed issue #2676: traffic_router build failure in master URL: https://github.com/apache/trafficcontrol/issues/2676 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] JordanBrosch opened a new pull request #2677: Fixing some grammatical mistakes.

2018-08-14 Thread GitBox
JordanBrosch opened a new pull request #2677: Fixing some grammatical mistakes. URL: https://github.com/apache/trafficcontrol/pull/2677 Fixing some grammatical mistakes. "In stead" to "Instead", "And ``ETag``" to "An ``ETag``".

[GitHub] dangogh opened a new issue #2676: traffic_router build failure in master

2018-08-14 Thread GitBox
dangogh opened a new issue #2676: traffic_router build failure in master URL: https://github.com/apache/trafficcontrol/issues/2676 Latest master build failed in Jenkins: https://builds.apache.org/view/S-Z/view/TrafficControl/job/trafficcontrol-master-build/997/console ```

[GitHub] asfgit commented on issue #2675: Fix TM tests

2018-08-14 Thread GitBox
asfgit commented on issue #2675: Fix TM tests URL: https://github.com/apache/trafficcontrol/pull/2675#issuecomment-412954631 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/2261/ Test PASSed.

[GitHub] asfgit commented on issue #2677: Fixing some grammatical mistakes.

2018-08-14 Thread GitBox
asfgit commented on issue #2677: Fixing some grammatical mistakes. URL: https://github.com/apache/trafficcontrol/pull/2677#issuecomment-412959171 Can one of the admins verify this patch? This is an automated message from the

[GitHub] rawlinp closed pull request #2680: Fix TM not starting with null ds matchset

2018-08-14 Thread GitBox
rawlinp closed pull request #2680: Fix TM not starting with null ds matchset URL: https://github.com/apache/trafficcontrol/pull/2680 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] DylanVolz closed pull request #2681: Fix TO Go CRConfig missing db commits

2018-08-14 Thread GitBox
DylanVolz closed pull request #2681: Fix TO Go CRConfig missing db commits URL: https://github.com/apache/trafficcontrol/pull/2681 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] rob05c opened a new pull request #2679: Fix Traffic Ops unit tests

2018-08-14 Thread GitBox
rob05c opened a new pull request #2679: Fix Traffic Ops unit tests URL: https://github.com/apache/trafficcontrol/pull/2679 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] rob05c closed pull request #1647: Fix Monitor Go tests

2018-08-14 Thread GitBox
rob05c closed pull request #1647: Fix Monitor Go tests URL: https://github.com/apache/trafficcontrol/pull/1647 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request

[GitHub] rob05c commented on issue #1647: Fix Monitor Go tests

2018-08-14 Thread GitBox
rob05c commented on issue #1647: Fix Monitor Go tests URL: https://github.com/apache/trafficcontrol/pull/1647#issuecomment-412985556 Closing, because I just duplicated this work and it was merged in https://github.com/apache/trafficcontrol/pull/2675

[GitHub] DylanVolz closed pull request #2675: Fix TM tests

2018-08-14 Thread GitBox
DylanVolz closed pull request #2675: Fix TM tests URL: https://github.com/apache/trafficcontrol/pull/2675 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a

[GitHub] rob05c opened a new pull request #2680: Fix TM not starting with null ds matchset

2018-08-14 Thread GitBox
rob05c opened a new pull request #2680: Fix TM not starting with null ds matchset URL: https://github.com/apache/trafficcontrol/pull/2680 Same issue as https://github.com/apache/trafficcontrol/pull/2091 just manifesting in a different place.

[GitHub] DylanVolz closed pull request #2679: Fix Traffic Ops unit tests

2018-08-14 Thread GitBox
DylanVolz closed pull request #2679: Fix Traffic Ops unit tests URL: https://github.com/apache/trafficcontrol/pull/2679 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] rob05c opened a new pull request #2681: Fix TO Go CRConfig missing db commits

2018-08-14 Thread GitBox
rob05c opened a new pull request #2681: Fix TO Go CRConfig missing db commits URL: https://github.com/apache/trafficcontrol/pull/2681 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] asfgit commented on issue #2674: Only route clients to cachegroups enabled for the localization method used

2018-08-14 Thread GitBox
asfgit commented on issue #2674: Only route clients to cachegroups enabled for the localization method used URL: https://github.com/apache/trafficcontrol/pull/2674#issuecomment-413009647 Refer to this link for build results (access rights to CI server needed):

[GitHub] asfgit commented on issue #2679: Fix Traffic Ops unit tests

2018-08-14 Thread GitBox
asfgit commented on issue #2679: Fix Traffic Ops unit tests URL: https://github.com/apache/trafficcontrol/pull/2679#issuecomment-412993875 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/2262/ Test FAILed.

[GitHub] asfgit commented on issue #2680: Fix TM not starting with null ds matchset

2018-08-14 Thread GitBox
asfgit commented on issue #2680: Fix TM not starting with null ds matchset URL: https://github.com/apache/trafficcontrol/pull/2680#issuecomment-413000776 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/2263/

[GitHub] dangogh opened a new issue #2682: TO Go POST /api/1.3/servers database access error

2018-08-14 Thread GitBox
dangogh opened a new issue #2682: TO Go POST /api/1.3/servers database access error URL: https://github.com/apache/trafficcontrol/issues/2682 a `POST` to `/api/1.3/servers` results in a database access error if the profile indicated by the `profileId` has `cdn` entry that is null. The

[GitHub] asfgit commented on issue #2674: Only route clients to cachegroups enabled for the localization method used

2018-08-14 Thread GitBox
asfgit commented on issue #2674: Only route clients to cachegroups enabled for the localization method used URL: https://github.com/apache/trafficcontrol/pull/2674#issuecomment-413028978 Refer to this link for build results (access rights to CI server needed):

[GitHub] asfgit commented on issue #2684: python lib updated to api v1.3

2018-08-14 Thread GitBox
asfgit commented on issue #2684: python lib updated to api v1.3 URL: https://github.com/apache/trafficcontrol/pull/2684#issuecomment-413040016 Can one of the admins verify this patch? This is an automated message from the

[GitHub] dangogh commented on issue #2682: TO Go POST /api/1.3/servers database access error

2018-08-14 Thread GitBox
dangogh commented on issue #2682: TO Go POST /api/1.3/servers database access error URL: https://github.com/apache/trafficcontrol/issues/2682#issuecomment-413044877 alternatively, perhaps that cdn column needs to be not null with the default being the id of the ALL cdn

[GitHub] rob05c opened a new issue #2683: Fix Traffic Monitor to not require `health.polling.url` if poll type is noop

2018-08-14 Thread GitBox
rob05c opened a new issue #2683: Fix Traffic Monitor to not require `health.polling.url` if poll type is noop URL: https://github.com/apache/trafficcontrol/issues/2683 If `health.polling.format` and `health.polling.type` are `noop`, the `health.polling.url` isn't used, and therefore

[GitHub] rawlinp opened a new issue #2685: The use_tenancy global parameter from seeds.sql should be removed

2018-08-14 Thread GitBox
rawlinp opened a new issue #2685: The use_tenancy global parameter from seeds.sql should be removed URL: https://github.com/apache/trafficcontrol/issues/2685 This parameter is now unused and removed in patches.sql, which is run _after_ seeds.sql, so this seed should be cleaned up and

[GitHub] mitchell852 closed pull request #2686: adds maxRevalDurationDays to seeds.sql

2018-08-16 Thread GitBox
mitchell852 closed pull request #2686: adds maxRevalDurationDays to seeds.sql URL: https://github.com/apache/trafficcontrol/pull/2686 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] elsloo closed pull request #2694: Fix Docs invalid JSON missing commas and escapes

2018-08-16 Thread GitBox
elsloo closed pull request #2694: Fix Docs invalid JSON missing commas and escapes URL: https://github.com/apache/trafficcontrol/pull/2694 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] mitchell852 closed pull request #2688: ensure use_tenancy set to 1 rather than deleting the parameter

2018-08-16 Thread GitBox
mitchell852 closed pull request #2688: ensure use_tenancy set to 1 rather than deleting the parameter URL: https://github.com/apache/trafficcontrol/pull/2688 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] dneuman64 opened a new issue #2692: Traffic Stats shouldn't panic when it cannot talk to Traffic OPs

2018-08-16 Thread GitBox
dneuman64 opened a new issue #2692: Traffic Stats shouldn't panic when it cannot talk to Traffic OPs URL: https://github.com/apache/trafficcontrol/issues/2692 If Traffic Stats cannot talk to Traffic Ops, like to get servers, it panics and dies. Traffic Stats should be able to handle this

[GitHub] dneuman64 opened a new issue #2693: When Traffic Stats panics, it leave systemd in a weird state

2018-08-16 Thread GitBox
dneuman64 opened a new issue #2693: When Traffic Stats panics, it leave systemd in a weird state URL: https://github.com/apache/trafficcontrol/issues/2693 If traffic stats panics and dies, it leaves systemd in a weird state where the process still says its running even though it is dead.

[GitHub] rob05c opened a new pull request #2694: Fix Docs invalid JSON missing commas and escapes

2018-08-16 Thread GitBox
rob05c opened a new pull request #2694: Fix Docs invalid JSON missing commas and escapes URL: https://github.com/apache/trafficcontrol/pull/2694 This is an automated message from the Apache Git Service. To respond to the

[GitHub] dangogh opened a new issue #2695: TO Go remove `use_tenancy` code

2018-08-16 Thread GitBox
dangogh opened a new issue #2695: TO Go remove `use_tenancy` code URL: https://github.com/apache/trafficcontrol/issues/2695 `use_tenancy` is now on by default. We can simplify quite a bit of code including sql by no longer checking this parameter. NOTE: the Perl code should not

[GitHub] rob05c opened a new pull request #2701: Fix TO Go dss endpoint limit param

2018-08-16 Thread GitBox
rob05c opened a new pull request #2701: Fix TO Go dss endpoint limit param URL: https://github.com/apache/trafficcontrol/pull/2701 What does this PR do? Fix TO Go dss endpoint limit param Which TC components are affected by this PR? - [ ] Documentation - [

[GitHub] asfgit commented on issue #2697: Added active filter on delivery services with matching origin names

2018-08-16 Thread GitBox
asfgit commented on issue #2697: Added active filter on delivery services with matching origin names URL: https://github.com/apache/trafficcontrol/pull/2697#issuecomment-413625734 Refer to this link for build results (access rights to CI server needed):

[GitHub] dangogh commented on issue #2668: Traffic Ops - Admin.pl load_schema proper exit codes and eval

2018-08-16 Thread GitBox
dangogh commented on issue #2668: Traffic Ops - Admin.pl load_schema proper exit codes and eval URL: https://github.com/apache/trafficcontrol/pull/2668#issuecomment-413590505 elsewhere, you'll see this: ``` /trafficcontrolpr2244_weasel exited with status 1 ``` `weasel`

[GitHub] asfgit commented on issue #2694: Fix Docs invalid JSON missing commas and escapes

2018-08-16 Thread GitBox
asfgit commented on issue #2694: Fix Docs invalid JSON missing commas and escapes URL: https://github.com/apache/trafficcontrol/pull/2694#issuecomment-413595062 Refer to this link for build results (access rights to CI server needed):

[GitHub] asfgit commented on issue #2600: Handle port different than 80 for Traffic Ops Checks

2018-08-16 Thread GitBox
asfgit commented on issue #2600: Handle port different than 80 for Traffic Ops Checks URL: https://github.com/apache/trafficcontrol/pull/2600#issuecomment-413602233 Refer to this link for build results (access rights to CI server needed):

[GitHub] mitchell852 closed pull request #2696: Fixes #2651 - Set Serves Status dropdown to be enabled when creating new

2018-08-16 Thread GitBox
mitchell852 closed pull request #2696: Fixes #2651 - Set Serves Status dropdown to be enabled when creating new URL: https://github.com/apache/trafficcontrol/pull/2696 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] rob05c opened a new issue #2698: Document POST servers/id/deliveryservices

2018-08-16 Thread GitBox
rob05c opened a new issue #2698: Document POST servers/id/deliveryservices URL: https://github.com/apache/trafficcontrol/issues/2698 This route needs documented. It's new, and not in Perl or the docs. I almost deleted it, because I thought it was a mistake (it's not:

[GitHub] mitchell852 closed issue #2651: Initial state for new server objects should be PRE_PROD

2018-08-16 Thread GitBox
mitchell852 closed issue #2651: Initial state for new server objects should be PRE_PROD URL: https://github.com/apache/trafficcontrol/issues/2651 This is an automated message from the Apache Git Service. To respond to the

[GitHub] dneuman64 closed pull request #2673: adds a simple PR template

2018-08-16 Thread GitBox
dneuman64 closed pull request #2673: adds a simple PR template URL: https://github.com/apache/trafficcontrol/pull/2673 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] dangogh commented on issue #2685: The use_tenancy global parameter from seeds.sql should be removed

2018-08-16 Thread GitBox
dangogh commented on issue #2685: The use_tenancy global parameter from seeds.sql should be removed URL: https://github.com/apache/trafficcontrol/issues/2685#issuecomment-413586593 This needs to wait until #2687 and #2695 are addressed. The `use_tenancy` parameter must remain in the db

[GitHub] dewrich opened a new pull request #2697: Added active filter on delivery services with matching origin names

2018-08-16 Thread GitBox
dewrich opened a new pull request #2697: Added active filter on delivery services with matching origin names URL: https://github.com/apache/trafficcontrol/pull/2697 Fixes #2644 This is an automated message from the Apache

[GitHub] rob05c opened a new issue #2699: Copy all Docs for API 1.2 into API 1.3

2018-08-16 Thread GitBox
rob05c opened a new issue #2699: Copy all Docs for API 1.2 into API 1.3 URL: https://github.com/apache/trafficcontrol/issues/2699 So far, we've been only putting new route docs into the 1.3 API docs. We need to copy all the old routes that haven't changed from 1.2. It's not reasonable to

[GitHub] dangogh edited a comment on issue #2668: Traffic Ops - Admin.pl load_schema proper exit codes and eval

2018-08-16 Thread GitBox
dangogh edited a comment on issue #2668: Traffic Ops - Admin.pl load_schema proper exit codes and eval URL: https://github.com/apache/trafficcontrol/pull/2668#issuecomment-413590505 elsewhere, you'll see this: ``` /trafficcontrolpr2244_weasel exited with status 1 ```

[GitHub] mitchell852 opened a new pull request #2700: pr template - moves license to bottom of file

2018-08-16 Thread GitBox
mitchell852 opened a new pull request #2700: pr template - moves license to bottom of file URL: https://github.com/apache/trafficcontrol/pull/2700 What does this PR do? Fixes #(issue_number) Which TC components are affected by this PR? - [ ]

[GitHub] dangogh commented on issue #2687: TP remove dependency on `use_tenancy` parameter

2018-08-16 Thread GitBox
dangogh commented on issue #2687: TP remove dependency on `use_tenancy` parameter URL: https://github.com/apache/trafficcontrol/issues/2687#issuecomment-413587046 Once this and #2695 are resolved, #2685 can be done. This is

[GitHub] dangogh commented on issue #2695: TO Go remove `use_tenancy` code

2018-08-16 Thread GitBox
dangogh commented on issue #2695: TO Go remove `use_tenancy` code URL: https://github.com/apache/trafficcontrol/issues/2695#issuecomment-413587355 Once this and #2687 are resolved, #2685 can be done. This is an automated

[GitHub] dneuman64 commented on a change in pull request #2684: python lib updated to api v1.3

2018-08-16 Thread GitBox
dneuman64 commented on a change in pull request #2684: python lib updated to api v1.3 URL: https://github.com/apache/trafficcontrol/pull/2684#discussion_r210657469 ## File path: traffic_control/clients/python/trafficops/trafficops/tosession.py ## @@ -590,18 +589,18 @@ def

[GitHub] asfgit commented on issue #2701: Fix TO Go dss endpoint limit param

2018-08-16 Thread GitBox
asfgit commented on issue #2701: Fix TO Go dss endpoint limit param URL: https://github.com/apache/trafficcontrol/pull/2701#issuecomment-413633620 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/2275/ Test

[GitHub] asfgit commented on issue #2668: Traffic Ops - Admin.pl load_schema proper exit codes and eval

2018-08-16 Thread GitBox
asfgit commented on issue #2668: Traffic Ops - Admin.pl load_schema proper exit codes and eval URL: https://github.com/apache/trafficcontrol/pull/2668#issuecomment-413663785 Refer to this link for build results (access rights to CI server needed):

[GitHub] rob05c edited a comment on issue #2701: Fix TO Go dss endpoint limit param

2018-08-16 Thread GitBox
rob05c edited a comment on issue #2701: Fix TO Go dss endpoint limit param URL: https://github.com/apache/trafficcontrol/pull/2701#issuecomment-413657909 @mitchell852 It will take me several days, between setting up the test framework, and learning or re-learning how to do something like

[GitHub] rob05c edited a comment on issue #2701: Fix TO Go dss endpoint limit param

2018-08-16 Thread GitBox
rob05c edited a comment on issue #2701: Fix TO Go dss endpoint limit param URL: https://github.com/apache/trafficcontrol/pull/2701#issuecomment-413657909 @mitchell852 It will take me several days, between setting up the test framework, and learning or re-learning how to do something like

[GitHub] rob05c edited a comment on issue #2701: Fix TO Go dss endpoint limit param

2018-08-16 Thread GitBox
rob05c edited a comment on issue #2701: Fix TO Go dss endpoint limit param URL: https://github.com/apache/trafficcontrol/pull/2701#issuecomment-413657909 @mitchell852 It will take me several days, between setting up the test framework, and learning or re-learning how to do something like

[GitHub] rob05c edited a comment on issue #2701: Fix TO Go dss endpoint limit param

2018-08-16 Thread GitBox
rob05c edited a comment on issue #2701: Fix TO Go dss endpoint limit param URL: https://github.com/apache/trafficcontrol/pull/2701#issuecomment-413657909 @mitchell852 It will take me several days, between setting up the test framework, and learning or re-learning how to do something like

[GitHub] rob05c opened a new pull request #2703: Remove TO Go unnecessary query passing

2018-08-16 Thread GitBox
rob05c opened a new pull request #2703: Remove TO Go unnecessary query passing URL: https://github.com/apache/trafficcontrol/pull/2703 What does this PR do? Removes an unnecessary obsolete function parameter. Which TC components are affected by this PR? - [ ]

[GitHub] asfgit commented on issue #2703: Remove TO Go unnecessary query passing

2018-08-16 Thread GitBox
asfgit commented on issue #2703: Remove TO Go unnecessary query passing URL: https://github.com/apache/trafficcontrol/pull/2703#issuecomment-413688067 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/2277/

[GitHub] rob05c commented on issue #2701: Fix TO Go dss endpoint limit param

2018-08-16 Thread GitBox
rob05c commented on issue #2701: Fix TO Go dss endpoint limit param URL: https://github.com/apache/trafficcontrol/pull/2701#issuecomment-413657909 @mitchell852 It will take me several days, between setting up the test framework, and learning or re-learning how to do something like that. I

[GitHub] mitchell852 commented on issue #2338: Add TO Go users

2018-08-16 Thread GitBox
mitchell852 commented on issue #2338: Add TO Go users URL: https://github.com/apache/trafficcontrol/pull/2338#issuecomment-413654855 does this leverage the CRUDDER interface? This is an automated message from the Apache Git

[GitHub] mitchell852 edited a comment on issue #2338: Add TO Go users

2018-08-16 Thread GitBox
mitchell852 edited a comment on issue #2338: Add TO Go users URL: https://github.com/apache/trafficcontrol/pull/2338#issuecomment-413654855 does this leverage the CRUDDER interface? I don't think so because i expected to se Create, Read, Update, Delete methods as opposed to POST, PUT,

[GitHub] mitchell852 commented on issue #2701: Fix TO Go dss endpoint limit param

2018-08-16 Thread GitBox
mitchell852 commented on issue #2701: Fix TO Go dss endpoint limit param URL: https://github.com/apache/trafficcontrol/pull/2701#issuecomment-413656614 you should be able to create a simple test to verify that ?limit=x has the desired effect, right?

[GitHub] mitchell852 commented on issue #2481: TP: adds the ability to crud api endpoints for roles/capabilities management

2018-08-16 Thread GitBox
mitchell852 commented on issue #2481: TP: adds the ability to crud api endpoints for roles/capabilities management URL: https://github.com/apache/trafficcontrol/pull/2481#issuecomment-413680640 retest this please This is an

[GitHub] JBevillC commented on issue #2668: Traffic Ops - Admin.pl load_schema proper exit codes and eval

2018-08-16 Thread GitBox
JBevillC commented on issue #2668: Traffic Ops - Admin.pl load_schema proper exit codes and eval URL: https://github.com/apache/trafficcontrol/pull/2668#issuecomment-413661845 Thanks Dan ! Rebased and pushed. This is an

[GitHub] chadgilloth opened a new pull request #2702: Improve usability of comments in DS requests

2018-08-16 Thread GitBox
chadgilloth opened a new pull request #2702: Improve usability of comments in DS requests URL: https://github.com/apache/trafficcontrol/pull/2702 Improves the usability of viewing comments in DS Requests by showing the comments in the same view CDN-2347 (No git issue)

[GitHub] asfgit commented on issue #2702: Improve usability of comments in DS requests

2018-08-16 Thread GitBox
asfgit commented on issue #2702: Improve usability of comments in DS requests URL: https://github.com/apache/trafficcontrol/pull/2702#issuecomment-413673807 Can one of the admins verify this patch? This is an automated

[GitHub] asfgit commented on issue #2705: Fix TO Go user/ds/available to skip assigned

2018-08-16 Thread GitBox
asfgit commented on issue #2705: Fix TO Go user/ds/available to skip assigned URL: https://github.com/apache/trafficcontrol/pull/2705#issuecomment-413702906 Refer to this link for build results (access rights to CI server needed):

[GitHub] dangogh opened a new pull request #2708: add operations role to seeds.sql so there when used for extension user

2018-08-16 Thread GitBox
dangogh opened a new pull request #2708: add operations role to seeds.sql so there when used for extension user URL: https://github.com/apache/trafficcontrol/pull/2708 What does this PR do? adds operations role in seeds.sql Fixes #2706 Which TC components are

[GitHub] asfgit commented on issue #2704: TO DB - Mapping roles to capabilities for read-only, operations, portal, federations, steering

2018-08-16 Thread GitBox
asfgit commented on issue #2704: TO DB - Mapping roles to capabilities for read-only, operations, portal, federations, steering URL: https://github.com/apache/trafficcontrol/pull/2704#issuecomment-413715002 Refer to this link for build results (access rights to CI server needed):

[GitHub] mitchell852 closed pull request #2708: add operations role to seeds.sql so there when used for extension user

2018-08-16 Thread GitBox
mitchell852 closed pull request #2708: add operations role to seeds.sql so there when used for extension user URL: https://github.com/apache/trafficcontrol/pull/2708 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] asfgit commented on issue #2703: Remove TO Go unnecessary query passing

2018-08-16 Thread GitBox
asfgit commented on issue #2703: Remove TO Go unnecessary query passing URL: https://github.com/apache/trafficcontrol/pull/2703#issuecomment-413695556 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/2278/

[GitHub] asfgit commented on issue #2704: TO DB - Mapping roles to capabilities for read-only, operations, portal, federations, steering

2018-08-16 Thread GitBox
asfgit commented on issue #2704: TO DB - Mapping roles to capabilities for read-only, operations, portal, federations, steering URL: https://github.com/apache/trafficcontrol/pull/2704#issuecomment-413695612 Can one of the admins verify this patch?

[GitHub] asfgit commented on issue #2481: TP: adds the ability to crud api endpoints for roles/capabilities management

2018-08-16 Thread GitBox
asfgit commented on issue #2481: TP: adds the ability to crud api endpoints for roles/capabilities management URL: https://github.com/apache/trafficcontrol/pull/2481#issuecomment-413699123 Refer to this link for build results (access rights to CI server needed):

[GitHub] dangogh opened a new pull request #2707: cdn-in-a-box: redo initial data loading from dir structure

2018-08-16 Thread GitBox
dangogh opened a new pull request #2707: cdn-in-a-box: redo initial data loading from dir structure URL: https://github.com/apache/trafficcontrol/pull/2707 What does this PR do? extends cdn-in-a-box with data loaded from json files on startup Which TC components are

[GitHub] asfgit commented on issue #2707: cdn-in-a-box: redo initial data loading from dir structure

2018-08-16 Thread GitBox
asfgit commented on issue #2707: cdn-in-a-box: redo initial data loading from dir structure URL: https://github.com/apache/trafficcontrol/pull/2707#issuecomment-413709203 Refer to this link for build results (access rights to CI server needed):

[GitHub] dangogh opened a new issue #2706: `operations` role not created in seeds.sql

2018-08-16 Thread GitBox
dangogh opened a new issue #2706: `operations` role not created in seeds.sql URL: https://github.com/apache/trafficcontrol/issues/2706 The `extension` user is created with the `operations` role in seeds.sql, but that role isn't created first. A brand new installation will fail to get

[GitHub] dangogh commented on issue #2704: TO DB - Mapping roles to capabilities for read-only, operations, portal, federations, steering

2018-08-16 Thread GitBox
dangogh commented on issue #2704: TO DB - Mapping roles to capabilities for read-only, operations, portal, federations, steering URL: https://github.com/apache/trafficcontrol/pull/2704#issuecomment-413710937 add to whitelist

[GitHub] mitchell852 opened a new pull request #2709: TP: server.js - removes commented out code

2018-08-16 Thread GitBox
mitchell852 opened a new pull request #2709: TP: server.js - removes commented out code URL: https://github.com/apache/trafficcontrol/pull/2709 What does this PR do? Removes some commented out code in server.js that was a failed attempt at dbdump. Which TC

[GitHub] moltzaum opened a new pull request #2704: TO DB - Mapping roles to capabilities for read-only, operations, portal, federations, steering

2018-08-16 Thread GitBox
moltzaum opened a new pull request #2704: TO DB - Mapping roles to capabilities for read-only, operations, portal, federations, steering URL: https://github.com/apache/trafficcontrol/pull/2704 What does this PR do? This PR is a database migration that assigns capabilities for

[GitHub] rob05c opened a new pull request #2705: Fix TO Go user/ds/available to skip assigned

2018-08-16 Thread GitBox
rob05c opened a new pull request #2705: Fix TO Go user/ds/available to skip assigned URL: https://github.com/apache/trafficcontrol/pull/2705 What does this PR do? Fix TO Go user/ds/available to skip assigned Which TC components are affected by this PR? - [ ]

[GitHub] asfgit commented on issue #2708: add operations role to seeds.sql so there when used for extension user

2018-08-16 Thread GitBox
asfgit commented on issue #2708: add operations role to seeds.sql so there when used for extension user URL: https://github.com/apache/trafficcontrol/pull/2708#issuecomment-413714455 Refer to this link for build results (access rights to CI server needed):

[GitHub] mitchell852 closed issue #2706: `operations` role not created in seeds.sql

2018-08-16 Thread GitBox
mitchell852 closed issue #2706: `operations` role not created in seeds.sql URL: https://github.com/apache/trafficcontrol/issues/2706 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] asfgit commented on issue #2709: TP: server.js - removes commented out code

2018-08-16 Thread GitBox
asfgit commented on issue #2709: TP: server.js - removes commented out code URL: https://github.com/apache/trafficcontrol/pull/2709#issuecomment-413753828 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/2284/

[GitHub] rob05c edited a comment on issue #2513: Add TO Go plugin system

2018-08-06 Thread GitBox
rob05c edited a comment on issue #2513: Add TO Go plugin system URL: https://github.com/apache/trafficcontrol/pull/2513#issuecomment-410737736 >dist/traffic_ops-2.3.0-8898.4abdfa71.el7.x86_64.rpm has no obvious indication of that plugin list, I'm not sure how you mean. Doing `rpm

[GitHub] mitchell852 opened a new pull request #2632: adds ds bps and tps charts

2018-08-06 Thread GitBox
mitchell852 opened a new pull request #2632: adds ds bps and tps charts URL: https://github.com/apache/trafficcontrol/pull/2632 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] mitchell852 commented on issue #2633: The auth check method needs to return an error

2018-08-06 Thread GitBox
mitchell852 commented on issue #2633: The auth check method needs to return an error URL: https://github.com/apache/trafficcontrol/issues/2633#issuecomment-410748564 yes, a 401 implies either the user never authenticated or the user's cookie is invalid (expired) a 403 implies that

[GitHub] dewrich closed pull request #2557: Cachegroups localization policy

2018-08-06 Thread GitBox
dewrich closed pull request #2557: Cachegroups localization policy URL: https://github.com/apache/trafficcontrol/pull/2557 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] rob05c commented on a change in pull request #2606: Updates 'grovetccfg' to to write a grove.cfg from the grove servers profile

2018-08-06 Thread GitBox
rob05c commented on a change in pull request #2606: Updates 'grovetccfg' to to write a grove.cfg from the grove servers profile URL: https://github.com/apache/trafficcontrol/pull/2606#discussion_r207913172 ## File path: grove/grovetccfg/grovetccfg.go ## @@ -259,20

[GitHub] rob05c commented on a change in pull request #2606: Updates 'grovetccfg' to to write a grove.cfg from the grove servers profile

2018-08-06 Thread GitBox
rob05c commented on a change in pull request #2606: Updates 'grovetccfg' to to write a grove.cfg from the grove servers profile URL: https://github.com/apache/trafficcontrol/pull/2606#discussion_r207912846 ## File path: grove/grovetccfg/grovetccfg.go ## @@ -259,20

[GitHub] rob05c commented on a change in pull request #2606: Updates 'grovetccfg' to to write a grove.cfg from the grove servers profile

2018-08-06 Thread GitBox
rob05c commented on a change in pull request #2606: Updates 'grovetccfg' to to write a grove.cfg from the grove servers profile URL: https://github.com/apache/trafficcontrol/pull/2606#discussion_r207918628 ## File path: grove/grovetccfg/grovetccfg.go ## @@ -259,20

[GitHub] rob05c commented on a change in pull request #2606: Updates 'grovetccfg' to to write a grove.cfg from the grove servers profile

2018-08-06 Thread GitBox
rob05c commented on a change in pull request #2606: Updates 'grovetccfg' to to write a grove.cfg from the grove servers profile URL: https://github.com/apache/trafficcontrol/pull/2606#discussion_r207918628 ## File path: grove/grovetccfg/grovetccfg.go ## @@ -259,20

<    8   9   10   11   12   13   14   15   16   17   >