[GitHub] mitchell852 closed issue #885: [TC-547] Fix regression issues caused by TC-187

2018-05-24 Thread GitBox
mitchell852 closed issue #885: [TC-547] Fix regression issues caused by TC-187 URL: https://github.com/apache/incubator-trafficcontrol/issues/885 This is an automated message from the Apache Git Service. To respond to the

[GitHub] dewrich closed pull request #2329: TO postinstall - generateCert no longer overwrites cdn.conf

2018-05-24 Thread GitBox
dewrich closed pull request #2329: TO postinstall - generateCert no longer overwrites cdn.conf URL: https://github.com/apache/incubator-trafficcontrol/pull/2329 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] mitchell852 commented on issue #911: [TC-295] Invalid DS regex causes nasty exception and unexpected results Github Issue #514

2018-05-24 Thread GitBox
mitchell852 commented on issue #911: [TC-295] Invalid DS regex causes nasty exception and unexpected results Github Issue #514 URL: https://github.com/apache/incubator-trafficcontrol/issues/911#issuecomment-391864800 TO UI is going to be deprecated soon so I wouldn't worry about fixing

[GitHub] mitchell852 closed pull request #2330: TO GO unit tests: request change from submitted to complete is valid

2018-05-24 Thread GitBox
mitchell852 closed pull request #2330: TO GO unit tests: request change from submitted to complete is valid URL: https://github.com/apache/incubator-trafficcontrol/pull/2330 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below

[GitHub] mitchell852 commented on issue #897: [TC-510] cannot apply ipv6 on delivery services

2018-05-24 Thread GitBox
mitchell852 commented on issue #897: [TC-510] cannot apply ipv6 on delivery services URL: https://github.com/apache/incubator-trafficcontrol/issues/897#issuecomment-391853618 TO UI will be deprecated shortly in favor of TP so closing this

[GitHub] mitchell852 closed issue #897: [TC-510] cannot apply ipv6 on delivery services

2018-05-24 Thread GitBox
mitchell852 closed issue #897: [TC-510] cannot apply ipv6 on delivery services URL: https://github.com/apache/incubator-trafficcontrol/issues/897 This is an automated message from the Apache Git Service. To respond to the

[GitHub] mitchell852 closed issue #926: [TC-445] Traffic Ops API Rewrite: Implement /api/1.2/servers

2018-05-24 Thread GitBox
mitchell852 closed issue #926: [TC-445] Traffic Ops API Rewrite: Implement /api/1.2/servers URL: https://github.com/apache/incubator-trafficcontrol/issues/926 This is an automated message from the Apache Git Service. To

[GitHub] mitchell852 commented on issue #926: [TC-445] Traffic Ops API Rewrite: Implement /api/1.2/servers

2018-05-24 Thread GitBox
mitchell852 commented on issue #926: [TC-445] Traffic Ops API Rewrite: Implement /api/1.2/servers URL: https://github.com/apache/incubator-trafficcontrol/issues/926#issuecomment-391873358 i think this was already done by @DylanVolz so i'm closing

[GitHub] asfgit commented on issue #2124: Add TO Go deliveryservices routes

2018-05-24 Thread GitBox
asfgit commented on issue #2124: Add TO Go deliveryservices routes URL: https://github.com/apache/incubator-trafficcontrol/pull/2124#issuecomment-391874134 Refer to this link for build results (access rights to CI server needed):

[GitHub] mitchell852 closed issue #931: [TC-184] Tenant Hierarchy Creation

2018-05-24 Thread GitBox
mitchell852 closed issue #931: [TC-184] Tenant Hierarchy Creation URL: https://github.com/apache/incubator-trafficcontrol/issues/931 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] mitchell852 commented on issue #937: [TC-465] Delivery-service tenancy based access control - JOBs

2018-05-24 Thread GitBox
mitchell852 commented on issue #937: [TC-465] Delivery-service tenancy based access control - JOBs URL: https://github.com/apache/incubator-trafficcontrol/issues/937#issuecomment-391875851 this should be done. you can't create a "job" for a ds that is outside your tenancy i don't think.

[GitHub] dangogh opened a new pull request #2330: TO GO unit tests: request change from submitted to complete is valid

2018-05-24 Thread GitBox
dangogh opened a new pull request #2330: TO GO unit tests: request change from submitted to complete is valid URL: https://github.com/apache/incubator-trafficcontrol/pull/2330 change needed after #2271 This is an automated

[GitHub] dangogh closed pull request #2327: updated the Traffic Router docker compose file

2018-05-24 Thread GitBox
dangogh closed pull request #2327: updated the Traffic Router docker compose file URL: https://github.com/apache/incubator-trafficcontrol/pull/2327 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] mitchell852 commented on issue #923: [TC-230] Cache Health Monitor - Add IPv6 Checks

2018-05-24 Thread GitBox
mitchell852 commented on issue #923: [TC-230] Cache Health Monitor - Add IPv6 Checks URL: https://github.com/apache/incubator-trafficcontrol/issues/923#issuecomment-391866810 I believe @DylanVolz is looking at this. correct me if i'm wrong @DylanVolz

[GitHub] mitchell852 commented on issue #937: [TC-465] Delivery-service tenancy based access control - JOBs

2018-05-24 Thread GitBox
mitchell852 commented on issue #937: [TC-465] Delivery-service tenancy based access control - JOBs URL: https://github.com/apache/incubator-trafficcontrol/issues/937#issuecomment-391875851 this should be done. you can't create a "job" for a ds that is outside your tenancy i don't think.

[GitHub] asfgit commented on issue #2329: TO postinstall - generateCert no longer overwrites cdn.conf

2018-05-24 Thread GitBox
asfgit commented on issue #2329: TO postinstall - generateCert no longer overwrites cdn.conf URL: https://github.com/apache/incubator-trafficcontrol/pull/2329#issuecomment-391852973 Refer to this link for build results (access rights to CI server needed):

[GitHub] rawlinp commented on issue #899: [TC-385] IPv6 Origin Configuration Not Allowed

2018-05-24 Thread GitBox
rawlinp commented on issue #899: [TC-385] IPv6 Origin Configuration Not Allowed URL: https://github.com/apache/incubator-trafficcontrol/issues/899#issuecomment-391865489 As far as I know, ipv6 addresses should be rejected, because the validation of that field has always been that it is a

[GitHub] mitchell852 closed issue #933: [TC-479] Portal: A way to contact owners whenever issues arise

2018-05-24 Thread GitBox
mitchell852 closed issue #933: [TC-479] Portal: A way to contact owners whenever issues arise URL: https://github.com/apache/incubator-trafficcontrol/issues/933 This is an automated message from the Apache Git Service. To

[GitHub] asfgit commented on issue #2330: TO GO unit tests: request change from submitted to complete is valid

2018-05-24 Thread GitBox
asfgit commented on issue #2330: TO GO unit tests: request change from submitted to complete is valid URL: https://github.com/apache/incubator-trafficcontrol/pull/2330#issuecomment-391878805 Refer to this link for build results (access rights to CI server needed):

[GitHub] asfgit commented on issue #2332: Adding grove to standard pkg build.

2018-05-24 Thread GitBox
asfgit commented on issue #2332: Adding grove to standard pkg build. URL: https://github.com/apache/incubator-trafficcontrol/pull/2332#issuecomment-391936617 Refer to this link for build results (access rights to CI server needed):

[GitHub] rob05c commented on issue #2332: Adding grove to standard pkg build.

2018-05-24 Thread GitBox
rob05c commented on issue #2332: Adding grove to standard pkg build. URL: https://github.com/apache/incubator-trafficcontrol/pull/2332#issuecomment-391933719 Retest this please This is an automated message from the Apache

[GitHub] ajschmidt opened a new pull request #2331: Traffic Router upgrade Tomcat to 8.5

2018-05-24 Thread GitBox
ajschmidt opened a new pull request #2331: Traffic Router upgrade Tomcat to 8.5 URL: https://github.com/apache/incubator-trafficcontrol/pull/2331 This PR should not be accepted in the 'master' branch at this time. This is a major upgrade to Traffic Router to be released with Traffic

[GitHub] ajschmidt commented on issue #925: [TC-69] Upgrade Tomcat Version for Traffic Router

2018-05-24 Thread GitBox
ajschmidt commented on issue #925: [TC-69] Upgrade Tomcat Version for Traffic Router URL: https://github.com/apache/incubator-trafficcontrol/issues/925#issuecomment-391889139 https://github.com/apache/incubator-trafficcontrol/pull/2331

[GitHub] asfgit commented on issue #2124: Add TO Go deliveryservices routes

2018-05-24 Thread GitBox
asfgit commented on issue #2124: Add TO Go deliveryservices routes URL: https://github.com/apache/incubator-trafficcontrol/pull/2124#issuecomment-391891689 Refer to this link for build results (access rights to CI server needed):

[GitHub] asfgit commented on issue #2331: Traffic Router upgrade Tomcat to 8.5

2018-05-24 Thread GitBox
asfgit commented on issue #2331: Traffic Router upgrade Tomcat to 8.5 URL: https://github.com/apache/incubator-trafficcontrol/pull/2331#issuecomment-391883035 Can one of the admins verify this patch? This is an automated

[GitHub] asfgit commented on issue #2331: Traffic Router upgrade Tomcat to 8.5

2018-05-24 Thread GitBox
asfgit commented on issue #2331: Traffic Router upgrade Tomcat to 8.5 URL: https://github.com/apache/incubator-trafficcontrol/pull/2331#issuecomment-391882825 Can one of the admins verify this patch? This is an automated

[GitHub] rob05c commented on issue #2124: Add TO Go deliveryservices routes

2018-05-24 Thread GitBox
rob05c commented on issue #2124: Add TO Go deliveryservices routes URL: https://github.com/apache/incubator-trafficcontrol/pull/2124#issuecomment-391887513 >don't forget to add the new vendor'd dirs to .rat-excludes Done

[GitHub] rob05c commented on issue #2124: Add TO Go deliveryservices routes

2018-05-24 Thread GitBox
rob05c commented on issue #2124: Add TO Go deliveryservices routes URL: https://github.com/apache/incubator-trafficcontrol/pull/2124#issuecomment-391887513 >don't forget to add the new vendor'd dirs to .rat-excludes Done

[GitHub] DylanVolz commented on issue #923: [TC-230] Cache Health Monitor - Add IPv6 Checks

2018-05-24 Thread GitBox
DylanVolz commented on issue #923: [TC-230] Cache Health Monitor - Add IPv6 Checks URL: https://github.com/apache/incubator-trafficcontrol/issues/923#issuecomment-391889314 yes I have worked to address this already, we are verifying the changes in this PR still: #1627

[GitHub] alficles opened a new pull request #2332: Adding grove to standard pkg build.

2018-05-24 Thread GitBox
alficles opened a new pull request #2332: Adding grove to standard pkg build. URL: https://github.com/apache/incubator-trafficcontrol/pull/2332 @rob05c, please review. This shouldn't break the non-docker build, but it adds `./pkg` functionality.

[GitHub] asfgit commented on issue #2296: Add Grove vendors to .rat-excludes

2018-05-18 Thread GitBox
asfgit commented on issue #2296: Add Grove vendors to .rat-excludes URL: https://github.com/apache/incubator-trafficcontrol/pull/2296#issuecomment-390257563 Refer to this link for build results (access rights to CI server needed):

[GitHub] DylanVolz opened a new pull request #2298: fix config_test.go to keep it up to date with changes to LoadConfig

2018-05-18 Thread GitBox
DylanVolz opened a new pull request #2298: fix config_test.go to keep it up to date with changes to LoadConfig URL: https://github.com/apache/incubator-trafficcontrol/pull/2298 This is an automated message from the Apache

[GitHub] asfgit commented on issue #2298: fix config_test.go to keep it up to date with changes to LoadConfig

2018-05-18 Thread GitBox
asfgit commented on issue #2298: fix config_test.go to keep it up to date with changes to LoadConfig URL: https://github.com/apache/incubator-trafficcontrol/pull/2298#issuecomment-390264004 Refer to this link for build results (access rights to CI server needed):

[GitHub] rob05c commented on issue #2232: Rewrite Traffic Ops CRConfig Table Endpoints in Go

2018-05-18 Thread GitBox
rob05c commented on issue #2232: Rewrite Traffic Ops CRConfig Table Endpoints in Go URL: https://github.com/apache/incubator-trafficcontrol/issues/2232#issuecomment-387444293 Ok, we have PRs for all major table routes, but many of them are only "CRUD", and missing additional endpoints.

[GitHub] rob05c opened a new pull request #2296: Add Grove vendors to .rat-excludes

2018-05-18 Thread GitBox
rob05c opened a new pull request #2296: Add Grove vendors to .rat-excludes URL: https://github.com/apache/incubator-trafficcontrol/pull/2296 Tested with rat, succeeds with `0 Unknown Licenses` This is an automated message

[GitHub] asfgit commented on issue #2297: Add TO Go cachegroups/trimmed

2018-05-18 Thread GitBox
asfgit commented on issue #2297: Add TO Go cachegroups/trimmed URL: https://github.com/apache/incubator-trafficcontrol/pull/2297#issuecomment-390261269 Refer to this link for build results (access rights to CI server needed):

[GitHub] dangogh closed pull request #2296: Add Grove vendors to .rat-excludes

2018-05-18 Thread GitBox
dangogh closed pull request #2296: Add Grove vendors to .rat-excludes URL: https://github.com/apache/incubator-trafficcontrol/pull/2296 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] dewrich closed pull request #2298: fix config_test.go to keep it up to date with changes to LoadConfig

2018-05-18 Thread GitBox
dewrich closed pull request #2298: fix config_test.go to keep it up to date with changes to LoadConfig URL: https://github.com/apache/incubator-trafficcontrol/pull/2298 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] rob05c opened a new pull request #2297: Add TO Go cachegroups/trimmed

2018-05-18 Thread GitBox
rob05c opened a new pull request #2297: Add TO Go cachegroups/trimmed URL: https://github.com/apache/incubator-trafficcontrol/pull/2297 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] rob05c commented on issue #2274: Profiles endpoint unordered

2018-05-18 Thread GitBox
rob05c commented on issue #2274: Profiles endpoint unordered URL: https://github.com/apache/incubator-trafficcontrol/issues/2274#issuecomment-390222865 I agree we should revisit `orderby` in API 2.0. However, currently, 1.x/profiles doesn't support orderby, per

[GitHub] smalenfant commented on issue #1210: CDN APIs: Routing

2018-05-18 Thread GitBox
smalenfant commented on issue #1210: CDN APIs: Routing URL: https://github.com/apache/incubator-trafficcontrol/issues/1210#issuecomment-390212306 Hopefully this fixes #902 at the same time. Just adding for reference. This is

[GitHub] mitchell852 commented on issue #2274: Profiles endpoint unordered

2018-05-18 Thread GitBox
mitchell852 commented on issue #2274: Profiles endpoint unordered URL: https://github.com/apache/incubator-trafficcontrol/issues/2274#issuecomment-390216359 @rob05c - its weird imo to have some apis support orderby and others not support it in API 1.x. How about we revisit this

[GitHub] dewrich closed issue #2274: Profiles endpoint unordered

2018-05-18 Thread GitBox
dewrich closed issue #2274: Profiles endpoint unordered URL: https://github.com/apache/incubator-trafficcontrol/issues/2274 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] asfgit commented on issue #2262: Part 1 of Range Request handling

2018-05-18 Thread GitBox
asfgit commented on issue #2262: Part 1 of Range Request handling URL: https://github.com/apache/incubator-trafficcontrol/pull/2262#issuecomment-390329494 Refer to this link for build results (access rights to CI server needed):

[GitHub] knutsel commented on issue #2262: Part 1 of Range Request handling

2018-05-18 Thread GitBox
knutsel commented on issue #2262: Part 1 of Range Request handling URL: https://github.com/apache/incubator-trafficcontrol/pull/2262#issuecomment-390333856 All review comments are addressed in the last commit. Thanks @rob05c !

[GitHub] mitchell852 closed pull request #2290: Fix TO missing use JSON

2018-05-17 Thread GitBox
mitchell852 closed pull request #2290: Fix TO missing use JSON URL: https://github.com/apache/incubator-trafficcontrol/pull/2290 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] asfgit commented on issue #2291: update portal ds fields

2018-05-17 Thread GitBox
asfgit commented on issue #2291: update portal ds fields URL: https://github.com/apache/incubator-trafficcontrol/pull/2291#issuecomment-390019702 Refer to this link for build results (access rights to CI server needed):

[GitHub] rob05c opened a new pull request #2290: Fix TO missing use JSON

2018-05-17 Thread GitBox
rob05c opened a new pull request #2290: Fix TO missing use JSON URL: https://github.com/apache/incubator-trafficcontrol/pull/2290 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] mitchell852 commented on issue #2274: Profiles endpoint unordered

2018-05-17 Thread GitBox
mitchell852 commented on issue #2274: Profiles endpoint unordered URL: https://github.com/apache/incubator-trafficcontrol/issues/2274#issuecomment-390020758 probably but seems like a pretty common feature of an api, no? orderby, limit, page, etc... plus orderby has already been

[GitHub] mitchell852 opened a new pull request #2292: adds orderby=name query param when fetching profiles

2018-05-17 Thread GitBox
mitchell852 opened a new pull request #2292: adds orderby=name query param when fetching profiles URL: https://github.com/apache/incubator-trafficcontrol/pull/2292 fixes #2274 This is an automated message from the Apache

[GitHub] rob05c commented on issue #2274: Profiles endpoint unordered

2018-05-17 Thread GitBox
rob05c commented on issue #2274: Profiles endpoint unordered URL: https://github.com/apache/incubator-trafficcontrol/issues/2274#issuecomment-390024452 Just because something is common doesn't make it good. And yes, we have it on existing endpoints. But IMO we should be reducing

[GitHub] rob05c commented on issue #2256: Add TO Go profile parameters routes

2018-05-18 Thread GitBox
rob05c commented on issue #2256: Add TO Go profile parameters routes URL: https://github.com/apache/incubator-trafficcontrol/pull/2256#issuecomment-390302932 Fixed This is an automated message from the Apache Git Service. To

[GitHub] asfgit commented on issue #2256: Add TO Go profile parameters routes

2018-05-18 Thread GitBox
asfgit commented on issue #2256: Add TO Go profile parameters routes URL: https://github.com/apache/incubator-trafficcontrol/pull/2256#issuecomment-390306299 Refer to this link for build results (access rights to CI server needed):

[GitHub] dangogh closed pull request #2271: allow the option to immediately fulfill DSR (d…

2018-05-18 Thread GitBox
dangogh closed pull request #2271: allow the option to immediately fulfill DSR (d… URL: https://github.com/apache/incubator-trafficcontrol/pull/2271 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] rob05c closed issue #1247: Login APIs

2018-05-17 Thread GitBox
rob05c closed issue #1247: Login APIs URL: https://github.com/apache/incubator-trafficcontrol/issues/1247 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the

[GitHub] asfgit commented on issue #2249: Add CRConfig DS Modified fields

2018-05-17 Thread GitBox
asfgit commented on issue #2249: Add CRConfig DS Modified fields URL: https://github.com/apache/incubator-trafficcontrol/pull/2249#issuecomment-390039554 Refer to this link for build results (access rights to CI server needed):

[GitHub] asfgit commented on issue #2292: adds orderby=name query param when fetching profiles

2018-05-17 Thread GitBox
asfgit commented on issue #2292: adds orderby=name query param when fetching profiles URL: https://github.com/apache/incubator-trafficcontrol/pull/2292#issuecomment-390025899 Refer to this link for build results (access rights to CI server needed):

[GitHub] dangogh closed issue #2174: TO/TP should allow for a configuration such that admins do not have to submit DSRs

2018-05-18 Thread GitBox
dangogh closed issue #2174: TO/TP should allow for a configuration such that admins do not have to submit DSRs URL: https://github.com/apache/incubator-trafficcontrol/issues/2174 This is an automated message from the Apache

[GitHub] mitchell852 closed pull request #2229: Add Traffic Ops Golang deliveryservicesregexes

2018-05-18 Thread GitBox
mitchell852 closed pull request #2229: Add Traffic Ops Golang deliveryservicesregexes URL: https://github.com/apache/incubator-trafficcontrol/pull/2229 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] mitchell852 commented on issue #2256: Add TO Go profile parameters routes

2018-05-18 Thread GitBox
mitchell852 commented on issue #2256: Add TO Go profile parameters routes URL: https://github.com/apache/incubator-trafficcontrol/pull/2256#issuecomment-390287473 @rob05c - conflicts...sorry :( This is an automated message

[GitHub] elsloo closed pull request #2288: Fix TO old Perl GUI CRConfig diff

2018-05-17 Thread GitBox
elsloo closed pull request #2288: Fix TO old Perl GUI CRConfig diff URL: https://github.com/apache/incubator-trafficcontrol/pull/2288 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] DylanVolz commented on issue #2232: Rewrite Traffic Ops CRConfig Table Endpoints in Go

2018-05-17 Thread GitBox
DylanVolz commented on issue #2232: Rewrite Traffic Ops CRConfig Table Endpoints in Go URL: https://github.com/apache/incubator-trafficcontrol/issues/2232#issuecomment-389995964 Here is the expected form of the above routes comma delimited as Method,Route GET,asns/?$

[GitHub] rob05c commented on issue #2232: Rewrite Traffic Ops CRConfig Table Endpoints in Go

2018-05-18 Thread GitBox
rob05c commented on issue #2232: Rewrite Traffic Ops CRConfig Table Endpoints in Go URL: https://github.com/apache/incubator-trafficcontrol/issues/2232#issuecomment-387444293 Ok, we have PRs for all major table routes, but many of them are only "CRUD", and missing additional endpoints.

[GitHub] rob05c commented on issue #2232: Rewrite Traffic Ops CRConfig Table Endpoints in Go

2018-05-18 Thread GitBox
rob05c commented on issue #2232: Rewrite Traffic Ops CRConfig Table Endpoints in Go URL: https://github.com/apache/incubator-trafficcontrol/issues/2232#issuecomment-387444293 Ok, we have PRs for all major table routes, but many of them are only "CRUD", and missing additional endpoints.

[GitHub] mitchell852 closed pull request #2281: Increase hostname and domain name length limit in Traffic Portal

2018-05-16 Thread GitBox
mitchell852 closed pull request #2281: Increase hostname and domain name length limit in Traffic Portal URL: https://github.com/apache/incubator-trafficcontrol/pull/2281 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for

[GitHub] mitchell852 closed issue #2279: Increase server hostname max length

2018-05-16 Thread GitBox
mitchell852 closed issue #2279: Increase server hostname max length URL: https://github.com/apache/incubator-trafficcontrol/issues/2279 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] mitchell852 closed pull request #2214: removed the job_result table because it is not being used

2018-05-16 Thread GitBox
mitchell852 closed pull request #2214: removed the job_result table because it is not being used URL: https://github.com/apache/incubator-trafficcontrol/pull/2214 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[GitHub] mitchell852 closed issue #2033: TO API - provide the ability to manage roles

2018-05-16 Thread GitBox
mitchell852 closed issue #2033: TO API - provide the ability to manage roles URL: https://github.com/apache/incubator-trafficcontrol/issues/2033 This is an automated message from the Apache Git Service. To respond to the

[GitHub] asfgit commented on issue #2282: Deliveryservice_Server API conversion to Go - formerly #2269

2018-05-16 Thread GitBox
asfgit commented on issue #2282: Deliveryservice_Server API conversion to Go - formerly #2269 URL: https://github.com/apache/incubator-trafficcontrol/pull/2282#issuecomment-389735036 Can one of the admins verify this patch?

[GitHub] ajschmidt opened a new pull request #2282: Deliveryservice_Server API conversion to Go - formerly #2269

2018-05-16 Thread GitBox
ajschmidt opened a new pull request #2282: Deliveryservice_Server API conversion to Go - formerly #2269 URL: https://github.com/apache/incubator-trafficcontrol/pull/2282 This PR converts these API methods to Go: GET api/1.1/deliveryserviceserver POST api/1.1/deliveryserviceserver

[GitHub] ajschmidt commented on a change in pull request #2269: Adds Docker Compose configuration for creating a Traffic_Ops Dev environment

2018-05-16 Thread GitBox
ajschmidt commented on a change in pull request #2269: Adds Docker Compose configuration for creating a Traffic_Ops Dev environment URL: https://github.com/apache/incubator-trafficcontrol/pull/2269#discussion_r188831251 ## File path:

[GitHub] ajschmidt commented on a change in pull request #2269: Adds Docker Compose configuration for creating a Traffic_Ops Dev environment

2018-05-16 Thread GitBox
ajschmidt commented on a change in pull request #2269: Adds Docker Compose configuration for creating a Traffic_Ops Dev environment URL: https://github.com/apache/incubator-trafficcontrol/pull/2269#discussion_r188831726 ## File path:

[GitHub] asfgit commented on issue #2124: Add TO Go deliveryservices routes

2018-05-23 Thread GitBox
asfgit commented on issue #2124: Add TO Go deliveryservices routes URL: https://github.com/apache/incubator-trafficcontrol/pull/2124#issuecomment-391388974 Refer to this link for build results (access rights to CI server needed):

[GitHub] rob05c closed pull request #2246: Add HitCount and FreshFor

2018-05-23 Thread GitBox
rob05c closed pull request #2246: Add HitCount and FreshFor URL: https://github.com/apache/incubator-trafficcontrol/pull/2246 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] rob05c closed pull request #2262: Part 1 of Range Request handling

2018-05-23 Thread GitBox
rob05c closed pull request #2262: Part 1 of Range Request handling URL: https://github.com/apache/incubator-trafficcontrol/pull/2262 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] rob05c opened a new pull request #2307: Add TO Go cdns/routing

2018-05-20 Thread GitBox
rob05c opened a new pull request #2307: Add TO Go cdns/routing URL: https://github.com/apache/incubator-trafficcontrol/pull/2307 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] asfgit commented on issue #2307: Add TO Go cdns/routing

2018-05-20 Thread GitBox
asfgit commented on issue #2307: Add TO Go cdns/routing URL: https://github.com/apache/incubator-trafficcontrol/pull/2307#issuecomment-390550420 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR/1626/

[GitHub] rob05c commented on a change in pull request #2282: Deliveryservice_Server API conversion to Go - formerly #2269

2018-05-23 Thread GitBox
rob05c commented on a change in pull request #2282: Deliveryservice_Server API conversion to Go - formerly #2269 URL: https://github.com/apache/incubator-trafficcontrol/pull/2282#discussion_r190276662 ## File path: traffic_ops/traffic_ops_golang/deliveryservice/servers/servers.go

[GitHub] asfgit commented on issue #2124: Add TO Go deliveryservices routes

2018-05-23 Thread GitBox
asfgit commented on issue #2124: Add TO Go deliveryservices routes URL: https://github.com/apache/incubator-trafficcontrol/pull/2124#issuecomment-391401251 Refer to this link for build results (access rights to CI server needed):

[GitHub] rob05c opened a new pull request #2315: Fix Grove grovetccfg compile errs, better err msgs

2018-05-22 Thread GitBox
rob05c opened a new pull request #2315: Fix Grove grovetccfg compile errs, better err msgs URL: https://github.com/apache/incubator-trafficcontrol/pull/2315 This is an automated message from the Apache Git Service. To

[GitHub] elsloo closed pull request #2315: Fix Grove grovetccfg compile errs, better err msgs

2018-05-22 Thread GitBox
elsloo closed pull request #2315: Fix Grove grovetccfg compile errs, better err msgs URL: https://github.com/apache/incubator-trafficcontrol/pull/2315 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] knutsel commented on issue #2202: Add Grove Range Request handling

2018-05-23 Thread GitBox
knutsel commented on issue #2202: Add Grove Range Request handling URL: https://github.com/apache/incubator-trafficcontrol/issues/2202#issuecomment-391449960 partially done through #2262 This is an automated message from

[GitHub] DylanVolz commented on a change in pull request #2247: Add an Origin API

2018-05-22 Thread GitBox
DylanVolz commented on a change in pull request #2247: Add an Origin API URL: https://github.com/apache/incubator-trafficcontrol/pull/2247#discussion_r189988525 ## File path: lib/go-tc/v13/origins.go ## @@ -0,0 +1,150 @@ +package v13 + +import ( +

[GitHub] DylanVolz commented on a change in pull request #2247: Add an Origin API

2018-05-22 Thread GitBox
DylanVolz commented on a change in pull request #2247: Add an Origin API URL: https://github.com/apache/incubator-trafficcontrol/pull/2247#discussion_r189986988 ## File path: lib/go-tc/v13/origins.go ## @@ -0,0 +1,150 @@ +package v13 + +import ( +

[GitHub] knutsel opened a new pull request #2320: Start of integration tests for Grove

2018-05-23 Thread GitBox
knutsel opened a new pull request #2320: Start of integration tests for Grove URL: https://github.com/apache/incubator-trafficcontrol/pull/2320 See #2201 - A simple dockerized thingie to do testing. This is an automated

[GitHub] rob05c opened a new pull request #2300: Add TO Go cachegroups/id/deliveryservices

2018-05-18 Thread GitBox
rob05c opened a new pull request #2300: Add TO Go cachegroups/id/deliveryservices URL: https://github.com/apache/incubator-trafficcontrol/pull/2300 This is an automated message from the Apache Git Service. To respond to the

[GitHub] asfgit commented on issue #2300: Add TO Go cachegroups/id/deliveryservices

2018-05-18 Thread GitBox
asfgit commented on issue #2300: Add TO Go cachegroups/id/deliveryservices URL: https://github.com/apache/incubator-trafficcontrol/pull/2300#issuecomment-390361620 Refer to this link for build results (access rights to CI server needed):

[GitHub] rob05c opened a new pull request #2386: Fix TO Go DS POST to 400 on duplicate, not 5xx

2018-06-10 Thread GitBox
rob05c opened a new pull request #2386: Fix TO Go DS POST to 400 on duplicate, not 5xx URL: https://github.com/apache/incubator-trafficcontrol/pull/2386 Fixes Traffic Ops Golang to return a 400 with a message, when the user tries to POST a delivery service whose xml_id already exists.

[GitHub] asfgit commented on issue #2386: Fix TO Go DS POST to 400 on duplicate, not 5xx

2018-06-10 Thread GitBox
asfgit commented on issue #2386: Fix TO Go DS POST to 400 on duplicate, not 5xx URL: https://github.com/apache/incubator-trafficcontrol/pull/2386#issuecomment-396064741 Refer to this link for build results (access rights to CI server needed):

[GitHub] rob05c closed pull request #2396: Fix TO Go "CRUDer" GetRefTypes to new, not shared

2018-06-12 Thread GitBox
rob05c closed pull request #2396: Fix TO Go "CRUDer" GetRefTypes to new, not shared URL: https://github.com/apache/incubator-trafficcontrol/pull/2396 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] rob05c commented on a change in pull request #2365: Add TO Go api helpers

2018-06-12 Thread GitBox
rob05c commented on a change in pull request #2365: Add TO Go api helpers URL: https://github.com/apache/incubator-trafficcontrol/pull/2365#discussion_r19489 ## File path: traffic_ops/traffic_ops_golang/api/api.go ## @@ -0,0 +1,304 @@ +package api + +/* + * Licensed

[GitHub] rob05c commented on issue #2396: Fix TO Go "CRUDer" GetRefTypes to new, not shared

2018-06-12 Thread GitBox
rob05c commented on issue #2396: Fix TO Go "CRUDer" GetRefTypes to new, not shared URL: https://github.com/apache/incubator-trafficcontrol/pull/2396#issuecomment-396626172 Closed because the "CRUDer" framework only calls the function once and shares it anyway, so it doesn't matter.

[GitHub] rob05c commented on a change in pull request #2365: Add TO Go api helpers

2018-06-12 Thread GitBox
rob05c commented on a change in pull request #2365: Add TO Go api helpers URL: https://github.com/apache/incubator-trafficcontrol/pull/2365#discussion_r194784735 ## File path: traffic_ops/traffic_ops_golang/api/api.go ## @@ -0,0 +1,304 @@ +package api + +/* + * Licensed

[GitHub] ezelkow1 opened a new issue #2397: TP - empty value field for parameter not accepted

2018-06-12 Thread GitBox
ezelkow1 opened a new issue #2397: TP - empty value field for parameter not accepted URL: https://github.com/apache/incubator-trafficcontrol/issues/2397 With the old TO UI we do currently have parameters that have/use empty value fields, i.e. various ATS plugins. These were valid in the

[GitHub] rob05c commented on a change in pull request #2365: Add TO Go api helpers

2018-06-12 Thread GitBox
rob05c commented on a change in pull request #2365: Add TO Go api helpers URL: https://github.com/apache/incubator-trafficcontrol/pull/2365#discussion_r194784848 ## File path: traffic_ops/traffic_ops_golang/api/api.go ## @@ -0,0 +1,304 @@ +package api + +/* + * Licensed

[GitHub] rob05c opened a new pull request #2382: To go dnsseckeys generate

2018-06-08 Thread GitBox
rob05c opened a new pull request #2382: To go dnsseckeys generate URL: https://github.com/apache/incubator-trafficcontrol/pull/2382 Branched from #2365 - recommend merging that first. This is an automated message from the

[GitHub] asfgit commented on issue #2369: To go deletednsseckeys

2018-06-08 Thread GitBox
asfgit commented on issue #2369: To go deletednsseckeys URL: https://github.com/apache/incubator-trafficcontrol/pull/2369#issuecomment-395800314 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR/1787/

[GitHub] asfgit commented on issue #2365: Add TO Go api helpers

2018-06-08 Thread GitBox
asfgit commented on issue #2365: Add TO Go api helpers URL: https://github.com/apache/incubator-trafficcontrol/pull/2365#issuecomment-395793299 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR/1785/

[GitHub] asfgit commented on issue #2382: To go dnsseckeys generate

2018-06-08 Thread GitBox
asfgit commented on issue #2382: To go dnsseckeys generate URL: https://github.com/apache/incubator-trafficcontrol/pull/2382#issuecomment-395798356 Refer to this link for build results (access rights to CI server needed):

[GitHub] elsloo closed pull request #2381: [Issue 2380] add soft link to lib for traffic_stats build

2018-06-08 Thread GitBox
elsloo closed pull request #2381: [Issue 2380] add soft link to lib for traffic_stats build URL: https://github.com/apache/incubator-trafficcontrol/pull/2381 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

<    1   2   3   4   5   6   7   8   9   10   >