[GitHub] dewrich commented on a change in pull request #2451: Fix delivery service validation

2018-06-25 Thread GitBox
dewrich commented on a change in pull request #2451: Fix delivery service validation URL: https://github.com/apache/trafficcontrol/pull/2451#discussion_r197866808 ## File path: lib/go-tc/tovalidate/rules.go ## @@ -46,3 +48,19 @@ func IsOneOfStringICase(set ...string)

[GitHub] asfgit commented on issue #2455: Add TO Go put deliveryservices/id/safe

2018-06-22 Thread GitBox
asfgit commented on issue #2455: Add TO Go put deliveryservices/id/safe URL: https://github.com/apache/trafficcontrol/pull/2455#issuecomment-399552857 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/1888/

[GitHub] mitchell852 commented on issue #2088: TO Go: implement tenants CRUD

2018-06-22 Thread GitBox
mitchell852 commented on issue #2088: TO Go: implement tenants CRUD URL: https://github.com/apache/trafficcontrol/pull/2088#issuecomment-399585762 seems to work as expected. I tested out the CRUD of tenants using TP. I also made sure I could create a DS. maybe somebody with real Go

[GitHub] asfgit commented on issue #2456: Add TO Go delete deliveryservice_user

2018-06-22 Thread GitBox
asfgit commented on issue #2456: Add TO Go delete deliveryservice_user URL: https://github.com/apache/trafficcontrol/pull/2456#issuecomment-399606142 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/1893/

[GitHub] mitchell852 commented on a change in pull request #2358: Created the static dns entry API

2018-06-22 Thread GitBox
mitchell852 commented on a change in pull request #2358: Created the static dns entry API URL: https://github.com/apache/trafficcontrol/pull/2358#discussion_r197504576 ## File path: traffic_ops/traffic_ops_golang/routes.go ## @@ -254,7 +254,12 @@ func Routes(d ServerData)

[GitHub] asfgit commented on issue #2088: TO Go: implement tenants CRUD

2018-06-22 Thread GitBox
asfgit commented on issue #2088: TO Go: implement tenants CRUD URL: https://github.com/apache/trafficcontrol/pull/2088#issuecomment-399581956 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/1892/ Test

[GitHub] rob05c edited a comment on issue #2232: Rewrite Traffic Ops CRConfig Table Endpoints in Go

2018-06-22 Thread GitBox
rob05c edited a comment on issue #2232: Rewrite Traffic Ops CRConfig Table Endpoints in Go URL: https://github.com/apache/trafficcontrol/issues/2232#issuecomment-398070296 # Table Usage ``` get /api/1.1/cdns/domains - DB: Profile, CDN get

[GitHub] rob05c opened a new pull request #2456: Add TO Go delete deliveryservice_user

2018-06-22 Thread GitBox
rob05c opened a new pull request #2456: Add TO Go delete deliveryservice_user URL: https://github.com/apache/trafficcontrol/pull/2456 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] asfgit commented on issue #2088: TO Go: implement tenants CRUD

2018-06-22 Thread GitBox
asfgit commented on issue #2088: TO Go: implement tenants CRUD URL: https://github.com/apache/trafficcontrol/pull/2088#issuecomment-399572843 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/1891/ Test

[GitHub] asfgit commented on issue #2187: updating roles and capabilities seeds

2018-06-22 Thread GitBox
asfgit commented on issue #2187: updating roles and capabilities seeds URL: https://github.com/apache/trafficcontrol/pull/2187#issuecomment-399567563 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/1889/

[GitHub] asfgit commented on issue #2088: TO Go: implement tenants CRUD

2018-06-22 Thread GitBox
asfgit commented on issue #2088: TO Go: implement tenants CRUD URL: https://github.com/apache/trafficcontrol/pull/2088#issuecomment-399568473 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/1890/ Test

[GitHub] dewrich closed pull request #2451: Fix delivery service validation

2018-06-25 Thread GitBox
dewrich closed pull request #2451: Fix delivery service validation URL: https://github.com/apache/trafficcontrol/pull/2451 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] dewrich closed issue #2373: Missing validation in Golang Delivery Service API

2018-06-25 Thread GitBox
dewrich closed issue #2373: Missing validation in Golang Delivery Service API URL: https://github.com/apache/trafficcontrol/issues/2373 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] DylanVolz commented on issue #2249: Add CRConfig DS Modified fields

2018-06-25 Thread GitBox
DylanVolz commented on issue #2249: Add CRConfig DS Modified fields URL: https://github.com/apache/trafficcontrol/pull/2249#issuecomment-400080589 The migration needs to be renamed to a later date so that it will run. It also appears to have syntax errors: `Migrating database...

[GitHub] jhg03a commented on issue #2464: Add documentation generation to pkg

2018-06-25 Thread GitBox
jhg03a commented on issue #2464: Add documentation generation to pkg URL: https://github.com/apache/trafficcontrol/pull/2464#issuecomment-400116732 ok to test This is an automated message from the Apache Git Service. To

[GitHub] dneuman64 commented on a change in pull request #2305: Add TO Go cdns/health

2018-06-25 Thread GitBox
dneuman64 commented on a change in pull request #2305: Add TO Go cdns/health URL: https://github.com/apache/trafficcontrol/pull/2305#discussion_r197957877 ## File path: lib/go-tc/enum.go ## @@ -53,6 +53,8 @@ type DeliveryServiceName string // CacheType is the type (or

[GitHub] dneuman64 commented on issue #2233: Fixed the Go import package alignment because the github project moved

2018-06-25 Thread GitBox
dneuman64 commented on issue #2233: Fixed the Go import package alignment because the github project moved URL: https://github.com/apache/trafficcontrol/pull/2233#issuecomment-400113929 @dewrich is this PR still valid? If so, can you please fix the merge issues?

[GitHub] dneuman64 commented on issue #2284: Remove (Incubating), and some other stuff not needed

2018-06-25 Thread GitBox
dneuman64 commented on issue #2284: Remove (Incubating), and some other stuff not needed URL: https://github.com/apache/trafficcontrol/pull/2284#issuecomment-400113735 Hey @knutsel do you still want this PR merged? It looks like it has some conflicts.

[GitHub] asfgit commented on issue #2187: updating roles and capabilities seeds

2018-06-25 Thread GitBox
asfgit commented on issue #2187: updating roles and capabilities seeds URL: https://github.com/apache/trafficcontrol/pull/2187#issuecomment-400112495 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/1911/

[GitHub] dangogh opened a new pull request #2466: DOC: Update profile_parameter.rst

2018-06-25 Thread GitBox
dangogh opened a new pull request #2466: DOC: Update profile_parameter.rst URL: https://github.com/apache/trafficcontrol/pull/2466 fixed a number of typos and grammatical errors This is an automated message from the Apache

[GitHub] dneuman64 commented on issue #2305: Add TO Go cdns/health

2018-06-25 Thread GitBox
dneuman64 commented on issue #2305: Add TO Go cdns/health URL: https://github.com/apache/trafficcontrol/pull/2305#issuecomment-400113317 I would expect a heathtest.go to be a part of this PR is there a reason it is not included?

[GitHub] asfgit commented on issue #2464: Add documentation generation to pkg

2018-06-25 Thread GitBox
asfgit commented on issue #2464: Add documentation generation to pkg URL: https://github.com/apache/trafficcontrol/pull/2464#issuecomment-400117790 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/1912/ Test

[GitHub] dangogh commented on issue #2464: Add documentation generation to pkg

2018-06-25 Thread GitBox
dangogh commented on issue #2464: Add documentation generation to pkg URL: https://github.com/apache/trafficcontrol/pull/2464#issuecomment-400115997 add to whitelist This is an automated message from the Apache Git Service.

[GitHub] asfgit commented on issue #2466: DOC: Update profile_parameter.rst

2018-06-25 Thread GitBox
asfgit commented on issue #2466: DOC: Update profile_parameter.rst URL: https://github.com/apache/trafficcontrol/pull/2466#issuecomment-400133245 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/1913/ Test

[GitHub] asfgit commented on issue #2358: Created the static dns entry API

2018-06-25 Thread GitBox
asfgit commented on issue #2358: Created the static dns entry API URL: https://github.com/apache/trafficcontrol/pull/2358#issuecomment-400045765 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/1910/ Test

[GitHub] jhg03a opened a new pull request #2464: Add documentation generation to pkg

2018-06-25 Thread GitBox
jhg03a opened a new pull request #2464: Add documentation generation to pkg URL: https://github.com/apache/trafficcontrol/pull/2464 #2463. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] dangogh opened a new issue #2465: TO Go API: .../profile/name/x/parameters does not check for missing keys

2018-06-25 Thread GitBox
dangogh opened a new issue #2465: TO Go API: .../profile/name/x/parameters does not check for missing keys URL: https://github.com/apache/trafficcontrol/issues/2465 had a parameters.json with content like this: ``` [ { "name" : "foo", "value": "value for foo",

[GitHub] jhg03a opened a new issue #2463: Feature: Add documentation generation to pkg

2018-06-25 Thread GitBox
jhg03a opened a new issue #2463: Feature: Add documentation generation to pkg URL: https://github.com/apache/trafficcontrol/issues/2463 I believe it would be worthwhile to enable new developers and technical writers the ability to easily compile our documentation. As a secondary bonus,

[GitHub] asfgit commented on issue #2451: Fix delivery service validation

2018-06-25 Thread GitBox
asfgit commented on issue #2451: Fix delivery service validation URL: https://github.com/apache/trafficcontrol/pull/2451#issuecomment-400044860 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/1909/ Test

[GitHub] asfgit commented on issue #2464: Add documentation generation to pkg

2018-06-25 Thread GitBox
asfgit commented on issue #2464: Add documentation generation to pkg URL: https://github.com/apache/trafficcontrol/pull/2464#issuecomment-400094284 Can one of the admins verify this patch? This is an automated message from

[GitHub] dneuman64 closed pull request #2289: Foundation for Java Api Client

2018-06-25 Thread GitBox
dneuman64 closed pull request #2289: Foundation for Java Api Client URL: https://github.com/apache/trafficcontrol/pull/2289 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] dewrich closed pull request #2466: DOC: Update profile_parameter.rst

2018-06-26 Thread GitBox
dewrich closed pull request #2466: DOC: Update profile_parameter.rst URL: https://github.com/apache/trafficcontrol/pull/2466 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] rob05c edited a comment on issue #2232: Rewrite Traffic Ops CRConfig Table Endpoints in Go

2018-06-23 Thread GitBox
rob05c edited a comment on issue #2232: Rewrite Traffic Ops CRConfig Table Endpoints in Go URL: https://github.com/apache/trafficcontrol/issues/2232#issuecomment-398070296 # Table Usage ``` get /api/1.1/cdns/domains - DB: Profile, CDN get

[GitHub] rob05c opened a new pull request #2457: Add TO Go post deliveryservice_user

2018-06-23 Thread GitBox
rob05c opened a new pull request #2457: Add TO Go post deliveryservice_user URL: https://github.com/apache/trafficcontrol/pull/2457 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] asfgit commented on issue #2457: Add TO Go post deliveryservice_user

2018-06-23 Thread GitBox
asfgit commented on issue #2457: Add TO Go post deliveryservice_user URL: https://github.com/apache/trafficcontrol/pull/2457#issuecomment-399655264 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/1895/ Test

[GitHub] dangogh opened a new issue #2454: TO API: "tenants" endpoint returning id as string

2018-06-22 Thread GitBox
dangogh opened a new issue #2454: TO API: "tenants" endpoint returning id as string URL: https://github.com/apache/trafficcontrol/issues/2454 This is a recent regression. The `api/1.2/tenants` endpoint returns the `id` field as a string rather than an integer. This causes the `POST

[GitHub] rob05c opened a new pull request #2455: Add TO Go put deliveryservices/id/safe

2018-06-22 Thread GitBox
rob05c opened a new pull request #2455: Add TO Go put deliveryservices/id/safe URL: https://github.com/apache/trafficcontrol/pull/2455 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] asfgit commented on issue #2088: TO Go: implement tenants CRUD

2018-06-22 Thread GitBox
asfgit commented on issue #2088: TO Go: implement tenants CRUD URL: https://github.com/apache/trafficcontrol/pull/2088#issuecomment-399532894 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/1887/ Test

[GitHub] rob05c edited a comment on issue #2232: Rewrite Traffic Ops CRConfig Table Endpoints in Go

2018-06-22 Thread GitBox
rob05c edited a comment on issue #2232: Rewrite Traffic Ops CRConfig Table Endpoints in Go URL: https://github.com/apache/trafficcontrol/issues/2232#issuecomment-398070296 # Table Usage ``` get /api/1.1/cdns/domains - DB: Profile, CDN get

[GitHub] mitchell852 commented on issue #2454: TO API: "tenants" endpoint returning id as string

2018-06-22 Thread GitBox
mitchell852 commented on issue #2454: TO API: "tenants" endpoint returning id as string URL: https://github.com/apache/trafficcontrol/issues/2454#issuecomment-399500828 I don't think it causes the `POST .../deliveryservice` endpoint to fail per se but it will if you call it via TP which

[GitHub] mitchell852 commented on a change in pull request #2358: Created the static dns entry API

2018-06-22 Thread GitBox
mitchell852 commented on a change in pull request #2358: Created the static dns entry API URL: https://github.com/apache/trafficcontrol/pull/2358#discussion_r197504576 ## File path: traffic_ops/traffic_ops_golang/routes.go ## @@ -254,7 +254,12 @@ func Routes(d ServerData)

[GitHub] asfgit commented on issue #2453: show / hide TP views based on a users capabilities

2018-06-22 Thread GitBox
asfgit commented on issue #2453: show / hide TP views based on a users capabilities URL: https://github.com/apache/trafficcontrol/pull/2453#issuecomment-399497366 Refer to this link for build results (access rights to CI server needed):

[GitHub] asfgit commented on issue #2305: Add TO Go cdns/health

2018-06-23 Thread GitBox
asfgit commented on issue #2305: Add TO Go cdns/health URL: https://github.com/apache/trafficcontrol/pull/2305#issuecomment-399690543 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/1896/ Test PASSed.

[GitHub] rob05c edited a comment on issue #2232: Rewrite Traffic Ops CRConfig Table Endpoints in Go

2018-06-23 Thread GitBox
rob05c edited a comment on issue #2232: Rewrite Traffic Ops CRConfig Table Endpoints in Go URL: https://github.com/apache/trafficcontrol/issues/2232#issuecomment-398070296 # Table Usage ``` get /api/1.1/cdns/domains - DB: Profile, CDN get

[GitHub] asfgit commented on issue #2305: Add TO Go cdns/health

2018-06-23 Thread GitBox
asfgit commented on issue #2305: Add TO Go cdns/health URL: https://github.com/apache/trafficcontrol/pull/2305#issuecomment-399705038 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/1900/ Test PASSed.

[GitHub] rob05c opened a new pull request #2458: Add TO Go deliveryservices/id/health

2018-06-23 Thread GitBox
rob05c opened a new pull request #2458: Add TO Go deliveryservices/id/health URL: https://github.com/apache/trafficcontrol/pull/2458 Branched from https://github.com/apache/trafficcontrol/pull/2305 - recommend merging that first.

[GitHub] asfgit commented on issue #2458: Add TO Go deliveryservices/id/health

2018-06-23 Thread GitBox
asfgit commented on issue #2458: Add TO Go deliveryservices/id/health URL: https://github.com/apache/trafficcontrol/pull/2458#issuecomment-399698400 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/1898/

[GitHub] asfgit commented on issue #2305: Add TO Go cdns/health

2018-06-23 Thread GitBox
asfgit commented on issue #2305: Add TO Go cdns/health URL: https://github.com/apache/trafficcontrol/pull/2305#issuecomment-399695160 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/1897/ Test PASSed.

[GitHub] asfgit commented on issue #2458: Add TO Go deliveryservices/id/health

2018-06-23 Thread GitBox
asfgit commented on issue #2458: Add TO Go deliveryservices/id/health URL: https://github.com/apache/trafficcontrol/pull/2458#issuecomment-399704583 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/1899/

[GitHub] rob05c edited a comment on issue #2232: Rewrite Traffic Ops CRConfig Table Endpoints in Go

2018-06-23 Thread GitBox
rob05c edited a comment on issue #2232: Rewrite Traffic Ops CRConfig Table Endpoints in Go URL: https://github.com/apache/trafficcontrol/issues/2232#issuecomment-398070296 # Table Usage ``` get /api/1.1/cdns/domains - DB: Profile, CDN get

[GitHub] rob05c opened a new pull request #2459: Add TO Go deliveryservices/id/capacity

2018-06-23 Thread GitBox
rob05c opened a new pull request #2459: Add TO Go deliveryservices/id/capacity URL: https://github.com/apache/trafficcontrol/pull/2459 Branched from #2305 - recommend merging that first. This is an automated message from the

[GitHub] asfgit commented on issue #2459: Add TO Go deliveryservices/id/capacity

2018-06-23 Thread GitBox
asfgit commented on issue #2459: Add TO Go deliveryservices/id/capacity URL: https://github.com/apache/trafficcontrol/pull/2459#issuecomment-399723358 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/1901/

[GitHub] rob05c commented on a change in pull request #2437: Fix TO Go CRConfig generation to ignore active ANY_MAP DSes

2018-06-20 Thread GitBox
rob05c commented on a change in pull request #2437: Fix TO Go CRConfig generation to ignore active ANY_MAP DSes URL: https://github.com/apache/trafficcontrol/pull/2437#discussion_r196926230 ## File path: traffic_ops/traffic_ops_golang/crconfig/deliveryservice.go ## @@

[GitHub] asfgit commented on issue #1993: [Issue-1617] - Traffic Ops Keeps track of configuration differences between database and Traffic Servers

2018-06-20 Thread GitBox
asfgit commented on issue #1993: [Issue-1617] - Traffic Ops Keeps track of configuration differences between database and Traffic Servers URL: https://github.com/apache/trafficcontrol/pull/1993#issuecomment-398912636 Can one of the admins verify this patch?

[GitHub] asfgit commented on issue #2289: Foundation for Java Api Client

2018-06-20 Thread GitBox
asfgit commented on issue #2289: Foundation for Java Api Client URL: https://github.com/apache/trafficcontrol/pull/2289#issuecomment-398912517 Can one of the admins verify this patch? This is an automated message from the

[GitHub] asfgit commented on issue #2331: Traffic Router upgrade Tomcat to 8.5

2018-06-20 Thread GitBox
asfgit commented on issue #2331: Traffic Router upgrade Tomcat to 8.5 URL: https://github.com/apache/trafficcontrol/pull/2331#issuecomment-398912444 Can one of the admins verify this patch? This is an automated message from

[GitHub] asfgit commented on issue #2407: Edge retrieval from origin - Configuring go_direct from traffic ops. [WIP]

2018-06-20 Thread GitBox
asfgit commented on issue #2407: Edge retrieval from origin - Configuring go_direct from traffic ops. [WIP] URL: https://github.com/apache/trafficcontrol/pull/2407#issuecomment-398912289 Can one of the admins verify this patch?

[GitHub] asfgit commented on issue #2437: Fix TO Go CRConfig generation to ignore active ANY_MAP DSes

2018-06-20 Thread GitBox
asfgit commented on issue #2437: Fix TO Go CRConfig generation to ignore active ANY_MAP DSes URL: https://github.com/apache/trafficcontrol/pull/2437#issuecomment-398881895 Refer to this link for build results (access rights to CI server needed):

[GitHub] asfgit commented on issue #2437: Fix TO Go CRConfig generation to ignore active ANY_MAP DSes

2018-06-20 Thread GitBox
asfgit commented on issue #2437: Fix TO Go CRConfig generation to ignore active ANY_MAP DSes URL: https://github.com/apache/trafficcontrol/pull/2437#issuecomment-398884596 Refer to this link for build results (access rights to CI server needed):

[GitHub] rob05c opened a new pull request #2439: Add TO Go riak/bucket

2018-06-20 Thread GitBox
rob05c opened a new pull request #2439: Add TO Go riak/bucket URL: https://github.com/apache/trafficcontrol/pull/2439 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] rob05c edited a comment on issue #2232: Rewrite Traffic Ops CRConfig Table Endpoints in Go

2018-06-20 Thread GitBox
rob05c edited a comment on issue #2232: Rewrite Traffic Ops CRConfig Table Endpoints in Go URL: https://github.com/apache/trafficcontrol/issues/2232#issuecomment-398070296 # Table Usage ``` get /api/1.1/cdns/:name/configs/routing - DB: Server, Profile, Cdn, Parameter,

[GitHub] asfgit commented on issue #2438: License compliance updates

2018-06-20 Thread GitBox
asfgit commented on issue #2438: License compliance updates URL: https://github.com/apache/trafficcontrol/pull/2438#issuecomment-398911801 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR/1866/

[GitHub] asfgit commented on issue #2434: Range Slice mode for the range_req_handler

2018-06-20 Thread GitBox
asfgit commented on issue #2434: Range Slice mode for the range_req_handler URL: https://github.com/apache/trafficcontrol/pull/2434#issuecomment-398806847 Refer to this link for build results (access rights to CI server needed):

[GitHub] rob05c closed pull request #2437: Fix TO Go CRConfig generation to ignore active ANY_MAP DSes

2018-06-20 Thread GitBox
rob05c closed pull request #2437: Fix TO Go CRConfig generation to ignore active ANY_MAP DSes URL: https://github.com/apache/trafficcontrol/pull/2437 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] rob05c closed issue #1121: Traffic Ops does not ignore active ANY_MAP Delivery Services when generating CRConfig

2018-06-20 Thread GitBox
rob05c closed issue #1121: Traffic Ops does not ignore active ANY_MAP Delivery Services when generating CRConfig URL: https://github.com/apache/trafficcontrol/issues/1121 This is an automated message from the Apache Git

[GitHub] dangogh commented on issue #2438: License compliance updates

2018-06-20 Thread GitBox
dangogh commented on issue #2438: License compliance updates URL: https://github.com/apache/trafficcontrol/pull/2438#issuecomment-398891468 retest this please This is an automated message from the Apache Git Service. To

[GitHub] asfgit commented on issue #2439: Add TO Go riak/bucket

2018-06-20 Thread GitBox
asfgit commented on issue #2439: Add TO Go riak/bucket URL: https://github.com/apache/trafficcontrol/pull/2439#issuecomment-398913222 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR/1867/ Test

[GitHub] asfgit commented on issue #2434: Range Slice mode for the range_req_handler

2018-06-20 Thread GitBox
asfgit commented on issue #2434: Range Slice mode for the range_req_handler URL: https://github.com/apache/trafficcontrol/pull/2434#issuecomment-398882958 Refer to this link for build results (access rights to CI server needed):

[GitHub] dangogh opened a new pull request #2438: License compliance updates

2018-06-20 Thread GitBox
dangogh opened a new pull request #2438: License compliance updates URL: https://github.com/apache/trafficcontrol/pull/2438 - new svg file needed an exception along with other logos - generated Perl files needed license added - files removed from docs dir needed to be removed from the

[GitHub] DylanVolz edited a comment on issue #2232: Rewrite Traffic Ops CRConfig Table Endpoints in Go

2018-06-20 Thread GitBox
DylanVolz edited a comment on issue #2232: Rewrite Traffic Ops CRConfig Table Endpoints in Go URL: https://github.com/apache/trafficcontrol/issues/2232#issuecomment-389995964 Here is the expected form of the above routes comma delimited as Method,Route GET,asns/?$ POST,asns/?$

[GitHub] rob05c edited a comment on issue #2232: Rewrite Traffic Ops CRConfig Table Endpoints in Go

2018-06-20 Thread GitBox
rob05c edited a comment on issue #2232: Rewrite Traffic Ops CRConfig Table Endpoints in Go URL: https://github.com/apache/trafficcontrol/issues/2232#issuecomment-398070296 # Table Usage ``` get /api/1.1/cdns/:name/configs/routing - DB: Server, Profile, Cdn, Parameter,

[GitHub] asfgit commented on issue #731: [TC-192] Differentiates between goTM and javaTM rpm builds

2018-06-20 Thread GitBox
asfgit commented on issue #731: [TC-192] Differentiates between goTM and javaTM rpm builds URL: https://github.com/apache/trafficcontrol/pull/731#issuecomment-398912752 Can one of the admins verify this patch? This is an

[GitHub] asfgit commented on issue #2438: License compliance updates

2018-06-20 Thread GitBox
asfgit commented on issue #2438: License compliance updates URL: https://github.com/apache/trafficcontrol/pull/2438#issuecomment-398914195 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR/1868/

[GitHub] alficles commented on a change in pull request #2364: Fix Traffic Ops Go to use transactions for deliveryservices, sslkeys, urisigning

2018-06-19 Thread GitBox
alficles commented on a change in pull request #2364: Fix Traffic Ops Go to use transactions for deliveryservices, sslkeys, urisigning URL: https://github.com/apache/trafficcontrol/pull/2364#discussion_r196155014 ## File path: lib/go-tc/deliveryservices.go ## @@ -205,6

[GitHub] alficles commented on a change in pull request #2364: Fix Traffic Ops Go to use transactions for deliveryservices, sslkeys, urisigning

2018-06-19 Thread GitBox
alficles commented on a change in pull request #2364: Fix Traffic Ops Go to use transactions for deliveryservices, sslkeys, urisigning URL: https://github.com/apache/trafficcontrol/pull/2364#discussion_r196160170 ## File path:

[GitHub] alficles commented on a change in pull request #2364: Fix Traffic Ops Go to use transactions for deliveryservices, sslkeys, urisigning

2018-06-19 Thread GitBox
alficles commented on a change in pull request #2364: Fix Traffic Ops Go to use transactions for deliveryservices, sslkeys, urisigning URL: https://github.com/apache/trafficcontrol/pull/2364#discussion_r196155822 ## File path: lib/go-tc/deliveryservices.go ## @@ -205,6

[GitHub] alficles commented on a change in pull request #2364: Fix Traffic Ops Go to use transactions for deliveryservices, sslkeys, urisigning

2018-06-19 Thread GitBox
alficles commented on a change in pull request #2364: Fix Traffic Ops Go to use transactions for deliveryservices, sslkeys, urisigning URL: https://github.com/apache/trafficcontrol/pull/2364#discussion_r196157510 ## File path: lib/go-tc/deliveryservices.go ## @@ -205,6

[GitHub] rob05c commented on issue #2407: Edge retrieval from origin - Configuring go_direct from traffic ops. [WIP]

2018-06-19 Thread GitBox
rob05c commented on issue #2407: Edge retrieval from origin - Configuring go_direct from traffic ops. [WIP] URL: https://github.com/apache/trafficcontrol/pull/2407#issuecomment-398422287 At what point are we implementing a cross product here? Seems like we should separate the underlying

[GitHub] rawlinp commented on issue #2407: Edge retrieval from origin - Configuring go_direct from traffic ops. [WIP]

2018-06-19 Thread GitBox
rawlinp commented on issue #2407: Edge retrieval from origin - Configuring go_direct from traffic ops. [WIP] URL: https://github.com/apache/trafficcontrol/pull/2407#issuecomment-398413475 Ok I think I understand now. ATS will go through all the parents first before going directly to the

[GitHub] rob05c commented on a change in pull request #2364: Fix Traffic Ops Go to use transactions for deliveryservices, sslkeys, urisigning

2018-06-19 Thread GitBox
rob05c commented on a change in pull request #2364: Fix Traffic Ops Go to use transactions for deliveryservices, sslkeys, urisigning URL: https://github.com/apache/trafficcontrol/pull/2364#discussion_r196446972 ## File path: lib/go-tc/deliveryservices.go ## @@ -205,6

[GitHub] limited commented on issue #2407: Edge retrieval from origin - Configuring go_direct from traffic ops. [WIP]

2018-06-19 Thread GitBox
limited commented on issue #2407: Edge retrieval from origin - Configuring go_direct from traffic ops. [WIP] URL: https://github.com/apache/trafficcontrol/pull/2407#issuecomment-398420385 Not a bad idea for a new DS Type. We could do (not suggesting actual naming, just the

[GitHub] rob05c commented on a change in pull request #2364: Fix Traffic Ops Go to use transactions for deliveryservices, sslkeys, urisigning

2018-06-19 Thread GitBox
rob05c commented on a change in pull request #2364: Fix Traffic Ops Go to use transactions for deliveryservices, sslkeys, urisigning URL: https://github.com/apache/trafficcontrol/pull/2364#discussion_r196448115 ## File path:

[GitHub] rob05c commented on a change in pull request #2364: Fix Traffic Ops Go to use transactions for deliveryservices, sslkeys, urisigning

2018-06-19 Thread GitBox
rob05c commented on a change in pull request #2364: Fix Traffic Ops Go to use transactions for deliveryservices, sslkeys, urisigning URL: https://github.com/apache/trafficcontrol/pull/2364#discussion_r196448115 ## File path:

[GitHub] rob05c commented on a change in pull request #2364: Fix Traffic Ops Go to use transactions for deliveryservices, sslkeys, urisigning

2018-06-19 Thread GitBox
rob05c commented on a change in pull request #2364: Fix Traffic Ops Go to use transactions for deliveryservices, sslkeys, urisigning URL: https://github.com/apache/trafficcontrol/pull/2364#discussion_r196461033 ## File path:

[GitHub] rawlinp commented on issue #2407: Edge retrieval from origin - Configuring go_direct from traffic ops. [WIP]

2018-06-19 Thread GitBox
rawlinp commented on issue #2407: Edge retrieval from origin - Configuring go_direct from traffic ops. [WIP] URL: https://github.com/apache/trafficcontrol/pull/2407#issuecomment-398433002 I don't know what's worse, new DS types or a new DS field that doesn't apply to/conflicts with

[GitHub] limited edited a comment on issue #2407: Edge retrieval from origin - Configuring go_direct from traffic ops. [WIP]

2018-06-19 Thread GitBox
limited edited a comment on issue #2407: Edge retrieval from origin - Configuring go_direct from traffic ops. [WIP] URL: https://github.com/apache/trafficcontrol/pull/2407#issuecomment-398420385 Not a bad idea for a new DS Type. We could do (not suggesting actual naming, just the

[GitHub] rob05c commented on a change in pull request #2364: Fix Traffic Ops Go to use transactions for deliveryservices, sslkeys, urisigning

2018-06-19 Thread GitBox
rob05c commented on a change in pull request #2364: Fix Traffic Ops Go to use transactions for deliveryservices, sslkeys, urisigning URL: https://github.com/apache/trafficcontrol/pull/2364#discussion_r196446230 ## File path: lib/go-tc/deliveryservices.go ## @@ -205,6

[GitHub] asfgit commented on issue #2435: Filter the list of potential Steering Targets in Traffic Portal

2018-06-20 Thread GitBox
asfgit commented on issue #2435: Filter the list of potential Steering Targets in Traffic Portal URL: https://github.com/apache/trafficcontrol/pull/2435#issuecomment-398830491 Refer to this link for build results (access rights to CI server needed):

[GitHub] nerdynick opened a new pull request #2436: Added SVG version of Logo

2018-06-20 Thread GitBox
nerdynick opened a new pull request #2436: Added SVG version of Logo URL: https://github.com/apache/trafficcontrol/pull/2436 SVG version of PSD logo This is an automated message from the Apache Git Service. To respond to the

[GitHub] asfgit commented on issue #2436: Added SVG version of Logo

2018-06-20 Thread GitBox
asfgit commented on issue #2436: Added SVG version of Logo URL: https://github.com/apache/trafficcontrol/pull/2436#issuecomment-398847903 Can one of the admins verify this patch? This is an automated message from the Apache

[GitHub] asfgit commented on issue #2436: Added SVG version of Logo

2018-06-20 Thread GitBox
asfgit commented on issue #2436: Added SVG version of Logo URL: https://github.com/apache/trafficcontrol/pull/2436#issuecomment-398847692 Can one of the admins verify this patch? This is an automated message from the Apache

[GitHub] mitchell852 closed issue #1884: Traffic Portal: filter dropdown list of potential Steering targets

2018-06-20 Thread GitBox
mitchell852 closed issue #1884: Traffic Portal: filter dropdown list of potential Steering targets URL: https://github.com/apache/trafficcontrol/issues/1884 This is an automated message from the Apache Git Service. To

[GitHub] mitchell852 closed pull request #2435: Filter the list of potential Steering Targets in Traffic Portal

2018-06-20 Thread GitBox
mitchell852 closed pull request #2435: Filter the list of potential Steering Targets in Traffic Portal URL: https://github.com/apache/trafficcontrol/pull/2435 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] limited commented on issue #1732: Add Docker TM Compose for load testing

2018-06-20 Thread GitBox
limited commented on issue #1732: Add Docker TM Compose for load testing URL: https://github.com/apache/trafficcontrol/pull/1732#issuecomment-398862068 Got the following error building `traffic_monitor_load_test_traffic_ops_database` image: ``` ---> Running in 2b78254facc3

[GitHub] rawlinp opened a new pull request #2437: Fix TO Go CRConfig generation to ignore active ANY_MAP DSes

2018-06-20 Thread GitBox
rawlinp opened a new pull request #2437: Fix TO Go CRConfig generation to ignore active ANY_MAP DSes URL: https://github.com/apache/trafficcontrol/pull/2437 This is a regression from the Perl version of the CRConfig generation which ignores active ANY_MAP DSes. Fixes #1121

[GitHub] asfgit commented on issue #2434: Range Slice mode for the range_req_handler

2018-06-20 Thread GitBox
asfgit commented on issue #2434: Range Slice mode for the range_req_handler URL: https://github.com/apache/trafficcontrol/pull/2434#issuecomment-398829471 Refer to this link for build results (access rights to CI server needed):

[GitHub] rob05c commented on issue #1732: Add Docker TM Compose for load testing

2018-06-20 Thread GitBox
rob05c commented on issue #1732: Add Docker TM Compose for load testing URL: https://github.com/apache/trafficcontrol/pull/1732#issuecomment-398865711 Yeah, it currently needs a DB dump, just to get TO running. Maybe we can script creating everything we need, or maybe we can sanitize a sql

[GitHub] asfgit commented on issue #2187: updating roles and capabilities seeds

2018-06-19 Thread GitBox
asfgit commented on issue #2187: updating roles and capabilities seeds URL: https://github.com/apache/trafficcontrol/pull/2187#issuecomment-398601066 Refer to this link for build results (access rights to CI server needed):

[GitHub] asfgit commented on issue #2432: Add TO Go deliveryservices urlkeys

2018-06-19 Thread GitBox
asfgit commented on issue #2432: Add TO Go deliveryservices urlkeys URL: https://github.com/apache/trafficcontrol/pull/2432#issuecomment-398618771 Refer to this link for build results (access rights to CI server needed):

[GitHub] rob05c edited a comment on issue #2232: Rewrite Traffic Ops CRConfig Table Endpoints in Go

2018-06-19 Thread GitBox
rob05c edited a comment on issue #2232: Rewrite Traffic Ops CRConfig Table Endpoints in Go URL: https://github.com/apache/trafficcontrol/issues/2232#issuecomment-398070296 # Table Usage ``` get /api/1.1/cdns/:name/configs/routing - DB: Server, Profile, Cdn, Parameter,

<    4   5   6   7   8   9   10   11   12   13   >