[GitHub] [trafficcontrol] kdamichie opened a new pull request, #7332: Add new role to user

kdamichie opened a new pull request, #7332: URL: https://github.com/apache/trafficcontrol/pull/7332 This PR is a DB entry for a new role called `trouter` that is for Traffic Router to watch Traffic Ops resources ## Which Traffic Control components are affected by this PR?

[GitHub] [trafficcontrol] ocket8888 opened a new pull request, #7335: TPv2 fix login redirect

ocket opened a new pull request, #7335: URL: https://github.com/apache/trafficcontrol/pull/7335 Login redirect is broken because it can't handle query string parameters. This PR fixes it so unauthenticated users are directed back where they were trying to go after logging in.

[GitHub] [trafficcontrol] srijeet0406 commented on pull request #7328: TP/TPv2 tests: Get admin role ID from the database

srijeet0406 commented on PR #7328: URL: https://github.com/apache/trafficcontrol/pull/7328#issuecomment-1412641454 I'll merge this once @tcfdev approves the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [trafficcontrol] zrhoffman opened a new pull request, #7334: Update Go version to 1.20

zrhoffman opened a new pull request, #7334: URL: https://github.com/apache/trafficcontrol/pull/7334 ## What does this PR (Pull Request) do? This PR makes the Go components of Traffic Control build using Go version 1.20 and updates the `golang.org/x/` dependencies. See the Go

[GitHub] [trafficcontrol] ocket8888 merged pull request #7330: Moved Fair Queueing Pacing Rate Bps field to Cache Configuration Settings section

ocket merged PR #7330: URL: https://github.com/apache/trafficcontrol/pull/7330 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] ocket8888 closed issue #5557: TP: Fair Queueing Pacing Rate Bps delivery service field should be under Cache Configuration Settings

ocket closed issue #5557: TP: Fair Queueing Pacing Rate Bps delivery service field should be under Cache Configuration Settings URL: https://github.com/apache/trafficcontrol/issues/5557 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [trafficcontrol] traeak commented on a diff in pull request #7323: t3c add support for anycast on http routed delivery services

traeak commented on code in PR #7323: URL: https://github.com/apache/trafficcontrol/pull/7323#discussion_r1093721734 ## lib/go-atscfg/remapdotconfig_test.go: ## @@ -72,12 +91,203 @@ func pluginsFromTokens(tokens []string, prefix string) []string { return plugins }

[GitHub] [trafficcontrol] traeak commented on a diff in pull request #7323: t3c add support for anycast on http routed delivery services

traeak commented on code in PR #7323: URL: https://github.com/apache/trafficcontrol/pull/7323#discussion_r1093722171 ## lib/go-atscfg/remapdotconfig_test.go: ## @@ -72,12 +91,203 @@ func pluginsFromTokens(tokens []string, prefix string) []string { return plugins }

[GitHub] [trafficcontrol] zrhoffman merged pull request #7288: Move assert functionality

zrhoffman merged PR #7288: URL: https://github.com/apache/trafficcontrol/pull/7288 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7288: Move assert functionality

zrhoffman commented on code in PR #7288: URL: https://github.com/apache/trafficcontrol/pull/7288#discussion_r1126918455 ## lib/go-util/assert/assertions.go: ## @@ -162,3 +162,63 @@ func RequireNotEqual(t *testing.T, a, b interface{}, msgAndArgs ...interface{})

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7358: Kannan victory 1 - statuses table, details

ocket commented on code in PR #7358: URL: https://github.com/apache/trafficcontrol/pull/7358#discussion_r1126861189 ## experimental/traffic-portal/src/app/api/server.service.ts: ## @@ -186,4 +187,33 @@ export class ServerService extends APIService { return

[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7384: Bump golang.org/x/sys from 0.0.0-20211013075003-97ac67df715c to 0.1.0

codecov[bot] commented on PR #7384: URL: https://github.com/apache/trafficcontrol/pull/7384#issuecomment-1460425094 #

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7383: Fixes service_categories response to POST API

rimashah25 commented on code in PR #7383: URL: https://github.com/apache/trafficcontrol/pull/7383#discussion_r1129855863 ## traffic_ops/traffic_ops_golang/api/generic_crud.go: ## @@ -119,19 +119,39 @@ func GenericCreateNameBasedID(val GenericCreator) (error, error, int) {

[GitHub] [trafficcontrol] zrhoffman opened a new issue, #6304: Users cannot import the TO API 4.0 client

zrhoffman opened a new issue, #6304: URL: https://github.com/apache/trafficcontrol/issues/6304 ## This Bug Report affects these Traffic Control components: - Users and 3rd-party clients ## Current behavior: Go packages that are new in ATC 6.0.0 cannot be

[GitHub] [trafficcontrol] dependabot[bot] opened a new pull request, #7385: Bump golang.org/x/text from 0.3.7 to 0.3.8

dependabot[bot] opened a new pull request, #7385: URL: https://github.com/apache/trafficcontrol/pull/7385 Bumps [golang.org/x/text](https://github.com/golang/text) from 0.3.7 to 0.3.8. Commits

[GitHub] [trafficcontrol] dependabot[bot] opened a new pull request, #7384: Bump golang.org/x/sys from 0.0.0-20211013075003-97ac67df715c to 0.1.0

dependabot[bot] opened a new pull request, #7384: URL: https://github.com/apache/trafficcontrol/pull/7384 Bumps [golang.org/x/sys](https://github.com/golang/sys) from 0.0.0-20211013075003-97ac67df715c to 0.1.0. Commits See full diff in

[GitHub] [trafficcontrol] zrhoffman merged pull request #7381: Update Go version to 1.19.7

zrhoffman merged PR #7381: URL: https://github.com/apache/trafficcontrol/pull/7381 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] zrhoffman commented on issue #6304: Users cannot import the TO API 4.0 client

zrhoffman commented on issue #6304: URL: https://github.com/apache/trafficcontrol/issues/6304#issuecomment-1460510654 This is still an issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7385: Bump golang.org/x/text from 0.3.7 to 0.3.8

codecov[bot] commented on PR #7385: URL: https://github.com/apache/trafficcontrol/pull/7385#issuecomment-1460428919 #

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7392: Traffic Ops client certificate authentication

ocket commented on code in PR #7392: URL: https://github.com/apache/trafficcontrol/pull/7392#discussion_r1131952932 ## traffic_ops/traffic_ops_golang/auth/certificate.go: ## @@ -0,0 +1,167 @@ +package auth + +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [trafficcontrol] ocket8888 commented on pull request #7393: [Docs] Change Role to Api Name

ocket commented on PR #7393: URL: https://github.com/apache/trafficcontrol/pull/7393#issuecomment-1463286391 I think instead you should change it to > _"The name of the [Role](https://traffic-control-cdn.readthedocs.io/en/latest/glossary.html#term-Role) which will be given to

[GitHub] [trafficcontrol] Rohith-Raju commented on pull request #7393: [Docs] Change Role to Api Name

Rohith-Raju commented on PR #7393: URL: https://github.com/apache/trafficcontrol/pull/7393#issuecomment-1463235870 @ocket can I change it to > "A name, unique identifier of the highest permission [Role](https://traffic-control-cdn.readthedocs.io/en/latest/glossary.html#term-Role)

[GitHub] [trafficcontrol] mitchell852 opened a new pull request, #7380: TP: adds strikethru for expired certs and red for less than 7 days until expiration

mitchell852 opened a new pull request, #7380: URL: https://github.com/apache/trafficcontrol/pull/7380 Added some color coding to the rows of the cert expiration table: expired = strikethru 7 days until expiration = red 30 days until expiration = yellow ## Which

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7110: Feature - Traffic Ops Client Certificate Authentication

zrhoffman commented on code in PR #7110: URL: https://github.com/apache/trafficcontrol/pull/7110#discussion_r1131408827 ## experimental/certificate_auth/certs/generate_certs.go: ## @@ -0,0 +1,446 @@ +package main + +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7110: Feature - Traffic Ops Client Certificate Authentication

zrhoffman commented on code in PR #7110: URL: https://github.com/apache/trafficcontrol/pull/7110#discussion_r1131409243 ## traffic_ops/traffic_ops_golang/login/login.go: ## @@ -108,135 +108,184 @@ Subject: {{.InstanceName}} Password Reset Request` + "\r\n\r" + ` `)) +//

[GitHub] [trafficcontrol] Rohith-Raju opened a new pull request, #7393: [Docs] Change Role to Api Name

Rohith-Raju opened a new pull request, #7393: URL: https://github.com/apache/trafficcontrol/pull/7393 Closes: #7326 Documentation changes for user registration endpoint `role` property. In APIv4 and later, Roles don't have IDs and use names as their primary identifiers. The

[GitHub] [trafficcontrol] zrhoffman opened a new pull request, #7392: Traffic Ops client certificate authentication

zrhoffman opened a new pull request, #7392: URL: https://github.com/apache/trafficcontrol/pull/7392 ## Overview (Largely reposting @tcfdev's PR description from #7110): This PR implements #6622 by adding the ability for a Traffic Ops instance to accept TLS certificates

[GitHub] [trafficcontrol] zrhoffman commented on pull request #7110: Feature - Traffic Ops Client Certificate Authentication

zrhoffman commented on PR #7110: URL: https://github.com/apache/trafficcontrol/pull/7110#issuecomment-1462528871 @tcfdev re-PRed this with edits at #7392 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7392: Traffic Ops client certificate authentication

codecov[bot] commented on PR #7392: URL: https://github.com/apache/trafficcontrol/pull/7392#issuecomment-1462539531 #

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7110: Feature - Traffic Ops Client Certificate Authentication

zrhoffman commented on code in PR #7110: URL: https://github.com/apache/trafficcontrol/pull/7110#discussion_r1131409458 ## traffic_ops/traffic_ops_golang/login/login.go: ## @@ -108,135 +108,184 @@ Subject: {{.InstanceName}} Password Reset Request` + "\r\n\r" + ` `)) +//

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7110: Feature - Traffic Ops Client Certificate Authentication

zrhoffman commented on code in PR #7110: URL: https://github.com/apache/trafficcontrol/pull/7110#discussion_r1131409786 ## traffic_ops/traffic_ops_golang/login/login.go: ## @@ -108,135 +108,184 @@ Subject: {{.InstanceName}} Password Reset Request` + "\r\n\r" + ` `)) +//

[GitHub] [trafficcontrol] alficles commented on a diff in pull request #7392: Traffic Ops client certificate authentication

alficles commented on code in PR #7392: URL: https://github.com/apache/trafficcontrol/pull/7392#discussion_r1131438753 ## traffic_ops/traffic_ops_golang/auth/certificate.go: ## @@ -0,0 +1,167 @@ +package auth + +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [trafficcontrol] gbkannan89 commented on a diff in pull request #7358: Kannan victory 1 - statuses table, details

gbkannan89 commented on code in PR #7358: URL: https://github.com/apache/trafficcontrol/pull/7358#discussion_r1127544361 ## experimental/traffic-portal/src/app/core/statuses/status-details/status-details.component.ts: ## @@ -0,0 +1,132 @@ +/* + * Licensed under the Apache

[GitHub] [trafficcontrol] tinfoil-knight opened a new pull request, #7394: return correct error on duplicate email while updating user

tinfoil-knight opened a new pull request, #7394: URL: https://github.com/apache/trafficcontrol/pull/7394 Currently, a user updating their email to one that's already in use returns an `500 Internal Server Error`. This PR updates the implementation to ensure that a `400 Bad Request`

[GitHub] [trafficcontrol] tinfoil-knight commented on pull request #7394: return correct error on duplicate email while updating user

tinfoil-knight commented on PR #7394: URL: https://github.com/apache/trafficcontrol/pull/7394#issuecomment-1463520053 Wanted to confirm if a test needs to be added here. I was looking at the test files & I'm slightly confused as to how/where users are added in the mock database.

[GitHub] [trafficcontrol] tinfoil-knight commented on a diff in pull request #7394: return correct error on duplicate email while updating user

tinfoil-knight commented on code in PR #7394: URL: https://github.com/apache/trafficcontrol/pull/7394#discussion_r1132164137 ## traffic_ops/traffic_ops_golang/user/current.go: ## @@ -479,9 +479,9 @@ func ReplaceCurrent(w http.ResponseWriter, r *http.Request) { }

[GitHub] [trafficcontrol] tinfoil-knight commented on a diff in pull request #7394: return correct error on duplicate email while updating user

tinfoil-knight commented on code in PR #7394: URL: https://github.com/apache/trafficcontrol/pull/7394#discussion_r1132164700 ## traffic_ops/traffic_ops_golang/user/current.go: ## @@ -600,9 +600,9 @@ func ReplaceCurrentV4(w http.ResponseWriter, r *http.Request) { }

[GitHub] [trafficcontrol] tinfoil-knight commented on issue #7248: /roles PUT response missing lastUpdated

tinfoil-knight commented on issue #7248: URL: https://github.com/apache/trafficcontrol/issues/7248#issuecomment-1463755538 @ocket Was inspecting this issue in

[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7394: return correct error on duplicate email while updating user

codecov[bot] commented on PR #7394: URL: https://github.com/apache/trafficcontrol/pull/7394#issuecomment-1463779897 ##

[GitHub] [trafficcontrol] JammUtkarsh opened a new pull request, #7391: Refactor const in ./lib/

JammUtkarsh opened a new pull request, #7391: URL: https://github.com/apache/trafficcontrol/pull/7391 Closes: #2669 This PR groups similar `const` in `lib` directory. ## Which Traffic Control components are affected by this PR? - lib ## What is the

[GitHub] [trafficcontrol] JammUtkarsh commented on pull request #7391: Refactor const in ./lib/

JammUtkarsh commented on PR #7391: URL: https://github.com/apache/trafficcontrol/pull/7391#issuecomment-1461436305 After having a brief discussion in slack, I was supposed to make changes in `lib/` directory. I have made changes to just one sub-folder `/lib/atscfg`. Based on the commit,

[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7388: adding sslkey_expirations methods in clients

codecov[bot] commented on PR #7388: URL: https://github.com/apache/trafficcontrol/pull/7388#issuecomment-1460878843 #

[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7390: Add unit tests for deliveryservice folder in Traffic Ops

codecov[bot] commented on PR #7390: URL: https://github.com/apache/trafficcontrol/pull/7390#issuecomment-1460937463 #

[GitHub] [trafficcontrol] rimashah25 opened a new pull request, #7407: Added ASN details for TPV2

rimashah25 opened a new pull request, #7407: URL: https://github.com/apache/trafficcontrol/pull/7407 This PR adds ANS details for TPv2 ## Which Traffic Control components are affected by this PR? - Traffic Portalv2 ## What is the best way to verify this PR?

[GitHub] [trafficcontrol] gokulakrishnansvm commented on pull request #7400: Adding API Contract Test for cdns endpoint

gokulakrishnansvm commented on PR #7400: URL: https://github.com/apache/trafficcontrol/pull/7400#issuecomment-1473131520 > Don't forget to check the code against our linter configuration at `traffic_control/clients/python/pylint.rc` checked the code against pylint. -- This is an

[GitHub] [trafficcontrol] gokulakrishnansvm commented on a diff in pull request #7400: Adding API Contract Test for cdns endpoint

gokulakrishnansvm commented on code in PR #7400: URL: https://github.com/apache/trafficcontrol/pull/7400#discussion_r1139736323 ## traffic_ops/testing/api_contract/v4/conftest.py: ## @@ -0,0 +1,92 @@ +"""This module is used to create a Traffic Ops session +and to store

[GitHub] [trafficcontrol] tinfoil-knight commented on issue #6985: Internal Sever Error in TP when updating own role to higher role

tinfoil-knight commented on issue #6985: URL: https://github.com/apache/trafficcontrol/issues/6985#issuecomment-1475357376 @ocket The issue still exists. - I created a new role with `[ "USER:UPDATE", "USER:READ" ]` permissions using `POST /roles` - Created a new user with that

[GitHub] [trafficcontrol] jagan-parthiban commented on a diff in pull request #7408: Fixes service_category apis to respond with RFC3339 date/time Format

jagan-parthiban commented on code in PR #7408: URL: https://github.com/apache/trafficcontrol/pull/7408#discussion_r1140147483 ## lib/go-tc/service_category.go: ## Review Comment: ServiceCategoryV5 struct introduced with TimeRFC3339 format for "LastUpdated" Field.

[GitHub] [trafficcontrol] jagan-parthiban commented on a diff in pull request #7408: Fixes service_category apis to respond with RFC3339 date/time Format

jagan-parthiban commented on code in PR #7408: URL: https://github.com/apache/trafficcontrol/pull/7408#discussion_r1140154251 ## traffic_ops/traffic_ops_golang/routing/routes.go: ## Review Comment: TOServiceCategory Routes are changed to refer the updated V5 clients only

[GitHub] [trafficcontrol] jagan-parthiban commented on a diff in pull request #7408: Fixes service_category apis to respond with RFC3339 date/time Format

jagan-parthiban commented on code in PR #7408: URL: https://github.com/apache/trafficcontrol/pull/7408#discussion_r1140154967 ## traffic_ops/traffic_ops_golang/servicecategory/servicecategories.go: ## @@ -187,3 +187,136 @@ WHERE name=$2 RETURNING last_updated` func

[GitHub] [trafficcontrol] jagan-parthiban commented on a diff in pull request #7408: Fixes service_category apis to respond with RFC3339 date/time Format

jagan-parthiban commented on code in PR #7408: URL: https://github.com/apache/trafficcontrol/pull/7408#discussion_r1140155491 ## traffic_ops/traffic_ops_golang/servicecategory/servicecategories.go: ## @@ -187,3 +187,136 @@ WHERE name=$2 RETURNING last_updated` func

[GitHub] [trafficcontrol] jagan-parthiban commented on a diff in pull request #7408: Fixes service_category apis to respond with RFC3339 date/time Format

jagan-parthiban commented on code in PR #7408: URL: https://github.com/apache/trafficcontrol/pull/7408#discussion_r1140152217 ## traffic_ops/traffic_ops_golang/api/generic_crud.go: ## @@ -43,6 +43,15 @@ type GenericCreator interface { InsertQuery() string } +//

[GitHub] [trafficcontrol] jagan-parthiban commented on a diff in pull request #7408: Fixes service_category apis to respond with RFC3339 date/time Format

jagan-parthiban commented on code in PR #7408: URL: https://github.com/apache/trafficcontrol/pull/7408#discussion_r1140151340 ## traffic_ops/testing/api/v5/servicecategories_test.go: ## Review Comment: V5 service_category Test cases are updated to use the newly created

[GitHub] [trafficcontrol] jagan-parthiban opened a new pull request, #7408: Fixes service_category apis to respond with RFC3339 date/time Format

jagan-parthiban opened a new pull request, #7408: URL: https://github.com/apache/trafficcontrol/pull/7408 Issue: https://github.com/apache/trafficcontrol/issues/5911 ## Which Traffic Control components are affected by this PR? - Documentation - Traffic

[GitHub] [trafficcontrol] jagan-parthiban commented on a diff in pull request #7408: Fixes service_category apis to respond with RFC3339 date/time Format

jagan-parthiban commented on code in PR #7408: URL: https://github.com/apache/trafficcontrol/pull/7408#discussion_r1140150254 ## lib/go-tc/time.go: ## Review Comment: A new struct TimeRFC3339 is added which wraps time.Time, but interfaces MarshalJSON is coded to return

[GitHub] [trafficcontrol] jagan-parthiban commented on a diff in pull request #7408: Fixes service_category apis to respond with RFC3339 date/time Format

jagan-parthiban commented on code in PR #7408: URL: https://github.com/apache/trafficcontrol/pull/7408#discussion_r1140147483 ## lib/go-tc/service_category.go: ## Review Comment: ServiceCategoryV5 struct introduced with TimeRFC3339 format for "LastUpdated" Field --

[GitHub] [trafficcontrol] jagan-parthiban commented on a diff in pull request #7408: Fixes service_category apis to respond with RFC3339 date/time Format

jagan-parthiban commented on code in PR #7408: URL: https://github.com/apache/trafficcontrol/pull/7408#discussion_r1140153005 ## traffic_ops/traffic_ops_golang/api/generic_crud.go: ## @@ -153,6 +162,48 @@ func GenericCreateNameBasedID(val GenericCreator) (error, error, int) {

[GitHub] [trafficcontrol] jagan-parthiban commented on a diff in pull request #7408: Fixes service_category apis to respond with RFC3339 date/time Format

jagan-parthiban commented on code in PR #7408: URL: https://github.com/apache/trafficcontrol/pull/7408#discussion_r1140156213 ## traffic_ops/v5-client/serviceCategory.go: ## Review Comment: Clients are updated to refer tc.ServiceCategoryV5 -- This is an automated

[GitHub] [trafficcontrol] zrhoffman merged pull request #7409: Have `chromedriver-updater` action use correct HEAD

zrhoffman merged PR #7409: URL: https://github.com/apache/trafficcontrol/pull/7409 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] zrhoffman commented on pull request #6159: Error-wrapping in Grove

zrhoffman commented on PR #6159: URL: https://github.com/apache/trafficcontrol/pull/6159#issuecomment-1474121092 @ocket #6159 would be good to merge if it did not use format strings -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [trafficcontrol] zrhoffman commented on pull request #6160: Error-wrapping in lib

zrhoffman commented on PR #6160: URL: https://github.com/apache/trafficcontrol/pull/6160#issuecomment-1474121104 @ocket #6160 would be good to merge if it did not use format strings -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [trafficcontrol] shamrickus opened a new pull request, #7409: Have `chromedriver-updater` action use correct HEAD

shamrickus opened a new pull request, #7409: URL: https://github.com/apache/trafficcontrol/pull/7409 This PR isn't related to any issue and fixes an issue where the `chromedriver-updater` was failing to create the PR _only_ on the apache repo. ## Which Traffic Control

[GitHub] [trafficcontrol] asf-ci-trafficcontrol opened a new pull request, #7410: Update Chromedriver Versions

asf-ci-trafficcontrol opened a new pull request, #7410: URL: https://github.com/apache/trafficcontrol/pull/7410 This PR updates chromedriver in: traffic_portal/test/integration: 109.0.0 -> 111.0.0 ## Which Traffic Control components are affected by this PR? * Traffic

[GitHub] [trafficcontrol] shamrickus merged pull request #7410: Update Chromedriver Versions

shamrickus merged PR #7410: URL: https://github.com/apache/trafficcontrol/pull/7410 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] kdamichie commented on a diff in pull request #7364: Tpv2 coordinates

kdamichie commented on code in PR #7364: URL: https://github.com/apache/trafficcontrol/pull/7364#discussion_r1137393788 ## experimental/traffic-portal/src/app/core/cache-groups/cache-group-details/cache-group-details.component.html: ## @@ -56,11 +56,11 @@

[GitHub] [trafficcontrol] ocket8888 commented on issue #7128: API acme_autorenew: Renewal are not being kicked off

ocket commented on issue #7128: URL: https://github.com/apache/trafficcontrol/issues/7128#issuecomment-1470587261 I don't think so. That would only impact a single delivery service at a time, only if they use this method of obtaining a cert, and only if they decide to use

[GitHub] [trafficcontrol] TerekhovaKate commented on a diff in pull request #7400: Adding API Contract Test for cdns endpoint

TerekhovaKate commented on code in PR #7400: URL: https://github.com/apache/trafficcontrol/pull/7400#discussion_r1135745969 ## traffic_ops/testing/api_contract/v4/conftest.py: ## @@ -0,0 +1,92 @@ +"""This module is used to create a Traffic Ops session +and to store

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7287: Fix t3c test duplication and upgrade to v4 (fix conflicts)

zrhoffman commented on code in PR #7287: URL: https://github.com/apache/trafficcontrol/pull/7287#discussion_r1137300557 ## infrastructure/cdn-in-a-box/enroller/Dockerfile: ## @@ -38,6 +38,7 @@ ARG ENROLLER_DEBUG_BUILD=false COPY ./lib/

[GitHub] [trafficcontrol] ocket8888 closed issue #7248: /roles PUT response missing lastUpdated

ocket closed issue #7248: /roles PUT response missing lastUpdated URL: https://github.com/apache/trafficcontrol/issues/7248 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [trafficcontrol] ocket8888 merged pull request #7402: add missing lastUpdated prop to PUT /roles

ocket merged PR #7402: URL: https://github.com/apache/trafficcontrol/pull/7402 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] TerekhovaKate commented on a diff in pull request #7400: Adding API Contract Test for cdns endpoint

TerekhovaKate commented on code in PR #7400: URL: https://github.com/apache/trafficcontrol/pull/7400#discussion_r1136061460 ## traffic_ops/testing/api_contract/v4/conftest.py: ## @@ -0,0 +1,100 @@ +"""This module is used to create a Traffic Ops session +and to store

[GitHub] [trafficcontrol] tinfoil-knight commented on a diff in pull request #7402: add missing lastUpdated prop to PUT /roles

tinfoil-knight commented on code in PR #7402: URL: https://github.com/apache/trafficcontrol/pull/7402#discussion_r1135248072 ## traffic_ops/traffic_ops_golang/role/roles.go: ## @@ -394,24 +395,15 @@ func Update(w http.ResponseWriter, r *http.Request) {

[GitHub] [trafficcontrol] gokulakrishnansvm commented on a diff in pull request #7400: Adding API Contract Test for cdns endpoint

gokulakrishnansvm commented on code in PR #7400: URL: https://github.com/apache/trafficcontrol/pull/7400#discussion_r1135328111 ## traffic_ops/testing/api_contract/v4/conftest.py: ## @@ -0,0 +1,94 @@ +import pytest +from trafficops.tosession import TOSession +from urllib.parse

[GitHub] [trafficcontrol] gokulakrishnansvm commented on a diff in pull request #7400: Adding API Contract Test for cdns endpoint

gokulakrishnansvm commented on code in PR #7400: URL: https://github.com/apache/trafficcontrol/pull/7400#discussion_r1135327545 ## setup.py: ## @@ -0,0 +1,37 @@ +from setuptools import setup + +setup( +name='trafficcontrol', +version='1.0.0', +

[GitHub] [trafficcontrol] gokulakrishnansvm commented on a diff in pull request #7400: Adding API Contract Test for cdns endpoint

gokulakrishnansvm commented on code in PR #7400: URL: https://github.com/apache/trafficcontrol/pull/7400#discussion_r1135329344 ## traffic_ops/testing/api_contract/v4/conftest.py: ## @@ -0,0 +1,94 @@ +import pytest +from trafficops.tosession import TOSession +from urllib.parse

[GitHub] [trafficcontrol] gokulakrishnansvm commented on a diff in pull request #7400: Adding API Contract Test for cdns endpoint

gokulakrishnansvm commented on code in PR #7400: URL: https://github.com/apache/trafficcontrol/pull/7400#discussion_r1135326825 ## traffic_ops/testing/api_contract/v4/conftest.py: ## @@ -0,0 +1,94 @@ +import pytest +from trafficops.tosession import TOSession +from urllib.parse

[GitHub] [trafficcontrol] tinfoil-knight commented on a diff in pull request #7402: add missing lastUpdated prop to PUT /roles

tinfoil-knight commented on code in PR #7402: URL: https://github.com/apache/trafficcontrol/pull/7402#discussion_r1135248072 ## traffic_ops/traffic_ops_golang/role/roles.go: ## @@ -394,24 +395,15 @@ func Update(w http.ResponseWriter, r *http.Request) {

[GitHub] [trafficcontrol] tinfoil-knight commented on a diff in pull request #7402: add missing lastUpdated prop to PUT /roles

tinfoil-knight commented on code in PR #7402: URL: https://github.com/apache/trafficcontrol/pull/7402#discussion_r1135248072 ## traffic_ops/traffic_ops_golang/role/roles.go: ## @@ -394,24 +395,15 @@ func Update(w http.ResponseWriter, r *http.Request) {

[GitHub] [trafficcontrol] tinfoil-knight commented on a diff in pull request #7402: add missing lastUpdated prop to PUT /roles

tinfoil-knight commented on code in PR #7402: URL: https://github.com/apache/trafficcontrol/pull/7402#discussion_r1135248072 ## traffic_ops/traffic_ops_golang/role/roles.go: ## @@ -394,24 +395,15 @@ func Update(w http.ResponseWriter, r *http.Request) {

[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7402: add missing lastUpdated prop to PUT /roles

codecov[bot] commented on PR #7402: URL: https://github.com/apache/trafficcontrol/pull/7402#issuecomment-1467745848 ##

[GitHub] [trafficcontrol] gokulakrishnansvm commented on a diff in pull request #7400: Adding API Contract Test for cdns endpoint

gokulakrishnansvm commented on code in PR #7400: URL: https://github.com/apache/trafficcontrol/pull/7400#discussion_r1135330247 ## traffic_ops/testing/api_contract/v4/test_cdns.py: ## @@ -0,0 +1,49 @@ +import pytest +import json +import logging + + +""" +PyTest Fixture to store

[GitHub] [trafficcontrol] gokulakrishnansvm commented on a diff in pull request #7400: Adding API Contract Test for cdns endpoint

gokulakrishnansvm commented on code in PR #7400: URL: https://github.com/apache/trafficcontrol/pull/7400#discussion_r1135325276 ## traffic_ops/testing/api_contract/v4/conftest.py: ## @@ -0,0 +1,94 @@ +import pytest +from trafficops.tosession import TOSession +from urllib.parse

[GitHub] [trafficcontrol] gokulakrishnansvm commented on a diff in pull request #7400: Adding API Contract Test for cdns endpoint

gokulakrishnansvm commented on code in PR #7400: URL: https://github.com/apache/trafficcontrol/pull/7400#discussion_r1135324570 ## traffic_ops/testing/api_contract/v4/to_data.json: ## @@ -0,0 +1,8 @@ +{ +"test": { +"user": "admin", +"password": "twelve", +

[GitHub] [trafficcontrol] gokulakrishnansvm commented on a diff in pull request #7400: Adding API Contract Test for cdns endpoint

gokulakrishnansvm commented on code in PR #7400: URL: https://github.com/apache/trafficcontrol/pull/7400#discussion_r1135326284 ## traffic_ops/testing/api_contract/v4/conftest.py: ## @@ -0,0 +1,94 @@ +import pytest +from trafficops.tosession import TOSession +from urllib.parse

[GitHub] [trafficcontrol] JammUtkarsh commented on issue #7247: Roles creation/update responses incorrectly set `null` permissions when not provided.

JammUtkarsh commented on issue #7247: URL: https://github.com/apache/trafficcontrol/issues/7247#issuecomment-1467792418 Hey @ocket, I'm interested in contributing to the Issue and I'd like to learn more about it. I appreciate any information you can provide like and look forward to

[GitHub] [trafficcontrol] gokulakrishnansvm commented on a diff in pull request #7400: Adding API Contract Test for cdns endpoint

gokulakrishnansvm commented on code in PR #7400: URL: https://github.com/apache/trafficcontrol/pull/7400#discussion_r1135330247 ## traffic_ops/testing/api_contract/v4/test_cdns.py: ## @@ -0,0 +1,49 @@ +import pytest +import json +import logging + + +""" +PyTest Fixture to store

[GitHub] [trafficcontrol] Rohith-Raju commented on issue #4427: parameters POST request with no request body returns Internal Server Error

Rohith-Raju commented on issue #4427: URL: https://github.com/apache/trafficcontrol/issues/4427#issuecomment-1467447110 Hey @ocket @mitchell852, Is this issue still relavent? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [trafficcontrol] serDrem commented on a diff in pull request #7302: added anycast traffic routing ability, and lastpoll time for v6

serDrem commented on code in PR #7302: URL: https://github.com/apache/trafficcontrol/pull/7302#discussion_r1134706675 ## traffic_monitor/health/cache.go: ## @@ -46,6 +46,26 @@ const AvailableStr = "available" // available to serve traffic. const UnavailableStr = "unavailable"

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7396: Improve unit test coverage for servers folder in Traffic Ops

rimashah25 commented on code in PR #7396: URL: https://github.com/apache/trafficcontrol/pull/7396#discussion_r1134805909 ## traffic_ops/traffic_ops_golang/servercapability/servercapability_test.go: ## @@ -0,0 +1,145 @@ +package servercapability + +/* + * Licensed to the Apache

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7401: Crconfig test coverage

rimashah25 commented on code in PR #7401: URL: https://github.com/apache/trafficcontrol/pull/7401#discussion_r1134859452 ## traffic_ops/traffic_ops_golang/crconfig/snapshot_test.go: ## @@ -37,56 +38,161 @@ func ExpectedGetSnapshot(crc *tc.CRConfig) ([]byte, error) {

[GitHub] [trafficcontrol] serDrem commented on a diff in pull request #7302: added anycast traffic routing ability, and lastpoll time for v6

serDrem commented on code in PR #7302: URL: https://github.com/apache/trafficcontrol/pull/7302#discussion_r1134706675 ## traffic_monitor/health/cache.go: ## @@ -46,6 +46,26 @@ const AvailableStr = "available" // available to serve traffic. const UnavailableStr = "unavailable"

[GitHub] [trafficcontrol] jagan-parthiban closed pull request #7399: TimeConstant format changed to include minute hand(:00) for zone offset[Outside US].

jagan-parthiban closed pull request #7399: TimeConstant format changed to include minute hand(:00) for zone offset[Outside US]. URL: https://github.com/apache/trafficcontrol/pull/7399 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [trafficcontrol] tinfoil-knight opened a new pull request, #7402: add missing lastUpdated prop to PUT /roles

tinfoil-knight opened a new pull request, #7402: URL: https://github.com/apache/trafficcontrol/pull/7402 Closes: #7248 Note: V3 API wasn't updated because it's already deprecated & `GET`, `POST` endpoints for the V3 API don't return the `lastUpdated` property.

[GitHub] [trafficcontrol] Rohith-Raju commented on a diff in pull request #7393: [Docs] Change Role to Api Name

Rohith-Raju commented on code in PR #7393: URL: https://github.com/apache/trafficcontrol/pull/7393#discussion_r1134968268 ## docs/source/api/v4/users_register.rst: ## @@ -31,7 +31,7 @@ Register a user and send registration email. Request Structure - :email:

[GitHub] [trafficcontrol] Rohith-Raju commented on a diff in pull request #7393: [Docs] Change Role to Api Name

Rohith-Raju commented on code in PR #7393: URL: https://github.com/apache/trafficcontrol/pull/7393#discussion_r1134968268 ## docs/source/api/v4/users_register.rst: ## @@ -31,7 +31,7 @@ Register a user and send registration email. Request Structure - :email:

[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7405: Fix reserved consistentHashQueryParams entries causing internal server error instead of client error

codecov[bot] commented on PR #7405: URL: https://github.com/apache/trafficcontrol/pull/7405#issuecomment-1470675548 ##

[GitHub] [trafficcontrol] ocket8888 opened a new pull request, #7405: Fix reserved consistentHashQueryParams entries causing internal server error instead of client error

ocket opened a new pull request, #7405: URL: https://github.com/apache/trafficcontrol/pull/7405 This PR fixes #6385 by causing Traffic Ops to return the correct error code (400 Bad Request) and an alert describing what went wrong when a client attempts to create or modify a Delivery

[GitHub] [trafficcontrol] ocket8888 commented on issue #7404: Improvement: Port conflict of traffic_ops container with Kubernetes

ocket commented on issue #7404: URL: https://github.com/apache/trafficcontrol/issues/7404#issuecomment-1470601663 The container for the trafficops service uses the same port as the CDN-in-a-Box default configuration for its own Traffic Ops container. So it should only change if both

[GitHub] [trafficcontrol] mitchell852 commented on issue #7128: API acme_autorenew: Renewal are not being kicked off

mitchell852 commented on issue #7128: URL: https://github.com/apache/trafficcontrol/issues/7128#issuecomment-1470821756 > I don't think so. That would only impact a single delivery service at a time, only if they use this method of obtaining a cert, and only if they decide to use

[GitHub] [trafficcontrol] TerekhovaKate commented on a diff in pull request #7400: Adding API Contract Test for cdns endpoint

TerekhovaKate commented on code in PR #7400: URL: https://github.com/apache/trafficcontrol/pull/7400#discussion_r1135819230 ## traffic_ops/testing/api_contract/v4/conftest.py: ## @@ -0,0 +1,92 @@ +"""This module is used to create a Traffic Ops session +and to store

<    3   4   5   6   7   8   9   10   11   12   >