[GitHub] [trafficcontrol] ericholguin commented on a diff in pull request #7144: Use Generics in TO Integration Tests

[GitBox]

ericholguin commented on code in PR #7144:
URL: https://github.com/apache/trafficcontrol/pull/7144#discussion_r1000939988


##
traffic_ops/testing/api/v5/servers_hostname_update_status_test.go:
##
@@ -1,18 +1,17 @@
 package v5
 
 /*
+   Licensed under the Apache License, Version 2.0 (the "License");
+   you may not use this file except in compliance with the License.
+   You may obtain a copy of the License at
 
-   Licensed under the Apache License, Version 2.0 (the "License");
-   you may not use this file except in compliance with the License.
-   You may obtain a copy of the License at
+   http://www.apache.org/licenses/LICENSE-2.0
 
-   http://www.apache.org/licenses/LICENSE-2.0
-
-   Unless required by applicable law or agreed to in writing, software
-   distributed under the License is distributed on an "AS IS" BASIS,
-   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-   See the License for the specific language governing permissions and
-   limitations under the License.
+   Unless required by applicable law or agreed to in writing, software
+   distributed under the License is distributed on an "AS IS" BASIS,
+   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+   See the License for the specific language governing permissions and
+   limitations under the License.

Review Comment:
   Oops



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [trafficcontrol] ericholguin commented on a diff in pull request #7144: Use Generics in TO Integration Tests

[GitBox]

ericholguin commented on code in PR #7144:
URL: https://github.com/apache/trafficcontrol/pull/7144#discussion_r1000939559


##
traffic_ops/testing/api/v4/server_server_capabilities_test.go:
##
@@ -216,25 +189,26 @@ func TestServerServerCapabilities(t *testing.T) {
})
case "POST":
t.Run(name, func(t *testing.T) {
-   alerts, reqInf, err := 
testCase.ClientSession.CreateServerServerCapability(ssc, testCase.RequestOpts)
-   for _, check := range 
testCase.Expectations {
-   check(t, 
reqInf, nil, alerts, err)
-   }
-   })
-   case "PUT":

Review Comment:
   server_server_capabilities doesn't have a PUT method, just moved that test 
for that route into its own test file: multiple_server_capabilities_test.go



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org