mitchell852 commented on issue #3966: Add server capabilities API
URL: https://github.com/apache/trafficcontrol/pull/3966#issuecomment-541107445
> Unknown parameters should be ignored.
agree
This is an automated
mitchell852 commented on issue #3966: Add server capabilities API
URL: https://github.com/apache/trafficcontrol/pull/3966#issuecomment-541107333
> Trimming whitespace should be fine. It should be documented, but the extra
safety seems like a good thing to me.
agree
mitchell852 commented on issue #3966: Add server capabilities API
URL: https://github.com/apache/trafficcontrol/pull/3966#issuecomment-540607241
Just a thought. What about a GET response like:
```
{
"response": [
{
"name": "bar",
"lastUpdated":
mitchell852 commented on issue #3966: Add server capabilities API
URL: https://github.com/apache/trafficcontrol/pull/3966#issuecomment-540599816
Are there any restrictions on server capability name? I.e. no spaces,
alphanumeric only, etc...
mitchell852 commented on issue #3966: Add server capabilities API
URL: https://github.com/apache/trafficcontrol/pull/3966#issuecomment-540090948
> Should POST/DELETE only be admin? Right now I have it set to Operations.
probably a question for @rob05c
mitchell852 commented on issue #3966: Add server capabilities API
URL: https://github.com/apache/trafficcontrol/pull/3966#issuecomment-540061661
i don't suppose you happened to add entries to seeds.sql for creating a
"capability" (i'm talking about a user capability here) like the
mitchell852 commented on issue #3966: Add server capabilities API
URL: https://github.com/apache/trafficcontrol/pull/3966#issuecomment-540043806
without reading thru the code, does DELETE validate that the "server
capability" is:
a. not being used by any server and
b. is not
mitchell852 commented on issue #3966: Add server capabilities API
URL: https://github.com/apache/trafficcontrol/pull/3966#issuecomment-539697696
> Updated the description with routes and expected payloads.
GET /server_capabilities[?name=]
POST /server_capabilities
DELETE
mitchell852 commented on issue #3966: Add server capabilities API
URL: https://github.com/apache/trafficcontrol/pull/3966#issuecomment-539687719
Since there are no docs, can you add to your PR description what that routes
are and the expected request payloads for each?
