ocket8888 commented on a change in pull request #4397: Fixed /api/2.0/roles
always returning empty array
URL: https://github.com/apache/trafficcontrol/pull/4397#discussion_r379107649
##########
File path: traffic_ops/traffic_ops_golang/role/roles.go
##########
@@ -164,6 +164,11 @@ func (role *TORole) Read() ([]interface{}, error, error,
int) {
if userErr != nil || sysErr != nil {
return nil, userErr, sysErr, errCode
}
+
+ if version.Major > 1 {
+ return vals, nil, nil, http.StatusOK
Review comment:
It that case I'll just move this into the loop below.
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
