[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #3691: Some best-practices updates to the kickstart script

2019-09-04 Thread GitBox
rawlinp commented on a change in pull request #3691: Some best-practices updates to the kickstart script URL: https://github.com/apache/trafficcontrol/pull/3691#discussion_r320915439 ## File path: misc/kickstart_create_network_line.py ## @@ -231,43 +238,46 @@ def useable_i

[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #3691: Some best-practices updates to the kickstart script

2019-09-04 Thread GitBox
rawlinp commented on a change in pull request #3691: Some best-practices updates to the kickstart script URL: https://github.com/apache/trafficcontrol/pull/3691#discussion_r320914157 ## File path: misc/kickstart_create_network_line.py ## @@ -14,60 +14,56 @@ # -''' +'

[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #3691: Some best-practices updates to the kickstart script

2019-09-04 Thread GitBox
rawlinp commented on a change in pull request #3691: Some best-practices updates to the kickstart script URL: https://github.com/apache/trafficcontrol/pull/3691#discussion_r320898799 ## File path: misc/kickstart_create_network_line.py ## @@ -109,7 +105,8 @@ def find_usable

[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #3691: Some best-practices updates to the kickstart script

2019-09-04 Thread GitBox
rawlinp commented on a change in pull request #3691: Some best-practices updates to the kickstart script URL: https://github.com/apache/trafficcontrol/pull/3691#discussion_r320900810 ## File path: misc/kickstart_create_network_line.py ## @@ -231,43 +238,46 @@ def useable_i

[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #3691: Some best-practices updates to the kickstart script

2019-09-04 Thread GitBox
rawlinp commented on a change in pull request #3691: Some best-practices updates to the kickstart script URL: https://github.com/apache/trafficcontrol/pull/3691#discussion_r320900012 ## File path: misc/kickstart_create_network_line.py ## @@ -215,12 +222,12 @@ def useable_i

[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #3691: Some best-practices updates to the kickstart script

2019-09-04 Thread GitBox
rawlinp commented on a change in pull request #3691: Some best-practices updates to the kickstart script URL: https://github.com/apache/trafficcontrol/pull/3691#discussion_r320897993 ## File path: misc/kickstart_create_network_line.py ## @@ -14,60 +14,56 @@ # -''' +'