[GitHub] [trafficcontrol] rawlinp commented on issue #4011: Implement GET /api/1.1/roles handler

rawlinp commented on issue #4011: Implement GET /api/1.1/roles handler URL: https://github.com/apache/trafficcontrol/pull/4011#issuecomment-545647906 > Hm. I thought that was fixed a while back, though. A holistic solution was never merged AFAIK.

[GitHub] [trafficcontrol] rawlinp commented on issue #4011: Implement GET /api/1.1/roles handler

rawlinp commented on issue #4011: Implement GET /api/1.1/roles handler URL: https://github.com/apache/trafficcontrol/pull/4011#issuecomment-545597371 Also, it seems intentional that `PUT` doesn't actually update the priv_level, since that would go away with roles and capabilities. The

[GitHub] [trafficcontrol] rawlinp commented on issue #4011: Implement GET /api/1.1/roles handler

rawlinp commented on issue #4011: Implement GET /api/1.1/roles handler URL: https://github.com/apache/trafficcontrol/pull/4011#issuecomment-545595699 I didn't write the PUT/POST/1.3+GET handlers. IMO we shouldn't even be able to create/update `roles` today since they're built-in, but I

[GitHub] [trafficcontrol] rawlinp commented on issue #4011: Implement GET /api/1.1/roles handler

rawlinp commented on issue #4011: Implement GET /api/1.1/roles handler URL: https://github.com/apache/trafficcontrol/pull/4011#issuecomment-545185758 Fixed. Those are interesting unit test failures. I assumed anonymously embedding a new `RoleV11` struct into `Role` would be non-breaking,