[GitHub] mitchell852 commented on issue #2063: creating, updating and deleting types should be reserved for admin users

2018-03-27 Thread GitBox
mitchell852 commented on issue #2063: creating, updating and deleting types should be reserved for admin users URL: https://github.com/apache/incubator-trafficcontrol/issues/2063#issuecomment-376695698 what's even better is maybe adding a protected (true, false) column to the type table.

[GitHub] mitchell852 commented on issue #2063: creating, updating and deleting types should be reserved for admin users

2018-03-27 Thread GitBox
mitchell852 commented on issue #2063: creating, updating and deleting types should be reserved for admin users URL: https://github.com/apache/incubator-trafficcontrol/issues/2063#issuecomment-376695698 what's even better is maybe adding a protected (true, false) column to the type table.

[GitHub] mitchell852 opened a new issue #2063: creating, updating and deleting types should be reserved for admin users

2018-03-27 Thread GitBox
mitchell852 opened a new issue #2063: creating, updating and deleting types should be reserved for admin users URL: https://github.com/apache/incubator-trafficcontrol/issues/2063 The system is very sensitive to the types found in the type table. For example, there needs to be a type named

[GitHub] mitchell852 commented on issue #2062: TP: trailing slash in DS origin URL breaks MSO parent.config

2018-03-27 Thread GitBox
mitchell852 commented on issue #2062: TP: trailing slash in DS origin URL breaks MSO parent.config URL: https://github.com/apache/incubator-trafficcontrol/issues/2062#issuecomment-376680130 Enforcing this in TP is a nice to have but at the very least it needs to be enforced in the API. -

[GitHub] guzzijason opened a new issue #2062: TP: trailing slash in DS origin URL breaks MSO parent.config

2018-03-27 Thread GitBox
guzzijason opened a new issue #2062: TP: trailing slash in DS origin URL breaks MSO parent.config URL: https://github.com/apache/incubator-trafficcontrol/issues/2062 Had an issue today while trying to convert an existing DS to use MSO. The `parent` field in parent.config kept coming up bla

[GitHub] mitchell852 commented on issue #2030: Feature: UI elements to delete active invalidation rules & queue revalidations

2018-03-27 Thread GitBox
mitchell852 commented on issue #2030: Feature: UI elements to delete active invalidation rules & queue revalidations URL: https://github.com/apache/incubator-trafficcontrol/issues/2030#issuecomment-376657842 looks like #1867 takes care of the ability to delete invalidate content jobs...

[GitHub] mitchell852 commented on issue #2059: TO API - profiles route no longer supports "includeParams" query param

2018-03-27 Thread GitBox
mitchell852 commented on issue #2059: TO API - profiles route no longer supports "includeParams" query param URL: https://github.com/apache/incubator-trafficcontrol/issues/2059#issuecomment-376647271 IMO just include the params with the GET /api/1.3/profiles/:id so the ?includeParams quer

[GitHub] mitchell852 closed pull request #2048: Created swaggerdocs for the /divisions API

2018-03-27 Thread GitBox
mitchell852 closed pull request #2048: Created swaggerdocs for the /divisions API URL: https://github.com/apache/incubator-trafficcontrol/pull/2048 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] asfgit commented on issue #2048: Created swaggerdocs for the /divisions API

2018-03-27 Thread GitBox
asfgit commented on issue #2048: Created swaggerdocs for the /divisions API URL: https://github.com/apache/incubator-trafficcontrol/pull/2048#issuecomment-376642699 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-traf

[GitHub] dewrich commented on issue #2050: Created swaggerdocs for the /asns API

2018-03-27 Thread GitBox
dewrich commented on issue #2050: Created swaggerdocs for the /asns API URL: https://github.com/apache/incubator-trafficcontrol/pull/2050#issuecomment-376642349 Fixes https://github.com/apache/incubator-trafficcontrol/issues/1987

[GitHub] dewrich commented on issue #2048: Created swaggerdocs for the /divisions API

2018-03-27 Thread GitBox
dewrich commented on issue #2048: Created swaggerdocs for the /divisions API URL: https://github.com/apache/incubator-trafficcontrol/pull/2048#issuecomment-376642147 Fixes https://github.com/apache/incubator-trafficcontrol/issues/1986 ---

[GitHub] asfgit commented on issue #2050: Created swaggerdocs for the /asns API

2018-03-27 Thread GitBox
asfgit commented on issue #2050: Created swaggerdocs for the /asns API URL: https://github.com/apache/incubator-trafficcontrol/pull/2050#issuecomment-376641729 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficco

[GitHub] dewrich commented on issue #2031: Created the swaggerdocs dir to document the /cdns API

2018-03-27 Thread GitBox
dewrich commented on issue #2031: Created the swaggerdocs dir to document the /cdns API URL: https://github.com/apache/incubator-trafficcontrol/pull/2031#issuecomment-376639015 fixes #1984 This is an automated message from

[GitHub] dewrich closed issue #1984: Document /api/1.3/cdns using Swagger

2018-03-27 Thread GitBox
dewrich closed issue #1984: Document /api/1.3/cdns using Swagger URL: https://github.com/apache/incubator-trafficcontrol/issues/1984 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] mitchell852 closed pull request #2031: Created the swaggerdocs dir to document the /cdns API

2018-03-27 Thread GitBox
mitchell852 closed pull request #2031: Created the swaggerdocs dir to document the /cdns API URL: https://github.com/apache/incubator-trafficcontrol/pull/2031 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of pr

[GitHub] mitchell852 closed pull request #2061: updated the profiles route to be -wip until more time to complete

2018-03-27 Thread GitBox
mitchell852 closed pull request #2061: updated the profiles route to be -wip until more time to complete URL: https://github.com/apache/incubator-trafficcontrol/pull/2061 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for th

[GitHub] dewrich opened a new pull request #2061: updated the profiles route to be -wip until more time to complete

2018-03-27 Thread GitBox
dewrich opened a new pull request #2061: updated the profiles route to be -wip until more time to complete URL: https://github.com/apache/incubator-trafficcontrol/pull/2061 This is an automated message from the Apache Git Se

[GitHub] asfgit commented on issue #2060: [Issue 2057] - adds the ability to compare 2 delivery service requests

2018-03-27 Thread GitBox
asfgit commented on issue #2060: [Issue 2057] - adds the ability to compare 2 delivery service requests URL: https://github.com/apache/incubator-trafficcontrol/pull/2060#issuecomment-376627510 Refer to this link for build results (access rights to CI server needed): https://builds.

[GitHub] mitchell852 opened a new pull request #2060: [Issue 2057] - adds the ability to compare 2 delivery service requests

2018-03-27 Thread GitBox
mitchell852 opened a new pull request #2060: [Issue 2057] - adds the ability to compare 2 delivery service requests URL: https://github.com/apache/incubator-trafficcontrol/pull/2060 This is an automated message from the Apac

[GitHub] mitchell852 opened a new issue #2059: TO API - profiles route no longer supports "includeParams" query param

2018-03-27 Thread GitBox
mitchell852 opened a new issue #2059: TO API - profiles route no longer supports "includeParams" query param URL: https://github.com/apache/incubator-trafficcontrol/issues/2059 For example GET /api/1.2/profiles/417?includeParams=true (perl) includes the parameters associated with th

[GitHub] mitchell852 opened a new issue #2058: TO API should support multiple values in orderby

2018-03-27 Thread GitBox
mitchell852 opened a new issue #2058: TO API should support multiple values in orderby URL: https://github.com/apache/incubator-trafficcontrol/issues/2058 For example, this works GET /api/1.3/deliveryservice_requests?orderby=xmlId but this does not GET /api/1.3/delivery

[GitHub] dewrich closed pull request #2027: [Issue 1819/1820] - adds ds request comments to TP

2018-03-27 Thread GitBox
dewrich closed pull request #2027: [Issue 1819/1820] - adds ds request comments to TP URL: https://github.com/apache/incubator-trafficcontrol/pull/2027 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenanc

[GitHub] dewrich closed issue #1820: DS Request Notes UI

2018-03-27 Thread GitBox
dewrich closed issue #1820: DS Request Notes UI URL: https://github.com/apache/incubator-trafficcontrol/issues/1820 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and

[GitHub] dewrich closed issue #1819: DS Request Notes API: CRUD

2018-03-27 Thread GitBox
dewrich closed issue #1819: DS Request Notes API: CRUD URL: https://github.com/apache/incubator-trafficcontrol/issues/1819 This is an automated message from the Apache Git Service. To respond to the message, please log on Git

[GitHub] asfgit commented on issue #2027: [Issue 1819/1820] - adds ds request comments to TP

2018-03-27 Thread GitBox
asfgit commented on issue #2027: [Issue 1819/1820] - adds ds request comments to TP URL: https://github.com/apache/incubator-trafficcontrol/pull/2027#issuecomment-376559596 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incub

[GitHub] mitchell852 commented on issue #2055: deleting inactive delivery services requires double confirmation

2018-03-27 Thread GitBox
mitchell852 commented on issue #2055: deleting inactive delivery services requires double confirmation URL: https://github.com/apache/incubator-trafficcontrol/issues/2055#issuecomment-376557304 @saoyag001 - why are you deleting a ds and then deleting the ds request that you just created?

[GitHub] mitchell852 commented on issue #2055: deleting inactive delivery services requires double confirmation

2018-03-27 Thread GitBox
mitchell852 commented on issue #2055: deleting inactive delivery services requires double confirmation URL: https://github.com/apache/incubator-trafficcontrol/issues/2055#issuecomment-376557304 @saoyag001 - why are you deleting a ds and then deleting the ds request? if you are tryin

[GitHub] mitchell852 opened a new issue #2057: TP - provide the ability to compare 2 delivery service requests

2018-03-27 Thread GitBox
mitchell852 opened a new issue #2057: TP - provide the ability to compare 2 delivery service requests URL: https://github.com/apache/incubator-trafficcontrol/issues/2057 When a ds request is "open" it is easy to see what changes are being requested because you can compare the ds request wi