[GitHub] incubator-trafficcontrol issue #813: [TC-353] Can't use CNAME hostname with ...

2017-08-17 Thread smalenfant
Github user smalenfant commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/813 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-trafficcontrol issue #821: [BACKPORT] [TC-521] TPv2 - accounts for...

2017-08-17 Thread smalenfant
Github user smalenfant commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/821 @mitchell852 Please close. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-trafficcontrol pull request #830: [TC-514] ORT: Use CLI provided t...

2017-08-17 Thread smalenfant
GitHub user smalenfant opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/830 [TC-514] ORT: Use CLI provided traffic_ops_hosts - Script was fetching tm.url from GLOBAL profile. If the URL was different (multiple TO for example), it was failing on cookies

[GitHub] incubator-trafficcontrol pull request #797: [BACKPORT][TC-511] Remove refere...

2017-08-15 Thread smalenfant
Github user smalenfant closed the pull request at: https://github.com/apache/incubator-trafficcontrol/pull/797 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] incubator-trafficcontrol issue #813: [TC-353] Can't use CNAME hostname with ...

2017-08-15 Thread smalenfant
Github user smalenfant commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/813 @dg4prez I'll conduct more testing here but I'd like you to review. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] incubator-trafficcontrol pull request #813: [TC-353] Can't use CNAME hostnam...

2017-08-15 Thread smalenfant
GitHub user smalenfant opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/813 [TC-353] Can't use CNAME hostname with "ccr" prefix - Replaced regex from ccr to http_routing You can merge this pull request into a Git repository by running:

[GitHub] incubator-trafficcontrol pull request #804: CDU/CHR Checks: Formatting float...

2017-08-14 Thread smalenfant
GitHub user smalenfant opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/804 CDU/CHR Checks: Formatting float as integer - Convertion was auto-applied by MySQL, but not with Postgresql resulting in errors in logs You can merge this pull request into a

[GitHub] incubator-trafficcontrol pull request #318: [TC-90] Recovered changes for @e...

2017-08-14 Thread smalenfant
Github user smalenfant closed the pull request at: https://github.com/apache/incubator-trafficcontrol/pull/318 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] incubator-trafficcontrol issue #318: [TC-90] Recovered changes for @elsloo

2017-08-14 Thread smalenfant
Github user smalenfant commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/318 This is already merged from another PR. Closing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] incubator-trafficcontrol pull request #803: Update master version to 2.2

2017-08-14 Thread smalenfant
GitHub user smalenfant opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/803 Update master version to 2.2 You can merge this pull request into a Git repository by running: $ git pull https://github.com/smalenfant/incubator-trafficcontrol update

[GitHub] incubator-trafficcontrol pull request #797: [BACKPORT][TC-511] Remove refere...

2017-08-11 Thread smalenfant
GitHub user smalenfant opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/797 [BACKPORT][TC-511] Remove reference to public database You can merge this pull request into a Git repository by running: $ git pull https://github.com/smalenfant

[GitHub] incubator-trafficcontrol pull request #796: [TC-511] Remove reference to pub...

2017-08-11 Thread smalenfant
GitHub user smalenfant opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/796 [TC-511] Remove reference to public database You can merge this pull request into a Git repository by running: $ git pull https://github.com/smalenfant/incubator

[GitHub] incubator-trafficcontrol issue #616: Modified astats_over_http to report the...

2017-05-26 Thread smalenfant
Github user smalenfant commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/616 Centos 7.3 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] incubator-trafficcontrol issue #616: Modified astats_over_http to report the...

2017-05-26 Thread smalenfant
Github user smalenfant commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/616 @elsloo Tested on Centos 6 (single interface) and Centos 7 (single and bond). All looks good. :shipit: --- If your project is set up for it, you can reply to this email and

[GitHub] incubator-trafficcontrol issue #616: Modified astats_over_http to report the...

2017-05-25 Thread smalenfant
Github user smalenfant commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/616 That's what I was thinking about first time I looked at this. Not sure why we needed to iterate all the slaves. We can put this through the test, but it looks good

[GitHub] incubator-trafficcontrol pull request #319: [TC-172] Add CURLOPT_FOLLOWLOCAT...

2017-02-27 Thread smalenfant
GitHub user smalenfant opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/319 [TC-172] Add CURLOPT_FOLLOWLOCATION Note: Not setting a limit and it is unlimited by default You can merge this pull request into a Git repository by running: $ git pull

[GitHub] incubator-trafficcontrol pull request #318: [TC-90] Recovered changes for @e...

2017-02-27 Thread smalenfant
GitHub user smalenfant opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/318 [TC-90] Recovered changes for @elsloo You can merge this pull request into a Git repository by running: $ git pull https://github.com/smalenfant/incubator-trafficcontrol

[GitHub] incubator-trafficcontrol pull request #281: [TC-132] Fix proper RP for sync

2017-02-23 Thread smalenfant
GitHub user smalenfant reopened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/281 [TC-132] Fix proper RP for sync This is still very static, but does what is intended to do. - daily_stats: Put data in indefinite instead of DEFAULT

[GitHub] incubator-trafficcontrol pull request #281: [TC-132] Fix proper RP for sync

2017-02-23 Thread smalenfant
Github user smalenfant closed the pull request at: https://github.com/apache/incubator-trafficcontrol/pull/281 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] incubator-trafficcontrol pull request #281: [TC-132] Fix proper RP for sync

2017-02-15 Thread smalenfant
Github user smalenfant commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/281#discussion_r101363315 --- Diff: traffic_stats/influxdb_tools/sync/sync_ts_databases.go --- @@ -176,16 +177,24 @@ func syncDailyDb(ch chan string

[GitHub] incubator-trafficcontrol pull request #281: [TC-132] Fix proper RP for sync

2017-02-15 Thread smalenfant
Github user smalenfant commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/281#discussion_r101362585 --- Diff: traffic_stats/influxdb_tools/sync/sync_ts_databases.go --- @@ -298,8 +307,9 @@ func syncDailyStat(sourceClient influx.Client

[GitHub] incubator-trafficcontrol pull request #281: [TC-132] Fix proper RP for sync

2017-02-13 Thread smalenfant
GitHub user smalenfant opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/281 [TC-132] Fix proper RP for sync This is still very static, but does what is intended to do. - daily_stats: Put data in indefinite instead of DEFAULT

[GitHub] incubator-trafficcontrol pull request #279: [TC-145] Add defines to compile ...

2017-02-13 Thread smalenfant
GitHub user smalenfant opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/279 [TC-145] Add defines to compile against multiple version of TS You can merge this pull request into a Git repository by running: $ git pull https://github.com/smalenfant

[GitHub] incubator-trafficcontrol issue #256: [TC-136] Fixes a logic bug that prevent...

2017-02-10 Thread smalenfant
Github user smalenfant commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/256 There is a possibility that you might have some patches against your 5.3.x that might make this work. But it won't compile against 5.3.2 provided by Traffic Server. -

[GitHub] incubator-trafficcontrol issue #256: [TC-136] Fixes a logic bug that prevent...

2017-02-10 Thread smalenfant
Github user smalenfant commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/256 @elsloo Sorry I couldn't get to this before, but it still fails compiling on 5.3.2. Please look at the PR I've made against yours to prevents this. ```

[GitHub] incubator-trafficcontrol issue #256: [TC-136] Fixes a logic bug that prevent...

2017-02-09 Thread smalenfant
Github user smalenfant commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/256 @elsloo I haven't tried but I believe it will fail on... Have you taken a look at the PR I made against yours? ``` if (TSPluginRegister(&info) != T