[GitHub] incubator-trafficcontrol issue #371: [TC-184] Tenancy table creation

2017-03-17 Thread nir-sopher
Github user nir-sopher commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/371 I'll add the test, also as all other fields in the tenant module are tested upon update, so it is more consistent. --- If your project is set up for it, you can reply to this

[GitHub] incubator-trafficcontrol issue #371: [TC-184] Tenancy table creation

2017-03-17 Thread mitchell852
Github user mitchell852 commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/371 As far as the "active" flag being required on update, it's no big deal. either was is fine with me. i guess i was just thinking it might be confusing to a user that if I omit

[GitHub] incubator-trafficcontrol issue #371: [TC-184] Tenancy table creation

2017-03-17 Thread nir-sopher
Github user nir-sopher commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/371 Thanks Jeremy for your comments and help with documentation. Most AIs are in. Still need to further discuss "Active" input as required comment --- If your project is set

[GitHub] incubator-trafficcontrol issue #371: [TC-184] Tenancy table creation

2017-03-16 Thread mitchell852
Github user mitchell852 commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/371 I created a PR into your branch for the documentation - https://github.com/nir-sopher/incubator-trafficcontrol/pull/4 If it looks ok to you, just hit the merge button

[GitHub] incubator-trafficcontrol issue #371: [TC-184] Tenancy table creation

2017-03-16 Thread mitchell852
Github user mitchell852 commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/371 Also, you forgot one thingdocumentation. I'll help you get started on that...I'll send a PR your way. --- If your project is set up for it, you can reply to this email and