[GitHub] incubator-trafficcontrol issue #731: [TC-192] Differentiates between goTM an...

2017-08-14 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/731 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] incubator-trafficcontrol issue #731: [TC-192] Differentiates between goTM an...

2017-07-14 Thread elsloo
Github user elsloo commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/731 Perhaps we should leave the Java version in there, at least for the short term, but rename it to `traffic_monitor_legacy` (or `_java` or something that makes sense), and have *that*

[GitHub] incubator-trafficcontrol issue #731: [TC-192] Differentiates between goTM an...

2017-07-14 Thread rob05c
Github user rob05c commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/731 I think it's been long enough, we haven't seen any major issues with the Golang TM. What about renaming `/traffic_monitor_golang` to `/traffic_monitor`, deleting the old Java dir

[GitHub] incubator-trafficcontrol issue #731: [TC-192] Differentiates between goTM an...

2017-07-14 Thread elsloo
Github user elsloo commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/731 @rob05c what do you think about including `_go` in the golang Traffic Monitor RPM filename, presuming that the above still works? We could also do the inverse, and modify the Java

[GitHub] incubator-trafficcontrol issue #731: [TC-192] Differentiates between goTM an...

2017-07-14 Thread elsloo
Github user elsloo commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/731 Hey @rguiliani, thanks for the PR. When the two Traffic Monitor RPMs are built, we will end up with an RPM with `_go` in its name, which will be included in the version. Do you know