Github user zhilhuan commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/855
@rawlinp Thanks for your comments! Yes, that's need aother discussion,
because the certs may be pasted by operator instead of generated by ops.
---
If your project is set up for i
Github user rawlinp commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/855
Looks good to me. Thanks for fixing this!
Note that we'll have to figure out if we want to regenerate the actual
certs too (rather than just the hostname in the riak record)
Github user DylanVolz commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/855
@zhilhuan Yes that was a build server issue that should be resolved now.
This PR looks good; it reverts the breaking changes introduced by the
change from xmlId to id in t
Github user asfgit commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/855
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/124/
---
If your project is set up for
Github user zhilhuan commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/855
fatal: ambiguous argument 'TC-547': unknown revision or path not in the
working tree.
This is a issue in build server, not my code, right?
---
If your project is set up f
Github user asfgit commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/855
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/84/
---
If your projec
Github user zhilhuan commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/855
@rawlinp This PR reverted the regression issues introduced by TC-187. And
also resolved your comments in PR#360. Please help to review.
---
If your project is set up for it, you c
