rawlinp opened a new issue #2254: Traffic Router should properly handle null 
values in sslkeys.json
URL: https://github.com/apache/incubator-trafficcontrol/issues/2254
 
 
   If there is a `"deliveryservice": null` in the sslkeys.json retrieved from 
the TO API, TR will continually loop catching a `NullPointerException` and 
never actually complete the sslkeys.json validation process. See below:
   ```
   WARN  2018-05-10T20:12:07.674 [Thread-5] 
com.comcast.cdn.traffic_control.traffic_router.core.secure.CertificatesPublisher
 - Interrupted while waiting for new certificate data list,
    trying again...
   java.lang.NullPointerException
           at 
com.comcast.cdn.traffic_control.traffic_router.core.config.CertificateChecker.deliveryServiceHasValidCertificates(CertificateChecker.java:89)
           at 
com.comcast.cdn.traffic_control.traffic_router.core.config.CertificateChecker.certificatesAreValid(CertificateChecker.java:49)
           at 
com.comcast.cdn.traffic_control.traffic_router.core.secure.CertificatesPublisher.lambda$new$1(CertificatesPublisher.java:59)
           at java.lang.Thread.run(Thread.java:745)
   INFO  2018-05-10T20:12:08.265 [main] 
com.comcast.cdn.traffic_control.traffic_router.core.config.ConfigHandler - 
Waiting for https certificates to support new config 42b02722
   INFO  2018-05-10T20:12:09.265 [main] 
com.comcast.cdn.traffic_control.traffic_router.core.config.ConfigHandler - 
Waiting for https certificates to support new config 42b02722
   ```
   Unless the offending record is removed from riak, TR will continue looping 
in this manner. Instead, TR should handle the null value properly and move on.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to