[GitHub] dewrich commented on issue #2124: Add TO Go GET deliveryservices routes

dewrich commented on issue #2124: Add TO Go GET deliveryservices routes URL: https://github.com/apache/incubator-trafficcontrol/pull/2124#issuecomment-380814242 @rob05c We're trying to stay away from id's in the "fixture data" so in your API test you have to make multiple calls (by

[GitHub] dewrich commented on a change in pull request #2124: Add TO Go GET deliveryservices routes

dewrich commented on a change in pull request #2124: Add TO Go GET deliveryservices routes URL: https://github.com/apache/incubator-trafficcontrol/pull/2124#discussion_r181099681 ## File path: traffic_ops/traffic_ops_golang/deliveryservice/deliveryservicesv13.go ## @@

[GitHub] dewrich commented on a change in pull request #2124: Add TO Go GET deliveryservices routes

dewrich commented on a change in pull request #2124: Add TO Go GET deliveryservices routes URL: https://github.com/apache/incubator-trafficcontrol/pull/2124#discussion_r181099605 ## File path: traffic_ops/traffic_ops_golang/deliveryservice/deliveryservicesv13.go ## @@

[GitHub] rob05c commented on a change in pull request #2124: Add TO Go GET deliveryservices routes

rob05c commented on a change in pull request #2124: Add TO Go GET deliveryservices routes URL: https://github.com/apache/incubator-trafficcontrol/pull/2124#discussion_r181101662 ## File path: traffic_ops/traffic_ops_golang/deliveryservice/deliveryservicesv13.go ## @@

[GitHub] rob05c commented on a change in pull request #2124: Add TO Go GET deliveryservices routes

rob05c commented on a change in pull request #2124: Add TO Go GET deliveryservices routes URL: https://github.com/apache/incubator-trafficcontrol/pull/2124#discussion_r181101714 ## File path: traffic_ops/traffic_ops_golang/deliveryservice/deliveryservicesv13.go ## @@

Build failed in Jenkins: incubator-trafficcontrol-traffic_ops-test #537

See Changes: [dewrich] Fix broken link in MSO quick-how-to doc [mitchell852] added swaggerdocs for statuses [mitchell852] created swaggerdocs for /regions [mitchell852] updated to use

[GitHub] dewrich commented on issue #2124: Add TO Go GET deliveryservices routes

dewrich commented on issue #2124: Add TO Go GET deliveryservices routes URL: https://github.com/apache/incubator-trafficcontrol/pull/2124#issuecomment-380835316 @rob05c The `cdnName` in these two examples refer to the cdnName linkage in the tc-fixtures.json. The Test case will read the

[GitHub] dewrich closed pull request #2123: Fix broken link in MSO quick-how-to doc

dewrich closed pull request #2123: Fix broken link in MSO quick-how-to doc URL: https://github.com/apache/incubator-trafficcontrol/pull/2123 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] rob05c commented on issue #2124: Add TO Go GET deliveryservices routes

rob05c commented on issue #2124: Add TO Go GET deliveryservices routes URL: https://github.com/apache/incubator-trafficcontrol/pull/2124#issuecomment-380818865 @dewrich Is there an example of that in the code or docs somewhere? I was looking for one to go off of, but didn't see any

[GitHub] mitchell852 closed pull request #2105: created swaggerdocs for /regions

mitchell852 closed pull request #2105: created swaggerdocs for /regions URL: https://github.com/apache/incubator-trafficcontrol/pull/2105 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] mitchell852 closed pull request #2107: added swaggerdocs for /statuses

mitchell852 closed pull request #2107: added swaggerdocs for /statuses URL: https://github.com/apache/incubator-trafficcontrol/pull/2107 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] mitchell852 closed pull request #2122: Created Swagger documentation for /phys_locations

mitchell852 closed pull request #2122: Created Swagger documentation for /phys_locations URL: https://github.com/apache/incubator-trafficcontrol/pull/2122 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] mitchell852 closed pull request #2117: removed status comments and fixed the test cases

mitchell852 closed pull request #2117: removed status comments and fixed the test cases URL: https://github.com/apache/incubator-trafficcontrol/pull/2117 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] mitchell852 opened a new pull request #2129: TP - in global 5xx handler, if there are custom alerts, show them

mitchell852 opened a new pull request #2129: TP - in global 5xx handler, if there are custom alerts, show them URL: https://github.com/apache/incubator-trafficcontrol/pull/2129 This is an automated message from the Apache

[GitHub] asfgit commented on issue #2128: fixed nil panic on the ChangeLogMessage for the servers

asfgit commented on issue #2128: fixed nil panic on the ChangeLogMessage for the servers URL: https://github.com/apache/incubator-trafficcontrol/pull/2128#issuecomment-380890476 Refer to this link for build results (access rights to CI server needed):

[GitHub] mitchell852 opened a new issue #2127: Server form: filter profiles by selected cdn

mitchell852 opened a new issue #2127: Server form: filter profiles by selected cdn URL: https://github.com/apache/incubator-trafficcontrol/issues/2127 When creating or updating a server, you can't assign the server to cdn 1 and to profile A (which belongs to cdn 2). this will result in an

[GitHub] dewrich opened a new pull request #2128: fixed nil panic on the ChangeLogMessage for the servers

dewrich opened a new pull request #2128: fixed nil panic on the ChangeLogMessage for the servers URL: https://github.com/apache/incubator-trafficcontrol/pull/2128 Fixes #2126 This is an automated message from the Apache Git

Build failed in Jenkins: incubator-trafficcontrol-master-build #692

See -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on H23 (ubuntu xenial) in workspace

Build failed in Jenkins: incubator-trafficcontrol-master-build #694

See -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on H23 (ubuntu xenial) in workspace

[GitHub] mitchell852 closed issue #2126: Creating a new server thru the API results in internal server error

mitchell852 closed issue #2126: Creating a new server thru the API results in internal server error URL: https://github.com/apache/incubator-trafficcontrol/issues/2126 This is an automated message from the Apache Git

[GitHub] mitchell852 closed pull request #2128: fixed nil panic on the ChangeLogMessage for the servers

mitchell852 closed pull request #2128: fixed nil panic on the ChangeLogMessage for the servers URL: https://github.com/apache/incubator-trafficcontrol/pull/2128 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] dewrich commented on issue #2124: Add TO Go GET deliveryservices routes

dewrich commented on issue #2124: Add TO Go GET deliveryservices routes URL: https://github.com/apache/incubator-trafficcontrol/pull/2124#issuecomment-380868344 np, lemme know if you need help This is an automated message

Build failed in Jenkins: incubator-trafficcontrol-rat #645

See -- Started by upstream project "incubator-trafficcontrol-master-build" build number 690 originally caused by: Started by an SCM change Started by an SCM change

Jenkins build is back to normal : incubator-trafficcontrol-master-build #697

See

Build failed in Jenkins: incubator-trafficcontrol-traffic_ops-test #540

See Changes: [dewrich] in global 5xx handler, if there are custom alerts, show them -- Started by an SCM change Started by an SCM change Started

[GitHub] asfgit commented on issue #2128: fixed nil panic on the ChangeLogMessage for the servers

asfgit commented on issue #2128: fixed nil panic on the ChangeLogMessage for the servers URL: https://github.com/apache/incubator-trafficcontrol/pull/2128#issuecomment-380870480 Refer to this link for build results (access rights to CI server needed):

Build failed in Jenkins: incubator-trafficcontrol-PR #1403

See -- GitHub pull request #2128 of commit ccef48c6423d4d456ca20cb94857eace403c56d5, no merge conflicts. [EnvInject] - Loading node environment variables. Building remotely

Build failed in Jenkins: incubator-trafficcontrol-master-build #690

See Changes: [mitchell852] removed status comments and fixed the test cases [mitchell852] fixed nil panic on the ChangeLogMessage for the servers [mitchell852] added domainName to the the

Build failed in Jenkins: incubator-trafficcontrol-master-build #693

See -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on H23 (ubuntu xenial) in workspace

[GitHub] mitchell852 commented on a change in pull request #2088: TO Go: implement tenants CRUD

mitchell852 commented on a change in pull request #2088: TO Go: implement tenants CRUD URL: https://github.com/apache/incubator-trafficcontrol/pull/2088#discussion_r18115 ## File path: traffic_ops/traffic_ops_golang/routes.go ## @@ -205,6 +206,13 @@ func Routes(d

[GitHub] mitchell852 opened a new issue #2126: Creating a new server thru the API results in internal server error

mitchell852 opened a new issue #2126: Creating a new server thru the API results in internal server error URL: https://github.com/apache/incubator-trafficcontrol/issues/2126 POST /api/1.2/servers results in internal server error. more specifically: 2018/04/12 09:44:48 http: panic

Jenkins build is back to normal : incubator-trafficcontrol-rat #646

See

[GitHub] dewrich closed pull request #2129: TP - in global 5xx handler, if there are custom alerts, show them

dewrich closed pull request #2129: TP - in global 5xx handler, if there are custom alerts, show them URL: https://github.com/apache/incubator-trafficcontrol/pull/2129 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

Build failed in Jenkins: incubator-trafficcontrol-rat #650

See -- Started by upstream project "incubator-trafficcontrol-master-build" build number 695 originally caused by: Started by an SCM change [EnvInject] - Loading node

Build failed in Jenkins: incubator-trafficcontrol-PR-rat #697

See -- Started by upstream project "incubator-trafficcontrol-PR" build number 1403 originally caused by: GitHub pull request #2128 of commit

Build failed in Jenkins: incubator-trafficcontrol-master-build #691

See -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on H23 (ubuntu xenial) in workspace

Build failed in Jenkins: incubator-trafficcontrol-master-build #695

See -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on H23 (ubuntu xenial) in workspace

Build failed in Jenkins: incubator-trafficcontrol-master-build #696

See -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on H23 (ubuntu xenial) in workspace

[GitHub] rivasj opened a new pull request #2130: Traffic Ops - golang API servers CRUD tests

rivasj opened a new pull request #2130: Traffic Ops - golang API servers CRUD tests URL: https://github.com/apache/incubator-trafficcontrol/pull/2130 CRUD tests for servers golang endpoints This is an automated message from

Jenkins build is back to normal : incubator-trafficcontrol-PR #1406

See

[GitHub] asfgit commented on issue #2128: fixed nil panic on the ChangeLogMessage for the servers

asfgit commented on issue #2128: fixed nil panic on the ChangeLogMessage for the servers URL: https://github.com/apache/incubator-trafficcontrol/pull/2128#issuecomment-380931076 Refer to this link for build results (access rights to CI server needed):

[GitHub] asfgit commented on issue #2116: TO go: `go get` prior to running unit tests for the golang.org/x dependencies

asfgit commented on issue #2116: TO go: `go get` prior to running unit tests for the golang.org/x dependencies URL: https://github.com/apache/incubator-trafficcontrol/pull/2116#issuecomment-380956317 Refer to this link for build results (access rights to CI server needed):

[GitHub] dangogh commented on issue #2116: TO go: `go get` prior to running unit tests for the golang.org/x dependencies

dangogh commented on issue #2116: TO go: `go get` prior to running unit tests for the golang.org/x dependencies URL: https://github.com/apache/incubator-trafficcontrol/pull/2116#issuecomment-380930481 retest this please

[GitHub] asfgit commented on issue #2130: Traffic Ops - golang API servers CRUD tests

asfgit commented on issue #2130: Traffic Ops - golang API servers CRUD tests URL: https://github.com/apache/incubator-trafficcontrol/pull/2130#issuecomment-380957399 Can one of the admins verify this patch? This is an

[GitHub] asfgit commented on issue #2130: Traffic Ops - golang API servers CRUD tests

asfgit commented on issue #2130: Traffic Ops - golang API servers CRUD tests URL: https://github.com/apache/incubator-trafficcontrol/pull/2130#issuecomment-380957614 Can one of the admins verify this patch? This is an

Jenkins build is back to normal : incubator-trafficcontrol-PR-rat #698

See

[GitHub] asfgit commented on issue #2131: Fix org_server_fqdn trailing slash issue

asfgit commented on issue #2131: Fix org_server_fqdn trailing slash issue URL: https://github.com/apache/incubator-trafficcontrol/pull/2131#issuecomment-380986771 Refer to this link for build results (access rights to CI server needed):

[GitHub] asfgit commented on issue #2124: Add TO Go GET, POST deliveryservices routes

asfgit commented on issue #2124: Add TO Go GET, POST deliveryservices routes URL: https://github.com/apache/incubator-trafficcontrol/pull/2124#issuecomment-380978018 Refer to this link for build results (access rights to CI server needed):

[GitHub] rob05c commented on issue #2124: Add TO Go GET deliveryservices routes

rob05c commented on issue #2124: Add TO Go GET deliveryservices routes URL: https://github.com/apache/incubator-trafficcontrol/pull/2124#issuecomment-380836830 @dewrich Ah, great, that's what I was looking for. I'll try to make deliveryservice tests based on that, and add them to this PR.

Build failed in Jenkins: incubator-trafficcontrol-PR #1401

See -- GitHub pull request #2124 of commit 780839c997cbbb522c70f67ea0db881c008e4702, no merge conflicts. Setting status of 780839c997cbbb522c70f67ea0db881c008e4702 to

[GitHub] asfgit commented on issue #2124: Add TO Go GET deliveryservices routes

asfgit commented on issue #2124: Add TO Go GET deliveryservices routes URL: https://github.com/apache/incubator-trafficcontrol/pull/2124#issuecomment-380837795 Refer to this link for build results (access rights to CI server needed):

[GitHub] mitchell852 opened a new issue #2125: Create configurable labels/tooltips for each property of a server

mitchell852 opened a new issue #2125: Create configurable labels/tooltips for each property of a server URL: https://github.com/apache/incubator-trafficcontrol/issues/2125 Like the delivery service form, each field on the server form should have configurable labels and tooltips.

Build failed in Jenkins: incubator-trafficcontrol-PR-rat #696

See -- Started by upstream project "incubator-trafficcontrol-PR" build number 1401 originally caused by: GitHub pull request #2124 of commit

Build failed in Jenkins: incubator-trafficcontrol-PR #1402

See -- GitHub pull request #2124 of commit 0caca6b4ff02dda6fd8120602d8015b35f36a3ee, no merge conflicts. Setting status of 0caca6b4ff02dda6fd8120602d8015b35f36a3ee to

[GitHub] asfgit commented on issue #2124: Add TO Go GET deliveryservices routes

asfgit commented on issue #2124: Add TO Go GET deliveryservices routes URL: https://github.com/apache/incubator-trafficcontrol/pull/2124#issuecomment-380844558 Refer to this link for build results (access rights to CI server needed):

Build failed in Jenkins: incubator-trafficcontrol-rat #644

See -- Started by upstream project "incubator-trafficcontrol-master-build" build number 689 originally caused by: Started by an SCM change Started by an SCM change

[GitHub] rawlinp opened a new pull request #2131: Fix org_server_fqdn trailing slash issue

rawlinp opened a new pull request #2131: Fix org_server_fqdn trailing slash issue URL: https://github.com/apache/incubator-trafficcontrol/pull/2131 Make the API validation match the form validation of the old TO UI. Make TP validation match the API validation. Fix issue with existing