GitHub user dangogh opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/168
merge postgres branch
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dangogh/incubator-trafficcontrol
merge-postgres
Github user sbogacz commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/167
I did look at the licenses beforehand, but I'll admit I don't know the most
about the technicalities of Open Source licenses. I'll go back and get the
tests to use the stdlib, as
Github user PSUdaemon commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/167#discussion_r95100817
--- Diff: traffic_stats/influxdb_tools/sync/sync_test.go ---
@@ -0,0 +1,230 @@
+/*
+Licensed to the Apache Software Foundation
Github user PSUdaemon commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/167#discussion_r95100599
--- Diff: traffic_stats/influxdb_tools/create/create_ts_databases.go ---
@@ -20,45 +20,81 @@ under the License.
package main
Github user sbogacz commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/167#discussion_r95100626
--- Diff: traffic_stats/influxdb_tools/sync/sync_test.go ---
@@ -0,0 +1,230 @@
+/*
+Licensed to the Apache Software Foundation
Github user sbogacz commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/167#discussion_r95100395
--- Diff: traffic_stats/influxdb_tools/create/create_ts_databases.go ---
@@ -20,45 +20,81 @@ under the License.
package main
Github user PSUdaemon commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/167#discussion_r95099075
--- Diff: traffic_stats/influxdb_tools/create/create_ts_databases.go ---
@@ -20,45 +20,81 @@ under the License.
package main
Github user PSUdaemon commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/167#discussion_r95098650
--- Diff: traffic_stats/influxdb_tools/create/create_ts_databases.go ---
@@ -20,45 +20,81 @@ under the License.
package main
Github user PSUdaemon commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/167#discussion_r95098546
--- Diff: traffic_stats/influxdb_tools/sync/sync_test.go ---
@@ -0,0 +1,230 @@
+/*
+Licensed to the Apache Software Foundation
Github user sbogacz commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/167
Hey @PSUdaemon, thanks for the review. I'm more than happy to make changes
to the PR to conform to project standards. I think the question of dependencies
is a good one, both in
Github user sbogacz commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/167#discussion_r95096773
--- Diff: traffic_stats/influxdb_tools/sync/sync_test.go ---
@@ -0,0 +1,230 @@
+/*
+Licensed to the Apache Software Foundation
Github user sbogacz commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/167#discussion_r95096692
--- Diff: traffic_stats/influxdb_tools/create/create_ts_databases.go ---
@@ -20,45 +20,81 @@ under the License.
package main
Github user sbogacz commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/167#discussion_r95096542
--- Diff: traffic_stats/influxdb_tools/create/create_ts_databases.go ---
@@ -20,45 +20,81 @@ under the License.
package main
13 matches
Mail list logo
