[GitHub] MattMills opened a new issue #2030: Feature: UI elements to delete active invalidation rules & queue revalidations

2018-03-21 Thread GitBox
MattMills opened a new issue #2030: Feature: UI elements to delete active 
invalidation rules & queue revalidations
URL: https://github.com/apache/incubator-trafficcontrol/issues/2030
 
 
   There is currently no mechanism to delete active invalidation rules or to 
queue revalidations across a CDN. These UI elements should be added so that 
when a disruptive invalidation rule is added.
   
   This has additional priority as there is an existing bug in ATS that 
re-applies every open invalidation any time a new one is added.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


Build failed in Jenkins: incubator-trafficcontrol-PR-rat #567

2018-03-21 Thread Apache Jenkins Server
See 


--
Started by upstream project "incubator-trafficcontrol-PR" build number 1263
originally caused by:
 GitHub pull request #2010 of commit 3a15d6c239e38831825221ce80b96aeb25aea339, 
no merge conflicts.
[EnvInject] - Loading node environment variables.
Building remotely on H22 (ubuntu xenial) in workspace 

[incubator-trafficcontrol-PR-rat] $ /bin/bash -xe 
/tmp/jenkins880435788554122473.sh
+ rm -rf 

 

 '
[operations-center-context] Requesting copy of artifacts matching '**/*.tar.gz' 
from 'Last successful build (either stable or unstable)' of 
incubator-trafficcontrol-PR
[operations-center-context] Copied 1 artifacts matching '**/*.tar.gz' from 
'Last successful build (either stable or unstable)' of 
incubator-trafficcontrol-PR:
[operations-center-context]   apache-trafficcontrol-2.3.0-incubating.tar.gz
[incubator-trafficcontrol-PR-rat] $ /bin/bash -xe 
/tmp/jenkins4688318155406480432.sh
+ set -exu
++ ls apache-trafficcontrol-2.3.0-incubating.tar.gz
+ tarball=apache-trafficcontrol-2.3.0-incubating.tar.gz
+ tar xzf apache-trafficcontrol-2.3.0-incubating.tar.gz
++ pwd
++ basename apache-trafficcontrol-2.3.0-incubating.tar.gz .tar.gz
+ 
tcdir=
+ cd 

++ date +%Y
+ egrep 'Copyright .*-?2018 The Apache Software Foundation' NOTICE
Copyright 2016-2018 The Apache Software Foundation
+ set +x
Searching for class files:
PASSED: No class files found.
Searching for jar files:
PASSED: No jar files found.
Searching for tar files:
PASSED: No tar files found.
Searching for tgz files:
PASSED: No tgz files found.
Searching for zip files:
PASSED: No zip files found.
++ curl 
https://repository.apache.org/content/repositories/snapshots/org/apache/rat/apache-rat/0.13-SNAPSHOT/
 -sN
++ grep jar
++ grep -ve md5 -e sha1
++ awk -F '"' '{print $2}'
++ cut -d / -f 12
++ sort -r
++ head -n 1
+ ratver=apache-rat-0.13-20180208.222412-98.jar
++ mktemp -d
+ ratdir=/tmp/tmp.NIhW05DCwf
+ ratjar=/tmp/tmp.NIhW05DCwf/apache-rat-0.13.SNAPSHOT.jar
+ curl -L -o /tmp/tmp.NIhW05DCwf/apache-rat-0.13.SNAPSHOT.jar 
https://repository.apache.org/content/repositories/snapshots/org/apache/rat/apache-rat/0.13-SNAPSHOT/apache-rat-0.13-20180208.222412-98.jar
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0  
0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0100 
1587k  100 1587k0 0  1612k  0 --:--:-- --:--:-- --:--:-- 1611k
+ curl -L -o /tmp/tmp.NIhW05DCwf/apache-rat-0.13.SNAPSHOT.jar.sha1 
https://repository.apache.org/content/repositories/snapshots/org/apache/rat/apache-rat/0.13-SNAPSHOT/apache-rat-0.13-20180208.222412-98.jar.sha1
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0  
0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0100 
   40  100400 0 72  0 --:--:-- --:--:-- --:--:--72
++ sha1sum /tmp/tmp.NIhW05DCwf/apache-rat-0.13.SNAPSHOT.jar
++ awk '{print $1}'
++ cat /tmp/tmp.NIhW05DCwf/apache-rat-0.13.SNAPSHOT.jar.sha1
+ [[ f6c4aadd6500b18299a0abd30430f6dddff7d6d8 == 
f6c4aadd6500b18299a0abd30430f6dddff7d6d8 ]]
++ pwd
++ pwd
+ java -jar /tmp/tmp.NIhW05DCwf/apache-rat-0.13.SNAPSHOT.jar -E 

 -d 

+ rm -rf /tmp/tmp.NIhW05DCwf
++ perl -lne 'print $1 if /(\d+) Unknown Licenses/' ratreport.txt
+ unknown=29
+ [[ 29 != 0 ]]
+ echo '29 Unknown Licenses'
29 Unknown Licenses
+ perl -lne 'print if /Files with unapproved licenses:/ .. /^\*\*\*/' 
ratreport.txt
+ sed s:::
Files with unapproved licenses:

  
apache-trafficcontrol-2.3.0-incubating/traffic_ops/traffic_ops_golang/auth/ldap.go
  
apache-trafficcontrol-2.3.0-incubating/traffic_ops/traffic_ops_golang/auth/login.go
  

[GitHub] asfgit commented on issue #2010: Go login

2018-03-21 Thread GitBox
asfgit commented on issue #2010: Go login
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2010#issuecomment-375122818
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/incubator-trafficcontrol-PR/1263/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] dangogh commented on issue #2029: Implements https://github.com/apache/incubator-trafficcontrol/issues/…

2018-03-21 Thread GitBox
dangogh commented on issue #2029: Implements 
https://github.com/apache/incubator-trafficcontrol/issues/…
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2029#issuecomment-375102654
 
 
   @Vijay-1 can you change the title of this PR so it's more descriptive of the 
actual change?  A link in the title doesn't work well..   Something like this 
is good:
   `[Issue 1907] TO API for backup edge cachegroup`
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] dangogh commented on issue #2029: Implements https://github.com/apache/incubator-trafficcontrol/issues/…

2018-03-21 Thread GitBox
dangogh commented on issue #2029: Implements 
https://github.com/apache/incubator-trafficcontrol/issues/…
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2029#issuecomment-375102654
 
 
   @Vijay-1 can you change the title of this PR so it's more descriptive of the 
actual change?  A link in the title doesn't work well..   Something like this 
is good:
   `[Issue 1907] TO API for backup edge cache group`
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] asfgit commented on issue #2029: Implements https://github.com/apache/incubator-trafficcontrol/issues/…

2018-03-21 Thread GitBox
asfgit commented on issue #2029: Implements 
https://github.com/apache/incubator-trafficcontrol/issues/…
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2029#issuecomment-375086443
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] asfgit commented on issue #2029: Implements https://github.com/apache/incubator-trafficcontrol/issues/…

2018-03-21 Thread GitBox
asfgit commented on issue #2029: Implements 
https://github.com/apache/incubator-trafficcontrol/issues/…
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2029#issuecomment-375085653
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] Vijay-1 commented on issue #1908: Changes for Backup Edge Cache Group

2018-03-21 Thread GitBox
Vijay-1 commented on issue #1908: Changes for Backup Edge Cache Group
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/1908#issuecomment-375085412
 
 
   New PR: https://github.com/apache/incubator-trafficcontrol/pull/2029
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] Vijay-1 opened a new pull request #2029: Implements https://github.com/apache/incubator-trafficcontrol/issues/…

2018-03-21 Thread GitBox
Vijay-1 opened a new pull request #2029: Implements 
https://github.com/apache/incubator-trafficcontrol/issues/…
URL: https://github.com/apache/incubator-trafficcontrol/pull/2029
 
 
   Implements https://github.com/apache/incubator-trafficcontrol/issues/1907
   
   Contains the following changes:
   Traffic Router - Backup edge configuration parsing and decision making code 
changes
   Traffic Ops - Mojolicious Perl CRUD APIs
   
   This is the initial version of code. Only minimal testing has been done. 
Will run more cases and update. Hosting it in advance to get review comments :-)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] asfgit commented on issue #2027: [Issue 1819/1820] - adds ds request comments to TP

2018-03-21 Thread GitBox
asfgit commented on issue #2027: [Issue 1819/1820] - adds ds request comments 
to TP
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2027#issuecomment-375037521
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/incubator-trafficcontrol-PR/1262/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] dangogh closed pull request #2020: moved cdns struct into v13 package

2018-03-21 Thread GitBox
dangogh closed pull request #2020: moved cdns struct into v13 package
URL: https://github.com/apache/incubator-trafficcontrol/pull/2020
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/lib/go-tc/cdns.go b/lib/go-tc/v13/cdns.go
similarity index 66%
rename from lib/go-tc/cdns.go
rename to lib/go-tc/v13/cdns.go
index 5402e2c19..e0c1aa8b8 100644
--- a/lib/go-tc/cdns.go
+++ b/lib/go-tc/v13/cdns.go
@@ -1,4 +1,4 @@
-package tc
+package v13
 
 /*
  * Licensed to the Apache Software Foundation (ASF) under one
@@ -18,25 +18,26 @@ package tc
  * specific language governing permissions and limitations
  * under the License.
  */
+import "github.com/apache/incubator-trafficcontrol/lib/go-tc"
 
 type CDNsResponse struct {
Response []CDN `json:"response"`
 }
 
 type CDN struct {
-   DNSSECEnabled bool  `json:"dnssecEnabled" db:"dnssec_enabled"`
-   DomainNamestring`json:"domainName" db:"domain_name"`
-   IDint   `json:"id" db:"id"`
-   LastUpdated   TimeNoMod `json:"lastUpdated" db:"last_updated"`
-   Name  string`json:"name" db:"name"`
+   DNSSECEnabled bool `json:"dnssecEnabled" db:"dnssec_enabled"`
+   DomainNamestring   `json:"domainName" db:"domain_name"`
+   IDint  `json:"id" db:"id"`
+   LastUpdated   tc.TimeNoMod `json:"lastUpdated" db:"last_updated"`
+   Name  string   `json:"name" db:"name"`
 }
 
 type CDNNullable struct {
-   DNSSECEnabled *bool  `json:"dnssecEnabled" db:"dnssec_enabled"`
-   DomainName*string`json:"domainName" db:"domain_name"`
-   ID*int   `json:"id" db:"id"`
-   LastUpdated   *TimeNoMod `json:"lastUpdated" db:"last_updated"`
-   Name  *string`json:"name" db:"name"`
+   DNSSECEnabled *bool `json:"dnssecEnabled" db:"dnssec_enabled"`
+   DomainName*string   `json:"domainName" db:"domain_name"`
+   ID*int  `json:"id" db:"id"`
+   LastUpdated   *tc.TimeNoMod `json:"lastUpdated" db:"last_updated"`
+   Name  *string   `json:"name" db:"name"`
 }
 
 // CDNSSLKeysResponse ...
diff --git a/traffic_ops/client/cdn.go b/traffic_ops/client/cdn.go
index d9e20e785..8ed0ee416 100644
--- a/traffic_ops/client/cdn.go
+++ b/traffic_ops/client/cdn.go
@@ -22,6 +22,7 @@ import (
"net/http"
 
"github.com/apache/incubator-trafficcontrol/lib/go-tc"
+   "github.com/apache/incubator-trafficcontrol/lib/go-tc/v13"
 )
 
 const (
@@ -29,7 +30,7 @@ const (
 )
 
 // Create a CDN
-func (to *Session) CreateCDN(cdn tc.CDN) (tc.Alerts, ReqInf, error) {
+func (to *Session) CreateCDN(cdn v13.CDN) (tc.Alerts, ReqInf, error) {
 
var remoteAddr net.Addr
reqBody, err := json.Marshal(cdn)
@@ -48,7 +49,7 @@ func (to *Session) CreateCDN(cdn tc.CDN) (tc.Alerts, ReqInf, 
error) {
 }
 
 // Update a CDN by ID
-func (to *Session) UpdateCDNByID(id int, cdn tc.CDN) (tc.Alerts, ReqInf, 
error) {
+func (to *Session) UpdateCDNByID(id int, cdn v13.CDN) (tc.Alerts, ReqInf, 
error) {
 
var remoteAddr net.Addr
reqBody, err := json.Marshal(cdn)
@@ -68,7 +69,7 @@ func (to *Session) UpdateCDNByID(id int, cdn tc.CDN) 
(tc.Alerts, ReqInf, error)
 }
 
 // Returns a list of CDNs
-func (to *Session) GetCDNs() ([]tc.CDN, ReqInf, error) {
+func (to *Session) GetCDNs() ([]v13.CDN, ReqInf, error) {
resp, remoteAddr, err := to.request(http.MethodGet, API_v12_CDNs, nil)
reqInf := ReqInf{CacheHitStatus: CacheHitStatusMiss, RemoteAddr: 
remoteAddr}
if err != nil {
@@ -76,13 +77,13 @@ func (to *Session) GetCDNs() ([]tc.CDN, ReqInf, error) {
}
defer resp.Body.Close()
 
-   var data tc.CDNsResponse
+   var data v13.CDNsResponse
err = json.NewDecoder(resp.Body).Decode()
return data.Response, reqInf, nil
 }
 
 // GET a CDN by the CDN id
-func (to *Session) GetCDNByID(id int) ([]tc.CDN, ReqInf, error) {
+func (to *Session) GetCDNByID(id int) ([]v13.CDN, ReqInf, error) {
route := fmt.Sprintf("%s/%d", API_v12_CDNs, id)
resp, remoteAddr, err := to.request(http.MethodGet, route, nil)
reqInf := ReqInf{CacheHitStatus: CacheHitStatusMiss, RemoteAddr: 
remoteAddr}
@@ -91,7 +92,7 @@ func (to *Session) GetCDNByID(id int) ([]tc.CDN, ReqInf, 
error) {
}
defer resp.Body.Close()
 
-   var data tc.CDNsResponse
+   var data v13.CDNsResponse
if err := json.NewDecoder(resp.Body).Decode(); err != nil {
return nil, reqInf, err
}
@@ -100,7 +101,7 @@ func (to *Session) GetCDNByID(id int) ([]tc.CDN, ReqInf, 
error) {
 }
 
 // GET a CDN by the CDN name
-func (to *Session) GetCDNByName(name string) ([]tc.CDN, 

[GitHub] Vijay-1 closed pull request #1908: Changes for Backup Edge Cache Group

2018-03-21 Thread GitBox
Vijay-1 closed pull request #1908: Changes for Backup Edge Cache Group
URL: https://github.com/apache/incubator-trafficcontrol/pull/1908
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 5f77b2990..cd65a168c 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -31,8 +31,10 @@ The format is based on [Keep a 
Changelog](http://keepachangelog.com/en/1.0.0/).
   - /api/1.3/statuses (R)
   - /api/1.3/system/info
   - /api/1.3/types (R)
+- Backup Edge Cache group: Backup Edge group for a particular cache group can 
be configured using coverage zone files. With this, users will be able control 
traffic within portions of their network, thereby avoiding choosing fallback 
cache groups using geo coordinates(getClosestAvailableCachegroup). This can be 
controlled using "backupZones" which contains configuration for backup cache 
groups parsed from the Coverage Zone File as explained 
[here](http://traffic-control-cdn.readthedocs.io/en/latest/admin/traffic_ops/using.html#the-coverage-zone-file-and-asn-table)
 
 ### Changed
 - Reformatted this CHANGELOG file to the keep-a-changelog format
 
-[Unreleased]: 
https://github.com/apache/incubator-trafficcontrol/compare/RELEASE-2.1.0...HEAD
+[Unreleased]: 
https://github.com/apache/incubator-trafficcontrol/compare/RELEASE-2.1.0...HEAD 
+
diff --git a/docs/source/admin/traffic_ops/using.rst 
b/docs/source/admin/traffic_ops/using.rst
index b5849753e..18c5de75d 100644
--- a/docs/source/admin/traffic_ops/using.rst
+++ b/docs/source/admin/traffic_ops/using.rst
@@ -873,6 +873,24 @@ The Coverage Zone File (CZF) should contain a cachegroup 
name to network prefix
   "192.168.4.0/24",
   "192.168.5.0/24"
 ]
+  },
+  "cache-group-03": {
+"backupZones":{
+  "list": ["cache-group-02"],
+  "fallbackToClosestGroup": true
+},
+"coordinates": {
+  "latitude":  3.3,
+  "longitude": 4.4
+},
+"network6": [
+  "1234:566a::/64",
+  "1234:566b::/64"
+],
+"network": [
+  "192.168.2.0/24",
+  "192.168.3.0/24"
+]
   }
 }
   }
@@ -881,7 +899,7 @@ The CZF is an input to the Traffic Control CDN, and as such 
does not get generat
 
 The script that generates the CZF file is not part of Traffic Control, since 
it is different for each situation.
 
-.. note:: The ``"coordinates"`` section is optional and may be used by Traffic 
Router for localization in the case of a CZF "hit" where the zone name does not 
map to a Cache Group name in Traffic Ops (i.e. Traffic Router will route to the 
closest Cache Group(s) geographically).
+.. note:: The ``"coordinates"`` section is optional and may be used by Traffic 
Router for localization in the case of a CZF "hit" where the zone name does not 
map to a Cache Group name in Traffic Ops (i.e. Traffic Router will route to the 
closest Cache Group(s) geographically). The ``"backupZones"`` section is 
optional and is used by Traffic Router for localization in the case of a CZF 
"hit" when there are no caches available for that DS in the matched cache 
group.  This backup "list" contains an ordered list of backup cache groups to 
choose from if the matched cache group has no caches available for a requested 
DS. If an available cache cannot be found in any of the backup groups either, 
the "fallbackToClosestGroup" flag determines the Traffic Router's following 
behavior. If true, Traffic Router will find the next closest cache group with 
available caches. If false (the default), Traffic Router will bypass the 
request (if configured) or reject it.
 
 .. _rl-deep-czf:
 
diff --git a/docs/source/admin/traffic_router.rst 
b/docs/source/admin/traffic_router.rst
index c1f33c8a4..8b9de6619 100644
--- a/docs/source/admin/traffic_router.rst
+++ b/docs/source/admin/traffic_router.rst
@@ -246,6 +246,8 @@ Fields Always Present
 
+--++
 |GEO_NO_CACHE_FOUND|Traffic Router could not find a resource via 
geolocation data based on the requesting client's geolocation   
   |
 
+--++
+|DS_CZ_BACKUP_CG   |Traffic Router found a cache from backup cache 
groups configured via backupZones / coordinates in Coverage zone data   
 |

[GitHub] Vijay-1 commented on issue #1908: Changes for Backup Edge Cache Group

2018-03-21 Thread GitBox
Vijay-1 commented on issue #1908: Changes for Backup Edge Cache Group
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/1908#issuecomment-374915222
 
 
   This PR will be closed and a new one based on the review comments will be 
created.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services