[GitHub] asfgit commented on issue #2010: Go login

[GitBox]

asfgit commented on issue #2010: Go login
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2010#issuecomment-379915876
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/incubator-trafficcontrol-PR/1369/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] guzzijason opened a new issue #2101: Traffic Portal feature request: the ability to identify if a DS is used as a steering target

[GitBox]

guzzijason opened a new issue #2101: Traffic Portal feature request: the 
ability to identify if a DS is used as a steering target
URL: https://github.com/apache/incubator-trafficcontrol/issues/2101
 
 
   As a Traffic Portal user, the ability to identify (in the Delivery Service 
table list and/or in the DS config screen) whether or not this service is a 
steering target, and if so, also identify the steering config(s) that reference 
it. Currently, we can only trace the relationship in the opposite direction.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #2100: upgrade Go from 1.8.3 to 1.10.1 for traffic_ops

[GitBox]

asfgit commented on issue #2100: upgrade Go from 1.8.3 to 1.10.1 for traffic_ops
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2100#issuecomment-379891988
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/incubator-trafficcontrol-PR/1368/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dangogh opened a new pull request #2100: upgrade Go from 1.8.3 to 1.10.1 for traffic_ops

[GitBox]

dangogh opened a new pull request #2100: upgrade Go from 1.8.3 to 1.10.1 for 
traffic_ops
URL: https://github.com/apache/incubator-trafficcontrol/pull/2100
 
 
   This will require some testing of a full TO installation before being 
merged,   but I think it's time we start exploring upgrading go..


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rob05c commented on issue #2098: Add TO deleted columns

[GitBox]

rob05c commented on issue #2098: Add TO deleted columns
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2098#issuecomment-379871646
 
 
   @limited We have some designs, specifically around the Snapshot-Queue 
automation problem, which is what this is "prepping" for. But they're pretty 
complex. 
   
   In a nutshell, the plan is to use timestamp history to solve the 
Snapshot-Queue problem. So, for this PR, `deleted` columns become necessary to 
preserve previous state (for caches or routers that haven't got the latest 
yet), while still indicating an object (server/ds/etc) now no longer exists.
   
   There's a talk scheduled at the TC Summit in a few weeks, we were hoping to 
have the talk where people can ask questions and have concerns addressed more 
efficiently, and then post it to the mailing list, to hopefully reduce the 
back-and-forth and misunderstandings from discussing something so complex via 
email.
   
   This "prep" stuff I was hoping to get started in the next couple weeks will 
all be backwards-compatible. The entire thing is, it doesn't change the 
existing API (though it does eventually add a few new endpoints).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dangogh commented on a change in pull request #2010: Go login

[GitBox]

dangogh commented on a change in pull request #2010: Go login
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2010#discussion_r180205545
 
 

 ##
 File path: traffic_ops/traffic_ops_golang/auth/login.go
 ##
 @@ -0,0 +1,130 @@
+package auth
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import (
+   "crypto/sha1"
+   "encoding/hex"
+   "encoding/json"
+   "errors"
+   "fmt"
+   "net/http"
+   "time"
+
+   "github.com/apache/incubator-trafficcontrol/lib/go-log"
+   "github.com/apache/incubator-trafficcontrol/lib/go-tc"
+   
"github.com/apache/incubator-trafficcontrol/traffic_ops/traffic_ops_golang/config"
+   
"github.com/apache/incubator-trafficcontrol/traffic_ops/traffic_ops_golang/tocookie"
+
+   "github.com/jmoiron/sqlx"
+)
+
+type passwordForm struct {
+   Username string `json:"u"`
+   Password string `json:"p"`
+}
+
+func LoginHandler(db *sqlx.DB, cfg config.Config) http.HandlerFunc {
+   return func(w http.ResponseWriter, r *http.Request) {
+   handleErrs := tc.GetHandleErrorsFunc(w, r)
+   defer r.Body.Close()
+   form := passwordForm{}
+   if err := json.NewDecoder(r.Body).Decode(); err != nil {
+   handleErrs(http.StatusBadRequest, err)
+   return
+   }
+   authenticated, err := checkLocalUser(form, db)
 
 Review comment:
   this needs to check that the local user exists first without checking the 
password.   If it doesn't exist or user's role is `disallowed`,   immediately 
error out without checking LDAP. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ezelkow1 opened a new issue #2099: TP changelog data enhancement

[GitBox]

ezelkow1 opened a new issue #2099: TP changelog data enhancement
URL: https://github.com/apache/incubator-trafficcontrol/issues/2099
 
 
   It would be useful if the changelogs reported the actual server name instead 
of the id, since there is not a 1 to 1 mapping thats easy to find within TP 
itself.
   
   Also being able to see specific up/down states and more information than 
APICHANGE would be very useful in diagnosing problematic servers


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] limited commented on issue #2098: Add TO deleted columns

[GitBox]

limited commented on issue #2098: Add TO deleted columns
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2098#issuecomment-379849389
 
 
   Hey @rob05c -
 Do you have any more details on the design behind the self service work 
going on here? Would be good to get the big picture before even the smaller 
"prep" changes start going in


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] limited commented on issue #2098: Add TO deleted columns

[GitBox]

limited commented on issue #2098: Add TO deleted columns
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2098#issuecomment-379849389
 
 
   Hey Rob-
 Do you have any more details on the design behind the self service work 
going on here? Would be good to get the big picture before even the smaller 
"prep" changes start going in


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #2098: Add TO deleted columns

[GitBox]

asfgit commented on issue #2098: Add TO deleted columns
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2098#issuecomment-379839683
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/incubator-trafficcontrol-PR/1367/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rob05c opened a new pull request #2098: Add TO deleted columns

[GitBox]

rob05c opened a new pull request #2098: Add TO deleted columns
URL: https://github.com/apache/incubator-trafficcontrol/pull/2098
 
 
   Adds 'deleted' columns to all CRConfig-used tables.
   These are not currently used, but will be for Self-Service.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rob05c commented on issue #2098: Add TO deleted columns

[GitBox]

rob05c commented on issue #2098: Add TO deleted columns
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2098#issuecomment-379837295
 
 
   Tested both up and down SQL commands on a TO database, works.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #2097: Add TO last_updated indexes

[GitBox]

asfgit commented on issue #2097: Add TO last_updated indexes
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2097#issuecomment-379831316
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/incubator-trafficcontrol-PR/1366/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: incubator-trafficcontrol-traffic_ops-test #530

[Apache Jenkins Server]

See 


Changes:

[dangogh] Add cachegroup generic crud to traffic_ops_golang

--
Started by an SCM change
[EnvInject] - Loading node environment variables.
Building remotely on ubuntu-eu3 (ubuntu xenial) in workspace 

 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url 
 > git://github.com/apache/incubator-trafficcontrol.git # timeout=10
Fetching upstream changes from 
git://github.com/apache/incubator-trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress 
 > git://github.com/apache/incubator-trafficcontrol.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/master^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/origin/master^{commit} # timeout=10
Checking out Revision 22005e5cafce569a1267cedc671a0f9bde6bf220 
(refs/remotes/origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 22005e5cafce569a1267cedc671a0f9bde6bf220
Commit message: "Add cachegroup generic crud to traffic_ops_golang"
 > git rev-list --no-walk 01e417cf77eac526a8cd6d6293ed7603d3b93f51 # timeout=10
[incubator-trafficcontrol-traffic_ops-test] $ /bin/bash 
/tmp/jenkins5435719966477977065.sh
docker-compose version 1.20.1, build 5d8c71b
docker-py version: 3.2.1
CPython version: 2.7.12
OpenSSL version: OpenSSL 1.0.2g  1 Mar 2016
+ trap finish EXIT
+ proj=jenkins-incubator-trafficcontrol-traffic_ops-test-530
++ pwd
+ 
compose=
+ cfile=traffic_ops/app/bin/tests/docker-compose.yml
+ [[ -z 

 ]]
+ [[ ! -x 

 ]]
+ 

 -p jenkins-incubator-trafficcontrol-traffic_ops-test-530 -f 
traffic_ops/app/bin/tests/docker-compose.yml up --build --exit-code-from 
unit_golang unit_golang
using --exit-code-from implies --abort-on-container-exit
Creating network "jenkinsincubatortrafficcontroltrafficopstest530_default" with 
the default driver
Creating volume "jenkinsincubatortrafficcontroltrafficopstest530_traffic_ops" 
with default driver
Creating volume 
"jenkinsincubatortrafficcontroltrafficopstest530_traffic_ops_golang" with 
default driver
Building unit_golang
Step 1/7 : FROM golang:1.8
 ---> ba52c9ef0f5c
Step 2/7 : MAINTAINER Dan Kirkwood 
 ---> Using cache
 ---> 6191b6f8cf39
Step 3/7 : ARG DIR=github.com/apache/incubator-trafficcontrol
 ---> Using cache
 ---> bcc290aed1ad
Step 4/7 : ADD traffic_ops /go/src/$DIR/traffic_ops
 ---> 509cd4759c9f
Removing intermediate container 17c169896458
Step 5/7 : ADD lib /go/src/$DIR/lib
 ---> c2476b55dfa4
Removing intermediate container b06a1c40df94
Step 6/7 : WORKDIR /go/src/$DIR/traffic_ops/traffic_ops_golang
 ---> d67a265e0449
Removing intermediate container 1e7572cd4fe1
Step 7/7 : CMD bash -c 'go test -v $(go list ./... | grep -v /vendor/)'
 ---> Running in cc0fcb57a3a1
 ---> 8f1e4346dd3f
Removing intermediate container cc0fcb57a3a1
Successfully built 8f1e4346dd3f
Successfully tagged 
jenkinsincubatortrafficcontroltrafficopstest530_unit_golang:latest
Creating jenkinsincubatortrafficcontroltrafficopstest530_unit_golang_1 ... 
Creating jenkinsincubatortrafficcontroltrafficopstest530_unit_golang_1
Creating jenkinsincubatortrafficcontroltrafficopstest530_unit_golang_1 ... 
doneAttaching to jenkinsincubatortrafficcontroltrafficopstest530_unit_golang_1
unit_golang_1  | auth/authenticate.go:31:2: cannot find package 
"golang.org/x/crypto/scrypt" in any of:
unit_golang_1  |
/go/src/github.com/apache/incubator-trafficcontrol/traffic_ops/traffic_ops_golang/vendor/golang.org/x/crypto/scrypt
 (vendor tree)
unit_golang_1  |/usr/local/go/src/golang.org/x/crypto/scrypt (from 
$GOROOT)
unit_golang_1  |/go/src/golang.org/x/crypto/scrypt (from $GOPATH)
jenkinsincubatortrafficcontroltrafficopstest530_unit_golang_1 exited with code 1
Aborting on container exit...
+ exit 1
+ finish
+ local st=1
+ [[ 1 -ne 0 ]]
+ echo 'Exiting with status 1'
Exiting with status 1
+ 

 -p jenkins-incubator-trafficcontrol-traffic_ops-test-530 -f 
traffic_ops/app/bin/tests/docker-compose.yml down -v
Removing jenkinsincubatortrafficcontroltrafficopstest530_unit_golang_1 ... 
Removing jenkinsincubatortrafficcontroltrafficopstest530_unit_golang_1 ... 
doneRemoving network jenkinsincubatortrafficcontroltrafficopstest530_default

[GitHub] rob05c commented on issue #2097: Add TO last_updated indexes

[GitBox]

rob05c commented on issue #2097: Add TO last_updated indexes
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2097#issuecomment-379828522
 
 
   Tested with a TO database, up and down queries execute successfully


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dangogh commented on issue #1229: Cache Group APIs: CRUD

[GitBox]

dangogh commented on issue #1229: Cache Group APIs: CRUD
URL: 
https://github.com/apache/incubator-trafficcontrol/issues/1229#issuecomment-379828193
 
 
   duplicate of #2079 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dangogh closed issue #2079: TO API - golang proxy should implement cachegroup CRUD.

[GitBox]

dangogh closed issue #2079: TO API - golang proxy should implement cachegroup 
CRUD.
URL: https://github.com/apache/incubator-trafficcontrol/issues/2079
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rob05c opened a new pull request #2097: Add TO last_updated indexes

[GitBox]

rob05c opened a new pull request #2097: Add TO last_updated indexes
URL: https://github.com/apache/incubator-trafficcontrol/pull/2097
 
 
   These will become necessary with Self Service, which will select
   frequently on the timestamps.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rivasj opened a new issue #2096: TR creates two files in /opt/traffic_router/var/auto-zones for each DS when CDN domain contains capitals

[GitBox]

rivasj opened a new issue #2096: TR creates two files in 
/opt/traffic_router/var/auto-zones for each DS when CDN domain contains capitals
URL: https://github.com/apache/incubator-trafficcontrol/issues/2096
 
 
   Given the example DS name linear-01 and CDN domain qaCDN.mydomain.com, the 
files linear-01.qaCDN.mydomain.com and linear-01.qacdn.mydomain.com are created 
in /opt/traffic_router/var/auto-zones containing different records, causing DNS 
resolution errors.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: incubator-trafficcontrol-traffic_ops-test #529

[Apache Jenkins Server]

See 


Changes:

[mtorluemke] if .cer file order changed, force update

--
Started by an SCM change
[EnvInject] - Loading node environment variables.
Building remotely on H32 (ubuntu xenial) in workspace 

 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url 
 > git://github.com/apache/incubator-trafficcontrol.git # timeout=10
Fetching upstream changes from 
git://github.com/apache/incubator-trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress 
 > git://github.com/apache/incubator-trafficcontrol.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/master^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/origin/master^{commit} # timeout=10
Checking out Revision 01e417cf77eac526a8cd6d6293ed7603d3b93f51 
(refs/remotes/origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 01e417cf77eac526a8cd6d6293ed7603d3b93f51
Commit message: "if .cer file order changed, force update"
 > git rev-list --no-walk eab39fb78113c580d2c3597409059c66ba39f806 # timeout=10
[incubator-trafficcontrol-traffic_ops-test] $ /bin/bash 
/tmp/jenkins6522438730129038049.sh
docker-compose version 1.20.1, build 5d8c71b
docker-py version: 3.2.1
CPython version: 2.7.12
OpenSSL version: OpenSSL 1.0.2g  1 Mar 2016
+ trap finish EXIT
+ proj=jenkins-incubator-trafficcontrol-traffic_ops-test-529
++ pwd
+ 
compose=
+ cfile=traffic_ops/app/bin/tests/docker-compose.yml
+ [[ -z 

 ]]
+ [[ ! -x 

 ]]
+ 

 -p jenkins-incubator-trafficcontrol-traffic_ops-test-529 -f 
traffic_ops/app/bin/tests/docker-compose.yml up --build --exit-code-from 
unit_golang unit_golang
using --exit-code-from implies --abort-on-container-exit
Creating network "jenkinsincubatortrafficcontroltrafficopstest529_default" with 
the default driver
Creating volume "jenkinsincubatortrafficcontroltrafficopstest529_traffic_ops" 
with default driver
Creating volume 
"jenkinsincubatortrafficcontroltrafficopstest529_traffic_ops_golang" with 
default driver
Building unit_golang
Step 1/7 : FROM golang:1.8
1.8: Pulling from library/golang
Digest: sha256:f0b5dab7581eddb49dabd1d1b9aa505ca3edcdf79a66395b5bfa4f3c036b49ef
Status: Downloaded newer image for golang:1.8
 ---> 0d283eb41a92
Step 2/7 : MAINTAINER Dan Kirkwood 
 ---> Using cache
 ---> d561ed8b7d4d
Step 3/7 : ARG DIR=github.com/apache/incubator-trafficcontrol
 ---> Using cache
 ---> 329888bba377
Step 4/7 : ADD traffic_ops /go/src/$DIR/traffic_ops
 ---> 58fbe83a6e22
Removing intermediate container a1bbe1a9f300
Step 5/7 : ADD lib /go/src/$DIR/lib
 ---> cdad1ba06ec1
Removing intermediate container 1cb459c7faef
Step 6/7 : WORKDIR /go/src/$DIR/traffic_ops/traffic_ops_golang
 ---> 6af7758b430c
Removing intermediate container 465a441b178c
Step 7/7 : CMD bash -c 'go test -v $(go list ./... | grep -v /vendor/)'
 ---> Running in c517452a7fe7
 ---> a82c912d09b6
Removing intermediate container c517452a7fe7
Successfully built a82c912d09b6
Successfully tagged 
jenkinsincubatortrafficcontroltrafficopstest529_unit_golang:latest
Creating jenkinsincubatortrafficcontroltrafficopstest529_unit_golang_1 ... 
Creating jenkinsincubatortrafficcontroltrafficopstest529_unit_golang_1
Creating jenkinsincubatortrafficcontroltrafficopstest529_unit_golang_1 ... 
doneAttaching to jenkinsincubatortrafficcontroltrafficopstest529_unit_golang_1
unit_golang_1  | auth/authenticate.go:31:2: cannot find package 
"golang.org/x/crypto/scrypt" in any of:
unit_golang_1  |
/go/src/github.com/apache/incubator-trafficcontrol/traffic_ops/traffic_ops_golang/vendor/golang.org/x/crypto/scrypt
 (vendor tree)
unit_golang_1  |/usr/local/go/src/golang.org/x/crypto/scrypt (from 
$GOROOT)
unit_golang_1  |/go/src/golang.org/x/crypto/scrypt (from $GOPATH)
jenkinsincubatortrafficcontroltrafficopstest529_unit_golang_1 exited with code 1
Aborting on container exit...
+ exit 1
+ finish
+ local st=1
+ [[ 1 -ne 0 ]]
+ echo 'Exiting with status 1'
Exiting with status 1
+ 

 -p jenkins-incubator-trafficcontrol-traffic_ops-test-529 -f 
traffic_ops/app/bin/tests/docker-compose.yml down -v
Removing jenkinsincubatortrafficcontroltrafficopstest529_unit_golang_1 ... 
Removing 

[GitH b] mtorl emke closed p ll req est #2095: ORT pdates .cer files if generated file wo ld be different, incl ding order

[GitBox]

mtorluemke closed pull request #2095: ORT updates .cer files if generated file 
would be different, including order
URL: https://github.com/apache/incubator-trafficcontrol/pull/2095
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/traffic_ops/bin/traffic_ops_ort.pl 
b/traffic_ops/bin/traffic_ops_ort.pl
index 32d25baa4..32a8e99cb 100755
--- a/traffic_ops/bin/traffic_ops_ort.pl
+++ b/traffic_ops/bin/traffic_ops_ort.pl
@@ -385,19 +385,29 @@ sub process_cfg_file {
@disk_file_lines = @{ _file_get_contents($file) };
}
 
-   my @return = _file_lines( $cfg_file, \@db_file_lines, 
\@disk_file_lines );
-   my @db_lines_missing   = @{ shift(@return) };
-   my @disk_lines_missing = @{ shift(@return) };
+   # First, check if the file to be generated would be identical including 
order
+   my $change_needed = ( join( '\0', @disk_file_lines ) ne join( '\0', 
@db_file_lines ) );
 
-   if ( ($cfg_file eq "logs_xml.config" && !(@disk_file_lines ~~ 
@db_file_lines))
-   || scalar(@disk_lines_missing) || scalar(@db_lines_missing) ) {
-   $cfg_file_tracker->{$cfg_file}->{'change_needed'}++;
+   # if different, look deeper to see if we care about the diffs (e.g. 
different order)
+   if ( $change_needed && !( $cfg_file eq 'logs_xml.config' || $cfg_file 
=~ /\.cer$/ ) ) {
+   my @return = _file_lines( $cfg_file, 
\@db_file_lines, \@disk_file_lines );
+   my @db_lines_missing   = @{ shift(@return) };
+   my @disk_lines_missing = @{ shift(@return) };
+
+   if ( scalar(@disk_lines_missing) == 0 && 
scalar(@db_lines_missing) == 0 ) {
+   # all lines accounted for
+   $change_needed = undef;
+   }
+   }
+
+   if ($change_needed) {
+   $cfg_file_tracker->{$cfg_file}{'change_needed'}++;
( $log_level >> $DEBUG ) && print "DEBUG $file needs 
updated.\n";
_file( $cfg_file, \$result );
}
else {
( $log_level >> $INFO ) && print "INFO: All lines match TrOps 
for config file: $cfg_file.\n";
-   $cfg_file_tracker->{$cfg_file}->{'change_needed'} = 0;
+   $cfg_file_tracker->{$cfg_file}{'change_needed'} = 0;
( $log_level >> $TRACE ) && print "TRACE Setting change not 
needed for $cfg_file.\n";
$return_code = $CFG_FILE_UNCHANGED;
}


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mtorluemke closed issue #2032: ORT doesn't notice new TLS certs

[GitBox]

mtorluemke closed issue #2032: ORT doesn't notice new TLS certs
URL: https://github.com/apache/incubator-trafficcontrol/issues/2032
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #2010: Go login

[GitBox]

asfgit commented on issue #2010: Go login
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2010#issuecomment-379763257
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/incubator-trafficcontrol-PR/1365/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services