Build failed in Jenkins: incubator-trafficcontrol-PR #1548

[Apache Jenkins Server]

See 


--
[...truncated 307 B...]
Building remotely on H34 (ubuntu xenial) in workspace 

Cloning the remote Git repository
Cloning repository git://github.com/apache/incubator-trafficcontrol.git
 > git init  # 
 > timeout=10
Fetching upstream changes from 
git://github.com/apache/incubator-trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress 
 > git://github.com/apache/incubator-trafficcontrol.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url 
 > git://github.com/apache/incubator-trafficcontrol.git # timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # 
 > timeout=10
 > git config remote.origin.url 
 > git://github.com/apache/incubator-trafficcontrol.git # timeout=10
Fetching upstream changes from 
git://github.com/apache/incubator-trafficcontrol.git
using GIT_SSH to set credentials 
 > git fetch --tags --progress 
 > git://github.com/apache/incubator-trafficcontrol.git 
 > +refs/pull/*:refs/remotes/origin/pr/*
 > git rev-parse a5eb1ba129d3e6f1d92a2235e70b122c098a9422^{commit} # timeout=10
Checking out Revision a5eb1ba129d3e6f1d92a2235e70b122c098a9422 (detached)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f a5eb1ba129d3e6f1d92a2235e70b122c098a9422
Commit message: "Add TO Go profile parameters routes"
 > git rev-list --no-walk 66c48b08d36034ee2f2a1f23d858fc83953eae22 # timeout=10
First time build. Skipping changelog.
[incubator-trafficcontrol-PR] $ /bin/bash /tmp/jenkins8654616081448908429.sh
+ '[' '!' -x bin/docker-compose ']'
+ mkdir bin
++ uname -s
++ uname -m
+ curl -L 
https://github.com/docker/compose/releases/download/1.13.0/docker-compose-Linux-x86_64
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 
0100   6170   6170 0   1862  0 --:--:-- --:--:-- --:--:--  1864
  0 8079k0 259620 0  27693  0  0:04:58 --:--:--  0:04:58 27693  
7 8079k7  619k0 0   318k  0  0:00:25  0:00:01  0:00:24  588k 16 
8079k   16 1334k0 0   451k  0  0:00:17  0:00:02  0:00:15  649k 26 
8079k   26 2115k0 0   534k  0  0:00:15  0:00:03  0:00:12  692k 35 
8079k   35 2881k0 0   581k  0  0:00:13  0:00:04  0:00:09  710k 45 
8079k   45 3663k0 0   614k  0  0:00:13  0:00:05  0:00:08  724k 55 
8079k   55 4513k0 0   648k  0  0:00:12  0:00:06  0:00:06  776k 68 
8079k   68 5550k0 0   697k  0  0:00:11  0:00:07  0:00:04  841k 85 
8079k   85 6926k0 0   772k  0  0:00:10  0:00:08  0:00:02  960k100 
8079k  100 8079k0 0   844k  0  0:00:09  0:00:09 --:--:-- 1126k
+ chmod +x ./bin/docker-compose
+ docker version
Client:
 Version:  17.05.0-ce
 API version:  1.29
 Go version:   go1.7.5
 Git commit:   89658be
 Built:Thu May  4 22:10:54 2017
 OS/Arch:  linux/amd64

Server:
 Version:  17.05.0-ce
 API version:  1.29 (minimum version 1.12)
 Go version:   go1.7.5
 Git commit:   89658be
 Built:Thu May  4 22:10:54 2017
 OS/Arch:  linux/amd64
 Experimental: false
+ rm -rf dist
+ export COMPOSE_HTTP_TIMEOUT=120
+ COMPOSE_HTTP_TIMEOUT=120
+ ./bin/docker-compose -p jenkins-incubator-trafficcontrol-PR-1548 -f 
infrastructure/docker/build/docker-compose.yml up --build
Creating network "jenkinsincubatortrafficcontrolpr1548_default" with the 
default driver
Building traffic_portal_build
Step 1/10 : FROM centos:7
7: Pulling from library/centos
Digest: sha256:989b936d56b1ace20ddf855a301741e52abca38286382cba7f3210e96d16
Status: Downloaded newer image for centos:7
 ---> e934aafc2206
Step 2/10 : MAINTAINER Dan Kirkwood
 ---> Using cache
 ---> 85207a97846d
Step 3/10 : VOLUME /trafficcontrol
 ---> Using cache
 ---> 32d4a2a545dc
Step 4/10 : RUN yum -y install  epel-releasegit 
rpm-build &&yum -y clean all
 ---> Using cache
 ---> bbac25135137
Step 5/10 : RUN rpm -ivh 
https://kojipkgs.fedoraproject.org//packages/http-parser/2.7.1/3.el7/x86_64/http-parser-2.7.1-3.el7.x86_64.rpm
 &&  yum -y install  gcc libffi-develmake   
 nodejs  npm ruby-devel  rubygems
 ---> Using cache
 ---> fc557dd72261
Step 6/10 : RUN gem install compass
 ---> Using cache
 ---> 4163a2ae09e9
Step 7/10 : RUN npm -g install bower grunt-cli
 ---> Using cache
 ---> ad3861685fb5
Step 8/10 : RUN echo '{ "allow_root": true }' > /root/.bowerrc
 ---> Using cache
 ---> 2a95476cfbc5
Step 9/10 : ADD infrastructure/docker/build/clean_build.sh /
 ---> Using cache
 

[GitHub] asfgit commented on issue #2256: Add TO Go profile parameters routes

[GitBox]

asfgit commented on issue #2256: Add TO Go profile parameters routes
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2256#issuecomment-388250281
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/incubator-trafficcontrol-PR/1548/
   Test FAILed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: incubator-trafficcontrol-PR-rat #830

[Apache Jenkins Server]

See 


--
Started by upstream project "incubator-trafficcontrol-PR" build number 1548
originally caused by:
 GitHub pull request #2256 of commit a5eb1ba129d3e6f1d92a2235e70b122c098a9422, 
no merge conflicts.
[EnvInject] - Loading node environment variables.
Building remotely on H35 (ubuntu xenial) in workspace 

[incubator-trafficcontrol-PR-rat] $ /bin/bash -xe 
/tmp/jenkins4947399193207509775.sh
+ rm -rf 

 

 '
[operations-center-context] Requesting copy of artifacts matching '**/*.tar.gz' 
from 'Last successful build (either stable or unstable)' of 
incubator-trafficcontrol-PR
[operations-center-context] Copied 1 artifacts matching '**/*.tar.gz' from 
'Last successful build (either stable or unstable)' of 
incubator-trafficcontrol-PR:
[operations-center-context]   apache-trafficcontrol-2.3.0-incubating.tar.gz
[incubator-trafficcontrol-PR-rat] $ /bin/bash -xe 
/tmp/jenkins4145767931910572496.sh
+ set -exu
++ ls apache-trafficcontrol-2.3.0-incubating.tar.gz
+ tarball=apache-trafficcontrol-2.3.0-incubating.tar.gz
+ tar xzf apache-trafficcontrol-2.3.0-incubating.tar.gz
++ pwd
++ basename apache-trafficcontrol-2.3.0-incubating.tar.gz .tar.gz
+ 
tcdir=
+ cd 

++ date +%Y
+ egrep 'Copyright .*-?2018 The Apache Software Foundation' NOTICE
Copyright 2016-2018 The Apache Software Foundation
+ set +x
Searching for class files:
PASSED: No class files found.
Searching for jar files:
PASSED: No jar files found.
Searching for tar files:
PASSED: No tar files found.
Searching for tgz files:
PASSED: No tgz files found.
Searching for zip files:
PASSED: No zip files found.
++ curl 
https://repository.apache.org/content/repositories/snapshots/org/apache/rat/apache-rat/0.13-SNAPSHOT/
 -sN
++ grep jar
++ awk -F '"' '{print $2}'
++ head -n 1
++ sort -r
++ cut -d / -f 12
++ grep -ve md5 -e sha1
+ ratver=apache-rat-0.13-20180329.151017-101.jar
++ mktemp -d
+ ratdir=/tmp/tmp.kCXyt7E128
+ ratjar=/tmp/tmp.kCXyt7E128/apache-rat-0.13.SNAPSHOT.jar
+ curl -L -o /tmp/tmp.kCXyt7E128/apache-rat-0.13.SNAPSHOT.jar 
https://repository.apache.org/content/repositories/snapshots/org/apache/rat/apache-rat/0.13-SNAPSHOT/apache-rat-0.13-20180329.151017-101.jar
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0  
0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0100 
1587k  100 1587k0 0  1703k  0 --:--:-- --:--:-- --:--:-- 1703k
+ curl -L -o /tmp/tmp.kCXyt7E128/apache-rat-0.13.SNAPSHOT.jar.sha1 
https://repository.apache.org/content/repositories/snapshots/org/apache/rat/apache-rat/0.13-SNAPSHOT/apache-rat-0.13-20180329.151017-101.jar.sha1
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0  
0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0100 
   40  100400 0 71  0 --:--:-- --:--:-- --:--:--71
++ sha1sum /tmp/tmp.kCXyt7E128/apache-rat-0.13.SNAPSHOT.jar
++ awk '{print $1}'
++ cat /tmp/tmp.kCXyt7E128/apache-rat-0.13.SNAPSHOT.jar.sha1
+ [[ 635c5eccad31cff1d713c12144eaae7fc9f10cf4 == 
635c5eccad31cff1d713c12144eaae7fc9f10cf4 ]]
++ pwd
++ pwd
+ java -jar /tmp/tmp.kCXyt7E128/apache-rat-0.13.SNAPSHOT.jar -E 

 -d 

+ rm -rf /tmp/tmp.kCXyt7E128
++ perl -lne 'print $1 if /(\d+) Unknown Licenses/' ratreport.txt
+ unknown=56
+ [[ 56 != 0 ]]
+ echo '56 Unknown Licenses'
56 Unknown Licenses
+ perl -lne 'print if /Files with unapproved licenses:/ .. /^\*\*\*/' 
ratreport.txt
+ sed s:::
Files with unapproved licenses:

  
apache-trafficcontrol-2.3.0-incubating/grove/vendor/code.cloudfoundry.org/bytefmt/bytes.go
  
apache-trafficcontrol-2.3.0-incubating/grove/vendor/code.cloudfoundry.org/bytefmt/bytes_test.go
  

Build failed in Jenkins: incubator-trafficcontrol-PR-rat #829

[Apache Jenkins Server]

See 


--
Started by upstream project "incubator-trafficcontrol-PR" build number 1547
originally caused by:
 GitHub pull request #2256 of commit 66c48b08d36034ee2f2a1f23d858fc83953eae22, 
no merge conflicts.
[EnvInject] - Loading node environment variables.
Building remotely on H25 (ubuntu xenial) in workspace 

[incubator-trafficcontrol-PR-rat] $ /bin/bash -xe 
/tmp/jenkins691224524608931351.sh
+ rm -rf 

 '
[operations-center-context] Requesting copy of artifacts matching '**/*.tar.gz' 
from 'Last successful build (either stable or unstable)' of 
incubator-trafficcontrol-PR
[operations-center-context] Copied 1 artifacts matching '**/*.tar.gz' from 
'Last successful build (either stable or unstable)' of 
incubator-trafficcontrol-PR:
[operations-center-context]   apache-trafficcontrol-2.3.0-incubating.tar.gz
[incubator-trafficcontrol-PR-rat] $ /bin/bash -xe 
/tmp/jenkins2443957194990883161.sh
+ set -exu
++ ls apache-trafficcontrol-2.3.0-incubating.tar.gz
+ tarball=apache-trafficcontrol-2.3.0-incubating.tar.gz
+ tar xzf apache-trafficcontrol-2.3.0-incubating.tar.gz
++ pwd
++ basename apache-trafficcontrol-2.3.0-incubating.tar.gz .tar.gz
+ 
tcdir=
+ cd 

++ date +%Y
+ egrep 'Copyright .*-?2018 The Apache Software Foundation' NOTICE
Copyright 2016-2018 The Apache Software Foundation
+ set +x
Searching for class files:
PASSED: No class files found.
Searching for jar files:
PASSED: No jar files found.
Searching for tar files:
PASSED: No tar files found.
Searching for tgz files:
PASSED: No tgz files found.
Searching for zip files:
PASSED: No zip files found.
++ curl 
https://repository.apache.org/content/repositories/snapshots/org/apache/rat/apache-rat/0.13-SNAPSHOT/
 -sN
++ grep jar
++ sort -r
++ head -n 1
++ cut -d / -f 12
++ awk -F '"' '{print $2}'
++ grep -ve md5 -e sha1
+ ratver=apache-rat-0.13-20180329.151017-101.jar
++ mktemp -d
+ ratdir=/tmp/tmp.g3n0yQjPj4
+ ratjar=/tmp/tmp.g3n0yQjPj4/apache-rat-0.13.SNAPSHOT.jar
+ curl -L -o /tmp/tmp.g3n0yQjPj4/apache-rat-0.13.SNAPSHOT.jar 
https://repository.apache.org/content/repositories/snapshots/org/apache/rat/apache-rat/0.13-SNAPSHOT/apache-rat-0.13-20180329.151017-101.jar
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0  
0 1587k0 156660 0  28026  0  0:00:57 --:--:--  0:00:57 28025100 
1587k  100 1587k0 0  1654k  0 --:--:-- --:--:-- --:--:-- 1653k
+ curl -L -o /tmp/tmp.g3n0yQjPj4/apache-rat-0.13.SNAPSHOT.jar.sha1 
https://repository.apache.org/content/repositories/snapshots/org/apache/rat/apache-rat/0.13-SNAPSHOT/apache-rat-0.13-20180329.151017-101.jar.sha1
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 
010040  100400 0 82  0 --:--:-- --:--:-- --:--:--82
++ sha1sum /tmp/tmp.g3n0yQjPj4/apache-rat-0.13.SNAPSHOT.jar
++ awk '{print $1}'
++ cat /tmp/tmp.g3n0yQjPj4/apache-rat-0.13.SNAPSHOT.jar.sha1
+ [[ 635c5eccad31cff1d713c12144eaae7fc9f10cf4 == 
635c5eccad31cff1d713c12144eaae7fc9f10cf4 ]]
++ pwd
++ pwd
+ java -jar /tmp/tmp.g3n0yQjPj4/apache-rat-0.13.SNAPSHOT.jar -E 

 -d 

+ rm -rf /tmp/tmp.g3n0yQjPj4
++ perl -lne 'print $1 if /(\d+) Unknown Licenses/' ratreport.txt
+ unknown=56
+ [[ 56 != 0 ]]
+ echo '56 Unknown Licenses'
56 Unknown Licenses
+ perl -lne 'print if /Files with unapproved licenses:/ .. /^\*\*\*/' 
ratreport.txt
+ sed s:::
Files with unapproved licenses:

  
apache-trafficcontrol-2.3.0-incubating/grove/vendor/code.cloudfoundry.org/bytefmt/bytes.go
  
apache-trafficcontrol-2.3.0-incubating/grove/vendor/code.cloudfoundry.org/bytefmt/bytes_test.go
  
apache-trafficcontrol-2.3.0-incubating/grove/vendor/code.cloudfoundry.org/bytefmt/formatters_suite_test.go
  
apache-trafficcontrol-2.3.0-incubating/grove/vendor/code.cloudfoundry.org/bytefmt/package.go
  

[GitHub] asfgit commented on issue #2256: Add TO Go profile parameters routes

[GitBox]

asfgit commented on issue #2256: Add TO Go profile parameters routes
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2256#issuecomment-388228922
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/incubator-trafficcontrol-PR/1547/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rob05c commented on issue #2232: Rewrite Traffic Ops CRConfig Table Endpoints in Go

[GitBox]

rob05c commented on issue #2232: Rewrite Traffic Ops CRConfig Table Endpoints 
in Go
URL: 
https://github.com/apache/incubator-trafficcontrol/issues/2232#issuecomment-387444293
 
 
   Ok, we have PRs for all major table routes, but many of them are only 
"CRUD", and missing additional endpoints. So I'm listing all Perl API routes 
here. 
   * if you've verified a route does not use one of the CRConfig tables 
(above), follow it with a bullet noting that. Be sure to verify any tables the 
route does use do not link a CRConfig table, in those tables' 
`traffic_ops/app/lib/Schema/Result`
   * if there is an unmerged PR, follow with a bullet linking the PR
   * if the route is in Go, in master, check it off
   
   - [x] get /api/1.1/asns
   - [x] get /api/1.2/asns
   - [x] get /api/1.1/asns/:id
   - [x] post /api/1.1/asns
   - [x] put /api/1.1/asns/:id
   - [x] delete /api/1.1/asns/:id
   - [ ] get /api/1.1/caches/stats
   - [x] get /api/1.1/cachegroups
   - [ ] get /api/1.1/cachegroups/trimmed
   - [x] get /api/1.1/cachegroups/:id
   - [x] post /api/1.1/cachegroups
   - [x] put /api/1.1/cachegroups/:id
   - [x] delete /api/1.1/cachegroups/:id
   - [ ] post /api/1.1/cachegroups/:id/deliveryservices
   - [ ] post /api/1.1/cachegroups/:id/queue_update
   - [x] get /api/1.1/cdns
   - [x] get /api/1.1/cdns/:id
   - [ ] get /api/1.1/cdns/name/:name
   - [x] post /api/1.1/cdns
   - [x] put /api/1.1/cdns/:id
   - [x] delete /api/1.1/cdns/:id
   - [ ] delete /api/1.1/cdns/name/:name
   - [ ] post /api/1.1/cdns/:id/queue_update
   - [ ] get /api/1.1/cdns/health
   - [ ] get /api/1.1/cdns/:name/health
   - [ ] get /api/1.1/cdns/capacity
   - [ ] get /api/1.1/cdns/routing
   - [x] get /api/1.1/cdns/:name/snapshot
   - [x] get /api/1.1/cdns/:name/snapshot/new
   - [x] put /api/1.1/cdns/:id/snapshot
   - [x] put /api/1.1/snapshot/:cdn_name
   - [ ] get 
/api/1.1/cdns/metric_types/:metric_type/start_date/:start_date/end_date/:end_date
   - [ ] get /api/1.1/cdns/name/:name/dnsseckeys
   - [ ] post /api/1.1/cdns/dnsseckeys/generate
   - [ ] get /api/1.1/cdns/name/:name/dnsseckeys/delete
   - [ ] get /internal/api/1.1/cdns/dnsseckeys/refresh
   - [ ] get /api/1.1/cdns/name/:name/sslkeys
   - [ ] get /api/1.1/cdns/configs
   - [ ] get /api/1.1/cdns/:name/configs/routing
   - [x] get /api/1.1/cdns/:name/configs/monitoring
   - [ ] get /api/1.1/cdns/domains
   - [ ] get /api/1.1/logs
   - [ ] get /api/1.1/logs/:days/days
   - [ ] get /api/1.1/logs/newcount
   - [ ] get /api/1.1/servers/:id/configfiles/ats
   - [ ] get /api/1.1/profiles/:id/configfiles/ats/:filename
   - [ ] get /api/1.1/servers/:id/configfiles/ats/:filename
   - [ ] get /api/1.1/cdns/:id/configfiles/ats/:filename
   - [ ] get /api/1.1/dbdump
   - [ ] get /api/1.1/deliveryservices
- PR https://github.com/apache/incubator-trafficcontrol/pull/2124
   - [ ] get /api/1.1/deliveryservices/:id
- PR https://github.com/apache/incubator-trafficcontrol/pull/2124
   - [ ] post /api/1.1/deliveryservices
- PR https://github.com/apache/incubator-trafficcontrol/pull/2124
   - [ ] put /api/1.1/deliveryservices/:id
- PR https://github.com/apache/incubator-trafficcontrol/pull/2124
   - [ ] put /api/1.1/deliveryservices/:id/safe
   - [ ] delete /api/1.1/deliveryservices/:id
- PR https://github.com/apache/incubator-trafficcontrol/pull/2124
   - [x] get /api/1.1/servers/:id/deliveryservices
   - [ ] post /api/1.1/deliveryservices/:xml_id/servers
   - [ ] delete /api/1.1/deliveryservice_server/:dsId/:serverId
   - [ ] get /api/1.1/deliveryservices/:id/health
   - [ ] get /api/1.1/deliveryservices/:id/capacity
   - [ ] get /api/1.1/deliveryservices/:id/routing
   - [ ] get /api/1.1/deliveryservices/:id/state
   - [ ] post /api/1.1/deliveryservices/request
   - [ ] get /internal/api/1.1/steering
   - [ ] get /internal/api/1.1/steering/:xml_id
   - [ ] put /internal/api/1.1/steering/:xml_id
   - [ ] get /api/1.1/steering/:id/targets
   - [ ] get /api/1.1/steering/:id/targets/:target_id
   - [ ] post /api/1.1/steering/:id/targets
   - [ ] put /api/1.1/steering/:id/targets/:target_id
   - [ ] delete /api/1.1/steering/:id/targets/:target_id
   - [x] get /api/1.1/deliveryservices/xmlId/:xmlid/sslkeys
   - [ ] post /api/1.1/deliveryservices/sslkeys/generate
   - [x] post /api/1.1/deliveryservices/sslkeys/add
   - [ ] get /api/1.1/deliveryservices/xmlId/:xmlid/sslkeys/delete
   - [ ] post /api/1.1/deliveryservices/xmlId/:xmlId/urlkeys/generate
   - [ ] post 
/api/1.1/deliveryservices/xmlId/:xmlId/urlkeys/copyFromXmlId/:copyFromXmlId
   - [ ] get /api/1.1/deliveryservices/xmlId/:xmlId/urlkeys
   - [ ] get /api/1.1/deliveryservices/:id/urlkeys
   - [ ] get /api/1.1/deliveryservices_regexes
- PR https://github.com/apache/incubator-trafficcontrol/pull/2229
   - [ ] get /api/1.1/deliveryservices/:dsId/regexes
- PR https://github.com/apache/incubator-trafficcontrol/pull/2229
   - [ ] get /api/1.1/deliveryservices/:dsId/regexes/:id
- PR 

[GitHub] rob05c opened a new pull request #2256: Add TO Go profile parameters routes

[GitBox]

rob05c opened a new pull request #2256: Add TO Go profile parameters routes
URL: https://github.com/apache/incubator-trafficcontrol/pull/2256
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rawlinp opened a new issue #2255: Traffic Ops API endpoint for generating SSL keys needs validation

[GitBox]

rawlinp opened a new issue #2255: Traffic Ops API endpoint for generating SSL 
keys needs validation
URL: https://github.com/apache/incubator-trafficcontrol/issues/2255
 
 
   The `/api/$version/deliveryservices/sslkeys/generate` route currently 
doesn't validate the request payload very well. If the request payload is 
missing `"deliveryservice"` or has that key set to `null`, the request is 
passed through successfully. However, downstream components such as Traffic 
Router that make use of the `/cdns/name/*/sslkeys.json` endpoint expect the 
`"deliveryservice"` key to exist and have a value (the xml_id). Traffic Router 
can get into a state on startup where it is unable to serve requests until the 
offending record has been removed from Riak (that in itself is a bug which 
needs to be fixed - #2254).
   
   Example bad request:
   ```
   {
 "key": "badkey",
 "hostname": "cdn.anotherbadhostname.foo.net",
 "country": "US",
 "state": "CO",
 "city": "Denver",
 "organization": "blah",
 "businessUnit": "blah",
 "cdn": "my-cdn"
   }
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: incubator-trafficcontrol-PR-rat #828

[Apache Jenkins Server]

See 


--
Started by upstream project "incubator-trafficcontrol-PR" build number 1546
originally caused by:
 GitHub pull request #2010 of commit 171c723709c67debebfc001f00b34c24dee2d29c, 
no merge conflicts.
[EnvInject] - Loading node environment variables.
Building remotely on H34 (ubuntu xenial) in workspace 

[incubator-trafficcontrol-PR-rat] $ /bin/bash -xe 
/tmp/jenkins7734192997565157352.sh
+ rm -rf 

 

 '
[operations-center-context] Requesting copy of artifacts matching '**/*.tar.gz' 
from 'Last successful build (either stable or unstable)' of 
incubator-trafficcontrol-PR
[operations-center-context] Copied 1 artifacts matching '**/*.tar.gz' from 
'Last successful build (either stable or unstable)' of 
incubator-trafficcontrol-PR:
[operations-center-context]   apache-trafficcontrol-2.3.0-incubating.tar.gz
[incubator-trafficcontrol-PR-rat] $ /bin/bash -xe 
/tmp/jenkins3234885927990066340.sh
+ set -exu
++ ls apache-trafficcontrol-2.3.0-incubating.tar.gz
+ tarball=apache-trafficcontrol-2.3.0-incubating.tar.gz
+ tar xzf apache-trafficcontrol-2.3.0-incubating.tar.gz
++ pwd
++ basename apache-trafficcontrol-2.3.0-incubating.tar.gz .tar.gz
+ 
tcdir=
+ cd 

++ date +%Y
+ egrep 'Copyright .*-?2018 The Apache Software Foundation' NOTICE
Copyright 2016-2018 The Apache Software Foundation
+ set +x
Searching for class files:
PASSED: No class files found.
Searching for jar files:
PASSED: No jar files found.
Searching for tar files:
PASSED: No tar files found.
Searching for tgz files:
PASSED: No tgz files found.
Searching for zip files:
PASSED: No zip files found.
++ curl 
https://repository.apache.org/content/repositories/snapshots/org/apache/rat/apache-rat/0.13-SNAPSHOT/
 -sN
++ grep jar
++ awk -F '"' '{print $2}'
++ grep -ve md5 -e sha1
++ sort -r
++ head -n 1
++ cut -d / -f 12
+ ratver=apache-rat-0.13-20180329.151017-101.jar
++ mktemp -d
+ ratdir=/tmp/tmp.PVdbcXIYx1
+ ratjar=/tmp/tmp.PVdbcXIYx1/apache-rat-0.13.SNAPSHOT.jar
+ curl -L -o /tmp/tmp.PVdbcXIYx1/apache-rat-0.13.SNAPSHOT.jar 
https://repository.apache.org/content/repositories/snapshots/org/apache/rat/apache-rat/0.13-SNAPSHOT/apache-rat-0.13-20180329.151017-101.jar
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0  
6 1587k6  101k0 0   132k  0  0:00:12 --:--:--  0:00:12  131k100 
1587k  100 1587k0 0  1615k  0 --:--:-- --:--:-- --:--:-- 1614k
+ curl -L -o /tmp/tmp.PVdbcXIYx1/apache-rat-0.13.SNAPSHOT.jar.sha1 
https://repository.apache.org/content/repositories/snapshots/org/apache/rat/apache-rat/0.13-SNAPSHOT/apache-rat-0.13-20180329.151017-101.jar.sha1
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 
010040  100400 0 72  0 --:--:-- --:--:-- --:--:--72
++ sha1sum /tmp/tmp.PVdbcXIYx1/apache-rat-0.13.SNAPSHOT.jar
++ awk '{print $1}'
++ cat /tmp/tmp.PVdbcXIYx1/apache-rat-0.13.SNAPSHOT.jar.sha1
+ [[ 635c5eccad31cff1d713c12144eaae7fc9f10cf4 == 
635c5eccad31cff1d713c12144eaae7fc9f10cf4 ]]
++ pwd
++ pwd
+ java -jar /tmp/tmp.PVdbcXIYx1/apache-rat-0.13.SNAPSHOT.jar -E 

 -d 

+ rm -rf /tmp/tmp.PVdbcXIYx1
++ perl -lne 'print $1 if /(\d+) Unknown Licenses/' ratreport.txt
+ unknown=56
+ [[ 56 != 0 ]]
+ echo '56 Unknown Licenses'
56 Unknown Licenses
+ perl -lne 'print if /Files with unapproved licenses:/ .. /^\*\*\*/' 
ratreport.txt
+ sed s:::
Files with unapproved licenses:

  
apache-trafficcontrol-2.3.0-incubating/grove/vendor/code.cloudfoundry.org/bytefmt/bytes.go
  
apache-trafficcontrol-2.3.0-incubating/grove/vendor/code.cloudfoundry.org/bytefmt/bytes_test.go
  
apache-trafficcontrol-2.3.0-incubating/grove/vendor/code.cloudfoundry.org/bytefmt/formatters_suite_test.go
  

[GitHub] asfgit commented on issue #2010: Go login

[GitBox]

asfgit commented on issue #2010: Go login
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2010#issuecomment-388195760
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/incubator-trafficcontrol-PR/1546/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rawlinp opened a new issue #2254: Traffic Router should properly handle null values in sslkeys.json

[GitBox]

rawlinp opened a new issue #2254: Traffic Router should properly handle null 
values in sslkeys.json
URL: https://github.com/apache/incubator-trafficcontrol/issues/2254
 
 
   If there is a `"deliveryservice": null` in the sslkeys.json retrieved from 
the TO API, TR will continually loop catching a `NullPointerException` and 
never actually complete the sslkeys.json validation process. See below:
   ```
   WARN  2018-05-10T20:12:07.674 [Thread-5] 
com.comcast.cdn.traffic_control.traffic_router.core.secure.CertificatesPublisher
 - Interrupted while waiting for new certificate data list,
trying again...
   java.lang.NullPointerException
   at 
com.comcast.cdn.traffic_control.traffic_router.core.config.CertificateChecker.deliveryServiceHasValidCertificates(CertificateChecker.java:89)
   at 
com.comcast.cdn.traffic_control.traffic_router.core.config.CertificateChecker.certificatesAreValid(CertificateChecker.java:49)
   at 
com.comcast.cdn.traffic_control.traffic_router.core.secure.CertificatesPublisher.lambda$new$1(CertificatesPublisher.java:59)
   at java.lang.Thread.run(Thread.java:745)
   INFO  2018-05-10T20:12:08.265 [main] 
com.comcast.cdn.traffic_control.traffic_router.core.config.ConfigHandler - 
Waiting for https certificates to support new config 42b02722
   INFO  2018-05-10T20:12:09.265 [main] 
com.comcast.cdn.traffic_control.traffic_router.core.config.ConfigHandler - 
Waiting for https certificates to support new config 42b02722
   ```
   Unless the offending record is removed from riak, TR will continue looping 
in this manner. Instead, TR should handle the null value properly and move on.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mitchell852 commented on a change in pull request #2236: update portal info bubbles

[GitBox]

mitchell852 commented on a change in pull request #2236: update portal info 
bubbles
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2236#discussion_r187352185
 
 

 ##
 File path: traffic_portal/app/src/traffic_portal_properties.json
 ##
 @@ -252,49 +252,49 @@
 "title": "Global Max TPS",
 "desc": "The maximum transactions this delivery service can serve 
across all EDGE caches before traffic will be diverted to the bypass 
destination. For a DNS delivery service, the Bypass Ipv4 or Ipv6 will be used 
(depending on whether this was a A or  request), and for HTTP delivery 
services the Bypass FQDN will be used."
   },
- "fqPacingRate": {
-   "title": "Fair Queuing Pacing Rate Bps",
+  "fqPacingRate": {
+"title": "Fair Queuing Pacing Rate Bps",
 "desc": "The maximum bytes per second a cache will delivery on any 
single TCP connection. This uses the Linux kernel's Fair Queuing 
setsockopt(SO_MAX_PACING_RATE) to limit the rate of delivery."
-  },
+  },
   "httpBypassFqdn": {
 "title": "HTTP Bypass FQDN",
 "desc": "This is the FQDN Traffic Router will redirect to (with 
the same path) when the max Bps or Max Tps for this delivery service are 
exceeded."
   },
   "infoUrl": {
 "title": "Info URL",
-"desc": "Info URL for this delivery service."
+"desc": "Free text field allowing you to enter a URL which 
provides information about the service. To be consumed from the APIs by 
downstream tools."
 
 Review comment:
   No need to say who it's consume by. Theoretically, it can be consumed by any 
API consumer. or just viewed in the UI.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mitchell852 commented on a change in pull request #2236: update portal info bubbles

[GitBox]

mitchell852 commented on a change in pull request #2236: update portal info 
bubbles
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2236#discussion_r187353732
 
 

 ##
 File path: traffic_portal/app/src/traffic_portal_properties.json
 ##
 @@ -306,71 +306,71 @@
   },
   "multiSiteOrigin": {
 "title": "Use Multi Site Origin Feature",
-"desc": "Enable the Multi Site Origin feature for this delivery 
service.http://traffic-control-cdn.readthedocs.io/en/latest/admin/traffic_ops/using.html#rl-multi-site-origin\;
 target=\"_blank\">See Multi Site Origin..."
+"desc": "Enable the Multi Site Origin feature for this delivery 
service. Is the Multi Site Origin feature enabled for this delivery service 
(True/False).http://traffic-control-cdn.readthedocs.io/en/latest/admin/traffic_ops/using.html#rl-multi-site-origin\;
 target=\"_blank\">See Multi Site Origin."
   },
   "orgServerFqdn": {
 "title": "Origin Server Base URL",
-"desc": "The Origin Server’s base URL. This includes the protocol 
(http or https). Example: http://movies.origin.com;
+"desc": "The Origin Server’s base URL. This includes the protocol 
(http or https). Example: http://movies.origin.com. Must be a domain only, no 
directories or IP addresses"
   },
   "originShield": {
 "title": "Origin Shield (Pipe Delimited String)",
-"desc": "Description required"
+"desc": "Add another forward proxy upstream of the mid caches. 
Example: go_direct=true will allow the Mid to hit the origin directly instead 
of failing if the origin shield is down. Experimental Feature."
   },
   "profileId": {
 "title": "Delivery Service Profile",
-"desc": "Description required"
+"desc": "Only used if a delivery service uses configurations that 
specifically require a profile. Example: MSO configurations or cachekey plugin 
would require a ds profile to be used."
   },
   "protocol": {
 "title": "Protocol",
-"desc": "The protocol to serve this delivery service to the 
clients with.http://traffic-control-cdn.readthedocs.io/en/latest/admin/traffic_ops/using.html#delivery-service\;
 target=\"_blank\">See more..."
+"desc": "Services that use \"HTTP and HTTPS\" will be able to 
deliver both types of traffic."
 
 Review comment:
   This doesn't seem like a good description of "protocol" as it seems to 
ignore the other types


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mitchell852 commented on a change in pull request #2236: update portal info bubbles

[GitBox]

mitchell852 commented on a change in pull request #2236: update portal info 
bubbles
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2236#discussion_r187352479
 
 

 ##
 File path: traffic_portal/app/src/traffic_portal_properties.json
 ##
 @@ -252,49 +252,49 @@
 "title": "Global Max TPS",
 "desc": "The maximum transactions this delivery service can serve 
across all EDGE caches before traffic will be diverted to the bypass 
destination. For a DNS delivery service, the Bypass Ipv4 or Ipv6 will be used 
(depending on whether this was a A or  request), and for HTTP delivery 
services the Bypass FQDN will be used."
   },
- "fqPacingRate": {
-   "title": "Fair Queuing Pacing Rate Bps",
+  "fqPacingRate": {
+"title": "Fair Queuing Pacing Rate Bps",
 "desc": "The maximum bytes per second a cache will delivery on any 
single TCP connection. This uses the Linux kernel's Fair Queuing 
setsockopt(SO_MAX_PACING_RATE) to limit the rate of delivery."
-  },
+  },
   "httpBypassFqdn": {
 "title": "HTTP Bypass FQDN",
 "desc": "This is the FQDN Traffic Router will redirect to (with 
the same path) when the max Bps or Max Tps for this delivery service are 
exceeded."
   },
   "infoUrl": {
 "title": "Info URL",
-"desc": "Info URL for this delivery service."
+"desc": "Free text field allowing you to enter a URL which 
provides information about the service. To be consumed from the APIs by 
downstream tools."
   },
   "initialDispersion": {
 "title": "Initial Dispersion",
-"desc": "Description required"
+"desc": "This is available only for HTTP Content Routing Types. 
Determines number of machines content will be placed on within a cache group. 
Default is 1, Setting too high will result in poor caching performance."
 
 Review comment:
   Again, don't reference the default as the default can be changed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mitchell852 commented on a change in pull request #2236: update portal info bubbles

[GitBox]

mitchell852 commented on a change in pull request #2236: update portal info 
bubbles
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2236#discussion_r187349711
 
 

 ##
 File path: traffic_portal/app/src/traffic_portal_properties.json
 ##
 @@ -178,71 +178,71 @@
   "_comments": "This is the text used to configure delivery service 
field titles/descriptions",
   "active": {
 "title": "Active",
-"desc": "When this is set to false Traffic Router will not serve 
DNS or HTTP responses for this delivery service."
+"desc": "Whether or not this delivery service is active on the CDN 
and is capable of traffic."
   },
   "cacheurl": {
 "title": "Cache URL expression",
-"desc": "Cache URL rule to apply to this delivery 
service.See https://docs.trafficserver.apache.org/en/latest/admin-guide/plugins/cacheurl.en.html\;
 target=\"_blank\">ATS documentation on cacheurl..."
+"desc": "Allows you to manipulate the cache key of the incoming 
requests. Normally, the cache key is the origin domain. This can be changed so 
that multiple services can share a cache key, can also be used to preserve 
cached content if service origin is changed.Note: Only valid in ATS 
6. X and earlier. Must be empty if using ATS 7. X and / or the https://docs.trafficserver.apache.org/en/latest/admin-guide/plugins/cachekey.en.html\;
 target=\"_blank\">cachekey plugin.See https://docs.trafficserver.apache.org/en/6.2.x/admin-guide/plugins/cacheurl.en.html\;
 target=\"_blank\">ATS documentation on cacheurl "
   },
   "ccrDnsTtl": {
 "title": "Delivery Service DNS TTL",
-"desc": "The Time To Live on the DNS record for the Traffic Router 
A and  records."
+"desc": "(For DNS routed delivery services only) The Time To Live 
on the DNS record for the Traffic Router A and  records. Default value is 
30 seconds. Setting too high or too low will result in poor caching 
performance."
 
 Review comment:
   I don't think you need the 
   
   (For DNS routed delivery services only) 
   
   because this field only shows up for DNS delivery services so it is 
redundant.
   
   Also, the default is configurable so by saying "Default value is 30 seconds" 
this will be inaccurate if somebody changes the default.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mitchell852 commented on a change in pull request #2236: update portal info bubbles

[GitBox]

mitchell852 commented on a change in pull request #2236: update portal info 
bubbles
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2236#discussion_r187350683
 
 

 ##
 File path: traffic_portal/app/src/traffic_portal_properties.json
 ##
 @@ -178,71 +178,71 @@
   "_comments": "This is the text used to configure delivery service 
field titles/descriptions",
   "active": {
 "title": "Active",
-"desc": "When this is set to false Traffic Router will not serve 
DNS or HTTP responses for this delivery service."
+"desc": "Whether or not this delivery service is active on the CDN 
and is capable of traffic."
   },
   "cacheurl": {
 "title": "Cache URL expression",
-"desc": "Cache URL rule to apply to this delivery 
service.See https://docs.trafficserver.apache.org/en/latest/admin-guide/plugins/cacheurl.en.html\;
 target=\"_blank\">ATS documentation on cacheurl..."
+"desc": "Allows you to manipulate the cache key of the incoming 
requests. Normally, the cache key is the origin domain. This can be changed so 
that multiple services can share a cache key, can also be used to preserve 
cached content if service origin is changed.Note: Only valid in ATS 
6. X and earlier. Must be empty if using ATS 7. X and / or the https://docs.trafficserver.apache.org/en/latest/admin-guide/plugins/cachekey.en.html\;
 target=\"_blank\">cachekey plugin.See https://docs.trafficserver.apache.org/en/6.2.x/admin-guide/plugins/cacheurl.en.html\;
 target=\"_blank\">ATS documentation on cacheurl "
   },
   "ccrDnsTtl": {
 "title": "Delivery Service DNS TTL",
-"desc": "The Time To Live on the DNS record for the Traffic Router 
A and  records."
+"desc": "(For DNS routed delivery services only) The Time To Live 
on the DNS record for the Traffic Router A and  records. Default value is 
30 seconds. Setting too high or too low will result in poor caching 
performance."
   },
   "cdnId": {
 "title": "CDN",
-"desc": "The CDN in which the delivery service belongs to."
+"desc": "The CDN in which the delivery service belongs."
   },
   "checkPath": {
 "title": "Check Path",
 "desc": "A path (ex: /crossdomain.xml) to verify the connection to 
the origin server with. This can be used by Check Extension scripts to do 
periodic health checks against the delivery service."
   },
   "deepCachingType": {
 "title": "Deep Caching",
-"desc": "When to do deep caching for this delivery 
service.See http://traffic-control-cdn.readthedocs.io/en/latest/admin/traffic_router.html#rl-deep-cache\;
 target=\"_blank\">Deep Caching for more details..."
+"desc": "Enables clients to be routed to the closest possible deep 
edge caches on a per Delivery Service basis.http://traffic-control-cdn.readthedocs.io/en/latest/admin/traffic_router.html#rl-deep-cache\;
 target=\"_blank\">See Deep Caching"
   },
   "displayName": {
 "title": "Display Name",
-"desc": "A human-readable name for the delivery service."
+"desc": "Name of the service that appears in the Traffic portal. 
No character restrictions."
   },
   "dnsBypassCname": {
 "title": "DNS Bypass CNAME",
-"desc": "Description required"
+"desc": "(For DNS routed delivery services only) Domain name to 
overflow requests when the the max Bps or Max Tps for this delivery service are 
exceeded."
   },
   "dnsBypassIp": {
 "title": "DNS Bypass IP",
-"desc": "This is the address to respond to A requests with when 
the max Bps or Max Tps for this delivery service are exceeded."
+"desc": "(For DNS routed delivery services only) IPv4 address to 
overflow requests when the the max Bps or Max Tps for this delivery service are 
exceeded."
 
 Review comment:
   again, ditch the (For DNS routed delivery services only)
   
   and is it max or Max?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mitchell852 commented on a change in pull request #2236: update portal info bubbles

[GitBox]

mitchell852 commented on a change in pull request #2236: update portal info 
bubbles
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2236#discussion_r187350781
 
 

 ##
 File path: traffic_portal/app/src/traffic_portal_properties.json
 ##
 @@ -178,71 +178,71 @@
   "_comments": "This is the text used to configure delivery service 
field titles/descriptions",
   "active": {
 "title": "Active",
-"desc": "When this is set to false Traffic Router will not serve 
DNS or HTTP responses for this delivery service."
+"desc": "Whether or not this delivery service is active on the CDN 
and is capable of traffic."
   },
   "cacheurl": {
 "title": "Cache URL expression",
-"desc": "Cache URL rule to apply to this delivery 
service.See https://docs.trafficserver.apache.org/en/latest/admin-guide/plugins/cacheurl.en.html\;
 target=\"_blank\">ATS documentation on cacheurl..."
+"desc": "Allows you to manipulate the cache key of the incoming 
requests. Normally, the cache key is the origin domain. This can be changed so 
that multiple services can share a cache key, can also be used to preserve 
cached content if service origin is changed.Note: Only valid in ATS 
6. X and earlier. Must be empty if using ATS 7. X and / or the https://docs.trafficserver.apache.org/en/latest/admin-guide/plugins/cachekey.en.html\;
 target=\"_blank\">cachekey plugin.See https://docs.trafficserver.apache.org/en/6.2.x/admin-guide/plugins/cacheurl.en.html\;
 target=\"_blank\">ATS documentation on cacheurl "
   },
   "ccrDnsTtl": {
 "title": "Delivery Service DNS TTL",
-"desc": "The Time To Live on the DNS record for the Traffic Router 
A and  records."
+"desc": "(For DNS routed delivery services only) The Time To Live 
on the DNS record for the Traffic Router A and  records. Default value is 
30 seconds. Setting too high or too low will result in poor caching 
performance."
   },
   "cdnId": {
 "title": "CDN",
-"desc": "The CDN in which the delivery service belongs to."
+"desc": "The CDN in which the delivery service belongs."
   },
   "checkPath": {
 "title": "Check Path",
 "desc": "A path (ex: /crossdomain.xml) to verify the connection to 
the origin server with. This can be used by Check Extension scripts to do 
periodic health checks against the delivery service."
   },
   "deepCachingType": {
 "title": "Deep Caching",
-"desc": "When to do deep caching for this delivery 
service.See http://traffic-control-cdn.readthedocs.io/en/latest/admin/traffic_router.html#rl-deep-cache\;
 target=\"_blank\">Deep Caching for more details..."
+"desc": "Enables clients to be routed to the closest possible deep 
edge caches on a per Delivery Service basis.http://traffic-control-cdn.readthedocs.io/en/latest/admin/traffic_router.html#rl-deep-cache\;
 target=\"_blank\">See Deep Caching"
   },
   "displayName": {
 "title": "Display Name",
-"desc": "A human-readable name for the delivery service."
+"desc": "Name of the service that appears in the Traffic portal. 
No character restrictions."
   },
   "dnsBypassCname": {
 "title": "DNS Bypass CNAME",
-"desc": "Description required"
+"desc": "(For DNS routed delivery services only) Domain name to 
overflow requests when the the max Bps or Max Tps for this delivery service are 
exceeded."
   },
   "dnsBypassIp": {
 "title": "DNS Bypass IP",
-"desc": "This is the address to respond to A requests with when 
the max Bps or Max Tps for this delivery service are exceeded."
+"desc": "(For DNS routed delivery services only) IPv4 address to 
overflow requests when the the max Bps or Max Tps for this delivery service are 
exceeded."
   },
   "dnsBypassIp6": {
 "title": "DNS Bypass IPv6",
-"desc": "This is the address to respond to  requests with when 
the max Bps or Max Tps for this delivery service are exceeded."
+"desc": "(For DNS routed delivery services only) IPv6 address to 
overflow requests when the the max Bps or Max Tps for this delivery service are 
exceeded."
 
 Review comment:
   same comment


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mitchell852 commented on a change in pull request #2236: update portal info bubbles

[GitBox]

mitchell852 commented on a change in pull request #2236: update portal info 
bubbles
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2236#discussion_r187354002
 
 

 ##
 File path: traffic_portal/app/src/traffic_portal_properties.json
 ##
 @@ -306,71 +306,71 @@
   },
   "multiSiteOrigin": {
 "title": "Use Multi Site Origin Feature",
-"desc": "Enable the Multi Site Origin feature for this delivery 
service.http://traffic-control-cdn.readthedocs.io/en/latest/admin/traffic_ops/using.html#rl-multi-site-origin\;
 target=\"_blank\">See Multi Site Origin..."
+"desc": "Enable the Multi Site Origin feature for this delivery 
service. Is the Multi Site Origin feature enabled for this delivery service 
(True/False).http://traffic-control-cdn.readthedocs.io/en/latest/admin/traffic_ops/using.html#rl-multi-site-origin\;
 target=\"_blank\">See Multi Site Origin."
   },
   "orgServerFqdn": {
 "title": "Origin Server Base URL",
-"desc": "The Origin Server’s base URL. This includes the protocol 
(http or https). Example: http://movies.origin.com;
+"desc": "The Origin Server’s base URL. This includes the protocol 
(http or https). Example: http://movies.origin.com. Must be a domain only, no 
directories or IP addresses"
   },
   "originShield": {
 "title": "Origin Shield (Pipe Delimited String)",
-"desc": "Description required"
+"desc": "Add another forward proxy upstream of the mid caches. 
Example: go_direct=true will allow the Mid to hit the origin directly instead 
of failing if the origin shield is down. Experimental Feature."
   },
   "profileId": {
 "title": "Delivery Service Profile",
-"desc": "Description required"
+"desc": "Only used if a delivery service uses configurations that 
specifically require a profile. Example: MSO configurations or cachekey plugin 
would require a ds profile to be used."
   },
   "protocol": {
 "title": "Protocol",
-"desc": "The protocol to serve this delivery service to the 
clients with.http://traffic-control-cdn.readthedocs.io/en/latest/admin/traffic_ops/using.html#delivery-service\;
 target=\"_blank\">See more..."
+"desc": "Services that use \"HTTP and HTTPS\" will be able to 
deliver both types of traffic."
   },
   "qstringIgnore": {
 "title": "Query String Handling",
-"desc": "How to treat query strings.http://traffic-control-cdn.readthedocs.io/en/latest/admin/traffic_ops/using.html#delivery-service\;
 target=\"_blank\">See more..."
+"desc": "How to treat query strings:0 use in cache 
key and hand up to origin: Each unique query string is treated as a unique 
URL.1 Do not use in cache key, but pass up to origin: 2 URLs that are 
the same except for the query string will match and cache HIT, while the origin 
still sees original query string in the request.2 Drop at edge: 2 URLs 
that are the same except for the query string will match and cache HIT, while 
the origin will not see original query string in the 
request.Note: Choosing to drop query strings at the edge will 
preclude the use of a Regex Remap Expression. http://traffic-control-cdn.readthedocs.io/en/latest/admin/traffic_ops/using.html#regex-remap-expression\;
 target=\"_blank\">See Regex Remap ExpressionTo set the qstring without 
the use of regex remap, or for further options, http://traffic-control-cdn.readthedocs.io/en/latest/admin/traffic_ops/using.html#qstring-handling\;
 target=\"_blank\">See Qstring Handling"
   },
   "rangeRequestHandling": {
 "title": "Range Request Handling",
-"desc": "How to treat range requests.http://traffic-control-cdn.readthedocs.io/en/latest/admin/traffic_ops/using.html#delivery-service\;
 target=\"_blank\">See more..."
+"desc": "How to treat range requests.0: Do not 
cache (ranges requested from files that are already cached due to a non range 
request will be a HIT)1: Use the https://docs.trafficserver.apache.org/en/latest/admin-guide/plugins/background_fetch.en.html\;
 target=\"_blank\">background_fetch plugin.2: Use the 
cache_range_requests plugin."
   },
   "regexRemap": {
 "title": "Regex remap expression",
-"desc": "Regex Remap rule to apply to this delivery service at the 
Edge tier.http://traffic-control-cdn.readthedocs.io/en/latest/admin/traffic_ops/using.html#delivery-service\;
 target=\"_blank\">See more..."
+"desc": "Allows remapping of incoming requests URL using regex 
pattern matching to search/replace text.https://docs.trafficserver.apache.org/en/latest/admin-guide/plugins/regex_remap.en.html\;
 target=\"_blank\">See ATS documentation on regex remapNote: You will 
not be able to save a Regex Remap Expression if you have Query 

[GitHub] mitchell852 commented on a change in pull request #2236: update portal info bubbles

[GitBox]

mitchell852 commented on a change in pull request #2236: update portal info 
bubbles
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2236#discussion_r187350423
 
 

 ##
 File path: traffic_portal/app/src/traffic_portal_properties.json
 ##
 @@ -178,71 +178,71 @@
   "_comments": "This is the text used to configure delivery service 
field titles/descriptions",
   "active": {
 "title": "Active",
-"desc": "When this is set to false Traffic Router will not serve 
DNS or HTTP responses for this delivery service."
+"desc": "Whether or not this delivery service is active on the CDN 
and is capable of traffic."
   },
   "cacheurl": {
 "title": "Cache URL expression",
-"desc": "Cache URL rule to apply to this delivery 
service.See https://docs.trafficserver.apache.org/en/latest/admin-guide/plugins/cacheurl.en.html\;
 target=\"_blank\">ATS documentation on cacheurl..."
+"desc": "Allows you to manipulate the cache key of the incoming 
requests. Normally, the cache key is the origin domain. This can be changed so 
that multiple services can share a cache key, can also be used to preserve 
cached content if service origin is changed.Note: Only valid in ATS 
6. X and earlier. Must be empty if using ATS 7. X and / or the https://docs.trafficserver.apache.org/en/latest/admin-guide/plugins/cachekey.en.html\;
 target=\"_blank\">cachekey plugin.See https://docs.trafficserver.apache.org/en/6.2.x/admin-guide/plugins/cacheurl.en.html\;
 target=\"_blank\">ATS documentation on cacheurl "
   },
   "ccrDnsTtl": {
 "title": "Delivery Service DNS TTL",
-"desc": "The Time To Live on the DNS record for the Traffic Router 
A and  records."
+"desc": "(For DNS routed delivery services only) The Time To Live 
on the DNS record for the Traffic Router A and  records. Default value is 
30 seconds. Setting too high or too low will result in poor caching 
performance."
   },
   "cdnId": {
 "title": "CDN",
-"desc": "The CDN in which the delivery service belongs to."
+"desc": "The CDN in which the delivery service belongs."
   },
   "checkPath": {
 "title": "Check Path",
 "desc": "A path (ex: /crossdomain.xml) to verify the connection to 
the origin server with. This can be used by Check Extension scripts to do 
periodic health checks against the delivery service."
   },
   "deepCachingType": {
 "title": "Deep Caching",
-"desc": "When to do deep caching for this delivery 
service.See http://traffic-control-cdn.readthedocs.io/en/latest/admin/traffic_router.html#rl-deep-cache\;
 target=\"_blank\">Deep Caching for more details..."
+"desc": "Enables clients to be routed to the closest possible deep 
edge caches on a per Delivery Service basis.http://traffic-control-cdn.readthedocs.io/en/latest/admin/traffic_router.html#rl-deep-cache\;
 target=\"_blank\">See Deep Caching"
   },
   "displayName": {
 "title": "Display Name",
-"desc": "A human-readable name for the delivery service."
+"desc": "Name of the service that appears in the Traffic portal. 
No character restrictions."
   },
   "dnsBypassCname": {
 "title": "DNS Bypass CNAME",
-"desc": "Description required"
+"desc": "(For DNS routed delivery services only) Domain name to 
overflow requests when the the max Bps or Max Tps for this delivery service are 
exceeded."
 
 Review comment:
   again, the (For DNS routed delivery services only) is redundant. and a 
couple typos in here.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mitchell852 commented on a change in pull request #2236: update portal info bubbles

[GitBox]

mitchell852 commented on a change in pull request #2236: update portal info 
bubbles
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2236#discussion_r187351587
 
 

 ##
 File path: traffic_portal/app/src/traffic_portal_properties.json
 ##
 @@ -178,71 +178,71 @@
   "_comments": "This is the text used to configure delivery service 
field titles/descriptions",
   "active": {
 "title": "Active",
-"desc": "When this is set to false Traffic Router will not serve 
DNS or HTTP responses for this delivery service."
+"desc": "Whether or not this delivery service is active on the CDN 
and is capable of traffic."
   },
   "cacheurl": {
 "title": "Cache URL expression",
-"desc": "Cache URL rule to apply to this delivery 
service.See https://docs.trafficserver.apache.org/en/latest/admin-guide/plugins/cacheurl.en.html\;
 target=\"_blank\">ATS documentation on cacheurl..."
+"desc": "Allows you to manipulate the cache key of the incoming 
requests. Normally, the cache key is the origin domain. This can be changed so 
that multiple services can share a cache key, can also be used to preserve 
cached content if service origin is changed.Note: Only valid in ATS 
6. X and earlier. Must be empty if using ATS 7. X and / or the https://docs.trafficserver.apache.org/en/latest/admin-guide/plugins/cachekey.en.html\;
 target=\"_blank\">cachekey plugin.See https://docs.trafficserver.apache.org/en/6.2.x/admin-guide/plugins/cacheurl.en.html\;
 target=\"_blank\">ATS documentation on cacheurl "
   },
   "ccrDnsTtl": {
 "title": "Delivery Service DNS TTL",
-"desc": "The Time To Live on the DNS record for the Traffic Router 
A and  records."
+"desc": "(For DNS routed delivery services only) The Time To Live 
on the DNS record for the Traffic Router A and  records. Default value is 
30 seconds. Setting too high or too low will result in poor caching 
performance."
   },
   "cdnId": {
 "title": "CDN",
-"desc": "The CDN in which the delivery service belongs to."
+"desc": "The CDN in which the delivery service belongs."
   },
   "checkPath": {
 "title": "Check Path",
 "desc": "A path (ex: /crossdomain.xml) to verify the connection to 
the origin server with. This can be used by Check Extension scripts to do 
periodic health checks against the delivery service."
   },
   "deepCachingType": {
 "title": "Deep Caching",
-"desc": "When to do deep caching for this delivery 
service.See http://traffic-control-cdn.readthedocs.io/en/latest/admin/traffic_router.html#rl-deep-cache\;
 target=\"_blank\">Deep Caching for more details..."
+"desc": "Enables clients to be routed to the closest possible deep 
edge caches on a per Delivery Service basis.http://traffic-control-cdn.readthedocs.io/en/latest/admin/traffic_router.html#rl-deep-cache\;
 target=\"_blank\">See Deep Caching"
   },
   "displayName": {
 "title": "Display Name",
-"desc": "A human-readable name for the delivery service."
+"desc": "Name of the service that appears in the Traffic portal. 
No character restrictions."
   },
   "dnsBypassCname": {
 "title": "DNS Bypass CNAME",
-"desc": "Description required"
+"desc": "(For DNS routed delivery services only) Domain name to 
overflow requests when the the max Bps or Max Tps for this delivery service are 
exceeded."
   },
   "dnsBypassIp": {
 "title": "DNS Bypass IP",
-"desc": "This is the address to respond to A requests with when 
the max Bps or Max Tps for this delivery service are exceeded."
+"desc": "(For DNS routed delivery services only) IPv4 address to 
overflow requests when the the max Bps or Max Tps for this delivery service are 
exceeded."
   },
   "dnsBypassIp6": {
 "title": "DNS Bypass IPv6",
-"desc": "This is the address to respond to  requests with when 
the max Bps or Max Tps for this delivery service are exceeded."
+"desc": "(For DNS routed delivery services only) IPv6 address to 
overflow requests when the the max Bps or Max Tps for this delivery service are 
exceeded."
   },
   "dnsBypassTtl": {
 "title": "DNS Bypass TTL",
-"desc": "Description required"
+"desc": "TTL for the DNS bypass domain or IP when threshold 
exceeded."
   },
   "dscp": {
-"title": "DSCP",
-"desc": "The DSCP value to mark IP packets to the client with."
+"title": "DSCP Tag",
+"desc": "The Differentiated Services Code Point (DSCP) value to 
mark IP packets to the client with."
   },
   

[GitHub] mitchell852 commented on a change in pull request #2236: update portal info bubbles

[GitBox]

mitchell852 commented on a change in pull request #2236: update portal info 
bubbles
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2236#discussion_r187352782
 
 

 ##
 File path: traffic_portal/app/src/traffic_portal_properties.json
 ##
 @@ -252,49 +252,49 @@
 "title": "Global Max TPS",
 "desc": "The maximum transactions this delivery service can serve 
across all EDGE caches before traffic will be diverted to the bypass 
destination. For a DNS delivery service, the Bypass Ipv4 or Ipv6 will be used 
(depending on whether this was a A or  request), and for HTTP delivery 
services the Bypass FQDN will be used."
   },
- "fqPacingRate": {
-   "title": "Fair Queuing Pacing Rate Bps",
+  "fqPacingRate": {
+"title": "Fair Queuing Pacing Rate Bps",
 "desc": "The maximum bytes per second a cache will delivery on any 
single TCP connection. This uses the Linux kernel's Fair Queuing 
setsockopt(SO_MAX_PACING_RATE) to limit the rate of delivery."
-  },
+  },
   "httpBypassFqdn": {
 "title": "HTTP Bypass FQDN",
 "desc": "This is the FQDN Traffic Router will redirect to (with 
the same path) when the max Bps or Max Tps for this delivery service are 
exceeded."
   },
   "infoUrl": {
 "title": "Info URL",
-"desc": "Info URL for this delivery service."
+"desc": "Free text field allowing you to enter a URL which 
provides information about the service. To be consumed from the APIs by 
downstream tools."
   },
   "initialDispersion": {
 "title": "Initial Dispersion",
-"desc": "Description required"
+"desc": "This is available only for HTTP Content Routing Types. 
Determines number of machines content will be placed on within a cache group. 
Default is 1, Setting too high will result in poor caching performance."
   },
   "ipv6RoutingEnabled": {
 "title": "IPv6 Routing Enabled",
 "desc": "When set to true, the Traffic Router will respond to  
DNS requests for the routed name of this delivery service. Otherwise, only A 
records will be served."
   },
   "logsEnabled": {
 "title": "Logs Enabled",
-"desc": "Description required"
+"desc": "Allows you to turn on/off logging for the service"
   },
   "longDesc": {
 "title": "Long Description",
-"desc": "Long description for this delivery service."
+"desc": "A short text field that describes the purpose of the 
delivery service and will be displayed in the portal as a description field. 
For example, you can use this field to describe your service. To be consumed 
from the APIs by downstream tools."
 
 Review comment:
   typo. No need to discuss who the consumer is.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: incubator-trafficcontrol-rat #712

[Apache Jenkins Server]

See 


--
Started by upstream project "incubator-trafficcontrol-master-build" build 
number 756
originally caused by:
 Started by an SCM change
[EnvInject] - Loading node environment variables.
Building remotely on H28 (ubuntu xenial) in workspace 

[incubator-trafficcontrol-rat] $ /bin/bash -xe 
/tmp/jenkins3678051655469749447.sh
+ rm -rf 

 

 '
[operations-center-context] Requesting copy of artifacts matching '**/*.tar.gz' 
from 'Last successful build (either stable or unstable)' of 
incubator-trafficcontrol-master-build
[operations-center-context] Copied 1 artifacts matching '**/*.tar.gz' from 
'Last successful build (either stable or unstable)' of 
incubator-trafficcontrol-master-build:
[operations-center-context]   apache-trafficcontrol-2.3.0-incubating.tar.gz
[incubator-trafficcontrol-rat] $ /bin/bash -xe 
/tmp/jenkins4270416107689623169.sh
+ set -exu
++ ls apache-trafficcontrol-2.3.0-incubating.tar.gz
+ tarball=apache-trafficcontrol-2.3.0-incubating.tar.gz
+ tar xzf apache-trafficcontrol-2.3.0-incubating.tar.gz
++ pwd
++ basename apache-trafficcontrol-2.3.0-incubating.tar.gz .tar.gz
+ 
tcdir=
+ cd 

++ date +%Y
+ egrep 'Copyright .*-?2018 The Apache Software Foundation' NOTICE
Copyright 2016-2018 The Apache Software Foundation
+ set +x
Searching for class files:
PASSED: No class files found.
Searching for jar files:
PASSED: No jar files found.
Searching for tar files:
PASSED: No tar files found.
Searching for tgz files:
PASSED: No tgz files found.
Searching for zip files:
PASSED: No zip files found.
++ curl 
https://repository.apache.org/content/repositories/snapshots/org/apache/rat/apache-rat/0.13-SNAPSHOT/
 -sN
++ grep jar
++ grep -ve md5 -e sha1
++ awk -F '"' '{print $2}'
++ sort -r
++ cut -d / -f 12
++ head -n 1
+ ratver=apache-rat-0.13-20180329.151017-101.jar
++ mktemp -d
+ ratdir=/tmp/tmp.qTP0AyzSSN
+ ratjar=/tmp/tmp.qTP0AyzSSN/apache-rat-0.13.SNAPSHOT.jar
+ curl -L -o /tmp/tmp.qTP0AyzSSN/apache-rat-0.13.SNAPSHOT.jar 
https://repository.apache.org/content/repositories/snapshots/org/apache/rat/apache-rat/0.13-SNAPSHOT/apache-rat-0.13-20180329.151017-101.jar
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0 
26 1587k   26  416k0 0   465k  0  0:00:03 --:--:--  0:00:03  
465k100 1587k  100 1587k0 0  1634k  0 --:--:-- --:--:-- --:--:-- 
1633k
+ curl -L -o /tmp/tmp.qTP0AyzSSN/apache-rat-0.13.SNAPSHOT.jar.sha1 
https://repository.apache.org/content/repositories/snapshots/org/apache/rat/apache-rat/0.13-SNAPSHOT/apache-rat-0.13-20180329.151017-101.jar.sha1
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 
010040  100400 0 75  0 --:--:-- --:--:-- --:--:--75
++ sha1sum /tmp/tmp.qTP0AyzSSN/apache-rat-0.13.SNAPSHOT.jar
++ awk '{print $1}'
++ cat /tmp/tmp.qTP0AyzSSN/apache-rat-0.13.SNAPSHOT.jar.sha1
+ [[ 635c5eccad31cff1d713c12144eaae7fc9f10cf4 == 
635c5eccad31cff1d713c12144eaae7fc9f10cf4 ]]
++ pwd
++ pwd
+ java -jar /tmp/tmp.qTP0AyzSSN/apache-rat-0.13.SNAPSHOT.jar -E 

 -d 

+ rm -rf /tmp/tmp.qTP0AyzSSN
++ perl -lne 'print $1 if /(\d+) Unknown Licenses/' ratreport.txt
+ unknown=56
+ [[ 56 != 0 ]]
+ echo '56 Unknown Licenses'
56 Unknown Licenses
+ perl -lne 'print if /Files with unapproved licenses:/ .. /^\*\*\*/' 
ratreport.txt
+ sed s:::
Files with unapproved licenses:

  
apache-trafficcontrol-2.3.0-incubating/grove/vendor/code.cloudfoundry.org/bytefmt/bytes.go
  
apache-trafficcontrol-2.3.0-incubating/grove/vendor/code.cloudfoundry.org/bytefmt/bytes_test.go
  
apache-trafficcontrol-2.3.0-incubating/grove/vendor/code.cloudfoundry.org/bytefmt/formatters_suite_test.go
  

[GitHub] knutsel closed issue #1973: Default Traffic Monitor Port is 8080 but docs and TR reference 80

[GitBox]

knutsel closed issue #1973: Default Traffic Monitor Port is 8080 but docs and 
TR reference 80
URL: https://github.com/apache/incubator-trafficcontrol/issues/1973
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rob05c commented on issue #2250: MonitorConfigPoller panic: runtime error: invalid memory address or nil pointer dereference

[GitBox]

rob05c commented on issue #2250: MonitorConfigPoller panic: runtime error: 
invalid memory address or nil pointer dereference
URL: 
https://github.com/apache/incubator-trafficcontrol/issues/2250#issuecomment-388070126
 
 
   We've seen this before, but very rarely, and only in the lab. 
   
   This was added, to dump the stacktrace when it happens, to tell us where it 
is:
   https://github.com/apache/incubator-trafficcontrol/pull/1894 
   https://github.com/apache/incubator-trafficcontrol/commit/8227159
   
   But we haven't seen it since that was added. If possible, can you apply that 
changeset? If you can get it to panic with that changeset, it should tell us 
where the panic is so we can fix it.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mitchell852 commented on issue #2029: [Issue 1907] TO API for backup edge cachegroup

[GitBox]

mitchell852 commented on issue #2029: [Issue 1907] TO API for backup edge 
cachegroup
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2029#issuecomment-388070098
 
 
   I still don't agree with how the POST and PUT works. In my  opinion, a POST 
should add fallbacks and a PUT should update existing fallbacks. This is how 
the rest of the API works.
   
   For example:
   
   POST /api/1.2/cachegroup_fallbacks [ fallback11, fallback12 ] <-- if there 
are already 10 fallbacks for cg1, add 2 more to the list making 12 fallbacks 
for cg1
   
   PUT /api/1.2/cachegroup_fallbacks [ fallback11, fallback12 ] <-- go find 
fallback11 and fallback12 and update them
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rob05c commented on issue #2251: Traffic Monitor still starting, some caches unpolled

[GitBox]

rob05c commented on issue #2251: Traffic Monitor still starting, some caches 
unpolled
URL: 
https://github.com/apache/incubator-trafficcontrol/issues/2251#issuecomment-388068010
 
 
   >monitor config server cdn1cdedge0001 profile EDGE_VM_713 has no polling URL
   
   We've seen a similar event, when changing the profile of a cache. I'm 
guessing you renamed a profile. So, the `CRConfig.json` still has the server 
with the old profile, while `monitoring.json` which contains the polling URLs 
doesn't have that profile.
   
   You're right, fundamentally, this should not cause the Monitor to fail to 
start. But at the same time, the Monitor does need to fail to start, if it 
can't poll all caches -- otherwise, it may give bad data to the Router.
   
   The real issue is that some data is raw, and some is snapshotted. We really 
need to snapshot all data, the Monitor and Router should never get raw data 
from TO.
   
   I think this is a duplicate of 
https://github.com/apache/incubator-trafficcontrol/issues/1738


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rob05c commented on issue #2251: Traffic Monitor still starting, some caches unpolled

[GitBox]

rob05c commented on issue #2251: Traffic Monitor still starting, some caches 
unpolled
URL: 
https://github.com/apache/incubator-trafficcontrol/issues/2251#issuecomment-388068010
 
 
   >monitor config server cdn1cdedge0001 profile EDGE_VM_713 has no polling URL
   We've seen a similar event, when changing the profile of a cache. I'm 
guessing you renamed a profile. So, the `CRConfig.json` still has the server 
with the old profile, while `monitoring.json` which contains the polling URLs 
doesn't have that profile.
   
   You're right, fundamentally, this should not cause the Monitor to fail to 
start. But at the same time, the Monitor does need to fail to start, if it 
can't poll all caches -- otherwise, it may give bad data to the Router.
   
   The real issue is that some data is raw, and some is snapshotted. We really 
need to snapshot all data, the Monitor and Router should never get raw data 
from TO.
   
   I think this is a duplicate of 
https://github.com/apache/incubator-trafficcontrol/issues/1738


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: incubator-trafficcontrol-PR-rat #827

[Apache Jenkins Server]

See 


--
Started by upstream project "incubator-trafficcontrol-PR" build number 1545
originally caused by:
 GitHub pull request #2253 of commit eee05c332c86bcd0d9292c6cb4b0115ebaabf1d2, 
no merge conflicts.
[EnvInject] - Loading node environment variables.
Building remotely on H28 (ubuntu xenial) in workspace 

[incubator-trafficcontrol-PR-rat] $ /bin/bash -xe 
/tmp/jenkins2394215764900889237.sh
+ rm -rf 

 

 '
[operations-center-context] Requesting copy of artifacts matching '**/*.tar.gz' 
from 'Last successful build (either stable or unstable)' of 
incubator-trafficcontrol-PR
[operations-center-context] Copied 1 artifacts matching '**/*.tar.gz' from 
'Last successful build (either stable or unstable)' of 
incubator-trafficcontrol-PR:
[operations-center-context]   apache-trafficcontrol-2.3.0-incubating.tar.gz
[incubator-trafficcontrol-PR-rat] $ /bin/bash -xe 
/tmp/jenkins7677968712246613988.sh
+ set -exu
++ ls apache-trafficcontrol-2.3.0-incubating.tar.gz
+ tarball=apache-trafficcontrol-2.3.0-incubating.tar.gz
+ tar xzf apache-trafficcontrol-2.3.0-incubating.tar.gz
++ pwd
++ basename apache-trafficcontrol-2.3.0-incubating.tar.gz .tar.gz
+ 
tcdir=
+ cd 

++ date +%Y
+ egrep 'Copyright .*-?2018 The Apache Software Foundation' NOTICE
Copyright 2016-2018 The Apache Software Foundation
+ set +x
Searching for class files:
PASSED: No class files found.
Searching for jar files:
PASSED: No jar files found.
Searching for tar files:
PASSED: No tar files found.
Searching for tgz files:
PASSED: No tgz files found.
Searching for zip files:
PASSED: No zip files found.
++ curl 
https://repository.apache.org/content/repositories/snapshots/org/apache/rat/apache-rat/0.13-SNAPSHOT/
 -sN
++ grep jar
++ grep -ve md5 -e sha1
++ head -n 1
++ cut -d / -f 12
++ sort -r
++ awk -F '"' '{print $2}'
+ ratver=apache-rat-0.13-20180329.151017-101.jar
++ mktemp -d
+ ratdir=/tmp/tmp.Q3qgGewODN
+ ratjar=/tmp/tmp.Q3qgGewODN/apache-rat-0.13.SNAPSHOT.jar
+ curl -L -o /tmp/tmp.Q3qgGewODN/apache-rat-0.13.SNAPSHOT.jar 
https://repository.apache.org/content/repositories/snapshots/org/apache/rat/apache-rat/0.13-SNAPSHOT/apache-rat-0.13-20180329.151017-101.jar
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0 
26 1587k   26  421k0 0   482k  0  0:00:03 --:--:--  0:00:03  
482k100 1587k  100 1587k0 0  1678k  0 --:--:-- --:--:-- --:--:-- 
1677k
+ curl -L -o /tmp/tmp.Q3qgGewODN/apache-rat-0.13.SNAPSHOT.jar.sha1 
https://repository.apache.org/content/repositories/snapshots/org/apache/rat/apache-rat/0.13-SNAPSHOT/apache-rat-0.13-20180329.151017-101.jar.sha1
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 
010040  100400 0 76  0 --:--:-- --:--:-- --:--:--77
++ sha1sum /tmp/tmp.Q3qgGewODN/apache-rat-0.13.SNAPSHOT.jar
++ awk '{print $1}'
++ cat /tmp/tmp.Q3qgGewODN/apache-rat-0.13.SNAPSHOT.jar.sha1
+ [[ 635c5eccad31cff1d713c12144eaae7fc9f10cf4 == 
635c5eccad31cff1d713c12144eaae7fc9f10cf4 ]]
++ pwd
++ pwd
+ java -jar /tmp/tmp.Q3qgGewODN/apache-rat-0.13.SNAPSHOT.jar -E 

 -d 

+ rm -rf /tmp/tmp.Q3qgGewODN
++ perl -lne 'print $1 if /(\d+) Unknown Licenses/' ratreport.txt
+ unknown=56
+ [[ 56 != 0 ]]
+ echo '56 Unknown Licenses'
56 Unknown Licenses
+ perl -lne 'print if /Files with unapproved licenses:/ .. /^\*\*\*/' 
ratreport.txt
+ sed s:::
Files with unapproved licenses:

  
apache-trafficcontrol-2.3.0-incubating/grove/vendor/code.cloudfoundry.org/bytefmt/bytes.go
  
apache-trafficcontrol-2.3.0-incubating/grove/vendor/code.cloudfoundry.org/bytefmt/bytes_test.go
  
apache-trafficcontrol-2.3.0-incubating/grove/vendor/code.cloudfoundry.org/bytefmt/formatters_suite_test.go
  

[GitHub] asfgit commented on issue #2253: Updating schema to sslkeys

[GitBox]

asfgit commented on issue #2253: Updating schema to sslkeys
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2253#issuecomment-388067254
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/incubator-trafficcontrol-PR/1545/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] smalenfant opened a new pull request #2253: Updating schema to sslkeys

[GitBox]

smalenfant opened a new pull request #2253: Updating schema to sslkeys
URL: https://github.com/apache/incubator-trafficcontrol/pull/2253
 
 
   Closes #2252


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] smalenfant opened a new issue #2252: Traffic Vault sslkeys.xml schema name incorrect

[GitBox]

smalenfant opened a new issue #2252: Traffic Vault sslkeys.xml schema name 
incorrect
URL: https://github.com/apache/incubator-trafficcontrol/issues/2252
 
 
   Should this schema read "sslkeys" ?
   
   
https://github.com/apache/incubator-trafficcontrol/blob/ad102f35f046ab63fc84b61f8481f7e5e056777a/traffic_ops/app/conf/misc/riak_search/sslkeys.xml#L22


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] smalenfant commented on issue #2251: Traffic Monitor still starting, some caches unpolled

[GitBox]

smalenfant commented on issue #2251: Traffic Monitor still starting, some 
caches unpolled
URL: 
https://github.com/apache/incubator-trafficcontrol/issues/2251#issuecomment-388045919
 
 
   I think part of the problem is that a CR-Config was not executed after 
changing the profile. cdn1cdedge0001 profile in Traffic Ops and CR-Config isn't 
matching. But I believe this should not prevent traffic monitor from starting.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] smalenfant opened a new issue #2251: Traffic Monitor still starting, some caches unpolled

[GitBox]

smalenfant opened a new issue #2251: Traffic Monitor still starting, some 
caches unpolled
URL: https://github.com/apache/incubator-trafficcontrol/issues/2251
 
 
   I have an edge cache that's currently being built. I restarted Traffic 
Monitor and after 10 minutes it still haven't started.
   
   Version: traffic_monitor-2.2.0-7731.6ea85056.el7.x86_64
   
   Not sure if this is by design or a bug, but different behavior than the java 
version.
   
   ```
   ERROR: datareq.go:261: 2018-05-10T12:52:12.739231563Z: Request Error: 
/publish/CrStates: service still starting, some caches unpolled: 
map[cdn1cdedge0001:{}]
   ERROR: datareq.go:261: 2018-05-10T12:52:13.709375974Z: Request Error: 
/publish/CrStates: service still starting, some caches unpolled: 
map[cdn1cdedge0001:{}]
   ERROR: datareq.go:261: 2018-05-10T12:52:13.711937723Z: Request Error: 
/publish/CrStates: service still starting, some caches unpolled: 
map[cdn1cdedge0001:{}]
   ERROR: datareq.go:261: 2018-05-10T12:52:14.115835758Z: Request Error: 
/api/bandwidth-capacity-kbps: service still starting, some caches unpolled: 
map[cdn1cdedge0001:{}]
   ERROR: datareq.go:261: 2018-05-10T12:52:14.206949351Z: Request Error: 
/api/bandwidth-kbps: service still starting, some caches unpolled: 
map[cdn1cdedge0001:{}]
   ERROR: asm_amd64.s:2197: 2018-05-10T12:52:14.280999564Z: monitor config 
server cdn1cdedge0001 profile EDGE_VM_713 has no polling URL; can't poll
   ERROR: datareq.go:261: 2018-05-10T12:52:14.375944312Z: Request Error: 
/publish/EventLog: service still starting, some caches unpolled: 
map[cdn1cdedge0001:{}]
   ERROR: datareq.go:261: 2018-05-10T12:52:14.403802012Z: Request Error: 
/publish/CrStates: service still starting, some caches unpolled: 
map[cdn1cdedge0001:{}]
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] smalenfant opened a new issue #2250: MonitorConfigPoller panic: runtime error: invalid memory address or nil pointer dereference

[GitBox]

smalenfant opened a new issue #2250: MonitorConfigPoller panic: runtime error: 
invalid memory address or nil pointer dereference
URL: https://github.com/apache/incubator-trafficcontrol/issues/2250
 
 
   Traffic Monitor crash and exited. I don't have much details except that 
procNetDev was not returning from astats json output.
   
   From traffic_monitor.log:
   
   ```
   ERROR: cache.go:325: 2018-04-16T17:08:34.339643848Z: precomputeAstats 
psp6cdedge03 handle precomputing outbytes 'procNetDev empty'
   ERROR: stat.go:87: 2018-04-16T17:08:34.351132976Z: stat poll getting vitals 
for psp6cdedge03: Error parsing procnetdev: no fields found
   ERROR: cache.go:325: 2018-04-16T17:08:42.098836427Z: precomputeAstats 
psp6cdedge03 handle precomputing outbytes 'procNetDev empty'
   ERROR: stat.go:87: 2018-04-16T17:08:42.10609049Z: stat poll getting vitals 
for psp6cdedge03: Error parsing procnetdev: no fields found
   ERROR: asm_amd64.s:2197: 2018-04-18T01:31:26.283370864Z: 
MonitorConfigPoller: getting monitor config map: Get 
https://cdn1cdcms0001.coxlab.net/api/1.2/cdns/cdn1/configs/monitoring.json: 
net/http: request canceled (Client.Timeout exceeded while awaiting headers)

   ERROR: asm_amd64.s:514: 2018-04-28T05:30:01.733534769Z: MonitorConfigPoller 
panic: runtime error: invalid memory address or nil pointer dereference
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services