[GitHub] rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go

rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go URL: https://github.com/apache/incubator-trafficcontrol/pull/2269#discussion_r188115566 ## File path: traffic_ops/traffic_ops_golang/deliveryservice/servers/servers.go ## @@ -2

[GitHub] rob05c opened a new pull request #2270: Add TO Go Servers Details endpoint

rob05c opened a new pull request #2270: Add TO Go Servers Details endpoint URL: https://github.com/apache/incubator-trafficcontrol/pull/2270 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go

rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go URL: https://github.com/apache/incubator-trafficcontrol/pull/2269#discussion_r188118026 ## File path: traffic_ops/traffic_ops_golang/deliveryservice/servers/servers.go ## @@ -9

[GitHub] rob05c commented on issue #2232: Rewrite Traffic Ops CRConfig Table Endpoints in Go

rob05c commented on issue #2232: Rewrite Traffic Ops CRConfig Table Endpoints in Go URL: https://github.com/apache/incubator-trafficcontrol/issues/2232#issuecomment-387444293 Ok, we have PRs for all major table routes, but many of them are only "CRUD", and missing additional endpoints. So

[GitHub] rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go

rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go URL: https://github.com/apache/incubator-trafficcontrol/pull/2269#discussion_r188116061 ## File path: traffic_ops/traffic_ops_golang/deliveryservice/servers/servers.go ## @@ -3

[GitHub] rob05c commented on a change in pull request #2246: Add HitCount and FreshFor

rob05c commented on a change in pull request #2246: Add HitCount and FreshFor URL: https://github.com/apache/incubator-trafficcontrol/pull/2246#discussion_r188119204 ## File path: grove/plugin/http_cacheinspector.go ## @@ -169,16 +170,17 @@ func cacheinspect(icfg interface

[GitHub] rob05c commented on a change in pull request #2246: Add HitCount and FreshFor

rob05c commented on a change in pull request #2246: Add HitCount and FreshFor URL: https://github.com/apache/incubator-trafficcontrol/pull/2246#discussion_r188120447 ## File path: grove/web/util.go ## @@ -198,3 +200,145 @@ func ParseHTTPDate(d string) (time.Time, bool) {

[GitHub] rob05c commented on a change in pull request #2262: Part 1 of Range Request handling

rob05c commented on a change in pull request #2262: Part 1 of Range Request handling URL: https://github.com/apache/incubator-trafficcontrol/pull/2262#discussion_r188121319 ## File path: grove/plugin/plugin.go ## @@ -91,6 +92,12 @@ type BeforeRespondData struct {

[GitHub] rob05c commented on a change in pull request #2262: Part 1 of Range Request handling

rob05c commented on a change in pull request #2262: Part 1 of Range Request handling URL: https://github.com/apache/incubator-trafficcontrol/pull/2262#discussion_r188121450 ## File path: grove/plugin/range_req_handler.go ## @@ -0,0 +1,225 @@ +package plugin + +/* + Lice

[GitHub] rob05c commented on a change in pull request #2262: Part 1 of Range Request handling

rob05c commented on a change in pull request #2262: Part 1 of Range Request handling URL: https://github.com/apache/incubator-trafficcontrol/pull/2262#discussion_r188121571 ## File path: grove/plugin/range_req_handler.go ## @@ -0,0 +1,225 @@ +package plugin + +/* + Lice

[GitHub] rob05c commented on a change in pull request #2262: Part 1 of Range Request handling

rob05c commented on a change in pull request #2262: Part 1 of Range Request handling URL: https://github.com/apache/incubator-trafficcontrol/pull/2262#discussion_r188121571 ## File path: grove/plugin/range_req_handler.go ## @@ -0,0 +1,225 @@ +package plugin + +/* + Lice

[GitHub] rob05c commented on a change in pull request #2262: Part 1 of Range Request handling

rob05c commented on a change in pull request #2262: Part 1 of Range Request handling URL: https://github.com/apache/incubator-trafficcontrol/pull/2262#discussion_r188121895 ## File path: grove/plugin/range_req_handler.go ## @@ -0,0 +1,225 @@ +package plugin + +/* + Lice

[GitHub] rob05c commented on a change in pull request #2262: Part 1 of Range Request handling

rob05c commented on a change in pull request #2262: Part 1 of Range Request handling URL: https://github.com/apache/incubator-trafficcontrol/pull/2262#discussion_r188121922 ## File path: grove/plugin/range_req_handler.go ## @@ -0,0 +1,225 @@ +package plugin + +/* + Lice

[GitHub] rob05c commented on a change in pull request #2262: Part 1 of Range Request handling

rob05c commented on a change in pull request #2262: Part 1 of Range Request handling URL: https://github.com/apache/incubator-trafficcontrol/pull/2262#discussion_r188122792 ## File path: grove/plugin/range_req_handler.go ## @@ -0,0 +1,225 @@ +package plugin + +/* + Lice

[GitHub] asfgit commented on issue #2270: Add TO Go Servers Details endpoint

asfgit commented on issue #2270: Add TO Go Servers Details endpoint URL: https://github.com/apache/incubator-trafficcontrol/pull/2270#issuecomment-388989863 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontr

[GitHub] asfgit commented on issue #2247: Add an Origin API

asfgit commented on issue #2247: Add an Origin API URL: https://github.com/apache/incubator-trafficcontrol/pull/2247#issuecomment-388997317 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR/1569/ Te

[GitHub] asfgit commented on issue #2247: Add an Origin API

asfgit commented on issue #2247: Add an Origin API URL: https://github.com/apache/incubator-trafficcontrol/pull/2247#issuecomment-388998048 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR/1570/ Te

[GitHub] asfgit commented on issue #2088: TO Go: implement tenants CRUD

asfgit commented on issue #2088: TO Go: implement tenants CRUD URL: https://github.com/apache/incubator-trafficcontrol/pull/2088#issuecomment-389032173 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR

[GitHub] asfgit commented on issue #2088: TO Go: implement tenants CRUD

asfgit commented on issue #2088: TO Go: implement tenants CRUD URL: https://github.com/apache/incubator-trafficcontrol/pull/2088#issuecomment-389036164 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR

[GitHub] knutsel commented on a change in pull request #2246: Add HitCount and FreshFor

knutsel commented on a change in pull request #2246: Add HitCount and FreshFor URL: https://github.com/apache/incubator-trafficcontrol/pull/2246#discussion_r188269492 ## File path: grove/web/util.go ## @@ -198,3 +200,145 @@ func ParseHTTPDate(d string) (time.Time, bool) {

[GitHub] mitchell852 opened a new pull request #2271: if user.role == admin, then allow the option to immediately fulfill DSR (d…

mitchell852 opened a new pull request #2271: if user.role == admin, then allow the option to immediately fulfill DSR (d… URL: https://github.com/apache/incubator-trafficcontrol/pull/2271 …elivery service requests) fixes #2174

[GitHub] mitchell852 commented on issue #2174: TO/TP should allow for a configuration such that admins do not have to submit DSRs

mitchell852 commented on issue #2174: TO/TP should allow for a configuration such that admins do not have to submit DSRs URL: https://github.com/apache/incubator-trafficcontrol/issues/2174#issuecomment-389181872 Implemented as such: If DSR is enabled and user.role=admin, then DSR is

[GitHub] mitchell852 commented on issue #2029: [Issue 1907] TO API for backup edge cachegroup

mitchell852 commented on issue #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#issuecomment-389185605 yes to last comment. that way POST is reserved for creating and PUT is reserved for updating and they don’t overlap

[GitHub] asfgit commented on issue #2271: if user.role == admin, then allow the option to immediately fulfill DSR (d…

asfgit commented on issue #2271: if user.role == admin, then allow the option to immediately fulfill DSR (d… URL: https://github.com/apache/incubator-trafficcontrol/pull/2271#issuecomment-389192028 Refer to this link for build results (access rights to CI server needed): https://bu

[GitHub] rob05c commented on a change in pull request #2262: Part 1 of Range Request handling

rob05c commented on a change in pull request #2262: Part 1 of Range Request handling URL: https://github.com/apache/incubator-trafficcontrol/pull/2262#discussion_r188314219 ## File path: grove/plugin/range_req_handler.go ## @@ -0,0 +1,225 @@ +package plugin + +/* + Lice

[GitHub] mitchell852 commented on issue #2029: [Issue 1907] TO API for backup edge cachegroup

mitchell852 commented on issue #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#issuecomment-389192781 this seems ok from an api perspective. need someone to review/test the TR part. @rawlinp @rivasj @elsloo @aj

[GitHub] mitchell852 commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup

mitchell852 commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#discussion_r188315094 ## File path: traffic_ops/app/lib/UI/Topology.pm ## @@ -250,6 +250,15 @@ sub gen

[GitHub] mitchell852 commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup

mitchell852 commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#discussion_r188317346 ## File path: traffic_ops/app/db/migrations/2018032100_cache_group_fallback.sql

[GitHub] rob05c commented on a change in pull request #2246: Add HitCount and FreshFor

rob05c commented on a change in pull request #2246: Add HitCount and FreshFor URL: https://github.com/apache/incubator-trafficcontrol/pull/2246#discussion_r188317853 ## File path: grove/web/util.go ## @@ -198,3 +200,145 @@ func ParseHTTPDate(d string) (time.Time, bool) {

[GitHub] rob05c commented on a change in pull request #2246: Add HitCount and FreshFor

rob05c commented on a change in pull request #2246: Add HitCount and FreshFor URL: https://github.com/apache/incubator-trafficcontrol/pull/2246#discussion_r188317853 ## File path: grove/web/util.go ## @@ -198,3 +200,145 @@ func ParseHTTPDate(d string) (time.Time, bool) {

[GitHub] elsloo opened a new issue #2272: Only create/update/modify DNSSEC keys for DS types that are routed on the CDN

elsloo opened a new issue #2272: Only create/update/modify DNSSEC keys for DS types that are routed on the CDN URL: https://github.com/apache/incubator-trafficcontrol/issues/2272 Create DNSSEC keys only for DS types that are routed on the CDN, such as any HTTP or DNS type. ANY_MAP, or othe

[GitHub] asfgit commented on issue #2236: update portal info bubbles

asfgit commented on issue #2236: update portal info bubbles URL: https://github.com/apache/incubator-trafficcontrol/pull/2236#issuecomment-389209826 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR/15

[GitHub] asfgit commented on issue #2010: Go login

asfgit commented on issue #2010: Go login URL: https://github.com/apache/incubator-trafficcontrol/pull/2010#issuecomment-389214762 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR/1575/ Test PASSed

[GitHub] rawlinp opened a new issue #2273: TO golang API framework tenancy enhancements

rawlinp opened a new issue #2273: TO golang API framework tenancy enhancements URL: https://github.com/apache/incubator-trafficcontrol/issues/2273 While working on the Origin API, I found a few things related to tenancy in the TO golang API framework that should be enhanced: 1. The s

[GitHub] rob05c commented on a change in pull request #2262: Part 1 of Range Request handling

rob05c commented on a change in pull request #2262: Part 1 of Range Request handling URL: https://github.com/apache/incubator-trafficcontrol/pull/2262#discussion_r188122792 ## File path: grove/plugin/range_req_handler.go ## @@ -0,0 +1,225 @@ +package plugin + +/* + Lice

[GitHub] rawlinp commented on issue #886: [TC-287] Add support for per-Delivery Service routing/name

rawlinp commented on issue #886: [TC-287] Add support for per-Delivery Service routing/name URL: https://github.com/apache/incubator-trafficcontrol/issues/886#issuecomment-389292459 This can be closed - implemented in #865 T

[GitHub] mitchell852 closed issue #886: [TC-287] Add support for per-Delivery Service routing/name

mitchell852 closed issue #886: [TC-287] Add support for per-Delivery Service routing/name URL: https://github.com/apache/incubator-trafficcontrol/issues/886 This is an automated message from the Apache Git Service. To respon

[GitHub] jhg03a closed issue #2263: Improve TO Client Library Documentation

jhg03a closed issue #2263: Improve TO Client Library Documentation URL: https://github.com/apache/incubator-trafficcontrol/issues/2263 This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] jhg03a opened a new issue #2274: Profiles endpoint unordered

jhg03a opened a new issue #2274: Profiles endpoint unordered URL: https://github.com/apache/incubator-trafficcontrol/issues/2274 With the Golang rewrite, the profiles endpoint is no longer ordered by name. This makes the dialogs such as in delivery services more difficult to navigate. ---

[GitHub] dneuman64 opened a new issue #2275: Download ISO should actually download the ISO

dneuman64 opened a new issue #2275: Download ISO should actually download the ISO URL: https://github.com/apache/incubator-trafficcontrol/issues/2275 Currently, when you generate an ISO you are given a link to download the ISO. If you are running a traffic ops in a HA fashion, it is no gu

[GitHub] rob05c commented on issue #2274: Profiles endpoint unordered

rob05c commented on issue #2274: Profiles endpoint unordered URL: https://github.com/apache/incubator-trafficcontrol/issues/2274#issuecomment-389306244 Ordering in the database can be expensive, and the API has never guaranteed order. See https://github.com/apache/incubator-trafficcontrol/

[GitHub] asfgit commented on issue #2247: Add an Origin API

asfgit commented on issue #2247: Add an Origin API URL: https://github.com/apache/incubator-trafficcontrol/pull/2247#issuecomment-389307651 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR/1576/ Te

[GitHub] rivasj opened a new pull request #2276: Migration to add anonymousBlockingEnabled field to deliveryservice_request json blob data

rivasj opened a new pull request #2276: Migration to add anonymousBlockingEnabled field to deliveryservice_request json blob data URL: https://github.com/apache/incubator-trafficcontrol/pull/2276 Add anonymousBlockingEnabled field to deliveryservice_request json blob data in db (deliveryse

[GitHub] asfgit commented on issue #2276: Migration to add anonymousBlockingEnabled field to deliveryservice_request json blob data

asfgit commented on issue #2276: Migration to add anonymousBlockingEnabled field to deliveryservice_request json blob data URL: https://github.com/apache/incubator-trafficcontrol/pull/2276#issuecomment-389318472 Can one of the admins verify this patch?

[GitHub] asfgit commented on issue #2276: Migration to add anonymousBlockingEnabled field to deliveryservice_request json blob data

asfgit commented on issue #2276: Migration to add anonymousBlockingEnabled field to deliveryservice_request json blob data URL: https://github.com/apache/incubator-trafficcontrol/pull/2276#issuecomment-389318776 Can one of the admins verify this patch?

[GitHub] asfgit commented on issue #2236: update portal info bubbles

asfgit commented on issue #2236: update portal info bubbles URL: https://github.com/apache/incubator-trafficcontrol/pull/2236#issuecomment-389322775 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR/15

[GitHub] asfgit commented on issue #2236: update portal info bubbles

asfgit commented on issue #2236: update portal info bubbles URL: https://github.com/apache/incubator-trafficcontrol/pull/2236#issuecomment-389334635 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR/15

[GitHub] DylanVolz opened a new pull request #2277: Allow the capture group for a route parameter to be defined

DylanVolz opened a new pull request #2277: Allow the capture group for a route parameter to be defined URL: https://github.com/apache/incubator-trafficcontrol/pull/2277 this is done in the form {parameterName:capturePattern} instead of {parameterName} in the route definition in routes.go.

[GitHub] rob05c opened a new pull request #2278: Add TO Go caches/stats endpoint

rob05c opened a new pull request #2278: Add TO Go caches/stats endpoint URL: https://github.com/apache/incubator-trafficcontrol/pull/2278 This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] DylanVolz commented on issue #2273: TO golang API framework tenancy enhancements

DylanVolz commented on issue #2273: TO golang API framework tenancy enhancements URL: https://github.com/apache/incubator-trafficcontrol/issues/2273#issuecomment-389337746 +1 This is an automated message from the Apache G

[GitHub] rob05c commented on issue #2277: Allow the capture group for a route parameter to be defined

rob05c commented on issue #2277: Allow the capture group for a route parameter to be defined URL: https://github.com/apache/incubator-trafficcontrol/pull/2277#issuecomment-389339315 I'm still not convinced this is worth the readability cost. Regex is hard to read. This makes the routes ha

[GitHub] rob05c commented on issue #2277: Allow the capture group for a route parameter to be defined

rob05c commented on issue #2277: Allow the capture group for a route parameter to be defined URL: https://github.com/apache/incubator-trafficcontrol/pull/2277#issuecomment-389339315 I'm still not convinced this is worth the readability cost. Regex is hard to read. This makes the routes ha

[GitHub] rob05c commented on issue #2232: Rewrite Traffic Ops CRConfig Table Endpoints in Go

rob05c commented on issue #2232: Rewrite Traffic Ops CRConfig Table Endpoints in Go URL: https://github.com/apache/incubator-trafficcontrol/issues/2232#issuecomment-387444293 Ok, we have PRs for all major table routes, but many of them are only "CRUD", and missing additional endpoints. So

[GitHub] asfgit commented on issue #2108: create roles crud endpoints in golang

asfgit commented on issue #2108: create roles crud endpoints in golang URL: https://github.com/apache/incubator-trafficcontrol/pull/2108#issuecomment-389347426 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficco

[GitHub] asfgit commented on issue #2278: Add TO Go caches/stats endpoint

asfgit commented on issue #2278: Add TO Go caches/stats endpoint URL: https://github.com/apache/incubator-trafficcontrol/pull/2278#issuecomment-389355518 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-

[GitHub] asfgit commented on issue #2277: Allow the capture group for a route parameter to be defined

asfgit commented on issue #2277: Allow the capture group for a route parameter to be defined URL: https://github.com/apache/incubator-trafficcontrol/pull/2277#issuecomment-389365591 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/

[GitHub] knutsel commented on a change in pull request #2246: Add HitCount and FreshFor

knutsel commented on a change in pull request #2246: Add HitCount and FreshFor URL: https://github.com/apache/incubator-trafficcontrol/pull/2246#discussion_r188635843 ## File path: grove/plugin/http_cacheinspector.go ## @@ -169,16 +170,17 @@ func cacheinspect(icfg interfac

[GitHub] asfgit commented on issue #2246: Add HitCount and FreshFor

asfgit commented on issue #2246: Add HitCount and FreshFor URL: https://github.com/apache/incubator-trafficcontrol/pull/2246#issuecomment-389530137 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR/158

[GitHub] asfgit commented on issue #2246: Add HitCount and FreshFor

asfgit commented on issue #2246: Add HitCount and FreshFor URL: https://github.com/apache/incubator-trafficcontrol/pull/2246#issuecomment-389552212 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR/158

[GitHub] asfgit commented on issue #2246: Add HitCount and FreshFor

asfgit commented on issue #2246: Add HitCount and FreshFor URL: https://github.com/apache/incubator-trafficcontrol/pull/2246#issuecomment-389553758 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR/158

[GitHub] knutsel commented on issue #2246: Add HitCount and FreshFor

knutsel commented on issue #2246: Add HitCount and FreshFor URL: https://github.com/apache/incubator-trafficcontrol/pull/2246#issuecomment-389554197 @rob05c - like this? Sorry that the diff in rfc/rules.go is a bit bigger than needed, hard to get it all in the right place. --

[GitHub] asfgit commented on issue #2247: Add an Origin API

asfgit commented on issue #2247: Add an Origin API URL: https://github.com/apache/incubator-trafficcontrol/pull/2247#issuecomment-389582209 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR/1585/ Te

[GitHub] DylanVolz commented on issue #2243: Routes.go file should include type capture groups to enforce route parameter types

DylanVolz commented on issue #2243: Routes.go file should include type capture groups to enforce route parameter types URL: https://github.com/apache/incubator-trafficcontrol/issues/2243#issuecomment-389624250 After analysis of the legacy routes we will be porting from perl to go this fea

[GitHub] DylanVolz commented on issue #2277: Allow the capture group for a route parameter to be defined

DylanVolz commented on issue #2277: Allow the capture group for a route parameter to be defined URL: https://github.com/apache/incubator-trafficcontrol/pull/2277#issuecomment-389624176 After analysis of the legacy routes we will be porting from perl to go this feature is unnecessary. By f

[GitHub] DylanVolz closed pull request #2277: Allow the capture group for a route parameter to be defined

DylanVolz closed pull request #2277: Allow the capture group for a route parameter to be defined URL: https://github.com/apache/incubator-trafficcontrol/pull/2277 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake o

[GitHub] rob05c closed issue #2243: Routes.go file should include type capture groups to enforce route parameter types

rob05c closed issue #2243: Routes.go file should include type capture groups to enforce route parameter types URL: https://github.com/apache/incubator-trafficcontrol/issues/2243 This is an automated message from the Apache G

[GitHub] jhg03a opened a new issue #2279: Increase server hostname max length

jhg03a opened a new issue #2279: Increase server hostname max length URL: https://github.com/apache/incubator-trafficcontrol/issues/2279 As a CDN SRE I want to be able to supply an arbitrarily long hostname. Today I actually only need 5 more characters, but this seems like a hidden limit

[GitHub] mitchell852 commented on issue #2279: Increase server hostname max length

mitchell852 commented on issue #2279: Increase server hostname max length URL: https://github.com/apache/incubator-trafficcontrol/issues/2279#issuecomment-389652233 Are you referring to the field in traffic portal? This is an

[GitHub] jhg03a commented on issue #2279: Increase server hostname max length

jhg03a commented on issue #2279: Increase server hostname max length URL: https://github.com/apache/incubator-trafficcontrol/issues/2279#issuecomment-389668324 Yes. I am able to enter the data in the old TO interface, but that makes the server editable in the current TP.

[GitHub] jhg03a commented on issue #2279: Increase server hostname max length

jhg03a commented on issue #2279: Increase server hostname max length URL: https://github.com/apache/incubator-trafficcontrol/issues/2279#issuecomment-389668324 Yes. I am able to enter the data in the old TO interface, but that makes the server uneditable in the current TP. --

[GitHub] rawlinp commented on issue #2279: Increase server hostname max length

rawlinp commented on issue #2279: Increase server hostname max length URL: https://github.com/apache/incubator-trafficcontrol/issues/2279#issuecomment-389668866 Yeah I think since the DB type is just `text` we should be able to bump up the artificial limit in TP. -

[GitHub] rob05c opened a new pull request #2280: Fix TO CRconfig changelog

rob05c opened a new pull request #2280: Fix TO CRconfig changelog URL: https://github.com/apache/incubator-trafficcontrol/pull/2280 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] elsloo closed pull request #2280: Fix TO CRconfig changelog

elsloo closed pull request #2280: Fix TO CRconfig changelog URL: https://github.com/apache/incubator-trafficcontrol/pull/2280 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pu

[GitHub] mitchell852 commented on issue #2279: Increase server hostname max length

mitchell852 commented on issue #2279: Increase server hostname max length URL: https://github.com/apache/incubator-trafficcontrol/issues/2279#issuecomment-389673406 there's probably a maxLength attribute in TP. you want to remove that @rawlinp ? --

[GitHub] asfgit commented on issue #2280: Fix TO CRconfig changelog

asfgit commented on issue #2280: Fix TO CRconfig changelog URL: https://github.com/apache/incubator-trafficcontrol/pull/2280#issuecomment-389676041 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR/158

[GitHub] rawlinp opened a new pull request #2281: Increase hostname and domain name length limit in Traffic Portal

rawlinp opened a new pull request #2281: Increase hostname and domain name length limit in Traffic Portal URL: https://github.com/apache/incubator-trafficcontrol/pull/2281 This changes is from 45 to 100. The limit itself could probably be removed altogether since the DB type is `text`, but

[GitHub] rawlinp commented on issue #2279: Increase server hostname max length

rawlinp commented on issue #2279: Increase server hostname max length URL: https://github.com/apache/incubator-trafficcontrol/issues/2279#issuecomment-389679003 Sure, just opened #2281 to increase both limits in TP to 100. Th

[GitHub] asfgit commented on issue #2281: Increase hostname and domain name length limit in Traffic Portal

asfgit commented on issue #2281: Increase hostname and domain name length limit in Traffic Portal URL: https://github.com/apache/incubator-trafficcontrol/pull/2281#issuecomment-389681832 Refer to this link for build results (access rights to CI server needed): https://builds.apache

[GitHub] asfgit commented on issue #1520: Add support for Deep Caching/Routing

asfgit commented on issue #1520: Add support for Deep Caching/Routing URL: https://github.com/apache/incubator-trafficcontrol/pull/1520#issuecomment-359989368 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcon

[GitHub] jhg03a closed issue #1317: Sphinx compilation fails on imgmath extension

jhg03a closed issue #1317: Sphinx compilation fails on imgmath extension URL: https://github.com/apache/incubator-trafficcontrol/issues/1317 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] asfgit commented on issue #1785: TO and TP -- initial implementation of deliveryservice_requests endpoints

asfgit commented on issue #1785: TO and TP -- initial implementation of deliveryservice_requests endpoints URL: https://github.com/apache/incubator-trafficcontrol/pull/1785#issuecomment-360187474 Refer to this link for build results (access rights to CI server needed): https://buil

[GitHub] elsloo closed pull request #1520: Add support for Deep Caching/Routing

elsloo closed pull request #1520: Add support for Deep Caching/Routing URL: https://github.com/apache/incubator-trafficcontrol/pull/1520 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] smalenfant commented on issue #1301: Manage static dns entries

smalenfant commented on issue #1301: Manage static dns entries URL: https://github.com/apache/incubator-trafficcontrol/issues/1301#issuecomment-360242072 @mitchell852 Isn't this already in Traffic Portal? This is an automated

[GitHub] asfgit commented on issue #1785: TO and TP -- initial implementation of deliveryservice_requests endpoints

asfgit commented on issue #1785: TO and TP -- initial implementation of deliveryservice_requests endpoints URL: https://github.com/apache/incubator-trafficcontrol/pull/1785#issuecomment-360247771 Refer to this link for build results (access rights to CI server needed): https://buil

[GitHub] asfgit commented on issue #1785: TO and TP -- initial implementation of deliveryservice_requests endpoints

asfgit commented on issue #1785: TO and TP -- initial implementation of deliveryservice_requests endpoints URL: https://github.com/apache/incubator-trafficcontrol/pull/1785#issuecomment-360259481 Refer to this link for build results (access rights to CI server needed): https://buil

[GitHub] rob05c commented on issue #917: [TC-192] Java TM and Go TM get build with exact same RPM Name

rob05c commented on issue #917: [TC-192] Java TM and Go TM get build with exact same RPM Name URL: https://github.com/apache/incubator-trafficcontrol/issues/917#issuecomment-360272758 @limited Java TM is now deprecated, has been moved to `traffic_monitor_java`, and shouldn't ordinarily be

[GitHub] rob05c commented on issue #917: [TC-192] Java TM and Go TM get build with exact same RPM Name

rob05c commented on issue #917: [TC-192] Java TM and Go TM get build with exact same RPM Name URL: https://github.com/apache/incubator-trafficcontrol/issues/917#issuecomment-360272758 @limited Java TM is now deprecated, has been moved to `traffic_monitor_java`, and shouldn't ordinarily be

[GitHub] dneuman64 closed issue #917: [TC-192] Java TM and Go TM get build with exact same RPM Name

dneuman64 closed issue #917: [TC-192] Java TM and Go TM get build with exact same RPM Name URL: https://github.com/apache/incubator-trafficcontrol/issues/917 This is an automated message from the Apache Git Service. To respo

[GitHub] dneuman64 commented on issue #917: [TC-192] Java TM and Go TM get build with exact same RPM Name

dneuman64 commented on issue #917: [TC-192] Java TM and Go TM get build with exact same RPM Name URL: https://github.com/apache/incubator-trafficcontrol/issues/917#issuecomment-360275034 Resolving since Java TM has been moved to a new directory. ---

[GitHub] rob05c commented on issue #1662: URI Signing doesn't assign parameters to profiles

rob05c commented on issue #1662: URI Signing doesn't assign parameters to profiles URL: https://github.com/apache/incubator-trafficcontrol/issues/1662#issuecomment-360282595 Moving to a future release. It really is mostly a regression, but it's not that clean-cut, as URI Signing is a new

[GitHub] dneuman64 opened a new pull request #1792: changed maxLength of zip code to be longer.

dneuman64 opened a new pull request #1792: changed maxLength of zip code to be longer. URL: https://github.com/apache/incubator-trafficcontrol/pull/1792 I removed the zip code length restriction in the TO UI and Changed it to be 11 in traffic portal. This should allow for Zip codes of oth

[GitHub] asfgit commented on issue #1792: changed maxLength of zip code to be longer.

asfgit commented on issue #1792: changed maxLength of zip code to be longer. URL: https://github.com/apache/incubator-trafficcontrol/pull/1792#issuecomment-360285543 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-tra

[GitHub] rob05c commented on issue #1620: API: Server API sets xmpp_id to null

rob05c commented on issue #1620: API: Server API sets xmpp_id to null URL: https://github.com/apache/incubator-trafficcontrol/issues/1620#issuecomment-360286686 We'll essentially get this for free, when the Server create/POST route is moved to `traffic_ops_golang`. Specifically, the

[GitHub] rob05c commented on issue #1620: API: Server API sets xmpp_id to null

rob05c commented on issue #1620: API: Server API sets xmpp_id to null URL: https://github.com/apache/incubator-trafficcontrol/issues/1620#issuecomment-360286916 @DylanVolz This is an automated message from the Apache Git Serv

[GitHub] limited commented on issue #1792: changed maxLength of zip code to be longer.

limited commented on issue #1792: changed maxLength of zip code to be longer. URL: https://github.com/apache/incubator-trafficcontrol/pull/1792#issuecomment-360286871 I think we need to allow letters too. Canadians use the alphabet in their postal codes: https://en.wikipedia.org/wiki/P

[GitHub] dneuman64 commented on issue #1792: changed maxLength of zip code to be longer.

dneuman64 commented on issue #1792: changed maxLength of zip code to be longer. URL: https://github.com/apache/incubator-trafficcontrol/pull/1792#issuecomment-360289830 Good point, I can make that change. This is an automated

[GitHub] dneuman64 commented on issue #1792: changed maxLength of zip code to be longer.

dneuman64 commented on issue #1792: changed maxLength of zip code to be longer. URL: https://github.com/apache/incubator-trafficcontrol/pull/1792#issuecomment-360291845 OK @limited I removed the check completely since all that was left was [0-9]. ---

[GitHub] limited closed pull request #1792: changed maxLength of zip code to be longer.

limited closed pull request #1792: changed maxLength of zip code to be longer. URL: https://github.com/apache/incubator-trafficcontrol/pull/1792 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As t

[GitHub] limited closed issue #1761: Traffic OPS ZIPCode

limited closed issue #1761: Traffic OPS ZIPCode URL: https://github.com/apache/incubator-trafficcontrol/issues/1761 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and

[GitHub] asfgit commented on issue #1792: changed maxLength of zip code to be longer.

asfgit commented on issue #1792: changed maxLength of zip code to be longer. URL: https://github.com/apache/incubator-trafficcontrol/pull/1792#issuecomment-360293832 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-tra

<    3   4   5   6   7   8   9   10   11   12   >