[GitHub] incubator-trafficcontrol pull request #445: [TC-64] - To exp ui server.js fi...

2017-04-10 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/445 [TC-64] - To exp ui server.js fixes plus simplifying build You can merge this pull request into a Git repository by running: $ git pull https://github.com/mitchell852

[GitHub] incubator-trafficcontrol pull request #446: [TC-64] - fixes serverutils typo

2017-04-10 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/446 [TC-64] - fixes serverutils typo You can merge this pull request into a Git repository by running: $ git pull https://github.com/mitchell852/incubator-trafficcontrol

[GitHub] incubator-trafficcontrol pull request #447: [TC-64] - to api destination is ...

2017-04-10 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/447 [TC-64] - to api destination is controlled at the server level You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] incubator-trafficcontrol issue #444: Updated API POST /api/1.2/deliveryservi...

2017-04-10 Thread mitchell852
Github user mitchell852 commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/444 can you do a search on that page for missLat and missLong? I see 2 more with 45 as the example, want to update those as well while you are in this file? --- If your project

[GitHub] incubator-trafficcontrol pull request #434: org tenancy - add tenant name to...

2017-04-11 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/434#discussion_r110946789 --- Diff: traffic_ops/app/lib/API/User.pm --- @@ -281,11 +284,14 @@ sub current { if ( _ldap($self

[GitHub] incubator-trafficcontrol pull request #454: clarifies ports for toui and rem...

2017-04-11 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/454 clarifies ports for toui and removes unused proxyport You can merge this pull request into a Git repository by running: $ git pull https://github.com/mitchell852

[GitHub] incubator-trafficcontrol pull request #453: [TC-227] - adds the ability to f...

2017-04-11 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/453 [TC-227] - adds the ability to fetch jobs thru api You can merge this pull request into a Git repository by running: $ git pull https://github.com/mitchell852/incubator

[GitHub] incubator-trafficcontrol pull request #421: fixes broken profile tests

2017-03-31 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/421 fixes broken profile tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/mitchell852/incubator-trafficcontrol fix

[GitHub] incubator-trafficcontrol pull request #398: [TC-184] Org tenancy - adding te...

2017-03-30 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/398#discussion_r109076554 --- Diff: traffic_ops/app/lib/API/User.pm --- @@ -277,6 +285,7 @@ sub current { @data

[GitHub] incubator-trafficcontrol pull request #398: [TC-184] Org tenancy - adding te...

2017-03-30 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/398#discussion_r109075457 --- Diff: traffic_ops/app/lib/API/User.pm --- @@ -277,6 +285,7 @@ sub current { @data

[GitHub] incubator-trafficcontrol pull request #398: [TC-184] Org tenancy - adding te...

2017-03-30 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/398#discussion_r109074671 --- Diff: traffic_ops/app/lib/API/User.pm --- @@ -375,6 +385,10 @@ sub update_current { if ( defined( $user

[GitHub] incubator-trafficcontrol pull request #398: [TC-184] Org tenancy - adding te...

2017-03-30 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/398#discussion_r109074708 --- Diff: traffic_ops/app/lib/API/User.pm --- @@ -475,6 +489,8 @@ sub is_valid { return $self

[GitHub] incubator-trafficcontrol pull request #398: [TC-184] Org tenancy - adding te...

2017-04-02 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/398#discussion_r109312063 --- Diff: traffic_ops/app/lib/UI/Utils.pm --- @@ -42,7 +42,7 @@ use constant ADMIN => 30; our %EXPORT_TAGS = ( '

[GitHub] incubator-trafficcontrol pull request #398: [TC-184] Org tenancy - adding te...

2017-04-02 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/398#discussion_r109312553 --- Diff: traffic_ops/app/lib/API/User.pm --- @@ -277,6 +285,7 @@ sub current { @data

[GitHub] incubator-trafficcontrol pull request #402: [TC-184] Org tenancy - adding te...

2017-04-02 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/402#discussion_r109322384 --- Diff: traffic_ops/app/lib/API/Cdn.pm --- @@ -123,10 +126,14 @@ sub create { return $self->alert( &qu

[GitHub] incubator-trafficcontrol pull request #458: [TC-221] - responses to ds updat...

2017-04-12 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/458 [TC-221] - responses to ds update/create now mirror that of show You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] incubator-trafficcontrol issue #435: Authorization model

2017-04-06 Thread mitchell852
Github user mitchell852 commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/435 thanks @naamashoresh - i'll take a look at this asap. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-trafficcontrol issue #322: Adding tenancy to the database

2017-04-06 Thread mitchell852
Github user mitchell852 commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/322 can this PR be closed? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-trafficcontrol pull request #430: updates traffic portal install r...

2017-04-05 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/430 updates traffic portal install readme You can merge this pull request into a Git repository by running: $ git pull https://github.com/mitchell852/incubator

[GitHub] incubator-trafficcontrol pull request #451: [TC-193] - adds ability to filte...

2017-04-10 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/451 [TC-193] - adds ability to filter delivery services by profile You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] incubator-trafficcontrol pull request #464: [TC-231] - adds a query param (e...

2017-04-12 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/464 [TC-231] - adds a query param (exclude) that can prevent the fetching of the ver… …y expensive exampleURLs property. if not used (?exclude=exampleURLs), the api behaves

[GitHub] incubator-trafficcontrol pull request #464: [TC-231] - adds a query param (e...

2017-04-17 Thread mitchell852
Github user mitchell852 closed the pull request at: https://github.com/apache/incubator-trafficcontrol/pull/464 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-trafficcontrol issue #370: Adding a "create user" to the api

2017-04-20 Thread mitchell852
Github user mitchell852 commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/370 you might want to run your code thru the perl formatter. I see some formatting errors. Here's more info about that: https://github.com/apache/incubator-trafficcontrol

[GitHub] incubator-trafficcontrol pull request #484: fixes broken log tests - loads l...

2017-04-19 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/484 fixes broken log tests - loads log fixture data outside of the core You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] incubator-trafficcontrol pull request #493: [TC-241] - adds api endpoint to ...

2017-04-20 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/493 [TC-241] - adds api endpoint to remove a cache from a ds You can merge this pull request into a Git repository by running: $ git pull https://github.com/mitchell852

[GitHub] incubator-trafficcontrol pull request #498: [WIP] - moves demo data out of s...

2017-04-21 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/498 [WIP] - moves demo data out of seeds file into seeds_demo.sql and adds new co… …nvenience method to admin.pl You can merge this pull request into a Git repository

[GitHub] incubator-trafficcontrol pull request #469: [BACKPORT TC-223] - default rege...

2017-04-13 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/469 [BACKPORT TC-223] - default regex is required on a ds before dnssec keys can be created (… …if required) (cherry picked from commit

[GitHub] incubator-trafficcontrol pull request #486: [TC-82] - removes duplicate apis

2017-04-19 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/486 [TC-82] - removes duplicate apis You can merge this pull request into a Git repository by running: $ git pull https://github.com/mitchell852/incubator-trafficcontrol tc

[GitHub] incubator-trafficcontrol pull request #485: fixes broken asn test

2017-04-19 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/485 fixes broken asn test You can merge this pull request into a Git repository by running: $ git pull https://github.com/mitchell852/incubator-trafficcontrol fixes-asn

[GitHub] incubator-trafficcontrol pull request #492: [TC-64] - hooks TOUI into up dbd...

2017-04-20 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/492 [TC-64] - hooks TOUI into up dbdump api You can merge this pull request into a Git repository by running: $ git pull https://github.com/mitchell852/incubator

[GitHub] incubator-trafficcontrol issue #433: [TC-184] Tenancy validation for resourc...

2017-04-20 Thread mitchell852
Github user mitchell852 commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/433 make sure you rebase this when you get a chance. you have conflicts. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] incubator-trafficcontrol issue #434: org tenancy - add tenant name to user a...

2017-04-14 Thread mitchell852
Github user mitchell852 commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/434 @orifinkelman - can you take out all the "N/A"s and i'll get this merged? if tenant is not defined, just leave it as undef that is how we do it on the

[GitHub] incubator-trafficcontrol pull request #470: fixes failing job unit test

2017-04-14 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/470 fixes failing job unit test You can merge this pull request into a Git repository by running: $ git pull https://github.com/mitchell852/incubator-trafficcontrol fix-job

[GitHub] incubator-trafficcontrol pull request #460: [TC-64] - TO UI experimental - a...

2017-04-12 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/460 [TC-64] - TO UI experimental - adds queue updates and invalidate content views You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] incubator-trafficcontrol pull request #478: cleans up trafficopsroutes file ...

2017-04-18 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/478 cleans up trafficopsroutes file - reorganizes, adds parameter constra… …ints where necessary, additional comments, etc. You can merge this pull request into a Git

[GitHub] incubator-trafficcontrol issue #402: [TC-184] Org tenancy - adding tenant to...

2017-04-18 Thread mitchell852
Github user mitchell852 commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/402 @nir-sopher - i agree. let's tackle tenancy on a deliveryservice to start and then we can circle back to tenancy at the cdn level... --- If your project is set up for it, you

[GitHub] incubator-trafficcontrol pull request #433: [TC-184] Tenancy validation for ...

2017-04-18 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/433#discussion_r112024314 --- Diff: traffic_ops/app/lib/API/Tenant.pm --- @@ -117,14 +123,25 @@ sub update { my $is_active = $params->{act

[GitHub] incubator-trafficcontrol pull request #433: [TC-184] Tenancy validation for ...

2017-04-18 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/433#discussion_r112025226 --- Diff: traffic_ops/app/lib/API/Tenant.pm --- @@ -117,14 +123,25 @@ sub update { my $is_active = $params->{act

[GitHub] incubator-trafficcontrol pull request #403: [TC-184] Org tenancy - delivery ...

2017-04-18 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/403#discussion_r112016567 --- Diff: traffic_ops/app/lib/Schema/Result/Deliveryservice.pm --- @@ -278,11 +278,22 @@ __PACKAGE__->table("deliver

[GitHub] incubator-trafficcontrol pull request #403: [TC-184] Org tenancy - delivery ...

2017-04-18 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/403#discussion_r112015576 --- Diff: traffic_ops/app/db/migrations/2017040400_delivery_service_tenancy.sql --- @@ -0,0 +1,30 @@ +/* --- End diff

[GitHub] incubator-trafficcontrol pull request #403: [TC-184] Org tenancy - delivery ...

2017-04-18 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/403#discussion_r112016601 --- Diff: traffic_ops/app/lib/Schema/Result/Deliveryservice.pm --- @@ -390,8 +401,12 @@ __PACKAGE__->add_columns( { data_t

[GitHub] incubator-trafficcontrol pull request #403: [TC-184] Org tenancy - delivery ...

2017-04-18 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/403#discussion_r112014737 --- Diff: docs/source/development/traffic_ops_api/v12/deliveryservice.rst --- @@ -168,6 +168,8 @@ Delivery Service

[GitHub] incubator-trafficcontrol issue #491: [TC-240] updates db dump to custom form...

2017-04-19 Thread mitchell852
Github user mitchell852 commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/491 works well for me in both the UI and the api. merging... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-trafficcontrol issue #337: simplifies config file / snapshot compa...

2017-03-07 Thread mitchell852
Github user mitchell852 commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/337 @knutsel - what do you think of these changes? i tried to simplify the script so basically all it does is compare the config files / snapshots of traffic ops X to those

[GitHub] incubator-trafficcontrol pull request #351: [BACKPORT] - TC-183 - server.pm ...

2017-03-13 Thread mitchell852
Github user mitchell852 closed the pull request at: https://github.com/apache/incubator-trafficcontrol/pull/351 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-trafficcontrol pull request #359: [TC-186] - ds profile is now opt...

2017-03-13 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/359 [TC-186] - ds profile is now optional per PR #290 You can merge this pull request into a Git repository by running: $ git pull https://github.com/mitchell852/incubator

[GitHub] incubator-trafficcontrol pull request #362: [BACKPORT] [TC-189] - fixes 2 mi...

2017-03-14 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/362 [BACKPORT] [TC-189] - fixes 2 missLatts (and no missLong) and casts to float if defined (cherry picked from commit 246d9b200fe18460fa7cc34fd7473c2b1910e81d) You can merge

[GitHub] incubator-trafficcontrol pull request #356: Security Enhancement - secures D...

2017-03-14 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/356#discussion_r105957356 --- Diff: traffic_ops/app/lib/UI/GenDbDump.pm --- @@ -32,6 +33,10 @@ sub dbdump { $self->internal_server_er

[GitHub] incubator-trafficcontrol pull request #361: [TC-189] - fixes 2 missLatts (an...

2017-03-14 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/361 [TC-189] - fixes 2 missLatts (and no missLong) and casts to float if defined You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] incubator-trafficcontrol pull request #322: Adding tenancy to the database

2017-03-06 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/322#discussion_r104485020 --- Diff: traffic_ops/app/db/migrations/2017022101_initial_tenancy.sql --- @@ -0,0 +1,65 @@ +/* + +Licensed under

[GitHub] incubator-trafficcontrol pull request #322: Adding tenancy to the database

2017-03-06 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/322#discussion_r104487370 --- Diff: traffic_ops/app/lib/API/Tenant.pm --- @@ -0,0 +1,225 @@ +package API::Tenant; +# +# +# Licensed under

[GitHub] incubator-trafficcontrol pull request #334: removes traffic_portal ?API_KEY ...

2017-03-06 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/334 removes traffic_portal ?API_KEY query parameter You can merge this pull request into a Git repository by running: $ git pull https://github.com/mitchell852/incubator

[GitHub] incubator-trafficcontrol pull request #322: Adding tenancy to the database

2017-02-28 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/322#discussion_r103534500 --- Diff: traffic_ops/app/lib/API/User.pm --- @@ -218,6 +218,118 @@ sub update { } +# Create +sub create

[GitHub] incubator-trafficcontrol pull request #322: Adding tenancy to the database

2017-02-28 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/322#discussion_r103532374 --- Diff: traffic_ops/app/lib/API/Tenant.pm --- @@ -0,0 +1,225 @@ +package API::Tenant; +# +# +# Licensed under

[GitHub] incubator-trafficcontrol pull request #322: Adding tenancy to the database

2017-02-28 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/322#discussion_r103534303 --- Diff: traffic_ops/app/lib/API/User.pm --- @@ -218,6 +218,118 @@ sub update { } +# Create +sub create

[GitHub] incubator-trafficcontrol pull request #322: Adding tenancy to the database

2017-02-28 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/322#discussion_r103531624 --- Diff: traffic_ops/app/lib/API/Tenant.pm --- @@ -0,0 +1,225 @@ +package API::Tenant; +# +# +# Licensed under

[GitHub] incubator-trafficcontrol pull request #337: simplifies config file / snapsho...

2017-03-07 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/337 simplifies config file / snapshot compare script You can merge this pull request into a Git repository by running: $ git pull https://github.com/mitchell852/incubator

[GitHub] incubator-trafficcontrol pull request #398: [TC-184] Org tenancy - adding te...

2017-04-02 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/398#discussion_r109320570 --- Diff: traffic_ops/app/lib/API/User.pm --- @@ -277,6 +285,7 @@ sub current { @data

[GitHub] incubator-trafficcontrol pull request #398: [TC-184] Org tenancy - adding te...

2017-04-02 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/398#discussion_r109321173 --- Diff: traffic_ops/app/lib/API/User.pm --- @@ -277,6 +285,7 @@ sub current { @data

[GitHub] incubator-trafficcontrol pull request #434: org tenancy - add tenant name to...

2017-04-06 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/434#discussion_r110308097 --- Diff: traffic_ops/app/lib/API/User.pm --- @@ -330,6 +336,7 @@ sub current { "phoneN

[GitHub] incubator-trafficcontrol pull request #434: org tenancy - add tenant name to...

2017-04-06 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/434#discussion_r110307660 --- Diff: traffic_ops/app/lib/API/User.pm --- @@ -98,6 +98,7 @@ sub index { "stateOrProvince&quo

[GitHub] incubator-trafficcontrol pull request #434: org tenancy - add tenant name to...

2017-04-06 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/434#discussion_r110307744 --- Diff: traffic_ops/app/lib/API/User.pm --- @@ -69,7 +69,7 @@ sub index { my $dbh; if ( defined $username

[GitHub] incubator-trafficcontrol pull request #434: org tenancy - add tenant name to...

2017-04-06 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/434#discussion_r110308262 --- Diff: traffic_ops/app/lib/API/User.pm --- @@ -134,6 +135,7 @@ sub show { "stateOrProvince&quo

[GitHub] incubator-trafficcontrol pull request #370: Adding a "create user" to the ap...

2017-04-06 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/370#discussion_r110309625 --- Diff: traffic_ops/app/lib/API/User.pm --- @@ -226,6 +226,120 @@ sub update { } +# Create +sub create

[GitHub] incubator-trafficcontrol pull request #370: Adding a "create user" to the ap...

2017-04-06 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/370#discussion_r110309463 --- Diff: traffic_ops/app/lib/API/User.pm --- @@ -226,6 +226,120 @@ sub update { } +# Create +sub create

[GitHub] incubator-trafficcontrol pull request #370: Adding a "create user" to the ap...

2017-04-06 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/370#discussion_r107505547 --- Diff: traffic_ops/app/lib/API/User.pm --- @@ -218,6 +218,115 @@ sub update { } +# Create +sub create

[GitHub] incubator-trafficcontrol pull request #370: Adding a "create user" to the ap...

2017-04-06 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/370#discussion_r110309119 --- Diff: docs/source/development/traffic_ops_api/v12/user.rst --- @@ -214,6 +214,153 @@ Users | + +**POST

[GitHub] incubator-trafficcontrol pull request #370: Adding a "create user" to the ap...

2017-04-06 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/370#discussion_r110309859 --- Diff: docs/source/development/traffic_ops_api/v12/user.rst --- @@ -214,6 +214,153 @@ Users | + +**POST

[GitHub] incubator-trafficcontrol pull request #370: Adding a "create user" to the ap...

2017-04-06 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/370#discussion_r110310005 --- Diff: traffic_ops/app/lib/API/User.pm --- @@ -226,6 +226,120 @@ sub update { } +# Create +sub create

[GitHub] incubator-trafficcontrol issue #402: [TC-184] Org tenancy - adding tenant to...

2017-04-06 Thread mitchell852
Github user mitchell852 commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/402 Do you want me to hold off on this one? Are you rethinking it? I still think we need tenancy at the CDN level. --- If your project is set up for it, you can reply

[GitHub] incubator-trafficcontrol pull request #433: [TC-184] Tenancy validation for ...

2017-04-06 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/433#discussion_r110311677 --- Diff: traffic_ops/app/lib/API/Tenant.pm --- @@ -44,14 +44,16 @@ sub index { my $orderby = $self->param('orderby') || &q

[GitHub] incubator-trafficcontrol pull request #433: [TC-184] Tenancy validation for ...

2017-04-06 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/433#discussion_r110311804 --- Diff: traffic_ops/app/lib/API/Tenant.pm --- @@ -44,14 +44,16 @@ sub index { my $orderby = $self->param('orderby') || &q

[GitHub] incubator-trafficcontrol pull request #398: [TC-184] Org tenancy - adding te...

2017-03-30 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/398#discussion_r109073415 --- Diff: traffic_ops/app/db/migrations/2017031501_user_tenancy.sql --- @@ -0,0 +1,31 @@ +/* --- End diff -- can

[GitHub] incubator-trafficcontrol pull request #402: [TC-184] Org tenancy - adding te...

2017-03-31 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/402#discussion_r109166684 --- Diff: traffic_ops/app/lib/API/Cdn.pm --- @@ -123,10 +126,14 @@ sub create { return $self->alert( &qu

[GitHub] incubator-trafficcontrol pull request #402: [TC-184] Org tenancy - adding te...

2017-03-31 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/402#discussion_r109164965 --- Diff: traffic_ops/app/db/migrations/2017031502_cdn_tenancy.sql --- @@ -0,0 +1,31 @@ +/* --- End diff

[GitHub] incubator-trafficcontrol pull request #402: [TC-184] Org tenancy - adding te...

2017-03-31 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/402#discussion_r109166992 --- Diff: traffic_ops/app/lib/API/Cdn.pm --- @@ -181,19 +189,25 @@ sub update { return $self->alert( &qu

[GitHub] incubator-trafficcontrol pull request #402: [TC-184] Org tenancy - adding te...

2017-03-31 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/402#discussion_r109165433 --- Diff: traffic_ops/app/lib/API/Cdn.pm --- @@ -123,10 +126,14 @@ sub create { return $self->alert( &qu

[GitHub] incubator-trafficcontrol pull request #402: [TC-184] Org tenancy - adding te...

2017-03-31 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/402#discussion_r109167349 --- Diff: traffic_ops/app/lib/Fixtures/Cdn.pm --- @@ -33,6 +34,17 @@ my %definition_for = ( id =>

[GitHub] incubator-trafficcontrol issue #384: Api fix

2017-03-21 Thread mitchell852
Github user mitchell852 commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/384 when you get a chance can you put a better title on this and a short description of the changes? --- If your project is set up for it, you can reply to this email and have

[GitHub] incubator-trafficcontrol pull request #472: fixes failing tests. ambiguous f...

2017-04-14 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/472 fixes failing tests. ambiguous fields need table qualifiers. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mitchell852

[GitHub] incubator-trafficcontrol pull request #481: [TC-237] - GET /api/../logs sets...

2017-04-18 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/481 [TC-237] - GET /api/../logs sets last_seen_log cookie when all change logs are viewed emulates the UI namespace You can merge this pull request into a Git repository

[GitHub] incubator-trafficcontrol pull request #482: [TC-238] - adds limit query para...

2017-04-18 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/482 [TC-238] - adds limit query param to GET api/../logs You can merge this pull request into a Git repository by running: $ git pull https://github.com/mitchell852

[GitHub] incubator-trafficcontrol pull request #483: [TC-64] - hooks in change logs t...

2017-04-18 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/483 [TC-64] - hooks in change logs to TO experimental UI You can merge this pull request into a Git repository by running: $ git pull https://github.com/mitchell852

[GitHub] incubator-trafficcontrol pull request #370: Adding a "create user" to the ap...

2017-04-24 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/370#discussion_r113004733 --- Diff: traffic_ops/app/t/api/1.2/user_admin.t --- @@ -0,0 +1,126 @@ +package main; +# +# +# Licensed under

[GitHub] incubator-trafficcontrol pull request #767: TPv2 - disables target on update...

2017-07-31 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/767 TPv2 - disables target on update. a steering target is comprised of a source… … and a target. changing the target represents a creation of a new target rather than

[GitHub] incubator-trafficcontrol pull request #761: Add TO client DS ByServer, Regex...

2017-07-31 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/761#discussion_r130380695 --- Diff: traffic_ops/client/delivery_service_endpoints.go --- @@ -22,6 +22,10 @@ func deliveryServicesEp() string { return

[GitHub] incubator-trafficcontrol pull request #751: [TC-462] Ds tenancy validation r...

2017-07-31 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/751#discussion_r130405449 --- Diff: traffic_ops/app/lib/API/DeliveryServiceMatches.pm --- @@ -28,11 +29,19 @@ sub index { my $format = $self->pa

[GitHub] incubator-trafficcontrol pull request #751: [TC-462] Ds tenancy validation r...

2017-07-31 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/751#discussion_r130406581 --- Diff: traffic_ops/app/lib/API/DeliveryServiceRegexes.pm --- @@ -222,6 +262,18 @@ sub delete { return $self

[GitHub] incubator-trafficcontrol pull request #752: [TC-460] Ds tenancy validation s...

2017-07-31 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/752#discussion_r130407783 --- Diff: traffic_ops/app/lib/API/DeliveryServiceServer.pm --- @@ -223,8 +240,19 @@ sub remove_server_from_ds { my $ds_id

[GitHub] incubator-trafficcontrol pull request #752: [TC-460] Ds tenancy validation s...

2017-07-31 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/752#discussion_r130410587 --- Diff: traffic_ops/app/lib/API/Server.pm --- @@ -726,41 +746,26 @@ sub get_servers_by_type { my $orderby = $self

[GitHub] incubator-trafficcontrol pull request #752: [TC-460] Ds tenancy validation s...

2017-07-31 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/752#discussion_r130410539 --- Diff: traffic_ops/app/lib/API/Server.pm --- @@ -569,10 +575,17 @@ sub get_unassigned_servers_by_dsid { $ds_server_criteria

[GitHub] incubator-trafficcontrol pull request #752: [TC-460] Ds tenancy validation s...

2017-07-31 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/752#discussion_r130407547 --- Diff: traffic_ops/app/lib/API/DeliveryServiceServer.pm --- @@ -80,15 +86,21 @@ sub assign_servers_to_ds { return

[GitHub] incubator-trafficcontrol pull request #751: [TC-462] Ds tenancy validation r...

2017-07-31 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/751#discussion_r130405550 --- Diff: traffic_ops/app/lib/API/DeliveryServiceRegexes.pm --- @@ -27,12 +28,18 @@ use Validate::Tiny ':all'; sub all

[GitHub] incubator-trafficcontrol pull request #752: [TC-460] Ds tenancy validation s...

2017-07-31 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/752#discussion_r130407887 --- Diff: traffic_ops/app/lib/API/Server.pm --- @@ -400,40 +401,25 @@ sub get_servers_by_status { my $orderby

[GitHub] incubator-trafficcontrol pull request #758: [TC-478] Parameter value can be ...

2017-08-02 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/758#discussion_r131001497 --- Diff: traffic_ops/app/lib/API/Parameter.pm --- @@ -317,7 +317,7 @@ sub update { my $name = $params->{name} || $f

[GitHub] incubator-trafficcontrol pull request #751: [TC-462] Ds tenancy validation r...

2017-08-02 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/751#discussion_r130975670 --- Diff: traffic_ops/app/lib/API/DeliveryServiceRegexes.pm --- @@ -222,6 +262,18 @@ sub delete { return $self

[GitHub] incubator-trafficcontrol pull request #758: [TC-478] Parameter value can be ...

2017-08-03 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/758#discussion_r131186253 --- Diff: traffic_ops/app/lib/API/Parameter.pm --- @@ -317,7 +317,7 @@ sub update { my $name = $params->{name} || $f

[GitHub] incubator-trafficcontrol pull request #753: [TC-463] User tenancy ds assignm...

2017-08-03 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/753#discussion_r129939021 --- Diff: traffic_ops/app/lib/API/Deliveryservice.pm --- @@ -949,6 +959,8 @@ sub get_deliveryservices_by_userId { my @data

[GitHub] incubator-trafficcontrol pull request #753: [TC-463] User tenancy ds assignm...

2017-08-03 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/753#discussion_r129940638 --- Diff: traffic_ops/app/lib/API/User.pm --- @@ -408,16 +423,24 @@ sub assign_deliveryservices { if ( !defined($user

[GitHub] incubator-trafficcontrol pull request #753: [TC-463] User tenancy ds assignm...

2017-08-03 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/753#discussion_r129937865 --- Diff: traffic_ops/app/lib/API/DeliveryServiceUser.pm --- @@ -31,6 +32,18 @@ sub delete { return $self->forbid

<    1   2   3   4   5   >