[GitHub] asfgit commented on issue #2281: Increase hostname and domain name length limit in Traffic Portal

2018-05-16 Thread GitBox
asfgit commented on issue #2281: Increase hostname and domain name length limit in Traffic Portal URL: https://github.com/apache/incubator-trafficcontrol/pull/2281#issuecomment-389681832 Refer to this link for build results (access rights to CI server needed):

[GitHub] rawlinp commented on issue #2279: Increase server hostname max length

2018-05-16 Thread GitBox
rawlinp commented on issue #2279: Increase server hostname max length URL: https://github.com/apache/incubator-trafficcontrol/issues/2279#issuecomment-389679003 Sure, just opened #2281 to increase both limits in TP to 100.

[GitHub] rawlinp opened a new pull request #2281: Increase hostname and domain name length limit in Traffic Portal

2018-05-16 Thread GitBox
rawlinp opened a new pull request #2281: Increase hostname and domain name length limit in Traffic Portal URL: https://github.com/apache/incubator-trafficcontrol/pull/2281 This changes is from 45 to 100. The limit itself could probably be removed altogether since the DB type is `text`,

[GitHub] asfgit commented on issue #2280: Fix TO CRconfig changelog

2018-05-16 Thread GitBox
asfgit commented on issue #2280: Fix TO CRconfig changelog URL: https://github.com/apache/incubator-trafficcontrol/pull/2280#issuecomment-389676041 Refer to this link for build results (access rights to CI server needed):

[GitHub] mitchell852 commented on issue #2279: Increase server hostname max length

2018-05-16 Thread GitBox
mitchell852 commented on issue #2279: Increase server hostname max length URL: https://github.com/apache/incubator-trafficcontrol/issues/2279#issuecomment-389673406 there's probably a maxLength attribute in TP. you want to remove that @rawlinp ?

[GitHub] elsloo closed pull request #2280: Fix TO CRconfig changelog

2018-05-16 Thread GitBox
elsloo closed pull request #2280: Fix TO CRconfig changelog URL: https://github.com/apache/incubator-trafficcontrol/pull/2280 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] rob05c opened a new pull request #2280: Fix TO CRconfig changelog

2018-05-16 Thread GitBox
rob05c opened a new pull request #2280: Fix TO CRconfig changelog URL: https://github.com/apache/incubator-trafficcontrol/pull/2280 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] rawlinp commented on issue #2279: Increase server hostname max length

2018-05-16 Thread GitBox
rawlinp commented on issue #2279: Increase server hostname max length URL: https://github.com/apache/incubator-trafficcontrol/issues/2279#issuecomment-389668866 Yeah I think since the DB type is just `text` we should be able to bump up the artificial limit in TP.

[GitHub] jhg03a commented on issue #2279: Increase server hostname max length

2018-05-16 Thread GitBox
jhg03a commented on issue #2279: Increase server hostname max length URL: https://github.com/apache/incubator-trafficcontrol/issues/2279#issuecomment-389668324 Yes. I am able to enter the data in the old TO interface, but that makes the server uneditable in the current TP.

[GitHub] mitchell852 commented on issue #2279: Increase server hostname max length

2018-05-16 Thread GitBox
mitchell852 commented on issue #2279: Increase server hostname max length URL: https://github.com/apache/incubator-trafficcontrol/issues/2279#issuecomment-389652233 Are you referring to the field in traffic portal? This is

[GitHub] jhg03a opened a new issue #2279: Increase server hostname max length

2018-05-16 Thread GitBox
jhg03a opened a new issue #2279: Increase server hostname max length URL: https://github.com/apache/incubator-trafficcontrol/issues/2279 As a CDN SRE I want to be able to supply an arbitrarily long hostname. Today I actually only need 5 more characters, but this seems like a hidden limit

[GitHub] rob05c closed issue #2243: Routes.go file should include type capture groups to enforce route parameter types

2018-05-16 Thread GitBox
rob05c closed issue #2243: Routes.go file should include type capture groups to enforce route parameter types URL: https://github.com/apache/incubator-trafficcontrol/issues/2243 This is an automated message from the Apache

[GitHub] DylanVolz commented on issue #2277: Allow the capture group for a route parameter to be defined

2018-05-16 Thread GitBox
DylanVolz commented on issue #2277: Allow the capture group for a route parameter to be defined URL: https://github.com/apache/incubator-trafficcontrol/pull/2277#issuecomment-389624176 After analysis of the legacy routes we will be porting from perl to go this feature is unnecessary. By

[GitHub] DylanVolz closed pull request #2277: Allow the capture group for a route parameter to be defined

2018-05-16 Thread GitBox
DylanVolz closed pull request #2277: Allow the capture group for a route parameter to be defined URL: https://github.com/apache/incubator-trafficcontrol/pull/2277 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[GitHub] DylanVolz commented on issue #2243: Routes.go file should include type capture groups to enforce route parameter types

2018-05-16 Thread GitBox
DylanVolz commented on issue #2243: Routes.go file should include type capture groups to enforce route parameter types URL: https://github.com/apache/incubator-trafficcontrol/issues/2243#issuecomment-389624250 After analysis of the legacy routes we will be porting from perl to go this

[GitHub] asfgit commented on issue #2247: Add an Origin API

2018-05-16 Thread GitBox
asfgit commented on issue #2247: Add an Origin API URL: https://github.com/apache/incubator-trafficcontrol/pull/2247#issuecomment-389582209 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR/1585/

[GitHub] knutsel commented on issue #2246: Add HitCount and FreshFor

2018-05-16 Thread GitBox
knutsel commented on issue #2246: Add HitCount and FreshFor URL: https://github.com/apache/incubator-trafficcontrol/pull/2246#issuecomment-389554197 @rob05c - like this? Sorry that the diff in rfc/rules.go is a bit bigger than needed, hard to get it all in the right place.

[GitHub] asfgit commented on issue #2246: Add HitCount and FreshFor

2018-05-16 Thread GitBox
asfgit commented on issue #2246: Add HitCount and FreshFor URL: https://github.com/apache/incubator-trafficcontrol/pull/2246#issuecomment-389553758 Refer to this link for build results (access rights to CI server needed):

[GitHub] asfgit commented on issue #2246: Add HitCount and FreshFor

2018-05-16 Thread GitBox
asfgit commented on issue #2246: Add HitCount and FreshFor URL: https://github.com/apache/incubator-trafficcontrol/pull/2246#issuecomment-389552212 Refer to this link for build results (access rights to CI server needed):

[GitHub] asfgit commented on issue #2246: Add HitCount and FreshFor

2018-05-16 Thread GitBox
asfgit commented on issue #2246: Add HitCount and FreshFor URL: https://github.com/apache/incubator-trafficcontrol/pull/2246#issuecomment-389530137 Refer to this link for build results (access rights to CI server needed):

[GitHub] knutsel commented on a change in pull request #2246: Add HitCount and FreshFor

2018-05-16 Thread GitBox
knutsel commented on a change in pull request #2246: Add HitCount and FreshFor URL: https://github.com/apache/incubator-trafficcontrol/pull/2246#discussion_r188635843 ## File path: grove/plugin/http_cacheinspector.go ## @@ -169,16 +170,17 @@ func cacheinspect(icfg

[GitHub] asfgit commented on issue #2277: Allow the capture group for a route parameter to be defined

2018-05-15 Thread GitBox
asfgit commented on issue #2277: Allow the capture group for a route parameter to be defined URL: https://github.com/apache/incubator-trafficcontrol/pull/2277#issuecomment-389365591 Refer to this link for build results (access rights to CI server needed):

[GitHub] asfgit commented on issue #2278: Add TO Go caches/stats endpoint

2018-05-15 Thread GitBox
asfgit commented on issue #2278: Add TO Go caches/stats endpoint URL: https://github.com/apache/incubator-trafficcontrol/pull/2278#issuecomment-389355518 Refer to this link for build results (access rights to CI server needed):

[GitHub] asfgit commented on issue #2108: create roles crud endpoints in golang

2018-05-15 Thread GitBox
asfgit commented on issue #2108: create roles crud endpoints in golang URL: https://github.com/apache/incubator-trafficcontrol/pull/2108#issuecomment-389347426 Refer to this link for build results (access rights to CI server needed):

[GitHub] rob05c commented on issue #2232: Rewrite Traffic Ops CRConfig Table Endpoints in Go

2018-05-15 Thread GitBox
rob05c commented on issue #2232: Rewrite Traffic Ops CRConfig Table Endpoints in Go URL: https://github.com/apache/incubator-trafficcontrol/issues/2232#issuecomment-387444293 Ok, we have PRs for all major table routes, but many of them are only "CRUD", and missing additional endpoints.

[GitHub] rob05c commented on issue #2277: Allow the capture group for a route parameter to be defined

2018-05-15 Thread GitBox
rob05c commented on issue #2277: Allow the capture group for a route parameter to be defined URL: https://github.com/apache/incubator-trafficcontrol/pull/2277#issuecomment-389339315 I'm still not convinced this is worth the readability cost. Regex is hard to read. This makes the routes

[GitHub] rob05c commented on issue #2277: Allow the capture group for a route parameter to be defined

2018-05-15 Thread GitBox
rob05c commented on issue #2277: Allow the capture group for a route parameter to be defined URL: https://github.com/apache/incubator-trafficcontrol/pull/2277#issuecomment-389339315 I'm still not convinced this is worth the readability cost. Regex is hard to read. This makes the routes

[GitHub] DylanVolz commented on issue #2273: TO golang API framework tenancy enhancements

2018-05-15 Thread GitBox
DylanVolz commented on issue #2273: TO golang API framework tenancy enhancements URL: https://github.com/apache/incubator-trafficcontrol/issues/2273#issuecomment-389337746 +1 This is an automated message from the Apache

[GitHub] rob05c opened a new pull request #2278: Add TO Go caches/stats endpoint

2018-05-15 Thread GitBox
rob05c opened a new pull request #2278: Add TO Go caches/stats endpoint URL: https://github.com/apache/incubator-trafficcontrol/pull/2278 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] DylanVolz opened a new pull request #2277: Allow the capture group for a route parameter to be defined

2018-05-15 Thread GitBox
DylanVolz opened a new pull request #2277: Allow the capture group for a route parameter to be defined URL: https://github.com/apache/incubator-trafficcontrol/pull/2277 this is done in the form {parameterName:capturePattern} instead of {parameterName} in the route definition in routes.go.

[GitHub] asfgit commented on issue #2236: update portal info bubbles

2018-05-15 Thread GitBox
asfgit commented on issue #2236: update portal info bubbles URL: https://github.com/apache/incubator-trafficcontrol/pull/2236#issuecomment-389334635 Refer to this link for build results (access rights to CI server needed):

[GitHub] asfgit commented on issue #2236: update portal info bubbles

2018-05-15 Thread GitBox
asfgit commented on issue #2236: update portal info bubbles URL: https://github.com/apache/incubator-trafficcontrol/pull/2236#issuecomment-389322775 Refer to this link for build results (access rights to CI server needed):

[GitHub] asfgit commented on issue #2276: Migration to add anonymousBlockingEnabled field to deliveryservice_request json blob data

2018-05-15 Thread GitBox
asfgit commented on issue #2276: Migration to add anonymousBlockingEnabled field to deliveryservice_request json blob data URL: https://github.com/apache/incubator-trafficcontrol/pull/2276#issuecomment-389318776 Can one of the admins verify this patch?

[GitHub] asfgit commented on issue #2276: Migration to add anonymousBlockingEnabled field to deliveryservice_request json blob data

2018-05-15 Thread GitBox
asfgit commented on issue #2276: Migration to add anonymousBlockingEnabled field to deliveryservice_request json blob data URL: https://github.com/apache/incubator-trafficcontrol/pull/2276#issuecomment-389318472 Can one of the admins verify this patch?

[GitHub] rivasj opened a new pull request #2276: Migration to add anonymousBlockingEnabled field to deliveryservice_request json blob data

2018-05-15 Thread GitBox
rivasj opened a new pull request #2276: Migration to add anonymousBlockingEnabled field to deliveryservice_request json blob data URL: https://github.com/apache/incubator-trafficcontrol/pull/2276 Add anonymousBlockingEnabled field to deliveryservice_request json blob data in db

[GitHub] asfgit commented on issue #2247: Add an Origin API

2018-05-15 Thread GitBox
asfgit commented on issue #2247: Add an Origin API URL: https://github.com/apache/incubator-trafficcontrol/pull/2247#issuecomment-389307651 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR/1576/

[GitHub] rob05c commented on issue #2274: Profiles endpoint unordered

2018-05-15 Thread GitBox
rob05c commented on issue #2274: Profiles endpoint unordered URL: https://github.com/apache/incubator-trafficcontrol/issues/2274#issuecomment-389306244 Ordering in the database can be expensive, and the API has never guaranteed order. See

[GitHub] dneuman64 opened a new issue #2275: Download ISO should actually download the ISO

2018-05-15 Thread GitBox
dneuman64 opened a new issue #2275: Download ISO should actually download the ISO URL: https://github.com/apache/incubator-trafficcontrol/issues/2275 Currently, when you generate an ISO you are given a link to download the ISO. If you are running a traffic ops in a HA fashion, it is no

[GitHub] jhg03a opened a new issue #2274: Profiles endpoint unordered

2018-05-15 Thread GitBox
jhg03a opened a new issue #2274: Profiles endpoint unordered URL: https://github.com/apache/incubator-trafficcontrol/issues/2274 With the Golang rewrite, the profiles endpoint is no longer ordered by name. This makes the dialogs such as in delivery services more difficult to navigate.

[GitHub] jhg03a closed issue #2263: Improve TO Client Library Documentation

2018-05-15 Thread GitBox
jhg03a closed issue #2263: Improve TO Client Library Documentation URL: https://github.com/apache/incubator-trafficcontrol/issues/2263 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] mitchell852 closed issue #886: [TC-287] Add support for per-Delivery Service routing/name

2018-05-15 Thread GitBox
mitchell852 closed issue #886: [TC-287] Add support for per-Delivery Service routing/name URL: https://github.com/apache/incubator-trafficcontrol/issues/886 This is an automated message from the Apache Git Service. To

[GitHub] rawlinp commented on issue #886: [TC-287] Add support for per-Delivery Service routing/name

2018-05-15 Thread GitBox
rawlinp commented on issue #886: [TC-287] Add support for per-Delivery Service routing/name URL: https://github.com/apache/incubator-trafficcontrol/issues/886#issuecomment-389292459 This can be closed - implemented in #865

[GitHub] rob05c commented on a change in pull request #2262: Part 1 of Range Request handling

2018-05-15 Thread GitBox
rob05c commented on a change in pull request #2262: Part 1 of Range Request handling URL: https://github.com/apache/incubator-trafficcontrol/pull/2262#discussion_r188122792 ## File path: grove/plugin/range_req_handler.go ## @@ -0,0 +1,225 @@ +package plugin + +/* +

[GitHub] rawlinp opened a new issue #2273: TO golang API framework tenancy enhancements

2018-05-15 Thread GitBox
rawlinp opened a new issue #2273: TO golang API framework tenancy enhancements URL: https://github.com/apache/incubator-trafficcontrol/issues/2273 While working on the Origin API, I found a few things related to tenancy in the TO golang API framework that should be enhanced: 1. The

[GitHub] asfgit commented on issue #2010: Go login

2018-05-15 Thread GitBox
asfgit commented on issue #2010: Go login URL: https://github.com/apache/incubator-trafficcontrol/pull/2010#issuecomment-389214762 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR/1575/ Test

[GitHub] asfgit commented on issue #2236: update portal info bubbles

2018-05-15 Thread GitBox
asfgit commented on issue #2236: update portal info bubbles URL: https://github.com/apache/incubator-trafficcontrol/pull/2236#issuecomment-389209826 Refer to this link for build results (access rights to CI server needed):

[GitHub] elsloo opened a new issue #2272: Only create/update/modify DNSSEC keys for DS types that are routed on the CDN

2018-05-15 Thread GitBox
elsloo opened a new issue #2272: Only create/update/modify DNSSEC keys for DS types that are routed on the CDN URL: https://github.com/apache/incubator-trafficcontrol/issues/2272 Create DNSSEC keys only for DS types that are routed on the CDN, such as any HTTP or DNS type. ANY_MAP, or

[GitHub] rob05c commented on a change in pull request #2246: Add HitCount and FreshFor

2018-05-15 Thread GitBox
rob05c commented on a change in pull request #2246: Add HitCount and FreshFor URL: https://github.com/apache/incubator-trafficcontrol/pull/2246#discussion_r188317853 ## File path: grove/web/util.go ## @@ -198,3 +200,145 @@ func ParseHTTPDate(d string) (time.Time, bool) {

[GitHub] rob05c commented on a change in pull request #2246: Add HitCount and FreshFor

2018-05-15 Thread GitBox
rob05c commented on a change in pull request #2246: Add HitCount and FreshFor URL: https://github.com/apache/incubator-trafficcontrol/pull/2246#discussion_r188317853 ## File path: grove/web/util.go ## @@ -198,3 +200,145 @@ func ParseHTTPDate(d string) (time.Time, bool) {

[GitHub] mitchell852 commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup

2018-05-15 Thread GitBox
mitchell852 commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#discussion_r188317346 ## File path: traffic_ops/app/db/migrations/2018032100_cache_group_fallback.sql

[GitHub] mitchell852 commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup

2018-05-15 Thread GitBox
mitchell852 commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#discussion_r188315094 ## File path: traffic_ops/app/lib/UI/Topology.pm ## @@ -250,6 +250,15 @@ sub

[GitHub] mitchell852 commented on issue #2029: [Issue 1907] TO API for backup edge cachegroup

2018-05-15 Thread GitBox
mitchell852 commented on issue #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#issuecomment-389192781 this seems ok from an api perspective. need someone to review/test the TR part. @rawlinp @rivasj @elsloo

[GitHub] rob05c commented on a change in pull request #2262: Part 1 of Range Request handling

2018-05-15 Thread GitBox
rob05c commented on a change in pull request #2262: Part 1 of Range Request handling URL: https://github.com/apache/incubator-trafficcontrol/pull/2262#discussion_r188314219 ## File path: grove/plugin/range_req_handler.go ## @@ -0,0 +1,225 @@ +package plugin + +/* +

[GitHub] asfgit commented on issue #2271: if user.role == admin, then allow the option to immediately fulfill DSR (d…

2018-05-15 Thread GitBox
asfgit commented on issue #2271: if user.role == admin, then allow the option to immediately fulfill DSR (d… URL: https://github.com/apache/incubator-trafficcontrol/pull/2271#issuecomment-389192028 Refer to this link for build results (access rights to CI server needed):

[GitHub] mitchell852 commented on issue #2029: [Issue 1907] TO API for backup edge cachegroup

2018-05-15 Thread GitBox
mitchell852 commented on issue #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#issuecomment-389185605 yes to last comment. that way POST is reserved for creating and PUT is reserved for updating and they don’t

[GitHub] mitchell852 commented on issue #2174: TO/TP should allow for a configuration such that admins do not have to submit DSRs

2018-05-15 Thread GitBox
mitchell852 commented on issue #2174: TO/TP should allow for a configuration such that admins do not have to submit DSRs URL: https://github.com/apache/incubator-trafficcontrol/issues/2174#issuecomment-389181872 Implemented as such: If DSR is enabled and user.role=admin, then DSR

[GitHub] mitchell852 opened a new pull request #2271: if user.role == admin, then allow the option to immediately fulfill DSR (d…

2018-05-15 Thread GitBox
mitchell852 opened a new pull request #2271: if user.role == admin, then allow the option to immediately fulfill DSR (d… URL: https://github.com/apache/incubator-trafficcontrol/pull/2271 …elivery service requests) fixes #2174

[GitHub] knutsel commented on a change in pull request #2246: Add HitCount and FreshFor

2018-05-15 Thread GitBox
knutsel commented on a change in pull request #2246: Add HitCount and FreshFor URL: https://github.com/apache/incubator-trafficcontrol/pull/2246#discussion_r188269492 ## File path: grove/web/util.go ## @@ -198,3 +200,145 @@ func ParseHTTPDate(d string) (time.Time, bool) {

[GitHub] asfgit commented on issue #2088: TO Go: implement tenants CRUD

2018-05-14 Thread GitBox
asfgit commented on issue #2088: TO Go: implement tenants CRUD URL: https://github.com/apache/incubator-trafficcontrol/pull/2088#issuecomment-389036164 Refer to this link for build results (access rights to CI server needed):

[GitHub] asfgit commented on issue #2088: TO Go: implement tenants CRUD

2018-05-14 Thread GitBox
asfgit commented on issue #2088: TO Go: implement tenants CRUD URL: https://github.com/apache/incubator-trafficcontrol/pull/2088#issuecomment-389032173 Refer to this link for build results (access rights to CI server needed):

[GitHub] asfgit commented on issue #2247: Add an Origin API

2018-05-14 Thread GitBox
asfgit commented on issue #2247: Add an Origin API URL: https://github.com/apache/incubator-trafficcontrol/pull/2247#issuecomment-388998048 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR/1570/

[GitHub] asfgit commented on issue #2247: Add an Origin API

2018-05-14 Thread GitBox
asfgit commented on issue #2247: Add an Origin API URL: https://github.com/apache/incubator-trafficcontrol/pull/2247#issuecomment-388997317 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR/1569/

[GitHub] asfgit commented on issue #2270: Add TO Go Servers Details endpoint

2018-05-14 Thread GitBox
asfgit commented on issue #2270: Add TO Go Servers Details endpoint URL: https://github.com/apache/incubator-trafficcontrol/pull/2270#issuecomment-388989863 Refer to this link for build results (access rights to CI server needed):

[GitHub] rob05c commented on a change in pull request #2262: Part 1 of Range Request handling

2018-05-14 Thread GitBox
rob05c commented on a change in pull request #2262: Part 1 of Range Request handling URL: https://github.com/apache/incubator-trafficcontrol/pull/2262#discussion_r188122792 ## File path: grove/plugin/range_req_handler.go ## @@ -0,0 +1,225 @@ +package plugin + +/* +

[GitHub] rob05c commented on a change in pull request #2262: Part 1 of Range Request handling

2018-05-14 Thread GitBox
rob05c commented on a change in pull request #2262: Part 1 of Range Request handling URL: https://github.com/apache/incubator-trafficcontrol/pull/2262#discussion_r188121922 ## File path: grove/plugin/range_req_handler.go ## @@ -0,0 +1,225 @@ +package plugin + +/* +

[GitHub] rob05c commented on a change in pull request #2262: Part 1 of Range Request handling

2018-05-14 Thread GitBox
rob05c commented on a change in pull request #2262: Part 1 of Range Request handling URL: https://github.com/apache/incubator-trafficcontrol/pull/2262#discussion_r188121895 ## File path: grove/plugin/range_req_handler.go ## @@ -0,0 +1,225 @@ +package plugin + +/* +

[GitHub] rob05c commented on a change in pull request #2262: Part 1 of Range Request handling

2018-05-14 Thread GitBox
rob05c commented on a change in pull request #2262: Part 1 of Range Request handling URL: https://github.com/apache/incubator-trafficcontrol/pull/2262#discussion_r188121571 ## File path: grove/plugin/range_req_handler.go ## @@ -0,0 +1,225 @@ +package plugin + +/* +

[GitHub] rob05c commented on a change in pull request #2262: Part 1 of Range Request handling

2018-05-14 Thread GitBox
rob05c commented on a change in pull request #2262: Part 1 of Range Request handling URL: https://github.com/apache/incubator-trafficcontrol/pull/2262#discussion_r188121571 ## File path: grove/plugin/range_req_handler.go ## @@ -0,0 +1,225 @@ +package plugin + +/* +

[GitHub] rob05c commented on a change in pull request #2262: Part 1 of Range Request handling

2018-05-14 Thread GitBox
rob05c commented on a change in pull request #2262: Part 1 of Range Request handling URL: https://github.com/apache/incubator-trafficcontrol/pull/2262#discussion_r188121450 ## File path: grove/plugin/range_req_handler.go ## @@ -0,0 +1,225 @@ +package plugin + +/* +

[GitHub] rob05c commented on a change in pull request #2262: Part 1 of Range Request handling

2018-05-14 Thread GitBox
rob05c commented on a change in pull request #2262: Part 1 of Range Request handling URL: https://github.com/apache/incubator-trafficcontrol/pull/2262#discussion_r188121319 ## File path: grove/plugin/plugin.go ## @@ -91,6 +92,12 @@ type BeforeRespondData struct {

[GitHub] rob05c commented on a change in pull request #2246: Add HitCount and FreshFor

2018-05-14 Thread GitBox
rob05c commented on a change in pull request #2246: Add HitCount and FreshFor URL: https://github.com/apache/incubator-trafficcontrol/pull/2246#discussion_r188120447 ## File path: grove/web/util.go ## @@ -198,3 +200,145 @@ func ParseHTTPDate(d string) (time.Time, bool) {

[GitHub] rob05c commented on a change in pull request #2246: Add HitCount and FreshFor

2018-05-14 Thread GitBox
rob05c commented on a change in pull request #2246: Add HitCount and FreshFor URL: https://github.com/apache/incubator-trafficcontrol/pull/2246#discussion_r188119204 ## File path: grove/plugin/http_cacheinspector.go ## @@ -169,16 +170,17 @@ func cacheinspect(icfg

[GitHub] rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go

2018-05-14 Thread GitBox
rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go URL: https://github.com/apache/incubator-trafficcontrol/pull/2269#discussion_r188116061 ## File path: traffic_ops/traffic_ops_golang/deliveryservice/servers/servers.go ## @@

[GitHub] rob05c commented on issue #2232: Rewrite Traffic Ops CRConfig Table Endpoints in Go

2018-05-14 Thread GitBox
rob05c commented on issue #2232: Rewrite Traffic Ops CRConfig Table Endpoints in Go URL: https://github.com/apache/incubator-trafficcontrol/issues/2232#issuecomment-387444293 Ok, we have PRs for all major table routes, but many of them are only "CRUD", and missing additional endpoints.

[GitHub] rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go

2018-05-14 Thread GitBox
rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go URL: https://github.com/apache/incubator-trafficcontrol/pull/2269#discussion_r188118026 ## File path: traffic_ops/traffic_ops_golang/deliveryservice/servers/servers.go ## @@

[GitHub] rob05c opened a new pull request #2270: Add TO Go Servers Details endpoint

2018-05-14 Thread GitBox
rob05c opened a new pull request #2270: Add TO Go Servers Details endpoint URL: https://github.com/apache/incubator-trafficcontrol/pull/2270 This is an automated message from the Apache Git Service. To respond to the

[GitHub] rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go

2018-05-14 Thread GitBox
rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go URL: https://github.com/apache/incubator-trafficcontrol/pull/2269#discussion_r188110723 ## File path: infrastructure/docker/traffic_ops/Dockerfile_psql ## @@ -0,0 +1,20 @@

[GitHub] rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go

2018-05-14 Thread GitBox
rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go URL: https://github.com/apache/incubator-trafficcontrol/pull/2269#discussion_r188112817 ## File path: traffic_ops/traffic_ops_golang/deliveryservice/servers/servers.go ## @@

[GitHub] rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go

2018-05-14 Thread GitBox
rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go URL: https://github.com/apache/incubator-trafficcontrol/pull/2269#discussion_r188114096 ## File path: infrastructure/docker/traffic_ops/dbInit.sh ## @@ -0,0 +1,8 @@

[GitHub] rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go

2018-05-14 Thread GitBox
rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go URL: https://github.com/apache/incubator-trafficcontrol/pull/2269#discussion_r188117012 ## File path: traffic_ops/traffic_ops_golang/deliveryservice/servers/servers.go ## @@

[GitHub] rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go

2018-05-14 Thread GitBox
rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go URL: https://github.com/apache/incubator-trafficcontrol/pull/2269#discussion_r188112552 ## File path: traffic_ops/traffic_ops_golang/deliveryservice/servers/servers.go ## @@

[GitHub] rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go

2018-05-14 Thread GitBox
rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go URL: https://github.com/apache/incubator-trafficcontrol/pull/2269#discussion_r188113319 ## File path: traffic_ops/traffic_ops_golang/deliveryservice/servers/servers.go ## @@

[GitHub] rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go

2018-05-14 Thread GitBox
rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go URL: https://github.com/apache/incubator-trafficcontrol/pull/2269#discussion_r188111222 ## File path: lib/go-tc/deliveryservice_servers.go ## @@ -78,3 +99,65 @@ type DssServer

[GitHub] rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go

2018-05-14 Thread GitBox
rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go URL: https://github.com/apache/incubator-trafficcontrol/pull/2269#discussion_r188114148 ## File path: infrastructure/docker/traffic_ops/Dockerfile_psql ## @@ -0,0 +1,20 @@

[GitHub] rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go

2018-05-14 Thread GitBox
rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go URL: https://github.com/apache/incubator-trafficcontrol/pull/2269#discussion_r188111742 ## File path: traffic_ops/traffic_ops_golang/deliveryservice/servers/servers.go ## @@

[GitHub] rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go

2018-05-14 Thread GitBox
rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go URL: https://github.com/apache/incubator-trafficcontrol/pull/2269#discussion_r188115566 ## File path: traffic_ops/traffic_ops_golang/deliveryservice/servers/servers.go ## @@

[GitHub] rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go

2018-05-14 Thread GitBox
rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go URL: https://github.com/apache/incubator-trafficcontrol/pull/2269#discussion_r188114240 ## File path: lib/go-tc/deliveryservice_servers.go ## @@ -1,6 +1,8 @@ package tc

[GitHub] rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go

2018-05-14 Thread GitBox
rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go URL: https://github.com/apache/incubator-trafficcontrol/pull/2269#discussion_r188110995 ## File path: lib/go-tc/deliveryservice_servers.go ## @@ -19,21 +21,40 @@ import "time"

[GitHub] rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go

2018-05-14 Thread GitBox
rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go URL: https://github.com/apache/incubator-trafficcontrol/pull/2269#discussion_r188114503 ## File path: traffic_ops/traffic_ops_golang/deliveryservice/servers/servers.go ## @@

[GitHub] rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go

2018-05-14 Thread GitBox
rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go URL: https://github.com/apache/incubator-trafficcontrol/pull/2269#discussion_r188112182 ## File path: traffic_ops/traffic_ops_golang/deliveryservice/servers/servers.go ## @@

[GitHub] rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go

2018-05-14 Thread GitBox
rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go URL: https://github.com/apache/incubator-trafficcontrol/pull/2269#discussion_r188114777 ## File path: traffic_ops/traffic_ops_golang/deliveryservice/servers/servers.go ## @@

[GitHub] rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go

2018-05-14 Thread GitBox
rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go URL: https://github.com/apache/incubator-trafficcontrol/pull/2269#discussion_r188110995 ## File path: lib/go-tc/deliveryservice_servers.go ## @@ -19,21 +21,40 @@ import "time"

[GitHub] rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go

2018-05-14 Thread GitBox
rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go URL: https://github.com/apache/incubator-trafficcontrol/pull/2269#discussion_r188115772 ## File path: traffic_ops/traffic_ops_golang/deliveryservice/servers/servers.go ## @@

[GitHub] rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go

2018-05-14 Thread GitBox
rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go URL: https://github.com/apache/incubator-trafficcontrol/pull/2269#discussion_r188114875 ## File path: traffic_ops/traffic_ops_golang/deliveryservice/servers/servers.go ## @@

[GitHub] rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go

2018-05-14 Thread GitBox
rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go URL: https://github.com/apache/incubator-trafficcontrol/pull/2269#discussion_r188115110 ## File path: traffic_ops/traffic_ops_golang/deliveryservice/servers/servers.go ## @@

[GitHub] asfgit commented on issue #2149: TO and TODB in docker front-to-back

2018-05-14 Thread GitBox
asfgit commented on issue #2149: TO and TODB in docker front-to-back URL: https://github.com/apache/incubator-trafficcontrol/pull/2149#issuecomment-388982939 Refer to this link for build results (access rights to CI server needed):

[GitHub] asfgit commented on issue #2269: Deliveryservice_Server API conversion to Go

2018-05-14 Thread GitBox
asfgit commented on issue #2269: Deliveryservice_Server API conversion to Go URL: https://github.com/apache/incubator-trafficcontrol/pull/2269#issuecomment-388975850 Can one of the admins verify this patch? This is an

[GitHub] asfgit commented on issue #2269: Deliveryservice_Server API conversion to Go

2018-05-14 Thread GitBox
asfgit commented on issue #2269: Deliveryservice_Server API conversion to Go URL: https://github.com/apache/incubator-trafficcontrol/pull/2269#issuecomment-388975605 Can one of the admins verify this patch? This is an

[GitHub] ajschmidt opened a new pull request #2269: Deliveryservice_Server API conversion to Go

2018-05-14 Thread GitBox
ajschmidt opened a new pull request #2269: Deliveryservice_Server API conversion to Go URL: https://github.com/apache/incubator-trafficcontrol/pull/2269 This PR converts these API methods to Go: GETapi/1.1/deliveryserviceserver POST

[GitHub] dangogh commented on issue #2149: TO and TODB in docker front-to-back

2018-05-14 Thread GitBox
dangogh commented on issue #2149: TO and TODB in docker front-to-back URL: https://github.com/apache/incubator-trafficcontrol/pull/2149#issuecomment-388970888 closing for now while still WIP This is an automated message from

  1   2   3   4   5   6   7   8   9   10   >