Github user mtorluemke commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/786#discussion_r131968364
--- Diff: traffic_ops/bin/traffic_ops_ort.pl ---
@@ -1623,9 +1623,7 @@ sub check_lwp_response_content_length {
my $url
Github user mtorluemke commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/785#discussion_r131964778
--- Diff: traffic_ops/bin/traffic_ops_ort.pl ---
@@ -1266,15 +1266,19 @@ sub check_plugins {
( my @parts
Github user mtorluemke commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/772#discussion_r131261159
--- Diff: traffic_monitor_golang/traffic_monitor/threadsafe/polledcaches.go
---
@@ -103,11 +116,22 @@ func copyCaches(a map
Github user mtorluemke commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/772#discussion_r131169393
--- Diff: traffic_monitor_golang/traffic_monitor/threadsafe/polledcaches.go
---
@@ -103,11 +116,22 @@ func copyCaches(a map
Github user mtorluemke commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/552#discussion_r115272927
--- Diff: traffic_ops/app/lib/API/Configs/ApacheTrafficServer.pm ---
@@ -1470,6 +1473,9 @@ sub ssl_multicert_dot_config
Github user mtorluemke commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/423
Looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user mtorluemke commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/416#discussion_r109228127
--- Diff: traffic_ops/bin/traffic_ops_ort.pl ---
@@ -1770,6 +1735,11 @@ sub get_cfg_file_list
Github user mtorluemke commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/299#discussion_r102822502
--- Diff: traffic_ops/app/lib/UI/Server.pm ---
@@ -977,7 +1017,16 @@ sub postupdate {
my $update_server
Github user mtorluemke commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/299#discussion_r102822448
--- Diff: traffic_ops/app/lib/UI/Server.pm ---
@@ -949,7 +985,11 @@ sub postupdate {
my $self = shift;
my
Github user mtorluemke commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/157
Yeah, 715 files and almost 390k lines seems excessive. On the other hand,
"go get" requires more babysitting over time. Feels like we should choose
either of the
10 matches
Mail list logo
