Jenkins build is back to normal : ubuntu_16_10-master ยป gcc,ubuntu_16_10,debug #79

2017-01-18 Thread jenkins
https://ci.trafficserver.apache.org/job/ubuntu_16_10-master/compiler=gcc,label=ubuntu_16_10,type=debug/79/

[GitHub] trafficserver issue #1333: PluginVC::inactive_event is not set to NULL after...

2017-01-18 Thread oknet
Github user oknet closed the issue at: https://github.com/apache/trafficserver/issues/1333 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] trafficserver pull request #1334: Do not reschedule the periodic inactive_ev...

2017-01-18 Thread oknet
Github user oknet closed the pull request at: https://github.com/apache/trafficserver/pull/1334 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1291: CID 1196420: Error handling issues (CHECKED_RETUR...

2017-01-18 Thread jablko
Github user jablko commented on the issue: https://github.com/apache/trafficserver/issues/1291 On second thought, I don't know the proper way to fix this. @zwoop Do you have any suggestions? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] trafficserver issue #1291: CID 1196420: Error handling issues (CHECKED_RETUR...

2017-01-18 Thread jablko
Github user jablko commented on the issue: https://github.com/apache/trafficserver/issues/1291 I think if the first argument -- buf -- is nullptr, print() should always return 1 [1]? I'll take a stab at fixing this. [1]

[GitHub] trafficserver issue #1341: openssl errors for every request

2017-01-18 Thread randall
Github user randall commented on the issue: https://github.com/apache/trafficserver/issues/1341 The full stack from the thread hitting this: [stack.txt](https://github.com/apache/trafficserver/files/715338/stack.txt) --- If your project is set up for it, you can reply to

[GitHub] trafficserver issue #1343: Change connect_attempts_rr_retries test to match ...

2017-01-18 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1343 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/1245/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1343: Change connect_attempts_rr_retries test to match ...

2017-01-18 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1343 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1353/ for details. --- If your project is set up for it, you can reply to this email and have

[GitHub] trafficserver issue #1343: Change connect_attempts_rr_retries test to match ...

2017-01-18 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1343 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] trafficserver issue #1342: Fix CID 1368305: Dereference before null check

2017-01-18 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1342 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/1244/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver pull request #1343: Change connect_attempts_rr_retries test to...

2017-01-18 Thread randall
GitHub user randall opened a pull request: https://github.com/apache/trafficserver/pull/1343 Change connect_attempts_rr_retries test to match warning text Fixes #1340 You can merge this pull request into a Git repository by running: $ git pull

[GitHub] trafficserver issue #1342: Fix CID 1368305: Dereference before null check

2017-01-18 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1342 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1352/ for details. --- If your project is set up for it, you can reply to this email and have

[GitHub] trafficserver issue #1341: openssl errors for every request

2017-01-18 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/issues/1341 Looking at 63b924e8, it seems we produce this error, and do these expensive lookups / additions on every request? ```C++ @@ -4018,7 +4020,7 @@ HttpSM::do_remap_request(bool

[GitHub] trafficserver pull request #1342: Fix CID 1368305: Dereference before null c...

2017-01-18 Thread jablko
GitHub user jablko opened a pull request: https://github.com/apache/trafficserver/pull/1342 Fix CID 1368305: Dereference before null check #1302 You can merge this pull request into a Git repository by running: $ git pull https://github.com/jablko/trafficserver cid1368305

[GitHub] trafficserver issue #1341: openssl errors for every request

2017-01-18 Thread randall
GitHub user randall opened an issue: https://github.com/apache/trafficserver/issues/1341 openssl errors for every request With ATS 7.1, the server will come up cleanly (same configs that work fine under 7.0.0), but a request will generate the following log lines. `Jan 18

[GitHub] trafficserver issue #1302: CID 1368306 & 1368305: NULLPTR and security BP in...

2017-01-18 Thread jablko
Github user jablko commented on the issue: https://github.com/apache/trafficserver/issues/1302 I think CID 1368306 is a false positive? The open() file_arguments[i] isn't the same as the access() file_arguments[i] because there's a ++i in between. I'm not sure how to proceed.

[GitHub] trafficserver issue #1340: new warning running 7.1

2017-01-18 Thread randall
GitHub user randall opened an issue: https://github.com/apache/trafficserver/issues/1340 new warning running 7.1 On startup of 7.1.0, I now see this warning: ` WARNING: connect_attempts_rr_retries (3) is greater than connect_attempts_max_retries (3), this means

[GitHub] trafficserver issue #1339: Revert "Modify TSHttpTxnHookAdd to add hook only ...

2017-01-18 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1339 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1351/ for details. --- If your project is set up for it, you can reply to this email and have

[GitHub] trafficserver issue #1320: Modify TSHttpTxnHookAdd to add hook only once

2017-01-18 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1320 Not going to do the reverts here, but please be careful going forward with squashing commits that are fixes / review comments. --- If your project is set up for it, you can reply to this

[GitHub] trafficserver pull request #1339: Revert "Modify TSHttpTxnHookAdd to add hoo...

2017-01-18 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1339 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #1339: Revert "Modify TSHttpTxnHookAdd to add hoo...

2017-01-18 Thread zwoop
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1339 Revert "Modify TSHttpTxnHookAdd to add hook only once" Reverts apache/trafficserver#1320 You can merge this pull request into a Git repository by running: $ git pull

[GitHub] trafficserver issue #1338: Revert "Modify TSHttpTxnHookAdd to add hook only ...

2017-01-18 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1338 Linux build *failed*! See https://ci.trafficserver.apache.org/job/Github-Linux/1243/ for details. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver pull request #1338: Revert "Modify TSHttpTxnHookAdd to add hoo...

2017-01-18 Thread zwoop
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1338 Revert "Modify TSHttpTxnHookAdd to add hook only once" Reverts apache/trafficserver#1320 You can merge this pull request into a Git repository by running: $ git pull

[GitHub] trafficserver pull request #1338: Revert "Modify TSHttpTxnHookAdd to add hoo...

2017-01-18 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1338 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1320: Modify TSHttpTxnHookAdd to add hook only once

2017-01-18 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1320 Well, dammit, I screwed up, this really shouldn't have been merged, you really must squash multiple commits like this into one commit (now I landed one commit that is not correct). :-/ ---

[GitHub] trafficserver pull request #1320: Modify TSHttpTxnHookAdd to add hook only o...

2017-01-18 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1320 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1320: Modify TSHttpTxnHookAdd to add hook only once

2017-01-18 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1320 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1350/ for details. --- If your project is set up for it, you can reply to this email and have

[GitHub] trafficserver issue #1320: Modify TSHttpTxnHookAdd to add hook only once

2017-01-18 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1320 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/1242/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1320: Modify TSHttpTxnHookAdd to add hook only once

2017-01-18 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1320 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1349/ for details. --- If your project is set up for it, you can reply to this email and have

[GitHub] trafficserver issue #1320: Modify TSHttpTxnHookAdd to add hook only once

2017-01-18 Thread meeramn
Github user meeramn commented on the issue: https://github.com/apache/trafficserver/pull/1320 Ran clang-format and pushed the change. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] trafficserver issue #1320: Modify TSHttpTxnHookAdd to add hook only once

2017-01-18 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1320 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] trafficserver issue #1337: This avoids some badness around some STL implemen...

2017-01-18 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1337 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1348/ for details. --- If your project is set up for it, you can reply to this email and have

[GitHub] trafficserver issue #1337: This avoids some badness around some STL implemen...

2017-01-18 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1337 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/1241/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver pull request #1337: This avoids some badness around some STL i...

2017-01-18 Thread SolidWallOfCode
Github user SolidWallOfCode commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1337#discussion_r96737701 --- Diff: plugins/experimental/cache_promote/cache_promote.cc --- @@ -327,10 +334,12 @@ class LRUPolicy : public PromotionPolicy private:

[GitHub] trafficserver pull request #1337: This avoids some badness around some STL i...

2017-01-18 Thread zwoop
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1337 This avoids some badness around some STL implementations Where the complexity of ::size is not O(1) Can someone please carefully review that I did the ++'s and --'s in all the

[GitHub] trafficserver issue #1313: Use Autoconf checks vs. OPENSSL_VERSION_NUMBER

2017-01-18 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1313 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/1240/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1313: Use Autoconf checks vs. OPENSSL_VERSION_NUMBER

2017-01-18 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1313 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1347/ for details. --- If your project is set up for it, you can reply to this email and have

[GitHub] trafficserver issue #1336: cache promote plugin takes too much calculating s...

2017-01-18 Thread vmamidi
GitHub user vmamidi opened an issue: https://github.com/apache/trafficserver/issues/1336 cache promote plugin takes too much calculating size of LRUList pstack shows that cache promote plugin spends lot of time calculating too much time in determining the size of LRUList

[GitHub] trafficserver issue #1335: Deadlock in HostDB

2017-01-18 Thread zwoop
GitHub user zwoop opened an issue: https://github.com/apache/trafficserver/issues/1335 Deadlock in HostDB We have some 7.0.0 boxes, which ends up completely wedged, where all ET_NET threads get stuck on the same lock (so, a deadlock): ``` #6

[GitHub] trafficserver issue #1309: Fixes for building with LibreSSL

2017-01-18 Thread bryancall
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/pull/1309 Is this pull request needed anymore after #1313 ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] trafficserver issue #1303: TS-5107: Changes to autolinking in Docutils 1.3

2017-01-18 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1303 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1346/ for details. --- If your project is set up for it, you can reply to this email and have

[GitHub] trafficserver issue #1303: TS-5107: Changes to autolinking in Docutils 1.3

2017-01-18 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1303 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/1239/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1175: socks.config - dest_ip rule issue

2017-01-18 Thread oknet
Github user oknet commented on the issue: https://github.com/apache/trafficserver/issues/1175 I think the message at below indicate your run-time openssl library is different from your build server. ``` /usr/local/lib/libssl.so.8: Undefined symbol

[GitHub] trafficserver issue #1326: Core dump in SSLAccept / SSLNetVConnection::sslSe...

2017-01-18 Thread oknet
Github user oknet commented on the issue: https://github.com/apache/trafficserver/issues/1326 I only saw the TS-4363 once and can not repeat it. How about your issue ? Is it repeatable ? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] trafficserver issue #1334: Do not reschedule the periodic inactive_event and...

2017-01-18 Thread oknet
Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/1334 Link it to https://issues.apache.org/jira/browse/TS-3235 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] trafficserver issue #1334: Do not reschedule the periodic inactive_event and...

2017-01-18 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1334 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/1238/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1334: Do not reschedule the periodic inactive_event and...

2017-01-18 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1334 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1345/ for details. --- If your project is set up for it, you can reply to this email and have

[GitHub] trafficserver issue #1334: Do not reschedule the periodic inactive_event and...

2017-01-18 Thread oknet
Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/1334 The inactive_event is a periodic event that is create by eventProcessor.schedule_every(). We should not reschedule it by schedule_in(). We cancelled it by call_event->cancel() even

[GitHub] trafficserver pull request #1334: Do not reschedule the periodic inactive_ev...

2017-01-18 Thread oknet
GitHub user oknet opened a pull request: https://github.com/apache/trafficserver/pull/1334 Do not reschedule the periodic inactive_event and cancel it after signal timeout event to SM this resolve issue 1333 You can merge this pull request into a Git repository by running: $

[GitHub] trafficserver issue #1332: Updates to cache documentation and Cache Tool.

2017-01-18 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1332 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/1237/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1333: PluginVC::inactive_event is not set to NULL after...

2017-01-18 Thread oknet
GitHub user oknet opened an issue: https://github.com/apache/trafficserver/issues/1333 PluginVC::inactive_event is not set to NULL after cancelled. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] trafficserver issue #1332: Updates to cache documentation and Cache Tool.

2017-01-18 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1332 FreeBSD build *failed*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1344/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1332: Updates to cache documentation and Cache Tool.

2017-01-18 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1332 Linux build *failed*! See https://ci.trafficserver.apache.org/job/Github-Linux/1236/ for details. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver issue #1332: Updates to cache documentation and Cache Tool.

2017-01-18 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1332 FreeBSD build *failed*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1343/ for details. --- If your project is set up for it, you can reply to this email and have your