Github user shukitchan commented on the issue:
https://github.com/apache/trafficserver/pull/776
I personally don't mind doing both. i.e. get this PR done right to merge
and also changing gzip plugin to support brotli. How does that sound?
---
If your project is set up for it, you
Github user shukitchan commented on the issue:
https://github.com/apache/trafficserver/pull/776
You can see @PSUdaemon comment above. That's pretty much the idea behind
the efforts of rewriting it to merge with gzip plugin.
---
If your project is set up for it, you can reply to
Github user bgaff commented on the issue:
https://github.com/apache/trafficserver/pull/776
Brotli and gzip are completely independent and given the chaining nature of
transformations id personally strongly favor seeing these as two separate
plugins. Whats the reasoning behind a
Github user shukitchan commented on the issue:
https://github.com/apache/trafficserver/pull/776
discussed with Bryan.
We will submit a PR that will change the gzip plugin instead of a separate
plugin like this PR.
---
If your project is set up for it, you can reply to this
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1332
clang-analyzer build *successful*! See
https://ci.trafficserver.apache.org/job/clang-analyzer-github/168/ for details.
---
If your project is set up for it, you can reply to this email
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1482
clang-analyzer build *successful*! See
https://ci.trafficserver.apache.org/job/clang-analyzer-github/167/ for details.
---
If your project is set up for it, you can reply to this email
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1332
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/linux-github/1498/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1332
Intel CC build *failed*! See
https://ci.trafficserver.apache.org/job/icc-github/36/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1332
FreeBSD build *failed*! See
https://ci.trafficserver.apache.org/job/freebsd-github/1604/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1482
Intel CC build *successful*! See
https://ci.trafficserver.apache.org/job/icc-github/35/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1482
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/linux-github/1497/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1482
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/freebsd-github/1603/ for details.
---
If your project is set up for it, you can reply to this email and have
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1482
clang-analyzer build *successful*! See
https://ci.trafficserver.apache.org/job/clang-analyzer-github/166/ for details.
---
If your project is set up for it, you can reply to this email
Github user jrushford commented on the issue:
https://github.com/apache/trafficserver/pull/1464
@zwoop All changes are in, see the commits.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1479
I like the elimination of that additional enum type, but I don't know
enough about the details in C++11 here to know what the impact are on
performance.
---
If your project is set up for it,
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1482
@SolidWallOfCode
```
$ make -h clang-format
```
AND, add the flipping script I wrote to your .git hooks :-/
---
If your project is set up for it, you can reply to
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1482
Intel CC build *successful*! See
https://ci.trafficserver.apache.org/job/icc-github/34/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1482
Linux build *failed*! See
https://ci.trafficserver.apache.org/job/linux-github/1496/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user SolidWallOfCode opened a pull request:
https://github.com/apache/trafficserver/pull/1482
MemView: Change typed array access method in MemView.
This makes the naming more STL style, improving usability.
You can merge this pull request into a Git repository by running:
Github user SolidWallOfCode commented on the issue:
https://github.com/apache/trafficserver/pull/1479
I think the implementation is significantly simpler, avoids more advanced
template techniques, and eliminates a type. It is also more easily expandable
in that the converters can
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1460
clang-analyzer build *successful*! See
https://ci.trafficserver.apache.org/job/clang-analyzer-github/165/ for details.
---
If your project is set up for it, you can reply to this email
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1460
Intel CC build *successful*! See
https://ci.trafficserver.apache.org/job/icc-github/33/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1460
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/freebsd-github/1601/ for details.
---
If your project is set up for it, you can reply to this email and have
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1460
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/linux-github/1495/ for details.
---
If your project is set up for it, you can reply to this email and have your
GitHub user ericcarlschwartz opened an issue:
https://github.com/apache/trafficserver/issues/1481
Log Field % always outputs "-"
Have been doing some testing with logging the cache key field % and
every log entry seems to simply be "-". Seeing this with 7.1.
---
If
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1460
@jpeach Thanks for the solid review! I'm going to push a second commit unto
this PR, so you can see the changes I made on top of this review. I'll squash
them before committing.
---
If your
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1460#discussion_r102559050
--- Diff: lib/wccp/Makefile.am ---
@@ -20,8 +20,8 @@
include $(top_srcdir)/build/tidy.mk
AM_CPPFLAGS = \
- -I$(abs_top_srcdir)/lib
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1471
clang-analyzer build *successful*! See
https://ci.trafficserver.apache.org/job/clang-analyzer-github/164/ for details.
---
If your project is set up for it, you can reply to this email
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1471
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/linux-github/1494/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1471
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/freebsd-github/1600/ for details.
---
If your project is set up for it, you can reply to this email and have
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1471
Intel CC build *successful*! See
https://ci.trafficserver.apache.org/job/icc-github/32/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1460#discussion_r102523151
--- Diff: proxy/Plugin.cc ---
@@ -231,8 +231,8 @@ plugin_init(bool validateOnly)
if (INIT_ONCE) {
api_init();
-
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1472
clang-analyzer build *successful*! See
https://ci.trafficserver.apache.org/job/clang-analyzer-github/163/ for details.
---
If your project is set up for it, you can reply to this email
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1471
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1473
Please run "make clang-format", and push again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1456
Yes, if there are subtle differences like this, we should break them out
accordingly, and then make an aggregated "sum" metrics in the Lua
metrics.config.
It almost sounds like a bug
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1472
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/freebsd-github/1599/ for details.
---
If your project is set up for it, you can reply to this email and have
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1472
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/linux-github/1493/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1472
Intel CC build *successful*! See
https://ci.trafficserver.apache.org/job/icc-github/31/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1473
Intel CC build *successful*! See
https://ci.trafficserver.apache.org/job/icc-github/30/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1473
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/freebsd-github/1598/ for details.
---
If your project is set up for it, you can reply to this email and have
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1473
Linux build *failed*! See
https://ci.trafficserver.apache.org/job/linux-github/1492/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1472
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1473
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1465
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/linux-github/1491/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1465
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/freebsd-github/1597/ for details.
---
If your project is set up for it, you can reply to this email and have
GitHub user dragon512 reopened a pull request:
https://github.com/apache/trafficserver/pull/1465
Add new testing system to the test subdirectory
First pass of new Testing system for Traffic server
Contain micro-server is the test/tools directory from the traffic-replay
work
Github user dragon512 closed the pull request at:
https://github.com/apache/trafficserver/pull/1465
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user dragon512 commented on the issue:
https://github.com/apache/trafficserver/pull/1465
This is just starter documentation.. We will move it to the official sphinx
doc later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user persiaAziz commented on the issue:
https://github.com/apache/trafficserver/pull/1465
Shouldn't the documentation be a inside the doc folder of ATS? Will this
show up on the traffic server website?
---
If your project is set up for it, you can reply to this email and have
Github user jrushford commented on the issue:
https://github.com/apache/trafficserver/issues/1427
@randall - what os are you using, i'll try to duplicate. can i see a
sample of your parent.config?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user ykopel commented on the issue:
https://github.com/apache/trafficserver/pull/1472
I tested it in my env. And I see it is grater than zero.
There are several lines before it that assume that "read_avail" is grater
than zero:
```
// Reset the inactivity timeout
52 matches
Mail list logo
