[GitHub] trafficserver pull request #1594: Early intervention APIs

2017-03-20 Thread SolidWallOfCode
Github user SolidWallOfCode commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1594#discussion_r107026702 --- Diff: proxy/InkAPI.cc --- @@ -9112,6 +9113,65 @@ TSSslContextDestroy(TSSslContext ctx) SSLReleaseContext(reinterpret_cast(ctx));

[GitHub] trafficserver pull request #1594: Early intervention APIs

2017-03-20 Thread SolidWallOfCode
Github user SolidWallOfCode commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1594#discussion_r107020509 --- Diff: iocore/net/SSLNetVConnection.cc --- @@ -1338,9 +1338,8 @@ SSLNetVConnection::sslClientHandShakeEvent(int ) } void

[GitHub] trafficserver issue #1594: Early intervention APIs

2017-03-20 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1594 clang-analyzer build *successful*! https://ci.trafficserver.apache.org/job/clang-analyzer-github/345/ --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1594: Early intervention APIs

2017-03-20 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1594 Intel CC build *successful*! https://ci.trafficserver.apache.org/job/icc-github/213/ --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] trafficserver issue #1594: Early intervention APIs

2017-03-20 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1594 Linux build *successful*! https://ci.trafficserver.apache.org/job/linux-github/1675/ --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] trafficserver issue #1594: Early intervention APIs

2017-03-20 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1594 FreeBSD11 build *successful*! https://ci.trafficserver.apache.org/job/freebsd-github/1782/ --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] trafficserver issue #1594: Early intervention APIs

2017-03-20 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1594 AU check *successful*! https://ci.trafficserver.apache.org/job/autest-github/84/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] trafficserver issue #1594: Early intervention APIs

2017-03-20 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1594 clang-analyzer build *successful*! https://ci.trafficserver.apache.org/job/clang-analyzer-github/344/ --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1594: Early intervention APIs

2017-03-20 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1594 RAT check *successful*! https://ci.trafficserver.apache.org/job/RAT-github/100/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] trafficserver issue #1594: Early intervention APIs

2017-03-20 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1594 clang format *successful*! https://ci.trafficserver.apache.org/job/clang-format-github/87/ --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] trafficserver issue #1594: Early intervention APIs

2017-03-20 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1594 Intel CC build *failed*! https://ci.trafficserver.apache.org/job/icc-github/212/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] trafficserver issue #1594: Early intervention APIs

2017-03-20 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1594 Linux build *failed*! https://ci.trafficserver.apache.org/job/linux-github/1674/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] trafficserver issue #1594: Early intervention APIs

2017-03-20 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1594 FreeBSD11 build *failed*! https://ci.trafficserver.apache.org/job/freebsd-github/1781/ --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] trafficserver issue #1594: Early intervention APIs

2017-03-20 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1594 AU check *successful*! https://ci.trafficserver.apache.org/job/autest-github/83/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] trafficserver issue #1594: Early intervention APIs

2017-03-20 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1594 clang format *failed*! https://ci.trafficserver.apache.org/job/clang-format-github/86/ --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] trafficserver issue #1594: Early intervention APIs

2017-03-20 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1594 RAT check *successful*! https://ci.trafficserver.apache.org/job/RAT-github/99/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] trafficserver issue #1599: Remove combohandler feature gate for 8.0 release

2017-03-20 Thread danobi
GitHub user danobi opened an issue: https://github.com/apache/trafficserver/issues/1599 Remove combohandler feature gate for 8.0 release I recently noticed `combohandler` was marking all of its generated documents as `Cache-Control: Public` regardless of what the requested

[GitHub] trafficserver issue #1598: Assertion failing when calling TSHttpTxnReenable ...

2017-03-20 Thread clearswift
Github user clearswift commented on the issue: https://github.com/apache/trafficserver/issues/1598 I've tried that (and quite a few different things) and had the same result. The example was intended to be as minimal as possible. There is an example plugin (examples/thread-1)

[GitHub] trafficserver pull request #1594: Early intervention APIs

2017-03-20 Thread persiaAziz
Github user persiaAziz commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1594#discussion_r106951005 --- Diff: proxy/InkAPI.cc --- @@ -9112,6 +9113,66 @@ TSSslContextDestroy(TSSslContext ctx) SSLReleaseContext(reinterpret_cast(ctx)); }

[GitHub] trafficserver pull request #1594: Early intervention APIs

2017-03-20 Thread SolidWallOfCode
Github user SolidWallOfCode commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1594#discussion_r106937502 --- Diff: proxy/InkAPI.cc --- @@ -9112,6 +9113,66 @@ TSSslContextDestroy(TSSslContext ctx) SSLReleaseContext(reinterpret_cast(ctx));

[GitHub] trafficserver issue #1598: Assertion failing when calling TSHttpTxnReenable ...

2017-03-20 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/issues/1598 You have to call `TSHttpTxnReenable` from an event thread. The typical pattern is to use `TSContSchedule` to bounce the call back over to the event thread pool once you are done. --- If

[GitHub] trafficserver issue #1598: Assertion failing when calling TSHttpTxnReenable ...

2017-03-20 Thread clearswift
GitHub user clearswift opened an issue: https://github.com/apache/trafficserver/issues/1598 Assertion failing when calling TSHttpTxnReenable from another thread. See the attached example plugin. This hooks onto the `TS_HTTP_READ_RESPONSE_HDR_HOOK` hook and, on that event, launches

[GitHub] trafficserver pull request #1548: Insure that parent health stats are update...

2017-03-20 Thread jrushford
Github user jrushford closed the pull request at: https://github.com/apache/trafficserver/pull/1548 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] trafficserver issue #1548: Insure that parent health stats are updated prope...

2017-03-20 Thread jrushford
Github user jrushford commented on the issue: https://github.com/apache/trafficserver/pull/1548 Should backport it to 7.1.0. Submitted an issue to refactor the duplicated code into a base class and will merge this pr. Thanks -- John J. Rushford IPCDN

[GitHub] trafficserver pull request #1594: Early intervention APIs

2017-03-20 Thread persiaAziz
Github user persiaAziz commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1594#discussion_r106927789 --- Diff: iocore/net/P_SSLNetVConnection.h --- @@ -295,7 +302,7 @@ class SSLNetVConnection : public UnixNetVConnection

[GitHub] trafficserver issue #1597: Refactor ParentRoundRobin and ParentConsistentHas...

2017-03-20 Thread jrushford
GitHub user jrushford opened an issue: https://github.com/apache/trafficserver/issues/1597 Refactor ParentRoundRobin and ParentConsistentHash policy's The ParentRoundRobin and ParentConsistentHash selection policies have functions that should be refactored into a base class as

[GitHub] trafficserver pull request #1516: Implement Cache-Control: immutable handlin...

2017-03-20 Thread shukitchan
Github user shukitchan closed the pull request at: https://github.com/apache/trafficserver/pull/1516 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the