shukitchan closed issue #10215: CID 1512901: Logically dead code
URL: https://github.com/apache/trafficserver/issues/10215
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
maskit opened a new issue, #10365:
URL: https://github.com/apache/trafficserver/issues/10365
fq_pacing.cc
```
62 f = TSfopen("/proc/sys/net/core/default_qdisc", "r");
1. Condition !f, taking false branch.
63 if (!f) {
64return 0;
65 }
66
2. identit
maskit opened a new issue, #10364:
URL: https://github.com/apache/trafficserver/issues/10364
IOBuffer.cc
```
80make_buffer_size_parser()
81{
82 using L = swoc::Lexicon;
CID 1518567 (#1 of 1): Big parameter passed by value (PASS_BY_VALUE)
pass_by_value: Capturing
maskit opened a new issue, #10363:
URL: https://github.com/apache/trafficserver/issues/10363
money_trace.cc
```
232bwriter.write(uuidstr, strlen(uuidstr));
233bwriter.write(sep);
234bwriter.write(parentid);
235bwriter.write(new_parent);
236
maskit opened a new issue, #10362:
URL: https://github.com/apache/trafficserver/issues/10362
intercept.cc
```
89 read(TSVConn vc, TSCont contp)
90 {
91TSReleaseAssert(this->vio == nullptr);
CID 1518570 (#1 of 1): Side effect in assertion (ASSERT_SIDE_EFFECT)
maskit opened a new issue, #10360:
URL: https://github.com/apache/trafficserver/issues/10360
CacheScan.h
```
45public:
46 CacheScan(Stripe *str, swoc::file::path const &path) : stripe(str)
47 {
1. Condition !path->empty(), taking false branch.
48if (!path.empty())
maskit opened a new issue, #10358:
URL: https://github.com/apache/trafficserver/issues/10358
```
48 switch (event) {
49 case TS_EVENT_NET_ACCEPT:
50/* Create a new mutex for the TxnSM, which is going
51 to handle the incoming request. */
52pmutex = TSMutexC
maskit opened a new issue, #10356:
URL: https://github.com/apache/trafficserver/issues/10356
NextHopConsistentHash.cc
```
342case NH_EXHAUST_RING:
343default:
const: At condition wrapped, the value of wrapped must be equal to 0.
dead_error_condition: The condi
maskit opened a new issue, #10355:
URL: https://github.com/apache/trafficserver/issues/10355
TSVConnFd.cc
```
484 class _Send_recv : private Send_to_vconn, private Recv_from_vconn
485 {
486 public:
487_Send_recv(TSVConn vconn_, std::shared_ptr f_del, int
n_groups_send,
maskit opened a new issue, #10353:
URL: https://github.com/apache/trafficserver/issues/10353
CacheScan.h
```
45public:
46 CacheScan(Stripe *str, swoc::file::path const &path) : stripe(str)
47 {
1. Condition !path->empty(), taking true branch.
48if (!path.empty())
maskit opened a new issue, #10352:
URL: https://github.com/apache/trafficserver/issues/10352
cache_fill.cc
```
69static bool
70cont_check_cacheable(TSHttpTxn txnp)
71{
1. Condition tsapi::c::TSHttpTxnIsInternal(txnp), taking false branch.
72 if (TSHttpTxnIsInternal
maskit opened a new issue, #10351:
URL: https://github.com/apache/trafficserver/issues/10351
traffic_server.cc
```
996static bool
997load_plugin(plugin_type_t plugin_type, const fs::path &plugin_path,
std::string &error)
998{
1. Switch case value plugin_type_t::GLOBAL.
maskit opened a new issue, #10349:
URL: https://github.com/apache/trafficserver/issues/10349
healthchecks.cc
```
CID 1518588 (#1 of 1): Out-of-bounds read (OVERRUN)
73. overrun-local: Overrunning array of 16368 bytes at byte offset 16383 by
dereferencing pointer event->name.
218
maskit opened a new issue, #10350:
URL: https://github.com/apache/trafficserver/issues/10350
healthchecks.cc
```
136 while (conf) {
137conf->wd = inotify_add_watch(fd, conf->fname, IN_DELETE_SELF |
IN_CLOSE_WRITE | IN_ATTRIB);
138TSDebug(PLUGIN_NAME, "Setting up a watche
maskit opened a new issue, #10348:
URL: https://github.com/apache/trafficserver/issues/10348
regex_revalidate.cc
```
438if (i->expiry <= i->epoch) {
439 TSDebug(PLUGIN_NAME, "Rule is already expired!");
440 free_invalidate_t(i);
CID 151858
maskit opened a new issue, #10347:
URL: https://github.com/apache/trafficserver/issues/10347
NextHopRoundRobin.cc
```
148} else { // if not available, check to see if it can be retried. If
so, set the retry flag and temporairly mark it as
149 // available.
150
maskit opened a new issue, #10346:
URL: https://github.com/apache/trafficserver/issues/10346
certifier.cc
```
417 /// If directory doesn't exist, create one
CID 1518591 (#1 of 1): Time of check time of use (TOCTOU)
1. fs_check_call: Calling function stat to perform check
maskit opened a new issue, #10344:
URL: https://github.com/apache/trafficserver/issues/10344
inliner-handler.cc
```
31namespace ats
32{
33namespace inliner
34{
35 Handler::Handler(const TSIOBufferReader r, ats::io::IOSinkPointer &&i)
CID 1518594 (#1 of 1):
maskit opened a new issue, #10343:
URL: https://github.com/apache/trafficserver/issues/10343
intercept.cc
```
88 void
89 read(TSVConn vc, TSCont contp)
90 {
91TSReleaseAssert(this->vio == nullptr);
CID 1518570: Side effect in assertion (ASSERT_SIDE_EFF
maskit opened a new issue, #10342:
URL: https://github.com/apache/trafficserver/issues/10342
intercept.cc
```
203static TSCont
204InterceptContCreate(TSEventFunc hook, TSMutex mutexp, void *data)
205{
206 TSCont contp;
207
CID 1518596 (#1 of 1): Side effect in a
maskit opened a new issue, #10341:
URL: https://github.com/apache/trafficserver/issues/10341
intercept.cc
```
98 void
99 write(TSVConn vc, TSCont contp)
100 {
101TSReleaseAssert(this->vio == nullptr);
CID 1518611: Side effect in assertion (ASSERT_SIDE_EF
maskit opened a new issue, #10340:
URL: https://github.com/apache/trafficserver/issues/10340
test_log_interface.cc
```
57 switch (event) {
58 case TS_EVENT_HTTP_READ_REQUEST_HDR:
59if (is_get_request(transaction)) {
60 const std::string long_line(5000, 's');
61
maskit opened a new issue, #10338:
URL: https://github.com/apache/trafficserver/issues/10338
NextHopHealthStatus.cc
```
130} else {
131 // if the last failure was outside the retry window, set the
failcount to 1 and failedAt to now.
132 { // lock guard
133
maskit opened a new issue, #10336:
URL: https://github.com/apache/trafficserver/issues/10336
```
405// if the parent is not available check to see if the retry
window has expired making it available
406// for retry.
407if (!pRec->available.load() && host_stat
maskit opened a new issue, #10335:
URL: https://github.com/apache/trafficserver/issues/10335
```
418 if (stat(path.c_str(), &st) == -1) {
CID 1518608 (#1 of 1): Unchecked return value from library (CHECKED_RETURN)
2. check_return: Calling mkdir(path.c_str(), 493U) without c
maskit opened a new issue, #10333:
URL: https://github.com/apache/trafficserver/issues/10333
```
98 void
99 write(TSVConn vc, TSCont contp)
100 {
101TSReleaseAssert(this->vio == nullptr);
CID 1518611 (#1 of 1): Side effect in assertion (ASSERT_SIDE_EFFECT)
a
maskit opened a new issue, #10331:
URL: https://github.com/apache/trafficserver/issues/10331
```
426close(ssnData->log_fd);
427std::error_code ec;
428swoc::file::file_status st =
swoc::file::status(ssnData->log_name, ec);
8. Condition !ec.operator boo
maskit opened a new issue, #10330:
URL: https://github.com/apache/trafficserver/issues/10330
```
2. Condition !regex_path->empty(), taking true branch.
7. Condition !regex_path->empty(), taking true branch.
1336if (!regex_path.empty()) {
8. identity_transfer: Passing
maskit opened a new issue, #10329:
URL: https://github.com/apache/trafficserver/issues/10329
```
188} else {
CID 1518615 (#1 of 1): Logically dead code (DEADCODE)
dead_error_begin: Execution cannot reach this statement:
lua_pushlightuserdata(L, tr
189 lua_pu
maskit opened a new issue, #10328:
URL: https://github.com/apache/trafficserver/issues/10328
```
76 // Associate our config file with remap.config to be able to initiate
reloads
77 TSMgmtString result;
78 const char *var_name = "proxy.config.url_remap.filename";
CI
30 matches
Mail list logo
