[jira] [Commented] (TS-1210) remove 3.0.x deprecated APIs

[ https://issues.apache.org/jira/browse/TS-1210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256718#comment-13256718 ] James Peach commented on TS-1210: - TSUrlDestroy() was deprecated in 3.1.x; we might want to k

[jira] [Commented] (TS-1079) Add an API function to turn debugging on for specific transactions/sessions

[ https://issues.apache.org/jira/browse/TS-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249591#comment-13249591 ] James Peach commented on TS-1079: - Hmm, Leif convinced me that the caller can't do the test.

[jira] [Commented] (TS-1079) Add an API function to turn debugging on for specific transactions/sessions

[ https://issues.apache.org/jira/browse/TS-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249589#comment-13249589 ] James Peach commented on TS-1079: - WRT bool: yep you are correct. WRT: TSDebugSpecific(), I

[jira] [Commented] (TS-1079) Add an API function to turn debugging on for specific transactions/sessions

[ https://issues.apache.org/jira/browse/TS-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247983#comment-13247983 ] James Peach commented on TS-1079: - My 2c When adding new TSAPI, please review on the de

[jira] [Commented] (TS-1147) deprecate records.config SSL configuration

[ https://issues.apache.org/jira/browse/TS-1147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245406#comment-13245406 ] James Peach commented on TS-1147: - Wow, trying to reply in line via email really doesn't work

[jira] [Commented] (TS-1147) deprecate records.config SSL configuration

[ https://issues.apache.org/jira/browse/TS-1147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245396#comment-13245396 ] James Peach commented on TS-1147: - Only the .filename options have been removed. I added

[jira] [Commented] (TS-1147) deprecate records.config SSL configuration

[ https://issues.apache.org/jira/browse/TS-1147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13244970#comment-13244970 ] James Peach commented on TS-1147: - I have a patch in my queue. > deprecate r

[jira] [Commented] (TS-1162) UnixNetVConnection.cc assertion when accepting a TLS connection

[ https://issues.apache.org/jira/browse/TS-1162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13240484#comment-13240484 ] James Peach commented on TS-1162: - Thanks. Yeh, that's deliberate, though in hindsight it

[jira] [Commented] (TS-1162) UnixNetVConnection.cc assertion when accepting a TLS connection

[ https://issues.apache.org/jira/browse/TS-1162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237705#comment-13237705 ] James Peach commented on TS-1162: - AFAICT, the calling VConnection has to hold the mutex and

[jira] [Commented] (TS-1162) UnixNetVConnection.cc assertion when accepting a TLS connection

[ https://issues.apache.org/jira/browse/TS-1162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237435#comment-13237435 ] James Peach commented on TS-1162: - But this doesn't make sense; reenable() handles the case w

[jira] [Commented] (TS-1162) UnixNetVConnection.cc assertion when accepting a TLS connection

[ https://issues.apache.org/jira/browse/TS-1162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237433#comment-13237433 ] James Peach commented on TS-1162: - Well I went back all the way to when NPN was first checked

[jira] [Commented] (TS-1135) support wildcard certificates for ServerNameIndication (SNI)

[ https://issues.apache.org/jira/browse/TS-1135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13233194#comment-13233194 ] James Peach commented on TS-1135: - RFC 6125 discusses how clients should match wildcard certs

[jira] [Commented] (TS-1152) http_ui error,when i get http://localhost/cache/

[ https://issues.apache.org/jira/browse/TS-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13233190#comment-13233190 ] James Peach commented on TS-1152: - I'm not sure if http_ui is still supported or known to be

[jira] [Commented] (TS-1146) RFC 5077 TLS Session tickets

[ https://issues.apache.org/jira/browse/TS-1146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13232154#comment-13232154 ] James Peach commented on TS-1146: - Also: https://github.com/apache/httpd/commit/414911a5

[jira] [Commented] (TS-1136) Expose Configuration API such that config files can be written (or scripted) in a glue-language such as Lua

[ https://issues.apache.org/jira/browse/TS-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13229856#comment-13229856 ] James Peach commented on TS-1136: - Since we already have Perl bindings for this, we could imp

[jira] [Commented] (TS-462) Support TLS Server Name Indication (SNI) negotiation

[ https://issues.apache.org/jira/browse/TS-462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13229854#comment-13229854 ] James Peach commented on TS-462: There's no configuration necessary. If SNI is supported by th

[jira] [Commented] (TS-462) Support TLS Server Name Indication (SNI) negotiation

[ https://issues.apache.org/jira/browse/TS-462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228937#comment-13228937 ] James Peach commented on TS-462: 75c6dd83c22cfdb04090db123a61c3e32d00b787 TS-462: Conditional

[jira] [Commented] (TS-1134) TSNetAcceptNamedProtocol should fail if NPN is not supported

[ https://issues.apache.org/jira/browse/TS-1134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228919#comment-13228919 ] James Peach commented on TS-1134: - 21b865093e44d55bb5055ba933c7c0b57b85f97e TS-1134: Update C

[jira] [Commented] (TS-462) Support TLS Server Name Indication (SNI) negotiation

[ https://issues.apache.org/jira/browse/TS-462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228217#comment-13228217 ] James Peach commented on TS-462: I wrote a quick test program and the hash table is faster and

[jira] [Commented] (TS-1087) TSHttpTxnOutgoingAddrSet forward declaration does not match implementation

[ https://issues.apache.org/jira/browse/TS-1087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225741#comment-13225741 ] James Peach commented on TS-1087: - I don't see socklen_t anywhere in ts.h. I think that a wel

[jira] [Commented] (TS-406) manual for traffic shell not installed during "make install"

[ https://issues.apache.org/jira/browse/TS-406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13223987#comment-13223987 ] James Peach commented on TS-406: traffic_shell online help was implemented in TS-1097. We stil

[jira] [Commented] (TS-1087) TSHttpTxnOutgoingAddrSet forward declaration does not match implementation

[ https://issues.apache.org/jira/browse/TS-1087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13223986#comment-13223986 ] James Peach commented on TS-1087: - Bart, maybe a better approach is to change the implementat

[jira] [Commented] (TS-462) Support TLS Server Name Indication (SNI) negotiation

[ https://issues.apache.org/jira/browse/TS-462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222475#comment-13222475 ] James Peach commented on TS-462: And to clarify ... SNI will be enabled automatically if it's

[jira] [Commented] (TS-462) Support TLS Server Name Indication (SNI) negotiation

[ https://issues.apache.org/jira/browse/TS-462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222472#comment-13222472 ] James Peach commented on TS-462: Assign to me since I'm working on this. > Su

[jira] [Commented] (TS-462) Support TLS Server Name Indication (SNI) negotiation

[ https://issues.apache.org/jira/browse/TS-462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220164#comment-13220164 ] James Peach commented on TS-462: I think I'd rather deal with this in a separate JIRA. Maybe

[jira] [Commented] (TS-462) Support TLS Server Name Indication (SNI) negotiation

[ https://issues.apache.org/jira/browse/TS-462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220086#comment-13220086 ] James Peach commented on TS-462: What's SAN? > Support TLS Server Name Ind

[jira] [Commented] (TS-462) Support TLS Server Name Indication (SNI) negotiation

[ https://issues.apache.org/jira/browse/TS-462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13219799#comment-13219799 ] James Peach commented on TS-462: It seems like you ought to be able to pull the hostname out o

[jira] [Commented] (TS-961) Extend TS API to support TSNetAccept with inbound transparency

[ https://issues.apache.org/jira/browse/TS-961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13201754#comment-13201754 ] James Peach commented on TS-961: Hey Alan, I was thinking about this in the context of allowi

[jira] [Commented] (TS-341) Update Contrib Scripts

[ https://issues.apache.org/jira/browse/TS-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13199525#comment-13199525 ] James Peach commented on TS-341: Hey Jason, the traffic server repo switched to git the other

[jira] [Commented] (TS-1084) enable compile-time format string checking

[ https://issues.apache.org/jira/browse/TS-1084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13197579#comment-13197579 ] James Peach commented on TS-1084: - Commit 9b3bae3644bc302aa7587b225bb4340b52219436 and follow

[jira] [Commented] (TS-1083) initial SSL next protocol negotiation support

[ https://issues.apache.org/jira/browse/TS-1083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13193110#comment-13193110 ] James Peach commented on TS-1083: - Let's just leave the patch as it. It's overkill but harmle

[jira] [Commented] (TS-1083) initial SSL next protocol negotiation support

[ https://issues.apache.org/jira/browse/TS-1083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13192268#comment-13192268 ] James Peach commented on TS-1083: - Ah, I just didn't notice that there was a OPENSSL_NPN_NEGO

[jira] [Commented] (TS-1045) PATCH: add new TSFetchHdrGet API

[ https://issues.apache.org/jira/browse/TS-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13182343#comment-13182343 ] James Peach commented on TS-1045: - Let's WONTFIX this one. The TSFetchUrl API is a bit weird

[jira] [Commented] (TS-1070) replace and deprecate TSFetchURL()

[ https://issues.apache.org/jira/browse/TS-1070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13182335#comment-13182335 ] James Peach commented on TS-1070: - I'll take it. > replace and deprecate TSF

[jira] [Commented] (TS-1041) PATCH: guarantee to populate sockaddr length for TSHostLookupResultAddrGet

[ https://issues.apache.org/jira/browse/TS-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181520#comment-13181520 ] James Peach commented on TS-1041: - I never knew that sa_len and friends was a BSD-ism. Will n

[jira] [Commented] (TS-1043) PATCH: teach TSFetchUrl to use the content-length to find the after_body event

[ https://issues.apache.org/jira/browse/TS-1043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181149#comment-13181149 ] James Peach commented on TS-1043: - TSFetchRespGet() returns different results depending on wh

[jira] [Commented] (TS-1045) PATCH: add new TSFetchHdrGet API

[ https://issues.apache.org/jira/browse/TS-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13179304#comment-13179304 ] James Peach commented on TS-1045: - Looks like I'm carrying a local patch that breaks TSFetchR

[jira] [Commented] (TS-1043) PATCH: teach TSFetchUrl to use the content-length to find the after_body event

[ https://issues.apache.org/jira/browse/TS-1043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13179297#comment-13179297 ] James Peach commented on TS-1043: - Sigh. This patch breaks TSFetchRespGet() by making it retu

[jira] [Commented] (TS-1045) PATCH: add new TSFetchHdrGet API

[ https://issues.apache.org/jira/browse/TS-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13178266#comment-13178266 ] James Peach commented on TS-1045: - TSFetchPageRespGet() takes a HTTPHdr * and returns a TSMBu

[jira] [Commented] (TS-1062) TSFetchUrl doesn't handle chunked encoding

[ https://issues.apache.org/jira/browse/TS-1062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13177909#comment-13177909 ] James Peach commented on TS-1062: - This is another instance of events failing to be delivered

[jira] [Commented] (TS-841) Refactor SSL code to make it possible to perform NPN negotiation without entering the HTTP SM

[ https://issues.apache.org/jira/browse/TS-841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13177764#comment-13177764 ] James Peach commented on TS-841: >From IRC discussion: 6:17pm] zwoop: but, not sure it should

[jira] [Commented] (TS-254) Add TSEscapifyString() and TSUnescapifyString()

[ https://issues.apache.org/jira/browse/TS-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13174580#comment-13174580 ] James Peach commented on TS-254: FWIW, wikipedia and RFC 3986 refer to it as "Percent-Encoding

[jira] [Commented] (TS-254) Add TSEscapifyString() and TSUnescapifyString()

[ https://issues.apache.org/jira/browse/TS-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172902#comment-13172902 ] James Peach commented on TS-254: My 2c ... can we choose better names for this API? For exampl

[jira] [Commented] (TS-912) TSFetchURL - poor performance

[ https://issues.apache.org/jira/browse/TS-912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13168707#comment-13168707 ] James Peach commented on TS-912: I believe that this happens when the whole response is delive

[jira] [Commented] (TS-1045) PATCH: add new TSFetchHdrGet API

[ https://issues.apache.org/jira/browse/TS-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13168530#comment-13168530 ] James Peach commented on TS-1045: - Oh, does TSFetchPageRespGet() return the whole response ob

[jira] [Commented] (TS-1040) PATCH: teach TSHostLookup to use const

[ https://issues.apache.org/jira/browse/TS-1040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13166334#comment-13166334 ] James Peach commented on TS-1040: - Yep I meant to click the donate button but forgot. I didn'

[jira] [Commented] (TS-1041) PATCH: guarantee to populate sockaddr length for TSHostLookupResultAddrGet

[ https://issues.apache.org/jira/browse/TS-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13166332#comment-13166332 ] James Peach commented on TS-1041: - I was referring to the sockaddr you get from TSHostLookupR

[jira] [Commented] (TS-1042) PATCH: correct debug message in FetchSM

[ https://issues.apache.org/jira/browse/TS-1042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13166330#comment-13166330 ] James Peach commented on TS-1042: - To be honest, it's mostly from habit. However "%*.*s" prin

[jira] [Commented] (TS-1045) PATCH: add new TSFetchHdrGet API

[ https://issues.apache.org/jira/browse/TS-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165819#comment-13165819 ] James Peach commented on TS-1045: - Nope, my example is definitely a TSFetchURL() request. The

[jira] [Commented] (TS-1045) PATCH: add new TSFetchHdrGet API

[ https://issues.apache.org/jira/browse/TS-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13164988#comment-13164988 ] James Peach commented on TS-1045: - Thanks Brian, I'll test that out and let you know. AFAICT